@heroiclands/package-build 3.3.0 → 4.0.0

package/CHANGELOG.md

@@ -1,5 +1,184 @@
 # @heroiclands/package-build
 
+## 4.0.0
+
+### Major Changes
+
+- 8cfa834: Reject `package:` in a note's frontmatter (#56).
+  
+  A note's package is the repository's configured `contentPackage`, full stop. A
+  note that declares the field fails the build, naming the file — **whatever the
+  value says**. An agreeing declaration is refused exactly as a disagreeing one
+  is: there is no value that makes writing the field correct, and a field accepted
+  while it agrees is a field that grows back one note at a time.
+  
+  ```text
+  assets/content/Gear/Axe.md:12:1: error: `package: sohl` is a retired frontmatter field — delete it. A note's package is this repository's configured `contentPackage` ("sohl", in package-build.config.yaml), and every note in the tree belongs to it.
+  ```
+  
+  `content-build lint` reports every such note in one pass, so a tree can be
+  checked before it is compiled; `package compile` and `manifest` refuse it.
+  
+  **This is the third and last step**, and the two before it are already released
+  and adopted. 3.3.0 made the field optional so an absent one was normal and a
+  disagreeing one was an error; every content tree on the org was then swept on
+  that version — `sohl` (1,639 files), `thalorna` (1,716), `kethira` (363),
+  `harnensemble` (2,517). Nothing this release refuses is authored anywhere today.
+  
+  **Why a major.** Consumers resolve `^3`, so a minor would reach every repository
+  on the next Dependabot run. A major is adopted deliberately, one repository at a
+  time, in a pull request that can also delete the field if any grew back — which
+  is the whole mechanism that made the deprecate → migrate → remove sequence safe.
+  
+  **Migrating** is one line, and nothing else reads the field:
+  
+  ```bash
+  find assets/content -name '*.md' -print0 | xargs -0 sed -i '' '/^package: /d'
+  ```
+  
+  `package compile` then produces byte-identical output, because the value the
+  build derives is the value the notes restated. See `MIGRATING.md`.
+  
+  **`contentPackage` is unaffected, and is not vestigial.** It is the address
+  namespace — the first segment of every canonical key, the name of the emitted
+  link manifest, and the package a cross-package wikilink writes. Retiring the
+  frontmatter field is what leaves it as the single source of that value: every
+  key is now derived from the configuration, where it used to come from two
+  sources that happened to agree.
+  
+  **A generated table's `WHERE … and package = "<pkg>"` clause keeps matching** —
+  45 such clauses across `sohl` and `thalorna` depend on it. The package is
+  _synthesised_ into what the table search sees, from `contentPackage`; it is a
+  search value, never an authored one.
+  
+  **API.** `engine/note-package.mjs` no longer exports `notePackage` — every call
+  site takes `contentPackage` directly, so no key is derived from frontmatter
+  anywhere — and `assertNotePackage` is now `assertNoDeclaredPackage`, which
+  asserts the field's absence rather than answering which package a note belongs
+  to. `expandNoteTables` no longer takes `pkg`: a table searches the whole tree,
+  which is one package's notes and nothing else.
+- ad7691f: Remove `draft:` from a note's frontmatter (#69).
+  
+  The field excluded a note from the compiled packs, from the link manifest and
+  from a consuming site build — and **nothing reported the consequence**.
+  `content-links.mjs`, `site-index.mjs` and `content-lint.mjs` never read it, so a
+  wikilink into a drafted note was indistinguishable from a link to a note that
+  does not exist, and no checker could say which. Its entire effect was to move a
+  note from _published_ to _unresolvable_, in silence. It also suppressed real
+  build failures: a note the compilers never reached could not fail on the defects
+  it carried.
+  
+  Nothing used it. Across every HeroicLands content repository — `sohl`,
+  `sohl-thalorna`, `sohl-kethira-basic`, `harn-ensemble`, `harn-adventures` — not
+  one note declared it.
+  
+  **What changed**
+  
+  - The three readers are gone: the compile loop, the link-manifest walk, and the
+    scenes pass's map collection. So are the `skippedDraft` tally, its `PassStats`
+    field, and the `Skipped N draft(s)` log line.
+  - A note declaring `draft:` now **fails the build**, naming the file and the
+    line, whatever the value says — `draft: false` included, since it reads as
+    "publish this note", which is what happens either way. A field left merely
+    ignored reads to its author as though it still works, which is the same
+    silence in a different place.
+  - `content-build lint` reports it too, so a whole tree is answered at once
+    rather than one note per build.
+  
+  **The `draft` _tag_ is untouched.** It is an authoring marker, read only by the
+  generated-table pass for `FROM #draft` queries, and 268 `sohl-thalorna` notes
+  carry it. An unfinished page is honest about being unfinished; a dropped link is
+  silent.
+  
+  **Adopting**
+  
+  Nothing to sweep — no note in the org declares the field. A consumer that
+  carries one deletes the line.
+  
+  This lands in the same major as the `package:` rejection (#56 step 3), so the
+  two retired fields are one adoption rather than two. They are refused the same
+  way, through the same diagnostic format and the same positioning, and the
+  locator both need is now shared rather than written twice.
+
+## 3.4.0
+
+### Minor Changes
+
+- 19df269: Stop emitting `assocMysteryCode` on a compiled mystical ability (#35).
+  
+  The `mysticalability` declaration named a field no SoHL DataModel receives.
+  `MysticalAbilityDataModel` declares `subType`, `assocSkillCode`,
+  `assocAffiliationCode`, `masteryLevelBase`, `improveFlag`, `levelBase` and
+  `charges`, and nothing else — Foundry discards the extra key when the document
+  is constructed, so every mystical ability in every consuming pack shipped a
+  value that was thrown away at load, with nothing at compile or load time saying
+  so.
+  
+  This is the exact inverse of #3 and has the same root cause: nothing compares a
+  builder's emitted `system` block against the DataModel that receives it. #3 was a
+  declared field the builder failed to emit; this is an emitted field the DataModel
+  never declares. Both compile clean, both lose data silently, and an author cannot
+  tell either from a correct build. The general check is #60.
+  
+  **The field was retired, not renamed.**
+  Song-of-Heroic-Lands-FoundryVTT#973 deleted `assocMysteryCode` because nothing in
+  production read the mystery it resolved to; #1012 later added
+  `assocAffiliationCode` as a separate concept — the faction whose standing confers
+  the ability. They look alike and mean different things, so the declaration is
+  dropped rather than retargeted.
+  
+  **This changes emitted documents**, so a consumer wants a rebuild rather than a
+  silent upgrade — though nothing downstream can have depended on the value:
+  
+  - `sohl` — nine notes authored the key, all of them blank. Corrected in
+    Song-of-Heroic-Lands-FoundryVTT#1747.
+  - `sohl-kethira-basic` — no note authors it; all 224 mystical abilities carried
+    the builder's own `""`. Recompiling `main` with this change removes exactly
+    those 224 lines and touches nothing else.
+- dced8b2: Write the derived package into an emitted page's frontmatter (#65).
+  
+  `content-build site` copied a note's frontmatter to the page verbatim. Since
+  3.3.0 a note need not declare `package:` — it is derived from the configured
+  `contentPackage` — and `engine/site-build.mjs` resolved that value one line
+  before it built the page, carrying it for the index, the table universe and the
+  local-package set. It never reached the page's own frontmatter, so a swept tree
+  published pages that said nothing about which package they belong to.
+  
+  **The visible symptom is the breadcrumb.**
+  `@heroiclands/hugo-theme`'s `layouts/partials/breadcrumbs.html` reads
+  `{{ $pkg := .Params.package | default "" }}` and builds the middle crumb from
+  it. With no `package` the section is never resolved and the crumb degrades from
+  a linked, labelled section to a bare, unlinked type slug:
+  
+  ```text
+  before: Home > SoHL Affliction > Aconite   (linked)
+  after:  Home > affliction       > Aconite   (bare)
+  ```
+  
+  Consumer layouts reading the field directly degrade the same way — a `package`
+  column renders blank.
+  
+  The fix is where the value was already known: `pageFrontmatter` spreads
+  `package` after the note's own frontmatter, so a note that declares the field
+  keeps its authored position and value and an unswept tree emits byte-identically,
+  while a swept one regains the line it lost. The alternative — teaching every
+  theme and consumer layout to default the package from a site parameter — pushes
+  a fact the build already knows out to N consumers, and the theme deliberately
+  carries no addresses.
+  
+  **This changes emitted output**, so a consumer wants a rebuild rather than a
+  silent upgrade, which is why it is a minor rather than a patch — the same
+  reasoning as #35. Verified against the swept `sohl` tree: 1,606 emitted content
+  pages differ, none added or removed, and the only diff line class across the
+  whole tree is the restored `package: sohl`. Rendering that tree, 1,600 pages
+  differ and in exactly two ways — the breadcrumb's middle crumb, and a `package`
+  column that was blank.
+  
+  `sohl-thalorna` has the same defect independently, in its own
+  `utils/build-site-content.mjs`, and is fixed in that repository
+  (sohl-thalorna#79) — two emitters, one behaviour, which is a second argument
+  for #36.
+
 ## 3.3.0
 
 ### Minor Changes

package/CONTENT.md

@@ -178,27 +178,44 @@ something migrates on it.
 ### A note's package is the repository's, not the note's
 
 `contentPackage` is the **address namespace** every note in the tree is
-published under. It is not a filter, and a note does not restate it.
+published under: the first segment of every canonical key (`sohl-skill-clmb`),
+the name of the link manifest this build emits (`sohl.json`), and the package a
+cross-package wikilink writes to reach one of these notes. It is the
+repository's identity in the address space — not a filter — and a note does not
+restate it.
+
+**`package:` in a note's frontmatter is retired, and declaring it fails the
+build**, naming the file, whatever the value says. An agreeing declaration is
+refused exactly as a disagreeing one is: there is no value that makes writing
+the field correct. The diagnostic says so, and says where the value comes from
+instead:
 
-A note may still carry `package:` — every note written before this did — and it
-is accepted while it **agrees** with `contentPackage`. One that disagrees is an
-error naming the file, in the compile, in the link manifest, and anywhere else
-a note is read. The field is redundant, and it is being retired in three steps:
-optional now, swept out of every content tree on this version, and rejected
-outright in a later major.
+```text
+assets/content/Gear/Axe.md:12:1: error: `package: sohl` is a retired frontmatter field — delete it. A note's package is this repository's configured `contentPackage` ("sohl", in package-build.config.yaml), and every note in the tree belongs to it.
+```
+
+`content-build lint` reports every such note in one pass; `content-build
+package compile` and `content-build manifest` refuse the tree.
 
 A generated table that scopes itself with `WHERE … and package = "<pkg>"` keeps
-working either way: a note's package is supplied to the table search whether or
-not the note declares it, so deleting the field never turns a table into an
-empty one.
+working: the package is **synthesised** into what the table search sees,
+supplied from `contentPackage` rather than read off the note. It is a search
+value, never an authored one.
 
 It used to **select**: a note compiled when its `package:` matched and was
 skipped when it did not. Every content tree is single-package — each is
 single-sourced in the repository that ships it — so the field restated one
 constant thousands of times, while a tree whose notes named a package no
 configuration answered to compiled **zero notes and exited 0**. Deleting the
-field from a note is safe on this version and is the fix; deleting the
-_configured_ value is not, since every address derives from it.
+field from a note is the fix; deleting the _configured_ value is not, since
+every address derives from it.
+
+Sweeping a tree is mechanical — the field is a whole line, and nothing else
+reads it:
+
+```bash
+find assets/content -name '*.md' -print0 | xargs -0 sed -i '' '/^package: /d'
+```
 
 ### A registry of your own
 

package/MIGRATING.md

@@ -1,3 +1,50 @@
+# Migrating to `@heroiclands/package-build` 4.0.0
+
+**One authoring change: delete `package:` from every content note.** A note's
+package is the repository's configured `contentPackage`, and declaring the field
+is now a build error rather than a redundancy the build tolerated.
+
+## 1. Sweep the content tree
+
+The field is a whole line, and nothing else reads it:
+
+```bash
+find assets/content -name '*.md' -print0 | xargs -0 sed -i '' '/^package: /d'
+```
+
+(GNU `sed`: `sed -i '/^package: /d'`.) Then compile — `content-build package
+compile` must produce byte-identical output to the run before the sweep, because
+the value the build derives is the value the notes restated.
+
+A note that still carries the field fails the build where it is:
+
+```text
+assets/content/Gear/Axe.md:12:1: error: `package: sohl` is a retired frontmatter field — delete it. A note's package is this repository's configured `contentPackage` ("sohl", in package-build.config.yaml), and every note in the tree belongs to it.
+```
+
+`content-build lint` reports every one of them in a single pass, so the sweep can
+be checked before it is compiled.
+
+## 2. Nothing else
+
+- **`contentPackage` stays**, and is unchanged. It is the address namespace —
+  the first segment of every canonical key, the name of the emitted link
+  manifest, and the package a cross-package wikilink writes. Every address in
+  every manifest is identical across this upgrade.
+- **A generated table's `WHERE … and package = "<pkg>"` clause keeps matching.**
+  The package is synthesised into what the table search sees, from
+  `contentPackage`; it was never the authored field that answered the clause
+  after 3.3.0.
+- **No configuration key changed**, and no CLI command, flag or exit code.
+
+## What this replaced
+
+A note used to be _selected_ by the field: it compiled when `package:` matched
+`contentPackage` and was skipped, silently and as "belongs to another pass",
+when it did not. A tree whose notes named a package no configuration answered to
+compiled **zero notes and exited 0** (#56). 3.3.0 made the field optional so
+every repository could be swept on a non-breaking version; this major removes it.
+
 # Migrating to `@heroiclands/package-build` 3.0.0
 
 `@heroiclands/content-build` and `@heroiclands/package-build` are one package.

package/engine/base-compiler.mjs

@@ -14,9 +14,9 @@
 /**
  * `BasePackCompiler` — the one compile loop every pack pass runs.
  *
- * Walking the content tree, rejecting what this build does not own, skipping
- * drafts, expanding generated tables, converting wikilinks, writing the JSON
- * and counting what failed are the same in every pass. They were written out
+ * Walking the content tree, rejecting what this build does not own, expanding
+ * generated tables, converting wikilinks, writing the JSON and counting what
+ * failed are the same in every pass. They were written out
  * once per pass — three times when this was filed, five by the time it landed —
  * so a fix to any of them had to be made everywhere, and the passes drifted
  * apart in exactly the places nobody was comparing (#1509).
@@ -73,26 +73,25 @@ import {
     expandNoteTables,
 } from "./helpers.mjs";
 import { emitDiagnostic } from "./diagnostics.mjs";
-import { contentPackage } from "./content-package.mjs";
-import { assertNotePackage } from "./note-package.mjs";
+import { assertNoDeclaredPackage } from "./note-package.mjs";
+import { assertNoDraftField } from "./retired-fields.mjs";
 import { assertTypeNotRetired, packForType } from "./ids.mjs";
 
 /**
  * The tallies one pass accumulates while walking the tree.
  *
  * `declined` and `skippedOther` are deliberately separate numbers. A declined
- * note is one this build **refused** — it names a package this repository does
- * not compile — and it is an error; a skipped one legitimately belongs to
- * another pass, and there are thousands of those. Folding the first into the
- * second is what let a whole tree be filtered out in silence (#56).
+ * note is one this build **refused** — it declares a retired frontmatter field
+ * — and it is an error; a skipped one legitimately belongs to another pass, and
+ * there are thousands of those. Folding the first into the second is what let a
+ * whole tree be filtered out in silence (#56).
  *
  * @typedef {object} PassStats
  * @property {number} compiled - Notes that became a document.
- * @property {number} skippedDraft - Notes marked `draft: true`.
  * @property {number} skippedNoId - Notes with no `id`, where that is tolerated.
  * @property {number} skippedOther - Notes this pass does not claim.
- * @property {number} declined - Notes refused because they declare another
- *   package. Counted as errors, never as skips.
+ * @property {number} declined - Notes refused because they declare a retired
+ *   frontmatter field. Counted as errors, never as skips.
  */
 
 /**
@@ -336,9 +335,6 @@ export class BasePackCompiler {
         const { markdown: tabulated, lineMap } = expandNoteTables(body, {
             docs: this.contentDocs,
             name,
-            // The repository's package, not the note's: every note in the tree
-            // is this package's note, whether or not it says so (#56).
-            pkg: contentPackage(),
             fm,
             bodyLine,
         });
@@ -512,15 +508,13 @@ export class BasePackCompiler {
         if (stats.skippedNoId) {
             log.info(`Skipped ${stats.skippedNoId} note(s) missing id`);
         }
-        if (stats.skippedDraft) {
-            log.info(`Skipped ${stats.skippedDraft} draft(s)`);
-        }
         if (stats.declined) {
             // Its own line, at error level: these are not skips, and burying
             // them in the skipped tally is the defect (#56). Each one has
             // already been named individually as a diagnostic.
             log.error(
-                `Declined ${stats.declined} note(s) declaring another package`,
+                `Declined ${stats.declined} note(s) declaring a retired ` +
+                    `frontmatter field`,
             );
         }
         this.reportDetail(stats);
@@ -535,7 +529,6 @@ export class BasePackCompiler {
         /** @type {PassStats} */
         const stats = {
             compiled: 0,
-            skippedDraft: 0,
             skippedNoId: 0,
             skippedOther: 0,
             declined: 0,
@@ -560,18 +553,27 @@ export class BasePackCompiler {
                 stats.skippedOther++;
                 continue;
             }
-            // The package a note belongs to is this repository's configured
-            // one; `package:` is optional and merely has to agree (#56). A
-            // disagreement is reported and counted as an error — never skipped,
-            // which is how a tree naming a package nothing answers to used to
-            // compile zero notes and exit 0. The file comes from the diagnostic
-            // locator, so the message must not repeat it.
+            // The retired frontmatter fields, refused before `selects` so a
+            // note is answered whichever pass would have claimed it — and
+            // whatever the declared value says.
+            //
+            // - `package:` (#56): a note's package is the repository's
+            //   configured one, so declaring it restates a constant.
+            // - `draft:` (#69): it excluded the note from the packs, the
+            //   manifest and the site, and no checker reported the links that
+            //   left dangling.
+            //
+            // Both are reported and counted — never skipped, which is how a
+            // tree naming a package nothing answers to used to compile zero
+            // notes and exit 0. The file comes from the diagnostic locator, so
+            // neither message may repeat it.
             try {
-                assertNotePackage(fm);
+                assertNoDeclaredPackage(fm, { absPath });
+                assertNoDraftField(fm, { absPath });
             } catch (err) {
                 stats.declined++;
                 this.errorCount++;
-                this.noteError(err.message);
+                this.noteError(err.message, err.position);
                 continue;
             }
             // Checked before `selects`, and therefore for every note this
@@ -584,11 +586,6 @@ export class BasePackCompiler {
                 stats.skippedOther++;
                 continue;
             }
-            if (fm.draft === true) {
-                stats.skippedDraft++;
-                log.debug(`Skipping draft: ${absPath}`);
-                continue;
-            }
             if (!fm.id) {
                 if (this.constructor.requiresId) {
                     throw new Error(`${Label} missing id: ${absPath}`);
@@ -597,9 +594,9 @@ export class BasePackCompiler {
                 this.noteWarn(`${label} note has no id, skipping`);
                 continue;
             }
-            // Which pack of this type takes it. Applied after the draft and
-            // id checks — a draft is not compiled anywhere, so its declaration
-            // is nobody's business — and before `skipNote`, so a note this pack
+            // Which pack of this type takes it. Applied after the id check —
+            // a note with no id is nobody's document, so its routing is
+            // nobody's business — and before `skipNote`, so a note this pack
             // does not own never reaches this pass's own rejection rules.
             try {
                 if (!this.routesHere(fm)) {

package/engine/content-links.mjs

@@ -52,7 +52,8 @@ import { matchAllOutsideCode } from "./code-fences.mjs";
 import { expandContentTables } from "./content-tables.mjs";
 import { walkMarkdownTree } from "./helpers.mjs";
 import { hasDocEntry } from "./item-docs.mjs";
-import { notePackage, searchableFrontmatter } from "./note-package.mjs";
+import { contentPackage } from "./content-package.mjs";
+import { searchableFrontmatter } from "./note-package.mjs";
 import {
     canonicalKey,
     loadForeignManifests,
@@ -130,12 +131,13 @@ export function buildLinkIndex(
     const byAlias = new Map();
     const aliasCollide = new Set();
 
+    // The one package every note in this tree belongs to. Taken from the
+    // configuration, never from a note: `package:` is retired, so there is no
+    // second source an address could disagree with (#56).
+    const pkg = contentPackage();
+
     for (const note of notes) {
         const { fm, type } = note;
-        // Derived, never read out of frontmatter: `package:` is optional, and a
-        // note that declares nothing addresses exactly as one that declares the
-        // configured package (#56).
-        const pkg = notePackage(fm);
         if (typeof fm.shortcode === "string" && fm.shortcode) {
             byKey.set(`${type}/${fm.shortcode}`.toLowerCase(), note);
             // The canonical, fully qualified address alongside the short one,
@@ -170,7 +172,7 @@ export function buildLinkIndex(
     // A foreign package may use a type this tree has never seen, so its types
     // join `types` — otherwise `readQualifier` reads the link as prose and it
     // is never checked at all.
-    const localPackages = new Set(notes.map((n) => notePackage(n.fm)));
+    const localPackages = new Set([pkg]);
     const foreign =
         manifestDir ?
             loadForeignManifests(manifestDir, localPackages)
@@ -178,15 +180,15 @@ export function buildLinkIndex(
     for (const v of foreign.index.values()) if (v.type) types.add(v.type);
 
     const packages = new Set([
-        ...[...byKey.values()].map((n) => notePackage(n.fm)),
+        ...(byKey.size ? [pkg] : []),
         ...foreign.packages,
     ]);
 
     /** The searchable universe a `dataview` table draws its rows from. */
     const tableDocs = notes.map((n) => ({
-        // Package present however the note spells it — see
-        // {@link searchableFrontmatter} (#56).
-        fm: searchableFrontmatter(n.fm),
+        // Package present for a `WHERE … package = "…"` clause, synthesised
+        // rather than authored — see {@link searchableFrontmatter} (#56).
+        fm: searchableFrontmatter(n.fm, pkg),
         path: n.rel,
         tld: n.rel.split("/")[0],
         folder: path.dirname(n.rel).split("/").pop(),
@@ -205,9 +207,9 @@ export function buildLinkIndex(
         let body = note.body;
         if (/^[ \t]*(?:`{3,}|~{3,})[ \t]*dataview\b/im.test(body)) {
             body = expandContentTables(body, {
-                docs: tableDocs.filter(
-                    (d) => notePackage(d.fm) === notePackage(note.fm),
-                ),
+                // Unfiltered: every note in the tree is this package's, so
+                // there is no other package's note to exclude (#56).
+                docs: tableDocs,
                 linkable: (d) => Boolean(d.fm.shortcode),
                 source: note.file,
             }).markdown;

package/engine/content-package.mjs

@@ -38,8 +38,9 @@ import { loadPackConfig } from "./pack-config.mjs";
  * `package:` frontmatter and the compilers kept the ones that matched. Every
  * content tree is single-package — each is single-sourced in the repository that
  * ships it — so the field restated this constant once per note while a value
- * that matched nothing filtered the whole tree out in silence. The field is
- * being retired; the value stays, here, where it is declared once.
+ * that matched nothing filtered the whole tree out in silence. That field is
+ * retired and declaring it now fails the build; this value stays, here, where
+ * it is declared once.
  *
  * Stable across compilation targets. If this content were ever compiled for a
  * second game system, it would still be published as `sohl` — only the Foundry

package/engine/field-reference.mjs

@@ -147,8 +147,8 @@ function workedExample(type, fields) {
         `type: ${type}`,
         "shortcode: xmpl",
         // No `package:`. A note's package is the repository's configured
-        // `contentPackage`, so the field is redundant and is being retired
-        // (#56) — and this example is the smallest note that compiles.
+        // `contentPackage`, and declaring the field is a build error (#56) —
+        // this example is the smallest note that compiles.
         "id: <16-character id>",
         "sohl:",
         "  archetype: null",

package/engine/frontmatter-lint.mjs

@@ -51,6 +51,7 @@
 import { authoredFields } from "./field-spec.mjs";
 import { positionInFrontmatter } from "./diagnostics.mjs";
 import { RETIRED_TYPES } from "./ids.mjs";
+import { draftRetiredMessage } from "./retired-fields.mjs";
 
 /**
  * `sohl:` keys every type accepts, whatever its schema says.
@@ -211,6 +212,31 @@ export function lintNote(note, { schemas, index }) {
     const at = (key, literal) =>
         positionInFrontmatter(raw(), key, literal ?? undefined);
 
+    // The retired top-level fields, checked before the type: a note may carry
+    // one whatever its type is, and each finding stands on its own. Reported
+    // here as well as refused at compile because this is where an author meets
+    // every finding in the tree at once, rather than one note at a time (#56).
+    if (Object.hasOwn(fm, "package")) {
+        findings.push({
+            file: note.file,
+            ...at("package"),
+            severity: "error",
+            message:
+                "`package:` is a retired frontmatter field — delete it. A " +
+                "note's package is this repository's configured " +
+                "`contentPackage`, in package-build.config.yaml, and every " +
+                "note in the tree belongs to it",
+        });
+    }
+    if (Object.hasOwn(fm, "draft")) {
+        findings.push({
+            file: note.file,
+            ...at("draft"),
+            severity: "error",
+            message: draftRetiredMessage(),
+        });
+    }
+
     const replacement = RETIRED_TYPES[type];
     if (replacement) {
         findings.push({

package/engine/helpers.mjs

@@ -36,7 +36,7 @@ import log from "loglevel";
 import { loadPackConfig } from "./pack-config.mjs";
 import { packRouter } from "./pack-router.mjs";
 import { contentPackage, foundryPackageId } from "./content-package.mjs";
-import { notePackage, searchableFrontmatter } from "./note-package.mjs";
+import { searchableFrontmatter } from "./note-package.mjs";
 import { loadForeignManifests, PACKAGE_BASE } from "./kb-manifest.mjs";
 import { buildWikilinkIndex, convertWikilinks } from "./wikilinks.mjs";
 import { expandContentTables } from "./content-tables.mjs";
@@ -602,8 +602,9 @@ export function collectContentDocs(contentBase) {
         if (!fm) continue;
         const segments = path.relative(contentBase, absPath).split(path.sep);
         docs.push({
-            // With its package present whether the note declares one or not, so
-            // a `WHERE … package = "…"` query reads the same either way (#56).
+            // With its package supplied for a `WHERE … package = "…"` query —
+            // synthesised from the configuration, since no note declares it
+            // (#56).
             fm: searchableFrontmatter(fm),
             // POSIX-separated and relative to the content root — what a
             // `path:` search term globs, on every platform.
@@ -636,17 +637,15 @@ const packLinkable = (doc) =>
  * Expand the fenced `dataview` tables in one note's markdown, before wikilinks
  * are resolved — so a generated cell may itself be a wikilink.
  *
- * A table searches only notes of the source note's own package, so a SoHL page
- * never tabulates setting-package content (and vice versa). Each candidate's
- * package is **derived** rather than read out of its frontmatter: `package:` is
- * optional, and comparing a declared value with an absent one would drop every
- * unswept — or every swept — note from the table (#56).
+ * A table searches the whole tree, which is one package's notes and nothing
+ * else — so there is no longer a package to scope on. It used to filter, back
+ * when a tree could hold several packages' notes and `package:` said which was
+ * which; that field is retired and the filter with it (#56).
  *
  * @param {string} body - The note's markdown body.
  * @param {object} ctx
  * @param {Array<object>} ctx.docs - From {@link collectContentDocs}.
  * @param {string} ctx.name - The note, for the error message.
- * @param {string} [ctx.pkg] - The source note's package.
  * @param {object} [ctx.fm] - The source note's frontmatter, which is what a
  *   query's `this` reads. Its entry in `docs` supplies the path as well.
  * @param {number} [ctx.bodyLine] - 1-based file line of the body's first line,
@@ -659,8 +658,7 @@ const packLinkable = (doc) =>
  *   compile rather than shipping a table-shaped hole. The error carries
  *   `position`, the directive's own line.
  */
-export function expandNoteTables(body, { docs, name, pkg, fm, bodyLine }) {
-    const scoped = pkg ? docs.filter((d) => notePackage(d.fm) === pkg) : docs;
+export function expandNoteTables(body, { docs, name, fm, bodyLine }) {
     const self =
         fm ?
             (docs.find((d) => d.fm?.id && d.fm.id === fm.id) ?? {
@@ -668,7 +666,7 @@ export function expandNoteTables(body, { docs, name, pkg, fm, bodyLine }) {
             })
         :   undefined;
     const { markdown, errors, lineMap } = expandContentTables(body ?? "", {
-        docs: scoped,
+        docs,
         linkable: packLinkable,
         source: name,
         self,

package/engine/index.mjs

@@ -54,9 +54,12 @@ export * as packRouter from "./pack-router.mjs";
 /** The content package a build compiles, and the Foundry package it ships in. */
 export * as contentPackage from "./content-package.mjs";
 
-/** Which content package a note belongs to, and refusing one that disagrees. */
+/** Which content package a note belongs to, and refusing one that says so. */
 export * as notePackage from "./note-package.mjs";
 
+/** Frontmatter fields a note may no longer declare, and the refusal of them. */
+export * as retiredFields from "./retired-fields.mjs";
+
 /** The shipped Foundry manifest: locating it, reading it, guarding its id. */
 
 /** The URL a content note is published at — the one web-address rule. */