@heroiclands/package-build 20.6.0 → 20.7.0

package/CHANGELOG.md

@@ -1,5 +1,27 @@
 # @heroiclands/package-build
 
+## 20.7.0
+
+### Minor Changes
+
+- 6c10f17: **A `trees` entry's pages stay where their tree mounts them** — declaring
+  `subType` on a note inside `site.trees` no longer moves its published address.
+  A `subType` classifies a page for the site index; it never routed a tree
+  page's URL to begin with for a note that left it unset, and now it does not
+  for one that sets it either. A site that already worked around this by
+  avoiding `subType` on its tree notes can declare it again: those pages move
+  back under the tree's own section on upgrade.
+
+### Patch Changes
+
+- 72daae4: **A being that declares no `sohl:` block no longer takes the site build down.**
+  `content-build site` failed with `unacceptable kind of an object to dump [object
+  Undefined]` for any `type: being` note whose front matter carried no `sohl:` key
+  at all, and the throw aborted the entire run rather than the one page. A note
+  carrying `sohl: null` had always been fine, so the failure only appeared once a
+  tree removed the empty key rather than emptying it. Both shapes now publish the
+  same page. Fixes HeroicLands/package-build#478.
+
 ## 20.6.0
 
 ### Minor Changes

package/engine/site-build.mjs

@@ -267,6 +267,14 @@ export function collectContentPages(contentBase, ctx) {
  * addressed by type and slug: they are a book with chapters, and a reader
  * follows their paths. A `README` is its directory's landing.
  *
+ * **The section is the tree's, never the note's.** `tree.section` is the
+ * mount point a `trees` entry configures — fixed, physical, and the same
+ * value `site-index.mjs` indexes a tree page's address under. A note's own
+ * `subType` is a genre and reaches no address, the same contract
+ * `packageAddress()` holds for a content page: reading it here would move a
+ * page's URL, its file destination (`pageDestination`) and the address a
+ * wikilink cites it by, every time an author classified it.
+ *
  * @param {object} tree - `{ from, rel, section, route }`.
  * @param {object} ctx - `{ mount }`.
  * @returns {{pages: object[], fmLinkFindings: object[]}}
@@ -287,7 +295,7 @@ export function collectTreePages(tree, ctx) {
         const rel = path.relative(tree.from, file).replace(/\\/g, "/");
         const base = path.basename(rel);
         const isReadme = base.toLowerCase() === "readme.md";
-        const sec = fm.subType ?? tree.section;
+        const sec = tree.section;
         const h1 = /^#\s+(.+?)\s*$/m.exec(body);
         const h1Title = h1 ? h1[1].replace(/\{@link\s+[^}]*\}/g, "").trim() : null;
         const name = fm.name?.full ?? fm.title ?? h1Title ?? path.basename(base, ".md");

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@heroiclands/package-build",
-    "version": "20.6.0",
+    "version": "20.7.0",
     "description": "Shared toolchain for building and shipping a HeroicLands Foundry VTT package — content compilation, manifest, localization, staging, bundle, release and deployment.",
     "license": "GPL-3.0-or-later",
     "type": "module",
@@ -154,6 +154,7 @@
     "devDependencies": {
         "@changesets/cli": "^3.0.0",
         "@types/node": "^26.2.0",
+        "npm-run-all": "^4.1.5",
         "vitest": "^5.0.0"
     },
     "scripts": {
@@ -163,7 +164,7 @@
         "build:types": "tsc -p tsconfig.dts.json",
         "format": "prettier --write .",
         "format:check": "prettier --check .",
-        "lint": "npm run format:check && npm run lint:markdown && npm run lint:yaml && npm run lint:labels && npm run lint:content-format",
+        "lint": "run-p --aggregate-output -c --max-parallel 4 format:check lint:markdown lint:yaml lint:labels lint:content-format",
         "lint:markdown": "node bin/content-build.mjs markdown",
         "lint:yaml": "node bin/package-build.mjs yaml",
         "lint:labels": "node bin/package-build.mjs labels check",

package/sohl/being-info.mjs

@@ -108,11 +108,17 @@ const nonEmpty = (v) => Array.isArray(v) && v.length > 0;
  * @param {object|null|undefined} sohl - The note's `sohl` frontmatter block.
  * @param {Map<string, {name?: string, url?: string}>} index - Content index,
  *   `"<type>:<shortcode>"` → the item's page.
- * @returns {object|null|undefined} The block with its info-block fields filled
- *   in, or the input unchanged when there is nothing to derive from.
+ * @returns {object|null} The block with its info-block fields filled in, or the
+ *   input unchanged when there is nothing to derive from — with an absent block
+ *   reported as `null`, the value an empty one already carries.
  */
 export function deriveBeingInfo(sohl, index) {
-    if (!isMap(sohl)) return sohl;
+    // A note declaring no `sohl:` key at all arrives as `undefined`, and the
+    // site emitter assigns this result straight into a page's front matter.
+    // js-yaml refuses to dump a property whose value is `undefined`, and the
+    // throw aborts the whole build rather than the one page — so "no block"
+    // is answered with the same `null` an empty block gets.
+    if (!isMap(sohl)) return sohl ?? null;
     const out = { ...sohl };
     const items = Array.isArray(out.items) ? out.items : [];
     if (items.length === 0) return out;

package/types/engine/site-build.d.mts

@@ -36,6 +36,14 @@ export function collectContentPages(contentBase: string, ctx: object): {
  * addressed by type and slug: they are a book with chapters, and a reader
  * follows their paths. A `README` is its directory's landing.
  *
+ * **The section is the tree's, never the note's.** `tree.section` is the
+ * mount point a `trees` entry configures — fixed, physical, and the same
+ * value `site-index.mjs` indexes a tree page's address under. A note's own
+ * `subType` is a genre and reaches no address, the same contract
+ * `packageAddress()` holds for a content page: reading it here would move a
+ * page's URL, its file destination (`pageDestination`) and the address a
+ * wikilink cites it by, every time an author classified it.
+ *
  * @param {object} tree - `{ from, rel, section, route }`.
  * @param {object} ctx - `{ mount }`.
  * @returns {{pages: object[], fmLinkFindings: object[]}}

package/types/sohl/being-info.d.mts

@@ -26,13 +26,14 @@ export function isBeing(fm: {
  * @param {object|null|undefined} sohl - The note's `sohl` frontmatter block.
  * @param {Map<string, {name?: string, url?: string}>} index - Content index,
  *   `"<type>:<shortcode>"` → the item's page.
- * @returns {object|null|undefined} The block with its info-block fields filled
- *   in, or the input unchanged when there is nothing to derive from.
+ * @returns {object|null} The block with its info-block fields filled in, or the
+ *   input unchanged when there is nothing to derive from — with an absent block
+ *   reported as `null`, the value an empty one already carries.
  */
 export function deriveBeingInfo(sohl: object | null | undefined, index: Map<string, {
     name?: string;
     url?: string;
-}>): object | null | undefined;
+}>): object | null;
 /**
  * The note `type` whose pages carry a being info block.
  *