@hero-design/rn 8.8.1 → 8.9.1

package/src/components/TextInput/__tests__/__snapshots__/index.spec.tsx.snap

@@ -6,7 +6,7 @@ exports[`TextInput defaultValue TextInput is idle renders correctly 1`] = `
   style={
     Array [
       Object {
-        "marginVertical": 8,
+        "marginTop": 8,
         "width": "100%",
       },
       undefined,
@@ -181,6 +181,7 @@ exports[`TextInput defaultValue TextInput is idle renders correctly 1`] = `
     style={
       Array [
         Object {
+          "minHeight": 16,
           "paddingLeft": 16,
         },
         undefined,
@@ -198,6 +199,31 @@ exports[`TextInput defaultValue TextInput is idle renders correctly 1`] = `
         ]
       }
     >
+      <Text
+        style={
+          Array [
+            Object {
+              "color": "#001f23",
+              "fontFamily": "BeVietnamPro-Regular",
+              "fontSize": 14,
+              "letterSpacing": 0.42,
+              "lineHeight": 22,
+            },
+            Array [
+              Object {
+                "fontSize": 12,
+              },
+              undefined,
+            ],
+          ]
+        }
+        themeFontSize="medium"
+        themeFontWeight="regular"
+        themeIntent="body"
+        themeTypeface="neutral"
+      >
+        This is helper text
+      </Text>
       <Text
         style={
           Array [
@@ -233,31 +259,6 @@ exports[`TextInput defaultValue TextInput is idle renders correctly 1`] = `
         255
       </Text>
     </View>
-    <Text
-      style={
-        Array [
-          Object {
-            "color": "#001f23",
-            "fontFamily": "BeVietnamPro-Regular",
-            "fontSize": 14,
-            "letterSpacing": 0.42,
-            "lineHeight": 22,
-          },
-          Array [
-            Object {
-              "fontSize": 12,
-            },
-            undefined,
-          ],
-        ]
-      }
-      themeFontSize="medium"
-      themeFontWeight="regular"
-      themeIntent="body"
-      themeTypeface="neutral"
-    >
-      This is helper text
-    </Text>
   </View>
 </View>
 `;
@@ -268,7 +269,7 @@ exports[`TextInput defaultValue default Value and Value renders correctly with 2
   style={
     Array [
       Object {
-        "marginVertical": 8,
+        "marginTop": 8,
         "width": "100%",
       },
       undefined,
@@ -444,6 +445,7 @@ exports[`TextInput defaultValue default Value and Value renders correctly with 2
     style={
       Array [
         Object {
+          "minHeight": 16,
           "paddingLeft": 16,
         },
         undefined,
@@ -461,6 +463,31 @@ exports[`TextInput defaultValue default Value and Value renders correctly with 2
         ]
       }
     >
+      <Text
+        style={
+          Array [
+            Object {
+              "color": "#001f23",
+              "fontFamily": "BeVietnamPro-Regular",
+              "fontSize": 14,
+              "letterSpacing": 0.42,
+              "lineHeight": 22,
+            },
+            Array [
+              Object {
+                "fontSize": 12,
+              },
+              undefined,
+            ],
+          ]
+        }
+        themeFontSize="medium"
+        themeFontWeight="regular"
+        themeIntent="body"
+        themeTypeface="neutral"
+      >
+        This is helper text
+      </Text>
       <Text
         style={
           Array [
@@ -496,31 +523,6 @@ exports[`TextInput defaultValue default Value and Value renders correctly with 2
         255
       </Text>
     </View>
-    <Text
-      style={
-        Array [
-          Object {
-            "color": "#001f23",
-            "fontFamily": "BeVietnamPro-Regular",
-            "fontSize": 14,
-            "letterSpacing": 0.42,
-            "lineHeight": 22,
-          },
-          Array [
-            Object {
-              "fontSize": 12,
-            },
-            undefined,
-          ],
-        ]
-      }
-      themeFontSize="medium"
-      themeFontWeight="regular"
-      themeIntent="body"
-      themeTypeface="neutral"
-    >
-      This is helper text
-    </Text>
   </View>
 </View>
 `;
@@ -531,7 +533,7 @@ exports[`TextInput disabled renders correctly 1`] = `
   style={
     Array [
       Object {
-        "marginVertical": 8,
+        "marginTop": 8,
         "width": "100%",
       },
       undefined,
@@ -691,6 +693,7 @@ exports[`TextInput disabled renders correctly 1`] = `
     style={
       Array [
         Object {
+          "minHeight": 16,
           "paddingLeft": 16,
         },
         undefined,
@@ -718,7 +721,7 @@ exports[`TextInput error renders correctly 1`] = `
   style={
     Array [
       Object {
-        "marginVertical": 8,
+        "marginTop": 8,
         "width": "100%",
       },
       undefined,
@@ -898,6 +901,7 @@ exports[`TextInput error renders correctly 1`] = `
     style={
       Array [
         Object {
+          "minHeight": 16,
           "paddingLeft": 16,
         },
         undefined,
@@ -984,7 +988,7 @@ exports[`TextInput filled renders correctly 1`] = `
   style={
     Array [
       Object {
-        "marginVertical": 8,
+        "marginTop": 8,
         "width": "100%",
       },
       undefined,
@@ -1147,6 +1151,7 @@ exports[`TextInput filled renders correctly 1`] = `
     style={
       Array [
         Object {
+          "minHeight": 16,
           "paddingLeft": 16,
         },
         undefined,
@@ -1174,7 +1179,7 @@ exports[`TextInput helper text renders correctly 1`] = `
   style={
     Array [
       Object {
-        "marginVertical": 8,
+        "marginTop": 8,
         "width": "100%",
       },
       undefined,
@@ -1354,6 +1359,7 @@ exports[`TextInput helper text renders correctly 1`] = `
     style={
       Array [
         Object {
+          "minHeight": 16,
           "paddingLeft": 16,
         },
         undefined,
@@ -1370,32 +1376,33 @@ exports[`TextInput helper text renders correctly 1`] = `
           undefined,
         ]
       }
-    />
-    <Text
-      style={
-        Array [
-          Object {
-            "color": "#001f23",
-            "fontFamily": "BeVietnamPro-Regular",
-            "fontSize": 14,
-            "letterSpacing": 0.42,
-            "lineHeight": 22,
-          },
+    >
+      <Text
+        style={
           Array [
             Object {
-              "fontSize": 12,
+              "color": "#001f23",
+              "fontFamily": "BeVietnamPro-Regular",
+              "fontSize": 14,
+              "letterSpacing": 0.42,
+              "lineHeight": 22,
             },
-            undefined,
-          ],
-        ]
-      }
-      themeFontSize="medium"
-      themeFontWeight="regular"
-      themeIntent="body"
-      themeTypeface="neutral"
-    >
-      This is helper text
-    </Text>
+            Array [
+              Object {
+                "fontSize": 12,
+              },
+              undefined,
+            ],
+          ]
+        }
+        themeFontSize="medium"
+        themeFontWeight="regular"
+        themeIntent="body"
+        themeTypeface="neutral"
+      >
+        This is helper text
+      </Text>
+    </View>
   </View>
 </View>
 `;
@@ -1406,7 +1413,7 @@ exports[`TextInput idle renders correctly 1`] = `
   style={
     Array [
       Object {
-        "marginVertical": 8,
+        "marginTop": 8,
         "width": "100%",
       },
       Object {
@@ -1577,6 +1584,7 @@ exports[`TextInput idle renders correctly 1`] = `
     style={
       Array [
         Object {
+          "minHeight": 16,
           "paddingLeft": 16,
         },
         undefined,
@@ -1604,7 +1612,7 @@ exports[`TextInput idle with suffix and prefix are React Element renders correct
   style={
     Array [
       Object {
-        "marginVertical": 8,
+        "marginTop": 8,
         "width": "100%",
       },
       undefined,
@@ -1799,6 +1807,7 @@ exports[`TextInput idle with suffix and prefix are React Element renders correct
     style={
       Array [
         Object {
+          "minHeight": 16,
           "paddingLeft": 16,
         },
         undefined,
@@ -1826,7 +1835,7 @@ exports[`TextInput loading renders correctly 1`] = `
   style={
     Array [
       Object {
-        "marginVertical": 8,
+        "marginTop": 8,
         "width": "100%",
       },
       undefined,
@@ -1958,6 +1967,7 @@ exports[`TextInput loading renders correctly 1`] = `
     style={
       Array [
         Object {
+          "minHeight": 16,
           "paddingLeft": 16,
         },
         undefined,
@@ -1985,7 +1995,7 @@ exports[`TextInput max length renders correctly 1`] = `
   style={
     Array [
       Object {
-        "marginVertical": 8,
+        "marginTop": 8,
         "width": "100%",
       },
       undefined,
@@ -2146,6 +2156,7 @@ exports[`TextInput max length renders correctly 1`] = `
     style={
       Array [
         Object {
+          "minHeight": 16,
           "paddingLeft": 16,
         },
         undefined,
@@ -2266,7 +2277,7 @@ exports[`TextInput placeholder TextInput is idle renders correctly 1`] = `
   style={
     Array [
       Object {
-        "marginVertical": 8,
+        "marginTop": 8,
         "width": "100%",
       },
       undefined,
@@ -2446,6 +2457,7 @@ exports[`TextInput placeholder TextInput is idle renders correctly 1`] = `
     style={
       Array [
         Object {
+          "minHeight": 16,
           "paddingLeft": 16,
         },
         undefined,
@@ -2462,32 +2474,33 @@ exports[`TextInput placeholder TextInput is idle renders correctly 1`] = `
           undefined,
         ]
       }
-    />
-    <Text
-      style={
-        Array [
-          Object {
-            "color": "#001f23",
-            "fontFamily": "BeVietnamPro-Regular",
-            "fontSize": 14,
-            "letterSpacing": 0.42,
-            "lineHeight": 22,
-          },
+    >
+      <Text
+        style={
           Array [
             Object {
-              "fontSize": 12,
+              "color": "#001f23",
+              "fontFamily": "BeVietnamPro-Regular",
+              "fontSize": 14,
+              "letterSpacing": 0.42,
+              "lineHeight": 22,
             },
-            undefined,
-          ],
-        ]
-      }
-      themeFontSize="medium"
-      themeFontWeight="regular"
-      themeIntent="body"
-      themeTypeface="neutral"
-    >
-      This is helper text
-    </Text>
+            Array [
+              Object {
+                "fontSize": 12,
+              },
+              undefined,
+            ],
+          ]
+        }
+        themeFontSize="medium"
+        themeFontWeight="regular"
+        themeIntent="body"
+        themeTypeface="neutral"
+      >
+        This is helper text
+      </Text>
+    </View>
   </View>
 </View>
 `;
@@ -2498,7 +2511,7 @@ exports[`TextInput readonly renders correctly 1`] = `
   style={
     Array [
       Object {
-        "marginVertical": 8,
+        "marginTop": 8,
         "width": "100%",
       },
       undefined,
@@ -2687,6 +2700,7 @@ exports[`TextInput readonly renders correctly 1`] = `
     style={
       Array [
         Object {
+          "minHeight": 16,
           "paddingLeft": 16,
         },
         undefined,
@@ -2714,7 +2728,7 @@ exports[`TextInput ref ref methods work correctly 1`] = `
   style={
     Array [
       Object {
-        "marginVertical": 8,
+        "marginTop": 8,
         "width": "100%",
       },
       undefined,
@@ -2847,6 +2861,7 @@ exports[`TextInput ref ref methods work correctly 1`] = `
     style={
       Array [
         Object {
+          "minHeight": 16,
           "paddingLeft": 16,
         },
         undefined,
@@ -2874,7 +2889,7 @@ exports[`TextInput required renders correctly 1`] = `
   style={
     Array [
       Object {
-        "marginVertical": 8,
+        "marginTop": 8,
         "width": "100%",
       },
       undefined,
@@ -3069,6 +3084,7 @@ exports[`TextInput required renders correctly 1`] = `
     style={
       Array [
         Object {
+          "minHeight": 16,
           "paddingLeft": 16,
         },
         undefined,

package/src/components/TextInput/index.tsx

@@ -339,7 +339,7 @@ const TextInput = forwardRef<TextInputHandles, TextInputProps>(
         </StyledTextInputContainer>
         <StyledErrorAndHelpTextContainer>
           <StyledErrorAndMaxLengthContainer>
-            {!!error && (
+            {error ? (
               <StyledErrorContainer>
                 <Icon
                   testID="input-error-icon"
@@ -350,6 +350,8 @@ const TextInput = forwardRef<TextInputHandles, TextInputProps>(
 
                 <StyledError testID="input-error-message">{error}</StyledError>
               </StyledErrorContainer>
+            ) : (
+              !!helpText && <StyledHelperText>{helpText}</StyledHelperText>
             )}
             {shouldShowMaxLength && (
               <StyledMaxLengthMessage themeVariant={variant} fontSize="small">
@@ -357,7 +359,6 @@ const TextInput = forwardRef<TextInputHandles, TextInputProps>(
               </StyledMaxLengthMessage>
             )}
           </StyledErrorAndMaxLengthContainer>
-          {!!helpText && <StyledHelperText>{helpText}</StyledHelperText>}
         </StyledErrorAndHelpTextContainer>
       </StyledContainer>
     );

package/src/components/TimePicker/__tests__/__snapshots__/TimePickerAndroid.spec.tsx.snap

@@ -32,7 +32,7 @@ exports[`TimePickerAndroid renders correct with hide suffix 1`] = `
       style={
         Array [
           Object {
-            "marginVertical": 8,
+            "marginTop": 8,
             "width": "100%",
           },
           undefined,
@@ -165,6 +165,7 @@ exports[`TimePickerAndroid renders correct with hide suffix 1`] = `
         style={
           Array [
             Object {
+              "minHeight": 16,
               "paddingLeft": 16,
             },
             undefined,
@@ -181,32 +182,33 @@ exports[`TimePickerAndroid renders correct with hide suffix 1`] = `
               undefined,
             ]
           }
-        />
-        <Text
-          style={
-            Array [
-              Object {
-                "color": "#001f23",
-                "fontFamily": "BeVietnamPro-Regular",
-                "fontSize": 14,
-                "letterSpacing": 0.42,
-                "lineHeight": 22,
-              },
+        >
+          <Text
+            style={
               Array [
                 Object {
-                  "fontSize": 12,
+                  "color": "#001f23",
+                  "fontFamily": "BeVietnamPro-Regular",
+                  "fontSize": 14,
+                  "letterSpacing": 0.42,
+                  "lineHeight": 22,
                 },
-                undefined,
-              ],
-            ]
-          }
-          themeFontSize="medium"
-          themeFontWeight="regular"
-          themeIntent="body"
-          themeTypeface="neutral"
-        >
-          This is help text
-        </Text>
+                Array [
+                  Object {
+                    "fontSize": 12,
+                  },
+                  undefined,
+                ],
+              ]
+            }
+            themeFontSize="medium"
+            themeFontWeight="regular"
+            themeIntent="body"
+            themeTypeface="neutral"
+          >
+            This is help text
+          </Text>
+        </View>
       </View>
     </View>
   </View>
@@ -245,7 +247,7 @@ exports[`TimePickerAndroid renders correctly 1`] = `
       style={
         Array [
           Object {
-            "marginVertical": 8,
+            "marginTop": 8,
             "width": "100%",
           },
           undefined,
@@ -393,6 +395,7 @@ exports[`TimePickerAndroid renders correctly 1`] = `
         style={
           Array [
             Object {
+              "minHeight": 16,
               "paddingLeft": 16,
             },
             undefined,

package/src/components/TimePicker/__tests__/__snapshots__/TimePickerIOS.spec.tsx.snap

@@ -32,7 +32,7 @@ exports[`TimePickerIOS renders correct with hide suffix 1`] = `
       style={
         Array [
           Object {
-            "marginVertical": 8,
+            "marginTop": 8,
             "width": "100%",
           },
           undefined,
@@ -165,6 +165,7 @@ exports[`TimePickerIOS renders correct with hide suffix 1`] = `
         style={
           Array [
             Object {
+              "minHeight": 16,
               "paddingLeft": 16,
             },
             undefined,
@@ -181,32 +182,33 @@ exports[`TimePickerIOS renders correct with hide suffix 1`] = `
               undefined,
             ]
           }
-        />
-        <Text
-          style={
-            Array [
-              Object {
-                "color": "#001f23",
-                "fontFamily": "BeVietnamPro-Regular",
-                "fontSize": 14,
-                "letterSpacing": 0.42,
-                "lineHeight": 22,
-              },
+        >
+          <Text
+            style={
               Array [
                 Object {
-                  "fontSize": 12,
+                  "color": "#001f23",
+                  "fontFamily": "BeVietnamPro-Regular",
+                  "fontSize": 14,
+                  "letterSpacing": 0.42,
+                  "lineHeight": 22,
                 },
-                undefined,
-              ],
-            ]
-          }
-          themeFontSize="medium"
-          themeFontWeight="regular"
-          themeIntent="body"
-          themeTypeface="neutral"
-        >
-          This is help text
-        </Text>
+                Array [
+                  Object {
+                    "fontSize": 12,
+                  },
+                  undefined,
+                ],
+              ]
+            }
+            themeFontSize="medium"
+            themeFontWeight="regular"
+            themeIntent="body"
+            themeTypeface="neutral"
+          >
+            This is help text
+          </Text>
+        </View>
       </View>
     </View>
   </View>
@@ -245,7 +247,7 @@ exports[`TimePickerIOS renders correctly 1`] = `
       style={
         Array [
           Object {
-            "marginVertical": 8,
+            "marginTop": 8,
             "width": "100%",
           },
           undefined,
@@ -393,6 +395,7 @@ exports[`TimePickerIOS renders correctly 1`] = `
         style={
           Array [
             Object {
+              "minHeight": 16,
               "paddingLeft": 16,
             },
             undefined,

package/src/index.ts

@@ -39,7 +39,6 @@ import Progress from './components/Progress';
 import Slider from './components/Slider';
 import Spinner from './components/Spinner';
 import Swipeable from './components/Swipeable';
-import SwipeableV2 from './components/SwipeableV2';
 import Radio from './components/Radio';
 import SectionHeading from './components/SectionHeading';
 import Select from './components/Select';
@@ -97,7 +96,6 @@ export {
   Slider,
   Spinner,
   Swipeable,
-  SwipeableV2,
   Radio,
   SectionHeading,
   Select,