@hero-design/rn 8.78.0 → 8.78.1

package/.turbo/turbo-build.log

@@ -1,7 +1,7 @@
-(node:2884) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
+(node:2844) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
 (Use `node --trace-warnings ...` to show where the warning was created)
 
 src/index.ts → lib/index.js, es/index.js...
 (!) [plugin replace] @rollup/plugin-replace: 'preventAssignment' currently defaults to false. It is recommended to set this option to `true`, as the next major version will default this option to `true`.
 (!) [plugin node-resolve] preferring built-in module 'events' over local alternative at '/home/runner/work/hero-design/hero-design/node_modules/events/events.js', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning.or passing a function to 'preferBuiltins' to provide more fine-grained control over which built-in modules to prefer.
-created lib/index.js, es/index.js in 50.6s
+created lib/index.js, es/index.js in 50.4s

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @hero-design/rn
 
+## 8.78.1
+
+### Patch Changes
+
+- [#3487](https://github.com/Thinkei/hero-design/pull/3487) [`5bcbcf14116726514e58aef14c9f7758cd8d1683`](https://github.com/Thinkei/hero-design/commit/5bcbcf14116726514e58aef14c9f7758cd8d1683) Thanks [@vinhphan-eh](https://github.com/vinhphan-eh)! - [BottomSheet] Add missing dependencies
+
 ## 8.78.0
 
 ### Minor Changes

package/es/index.js

@@ -9718,16 +9718,24 @@ var BottomSheet = function BottomSheet(_ref) {
     _useState4 = _slicedToArray(_useState3, 2),
     internalShowDivider = _useState4[0],
     setInternalShowDivider = _useState4[1];
-  var canCallOnDismiss = useRef(false);
   useEffect(function () {
-    // Prevent calling onDismiss when the component has not yet opened
-    if (open && !canCallOnDismiss.current) {
-      canCallOnDismiss.current = true;
-    }
     // Show the modal before the open animation start
     if (open && !visible) {
       setVisibility(open);
     }
+    // Delay closing the modal until after the closing animation end
+    animatedValue.current.removeAllListeners();
+    animatedValue.current.addListener(function (_ref2) {
+      var value = _ref2.value;
+      var endValueOfTransition = open ? 1 : 0;
+      if (endValueOfTransition === 0 && value === endValueOfTransition) {
+        setVisibility(false);
+        onDismiss === null || onDismiss === void 0 || onDismiss();
+      }
+    });
+    return function () {
+      return animatedValue.current.removeAllListeners();
+    };
   }, [open]);
   // Animation
   useEffect(function () {
@@ -9736,13 +9744,7 @@ var BottomSheet = function BottomSheet(_ref) {
       easing: Easing.inOut(Easing.cubic),
       useNativeDriver: true
     });
-    animation.start(function () {
-      if (!open && canCallOnDismiss.current) {
-        setVisibility(false);
-        onDismiss === null || onDismiss === void 0 || onDismiss();
-      }
-      onAnimationEnd === null || onAnimationEnd === void 0 || onAnimationEnd();
-    });
+    animation.start(onAnimationEnd);
     return function () {
       return animation.stop();
     };

package/lib/index.js

@@ -9745,16 +9745,24 @@ var BottomSheet = function BottomSheet(_ref) {
     _useState4 = _slicedToArray(_useState3, 2),
     internalShowDivider = _useState4[0],
     setInternalShowDivider = _useState4[1];
-  var canCallOnDismiss = React.useRef(false);
   React.useEffect(function () {
-    // Prevent calling onDismiss when the component has not yet opened
-    if (open && !canCallOnDismiss.current) {
-      canCallOnDismiss.current = true;
-    }
     // Show the modal before the open animation start
     if (open && !visible) {
       setVisibility(open);
     }
+    // Delay closing the modal until after the closing animation end
+    animatedValue.current.removeAllListeners();
+    animatedValue.current.addListener(function (_ref2) {
+      var value = _ref2.value;
+      var endValueOfTransition = open ? 1 : 0;
+      if (endValueOfTransition === 0 && value === endValueOfTransition) {
+        setVisibility(false);
+        onDismiss === null || onDismiss === void 0 || onDismiss();
+      }
+    });
+    return function () {
+      return animatedValue.current.removeAllListeners();
+    };
   }, [open]);
   // Animation
   React.useEffect(function () {
@@ -9763,13 +9771,7 @@ var BottomSheet = function BottomSheet(_ref) {
       easing: reactNative.Easing.inOut(reactNative.Easing.cubic),
       useNativeDriver: true
     });
-    animation.start(function () {
-      if (!open && canCallOnDismiss.current) {
-        setVisibility(false);
-        onDismiss === null || onDismiss === void 0 || onDismiss();
-      }
-      onAnimationEnd === null || onAnimationEnd === void 0 || onAnimationEnd();
-    });
+    animation.start(onAnimationEnd);
     return function () {
       return animation.stop();
     };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hero-design/rn",
-  "version": "8.78.0",
+  "version": "8.78.1",
   "license": "MIT",
   "main": "lib/index.js",
   "module": "es/index.js",

package/src/components/BottomSheet/index.tsx

@@ -115,18 +115,24 @@ const BottomSheet = ({
   const animatedValue = useRef(new Animated.Value(open ? 0 : 1));
   const [internalShowDivider, setInternalShowDivider] =
     useState<boolean>(showDivider);
-  const canCallOnDismiss = useRef(false);
 
   useEffect(() => {
-    // Prevent calling onDismiss when the component has not yet opened
-    if (open && !canCallOnDismiss.current) {
-      canCallOnDismiss.current = true;
-    }
-
     // Show the modal before the open animation start
     if (open && !visible) {
       setVisibility(open);
     }
+
+    // Delay closing the modal until after the closing animation end
+    animatedValue.current.removeAllListeners();
+    animatedValue.current.addListener(({ value }) => {
+      const endValueOfTransition = open ? 1 : 0;
+      if (endValueOfTransition === 0 && value === endValueOfTransition) {
+        setVisibility(false);
+        onDismiss?.();
+      }
+    });
+
+    return () => animatedValue.current.removeAllListeners();
   }, [open]);
 
   // Animation
@@ -137,14 +143,7 @@ const BottomSheet = ({
       useNativeDriver: true,
     });
 
-    animation.start(() => {
-      if (!open && canCallOnDismiss.current) {
-        setVisibility(false);
-        onDismiss?.();
-      }
-
-      onAnimationEnd?.();
-    });
+    animation.start(onAnimationEnd);
 
     return () => animation.stop();
   }, [open]);