@hero-design/rn 8.24.0-alpha.1 → 8.25.0

package/src/components/Carousel/__tests__/CardCarousel.spec.tsx

@@ -1,104 +1,211 @@
 import { waitFor } from '@testing-library/react-native';
 import React from 'react';
-import { FlatList } from 'react-native';
+import { FlatList, Platform } from 'react-native';
 import { CardCarousel, CardCarouselHandles } from '../CardCarousel';
 import renderWithTheme from '../../../testHelpers/renderWithTheme';
 import Typography from '../../Typography';
 
 describe('CardCarousel', () => {
-  it('should render correctly', () => {
-    const wrapper = renderWithTheme(
-      <CardCarousel
-        testID="cardCarousel"
-        style={{ width: 100, height: 100 }}
-        items={[
-          <Typography.Text> screen 1</Typography.Text>,
-          <Typography.Text> screen 2</Typography.Text>,
-        ]}
-      />
-    );
-
-    expect(wrapper.toJSON()).toMatchSnapshot();
-    expect(wrapper.queryAllByText('screen 1')).toHaveLength(1);
-    expect(wrapper.queryAllByText('screen 2')).toHaveLength(1);
-    expect(wrapper.queryAllByTestId('pageControl')).toHaveLength(1);
-  });
-
-  describe('autoPlay', () => {
-    it('should call scrollToIndex 1', () => {
-      jest.useFakeTimers();
-      const carouselRef = React.createRef<
-        CardCarouselHandles & {
-          getFlatListRef: () => FlatList;
-        }
-      >();
+  describe('ios', () => {
+    beforeAll(() => {
+      Platform.OS = 'ios';
+    });
 
-      renderWithTheme(
+    it('should render correctly on iOS', () => {
+      const wrapper = renderWithTheme(
         <CardCarousel
-          ref={carouselRef}
-          autoPlay
-          autoPlayInterval={3000}
+          testID="cardCarousel"
+          style={{ width: 100, height: 100 }}
           items={[
             <Typography.Text> screen 1</Typography.Text>,
             <Typography.Text> screen 2</Typography.Text>,
           ]}
         />
       );
-      const flatListRef = carouselRef.current!.getFlatListRef()!;
-      const snapToIndexSpy = jest.spyOn(flatListRef, 'scrollToIndex');
-      jest.advanceTimersByTime(3000);
-      expect(snapToIndexSpy).toHaveBeenCalledWith({
-        animated: true,
-        index: 1,
-        viewPosition: 0.5,
+
+      expect(wrapper.toJSON()).toMatchSnapshot();
+      expect(wrapper.queryAllByText('screen 1')).toHaveLength(1);
+      expect(wrapper.queryAllByText('screen 2')).toHaveLength(1);
+      expect(wrapper.queryAllByTestId('pageControl')).toHaveLength(1);
+    });
+
+    describe('autoPlay', () => {
+      it('should call scrollToIndex 1', () => {
+        jest.useFakeTimers();
+        const carouselRef = React.createRef<
+          CardCarouselHandles & {
+            getFlatListRef: () => FlatList;
+          }
+        >();
+
+        renderWithTheme(
+          <CardCarousel
+            ref={carouselRef}
+            autoPlay
+            autoPlayInterval={3000}
+            items={[
+              <Typography.Text> screen 1</Typography.Text>,
+              <Typography.Text> screen 2</Typography.Text>,
+            ]}
+          />
+        );
+        const flatListRef = carouselRef.current!.getFlatListRef()!;
+        const snapToIndexSpy = jest.spyOn(flatListRef, 'scrollToIndex');
+        jest.advanceTimersByTime(3000);
+        expect(snapToIndexSpy).toHaveBeenCalledWith({
+          animated: true,
+          index: 1,
+          viewPosition: 0.5,
+        });
+
+        jest.useRealTimers();
       });
+    });
 
-      jest.useRealTimers();
+    describe('hidePageControl', () => {
+      const wrapper = renderWithTheme(
+        <CardCarousel
+          style={{ width: 100, height: 100 }}
+          hidePageControl
+          items={[
+            <Typography.Text> screen 1</Typography.Text>,
+            <Typography.Text> screen 2</Typography.Text>,
+          ]}
+        />
+      );
+      expect(wrapper.queryAllByTestId('pageControl')).toHaveLength(0);
     });
-  });
 
-  describe('hidePageControl', () => {
-    const wrapper = renderWithTheme(
-      <CardCarousel
-        style={{ width: 100, height: 100 }}
-        hidePageControl
-        items={[
-          <Typography.Text> screen 1</Typography.Text>,
-          <Typography.Text> screen 2</Typography.Text>,
-        ]}
-      />
-    );
-    expect(wrapper.queryAllByTestId('pageControl')).toHaveLength(0);
+    describe('snapToIndex', () => {
+      it('should render correctly', () => {
+        const carouselRef = React.createRef<
+          CardCarouselHandles & {
+            getFlatListRef: () => FlatList;
+          }
+        >();
+
+        renderWithTheme(
+          <CardCarousel
+            ref={carouselRef}
+            items={[
+              <Typography.Text> screen 1</Typography.Text>,
+              <Typography.Text> screen 2</Typography.Text>,
+              <Typography.Text> screen 3</Typography.Text>,
+            ]}
+          />
+        );
+
+        const flatListRef = carouselRef.current!.getFlatListRef()!;
+        const snapToIndexSpy = jest.spyOn(flatListRef, 'scrollToIndex');
+        carouselRef.current?.snapToIndex(2);
+        waitFor(() => expect(snapToIndexSpy).toHaveBeenCalled());
+
+        expect(snapToIndexSpy).toHaveBeenCalledWith({
+          animated: true,
+          index: 2,
+          viewPosition: 0.5,
+        });
+      });
+    });
   });
+  describe('android', () => {
+    beforeAll(() => {
+      Platform.OS = 'android';
+    });
+    it('should render correctly on iOS', () => {
+      const wrapper = renderWithTheme(
+        <CardCarousel
+          testID="cardCarousel"
+          style={{ width: 100, height: 100 }}
+          items={[
+            <Typography.Text> screen 1</Typography.Text>,
+            <Typography.Text> screen 2</Typography.Text>,
+          ]}
+        />
+      );
 
-  describe('snapToIndex', () => {
-    it('should render correctly', () => {
-      const carouselRef = React.createRef<
-        CardCarouselHandles & {
-          getFlatListRef: () => FlatList;
-        }
-      >();
+      expect(wrapper.toJSON()).toMatchSnapshot();
+      expect(wrapper.queryAllByText('screen 1')).toHaveLength(1);
+      expect(wrapper.queryAllByText('screen 2')).toHaveLength(1);
+      expect(wrapper.queryAllByTestId('pageControl')).toHaveLength(1);
+    });
+
+    describe('autoPlay', () => {
+      it('should call scrollToIndex 1', () => {
+        jest.useFakeTimers();
+        const carouselRef = React.createRef<
+          CardCarouselHandles & {
+            getFlatListRef: () => FlatList;
+          }
+        >();
+
+        renderWithTheme(
+          <CardCarousel
+            ref={carouselRef}
+            autoPlay
+            autoPlayInterval={3000}
+            items={[
+              <Typography.Text> screen 1</Typography.Text>,
+              <Typography.Text> screen 2</Typography.Text>,
+            ]}
+          />
+        );
+        const flatListRef = carouselRef.current!.getFlatListRef()!;
+        const snapToIndexSpy = jest.spyOn(flatListRef, 'scrollToIndex');
+        jest.advanceTimersByTime(3000);
+        expect(snapToIndexSpy).toHaveBeenCalledWith({
+          animated: true,
+          index: 1,
+          viewPosition: undefined,
+        });
 
-      renderWithTheme(
+        jest.useRealTimers();
+      });
+    });
+
+    describe('hidePageControl', () => {
+      const wrapper = renderWithTheme(
         <CardCarousel
-          ref={carouselRef}
+          style={{ width: 100, height: 100 }}
+          hidePageControl
           items={[
             <Typography.Text> screen 1</Typography.Text>,
             <Typography.Text> screen 2</Typography.Text>,
-            <Typography.Text> screen 3</Typography.Text>,
           ]}
         />
       );
+      expect(wrapper.queryAllByTestId('pageControl')).toHaveLength(0);
+    });
+
+    describe('snapToIndex', () => {
+      it('should render correctly', () => {
+        const carouselRef = React.createRef<
+          CardCarouselHandles & {
+            getFlatListRef: () => FlatList;
+          }
+        >();
+
+        renderWithTheme(
+          <CardCarousel
+            ref={carouselRef}
+            items={[
+              <Typography.Text> screen 1</Typography.Text>,
+              <Typography.Text> screen 2</Typography.Text>,
+              <Typography.Text> screen 3</Typography.Text>,
+            ]}
+          />
+        );
 
-      const flatListRef = carouselRef.current!.getFlatListRef()!;
-      const snapToIndexSpy = jest.spyOn(flatListRef, 'scrollToIndex');
-      carouselRef.current?.snapToIndex(2);
-      waitFor(() => expect(snapToIndexSpy).toHaveBeenCalled());
+        const flatListRef = carouselRef.current!.getFlatListRef()!;
+        const snapToIndexSpy = jest.spyOn(flatListRef, 'scrollToIndex');
+        carouselRef.current?.snapToIndex(2);
+        waitFor(() => expect(snapToIndexSpy).toHaveBeenCalled());
 
-      expect(snapToIndexSpy).toHaveBeenCalledWith({
-        animated: true,
-        index: 2,
-        viewPosition: 0.5,
+        expect(snapToIndexSpy).toHaveBeenCalledWith({
+          animated: true,
+          index: 2,
+          viewPosition: undefined,
+        });
       });
     });
   });

package/src/components/Carousel/__tests__/__snapshots__/CardCarousel.spec.tsx.snap

@@ -1,6 +1,299 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`CardCarousel should render correctly 1`] = `
+exports[`CardCarousel android should render correctly on iOS 1`] = `
+<View
+  style={
+    Array [
+      Object {},
+      Object {
+        "height": 100,
+        "width": 100,
+      },
+    ]
+  }
+  testID="cardCarousel"
+>
+  <RCTScrollView
+    bounces={false}
+    contentInset={
+      Object {
+        "bottom": 0,
+        "left": 24,
+        "right": 24,
+        "top": 0,
+      }
+    }
+    data={
+      Array [
+        <Text>
+           screen 1
+        </Text>,
+        <Text>
+           screen 2
+        </Text>,
+      ]
+    }
+    decelerationRate="fast"
+    getItem={[Function]}
+    getItemCount={[Function]}
+    getItemLayout={[Function]}
+    horizontal={true}
+    keyExtractor={[Function]}
+    onContentSizeChange={[Function]}
+    onLayout={[Function]}
+    onMomentumScrollBegin={[Function]}
+    onMomentumScrollEnd={[Function]}
+    onScroll={[Function]}
+    onScrollBeginDrag={[Function]}
+    onScrollEndDrag={[Function]}
+    onViewableItemsChanged={[Function]}
+    pagingEnabled={true}
+    removeClippedSubviews={true}
+    renderItem={[Function]}
+    renderToHardwareTextureAndroid={true}
+    scrollEventThrottle={32}
+    showsHorizontalScrollIndicator={false}
+    snapToAlignment="center"
+    snapToInterval={0}
+    stickyHeaderIndices={Array []}
+    viewabilityConfig={
+      Object {
+        "itemVisiblePercentThreshold": 80,
+      }
+    }
+    viewabilityConfigCallbackPairs={
+      Array [
+        Object {
+          "onViewableItemsChanged": [Function],
+          "viewabilityConfig": Object {
+            "itemVisiblePercentThreshold": 80,
+          },
+        },
+      ]
+    }
+  >
+    <View>
+      <View
+        style={
+          Array [
+            Object {
+              "flexDirection": "row",
+            },
+            null,
+          ]
+        }
+      >
+        <View
+          style={
+            Array [
+              Object {
+                "padding": 8,
+              },
+              Object {
+                "width": 0,
+              },
+            ]
+          }
+        >
+          <View
+            style={
+              Array [
+                Object {
+                  "borderRadius": 8,
+                  "elevation": 4,
+                  "flex": 1,
+                  "shadowColor": "#001f23",
+                  "shadowOffset": Object {
+                    "height": 2,
+                    "width": 0,
+                  },
+                  "shadowOpacity": 0.12,
+                  "shadowRadius": 8,
+                },
+                undefined,
+              ]
+            }
+          >
+            <View
+              style={
+                Array [
+                  Object {
+                    "borderRadius": 12,
+                    "overflow": "hidden",
+                  },
+                  Array [
+                    Object {
+                      "borderRadius": 8,
+                      "flex": 1,
+                      "overflow": "hidden",
+                    },
+                    undefined,
+                  ],
+                ]
+              }
+            >
+              <Text
+                allowFontScaling={false}
+                style={
+                  Array [
+                    Object {
+                      "color": "#001f23",
+                      "fontFamily": "BeVietnamPro-Regular",
+                      "fontSize": 14,
+                      "letterSpacing": 0.42,
+                      "lineHeight": 22,
+                    },
+                    undefined,
+                  ]
+                }
+                themeFontSize="medium"
+                themeFontWeight="regular"
+                themeIntent="body"
+                themeTypeface="neutral"
+              >
+                 screen 1
+              </Text>
+            </View>
+          </View>
+        </View>
+      </View>
+      <View
+        style={
+          Array [
+            Object {
+              "flexDirection": "row",
+            },
+            null,
+          ]
+        }
+      >
+        <View
+          style={
+            Array [
+              Object {
+                "padding": 8,
+              },
+              Object {
+                "width": 0,
+              },
+            ]
+          }
+        >
+          <View
+            style={
+              Array [
+                Object {
+                  "borderRadius": 8,
+                  "elevation": 4,
+                  "flex": 1,
+                  "shadowColor": "#001f23",
+                  "shadowOffset": Object {
+                    "height": 2,
+                    "width": 0,
+                  },
+                  "shadowOpacity": 0.12,
+                  "shadowRadius": 8,
+                },
+                undefined,
+              ]
+            }
+          >
+            <View
+              style={
+                Array [
+                  Object {
+                    "borderRadius": 12,
+                    "overflow": "hidden",
+                  },
+                  Array [
+                    Object {
+                      "borderRadius": 8,
+                      "flex": 1,
+                      "overflow": "hidden",
+                    },
+                    undefined,
+                  ],
+                ]
+              }
+            >
+              <Text
+                allowFontScaling={false}
+                style={
+                  Array [
+                    Object {
+                      "color": "#001f23",
+                      "fontFamily": "BeVietnamPro-Regular",
+                      "fontSize": 14,
+                      "letterSpacing": 0.42,
+                      "lineHeight": 22,
+                    },
+                    undefined,
+                  ]
+                }
+                themeFontSize="medium"
+                themeFontWeight="regular"
+                themeIntent="body"
+                themeTypeface="neutral"
+              >
+                 screen 2
+              </Text>
+            </View>
+          </View>
+        </View>
+      </View>
+    </View>
+  </RCTScrollView>
+  <View
+    style={
+      Array [
+        Object {
+          "alignItems": "center",
+          "flexDirection": "row",
+        },
+        Array [
+          Object {
+            "alignSelf": "center",
+            "marginTop": 16,
+          },
+          undefined,
+        ],
+      ]
+    }
+    testID="pageControl"
+  >
+    <View
+      collapsable={false}
+      style={
+        Object {
+          "backgroundColor": "#401960",
+          "borderRadius": 999,
+          "height": 8,
+          "marginHorizontal": 8,
+          "opacity": 1,
+          "width": 24,
+        }
+      }
+      testID="page-control-indicator0"
+    />
+    <View
+      collapsable={false}
+      style={
+        Object {
+          "backgroundColor": "#401960",
+          "borderRadius": 999,
+          "height": 8,
+          "marginHorizontal": 8,
+          "opacity": 0.5,
+          "width": 8,
+        }
+      }
+      testID="page-control-indicator1"
+    />
+  </View>
+</View>
+`;
+
+exports[`CardCarousel ios should render correctly on iOS 1`] = `
 <View
   style={
     Array [

package/src/components/Error/StyledError.tsx

@@ -68,6 +68,7 @@ const StyledErrorTitle = styled(Typography.Text)(({ theme }) => ({
   textAlign: 'center',
   marginBottom: theme.__hd__.error.space.titleMarginBottom,
   color: theme.__hd__.error.colors.title,
+  lineHeight: theme.__hd__.error.lineHeight.title,
 }));
 
 const StyledErrorDescription = styled(Typography.Text)(({ theme }) => ({
@@ -75,6 +76,7 @@ const StyledErrorDescription = styled(Typography.Text)(({ theme }) => ({
   fontSize: theme.__hd__.error.fontSizes.description,
   textAlign: 'center',
   color: theme.__hd__.error.colors.description,
+  lineHeight: theme.__hd__.error.lineHeight.description,
 }));
 
 export {

package/src/components/Error/__tests__/__snapshots__/index.spec.tsx.snap

@@ -77,6 +77,7 @@ exports[`Error renders error screen with custom image element correctly 1`] = `
               "color": "#001f23",
               "fontFamily": "RebondGrotesque-SemiBold",
               "fontSize": 24,
+              "lineHeight": 32,
               "marginBottom": 8,
               "textAlign": "center",
             },
@@ -107,6 +108,7 @@ exports[`Error renders error screen with custom image element correctly 1`] = `
               "color": "#4d6265",
               "fontFamily": "RebondGrotesque",
               "fontSize": 18,
+              "lineHeight": 26,
               "textAlign": "center",
             },
             undefined,
@@ -209,6 +211,7 @@ exports[`Error renders error screen with image correctly 1`] = `
               "color": "#001f23",
               "fontFamily": "RebondGrotesque-SemiBold",
               "fontSize": 24,
+              "lineHeight": 32,
               "marginBottom": 8,
               "textAlign": "center",
             },
@@ -239,6 +242,7 @@ exports[`Error renders error screen with image correctly 1`] = `
               "color": "#4d6265",
               "fontFamily": "RebondGrotesque",
               "fontSize": 18,
+              "lineHeight": 26,
               "textAlign": "center",
             },
             undefined,
@@ -357,6 +361,7 @@ exports[`Error renders full screen error page correctly 1`] = `
                 "color": "#001f23",
                 "fontFamily": "RebondGrotesque-SemiBold",
                 "fontSize": 24,
+                "lineHeight": 32,
                 "marginBottom": 8,
                 "textAlign": "center",
               },
@@ -387,6 +392,7 @@ exports[`Error renders full screen error page correctly 1`] = `
                 "color": "#4d6265",
                 "fontFamily": "RebondGrotesque",
                 "fontSize": 18,
+                "lineHeight": 26,
                 "textAlign": "center",
               },
               undefined,
@@ -451,6 +457,7 @@ exports[`Error renders title only correctly 1`] = `
               "color": "#001f23",
               "fontFamily": "RebondGrotesque-SemiBold",
               "fontSize": 24,
+              "lineHeight": 32,
               "marginBottom": 8,
               "textAlign": "center",
             },
@@ -481,6 +488,7 @@ exports[`Error renders title only correctly 1`] = `
               "color": "#4d6265",
               "fontFamily": "RebondGrotesque",
               "fontSize": 18,
+              "lineHeight": 26,
               "textAlign": "center",
             },
             undefined,

package/src/components/RichTextEditor/RichTextEditor.tsx

@@ -10,7 +10,7 @@ import React, {
   useState,
 } from 'react';
 
-import { Keyboard, TouchableWithoutFeedback } from 'react-native';
+import { TouchableWithoutFeedback } from 'react-native';
 import { WebView } from 'react-native-webview';
 import type { ComponentType, ReactElement, Ref } from 'react';
 import type { StyleProp, ViewStyle } from 'react-native';
@@ -207,11 +207,10 @@ const RichTextEditor: ComponentType<RichTextEditorProps> = ({
   }, []);
 
   const requestBlur = useCallback(() => {
-    if (webview.current) {
+    if (webview.current && isFocused) {
       requestBlurEditor(webview.current);
-      Keyboard.dismiss();
     }
-  }, []);
+  }, [isFocused]);
 
   useImperativeHandle(forwardedRef, () => ({ requestBlur }), [requestBlur]);
 

package/src/components/Spinner/AnimatedSpinner.tsx

@@ -1,5 +1,5 @@
 import React, { useEffect, useRef } from 'react';
-import { Animated, Easing, StyleSheet } from 'react-native';
+import { Animated, Easing, Platform, StyleSheet } from 'react-native';
 
 import { StyledSpinnerDot, StyledSpinnerRow } from './StyledSpinner';
 
@@ -22,7 +22,7 @@ const AnimatedSpinner = ({
         toValue: 1,
         duration: 1200,
         easing: Easing.linear,
-        useNativeDriver: true,
+        useNativeDriver: Platform.OS !== 'web',
       })
     );