@hero-design/rn 8.109.0 → 8.109.1

package/.turbo/turbo-build.log

@@ -1,4 +1,4 @@
-(node:3326) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
+(node:3341) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
 (Use `node --trace-warnings ...` to show where the warning was created)
 
 src/index.ts → lib/index.js, es/index.js...
@@ -9,9 +9,9 @@ node_modules/d3-selection/src/selection/index.js -> node_modules/d3-selection/sr
 ...and 12 more
 (!) [plugin replace] @rollup/plugin-replace: 'preventAssignment' currently defaults to false. It is recommended to set this option to `true`, as the next major version will default this option to `true`.
 (!) [plugin node-resolve] preferring built-in module 'events' over local alternative at '/home/runner/work/hero-design/hero-design/node_modules/events/events.js', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning.or passing a function to 'preferBuiltins' to provide more fine-grained control over which built-in modules to prefer.
-created lib/index.js, es/index.js in 1m 12.1s
+created lib/index.js, es/index.js in 1m 12.6s
 
 /home/runner/work/hero-design/hero-design/packages/rn/src/locales/en_AU.ts, /home/runner/work/hero-design/hero-design/packages/rn/src/locales/en_CA.ts, /home/runner/work/hero-design/hero-design/packages/rn/src/locales/index.ts, /home/runner/work/hero-design/hero-design/packages/rn/src/locales/types.ts → ., ....
 (!) Generated empty chunks
 "locales/types" and "locales/types"
-created ., . in 20.9s
+created ., . in 21.1s

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @hero-design/rn
 
+## 8.109.1
+
+### Patch Changes
+
+- [#4236](https://github.com/Thinkei/hero-design/pull/4236) [`a873d35cddd56b5302bd4d0f95a2dfa887be995e`](https://github.com/Thinkei/hero-design/commit/a873d35cddd56b5302bd4d0f95a2dfa887be995e) Thanks [@cuongnguyeneh](https://github.com/cuongnguyeneh)! - [Button] call onPress callback with no args
+
 ## 8.109.0
 
 ### Minor Changes

package/es/index.js

@@ -10932,6 +10932,9 @@ var Button = function Button(_ref) {
     _useState2 = _slicedToArray(_useState, 2),
     isPressed = _useState2[0],
     setIsPressed = _useState2[1];
+  var handlePress = useCallback(function () {
+    return onPress();
+  }, [onPress]);
   useDeprecation("Button variant ".concat(deprecatedVariants.join(', '), " are deprecated."), deprecatedVariants.includes(themeVariant));
   var isCompactVariant = ['filled-compact', 'outlined-compact', 'text-compact', 'inline-text-compact'].includes(variant);
   var isMediumVariant = ['filled-medium', 'outlined-medium', 'text-medium'].includes(variant);
@@ -10981,7 +10984,7 @@ var Button = function Button(_ref) {
     accessibilityLabel: accessibilityLabel,
     disabled: disabled || loading,
     loading: loading,
-    onPress: onPress,
+    onPress: handlePress,
     testID: testID,
     themeButtonVariant: themeVariant,
     style: style,

package/lib/index.js

@@ -10961,6 +10961,9 @@ var Button = function Button(_ref) {
     _useState2 = _slicedToArray(_useState, 2),
     isPressed = _useState2[0],
     setIsPressed = _useState2[1];
+  var handlePress = React.useCallback(function () {
+    return onPress();
+  }, [onPress]);
   useDeprecation("Button variant ".concat(deprecatedVariants.join(', '), " are deprecated."), deprecatedVariants.includes(themeVariant));
   var isCompactVariant = ['filled-compact', 'outlined-compact', 'text-compact', 'inline-text-compact'].includes(variant);
   var isMediumVariant = ['filled-medium', 'outlined-medium', 'text-medium'].includes(variant);
@@ -11010,7 +11013,7 @@ var Button = function Button(_ref) {
     accessibilityLabel: accessibilityLabel,
     disabled: disabled || loading,
     loading: loading,
-    onPress: onPress,
+    onPress: handlePress,
     testID: testID,
     themeButtonVariant: themeVariant,
     style: style,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hero-design/rn",
-  "version": "8.109.0",
+  "version": "8.109.1",
   "license": "MIT",
   "main": "lib/index.js",
   "module": "es/index.js",

package/src/components/Button/Button.tsx

@@ -1,5 +1,5 @@
 import type { ReactChild, ReactNode } from 'react';
-import React, { useMemo, useState } from 'react';
+import React, { useCallback, useMemo, useState } from 'react';
 import type { StyleProp, ViewStyle } from 'react-native';
 import type { Theme } from '../../theme';
 import { useTheme } from '../../theme';
@@ -193,6 +193,7 @@ const Button = ({
     return isInlineText ? 'transparent' : getUnderlayColor(theme, themeVariant);
   }, [theme, themeVariant, isInlineText]);
   const [isPressed, setIsPressed] = useState(false);
+  const handlePress = useCallback(() => onPress(), [onPress]);
 
   useDeprecation(
     `Button variant ${deprecatedVariants.join(', ')} are deprecated.`,
@@ -282,7 +283,7 @@ const Button = ({
       accessibilityLabel={accessibilityLabel}
       disabled={disabled || loading}
       loading={loading}
-      onPress={onPress}
+      onPress={handlePress}
       testID={testID}
       themeButtonVariant={themeVariant}
       style={style}

package/src/components/Button/__tests__/Button.spec.tsx

@@ -104,6 +104,15 @@ describe('Button', () => {
         fireEvent.press(getByText('A button'));
         expect(onPress).toHaveBeenCalledTimes(1);
       });
+
+      it('triggers onPress with no arguments', () => {
+        const onPress = jest.fn();
+        const { getByText } = renderWithTheme(
+          <Button text="A button" onPress={onPress} />
+        );
+        fireEvent.press(getByText('A button'));
+        expect(onPress).toHaveBeenCalledWith();
+      });
     });
   });