@hero-design/eslint-plugin 8.44.0-alpha.0 → 9.0.0

package/CHANGELOG.md

@@ -0,0 +1,13 @@
+# @hero-design/eslint-plugin
+
+## 9.0.0
+
+### Major Changes
+
+- [#2563](https://github.com/Thinkei/hero-design/pull/2563) [`0254e47a8`](https://github.com/Thinkei/hero-design/commit/0254e47a838f0f431c3d72306b945247786ea7d1) Thanks [@luanlai2201](https://github.com/luanlai2201)! - [Internal] Remove eslint no-invalid-access-theme rule
+
+## 8.42.5
+
+### Patch Changes
+
+- [#2302](https://github.com/Thinkei/hero-design/pull/2302) [`2293190d1`](https://github.com/Thinkei/hero-design/commit/2293190d105fb97dc699e39990c3148f3509fafb) Thanks [@vinhphan-eh](https://github.com/vinhphan-eh)! - Upgrade expo sdk and react-native version

package/lib/index.js

@@ -43,7 +43,6 @@ module.exports = {
       plugins: ['@hero-design'],
       extends: ['plugin:@hero-design/internalRn'],
       rules: {
-        '@hero-design/no-invalid-theme-access': 'error',
         '@hero-design/not-recommended-import': [
           'warn',
           {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hero-design/eslint-plugin",
-  "version": "8.44.0-alpha.0",
+  "version": "9.0.0",
   "description": "Hero Design's eslint plugin",
   "keywords": [
     "eslint",
@@ -25,8 +25,8 @@
     "eslint": "^8.10.0",
     "eslint-plugin-eslint-plugin": "^5.0.0",
     "eslint-plugin-node": "^11.1.0",
-    "jest": "^29.6.2",
-    "prettier-config-hd": "8.44.0-alpha.0"
+    "jest": "^29.2.1",
+    "prettier-config-hd": "8.42.4"
   },
   "engines": {
     "node": "^14.17.0 || ^16.0.0 || >= 18.0.0"

package/lib/rules/no-invalid-theme-access.js

@@ -1,97 +0,0 @@
-'use strict';
-
-//------------------------------------------------------------------------------
-// Rule Definition
-//------------------------------------------------------------------------------
-
-const findPaths = (node, paths) => {
-  if (node == null) {
-    return paths;
-  }
-  const property = node.property;
-  if (
-    property != null &&
-    property.type === 'Identifier' &&
-    property.name != null
-  ) {
-    return findPaths(node.parent, [...paths, property.name]);
-  }
-  return paths;
-};
-
-const getError = (themePath) => {
-  if (themePath == null || themePath === '') {
-    return 'Invalid access to theming object';
-  }
-
-  if (themePath.startsWith('__hd__')) {
-    return 'Invalid access to component level theming object.';
-  }
-
-  return undefined;
-};
-
-/** @type {import('eslint').Rule.RuleModule} */
-module.exports = {
-  meta: {
-    type: 'problem', // `problem`, `suggestion`, or `layout`
-    docs: {
-      description: 'Invalidate theming access',
-      recommended: false,
-    },
-    fixable: null, // or "code" or "whitespace"
-    schema: [
-      {
-        properties: {
-          themeFile: { type: ['string'] },
-        },
-      },
-    ],
-    messages: {
-      invalidThemeAccess: 'Invalid access to component level theming object.',
-    },
-  },
-  create: function (context) {
-    return {
-      MemberExpression(node) {
-        const object = node.object;
-        if (object == null) {
-          return;
-        }
-
-        if (object.type === 'Identifier' && object.name === 'theme') {
-          const paths = findPaths(node, []);
-          const themePath = paths.join('.');
-          const error = getError(themePath);
-          if (error != null) {
-            context.report({
-              node,
-              messageId: 'invalidThemeAccess',
-            });
-          }
-          return;
-        }
-
-        const property = node.property;
-        if (
-          property != null &&
-          property.name === 'theme' &&
-          object.type === 'Identifier' &&
-          object.name === 'props'
-        ) {
-          // First element is theme, we don't need it
-          const [, ...paths] = findPaths(node, []);
-          const themePath = paths.join('.');
-          const error = getError(themePath);
-          if (error != null) {
-            context.report({
-              node,
-              messageId: 'invalidThemeAccess',
-            });
-          }
-          return;
-        }
-      },
-    };
-  },
-};

package/tests/lib/rules/no-invalid-theme-access.js

@@ -1,41 +0,0 @@
-'use strict';
-
-//------------------------------------------------------------------------------
-// Requirements
-//------------------------------------------------------------------------------
-
-var rule = require('../../../lib/rules/no-invalid-theme-access'),
-  RuleTester = require('eslint').RuleTester;
-
-//------------------------------------------------------------------------------
-// Tests
-//------------------------------------------------------------------------------
-
-var ruleTester = new RuleTester();
-ruleTester.run('no-invalid-theme-access', rule, {
-  valid: [
-    {
-      code: 'theme.space.medium',
-    },
-  ],
-  invalid: [
-    {
-      code: 'theme.__hd__.card.space.titlePadding',
-      errors: [
-        {
-          type: 'MemberExpression',
-          message: 'Invalid access to component level theming object.',
-        },
-      ],
-    },
-    {
-      code: 'props.theme.__hd__.card.space.titlePadding',
-      errors: [
-        {
-          type: 'MemberExpression',
-          message: 'Invalid access to component level theming object.',
-        },
-      ],
-    },
-  ],
-});