@heretek-ai/epistemic-swarm 0.7.19 → 0.7.21

package/runner/tests/test_swarm_config.py

@@ -38,6 +38,7 @@ from skills.swarm_config.configure import (  # noqa: E402
     ConfigHashError,
     ConfigStaleError,
     ConfigValidationError,
+    _FALLBACK_DEFAULT_CONFIG,
     config_hash,
     heal_config,
     load_config,
@@ -54,6 +55,26 @@ def _write_config(base_dir: Path, payload: dict) -> Path:
     return cfg_file
 
 
+class TestFallbackDrift(unittest.TestCase):
+    """Phase-03 R2: the standalone fallback literal tracks the canonical defaults.
+
+    Replaces the old comment-only "drift guard" (which named a test that never
+    existed): this is the real test. `_FALLBACK_DEFAULT_CONFIG` is the
+    standalone path of `DEFAULT_CONFIG`, so any key added to
+    `runner.schemas.CONFIG_DEFAULTS` without updating the literal fails here.
+    """
+
+    def test_fallback_literal_matches_canonical_defaults(self):
+        from runner.schemas import CONFIG_DEFAULTS
+
+        self.assertEqual(_FALLBACK_DEFAULT_CONFIG, CONFIG_DEFAULTS)
+
+    def test_fallback_literal_covers_every_schema_key(self):
+        from runner.schemas import CONFIG
+
+        self.assertEqual(set(_FALLBACK_DEFAULT_CONFIG), set(CONFIG["properties"]))
+
+
 class TestLegacyAgentPinMigration(unittest.TestCase):
     def test_legacy_pin_is_dropped_when_backend_is_auto(self):
         with tempfile.TemporaryDirectory() as tmp:

package/schemas/config.schema.json

@@ -294,6 +294,17 @@
       "x-scope": "dispatch",
       "x-restart": "next-run",
       "description": "Default named opencode agent profile for all roles; per-role agents.<role>.opencode_agent wins."
+    },
+    "mcp_servers": {
+      "type": "object",
+      "default": {},
+      "x-label": "MCP Servers",
+      "x-scope": "dispatch",
+      "x-restart": "next-run",
+      "description": "Persisted toggle map for the plugin-controllable MCP server set (bundled `iumbtems` server plus research servers declared in the project OpenCode config). Keys are server names; values are booleans (true = enabled, false = disabled). Absent keys mean enabled. Applied via ctx.mcp.transform (`disabled` reconcile); the catalog file config/mcp-research-servers.json is never modified.",
+      "additionalProperties": {
+        "type": "boolean"
+      }
     }
   }
 }

package/skills/swarm_config/SKILL.md

@@ -124,6 +124,32 @@ prefix of **at least 8 hex characters**; conflicting spellings are rejected with
 canonical validation (the legacy-pin migration stays in memory until the
 invalid values are fixed).
 
+## 4. TUI Settings Surface (OpenCode V2)
+
+On OpenCode V2 hosts the plugin ships a native settings surface — the recommended
+path when you are already inside OpenCode:
+
+- **`/swarm-config` wizard** — `ui.dialog.select/prompt/confirm`, one row per
+  canonical key with a provenance badge (`default` / `file` / `env-override`);
+  edits validate on save.
+- **`iumbtems.swarm-settings` status panel** — a read-only panel opened from the
+  command palette / keymap showing the effective rows with a **next-run** badge;
+  it never writes.
+
+Both read and write the same canonical `.research/config.json`, preferring the
+server `iumbtems.settings` RPC (server-side validation + `expectedHash` guard) and
+degrading to a direct-fs write (`plugins/opencode/config-io.js`) with a visible
+toast when `client.rpc` is absent. Live refresh subscribes to the RPC `changed`
+event; the 5s poll remains the floor.
+
+The honest boundaries are unchanged from the CLI/MCP paths: values apply to the
+**next** swarm run (the runner reads config at run start); per-role temperature
+does **not** govern spawned agents (dated `[NEGATIVE_KNOWLEDGE]`, waiver W3);
+out-of-range `IUMBTEMS_TEMPERATURE[_<ROLE>]` values are DISCARDED (fail-closed),
+not clamped; secrets stay in the environment. See `docs/SYSTEM_ARCHITECTURE.md`
+§6.7 for the full data flow, the `.research/.config.lock` protocol, the
+`expectedHash` guard, and the `ctx.storage` mirror.
+
 ## 5. Known limitations (recorded by phase 01)
 
 - **Crash-safety scope (F9):** the atomic-write regression patches `os.replace`

package/skills/swarm_config/configure.py

@@ -88,8 +88,9 @@ except ImportError:  # pragma: no cover - standalone skill copy
     _file_lock = _fallback_file_lock
 
 
-# Literal fallback for standalone runs; `test_config_schema.py` asserts it stays
-# byte-identical to `runner.schemas.CONFIG_DEFAULTS` (drift guard).
+# Literal fallback for standalone runs (runner/ not importable). It must stay
+# in sync with the canonical `runner.schemas.CONFIG_DEFAULTS`; the drift test
+# `TestFallbackDrift` in `runner/tests/test_swarm_config.py` asserts equality.
 _FALLBACK_DEFAULT_CONFIG: Dict[str, Any] = {
     "search_engine": "duckduckgo",
     "max_iterations": 2,
@@ -124,6 +125,8 @@ _FALLBACK_DEFAULT_CONFIG: Dict[str, Any] = {
     },
     "opencode_auto": None,  # None = enabled unless IUMBTEMS_OPENCODE_AUTO says no
     "opencode_agent": None,  # None = inline the prompt, no --agent
+    # Persisted MCP-server toggle map (phase 03); mirrors CONFIG_DEFAULTS.
+    "mcp_servers": {},
 }
 
 DEFAULT_CONFIG: Dict[str, Any] = copy.deepcopy(
@@ -691,15 +694,38 @@ def _save_or_report(cfg: Dict[str, Any]) -> Optional[Path]:
         return None
 
 
+def _legacy_pin_pending(base_dir: str = DEFAULT_RESEARCH_DIR) -> bool:
+    """Would the legacy-pin migration apply on the next save? (read-only)
+
+    R12/F2: the CLI read paths (`--show` / bare) must never write, so this
+    reports a pending migration without persisting it. Mirrors `heal_config`'s
+    decision — a legacy ``["claude", "-p"]`` pin is present AND the
+    would-be-persisted config passes canonical validation — but never writes.
+    """
+    try:
+        raw = _read_raw_config(get_config_path(base_dir))
+        if not isinstance(raw, dict):
+            return False
+        if not migrate_legacy_agent_backends(raw):
+            return False
+        return not validate_config(load_config(base_dir))
+    except Exception:
+        return False
+
+
 def main():
     cfg = load_config()
-    if heal_config():
-        print(
-            "ℹ️  Migrated legacy ['claude', '-p'] agent backend pin → host-native default."
-        )
     args = sys.argv[1:]
+    # R12/F2: compute the pending migration READ-ONLY. Heal only when an update
+    # is actually saved; a read (`--show` / bare) must never write.
+    pending_migration = _legacy_pin_pending()
 
     if not args or "--show" in args:
+        if pending_migration:
+            print(
+                "ℹ️  A legacy ['claude', '-p'] agent backend pin is present; it "
+                "will migrate to the host-native default on the next save."
+            )
         display_config(cfg)
         if not args:
             print("To edit settings, run:")
@@ -714,6 +740,10 @@ def main():
         cfg_path = _save_or_report(cfg)
         if cfg_path is None:
             raise SystemExit(1)
+        if pending_migration:
+            print(
+                "ℹ️  Migrated legacy ['claude', '-p'] agent backend pin → host-native default."
+            )
         print(f"✅ Configuration saved to {cfg_path}")
         display_config(cfg)
         return
@@ -723,6 +753,10 @@ def main():
         cfg_path = _save_or_report(cfg)
         if cfg_path is None:
             raise SystemExit(1)
+        if pending_migration:
+            print(
+                "ℹ️  Migrated legacy ['claude', '-p'] agent backend pin → host-native default."
+            )
         print(f"✅ Configuration updated and saved to {cfg_path}")
     display_config(cfg)