@herbertgao/pi-extensions 2026.9.0 → 2026.9.2

package/node_modules/pi-lens/dist/clients/finding-delivery-gate.js

@@ -87,17 +87,45 @@
  * degrade; they satisfy the same rule by dropping the authority marker
  * alongside the coordinate.
  *
- * ── Retirement (#1944) ────────────────────────────────────────────────────
- * Demote-not-drop assumes the agent CAN re-run to confirm. A past-EOF
- * demotion breaks that assumption: the file shrank past the cited lines, so
- * no re-run can ever speak to them, and the record re-served on every turn
- * end for the life of the session. Such a record is delivered ONCE, degraded,
- * then retired (`RuntimeCoordinator.retireDemotedPastEofBlocker`). The
- * suppression is recorded in the degradation ledger under
- * `demoted-finding-retired`, whose subject keeps the store and file, and the
- * delivered payload says so in its own words — so an empty advisory section
- * can only mean "nothing to say". Dependency-drift demotions keep in-bounds
- * coordinates the agent can act on and are NOT retired.
+ * ── Retirement (#1944, #1950, #2275) ──────────────────────────────────────
+ * Demote-not-drop assumes the agent CAN re-run to confirm. Retirement is what
+ * happens when re-serving a demotion forever stops being honest. Every kind
+ * of retirement records itself in the degradation ledger under
+ * `demoted-finding-retired`, whose subject keeps the store and the file
+ * (`inline-blocker:` / `widget-blocker:`), so an empty section can only mean
+ * "nothing to say". There are three, and they differ in WHY and in HOW MUCH
+ * they remove:
+ *
+ * 1. Past-EOF, unrecoverable (#1944). The file shrank past the cited lines,
+ *    so no re-run can ever speak to them. Delivered ONCE, degraded, then the
+ *    record is DROPPED (`RuntimeCoordinator.retireDemotedPastEofBlocker`).
+ *
+ * 2. Dependency-drift, inline-blocker channel (#1950). The coordinates are
+ *    still in bounds and a re-run COULD confirm them, so this is a delivery
+ *    cap, not a verdict: after `DEPENDENCY_DRIFT_MAX_DELIVERIES` turn-end
+ *    deliveries with no re-run the record is dropped from
+ *    `_pendingInlineBlockers`, and the LAST delivery carries a note saying it
+ *    will not be shown again and can still be confirmed
+ *    (`formatDeliveryCapNote`). Counting is deferred until the turn's content
+ *    is known not to be suppressed, so the count is deliveries the agent
+ *    actually received (#1950 fix round F1).
+ *
+ * 3. Dependency-drift, widget footer (#2275). The same cap number over the
+ *    widget store, which unlike the inline-blocker map backs MORE THAN ONE
+ *    surface — `lens_diagnostics mode=all` and `lens_diagnostic_mark` read
+ *    the same `allDiagnostics` list the footer draws from. So this retirement
+ *    HIDES rather than drops: the entry keeps its demotion and its place in
+ *    the error tally, gains `WidgetDiagnostic.footerRetired`, and only the
+ *    footer stops rendering it; mode=all carries the "capped, no longer shown
+ *    in the footer, re-run can still confirm" note in place of the inline
+ *    channel's last-delivery note. Its count is RENDERS, not turn ends — the
+ *    footer serves one record per pass, so `renderWidget` marks what it drew
+ *    and the turn-end step drains those marks. Dropping the record instead
+ *    would have made an unconfirmed LSP error read as CLEAN on mode=all.
+ *
+ * The rule the three share: a retirement may remove a finding from the
+ * surface that has re-served it, never from every surface at once, unless no
+ * re-run could ever confirm it (case 1).
  *
  * ── Explicit lag labels (the non-gated escape hatch) ──────────────────────
  * A store that cannot afford the freshness/disposition stack — because it
@@ -294,6 +322,7 @@ export const DELIVERY_SURFACES = {
     "agent-nudge:context-message": labeled("clients/agent-nudge.ts", "Post-edit file-touch nudge injected via `context`.", "Not a scanner finding store: no severity, no cited line, no cache — the " +
         "accumulator is drained and cleared at the moment of injection, so the " +
         "content IS the current state by construction.", "live"),
+    "test-runner-delivery:custom-entry": labeled("clients/test-runner-delivery.ts", "Post-agent test-runner failures in a non-context custom entry.", "The cache remains authoritative for pull diagnostics and the commit guard; this surface appends only after provenance validation and an idle recheck.", "live"),
     "project-diagnostics:persisted-snapshot": gated(LENS_DIAGNOSTICS_FILE, "Cross-session persisted project-diagnostics snapshot read.", ["reconcileProjectDiagnosticsSnapshot"], ["reconcileProjectDiagnosticsSnapshot("]),
     // ── #2028: the remaining agent-facing surfaces ──────────────────────────
     // Registered after #2028's root-cause review found the 🔴 STOP block
@@ -324,8 +353,16 @@ export const DELIVERY_SURFACES = {
         "command. Both inputs are read at decision time — the instance registry " +
         "and `git status` — so no stored finding is replayed and nothing can go " +
         "stale between detection and delivery.", "live"),
-    "read-guard-tool-lines:preflight-errors": labeled("clients/read-guard-tool-lines.ts", "Read-guard hashline BLOCKED / RE-READ REQUIRED preflight errors.", "Computed fresh per edit attempt and returned as that attempt's rejection — " +
-        "no cached findings are replayed, so there is no staleness window.", "live"),
+    "read-guard-tool-lines:preflight-errors": labeled("clients/read-guard-tool-lines.ts", "Read-guard hashline BLOCKED / RE-READ REQUIRED / PARTIAL APPLY / " +
+        "ALREADY APPLIED preflight errors (#2402).", "Computed fresh per edit attempt and returned as that attempt's rejection — " +
+        "no cached findings are replayed, so there is no staleness window. The " +
+        "PARTIAL APPLY and ALREADY APPLIED variants describe the same attempt's " +
+        "commit outcome; applied-edit recognition reads RuntimeCoordinator's " +
+        "session-scoped record, which resets with the session.", "live"),
+    "mutating-tool:adapter-preflight-errors": labeled("clients/mutating-tool.ts", "Shape-adapter BLOCKED preflight errors for hashline edit inputs the " +
+        "adapter recognized but could not resolve to a range (#2423).", "Computed fresh from the tool input on each attempt and returned as that " +
+        "attempt's rejection, so there is no staleness window. The adapters " +
+        "read only the call's own arguments; nothing cached is replayed.", "live"),
     "tool-call:duplicate-export-blocker": labeled("clients/runtime-tool-call.ts", "Duplicate-export STOP rejection returned inline with the failed edit.", "Synchronous preflight rejection computed per edit attempt; no stored state.", "live"),
     "agent-behavior:thrashing-notice": labeled("clients/agent-behavior-client.ts", "In-result thrashing/blind-write detection notice.", "Ephemeral notice computed at detection time inside the same tool result — " +
         "no persistence and no cache, so nothing can be stale.", "live"),

package/node_modules/pi-lens/dist/clients/format-service.js

@@ -73,7 +73,7 @@ export class FormatService {
         // Record new file state after formatting
         this.fileTime.read(absolutePath);
         for (const [index, result] of results.entries()) {
-            recordFormatter(absolutePath, formatters[index]?.name ?? "unknown", result.changed, result.success);
+            recordFormatter(absolutePath, formatters[index]?.name ?? "unknown", result.changed, result.success, result.outcome);
         }
         // Build summary
         const anyChanged = results.some((r) => r.changed);
@@ -85,6 +85,7 @@ export class FormatService {
                 success: r.success,
                 changed: r.changed,
                 error: r.error,
+                outcome: r.outcome,
             })),
             anyChanged,
             allSucceeded,
@@ -114,9 +115,13 @@ export class FormatService {
                 results.push(result);
             }
             catch (error) {
+                // A timeout or thrown error here is a real failure (#2413): the
+                // formatter ran and did not complete, distinct from an unavailable
+                // executable (which formatFile classifies before spawning).
                 results.push({
                     success: false,
                     changed: false,
+                    outcome: "failed",
                     error: error instanceof Error ? error.message : String(error),
                 });
             }
@@ -197,4 +202,3 @@ export function clearFormatServiceAndFileState() {
     resetFormatService();
 }
 // Re-export for convenience
-export { clearAllSessions } from "./file-time.js";