@herbertgao/pi-extensions 2026.8.7 → 2026.8.8

package/node_modules/@juicesharp/rpiv-ask-user-question/view/dialog-builder.ts

@@ -61,6 +61,47 @@ const OVERFLOW_UP = "↑";
 const OVERFLOW_DOWN = "↓";
 const OVERFLOW_BOTH = "↕";
 
+/** No-overflow path: append the residual spacer rows after the footer. */
+function renderFitsTerminal(natural: string[], spacerRows: number): string[] {
+	return spacerRows > 0 ? [...natural, ...Array<string>(spacerRows).fill("")] : natural;
+}
+
+/** Terminal too small for any middle content — show just chrome, hard-clamped to termRows. */
+function renderChromeOnly(natural: string[], topFixed: number, bottomFixed: number, termRows: number): string[] {
+	const chromeOnly = [...natural.slice(0, topFixed), ...natural.slice(natural.length - bottomFixed)];
+	return chromeOnly.length > termRows ? chromeOnly.slice(0, termRows) : chromeOnly;
+}
+
+/** Scroll window start, centered on the focused option; top-anchored when there is no interactive focus. */
+function computeScrollStart(
+	bodyRange: [number, number] | undefined,
+	headingCount: number,
+	availableMiddle: number,
+	middleRows: number,
+): number {
+	if (!bodyRange) return 0;
+	const focusedRowInMiddle = headingCount + bodyRange[0];
+	const focusedHeight = bodyRange[1] - bodyRange[0];
+	// Center the focused item vertically in the available middle space.
+	const idealStart = focusedRowInMiddle - Math.floor(Math.max(0, availableMiddle - focusedHeight) / 2);
+	return Math.max(0, Math.min(idealStart, middleRows - availableMiddle));
+}
+
+/** Mark the scroll window edges with overflow arrows; combined ↕ on a single-row middle. */
+function decorateOverflow(scrollableMiddle: string[], hasUp: boolean, hasDown: boolean, theme: Theme): void {
+	if (hasUp && hasDown && scrollableMiddle.length === 1) {
+		// Single-row middle: combined ↕ avoids the prior collision where ↓ overwrote ↑.
+		scrollableMiddle[0] = theme.fg("dim", OVERFLOW_BOTH);
+		return;
+	}
+	if (hasUp && scrollableMiddle.length > 0) {
+		scrollableMiddle[0] = theme.fg("dim", OVERFLOW_UP);
+	}
+	if (hasDown && scrollableMiddle.length > 0) {
+		scrollableMiddle[scrollableMiddle.length - 1] = theme.fg("dim", OVERFLOW_DOWN);
+	}
+}
+
 export type DialogState = QuestionnaireState;
 
 /** Per-tick projection of dialog state. Written by the adapter; read by the strategy thunk. */
@@ -127,6 +168,7 @@ export class DialogView implements StatefulView<DialogProps> {
 					theme: config.theme,
 					questions: config.questions,
 					submitPicker: config.submitPicker,
+					notesInput: config.notesInput,
 				})
 			: undefined;
 		this.maxFooterRowCount = Math.max(this.questionStrategy.footerRowCount, this.submitStrategy?.footerRowCount ?? 0);
@@ -173,48 +215,28 @@ export class DialogView implements StatefulView<DialogProps> {
 		const termRows = this.config.getTerminalRows();
 
 		if (natural.length + spacerRows <= termRows) {
-			// No overflow — add residual spacer rows after footer.
-			return spacerRows > 0 ? [...natural, ...Array<string>(spacerRows).fill("")] : natural;
+			return renderFitsTerminal(natural, spacerRows);
 		}
 
 		// OVERFLOW — apply 3-region partition with scroll-to-focus.
 		const availableMiddle = Math.max(0, termRows - topFixed - bottomFixed);
 		if (availableMiddle === 0) {
-			// Terminal too small for any middle content — show just chrome.
-			const chromeOnly = [...natural.slice(0, topFixed), ...natural.slice(natural.length - bottomFixed)];
-			return chromeOnly.length > termRows ? chromeOnly.slice(0, termRows) : chromeOnly;
-		}
-
-		const bodyRange = strategy.focusedItemRowRange(width, state);
-
-		// Compute scroll window centered on the focused option.
-		let scrollStart: number;
-		if (bodyRange) {
-			const focusedRowInMiddle = headingCount + bodyRange[0];
-			const focusedHeight = bodyRange[1] - bodyRange[0];
-			// Center the focused item vertically in the available middle space.
-			const idealStart = focusedRowInMiddle - Math.floor(Math.max(0, availableMiddle - focusedHeight) / 2);
-			scrollStart = Math.max(0, Math.min(idealStart, middleRows - availableMiddle));
-		} else {
-			// No interactive focus (submit tab) — top-anchor the middle.
-			scrollStart = 0;
+			return renderChromeOnly(natural, topFixed, bottomFixed, termRows);
 		}
 
+		const scrollStart = computeScrollStart(
+			strategy.focusedItemRowRange(width, state),
+			headingCount,
+			availableMiddle,
+			middleRows,
+		);
 		const scrollableMiddle = natural.slice(topFixed + scrollStart, topFixed + scrollStart + availableMiddle);
-
-		const hasUp = scrollStart > 0;
-		const hasDown = scrollStart + availableMiddle < middleRows;
-		if (hasUp && hasDown && scrollableMiddle.length === 1) {
-			// Single-row middle: combined ↕ avoids the prior collision where ↓ overwrote ↑.
-			scrollableMiddle[0] = this.config.theme.fg("dim", OVERFLOW_BOTH);
-		} else {
-			if (hasUp && scrollableMiddle.length > 0) {
-				scrollableMiddle[0] = this.config.theme.fg("dim", OVERFLOW_UP);
-			}
-			if (hasDown && scrollableMiddle.length > 0) {
-				scrollableMiddle[scrollableMiddle.length - 1] = this.config.theme.fg("dim", OVERFLOW_DOWN);
-			}
-		}
+		decorateOverflow(
+			scrollableMiddle,
+			scrollStart > 0,
+			scrollStart + availableMiddle < middleRows,
+			this.config.theme,
+		);
 
 		const result = [
 			...natural.slice(0, topFixed),

package/node_modules/@juicesharp/rpiv-ask-user-question/view/tab-content-strategy.ts

@@ -25,6 +25,9 @@ import type { StatefulView } from "./stateful-view.js";
 import type { TabComponents } from "./tab-components.js";
 
 const NOTES_HEADER = "Notes:";
+const GLOBAL_NOTES_HEADER = "Global note:";
+const REVIEW_GLOBAL_HINT = "n to add a note";
+const REVIEW_NOTE_LABEL = "Note";
 
 /**
  * Single-row, width-clipped chrome cell. The footer row count is invariant
@@ -160,10 +163,12 @@ export interface SubmitTabStrategyConfig {
 	theme: Theme;
 	questions: readonly QuestionData[];
 	submitPicker: Component | undefined;
+	/** Shared notes Editor — mounted into midRows while the global-note editor is open on this tab. */
+	notesInput: Editor;
 }
 
 export class SubmitTabStrategy implements TabContentStrategy {
-	/** Spacer(1) + Text(prompt, 1) + Spacer(1) + submitPicker(2) = 5 rendered rows. Fallback path lands at 5 via 2 trailing Spacer(1)s. */
+	/** Spacer(1) + Text(prompt, 1) + submitPicker(2) + OneLineClippedText(hint, 1) = 5 rendered rows. Fallback path lands at 5 via 2 Spacer(1)s in the picker slot. */
 	readonly footerRowCount = 5;
 
 	constructor(private readonly config: SubmitTabStrategyConfig) {}
@@ -191,6 +196,18 @@ export class SubmitTabStrategy implements TabContentStrategy {
 				c.addChild(new Text(this.config.theme.fg("dim", `     notes: ${a.notes}`), 1, 0));
 			}
 		}
+		// Committed global note (#182) as a review entry — pressing `n` gets visible
+		// feedback and the note is reviewable before submit. Same presence predicate as
+		// the reducer's doneFor lift. Hidden while the editor is open: the midRows editor
+		// (seeded with this text) is the live surface then, and a stale copy above it
+		// would read as a second note.
+		const globalNote = state.notesByTab.get(this.config.questions.length);
+		if (!state.notesVisible && globalNote && globalNote.length > 0) {
+			c.addChild(new Text(this.config.theme.fg("muted", ` ● ${t("review.note_label", REVIEW_NOTE_LABEL)}`), 1, 0));
+			c.addChild(
+				new Text(`   ${this.config.theme.fg("muted", "→")} ${this.config.theme.fg("text", globalNote)}`, 1, 0),
+			);
+		}
 		return c;
 	}
 
@@ -198,8 +215,17 @@ export class SubmitTabStrategy implements TabContentStrategy {
 		return this.bodyComponent(state).render(width).length;
 	}
 
-	midRows(_state: DialogState): Component[] {
-		return [];
+	midRows(state: DialogState): Component[] {
+		// notesVisible-gated mirror of QuestionTabStrategy.midRows: while the global-note
+		// editor is open, the shared notesInput mounts below the answer summary under its
+		// own header. The pseudo-index draft (notesByTab[questions.length]) is reducer-owned
+		// state; the strategy only renders.
+		if (!state.notesVisible) return [];
+		return [
+			new Text(this.config.theme.fg("muted", t("notes.global_header", GLOBAL_NOTES_HEADER)), 1, 0),
+			this.config.notesInput,
+			new Spacer(1),
+		];
 	}
 
 	footerRows(state: DialogState): Component[] {
@@ -217,7 +243,7 @@ export class SubmitTabStrategy implements TabContentStrategy {
 						"warning",
 						`${t("review.incomplete", INCOMPLETE_WARNING_PREFIX)} ${missing.join(", ")}`,
 					);
-		const out: Component[] = [new Spacer(1), new Text(promptText, 1, 0), new Spacer(1)];
+		const out: Component[] = [new Spacer(1), new Text(promptText, 1, 0)];
 		if (this.config.submitPicker) {
 			out.push(this.config.submitPicker);
 		} else {
@@ -225,6 +251,12 @@ export class SubmitTabStrategy implements TabContentStrategy {
 			out.push(new Spacer(1));
 			out.push(new Spacer(1));
 		}
+		// Bottom key-hint row, mirroring QuestionTabStrategy's footer idiom (one dim
+		// `·`-joined line below everything) — the prompt reads straight into its picker
+		// with no hint wedged between them. Always present so footerRowCount stays
+		// exactly 5. OneLineClippedText (not pi-tui Text) — a wrapped hint would inflate
+		// the footer past footerRowCount and desync the chrome's cross-tab height math.
+		out.push(new OneLineClippedText(this.config.theme.fg("dim", buildSubmitHintText(state)), 1));
 		return out;
 	}
 
@@ -268,3 +300,17 @@ export function buildHintText(
 	if (state.inputMode) parts.push(t("hint.clear", HINT_PART_CLEAR));
 	return parts.join(" · ");
 }
+
+/**
+ * Submit-tab counterpart of `buildHintText` — the same `·`-joined bottom-row idiom.
+ * Resting: Enter · ↑/↓ · `n to add a note` · Esc. While the global-note editor is
+ * open the note part drops (the editor is the affordance then) and the Shift+Enter
+ * newline hint is appended after cancel, mirroring the question tabs' notes-open shape.
+ */
+export function buildSubmitHintText(state: DialogState): string {
+	const parts: string[] = [t("hint.enter", HINT_PART_ENTER), t("hint.navigate", HINT_PART_NAV)];
+	if (!state.notesVisible) parts.push(t("review.global_hint", REVIEW_GLOBAL_HINT));
+	parts.push(t("hint.cancel", HINT_PART_CANCEL));
+	if (state.notesVisible) parts.push(t("hint.newline", HINT_PART_NEW_LINE));
+	return parts.join(" · ");
+}

package/node_modules/@narumitw/pi-btw/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@narumitw/pi-btw",
-	"version": "0.55.0",
+	"version": "0.55.1",
 	"description": "Pi extension that adds a /btw side-question command.",
 	"type": "module",
 	"license": "MIT",
@@ -47,7 +47,7 @@
 		"directory": "packages/pi-btw"
 	},
 	"dependencies": {
-		"@narumitw/pi-tui-kit": "^0.56.0"
+		"@narumitw/pi-tui-kit": "^0.57.0"
 	},
 	"peerDependencies": {
 		"@earendil-works/pi-ai": "*",