@herbertgao/pi-extensions 2026.8.4 → 2026.8.5

package/node_modules/pi-lens/dist/clients/format-events-publish.js

@@ -70,13 +70,14 @@
 import { logBusEvent } from "./bus-events-logger.js";
 import { isBusPublishEnabled } from "./bus-publish.js";
 import { normalizeFilePath } from "./path-utils.js";
+import { createLiveBusEmitter, recordStaleBusFailure, } from "./live-bus-emitter.js";
 export const BUS_FORMAT_QUEUED_EVENT = "pilens:format:queued";
 export const BUS_FORMAT_QUEUED_VERSION = 1;
 export const BUS_FORMAT_START_EVENT = "pilens:format:start";
 export const BUS_FORMAT_START_VERSION = 1;
 export const BUS_AUTOFIX_START_EVENT = "pilens:autofix:start";
 export const BUS_AUTOFIX_START_VERSION = 1;
-let busEmit;
+const liveEmitter = createLiveBusEmitter();
 let hasLoggedQueuedFailure = false;
 let hasLoggedQueuedUnwired = false;
 let hasLoggedQueuedDisabled = false;
@@ -93,11 +94,14 @@ let hasLoggedAutofixStartDisabled = false;
  * identical `pi.events.emit` binding, wired separately per producer.
  */
 export function wireFormatEventsBusEmitter(emitFn) {
-    busEmit = emitFn;
+    liveEmitter.wire(emitFn);
+}
+export function wireFormatEventsBusEmitterGetter(getter) {
+    liveEmitter.wireGetter(getter);
 }
 /** Test-only: reset module state between test files. */
 export function _resetFormatEventsPublishForTests() {
-    busEmit = undefined;
+    liveEmitter.reset();
     hasLoggedQueuedFailure = false;
     hasLoggedQueuedUnwired = false;
     hasLoggedQueuedDisabled = false;
@@ -127,6 +131,7 @@ export function publishFormatQueued(args) {
         }
         return;
     }
+    const busEmit = liveEmitter.get();
     if (!busEmit) {
         if (!hasLoggedQueuedUnwired) {
             hasLoggedQueuedUnwired = true;
@@ -147,6 +152,7 @@ export function publishFormatQueued(args) {
             tool: args.tool,
         };
         busEmit(BUS_FORMAT_QUEUED_EVENT, payload);
+        hasLoggedQueuedFailure = false;
         logBusEvent({
             event: BUS_FORMAT_QUEUED_EVENT,
             outcome: "emitted",
@@ -163,6 +169,7 @@ export function publishFormatQueued(args) {
         });
         if (!hasLoggedQueuedFailure) {
             hasLoggedQueuedFailure = true;
+            recordStaleBusFailure(BUS_FORMAT_QUEUED_EVENT, err);
             args.dbg?.(`format-events-publish: pilens:format:queued emit failed (further failures suppressed): ${err}`);
         }
     }
@@ -189,6 +196,7 @@ export function publishFormatStart(args) {
         }
         return;
     }
+    const busEmit = liveEmitter.get();
     if (!busEmit) {
         if (!hasLoggedStartUnwired) {
             hasLoggedStartUnwired = true;
@@ -210,6 +218,7 @@ export function publishFormatStart(args) {
             fileCount: paths.length,
         };
         busEmit(BUS_FORMAT_START_EVENT, payload);
+        hasLoggedStartFailure = false;
         logBusEvent({
             event: BUS_FORMAT_START_EVENT,
             outcome: "emitted",
@@ -226,6 +235,7 @@ export function publishFormatStart(args) {
         });
         if (!hasLoggedStartFailure) {
             hasLoggedStartFailure = true;
+            recordStaleBusFailure(BUS_FORMAT_START_EVENT, err);
             args.dbg?.(`format-events-publish: pilens:format:start emit failed (further failures suppressed): ${err}`);
         }
     }
@@ -255,6 +265,7 @@ export function publishAutofixStart(args) {
         }
         return;
     }
+    const busEmit = liveEmitter.get();
     if (!busEmit) {
         if (!hasLoggedAutofixStartUnwired) {
             hasLoggedAutofixStartUnwired = true;
@@ -277,6 +288,7 @@ export function publishAutofixStart(args) {
             eligibleCount: args.eligibleCount,
         };
         busEmit(BUS_AUTOFIX_START_EVENT, payload);
+        hasLoggedAutofixStartFailure = false;
         logBusEvent({
             event: BUS_AUTOFIX_START_EVENT,
             outcome: "emitted",
@@ -293,6 +305,7 @@ export function publishAutofixStart(args) {
         });
         if (!hasLoggedAutofixStartFailure) {
             hasLoggedAutofixStartFailure = true;
+            recordStaleBusFailure(BUS_AUTOFIX_START_EVENT, err);
             args.dbg?.(`format-events-publish: pilens:autofix:start emit failed (further failures suppressed): ${err}`);
         }
     }

package/node_modules/pi-lens/dist/clients/format-service.js

@@ -10,10 +10,11 @@
  * - FileTime integration for safety
  * - Explicit config wins; otherwise smart defaults apply
  */
+import { logExtension } from "./extension-log.js";
 import * as path from "node:path";
 import { recordFormatter } from "./widget-state.js";
 import { FileTime } from "./file-time.js";
-import { clearFormatterRuntimeState, formatFile, getFormattersForFile, } from "./formatters.js";
+import { loadFormatters } from "./formatters-lazy.js";
 // --- Configuration ---
 /** Reserved for future batching; formatting currently runs one selected formatter per file. */
 const DEFAULT_FORMATTER_CONCURRENCY = 1;
@@ -42,7 +43,12 @@ export class FormatService {
         }
         // Check if file was modified externally (safety check)
         if (this.fileTime.hasChanged(absolutePath)) {
-            console.warn(`[format] File ${absolutePath} modified externally, skipping format`);
+            logExtension({
+                subsystem: "format",
+                level: "warn",
+                message: `File ${absolutePath} modified externally, skipping format`,
+                metadata: { filePath: absolutePath },
+            });
             return {
                 filePath: absolutePath,
                 formatters: [],
@@ -53,7 +59,7 @@ export class FormatService {
         // Get formatters for this file
         const formatters = options.formatters
             ? await this.getFormattersByName(options.formatters)
-            : await getFormattersForFile(absolutePath, cwd);
+            : await (await loadFormatters()).getFormattersForFile(absolutePath, cwd);
         if (formatters.length === 0) {
             return {
                 filePath: absolutePath,
@@ -90,13 +96,19 @@ export class FormatService {
     async runFormattersWithConcurrency(filePath, formatters, _concurrency = DEFAULT_FORMATTER_CONCURRENCY) {
         const results = [];
         for (const formatter of formatters) {
+            // #1097: keep the timer handle so it can be cleared once the race
+            // settles. An uncleared, REF'D 30s setTimeout that outlives a fast
+            // `formatFile` win would keep a one-shot `pi --print` process alive for
+            // up to 30s after completion (same uncleared-race-timeout class as the
+            // LSP client-wait leak fixed in clients/lsp/index.ts).
+            let formatTimer;
             try {
                 const timeoutMs = 30000;
                 const timeoutPromise = new Promise((_, reject) => {
-                    setTimeout(() => reject(new Error(`Formatter ${formatter.name} timed out after ${timeoutMs}ms`)), timeoutMs);
+                    formatTimer = setTimeout(() => reject(new Error(`Formatter ${formatter.name} timed out after ${timeoutMs}ms`)), timeoutMs);
                 });
                 const result = await Promise.race([
-                    formatFile(filePath, formatter),
+                    loadFormatters().then(({ formatFile }) => formatFile(filePath, formatter)),
                     timeoutPromise,
                 ]);
                 results.push(result);
@@ -108,6 +120,10 @@ export class FormatService {
                     error: error instanceof Error ? error.message : String(error),
                 });
             }
+            finally {
+                if (formatTimer)
+                    clearTimeout(formatTimer);
+            }
         }
         return results;
     }
@@ -115,7 +131,7 @@ export class FormatService {
      * Get formatters by name (for explicit formatter selection)
      */
     async getFormattersByName(names) {
-        const { listAllFormatters, ...formatters } = await import("./formatters.js");
+        const { listAllFormatters, ...formatters } = await loadFormatters();
         const allNames = listAllFormatters();
         return names
             .filter((name) => allNames.includes(name))
@@ -151,7 +167,7 @@ export class FormatService {
      * Clear detection cache
      */
     clearCache() {
-        clearFormatterRuntimeState();
+        void loadFormatters().then(({ clearFormatterRuntimeState }) => clearFormatterRuntimeState());
     }
 }
 // --- Singleton Instance ---
@@ -169,7 +185,7 @@ export function getFormatService(sessionID, enabled = true) {
     return globalFormatService;
 }
 export function resetFormatService() {
-    clearFormatterRuntimeState();
+    void loadFormatters().then(({ clearFormatterRuntimeState }) => clearFormatterRuntimeState());
     globalFormatService = null;
     currentSessionID = null;
 }

package/node_modules/pi-lens/dist/clients/formatters-lazy.js

@@ -0,0 +1,8 @@
+/** Shared lazy formatter catalog seam (#1394). */
+let formatterPromise;
+export function warmFormatters() {
+    return (formatterPromise ??= import("./formatters.js"));
+}
+export function loadFormatters() {
+    return warmFormatters();
+}