@herb-tools/linter 0.8.10 → 0.9.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (587) hide show
  1. package/README.md +5 -5
  2. package/dist/{src/cli → cli}/argument-parser.js +15 -2
  3. package/dist/cli/argument-parser.js.map +1 -0
  4. package/dist/{src/cli → cli}/file-processor.js +155 -9
  5. package/dist/cli/file-processor.js.map +1 -0
  6. package/dist/cli/file-url.js +6 -0
  7. package/dist/cli/file-url.js.map +1 -0
  8. package/dist/cli/formatters/base-formatter.js.map +1 -0
  9. package/dist/{src/cli → cli}/formatters/detailed-formatter.js +16 -19
  10. package/dist/cli/formatters/detailed-formatter.js.map +1 -0
  11. package/dist/cli/formatters/github-actions-formatter.js.map +1 -0
  12. package/dist/cli/formatters/index.js.map +1 -0
  13. package/dist/cli/formatters/json-formatter.js.map +1 -0
  14. package/dist/cli/formatters/simple-formatter.js +54 -0
  15. package/dist/cli/formatters/simple-formatter.js.map +1 -0
  16. package/dist/cli/index.js.map +1 -0
  17. package/dist/cli/lint-worker.js +143 -0
  18. package/dist/cli/lint-worker.js.map +1 -0
  19. package/dist/cli/output-manager.js.map +1 -0
  20. package/dist/{src/cli → cli}/summary-reporter.js +13 -16
  21. package/dist/cli/summary-reporter.js.map +1 -0
  22. package/dist/{src/cli.js → cli.js} +5 -3
  23. package/dist/cli.js.map +1 -0
  24. package/dist/{src/custom-rule-loader.js → custom-rule-loader.js} +20 -4
  25. package/dist/custom-rule-loader.js.map +1 -0
  26. package/dist/herb-disable-comment-utils.js.map +1 -0
  27. package/dist/herb-lint.js +61834 -17340
  28. package/dist/herb-lint.js.map +1 -1
  29. package/dist/index.cjs +3109 -956
  30. package/dist/index.cjs.map +1 -1
  31. package/dist/index.js +2969 -897
  32. package/dist/index.js.map +1 -1
  33. package/dist/lint-worker.js +72889 -0
  34. package/dist/lint-worker.js.map +1 -0
  35. package/dist/linter-ignore.js.map +1 -0
  36. package/dist/{src/linter.js → linter.js} +89 -74
  37. package/dist/linter.js.map +1 -0
  38. package/dist/loader.cjs +32163 -7842
  39. package/dist/loader.cjs.map +1 -1
  40. package/dist/loader.js +32121 -7828
  41. package/dist/loader.js.map +1 -1
  42. package/dist/parse-cache.js +30 -0
  43. package/dist/parse-cache.js.map +1 -0
  44. package/dist/rules/actionview-no-silent-helper.js +45 -0
  45. package/dist/rules/actionview-no-silent-helper.js.map +1 -0
  46. package/dist/rules/actionview-no-silent-render.js +31 -0
  47. package/dist/rules/actionview-no-silent-render.js.map +1 -0
  48. package/dist/{src/rules → rules}/erb-comment-syntax.js +2 -2
  49. package/dist/rules/erb-comment-syntax.js.map +1 -0
  50. package/dist/{src/rules → rules}/erb-no-case-node-children.js +5 -3
  51. package/dist/rules/erb-no-case-node-children.js.map +1 -0
  52. package/dist/rules/erb-no-conditional-html-element.js +38 -0
  53. package/dist/rules/erb-no-conditional-html-element.js.map +1 -0
  54. package/dist/rules/erb-no-conditional-open-tag.js +24 -0
  55. package/dist/rules/erb-no-conditional-open-tag.js.map +1 -0
  56. package/dist/rules/erb-no-duplicate-branch-elements.js +329 -0
  57. package/dist/rules/erb-no-duplicate-branch-elements.js.map +1 -0
  58. package/dist/rules/erb-no-empty-control-flow.js +190 -0
  59. package/dist/rules/erb-no-empty-control-flow.js.map +1 -0
  60. package/dist/{src/rules → rules}/erb-no-empty-tags.js +2 -2
  61. package/dist/rules/erb-no-empty-tags.js.map +1 -0
  62. package/dist/{src/rules → rules}/erb-no-extra-newline.js +4 -21
  63. package/dist/rules/erb-no-extra-newline.js.map +1 -0
  64. package/dist/{src/rules → rules}/erb-no-extra-whitespace-inside-tags.js +39 -13
  65. package/dist/rules/erb-no-extra-whitespace-inside-tags.js.map +1 -0
  66. package/dist/rules/erb-no-inline-case-conditions.js +40 -0
  67. package/dist/rules/erb-no-inline-case-conditions.js.map +1 -0
  68. package/dist/rules/erb-no-instance-variables-in-partials.js +67 -0
  69. package/dist/rules/erb-no-instance-variables-in-partials.js.map +1 -0
  70. package/dist/rules/erb-no-interpolated-class-names.js +47 -0
  71. package/dist/rules/erb-no-interpolated-class-names.js.map +1 -0
  72. package/dist/rules/erb-no-javascript-tag-helper.js +34 -0
  73. package/dist/rules/erb-no-javascript-tag-helper.js.map +1 -0
  74. package/dist/{src/rules → rules}/erb-no-output-control-flow.js +9 -12
  75. package/dist/rules/erb-no-output-control-flow.js.map +1 -0
  76. package/dist/rules/erb-no-output-in-attribute-name.js +30 -0
  77. package/dist/rules/erb-no-output-in-attribute-name.js.map +1 -0
  78. package/dist/rules/erb-no-output-in-attribute-position.js +30 -0
  79. package/dist/rules/erb-no-output-in-attribute-position.js.map +1 -0
  80. package/dist/rules/erb-no-raw-output-in-attribute-value.js +35 -0
  81. package/dist/rules/erb-no-raw-output-in-attribute-value.js.map +1 -0
  82. package/dist/rules/erb-no-silent-statement.js +44 -0
  83. package/dist/rules/erb-no-silent-statement.js.map +1 -0
  84. package/dist/{src/rules → rules}/erb-no-silent-tag-in-attribute-name.js +2 -2
  85. package/dist/rules/erb-no-silent-tag-in-attribute-name.js.map +1 -0
  86. package/dist/rules/erb-no-statement-in-script.js +58 -0
  87. package/dist/rules/erb-no-statement-in-script.js.map +1 -0
  88. package/dist/rules/erb-no-then-in-control-flow.js +45 -0
  89. package/dist/rules/erb-no-then-in-control-flow.js.map +1 -0
  90. package/dist/rules/erb-no-trailing-whitespace.js +138 -0
  91. package/dist/rules/erb-no-trailing-whitespace.js.map +1 -0
  92. package/dist/rules/erb-no-unsafe-js-attribute.js +36 -0
  93. package/dist/rules/erb-no-unsafe-js-attribute.js.map +1 -0
  94. package/dist/rules/erb-no-unsafe-raw.js +63 -0
  95. package/dist/rules/erb-no-unsafe-raw.js.map +1 -0
  96. package/dist/rules/erb-no-unsafe-script-interpolation.js +88 -0
  97. package/dist/rules/erb-no-unsafe-script-interpolation.js.map +1 -0
  98. package/dist/{src/rules → rules}/erb-prefer-image-tag-helper.js +5 -4
  99. package/dist/rules/erb-prefer-image-tag-helper.js.map +1 -0
  100. package/dist/{src/rules → rules}/erb-require-trailing-newline.js +2 -2
  101. package/dist/rules/erb-require-trailing-newline.js.map +1 -0
  102. package/dist/{src/rules → rules}/erb-require-whitespace-inside-tags.js +39 -15
  103. package/dist/rules/erb-require-whitespace-inside-tags.js.map +1 -0
  104. package/dist/{src/rules → rules}/erb-right-trim.js +2 -2
  105. package/dist/rules/erb-right-trim.js.map +1 -0
  106. package/dist/{src/rules → rules}/erb-strict-locals-comment-syntax.js +4 -4
  107. package/dist/rules/erb-strict-locals-comment-syntax.js.map +1 -0
  108. package/dist/{src/rules → rules}/erb-strict-locals-required.js +2 -2
  109. package/dist/rules/erb-strict-locals-required.js.map +1 -0
  110. package/dist/rules/file-utils.js.map +1 -0
  111. package/dist/rules/herb-disable-comment-base.js.map +1 -0
  112. package/dist/{src/rules → rules}/herb-disable-comment-malformed.js +2 -2
  113. package/dist/rules/herb-disable-comment-malformed.js.map +1 -0
  114. package/dist/{src/rules → rules}/herb-disable-comment-missing-rules.js +2 -2
  115. package/dist/rules/herb-disable-comment-missing-rules.js.map +1 -0
  116. package/dist/{src/rules → rules}/herb-disable-comment-no-duplicate-rules.js +2 -2
  117. package/dist/rules/herb-disable-comment-no-duplicate-rules.js.map +1 -0
  118. package/dist/{src/rules → rules}/herb-disable-comment-no-redundant-all.js +2 -2
  119. package/dist/rules/herb-disable-comment-no-redundant-all.js.map +1 -0
  120. package/dist/{src/rules → rules}/herb-disable-comment-unnecessary.js +2 -2
  121. package/dist/rules/herb-disable-comment-unnecessary.js.map +1 -0
  122. package/dist/{src/rules → rules}/herb-disable-comment-valid-rule-name.js +2 -2
  123. package/dist/rules/herb-disable-comment-valid-rule-name.js.map +1 -0
  124. package/dist/rules/html-allowed-script-type.js +57 -0
  125. package/dist/rules/html-allowed-script-type.js.map +1 -0
  126. package/dist/rules/html-anchor-require-href.js +68 -0
  127. package/dist/rules/html-anchor-require-href.js.map +1 -0
  128. package/dist/{src/rules → rules}/html-aria-attribute-must-be-valid.js +3 -3
  129. package/dist/rules/html-aria-attribute-must-be-valid.js.map +1 -0
  130. package/dist/{src/rules → rules}/html-aria-label-is-well-formatted.js +3 -3
  131. package/dist/rules/html-aria-label-is-well-formatted.js.map +1 -0
  132. package/dist/{src/rules → rules}/html-aria-level-must-be-valid.js +3 -3
  133. package/dist/rules/html-aria-level-must-be-valid.js.map +1 -0
  134. package/dist/{src/rules → rules}/html-aria-role-heading-requires-level.js +5 -4
  135. package/dist/rules/html-aria-role-heading-requires-level.js.map +1 -0
  136. package/dist/{src/rules → rules}/html-aria-role-must-be-valid.js +3 -3
  137. package/dist/rules/html-aria-role-must-be-valid.js.map +1 -0
  138. package/dist/{src/rules → rules}/html-attribute-double-quotes.js +4 -4
  139. package/dist/rules/html-attribute-double-quotes.js.map +1 -0
  140. package/dist/{src/rules → rules}/html-attribute-equals-spacing.js +2 -2
  141. package/dist/rules/html-attribute-equals-spacing.js.map +1 -0
  142. package/dist/{src/rules → rules}/html-attribute-values-require-quotes.js +2 -2
  143. package/dist/rules/html-attribute-values-require-quotes.js.map +1 -0
  144. package/dist/{src/rules → rules}/html-avoid-both-disabled-and-aria-disabled.js +9 -9
  145. package/dist/rules/html-avoid-both-disabled-and-aria-disabled.js.map +1 -0
  146. package/dist/{src/rules → rules}/html-body-only-elements.js +5 -4
  147. package/dist/rules/html-body-only-elements.js.map +1 -0
  148. package/dist/{src/rules → rules}/html-boolean-attributes-no-value.js +4 -3
  149. package/dist/rules/html-boolean-attributes-no-value.js.map +1 -0
  150. package/dist/rules/html-details-has-summary.js +52 -0
  151. package/dist/rules/html-details-has-summary.js.map +1 -0
  152. package/dist/{src/rules → rules}/html-head-only-elements.js +6 -5
  153. package/dist/rules/html-head-only-elements.js.map +1 -0
  154. package/dist/{src/rules → rules}/html-iframe-has-title.js +8 -11
  155. package/dist/rules/html-iframe-has-title.js.map +1 -0
  156. package/dist/{src/rules → rules}/html-img-require-alt.js +11 -5
  157. package/dist/rules/html-img-require-alt.js.map +1 -0
  158. package/dist/{src/rules → rules}/html-input-require-autocomplete.js +7 -10
  159. package/dist/rules/html-input-require-autocomplete.js.map +1 -0
  160. package/dist/{src/rules → rules}/html-navigation-has-label.js +6 -5
  161. package/dist/rules/html-navigation-has-label.js.map +1 -0
  162. package/dist/rules/html-no-abstract-roles.js +29 -0
  163. package/dist/rules/html-no-abstract-roles.js.map +1 -0
  164. package/dist/rules/html-no-aria-hidden-on-body.js +42 -0
  165. package/dist/rules/html-no-aria-hidden-on-body.js.map +1 -0
  166. package/dist/{src/rules → rules}/html-no-aria-hidden-on-focusable.js +6 -5
  167. package/dist/rules/html-no-aria-hidden-on-focusable.js.map +1 -0
  168. package/dist/{src/rules → rules}/html-no-block-inside-inline.js +6 -9
  169. package/dist/rules/html-no-block-inside-inline.js.map +1 -0
  170. package/dist/{src/rules → rules}/html-no-duplicate-attributes.js +4 -3
  171. package/dist/rules/html-no-duplicate-attributes.js.map +1 -0
  172. package/dist/{src/rules → rules}/html-no-duplicate-ids.js +14 -11
  173. package/dist/rules/html-no-duplicate-ids.js.map +1 -0
  174. package/dist/{src/rules → rules}/html-no-duplicate-meta-names.js +22 -20
  175. package/dist/rules/html-no-duplicate-meta-names.js.map +1 -0
  176. package/dist/{src/rules → rules}/html-no-empty-attributes.js +2 -2
  177. package/dist/rules/html-no-empty-attributes.js.map +1 -0
  178. package/dist/rules/html-no-empty-headings.js +98 -0
  179. package/dist/rules/html-no-empty-headings.js.map +1 -0
  180. package/dist/{src/rules → rules}/html-no-nested-links.js +23 -15
  181. package/dist/rules/html-no-nested-links.js.map +1 -0
  182. package/dist/{src/rules → rules}/html-no-positive-tab-index.js +3 -3
  183. package/dist/rules/html-no-positive-tab-index.js.map +1 -0
  184. package/dist/{src/rules → rules}/html-no-self-closing.js +4 -4
  185. package/dist/rules/html-no-self-closing.js.map +1 -0
  186. package/dist/{src/rules → rules}/html-no-space-in-tag.js +4 -6
  187. package/dist/rules/html-no-space-in-tag.js.map +1 -0
  188. package/dist/{src/rules → rules}/html-no-title-attribute.js +6 -5
  189. package/dist/rules/html-no-title-attribute.js.map +1 -0
  190. package/dist/{src/rules → rules}/html-no-underscores-in-attribute-names.js +2 -2
  191. package/dist/rules/html-no-underscores-in-attribute-names.js.map +1 -0
  192. package/dist/rules/html-require-closing-tags.js +29 -0
  193. package/dist/rules/html-require-closing-tags.js.map +1 -0
  194. package/dist/{src/rules → rules}/html-tag-name-lowercase.js +13 -9
  195. package/dist/rules/html-tag-name-lowercase.js.map +1 -0
  196. package/dist/{src/rules → rules}/index.js +27 -4
  197. package/dist/rules/index.js.map +1 -0
  198. package/dist/{src/rules → rules}/parser-no-errors.js +3 -3
  199. package/dist/rules/parser-no-errors.js.map +1 -0
  200. package/dist/{src/rules → rules}/rule-utils.js +144 -219
  201. package/dist/rules/rule-utils.js.map +1 -0
  202. package/dist/rules/string-utils.js.map +1 -0
  203. package/dist/{src/rules → rules}/svg-tag-name-capitalization.js +7 -6
  204. package/dist/rules/svg-tag-name-capitalization.js.map +1 -0
  205. package/dist/rules/turbo-permanent-require-id.js +34 -0
  206. package/dist/rules/turbo-permanent-require-id.js.map +1 -0
  207. package/dist/{src/rules.js → rules.js} +62 -10
  208. package/dist/rules.js.map +1 -0
  209. package/dist/types/cli/argument-parser.d.ts +1 -0
  210. package/dist/types/cli/file-processor.d.ts +13 -0
  211. package/dist/types/cli/file-url.d.ts +1 -0
  212. package/dist/types/cli/index.d.ts +1 -0
  213. package/dist/types/cli/lint-worker.d.ts +34 -0
  214. package/dist/types/custom-rule-loader.d.ts +4 -0
  215. package/dist/types/index.d.ts +2 -0
  216. package/dist/types/linter.d.ts +13 -6
  217. package/dist/types/parse-cache.d.ts +9 -0
  218. package/dist/types/{src/rules/html-aria-level-must-be-valid.d.ts → rules/actionview-no-silent-helper.d.ts} +4 -3
  219. package/dist/types/rules/actionview-no-silent-render.d.ts +9 -0
  220. package/dist/types/rules/erb-comment-syntax.d.ts +1 -1
  221. package/dist/types/rules/erb-no-case-node-children.d.ts +1 -1
  222. package/dist/types/{src/rules/herb-disable-comment-malformed.d.ts → rules/erb-no-conditional-html-element.d.ts} +3 -3
  223. package/dist/types/{src/rules/erb-prefer-image-tag-helper.d.ts → rules/erb-no-conditional-open-tag.d.ts} +3 -3
  224. package/dist/types/rules/erb-no-duplicate-branch-elements.d.ts +18 -0
  225. package/dist/types/{src/rules/html-anchor-require-href.d.ts → rules/erb-no-empty-control-flow.d.ts} +2 -2
  226. package/dist/types/rules/erb-no-empty-tags.d.ts +1 -1
  227. package/dist/types/rules/erb-no-extra-newline.d.ts +1 -1
  228. package/dist/types/rules/erb-no-extra-whitespace-inside-tags.d.ts +1 -1
  229. package/dist/types/{src/rules/html-no-duplicate-attributes.d.ts → rules/erb-no-inline-case-conditions.d.ts} +4 -3
  230. package/dist/types/rules/erb-no-instance-variables-in-partials.d.ts +10 -0
  231. package/dist/types/{src/rules/html-no-aria-hidden-on-focusable.d.ts → rules/erb-no-interpolated-class-names.d.ts} +2 -2
  232. package/dist/types/{src/rules/html-aria-attribute-must-be-valid.d.ts → rules/erb-no-javascript-tag-helper.d.ts} +2 -2
  233. package/dist/types/rules/erb-no-output-control-flow.d.ts +1 -1
  234. package/dist/types/{src/rules/erb-no-silent-tag-in-attribute-name.d.ts → rules/erb-no-output-in-attribute-name.d.ts} +2 -2
  235. package/dist/types/{src/rules/herb-disable-comment-missing-rules.d.ts → rules/erb-no-output-in-attribute-position.d.ts} +2 -2
  236. package/dist/types/{src/rules/erb-no-empty-tags.d.ts → rules/erb-no-raw-output-in-attribute-value.d.ts} +2 -2
  237. package/dist/types/{src/rules/html-no-title-attribute.d.ts → rules/erb-no-silent-statement.d.ts} +4 -3
  238. package/dist/types/rules/erb-no-silent-tag-in-attribute-name.d.ts +1 -1
  239. package/dist/types/{src/rules/html-navigation-has-label.d.ts → rules/erb-no-statement-in-script.d.ts} +2 -2
  240. package/dist/types/rules/erb-no-then-in-control-flow.d.ts +9 -0
  241. package/dist/types/rules/erb-no-trailing-whitespace.d.ts +19 -0
  242. package/dist/types/{src/rules/html-no-positive-tab-index.d.ts → rules/erb-no-unsafe-js-attribute.d.ts} +2 -2
  243. package/dist/types/{src/rules/erb-no-case-node-children.d.ts → rules/erb-no-unsafe-raw.d.ts} +2 -2
  244. package/dist/types/rules/erb-no-unsafe-script-interpolation.d.ts +9 -0
  245. package/dist/types/rules/erb-prefer-image-tag-helper.d.ts +1 -1
  246. package/dist/types/rules/erb-require-trailing-newline.d.ts +1 -1
  247. package/dist/types/rules/erb-require-whitespace-inside-tags.d.ts +1 -1
  248. package/dist/types/rules/erb-right-trim.d.ts +1 -1
  249. package/dist/types/rules/erb-strict-locals-comment-syntax.d.ts +1 -1
  250. package/dist/types/rules/erb-strict-locals-required.d.ts +1 -1
  251. package/dist/types/rules/herb-disable-comment-malformed.d.ts +1 -1
  252. package/dist/types/rules/herb-disable-comment-missing-rules.d.ts +1 -1
  253. package/dist/types/rules/herb-disable-comment-no-duplicate-rules.d.ts +1 -1
  254. package/dist/types/rules/herb-disable-comment-no-redundant-all.d.ts +1 -1
  255. package/dist/types/rules/herb-disable-comment-unnecessary.d.ts +1 -1
  256. package/dist/types/rules/herb-disable-comment-valid-rule-name.d.ts +1 -1
  257. package/dist/types/{src/rules/html-no-empty-attributes.d.ts → rules/html-allowed-script-type.d.ts} +2 -2
  258. package/dist/types/rules/html-anchor-require-href.d.ts +3 -2
  259. package/dist/types/rules/html-aria-attribute-must-be-valid.d.ts +1 -1
  260. package/dist/types/rules/html-aria-label-is-well-formatted.d.ts +1 -1
  261. package/dist/types/rules/html-aria-level-must-be-valid.d.ts +1 -1
  262. package/dist/types/rules/html-aria-role-heading-requires-level.d.ts +1 -1
  263. package/dist/types/rules/html-aria-role-must-be-valid.d.ts +1 -1
  264. package/dist/types/rules/html-attribute-double-quotes.d.ts +1 -1
  265. package/dist/types/rules/html-attribute-equals-spacing.d.ts +1 -1
  266. package/dist/types/rules/html-attribute-values-require-quotes.d.ts +1 -1
  267. package/dist/types/rules/html-avoid-both-disabled-and-aria-disabled.d.ts +1 -1
  268. package/dist/types/rules/html-body-only-elements.d.ts +1 -1
  269. package/dist/types/rules/html-boolean-attributes-no-value.d.ts +1 -1
  270. package/dist/types/rules/html-details-has-summary.d.ts +9 -0
  271. package/dist/types/rules/html-head-only-elements.d.ts +1 -1
  272. package/dist/types/rules/html-iframe-has-title.d.ts +1 -1
  273. package/dist/types/rules/html-img-require-alt.d.ts +1 -1
  274. package/dist/types/rules/html-input-require-autocomplete.d.ts +1 -1
  275. package/dist/types/rules/html-navigation-has-label.d.ts +1 -1
  276. package/dist/types/{src/rules/html-no-empty-headings.d.ts → rules/html-no-abstract-roles.d.ts} +2 -2
  277. package/dist/types/{src/rules/erb-no-output-control-flow.d.ts → rules/html-no-aria-hidden-on-body.d.ts} +3 -3
  278. package/dist/types/rules/html-no-aria-hidden-on-focusable.d.ts +1 -1
  279. package/dist/types/rules/html-no-block-inside-inline.d.ts +1 -1
  280. package/dist/types/rules/html-no-duplicate-attributes.d.ts +1 -1
  281. package/dist/types/rules/html-no-duplicate-ids.d.ts +1 -1
  282. package/dist/types/rules/html-no-duplicate-meta-names.d.ts +1 -1
  283. package/dist/types/rules/html-no-empty-attributes.d.ts +1 -1
  284. package/dist/types/rules/html-no-empty-headings.d.ts +1 -1
  285. package/dist/types/rules/html-no-nested-links.d.ts +1 -1
  286. package/dist/types/rules/html-no-positive-tab-index.d.ts +1 -1
  287. package/dist/types/rules/html-no-self-closing.d.ts +1 -1
  288. package/dist/types/rules/html-no-space-in-tag.d.ts +1 -1
  289. package/dist/types/rules/html-no-title-attribute.d.ts +1 -1
  290. package/dist/types/rules/html-no-underscores-in-attribute-names.d.ts +1 -1
  291. package/dist/types/{src/rules/html-body-only-elements.d.ts → rules/html-require-closing-tags.d.ts} +4 -3
  292. package/dist/types/rules/html-tag-name-lowercase.d.ts +1 -1
  293. package/dist/types/rules/index.d.ts +27 -4
  294. package/dist/types/rules/parser-no-errors.d.ts +1 -1
  295. package/dist/types/rules/rule-utils.d.ts +36 -88
  296. package/dist/types/rules/svg-tag-name-capitalization.d.ts +1 -1
  297. package/dist/types/{src/rules/html-aria-role-must-be-valid.d.ts → rules/turbo-permanent-require-id.d.ts} +2 -2
  298. package/dist/types/types.d.ts +26 -7
  299. package/dist/types/urls.d.ts +1 -0
  300. package/dist/{src/types.js → types.js} +56 -0
  301. package/dist/types.js.map +1 -0
  302. package/dist/urls.js +5 -0
  303. package/dist/urls.js.map +1 -0
  304. package/docs/rules/README.md +26 -2
  305. package/docs/rules/actionview-no-silent-helper.md +57 -0
  306. package/docs/rules/actionview-no-silent-render.md +47 -0
  307. package/docs/rules/erb-no-conditional-html-element.md +90 -0
  308. package/docs/rules/erb-no-conditional-open-tag.md +130 -0
  309. package/docs/rules/erb-no-duplicate-branch-elements.md +98 -0
  310. package/docs/rules/erb-no-empty-control-flow.md +83 -0
  311. package/docs/rules/erb-no-inline-case-conditions.md +85 -0
  312. package/docs/rules/erb-no-instance-variables-in-partials.md +43 -0
  313. package/docs/rules/erb-no-interpolated-class-names.md +57 -0
  314. package/docs/rules/erb-no-javascript-tag-helper.md +33 -0
  315. package/docs/rules/erb-no-output-in-attribute-name.md +38 -0
  316. package/docs/rules/erb-no-output-in-attribute-position.md +60 -0
  317. package/docs/rules/erb-no-raw-output-in-attribute-value.md +37 -0
  318. package/docs/rules/erb-no-silent-statement.md +53 -0
  319. package/docs/rules/erb-no-statement-in-script.md +68 -0
  320. package/docs/rules/erb-no-then-in-control-flow.md +86 -0
  321. package/docs/rules/erb-no-trailing-whitespace.md +69 -0
  322. package/docs/rules/erb-no-unsafe-js-attribute.md +41 -0
  323. package/docs/rules/erb-no-unsafe-raw.md +47 -0
  324. package/docs/rules/erb-no-unsafe-script-interpolation.md +140 -0
  325. package/docs/rules/html-allowed-script-type.md +59 -0
  326. package/docs/rules/html-anchor-require-href.md +19 -6
  327. package/docs/rules/html-details-has-summary.md +46 -0
  328. package/docs/rules/html-img-require-alt.md +5 -3
  329. package/docs/rules/html-no-abstract-roles.md +74 -0
  330. package/docs/rules/html-no-aria-hidden-on-body.md +44 -0
  331. package/docs/rules/html-require-closing-tags.md +142 -0
  332. package/docs/rules/parser-no-errors.md +4 -17
  333. package/docs/rules/turbo-permanent-require-id.md +41 -0
  334. package/package.json +11 -10
  335. package/src/cli/argument-parser.ts +20 -2
  336. package/src/cli/file-processor.ts +189 -10
  337. package/src/cli/file-url.ts +6 -0
  338. package/src/cli/formatters/detailed-formatter.ts +19 -21
  339. package/src/cli/formatters/simple-formatter.ts +23 -13
  340. package/src/cli/index.ts +2 -0
  341. package/src/cli/lint-worker.ts +208 -0
  342. package/src/cli/summary-reporter.ts +14 -15
  343. package/src/cli.ts +5 -3
  344. package/src/custom-rule-loader.ts +20 -5
  345. package/src/herb-disable-comment-utils.ts +0 -3
  346. package/src/index.ts +22 -0
  347. package/src/linter.ts +98 -79
  348. package/src/parse-cache.ts +39 -0
  349. package/src/rules/actionview-no-silent-helper.ts +58 -0
  350. package/src/rules/actionview-no-silent-render.ts +44 -0
  351. package/src/rules/erb-comment-syntax.ts +2 -2
  352. package/src/rules/erb-no-case-node-children.ts +5 -3
  353. package/src/rules/erb-no-conditional-html-element.ts +53 -0
  354. package/src/rules/erb-no-conditional-open-tag.ts +37 -0
  355. package/src/rules/erb-no-duplicate-branch-elements.ts +436 -0
  356. package/src/rules/erb-no-empty-control-flow.ts +255 -0
  357. package/src/rules/erb-no-empty-tags.ts +2 -2
  358. package/src/rules/erb-no-extra-newline.ts +5 -25
  359. package/src/rules/erb-no-extra-whitespace-inside-tags.ts +45 -15
  360. package/src/rules/erb-no-inline-case-conditions.ts +54 -0
  361. package/src/rules/erb-no-instance-variables-in-partials.ts +101 -0
  362. package/src/rules/erb-no-interpolated-class-names.ts +65 -0
  363. package/src/rules/erb-no-javascript-tag-helper.ts +47 -0
  364. package/src/rules/erb-no-output-control-flow.ts +10 -10
  365. package/src/rules/erb-no-output-in-attribute-name.ts +39 -0
  366. package/src/rules/erb-no-output-in-attribute-position.ts +39 -0
  367. package/src/rules/erb-no-raw-output-in-attribute-value.ts +47 -0
  368. package/src/rules/erb-no-silent-statement.ts +58 -0
  369. package/src/rules/erb-no-silent-tag-in-attribute-name.ts +2 -2
  370. package/src/rules/erb-no-statement-in-script.ts +82 -0
  371. package/src/rules/erb-no-then-in-control-flow.ts +62 -0
  372. package/src/rules/erb-no-trailing-whitespace.ts +187 -0
  373. package/src/rules/erb-no-unsafe-js-attribute.ts +47 -0
  374. package/src/rules/erb-no-unsafe-raw.ts +83 -0
  375. package/src/rules/erb-no-unsafe-script-interpolation.ts +122 -0
  376. package/src/rules/erb-prefer-image-tag-helper.ts +5 -4
  377. package/src/rules/erb-require-trailing-newline.ts +2 -2
  378. package/src/rules/erb-require-whitespace-inside-tags.ts +42 -18
  379. package/src/rules/erb-right-trim.ts +2 -2
  380. package/src/rules/erb-strict-locals-comment-syntax.ts +4 -4
  381. package/src/rules/erb-strict-locals-required.ts +2 -2
  382. package/src/rules/herb-disable-comment-malformed.ts +2 -2
  383. package/src/rules/herb-disable-comment-missing-rules.ts +2 -2
  384. package/src/rules/herb-disable-comment-no-duplicate-rules.ts +2 -2
  385. package/src/rules/herb-disable-comment-no-redundant-all.ts +2 -2
  386. package/src/rules/herb-disable-comment-unnecessary.ts +2 -2
  387. package/src/rules/herb-disable-comment-valid-rule-name.ts +2 -2
  388. package/src/rules/html-allowed-script-type.ts +84 -0
  389. package/src/rules/html-anchor-require-href.ts +73 -11
  390. package/src/rules/html-aria-attribute-must-be-valid.ts +3 -3
  391. package/src/rules/html-aria-label-is-well-formatted.ts +3 -3
  392. package/src/rules/html-aria-level-must-be-valid.ts +3 -3
  393. package/src/rules/html-aria-role-heading-requires-level.ts +5 -4
  394. package/src/rules/html-aria-role-must-be-valid.ts +3 -3
  395. package/src/rules/html-attribute-double-quotes.ts +4 -4
  396. package/src/rules/html-attribute-equals-spacing.ts +2 -2
  397. package/src/rules/html-attribute-values-require-quotes.ts +2 -2
  398. package/src/rules/html-avoid-both-disabled-and-aria-disabled.ts +10 -11
  399. package/src/rules/html-body-only-elements.ts +5 -4
  400. package/src/rules/html-boolean-attributes-no-value.ts +4 -3
  401. package/src/rules/html-details-has-summary.ts +69 -0
  402. package/src/rules/html-head-only-elements.ts +6 -5
  403. package/src/rules/html-iframe-has-title.ts +8 -11
  404. package/src/rules/html-img-require-alt.ts +16 -5
  405. package/src/rules/html-input-require-autocomplete.ts +7 -10
  406. package/src/rules/html-navigation-has-label.ts +6 -5
  407. package/src/rules/html-no-abstract-roles.ts +40 -0
  408. package/src/rules/html-no-aria-hidden-on-body.ts +58 -0
  409. package/src/rules/html-no-aria-hidden-on-focusable.ts +6 -5
  410. package/src/rules/html-no-block-inside-inline.ts +7 -13
  411. package/src/rules/html-no-duplicate-attributes.ts +4 -3
  412. package/src/rules/html-no-duplicate-ids.ts +16 -13
  413. package/src/rules/html-no-duplicate-meta-names.ts +20 -19
  414. package/src/rules/html-no-empty-attributes.ts +2 -2
  415. package/src/rules/html-no-empty-headings.ts +44 -58
  416. package/src/rules/html-no-nested-links.ts +25 -16
  417. package/src/rules/html-no-positive-tab-index.ts +3 -3
  418. package/src/rules/html-no-self-closing.ts +5 -5
  419. package/src/rules/html-no-space-in-tag.ts +5 -8
  420. package/src/rules/html-no-title-attribute.ts +6 -5
  421. package/src/rules/html-no-underscores-in-attribute-names.ts +2 -2
  422. package/src/rules/html-require-closing-tags.ts +41 -0
  423. package/src/rules/html-tag-name-lowercase.ts +14 -9
  424. package/src/rules/index.ts +28 -4
  425. package/src/rules/parser-no-errors.ts +3 -3
  426. package/src/rules/rule-utils.ts +166 -279
  427. package/src/rules/svg-tag-name-capitalization.ts +10 -10
  428. package/src/rules/turbo-permanent-require-id.ts +49 -0
  429. package/src/rules.ts +66 -10
  430. package/src/types.ts +80 -7
  431. package/src/urls.ts +5 -0
  432. package/dist/package.json +0 -65
  433. package/dist/src/cli/argument-parser.js.map +0 -1
  434. package/dist/src/cli/file-processor.js.map +0 -1
  435. package/dist/src/cli/formatters/base-formatter.js.map +0 -1
  436. package/dist/src/cli/formatters/detailed-formatter.js.map +0 -1
  437. package/dist/src/cli/formatters/github-actions-formatter.js.map +0 -1
  438. package/dist/src/cli/formatters/index.js.map +0 -1
  439. package/dist/src/cli/formatters/json-formatter.js.map +0 -1
  440. package/dist/src/cli/formatters/simple-formatter.js +0 -44
  441. package/dist/src/cli/formatters/simple-formatter.js.map +0 -1
  442. package/dist/src/cli/index.js.map +0 -1
  443. package/dist/src/cli/output-manager.js.map +0 -1
  444. package/dist/src/cli/summary-reporter.js.map +0 -1
  445. package/dist/src/cli.js.map +0 -1
  446. package/dist/src/custom-rule-loader.js.map +0 -1
  447. package/dist/src/herb-disable-comment-utils.js.map +0 -1
  448. package/dist/src/herb-lint.js +0 -5
  449. package/dist/src/herb-lint.js.map +0 -1
  450. package/dist/src/index.js +0 -5
  451. package/dist/src/index.js.map +0 -1
  452. package/dist/src/linter-ignore.js.map +0 -1
  453. package/dist/src/linter.js.map +0 -1
  454. package/dist/src/loader.js +0 -17
  455. package/dist/src/loader.js.map +0 -1
  456. package/dist/src/rules/erb-comment-syntax.js.map +0 -1
  457. package/dist/src/rules/erb-no-case-node-children.js.map +0 -1
  458. package/dist/src/rules/erb-no-empty-tags.js.map +0 -1
  459. package/dist/src/rules/erb-no-extra-newline.js.map +0 -1
  460. package/dist/src/rules/erb-no-extra-whitespace-inside-tags.js.map +0 -1
  461. package/dist/src/rules/erb-no-output-control-flow.js.map +0 -1
  462. package/dist/src/rules/erb-no-silent-tag-in-attribute-name.js.map +0 -1
  463. package/dist/src/rules/erb-prefer-image-tag-helper.js.map +0 -1
  464. package/dist/src/rules/erb-require-trailing-newline.js.map +0 -1
  465. package/dist/src/rules/erb-require-whitespace-inside-tags.js.map +0 -1
  466. package/dist/src/rules/erb-right-trim.js.map +0 -1
  467. package/dist/src/rules/erb-strict-locals-comment-syntax.js.map +0 -1
  468. package/dist/src/rules/erb-strict-locals-required.js.map +0 -1
  469. package/dist/src/rules/file-utils.js.map +0 -1
  470. package/dist/src/rules/herb-disable-comment-base.js.map +0 -1
  471. package/dist/src/rules/herb-disable-comment-malformed.js.map +0 -1
  472. package/dist/src/rules/herb-disable-comment-missing-rules.js.map +0 -1
  473. package/dist/src/rules/herb-disable-comment-no-duplicate-rules.js.map +0 -1
  474. package/dist/src/rules/herb-disable-comment-no-redundant-all.js.map +0 -1
  475. package/dist/src/rules/herb-disable-comment-unnecessary.js.map +0 -1
  476. package/dist/src/rules/herb-disable-comment-valid-rule-name.js.map +0 -1
  477. package/dist/src/rules/html-anchor-require-href.js +0 -32
  478. package/dist/src/rules/html-anchor-require-href.js.map +0 -1
  479. package/dist/src/rules/html-aria-attribute-must-be-valid.js.map +0 -1
  480. package/dist/src/rules/html-aria-label-is-well-formatted.js.map +0 -1
  481. package/dist/src/rules/html-aria-level-must-be-valid.js.map +0 -1
  482. package/dist/src/rules/html-aria-role-heading-requires-level.js.map +0 -1
  483. package/dist/src/rules/html-aria-role-must-be-valid.js.map +0 -1
  484. package/dist/src/rules/html-attribute-double-quotes.js.map +0 -1
  485. package/dist/src/rules/html-attribute-equals-spacing.js.map +0 -1
  486. package/dist/src/rules/html-attribute-values-require-quotes.js.map +0 -1
  487. package/dist/src/rules/html-avoid-both-disabled-and-aria-disabled.js.map +0 -1
  488. package/dist/src/rules/html-body-only-elements.js.map +0 -1
  489. package/dist/src/rules/html-boolean-attributes-no-value.js.map +0 -1
  490. package/dist/src/rules/html-head-only-elements.js.map +0 -1
  491. package/dist/src/rules/html-iframe-has-title.js.map +0 -1
  492. package/dist/src/rules/html-img-require-alt.js.map +0 -1
  493. package/dist/src/rules/html-input-require-autocomplete.js.map +0 -1
  494. package/dist/src/rules/html-navigation-has-label.js.map +0 -1
  495. package/dist/src/rules/html-no-aria-hidden-on-focusable.js.map +0 -1
  496. package/dist/src/rules/html-no-block-inside-inline.js.map +0 -1
  497. package/dist/src/rules/html-no-duplicate-attributes.js.map +0 -1
  498. package/dist/src/rules/html-no-duplicate-ids.js.map +0 -1
  499. package/dist/src/rules/html-no-duplicate-meta-names.js.map +0 -1
  500. package/dist/src/rules/html-no-empty-attributes.js.map +0 -1
  501. package/dist/src/rules/html-no-empty-headings.js +0 -115
  502. package/dist/src/rules/html-no-empty-headings.js.map +0 -1
  503. package/dist/src/rules/html-no-nested-links.js.map +0 -1
  504. package/dist/src/rules/html-no-positive-tab-index.js.map +0 -1
  505. package/dist/src/rules/html-no-self-closing.js.map +0 -1
  506. package/dist/src/rules/html-no-space-in-tag.js.map +0 -1
  507. package/dist/src/rules/html-no-title-attribute.js.map +0 -1
  508. package/dist/src/rules/html-no-underscores-in-attribute-names.js.map +0 -1
  509. package/dist/src/rules/html-tag-name-lowercase.js.map +0 -1
  510. package/dist/src/rules/index.js.map +0 -1
  511. package/dist/src/rules/parser-no-errors.js.map +0 -1
  512. package/dist/src/rules/rule-utils.js.map +0 -1
  513. package/dist/src/rules/string-utils.js.map +0 -1
  514. package/dist/src/rules/svg-tag-name-capitalization.js.map +0 -1
  515. package/dist/src/rules.js.map +0 -1
  516. package/dist/src/types.js.map +0 -1
  517. package/dist/tsconfig.tsbuildinfo +0 -1
  518. package/dist/types/src/cli/argument-parser.d.ts +0 -25
  519. package/dist/types/src/cli/file-processor.d.ts +0 -43
  520. package/dist/types/src/cli/formatters/base-formatter.d.ts +0 -6
  521. package/dist/types/src/cli/formatters/detailed-formatter.d.ts +0 -13
  522. package/dist/types/src/cli/formatters/github-actions-formatter.d.ts +0 -17
  523. package/dist/types/src/cli/formatters/index.d.ts +0 -5
  524. package/dist/types/src/cli/formatters/json-formatter.d.ts +0 -48
  525. package/dist/types/src/cli/formatters/simple-formatter.d.ts +0 -8
  526. package/dist/types/src/cli/index.d.ts +0 -5
  527. package/dist/types/src/cli/output-manager.d.ts +0 -32
  528. package/dist/types/src/cli/summary-reporter.d.ts +0 -28
  529. package/dist/types/src/cli.d.ts +0 -28
  530. package/dist/types/src/custom-rule-loader.d.ts +0 -62
  531. package/dist/types/src/herb-disable-comment-utils.d.ts +0 -69
  532. package/dist/types/src/herb-lint.d.ts +0 -2
  533. package/dist/types/src/index.d.ts +0 -4
  534. package/dist/types/src/linter-ignore.d.ts +0 -12
  535. package/dist/types/src/linter.d.ts +0 -133
  536. package/dist/types/src/loader.d.ts +0 -20
  537. package/dist/types/src/rules/erb-comment-syntax.d.ts +0 -14
  538. package/dist/types/src/rules/erb-no-extra-newline.d.ts +0 -14
  539. package/dist/types/src/rules/erb-no-extra-whitespace-inside-tags.d.ts +0 -18
  540. package/dist/types/src/rules/erb-require-trailing-newline.d.ts +0 -9
  541. package/dist/types/src/rules/erb-require-whitespace-inside-tags.d.ts +0 -18
  542. package/dist/types/src/rules/erb-right-trim.d.ts +0 -14
  543. package/dist/types/src/rules/erb-strict-locals-comment-syntax.d.ts +0 -9
  544. package/dist/types/src/rules/erb-strict-locals-required.d.ts +0 -9
  545. package/dist/types/src/rules/file-utils.d.ts +0 -13
  546. package/dist/types/src/rules/herb-disable-comment-base.d.ts +0 -37
  547. package/dist/types/src/rules/herb-disable-comment-no-duplicate-rules.d.ts +0 -8
  548. package/dist/types/src/rules/herb-disable-comment-no-redundant-all.d.ts +0 -8
  549. package/dist/types/src/rules/herb-disable-comment-unnecessary.d.ts +0 -8
  550. package/dist/types/src/rules/herb-disable-comment-valid-rule-name.d.ts +0 -8
  551. package/dist/types/src/rules/html-aria-label-is-well-formatted.d.ts +0 -8
  552. package/dist/types/src/rules/html-aria-role-heading-requires-level.d.ts +0 -8
  553. package/dist/types/src/rules/html-attribute-double-quotes.d.ts +0 -15
  554. package/dist/types/src/rules/html-attribute-equals-spacing.d.ts +0 -14
  555. package/dist/types/src/rules/html-attribute-values-require-quotes.d.ts +0 -15
  556. package/dist/types/src/rules/html-avoid-both-disabled-and-aria-disabled.d.ts +0 -8
  557. package/dist/types/src/rules/html-boolean-attributes-no-value.d.ts +0 -14
  558. package/dist/types/src/rules/html-head-only-elements.d.ts +0 -9
  559. package/dist/types/src/rules/html-iframe-has-title.d.ts +0 -8
  560. package/dist/types/src/rules/html-img-require-alt.d.ts +0 -8
  561. package/dist/types/src/rules/html-input-require-autocomplete.d.ts +0 -8
  562. package/dist/types/src/rules/html-no-block-inside-inline.d.ts +0 -8
  563. package/dist/types/src/rules/html-no-duplicate-ids.d.ts +0 -8
  564. package/dist/types/src/rules/html-no-duplicate-meta-names.d.ts +0 -9
  565. package/dist/types/src/rules/html-no-nested-links.d.ts +0 -8
  566. package/dist/types/src/rules/html-no-self-closing.d.ts +0 -16
  567. package/dist/types/src/rules/html-no-space-in-tag.d.ts +0 -16
  568. package/dist/types/src/rules/html-no-underscores-in-attribute-names.d.ts +0 -8
  569. package/dist/types/src/rules/html-tag-name-lowercase.d.ts +0 -18
  570. package/dist/types/src/rules/index.d.ts +0 -54
  571. package/dist/types/src/rules/parser-no-errors.d.ts +0 -9
  572. package/dist/types/src/rules/rule-utils.d.ts +0 -351
  573. package/dist/types/src/rules/string-utils.d.ts +0 -15
  574. package/dist/types/src/rules/svg-tag-name-capitalization.d.ts +0 -16
  575. package/dist/types/src/rules.d.ts +0 -2
  576. package/dist/types/src/types.d.ts +0 -190
  577. /package/dist/{src/cli → cli}/formatters/base-formatter.js +0 -0
  578. /package/dist/{src/cli → cli}/formatters/github-actions-formatter.js +0 -0
  579. /package/dist/{src/cli → cli}/formatters/index.js +0 -0
  580. /package/dist/{src/cli → cli}/formatters/json-formatter.js +0 -0
  581. /package/dist/{src/cli → cli}/index.js +0 -0
  582. /package/dist/{src/cli → cli}/output-manager.js +0 -0
  583. /package/dist/{src/herb-disable-comment-utils.js → herb-disable-comment-utils.js} +0 -0
  584. /package/dist/{src/linter-ignore.js → linter-ignore.js} +0 -0
  585. /package/dist/{src/rules → rules}/file-utils.js +0 -0
  586. /package/dist/{src/rules → rules}/herb-disable-comment-base.js +0 -0
  587. /package/dist/{src/rules → rules}/string-utils.js +0 -0
@@ -0,0 +1,190 @@
1
+ import { BaseRuleVisitor } from "./rule-utils.js";
2
+ import { ParserRule } from "../types.js";
3
+ import { isHTMLTextNode, isERBIfNode, isERBElseNode, Location } from "@herb-tools/core";
4
+ class ERBNoEmptyControlFlowVisitor extends BaseRuleVisitor {
5
+ processedIfNodes = new Set();
6
+ processedElseNodes = new Set();
7
+ visitERBIfNode(node) {
8
+ if (this.processedIfNodes.has(node)) {
9
+ return;
10
+ }
11
+ this.markIfChainAsProcessed(node);
12
+ this.markElseNodesInIfChain(node);
13
+ const entireChainEmpty = this.isEntireIfChainEmpty(node);
14
+ if (entireChainEmpty) {
15
+ this.addEmptyBlockOffense(node, node.statements, "if");
16
+ }
17
+ else {
18
+ this.checkIfChainParts(node);
19
+ }
20
+ this.visitChildNodes(node);
21
+ }
22
+ visitERBElseNode(node) {
23
+ if (this.processedElseNodes.has(node)) {
24
+ this.visitChildNodes(node);
25
+ return;
26
+ }
27
+ this.addEmptyBlockOffense(node, node.statements, "else");
28
+ this.visitChildNodes(node);
29
+ }
30
+ visitERBUnlessNode(node) {
31
+ const unlessHasContent = this.statementsHaveContent(node.statements);
32
+ const elseHasContent = node.else_clause && this.statementsHaveContent(node.else_clause.statements);
33
+ if (node.else_clause) {
34
+ this.processedElseNodes.add(node.else_clause);
35
+ }
36
+ const entireBlockEmpty = !unlessHasContent && !elseHasContent;
37
+ if (entireBlockEmpty) {
38
+ this.addEmptyBlockOffense(node, node.statements, "unless");
39
+ }
40
+ else {
41
+ if (!unlessHasContent) {
42
+ this.addEmptyBlockOffenseWithEnd(node, node.statements, "unless", node.else_clause);
43
+ }
44
+ if (node.else_clause && !elseHasContent) {
45
+ this.addEmptyBlockOffense(node.else_clause, node.else_clause.statements, "else");
46
+ }
47
+ }
48
+ this.visitChildNodes(node);
49
+ }
50
+ visitERBForNode(node) {
51
+ this.addEmptyBlockOffense(node, node.statements, "for");
52
+ this.visitChildNodes(node);
53
+ }
54
+ visitERBWhileNode(node) {
55
+ this.addEmptyBlockOffense(node, node.statements, "while");
56
+ this.visitChildNodes(node);
57
+ }
58
+ visitERBUntilNode(node) {
59
+ this.addEmptyBlockOffense(node, node.statements, "until");
60
+ this.visitChildNodes(node);
61
+ }
62
+ visitERBWhenNode(node) {
63
+ if (!node.then_keyword) {
64
+ this.addEmptyBlockOffense(node, node.statements, "when");
65
+ }
66
+ this.visitChildNodes(node);
67
+ }
68
+ visitERBInNode(node) {
69
+ if (!node.then_keyword) {
70
+ this.addEmptyBlockOffense(node, node.statements, "in");
71
+ }
72
+ this.visitChildNodes(node);
73
+ }
74
+ visitERBBeginNode(node) {
75
+ this.addEmptyBlockOffense(node, node.statements, "begin");
76
+ this.visitChildNodes(node);
77
+ }
78
+ visitERBRescueNode(node) {
79
+ this.addEmptyBlockOffense(node, node.statements, "rescue");
80
+ this.visitChildNodes(node);
81
+ }
82
+ visitERBEnsureNode(node) {
83
+ this.addEmptyBlockOffense(node, node.statements, "ensure");
84
+ this.visitChildNodes(node);
85
+ }
86
+ visitERBBlockNode(node) {
87
+ this.addEmptyBlockOffense(node, node.body, "do");
88
+ this.visitChildNodes(node);
89
+ }
90
+ addEmptyBlockOffense(node, statements, blockType) {
91
+ this.addEmptyBlockOffenseWithEnd(node, statements, blockType, null);
92
+ }
93
+ addEmptyBlockOffenseWithEnd(node, statements, blockType, subsequentNode) {
94
+ if (this.statementsHaveContent(statements)) {
95
+ return;
96
+ }
97
+ const startLocation = node.location.start;
98
+ const endLocation = subsequentNode
99
+ ? subsequentNode.location.start
100
+ : node.location.end;
101
+ const location = Location.from(startLocation.line, startLocation.column, endLocation.line, endLocation.column);
102
+ const offense = this.createOffense(`Empty ${blockType} block: this control flow statement has no content`, location);
103
+ offense.tags = ["unnecessary"];
104
+ this.offenses.push(offense);
105
+ }
106
+ statementsHaveContent(statements) {
107
+ return statements.some(statement => {
108
+ if (isHTMLTextNode(statement)) {
109
+ return statement.content.trim() !== "";
110
+ }
111
+ return true;
112
+ });
113
+ }
114
+ markIfChainAsProcessed(node) {
115
+ this.processedIfNodes.add(node);
116
+ this.traverseSubsequentNodes(node.subsequent, (current) => {
117
+ if (isERBIfNode(current)) {
118
+ this.processedIfNodes.add(current);
119
+ }
120
+ });
121
+ }
122
+ markElseNodesInIfChain(node) {
123
+ this.traverseSubsequentNodes(node.subsequent, (current) => {
124
+ if (isERBElseNode(current)) {
125
+ this.processedElseNodes.add(current);
126
+ }
127
+ });
128
+ }
129
+ traverseSubsequentNodes(startNode, callback) {
130
+ let current = startNode;
131
+ while (current) {
132
+ if (isERBIfNode(current)) {
133
+ callback(current);
134
+ current = current.subsequent;
135
+ }
136
+ else if (isERBElseNode(current)) {
137
+ callback(current);
138
+ break;
139
+ }
140
+ else {
141
+ break;
142
+ }
143
+ }
144
+ }
145
+ checkIfChainParts(node) {
146
+ if (!this.statementsHaveContent(node.statements)) {
147
+ this.addEmptyBlockOffenseWithEnd(node, node.statements, "if", node.subsequent);
148
+ }
149
+ this.traverseSubsequentNodes(node.subsequent, (current) => {
150
+ if (this.statementsHaveContent(current.statements)) {
151
+ return;
152
+ }
153
+ const blockType = isERBIfNode(current) ? "elsif" : "else";
154
+ const nextSubsequent = isERBIfNode(current) ? current.subsequent : null;
155
+ if (nextSubsequent) {
156
+ this.addEmptyBlockOffenseWithEnd(current, current.statements, blockType, nextSubsequent);
157
+ }
158
+ else {
159
+ this.addEmptyBlockOffense(current, current.statements, blockType);
160
+ }
161
+ });
162
+ }
163
+ isEntireIfChainEmpty(node) {
164
+ if (this.statementsHaveContent(node.statements)) {
165
+ return false;
166
+ }
167
+ let hasContent = false;
168
+ this.traverseSubsequentNodes(node.subsequent, (current) => {
169
+ if (this.statementsHaveContent(current.statements)) {
170
+ hasContent = true;
171
+ }
172
+ });
173
+ return !hasContent;
174
+ }
175
+ }
176
+ export class ERBNoEmptyControlFlowRule extends ParserRule {
177
+ static ruleName = "erb-no-empty-control-flow";
178
+ get defaultConfig() {
179
+ return {
180
+ enabled: true,
181
+ severity: "hint"
182
+ };
183
+ }
184
+ check(result, context) {
185
+ const visitor = new ERBNoEmptyControlFlowVisitor(this.ruleName, context);
186
+ visitor.visit(result.value);
187
+ return visitor.offenses;
188
+ }
189
+ }
190
+ //# sourceMappingURL=erb-no-empty-control-flow.js.map
@@ -0,0 +1 @@
1
+ {"version":3,"file":"erb-no-empty-control-flow.js","sourceRoot":"","sources":["../../src/rules/erb-no-empty-control-flow.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAA;AACjD,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,cAAc,EAAE,WAAW,EAAE,aAAa,EAAE,QAAQ,EAAE,MAAM,kBAAkB,CAAA;AAoBvF,MAAM,4BAA6B,SAAQ,eAAe;IAChD,gBAAgB,GAAmB,IAAI,GAAG,EAAE,CAAA;IAC5C,kBAAkB,GAAqB,IAAI,GAAG,EAAE,CAAA;IAExD,cAAc,CAAC,IAAe;QAC5B,IAAI,IAAI,CAAC,gBAAgB,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC;YACpC,OAAM;QACR,CAAC;QAED,IAAI,CAAC,sBAAsB,CAAC,IAAI,CAAC,CAAA;QACjC,IAAI,CAAC,sBAAsB,CAAC,IAAI,CAAC,CAAA;QAEjC,MAAM,gBAAgB,GAAG,IAAI,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAA;QAExD,IAAI,gBAAgB,EAAE,CAAC;YACrB,IAAI,CAAC,oBAAoB,CAAC,IAAI,EAAE,IAAI,CAAC,UAAU,EAAE,IAAI,CAAC,CAAA;QACxD,CAAC;aAAM,CAAC;YACN,IAAI,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAA;QAC9B,CAAC;QAED,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAED,gBAAgB,CAAC,IAAiB;QAChC,IAAI,IAAI,CAAC,kBAAkB,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC;YACtC,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;YAC1B,OAAM;QACR,CAAC;QAED,IAAI,CAAC,oBAAoB,CAAC,IAAI,EAAE,IAAI,CAAC,UAAU,EAAE,MAAM,CAAC,CAAA;QACxD,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAED,kBAAkB,CAAC,IAAmB;QACpC,MAAM,gBAAgB,GAAG,IAAI,CAAC,qBAAqB,CAAC,IAAI,CAAC,UAAU,CAAC,CAAA;QACpE,MAAM,cAAc,GAAG,IAAI,CAAC,WAAW,IAAI,IAAI,CAAC,qBAAqB,CAAC,IAAI,CAAC,WAAW,CAAC,UAAU,CAAC,CAAA;QAElG,IAAI,IAAI,CAAC,WAAW,EAAE,CAAC;YACrB,IAAI,CAAC,kBAAkB,CAAC,GAAG,CAAC,IAAI,CAAC,WAAW,CAAC,CAAA;QAC/C,CAAC;QAED,MAAM,gBAAgB,GAAG,CAAC,gBAAgB,IAAI,CAAC,cAAc,CAAA;QAE7D,IAAI,gBAAgB,EAAE,CAAC;YACrB,IAAI,CAAC,oBAAoB,CAAC,IAAI,EAAE,IAAI,CAAC,UAAU,EAAE,QAAQ,CAAC,CAAA;QAC5D,CAAC;aAAM,CAAC;YACN,IAAI,CAAC,gBAAgB,EAAE,CAAC;gBACtB,IAAI,CAAC,2BAA2B,CAAC,IAAI,EAAE,IAAI,CAAC,UAAU,EAAE,QAAQ,EAAE,IAAI,CAAC,WAAW,CAAC,CAAA;YACrF,CAAC;YAED,IAAI,IAAI,CAAC,WAAW,IAAI,CAAC,cAAc,EAAE,CAAC;gBACxC,IAAI,CAAC,oBAAoB,CAAC,IAAI,CAAC,WAAW,EAAE,IAAI,CAAC,WAAW,CAAC,UAAU,EAAE,MAAM,CAAC,CAAA;YAClF,CAAC;QACH,CAAC;QAED,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAED,eAAe,CAAC,IAAgB;QAC9B,IAAI,CAAC,oBAAoB,CAAC,IAAI,EAAE,IAAI,CAAC,UAAU,EAAE,KAAK,CAAC,CAAA;QACvD,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAED,iBAAiB,CAAC,IAAkB;QAClC,IAAI,CAAC,oBAAoB,CAAC,IAAI,EAAE,IAAI,CAAC,UAAU,EAAE,OAAO,CAAC,CAAA;QACzD,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAED,iBAAiB,CAAC,IAAkB;QAClC,IAAI,CAAC,oBAAoB,CAAC,IAAI,EAAE,IAAI,CAAC,UAAU,EAAE,OAAO,CAAC,CAAA;QACzD,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAED,gBAAgB,CAAC,IAAiB;QAChC,IAAI,CAAC,IAAI,CAAC,YAAY,EAAE,CAAC;YACvB,IAAI,CAAC,oBAAoB,CAAC,IAAI,EAAE,IAAI,CAAC,UAAU,EAAE,MAAM,CAAC,CAAA;QAC1D,CAAC;QAED,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAED,cAAc,CAAC,IAAe;QAC5B,IAAI,CAAC,IAAI,CAAC,YAAY,EAAE,CAAC;YACvB,IAAI,CAAC,oBAAoB,CAAC,IAAI,EAAE,IAAI,CAAC,UAAU,EAAE,IAAI,CAAC,CAAA;QACxD,CAAC;QAED,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAED,iBAAiB,CAAC,IAAkB;QAClC,IAAI,CAAC,oBAAoB,CAAC,IAAI,EAAE,IAAI,CAAC,UAAU,EAAE,OAAO,CAAC,CAAA;QACzD,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAED,kBAAkB,CAAC,IAAmB;QACpC,IAAI,CAAC,oBAAoB,CAAC,IAAI,EAAE,IAAI,CAAC,UAAU,EAAE,QAAQ,CAAC,CAAA;QAC1D,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAED,kBAAkB,CAAC,IAAmB;QACpC,IAAI,CAAC,oBAAoB,CAAC,IAAI,EAAE,IAAI,CAAC,UAAU,EAAE,QAAQ,CAAC,CAAA;QAC1D,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAED,iBAAiB,CAAC,IAAkB;QAClC,IAAI,CAAC,oBAAoB,CAAC,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,IAAI,CAAC,CAAA;QAChD,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAEO,oBAAoB,CAAC,IAAU,EAAE,UAAkB,EAAE,SAAiB;QAC5E,IAAI,CAAC,2BAA2B,CAAC,IAAI,EAAE,UAAU,EAAE,SAAS,EAAE,IAAI,CAAC,CAAA;IACrE,CAAC;IAEO,2BAA2B,CAAC,IAAU,EAAE,UAAkB,EAAE,SAAiB,EAAE,cAA2B;QAChH,IAAI,IAAI,CAAC,qBAAqB,CAAC,UAAU,CAAC,EAAE,CAAC;YAC3C,OAAM;QACR,CAAC;QAED,MAAM,aAAa,GAAG,IAAI,CAAC,QAAQ,CAAC,KAAK,CAAA;QACzC,MAAM,WAAW,GAAG,cAAc;YAChC,CAAC,CAAC,cAAc,CAAC,QAAQ,CAAC,KAAK;YAC/B,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAA;QAErB,MAAM,QAAQ,GAAG,QAAQ,CAAC,IAAI,CAC5B,aAAa,CAAC,IAAI,EAAE,aAAa,CAAC,MAAM,EACxC,WAAW,CAAC,IAAI,EAAE,WAAW,CAAC,MAAM,CACrC,CAAA;QAED,MAAM,OAAO,GAAG,IAAI,CAAC,aAAa,CAChC,SAAS,SAAS,oDAAoD,EACtE,QAAQ,CACT,CAAA;QACD,OAAO,CAAC,IAAI,GAAG,CAAC,aAAa,CAAC,CAAA;QAC9B,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,OAAO,CAAC,CAAA;IAC7B,CAAC;IAEO,qBAAqB,CAAC,UAAkB;QAC9C,OAAO,UAAU,CAAC,IAAI,CAAC,SAAS,CAAC,EAAE;YACjC,IAAI,cAAc,CAAC,SAAS,CAAC,EAAE,CAAC;gBAC9B,OAAO,SAAS,CAAC,OAAO,CAAC,IAAI,EAAE,KAAK,EAAE,CAAA;YACxC,CAAC;YAED,OAAO,IAAI,CAAA;QACb,CAAC,CAAC,CAAA;IACJ,CAAC;IAEO,sBAAsB,CAAC,IAAe;QAC5C,IAAI,CAAC,gBAAgB,CAAC,GAAG,CAAC,IAAI,CAAC,CAAA;QAC/B,IAAI,CAAC,uBAAuB,CAAC,IAAI,CAAC,UAAU,EAAE,CAAC,OAAO,EAAE,EAAE;YACxD,IAAI,WAAW,CAAC,OAAO,CAAC,EAAE,CAAC;gBACzB,IAAI,CAAC,gBAAgB,CAAC,GAAG,CAAC,OAAO,CAAC,CAAA;YACpC,CAAC;QACH,CAAC,CAAC,CAAA;IACJ,CAAC;IAEO,sBAAsB,CAAC,IAAe;QAC5C,IAAI,CAAC,uBAAuB,CAAC,IAAI,CAAC,UAAU,EAAE,CAAC,OAAO,EAAE,EAAE;YACxD,IAAI,aAAa,CAAC,OAAO,CAAC,EAAE,CAAC;gBAC3B,IAAI,CAAC,kBAAkB,CAAC,GAAG,CAAC,OAAO,CAAC,CAAA;YACtC,CAAC;QACH,CAAC,CAAC,CAAA;IACJ,CAAC;IAEO,uBAAuB,CAAC,SAAsB,EAAE,QAAiD;QACvG,IAAI,OAAO,GAAgB,SAAS,CAAA;QACpC,OAAO,OAAO,EAAE,CAAC;YACf,IAAI,WAAW,CAAC,OAAO,CAAC,EAAE,CAAC;gBACzB,QAAQ,CAAC,OAAO,CAAC,CAAA;gBACjB,OAAO,GAAG,OAAO,CAAC,UAAU,CAAA;YAC9B,CAAC;iBAAM,IAAI,aAAa,CAAC,OAAO,CAAC,EAAE,CAAC;gBAClC,QAAQ,CAAC,OAAO,CAAC,CAAA;gBACjB,MAAK;YACP,CAAC;iBAAM,CAAC;gBACN,MAAK;YACP,CAAC;QACH,CAAC;IACH,CAAC;IAEO,iBAAiB,CAAC,IAAe;QACvC,IAAI,CAAC,IAAI,CAAC,qBAAqB,CAAC,IAAI,CAAC,UAAU,CAAC,EAAE,CAAC;YACjD,IAAI,CAAC,2BAA2B,CAAC,IAAI,EAAE,IAAI,CAAC,UAAU,EAAE,IAAI,EAAE,IAAI,CAAC,UAAU,CAAC,CAAA;QAChF,CAAC;QAED,IAAI,CAAC,uBAAuB,CAAC,IAAI,CAAC,UAAU,EAAE,CAAC,OAAO,EAAE,EAAE;YACxD,IAAI,IAAI,CAAC,qBAAqB,CAAC,OAAO,CAAC,UAAU,CAAC,EAAE,CAAC;gBACnD,OAAM;YACR,CAAC;YAED,MAAM,SAAS,GAAG,WAAW,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAA;YACzD,MAAM,cAAc,GAAG,WAAW,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC,CAAC,IAAI,CAAA;YAEvE,IAAI,cAAc,EAAE,CAAC;gBACnB,IAAI,CAAC,2BAA2B,CAAC,OAAO,EAAE,OAAO,CAAC,UAAU,EAAE,SAAS,EAAE,cAAc,CAAC,CAAA;YAC1F,CAAC;iBAAM,CAAC;gBACN,IAAI,CAAC,oBAAoB,CAAC,OAAO,EAAE,OAAO,CAAC,UAAU,EAAE,SAAS,CAAC,CAAA;YACnE,CAAC;QACH,CAAC,CAAC,CAAA;IACJ,CAAC;IAEO,oBAAoB,CAAC,IAAe;QAC1C,IAAI,IAAI,CAAC,qBAAqB,CAAC,IAAI,CAAC,UAAU,CAAC,EAAE,CAAC;YAChD,OAAO,KAAK,CAAA;QACd,CAAC;QAED,IAAI,UAAU,GAAG,KAAK,CAAA;QACtB,IAAI,CAAC,uBAAuB,CAAC,IAAI,CAAC,UAAU,EAAE,CAAC,OAAO,EAAE,EAAE;YACxD,IAAI,IAAI,CAAC,qBAAqB,CAAC,OAAO,CAAC,UAAU,CAAC,EAAE,CAAC;gBACnD,UAAU,GAAG,IAAI,CAAA;YACnB,CAAC;QACH,CAAC,CAAC,CAAA;QAEF,OAAO,CAAC,UAAU,CAAA;IACpB,CAAC;CACF;AAED,MAAM,OAAO,yBAA0B,SAAQ,UAAU;IACvD,MAAM,CAAC,QAAQ,GAAG,2BAA2B,CAAA;IAE7C,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,MAAM;SACjB,CAAA;IACH,CAAC;IAED,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,4BAA4B,CAAC,IAAI,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAA;QAExE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC"}
@@ -14,7 +14,7 @@ class ERBNoEmptyTagsVisitor extends BaseRuleVisitor {
14
14
  }
15
15
  }
16
16
  export class ERBNoEmptyTagsRule extends ParserRule {
17
- name = "erb-no-empty-tags";
17
+ static ruleName = "erb-no-empty-tags";
18
18
  get defaultConfig() {
19
19
  return {
20
20
  enabled: true,
@@ -22,7 +22,7 @@ export class ERBNoEmptyTagsRule extends ParserRule {
22
22
  };
23
23
  }
24
24
  check(result, context) {
25
- const visitor = new ERBNoEmptyTagsVisitor(this.name, context);
25
+ const visitor = new ERBNoEmptyTagsVisitor(this.ruleName, context);
26
26
  visitor.visit(result.value);
27
27
  return visitor.offenses;
28
28
  }
@@ -0,0 +1 @@
1
+ {"version":3,"file":"erb-no-empty-tags.js","sourceRoot":"","sources":["../../src/rules/erb-no-empty-tags.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAA;AAEjD,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AAIxC,MAAM,qBAAsB,SAAQ,eAAe;IACjD,mBAAmB,CAAC,IAAoB;QACtC,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;QAE1B,MAAM,EAAE,OAAO,EAAE,WAAW,EAAE,GAAG,IAAI,CAAA;QAErC,IAAI,CAAC,OAAO;YAAE,OAAM;QACpB,IAAI,WAAW,EAAE,KAAK,KAAK,EAAE;YAAE,OAAM;QACrC,IAAI,OAAO,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,MAAM,GAAG,CAAC;YAAE,OAAM;QAE3C,IAAI,CAAC,UAAU,CACb,oEAAoE,EACpE,IAAI,CAAC,QAAQ,CACd,CAAA;IACH,CAAC;CACF;AAED,MAAM,OAAO,kBAAmB,SAAQ,UAAU;IAChD,MAAM,CAAC,QAAQ,GAAG,mBAAmB,CAAA;IAErC,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,OAAO;SAClB,CAAA;IACH,CAAC;IAED,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,qBAAqB,CAAC,IAAI,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAA;QAEjE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC"}
@@ -1,23 +1,6 @@
1
- import { BaseSourceRuleVisitor } from "./rule-utils.js";
1
+ import { Location } from "@herb-tools/core";
2
+ import { BaseSourceRuleVisitor, positionFromOffset } from "./rule-utils.js";
2
3
  import { SourceRule } from "../types.js";
3
- import { Location, Position } from "@herb-tools/core";
4
- function positionFromOffset(source, offset) {
5
- let line = 1;
6
- let column = 0;
7
- let currentOffset = 0;
8
- for (let i = 0; i < source.length && currentOffset < offset; i++) {
9
- const char = source[i];
10
- currentOffset++;
11
- if (char === "\n") {
12
- line++;
13
- column = 0;
14
- }
15
- else {
16
- column++;
17
- }
18
- }
19
- return new Position(line, column);
20
- }
21
4
  class ERBNoExtraNewLineVisitor extends BaseSourceRuleVisitor {
22
5
  visitSource(source) {
23
6
  if (source.length === 0)
@@ -41,7 +24,7 @@ class ERBNoExtraNewLineVisitor extends BaseSourceRuleVisitor {
41
24
  }
42
25
  export class ERBNoExtraNewLineRule extends SourceRule {
43
26
  static autocorrectable = true;
44
- name = "erb-no-extra-newline";
27
+ static ruleName = "erb-no-extra-newline";
45
28
  get defaultConfig() {
46
29
  return {
47
30
  enabled: true,
@@ -49,7 +32,7 @@ export class ERBNoExtraNewLineRule extends SourceRule {
49
32
  };
50
33
  }
51
34
  check(source, context) {
52
- const visitor = new ERBNoExtraNewLineVisitor(this.name, context);
35
+ const visitor = new ERBNoExtraNewLineVisitor(this.ruleName, context);
53
36
  visitor.visit(source);
54
37
  return visitor.offenses;
55
38
  }
@@ -0,0 +1 @@
1
+ {"version":3,"file":"erb-no-extra-newline.js","sourceRoot":"","sources":["../../src/rules/erb-no-extra-newline.ts"],"names":[],"mappings":"AAAA,OAAO,EAAa,QAAQ,EAAE,MAAM,kBAAkB,CAAA;AAEtD,OAAO,EAAE,qBAAqB,EAAE,kBAAkB,EAAE,MAAM,iBAAiB,CAAA;AAC3E,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AAQxC,MAAM,wBAAyB,SAAQ,qBAAsD;IACjF,WAAW,CAAC,MAAc;QAClC,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC;YAAE,OAAM;QAE/B,MAAM,KAAK,GAAG,SAAS,CAAA;QAEvB,IAAI,KAA6B,CAAA;QAEjC,OAAO,CAAC,KAAK,GAAG,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,KAAK,IAAI,EAAE,CAAC;YAC7C,MAAM,WAAW,GAAG,KAAK,CAAC,KAAK,GAAG,CAAC,CAAA;YACnC,MAAM,SAAS,GAAG,KAAK,CAAC,KAAK,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC,MAAM,CAAA;YAC/C,MAAM,KAAK,GAAG,kBAAkB,CAAC,MAAM,EAAE,WAAW,CAAC,CAAA;YACrD,MAAM,GAAG,GAAG,kBAAkB,CAAC,MAAM,EAAE,SAAS,CAAC,CAAA;YACjD,MAAM,QAAQ,GAAG,IAAI,QAAQ,CAAC,KAAK,EAAE,GAAG,CAAC,CAAA;YAEzC,MAAM,UAAU,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC,MAAM,GAAG,CAAC,CAAA;YAEtC,IAAI,CAAC,UAAU,CACb,qCAAqC,UAAU,UAAU,UAAU,KAAK,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,OAAO,kDAAkD,EAC9I,QAAQ,EACR;gBACE,IAAI,EAAE,IAAmB;gBACzB,WAAW;gBACX,SAAS;aACV,CACF,CAAA;QACH,CAAC;IACH,CAAC;CACF;AAED,MAAM,OAAO,qBAAsB,SAAQ,UAAU;IACnD,MAAM,CAAC,eAAe,GAAG,IAAI,CAAA;IAC7B,MAAM,CAAC,QAAQ,GAAG,sBAAsB,CAAA;IAExC,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,OAAO;SAClB,CAAA;IACH,CAAC;IAED,KAAK,CAAC,MAAc,EAAE,OAA8B;QAClD,MAAM,OAAO,GAAG,IAAI,wBAAwB,CAAC,IAAI,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAA;QAEpE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,CAAA;QAErB,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;IAED,OAAO,CAAC,OAAqD,EAAE,MAAc,EAAE,QAA+B;QAC5G,IAAI,CAAC,OAAO,CAAC,cAAc;YAAE,OAAO,IAAI,CAAA;QAExC,MAAM,EAAE,WAAW,EAAE,SAAS,EAAE,GAAG,OAAO,CAAC,cAAc,CAAA;QAEzD,MAAM,MAAM,GAAG,MAAM,CAAC,SAAS,CAAC,CAAC,EAAE,WAAW,CAAC,CAAA;QAC/C,MAAM,KAAK,GAAG,MAAM,CAAC,SAAS,CAAC,SAAS,CAAC,CAAA;QAEzC,OAAO,MAAM,GAAG,KAAK,CAAA;IACvB,CAAC"}
@@ -11,16 +11,39 @@ class ERBNoExtraWhitespaceInsideTagsVisitor extends BaseRuleVisitor {
11
11
  if (this.hasExtraLeadingWhitespace(value)) {
12
12
  this.reportWhitespace(node, openTag, closeTag, value, "start", 0, `Remove extra whitespace after \`${openTag.value}\`.`, "after-open");
13
13
  }
14
- if (openTag.value === "<%#" && value.startsWith("=") && value.length > 1) {
15
- const afterEquals = value.substring(1);
16
- if (afterEquals.match(/^\s{2,}/) && !afterEquals.startsWith(" \n") && !afterEquals.startsWith("\n")) {
17
- this.reportWhitespace(node, openTag, closeTag, value, "start", 1, `Remove extra whitespace after \`<%#=\`.`, "after-comment-equals");
14
+ if (openTag.value === "<%#") {
15
+ const prefix = this.getCommentedTagPrefix(value);
16
+ if (prefix) {
17
+ const afterPrefix = value.substring(prefix.length);
18
+ const tag = `<%#${prefix}`;
19
+ const hasExtraWhitespace = afterPrefix.match(/^\s{2,}/) && !afterPrefix.startsWith(" \n") && !afterPrefix.startsWith("\n");
20
+ if (hasExtraWhitespace) {
21
+ this.reportWhitespace(node, openTag, closeTag, value, "start", prefix.length, `Remove extra whitespace after \`${tag}\`. This looks like a temporarily commented ERB tag.`, "after-comment-equals", "info");
22
+ }
23
+ else {
24
+ this.addOffense(`\`${tag}\` looks like a temporarily commented ERB tag.`, openTag.location, { node, openTag, closeTag, content: value, fixType: "after-comment-equals", unsafe: true }, "info");
25
+ }
18
26
  }
19
27
  }
20
28
  if (this.hasExtraTrailingWhitespace(value)) {
21
29
  this.reportWhitespace(node, openTag, closeTag, value, "end", 0, `Remove extra whitespace before \`${closeTag.value}\`.`, "before-close");
22
30
  }
23
31
  }
32
+ getCommentedTagPrefix(content) {
33
+ if (content.startsWith("graphql"))
34
+ return "graphql";
35
+ if (content.startsWith("%="))
36
+ return "%=";
37
+ if (content.startsWith("=="))
38
+ return "==";
39
+ if (content.startsWith("%"))
40
+ return "%";
41
+ if (content.startsWith("="))
42
+ return "=";
43
+ if (content.startsWith("-"))
44
+ return "-";
45
+ return null;
46
+ }
24
47
  hasExtraLeadingWhitespace(content) {
25
48
  return content.startsWith(" ") && !content.startsWith(" \n");
26
49
  }
@@ -41,20 +64,21 @@ class ERBNoExtraWhitespaceInsideTagsVisitor extends BaseRuleVisitor {
41
64
  return Location.from(contentLocation.end.line, contentLocation.end.column - length, contentLocation.end.line, contentLocation.end.column);
42
65
  }
43
66
  }
44
- reportWhitespace(node, openTag, closeTag, content, position, offset, message, fixType) {
67
+ reportWhitespace(node, openTag, closeTag, content, position, offset, message, fixType, severity, unsafe) {
45
68
  const location = this.getWhitespaceLocation(node, content, position, offset);
46
69
  this.addOffense(message, location, {
47
70
  node,
48
71
  openTag,
49
72
  closeTag,
50
73
  content,
51
- fixType
52
- });
74
+ fixType,
75
+ unsafe,
76
+ }, severity);
53
77
  }
54
78
  }
55
79
  export class ERBNoExtraWhitespaceRule extends ParserRule {
56
80
  static autocorrectable = true;
57
- name = "erb-no-extra-whitespace-inside-tags";
81
+ static ruleName = "erb-no-extra-whitespace-inside-tags";
58
82
  get defaultConfig() {
59
83
  return {
60
84
  enabled: true,
@@ -62,7 +86,7 @@ export class ERBNoExtraWhitespaceRule extends ParserRule {
62
86
  };
63
87
  }
64
88
  check(result, context) {
65
- const visitor = new ERBNoExtraWhitespaceInsideTagsVisitor(this.name, context);
89
+ const visitor = new ERBNoExtraWhitespaceInsideTagsVisitor(this.ruleName, context);
66
90
  visitor.visit(result.value);
67
91
  return visitor.offenses;
68
92
  }
@@ -80,12 +104,14 @@ export class ERBNoExtraWhitespaceRule extends ParserRule {
80
104
  case "after-open":
81
105
  node.content.value = content.replace(/^\s{2,}/, " ");
82
106
  break;
83
- case "after-comment-equals":
84
- if (content.startsWith("=")) {
85
- const afterEquals = content.substring(1);
86
- node.content.value = "= " + afterEquals.replace(/^\s{2,}/, "");
107
+ case "after-comment-equals": {
108
+ const prefix = content.startsWith("graphql") ? "graphql" : content.startsWith("%=") ? "%=" : content.startsWith("==") ? "==" : content.startsWith("%") ? "%" : content.startsWith("=") ? "=" : content.startsWith("-") ? "-" : null;
109
+ if (prefix) {
110
+ const afterPrefix = content.substring(prefix.length);
111
+ node.content.value = prefix + " " + afterPrefix.replace(/^\s{2,}/, "");
87
112
  }
88
113
  break;
114
+ }
89
115
  default:
90
116
  return null;
91
117
  }
@@ -0,0 +1 @@
1
+ {"version":3,"file":"erb-no-extra-whitespace-inside-tags.js","sourceRoot":"","sources":["../../src/rules/erb-no-extra-whitespace-inside-tags.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAA+B,MAAM,aAAa,CAAA;AACrE,OAAO,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAA;AAGjD,OAAO,EAAE,QAAQ,EAAE,MAAM,kBAAkB,CAAA;AAW3C,MAAM,qCAAsC,SAAQ,eAAmD;IAErG,YAAY,CAAC,IAAa;QACxB,MAAM,OAAO,GAAG,IAAI,CAAC,WAAW,CAAA;QAChC,MAAM,QAAQ,GAAG,IAAI,CAAC,WAAW,CAAA;QACjC,MAAM,EAAE,KAAK,EAAE,GAAG,IAAI,CAAC,OAAO,IAAI,EAAE,CAAA;QAEpC,IAAI,CAAC,OAAO,IAAI,CAAC,QAAQ,IAAI,CAAC,KAAK;YAAE,OAAM;QAE3C,IAAI,IAAI,CAAC,yBAAyB,CAAC,KAAK,CAAC,EAAE,CAAC;YAC1C,IAAI,CAAC,gBAAgB,CAAC,IAAI,EAAE,OAAO,EAAE,QAAQ,EAAE,KAAK,EAAE,OAAO,EAAE,CAAC,EAAE,mCAAmC,OAAO,CAAC,KAAK,KAAK,EAAE,YAAY,CAAC,CAAA;QACxI,CAAC;QAED,IAAI,OAAO,CAAC,KAAK,KAAK,KAAK,EAAE,CAAC;YAC5B,MAAM,MAAM,GAAG,IAAI,CAAC,qBAAqB,CAAC,KAAK,CAAC,CAAA;YAEhD,IAAI,MAAM,EAAE,CAAC;gBACX,MAAM,WAAW,GAAG,KAAK,CAAC,SAAS,CAAC,MAAM,CAAC,MAAM,CAAC,CAAA;gBAClD,MAAM,GAAG,GAAG,MAAM,MAAM,EAAE,CAAA;gBAC1B,MAAM,kBAAkB,GAAG,WAAW,CAAC,KAAK,CAAC,SAAS,CAAC,IAAI,CAAC,WAAW,CAAC,UAAU,CAAC,MAAM,CAAC,IAAI,CAAC,WAAW,CAAC,UAAU,CAAC,IAAI,CAAC,CAAA;gBAE3H,IAAI,kBAAkB,EAAE,CAAC;oBACvB,IAAI,CAAC,gBAAgB,CAAC,IAAI,EAAE,OAAO,EAAE,QAAQ,EAAE,KAAK,EAAE,OAAO,EAAE,MAAM,CAAC,MAAM,EAAE,mCAAmC,GAAG,sDAAsD,EAAE,sBAAsB,EAAE,MAAM,CAAC,CAAA;gBAC7M,CAAC;qBAAM,CAAC;oBACN,IAAI,CAAC,UAAU,CACb,KAAK,GAAG,gDAAgD,EACxD,OAAO,CAAC,QAAQ,EAChB,EAAE,IAAI,EAAE,OAAO,EAAE,QAAQ,EAAE,OAAO,EAAE,KAAK,EAAE,OAAO,EAAE,sBAAsB,EAAE,MAAM,EAAE,IAAI,EAAE,EAC1F,MAAM,CACP,CAAA;gBACH,CAAC;YACH,CAAC;QACH,CAAC;QAED,IAAI,IAAI,CAAC,0BAA0B,CAAC,KAAK,CAAC,EAAE,CAAC;YAC3C,IAAI,CAAC,gBAAgB,CAAC,IAAI,EAAE,OAAO,EAAE,QAAQ,EAAE,KAAK,EAAE,KAAK,EAAE,CAAC,EAAE,oCAAoC,QAAQ,CAAC,KAAK,KAAK,EAAE,cAAc,CAAC,CAAA;QAC1I,CAAC;IACH,CAAC;IAEO,qBAAqB,CAAC,OAAe;QAC3C,IAAI,OAAO,CAAC,UAAU,CAAC,SAAS,CAAC;YAAE,OAAO,SAAS,CAAA;QACnD,IAAI,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC;YAAE,OAAO,IAAI,CAAA;QACzC,IAAI,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC;YAAE,OAAO,IAAI,CAAA;QACzC,IAAI,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC;YAAE,OAAO,GAAG,CAAA;QACvC,IAAI,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC;YAAE,OAAO,GAAG,CAAA;QACvC,IAAI,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC;YAAE,OAAO,GAAG,CAAA;QAEvC,OAAO,IAAI,CAAA;IACb,CAAC;IAEO,yBAAyB,CAAC,OAAe;QAC/C,OAAO,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,MAAM,CAAC,CAAA;IAChE,CAAC;IAEO,0BAA0B,CAAC,OAAe;QAChD,OAAO,CAAC,OAAO,CAAC,QAAQ,CAAC,IAAI,CAAC,IAAI,SAAS,CAAC,IAAI,CAAC,OAAO,CAAC,CAAA;IAC3D,CAAC;IAEO,qBAAqB,CAAC,IAAa,EAAE,OAAe,EAAE,QAAyB,EAAE,SAAiB,CAAC;QACzG,MAAM,eAAe,GAAG,IAAI,CAAC,OAAQ,CAAC,QAAQ,CAAA;QAE9C,IAAI,QAAQ,KAAK,OAAO,EAAE,CAAC;YACzB,MAAM,KAAK,GAAG,OAAO,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC,KAAK,CAAC,MAAM,CAAC,CAAA;YACrD,MAAM,MAAM,GAAG,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,CAAA;YAC1C,MAAM,WAAW,GAAG,eAAe,CAAC,KAAK,CAAC,MAAM,GAAG,MAAM,CAAA;YAEzD,OAAO,QAAQ,CAAC,IAAI,CAClB,eAAe,CAAC,KAAK,CAAC,IAAI,EAC1B,WAAW,EACX,eAAe,CAAC,KAAK,CAAC,IAAI,EAC1B,WAAW,GAAG,MAAM,CACrB,CAAA;QACH,CAAC;aAAM,CAAC;YACN,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,CAAA;YACnC,MAAM,MAAM,GAAG,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,CAAA;YAE1C,OAAO,QAAQ,CAAC,IAAI,CAClB,eAAe,CAAC,GAAG,CAAC,IAAI,EACxB,eAAe,CAAC,GAAG,CAAC,MAAM,GAAG,MAAM,EACnC,eAAe,CAAC,GAAG,CAAC,IAAI,EACxB,eAAe,CAAC,GAAG,CAAC,MAAM,CAC3B,CAAA;QACH,CAAC;IACH,CAAC;IAEO,gBAAgB,CACtB,IAAa,EACb,OAAc,EACd,QAAe,EACf,OAAe,EACf,QAAyB,EACzB,MAAc,EACd,OAAe,EACf,OAA+D,EAC/D,QAAuB,EACvB,MAAgB;QAEhB,MAAM,QAAQ,GAAG,IAAI,CAAC,qBAAqB,CAAC,IAAI,EAAE,OAAO,EAAE,QAAQ,EAAE,MAAM,CAAC,CAAA;QAC5E,IAAI,CAAC,UAAU,CAAC,OAAO,EAAE,QAAQ,EAAE;YACjC,IAAI;YACJ,OAAO;YACP,QAAQ;YACR,OAAO;YACP,OAAO;YACP,MAAM;SACP,EAAE,QAAQ,CAAC,CAAA;IACd,CAAC;CACF;AAED,MAAM,OAAO,wBAAyB,SAAQ,UAA8C;IAC1F,MAAM,CAAC,eAAe,GAAG,IAAI,CAAA;IAC7B,MAAM,CAAC,QAAQ,GAAG,qCAAqC,CAAA;IAEvD,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,OAAO;SAClB,CAAA;IACH,CAAC;IAED,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,qCAAqC,CAAC,IAAI,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAA;QAEjF,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;IAED,OAAO,CAAC,OAAwD,EAAE,MAAmB,EAAE,QAA+B;QACpH,IAAI,CAAC,OAAO,CAAC,cAAc;YAAE,OAAO,IAAI,CAAA;QAExC,MAAM,EAAE,IAAI,EAAE,OAAO,EAAE,GAAG,OAAO,CAAC,cAAc,CAAA;QAChD,IAAI,CAAC,IAAI,CAAC,OAAO;YAAE,OAAO,IAAI,CAAA;QAE9B,MAAM,OAAO,GAAG,IAAI,CAAC,OAAO,CAAC,KAAK,CAAA;QAElC,QAAQ,OAAO,EAAE,CAAC;YAChB,KAAK,cAAc;gBACjB,IAAI,CAAC,OAAO,CAAC,KAAK,GAAG,OAAO,CAAC,OAAO,CAAC,SAAS,EAAE,GAAG,CAAC,CAAA;gBACpD,MAAK;YAEP,KAAK,YAAY;gBACf,IAAI,CAAC,OAAO,CAAC,KAAK,GAAG,OAAO,CAAC,OAAO,CAAC,SAAS,EAAE,GAAG,CAAC,CAAA;gBACpD,MAAK;YAEP,KAAK,sBAAsB,CAAC,CAAC,CAAC;gBAC5B,MAAM,MAAM,GAAG,OAAO,CAAC,UAAU,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAA;gBAEnO,IAAI,MAAM,EAAE,CAAC;oBACX,MAAM,WAAW,GAAG,OAAO,CAAC,SAAS,CAAC,MAAM,CAAC,MAAM,CAAC,CAAA;oBACpD,IAAI,CAAC,OAAO,CAAC,KAAK,GAAG,MAAM,GAAG,GAAG,GAAG,WAAW,CAAC,OAAO,CAAC,SAAS,EAAE,EAAE,CAAC,CAAA;gBACxE,CAAC;gBAED,MAAK;YACP,CAAC;YACD;gBACE,OAAO,IAAI,CAAA;QACf,CAAC;QAED,OAAO,MAAM,CAAA;IACf,CAAC"}
@@ -0,0 +1,40 @@
1
+ import { ParserRule } from "../types.js";
2
+ import { BaseRuleVisitor } from "./rule-utils.js";
3
+ class ERBNoInlineCaseConditionsVisitor extends BaseRuleVisitor {
4
+ visitERBCaseNode(node) {
5
+ this.checkConditions(node, "when");
6
+ this.visitChildNodes(node);
7
+ }
8
+ visitERBCaseMatchNode(node) {
9
+ this.checkConditions(node, "in");
10
+ this.visitChildNodes(node);
11
+ }
12
+ checkConditions(node, type) {
13
+ if (!node.conditions || node.conditions.length === 0)
14
+ return;
15
+ for (const condition of node.conditions) {
16
+ if (condition.tag_opening === null) {
17
+ this.addOffense(`A \`case\` statement with \`${type}\` conditions in a single ERB tag cannot be reliably parsed, compiled, and formatted. Use separate ERB tags for \`case\` and its conditions (e.g., \`<% case x %>\` followed by \`<% ${type} y %>\`).`, node.location);
18
+ break;
19
+ }
20
+ }
21
+ }
22
+ }
23
+ export class ERBNoInlineCaseConditionsRule extends ParserRule {
24
+ static ruleName = "erb-no-inline-case-conditions";
25
+ get defaultConfig() {
26
+ return {
27
+ enabled: true,
28
+ severity: "warning",
29
+ };
30
+ }
31
+ get parserOptions() {
32
+ return { strict: false };
33
+ }
34
+ check(result, context) {
35
+ const visitor = new ERBNoInlineCaseConditionsVisitor(this.ruleName, context);
36
+ visitor.visit(result.value);
37
+ return visitor.offenses;
38
+ }
39
+ }
40
+ //# sourceMappingURL=erb-no-inline-case-conditions.js.map
@@ -0,0 +1 @@
1
+ {"version":3,"file":"erb-no-inline-case-conditions.js","sourceRoot":"","sources":["../../src/rules/erb-no-inline-case-conditions.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAA;AAKjD,MAAM,gCAAiC,SAAQ,eAAe;IAC5D,gBAAgB,CAAC,IAAiB;QAChC,IAAI,CAAC,eAAe,CAAC,IAAI,EAAE,MAAM,CAAC,CAAA;QAClC,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAED,qBAAqB,CAAC,IAAsB;QAC1C,IAAI,CAAC,eAAe,CAAC,IAAI,EAAE,IAAI,CAAC,CAAA;QAChC,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAEO,eAAe,CAAC,IAAoC,EAAE,IAAY;QACxE,IAAI,CAAC,IAAI,CAAC,UAAU,IAAI,IAAI,CAAC,UAAU,CAAC,MAAM,KAAK,CAAC;YAAE,OAAM;QAE5D,KAAK,MAAM,SAAS,IAAI,IAAI,CAAC,UAAyC,EAAE,CAAC;YACvE,IAAI,SAAS,CAAC,WAAW,KAAK,IAAI,EAAE,CAAC;gBACnC,IAAI,CAAC,UAAU,CACb,+BAA+B,IAAI,wLAAwL,IAAI,WAAW,EAC1O,IAAI,CAAC,QAAQ,CACd,CAAA;gBACD,MAAK;YACP,CAAC;QACH,CAAC;IACH,CAAC;CACF;AAED,MAAM,OAAO,6BAA8B,SAAQ,UAAU;IAC3D,MAAM,CAAC,QAAQ,GAAG,+BAA+B,CAAA;IAEjD,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,SAAS;SACpB,CAAA;IACH,CAAC;IAED,IAAI,aAAa;QACf,OAAO,EAAE,MAAM,EAAE,KAAK,EAAE,CAAA;IAC1B,CAAC;IAED,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,gCAAgC,CAAC,IAAI,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAA;QAE5E,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC"}
@@ -0,0 +1,67 @@
1
+ import { PrismVisitor } from "@herb-tools/core";
2
+ import { ParserRule } from "../types.js";
3
+ import { isPartialFile } from "./file-utils.js";
4
+ import { locationFromOffset } from "./rule-utils.js";
5
+ class InstanceVariableCollector extends PrismVisitor {
6
+ instanceVariables = [];
7
+ visitInstanceVariableReadNode(node) {
8
+ this.collect(node, "read");
9
+ }
10
+ visitInstanceVariableWriteNode(node) {
11
+ this.collect(node, "write");
12
+ }
13
+ visitInstanceVariableAndWriteNode(node) {
14
+ this.collect(node, "write");
15
+ }
16
+ visitInstanceVariableOrWriteNode(node) {
17
+ this.collect(node, "write");
18
+ }
19
+ visitInstanceVariableOperatorWriteNode(node) {
20
+ this.collect(node, "write");
21
+ }
22
+ visitInstanceVariableTargetNode(node) {
23
+ this.collect(node, "write");
24
+ }
25
+ collect(node, usage) {
26
+ this.instanceVariables.push({
27
+ name: node.name,
28
+ usage,
29
+ startOffset: node.location.startOffset,
30
+ length: node.location.length
31
+ });
32
+ }
33
+ }
34
+ export class ERBNoInstanceVariablesInPartialsRule extends ParserRule {
35
+ static ruleName = "erb-no-instance-variables-in-partials";
36
+ get defaultConfig() {
37
+ return {
38
+ enabled: true,
39
+ severity: "error",
40
+ };
41
+ }
42
+ get parserOptions() {
43
+ return {
44
+ track_whitespace: true,
45
+ prism_program: true,
46
+ };
47
+ }
48
+ isEnabled(_result, context) {
49
+ return isPartialFile(context?.fileName) === true;
50
+ }
51
+ check(result, _context) {
52
+ const source = result.value.source;
53
+ const prismNode = result.value.prismNode;
54
+ if (!prismNode || !source)
55
+ return [];
56
+ const collector = new InstanceVariableCollector();
57
+ collector.visit(prismNode);
58
+ return collector.instanceVariables.map(ivar => {
59
+ const location = locationFromOffset(source, ivar.startOffset, ivar.length);
60
+ const message = ivar.usage === "read"
61
+ ? `Avoid using instance variables in partials. Pass \`${ivar.name}\` as a local variable instead.`
62
+ : `Avoid setting instance variables in partials. Use a local variable instead of \`${ivar.name}\`.`;
63
+ return this.createOffense(message, location);
64
+ });
65
+ }
66
+ }
67
+ //# sourceMappingURL=erb-no-instance-variables-in-partials.js.map
@@ -0,0 +1 @@
1
+ {"version":3,"file":"erb-no-instance-variables-in-partials.js","sourceRoot":"","sources":["../../src/rules/erb-no-instance-variables-in-partials.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,YAAY,EAAc,MAAM,kBAAkB,CAAA;AAC3D,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AAExC,OAAO,EAAE,aAAa,EAAE,MAAM,iBAAiB,CAAA;AAC/C,OAAO,EAAE,kBAAkB,EAAE,MAAM,iBAAiB,CAAA;AAmBpD,MAAM,yBAA0B,SAAQ,YAAY;IAClC,iBAAiB,GAAgC,EAAE,CAAA;IAEnE,6BAA6B,CAAC,IAAyC;QACrE,IAAI,CAAC,OAAO,CAAC,IAAI,EAAE,MAAM,CAAC,CAAA;IAC5B,CAAC;IAED,8BAA8B,CAAC,IAA0C;QACvE,IAAI,CAAC,OAAO,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;IAC7B,CAAC;IAED,iCAAiC,CAAC,IAA6C;QAC7E,IAAI,CAAC,OAAO,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;IAC7B,CAAC;IAED,gCAAgC,CAAC,IAA4C;QAC3E,IAAI,CAAC,OAAO,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;IAC7B,CAAC;IAED,sCAAsC,CAAC,IAAkD;QACvF,IAAI,CAAC,OAAO,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;IAC7B,CAAC;IAED,+BAA+B,CAAC,IAA2C;QACzE,IAAI,CAAC,OAAO,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;IAC7B,CAAC;IAEO,OAAO,CAAC,IAA0B,EAAE,KAA4B;QACtE,IAAI,CAAC,iBAAiB,CAAC,IAAI,CAAC;YAC1B,IAAI,EAAE,IAAI,CAAC,IAAI;YACf,KAAK;YACL,WAAW,EAAE,IAAI,CAAC,QAAQ,CAAC,WAAW;YACtC,MAAM,EAAE,IAAI,CAAC,QAAQ,CAAC,MAAM;SAC7B,CAAC,CAAA;IACJ,CAAC;CACF;AAED,MAAM,OAAO,oCAAqC,SAAQ,UAAU;IAClE,MAAM,CAAC,QAAQ,GAAG,uCAAuC,CAAA;IAEzD,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,OAAO;SAClB,CAAA;IACH,CAAC;IAED,IAAI,aAAa;QACf,OAAO;YACL,gBAAgB,EAAE,IAAI;YACtB,aAAa,EAAE,IAAI;SACpB,CAAA;IACH,CAAC;IAED,SAAS,CAAC,OAAoB,EAAE,OAA8B;QAC5D,OAAO,aAAa,CAAC,OAAO,EAAE,QAAQ,CAAC,KAAK,IAAI,CAAA;IAClD,CAAC;IAED,KAAK,CAAC,MAAmB,EAAE,QAA+B;QACxD,MAAM,MAAM,GAAG,MAAM,CAAC,KAAK,CAAC,MAAM,CAAA;QAClC,MAAM,SAAS,GAAG,MAAM,CAAC,KAAK,CAAC,SAAS,CAAA;QAExC,IAAI,CAAC,SAAS,IAAI,CAAC,MAAM;YAAE,OAAO,EAAE,CAAA;QAEpC,MAAM,SAAS,GAAG,IAAI,yBAAyB,EAAE,CAAA;QAEjD,SAAS,CAAC,KAAK,CAAC,SAAS,CAAC,CAAA;QAE1B,OAAO,SAAS,CAAC,iBAAiB,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE;YAC5C,MAAM,QAAQ,GAAG,kBAAkB,CAAC,MAAM,EAAE,IAAI,CAAC,WAAW,EAAE,IAAI,CAAC,MAAM,CAAC,CAAA;YAC1E,MAAM,OAAO,GAAG,IAAI,CAAC,KAAK,KAAK,MAAM;gBACnC,CAAC,CAAC,sDAAsD,IAAI,CAAC,IAAI,iCAAiC;gBAClG,CAAC,CAAC,mFAAmF,IAAI,CAAC,IAAI,KAAK,CAAA;YAErG,OAAO,IAAI,CAAC,aAAa,CAAC,OAAO,EAAE,QAAQ,CAAC,CAAA;QAC9C,CAAC,CAAC,CAAA;IACJ,CAAC"}
@@ -0,0 +1,47 @@
1
+ import { isLiteralNode, isPureWhitespaceNode, splitLiteralsAtWhitespace, groupNodesByClass } from "@herb-tools/core";
2
+ import { IdentityPrinter } from "@herb-tools/printer";
3
+ import { ParserRule } from "../types.js";
4
+ import { AttributeVisitorMixin } from "./rule-utils.js";
5
+ function groupToString(group) {
6
+ return group.map(node => {
7
+ if (isLiteralNode(node)) {
8
+ return node.content;
9
+ }
10
+ return IdentityPrinter.print(node, { ignoreErrors: true });
11
+ }).join("");
12
+ }
13
+ class ERBNoInterpolatedClassNamesVisitor extends AttributeVisitorMixin {
14
+ checkStaticAttributeDynamicValue({ attributeName, valueNodes, attributeNode }) {
15
+ if (attributeName !== "class")
16
+ return;
17
+ const splitNodes = splitLiteralsAtWhitespace(valueNodes);
18
+ const groups = groupNodesByClass(splitNodes);
19
+ for (const group of groups) {
20
+ if (group.every(node => isPureWhitespaceNode(node)))
21
+ continue;
22
+ const isInterpolated = group.some(node => !isLiteralNode(node));
23
+ if (!isInterpolated)
24
+ continue;
25
+ const hasAttachedLiteral = group.some(node => isLiteralNode(node) && node.content.trim());
26
+ if (!hasAttachedLiteral)
27
+ continue;
28
+ const className = groupToString(group);
29
+ this.addOffense(`Avoid ERB interpolation inside class names: \`${className}\`. Use standalone ERB expressions that output complete class names instead.`, attributeNode.value.location);
30
+ }
31
+ }
32
+ }
33
+ export class ERBNoInterpolatedClassNamesRule extends ParserRule {
34
+ static ruleName = "erb-no-interpolated-class-names";
35
+ get defaultConfig() {
36
+ return {
37
+ enabled: true,
38
+ severity: "warning"
39
+ };
40
+ }
41
+ check(result, context) {
42
+ const visitor = new ERBNoInterpolatedClassNamesVisitor(this.ruleName, context);
43
+ visitor.visit(result.value);
44
+ return visitor.offenses;
45
+ }
46
+ }
47
+ //# sourceMappingURL=erb-no-interpolated-class-names.js.map
@@ -0,0 +1 @@
1
+ {"version":3,"file":"erb-no-interpolated-class-names.js","sourceRoot":"","sources":["../../src/rules/erb-no-interpolated-class-names.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,aAAa,EAAE,oBAAoB,EAAE,yBAAyB,EAAE,iBAAiB,EAAE,MAAM,kBAAkB,CAAA;AACpH,OAAO,EAAE,eAAe,EAAE,MAAM,qBAAqB,CAAA;AAErD,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,qBAAqB,EAAE,MAAM,iBAAiB,CAAA;AAOvD,SAAS,aAAa,CAAC,KAAa;IAClC,OAAO,KAAK,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE;QACtB,IAAI,aAAa,CAAC,IAAI,CAAC,EAAE,CAAC;YACxB,OAAO,IAAI,CAAC,OAAO,CAAA;QACrB,CAAC;QAED,OAAO,eAAe,CAAC,KAAK,CAAC,IAAI,EAAE,EAAE,YAAY,EAAE,IAAI,EAAE,CAAC,CAAA;IAC5D,CAAC,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;AACb,CAAC;AAED,MAAM,kCAAmC,SAAQ,qBAAqB;IAC1D,gCAAgC,CAAC,EAAE,aAAa,EAAE,UAAU,EAAE,aAAa,EAAqC;QACxH,IAAI,aAAa,KAAK,OAAO;YAAE,OAAM;QAErC,MAAM,UAAU,GAAG,yBAAyB,CAAC,UAAU,CAAC,CAAA;QACxD,MAAM,MAAM,GAAG,iBAAiB,CAAC,UAAU,CAAC,CAAA;QAE5C,KAAK,MAAM,KAAK,IAAI,MAAM,EAAE,CAAC;YAC3B,IAAI,KAAK,CAAC,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAC;gBAAE,SAAQ;YAE7D,MAAM,cAAc,GAAG,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC,aAAa,CAAC,IAAI,CAAC,CAAC,CAAA;YAC/D,IAAI,CAAC,cAAc;gBAAE,SAAQ;YAE7B,MAAM,kBAAkB,GAAG,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,aAAa,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC,CAAA;YACzF,IAAI,CAAC,kBAAkB;gBAAE,SAAQ;YAEjC,MAAM,SAAS,GAAG,aAAa,CAAC,KAAK,CAAC,CAAA;YAEtC,IAAI,CAAC,UAAU,CACb,iDAAiD,SAAS,8EAA8E,EACxI,aAAa,CAAC,KAAM,CAAC,QAAQ,CAC9B,CAAA;QACH,CAAC;IACH,CAAC;CACF;AAED,MAAM,OAAO,+BAAgC,SAAQ,UAAU;IAC7D,MAAM,CAAC,QAAQ,GAAG,iCAAiC,CAAA;IAEnD,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,SAAS;SACpB,CAAA;IACH,CAAC;IAED,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,kCAAkC,CAAC,IAAI,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAA;QAE9E,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC"}
@@ -0,0 +1,34 @@
1
+ import { ParserRule } from "../types.js";
2
+ import { BaseRuleVisitor } from "./rule-utils.js";
3
+ import { isERBNode, isERBOutputNode } from "@herb-tools/core";
4
+ const JAVASCRIPT_TAG_PATTERN = /\bjavascript_tag\b/;
5
+ class ERBNoJavascriptTagHelperVisitor extends BaseRuleVisitor {
6
+ visitDocumentNode(node) {
7
+ for (const child of node.children || []) {
8
+ if (!isERBNode(child))
9
+ continue;
10
+ if (!isERBOutputNode(child))
11
+ continue;
12
+ const content = child.content?.value || "";
13
+ if (JAVASCRIPT_TAG_PATTERN.test(content)) {
14
+ this.addOffense("Avoid `javascript_tag`. Use inline `<script>` tags instead.", child.location);
15
+ }
16
+ }
17
+ super.visitDocumentNode(node);
18
+ }
19
+ }
20
+ export class ERBNoJavascriptTagHelperRule extends ParserRule {
21
+ static ruleName = "erb-no-javascript-tag-helper";
22
+ get defaultConfig() {
23
+ return {
24
+ enabled: true,
25
+ severity: "warning"
26
+ };
27
+ }
28
+ check(result, context) {
29
+ const visitor = new ERBNoJavascriptTagHelperVisitor(this.ruleName, context);
30
+ visitor.visit(result.value);
31
+ return visitor.offenses;
32
+ }
33
+ }
34
+ //# sourceMappingURL=erb-no-javascript-tag-helper.js.map
@@ -0,0 +1 @@
1
+ {"version":3,"file":"erb-no-javascript-tag-helper.js","sourceRoot":"","sources":["../../src/rules/erb-no-javascript-tag-helper.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAA;AACjD,OAAO,EAAE,SAAS,EAAE,eAAe,EAAE,MAAM,kBAAkB,CAAA;AAK7D,MAAM,sBAAsB,GAAG,oBAAoB,CAAA;AAEnD,MAAM,+BAAgC,SAAQ,eAAe;IAC3D,iBAAiB,CAAC,IAAkB;QAClC,KAAK,MAAM,KAAK,IAAI,IAAI,CAAC,QAAQ,IAAI,EAAE,EAAE,CAAC;YACxC,IAAI,CAAC,SAAS,CAAC,KAAK,CAAC;gBAAE,SAAQ;YAC/B,IAAI,CAAC,eAAe,CAAC,KAAK,CAAC;gBAAE,SAAQ;YAErC,MAAM,OAAO,GAAG,KAAK,CAAC,OAAO,EAAE,KAAK,IAAI,EAAE,CAAA;YAE1C,IAAI,sBAAsB,CAAC,IAAI,CAAC,OAAO,CAAC,EAAE,CAAC;gBACzC,IAAI,CAAC,UAAU,CACb,6DAA6D,EAC7D,KAAK,CAAC,QAAQ,CACf,CAAA;YACH,CAAC;QACH,CAAC;QAED,KAAK,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAA;IAC/B,CAAC;CACF;AAED,MAAM,OAAO,4BAA6B,SAAQ,UAAU;IAC1D,MAAM,CAAC,QAAQ,GAAG,8BAA8B,CAAA;IAEhD,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,SAAS;SACpB,CAAA;IACH,CAAC;IAED,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,+BAA+B,CAAC,IAAI,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAA;QAE3E,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC"}
@@ -17,28 +17,25 @@ class ERBNoOutputControlFlowRuleVisitor extends BaseRuleVisitor {
17
17
  this.checkOutputControlFlow(node);
18
18
  this.visitChildNodes(node);
19
19
  }
20
+ static CONTROL_BLOCK_NAMES = {
21
+ "AST_ERB_IF_NODE": "if",
22
+ "AST_ERB_ELSE_NODE": "else",
23
+ "AST_ERB_END_NODE": "end",
24
+ "AST_ERB_UNLESS_NODE": "unless"
25
+ };
20
26
  checkOutputControlFlow(controlBlock) {
21
27
  const openTag = controlBlock.tag_opening;
22
28
  if (!openTag) {
23
29
  return;
24
30
  }
25
31
  if (openTag.value === "<%=") {
26
- let controlBlockType = controlBlock.type;
27
- if (controlBlock.type === "AST_ERB_IF_NODE")
28
- controlBlockType = "if";
29
- if (controlBlock.type === "AST_ERB_ELSE_NODE")
30
- controlBlockType = "else";
31
- if (controlBlock.type === "AST_ERB_END_NODE")
32
- controlBlockType = "end";
33
- if (controlBlock.type === "AST_ERB_UNLESS_NODE")
34
- controlBlockType = "unless";
32
+ const controlBlockType = ERBNoOutputControlFlowRuleVisitor.CONTROL_BLOCK_NAMES[controlBlock.type] || controlBlock.type;
35
33
  this.addOffense(`Control flow statements like \`${controlBlockType}\` should not be used with output tags. Use \`<% ${controlBlockType} ... %>\` instead.`, openTag.location);
36
34
  }
37
- return;
38
35
  }
39
36
  }
40
37
  export class ERBNoOutputControlFlowRule extends ParserRule {
41
- name = "erb-no-output-control-flow";
38
+ static ruleName = "erb-no-output-control-flow";
42
39
  get defaultConfig() {
43
40
  return {
44
41
  enabled: true,
@@ -46,7 +43,7 @@ export class ERBNoOutputControlFlowRule extends ParserRule {
46
43
  };
47
44
  }
48
45
  check(result, context) {
49
- const visitor = new ERBNoOutputControlFlowRuleVisitor(this.name, context);
46
+ const visitor = new ERBNoOutputControlFlowRuleVisitor(this.ruleName, context);
50
47
  visitor.visit(result.value);
51
48
  return visitor.offenses;
52
49
  }