@herb-tools/linter 0.7.5 → 0.8.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +253 -13
- package/dist/herb-lint.js +26023 -3424
- package/dist/herb-lint.js.map +1 -1
- package/dist/index.cjs +5759 -1583
- package/dist/index.cjs.map +1 -1
- package/dist/index.js +5727 -1584
- package/dist/index.js.map +1 -1
- package/dist/loader.cjs +17010 -0
- package/dist/loader.cjs.map +1 -0
- package/dist/loader.js +16879 -0
- package/dist/loader.js.map +1 -0
- package/dist/package.json +13 -5
- package/dist/src/cli/argument-parser.js +38 -33
- package/dist/src/cli/argument-parser.js.map +1 -1
- package/dist/src/cli/file-processor.js +124 -23
- package/dist/src/cli/file-processor.js.map +1 -1
- package/dist/src/cli/formatters/detailed-formatter.js +18 -3
- package/dist/src/cli/formatters/detailed-formatter.js.map +1 -1
- package/dist/src/cli/formatters/github-actions-formatter.js +15 -1
- package/dist/src/cli/formatters/github-actions-formatter.js.map +1 -1
- package/dist/src/cli/formatters/json-formatter.js +3 -0
- package/dist/src/cli/formatters/json-formatter.js.map +1 -1
- package/dist/src/cli/formatters/simple-formatter.js +20 -7
- package/dist/src/cli/formatters/simple-formatter.js.map +1 -1
- package/dist/src/cli/output-manager.js +22 -3
- package/dist/src/cli/output-manager.js.map +1 -1
- package/dist/src/cli/summary-reporter.js +26 -3
- package/dist/src/cli/summary-reporter.js.map +1 -1
- package/dist/src/cli.js +107 -42
- package/dist/src/cli.js.map +1 -1
- package/dist/src/custom-rule-loader.js +139 -0
- package/dist/src/custom-rule-loader.js.map +1 -0
- package/dist/src/herb-disable-comment-utils.js +129 -0
- package/dist/src/herb-disable-comment-utils.js.map +1 -0
- package/dist/src/index.js +1 -0
- package/dist/src/index.js.map +1 -1
- package/dist/src/linter.js +369 -34
- package/dist/src/linter.js.map +1 -1
- package/dist/src/loader.js +17 -0
- package/dist/src/loader.js.map +1 -0
- package/dist/src/rules/erb-comment-syntax.js +31 -2
- package/dist/src/rules/erb-comment-syntax.js.map +1 -1
- package/dist/src/rules/erb-no-case-node-children.js +52 -0
- package/dist/src/rules/erb-no-case-node-children.js.map +1 -0
- package/dist/src/rules/erb-no-empty-tags.js +7 -1
- package/dist/src/rules/erb-no-empty-tags.js.map +1 -1
- package/dist/src/rules/erb-no-extra-newline.js +65 -0
- package/dist/src/rules/erb-no-extra-newline.js.map +1 -0
- package/dist/src/rules/erb-no-extra-whitespace-inside-tags.js +95 -0
- package/dist/src/rules/erb-no-extra-whitespace-inside-tags.js.map +1 -0
- package/dist/src/rules/erb-no-output-control-flow.js +7 -1
- package/dist/src/rules/erb-no-output-control-flow.js.map +1 -1
- package/dist/src/rules/erb-no-silent-tag-in-attribute-name.js +7 -1
- package/dist/src/rules/erb-no-silent-tag-in-attribute-name.js.map +1 -1
- package/dist/src/rules/erb-prefer-image-tag-helper.js +7 -1
- package/dist/src/rules/erb-prefer-image-tag-helper.js.map +1 -1
- package/dist/src/rules/erb-require-trailing-newline.js +35 -0
- package/dist/src/rules/erb-require-trailing-newline.js.map +1 -0
- package/dist/src/rules/erb-require-whitespace-inside-tags.js +69 -11
- package/dist/src/rules/erb-require-whitespace-inside-tags.js.map +1 -1
- package/dist/src/rules/erb-right-trim.js +26 -9
- package/dist/src/rules/erb-right-trim.js.map +1 -1
- package/dist/src/rules/herb-disable-comment-base.js +51 -0
- package/dist/src/rules/herb-disable-comment-base.js.map +1 -0
- package/dist/src/rules/herb-disable-comment-malformed.js +51 -0
- package/dist/src/rules/herb-disable-comment-malformed.js.map +1 -0
- package/dist/src/rules/herb-disable-comment-missing-rules.js +29 -0
- package/dist/src/rules/herb-disable-comment-missing-rules.js.map +1 -0
- package/dist/src/rules/herb-disable-comment-no-duplicate-rules.js +32 -0
- package/dist/src/rules/herb-disable-comment-no-duplicate-rules.js.map +1 -0
- package/dist/src/rules/herb-disable-comment-no-redundant-all.js +31 -0
- package/dist/src/rules/herb-disable-comment-no-redundant-all.js.map +1 -0
- package/dist/src/rules/herb-disable-comment-unnecessary.js +65 -0
- package/dist/src/rules/herb-disable-comment-unnecessary.js.map +1 -0
- package/dist/src/rules/herb-disable-comment-valid-rule-name.js +44 -0
- package/dist/src/rules/herb-disable-comment-valid-rule-name.js.map +1 -0
- package/dist/src/rules/html-anchor-require-href.js +7 -1
- package/dist/src/rules/html-anchor-require-href.js.map +1 -1
- package/dist/src/rules/html-aria-attribute-must-be-valid.js +7 -1
- package/dist/src/rules/html-aria-attribute-must-be-valid.js.map +1 -1
- package/dist/src/rules/html-aria-label-is-well-formatted.js +9 -3
- package/dist/src/rules/html-aria-label-is-well-formatted.js.map +1 -1
- package/dist/src/rules/html-aria-level-must-be-valid.js +6 -0
- package/dist/src/rules/html-aria-level-must-be-valid.js.map +1 -1
- package/dist/src/rules/html-aria-role-heading-requires-level.js +7 -1
- package/dist/src/rules/html-aria-role-heading-requires-level.js.map +1 -1
- package/dist/src/rules/html-aria-role-must-be-valid.js +7 -1
- package/dist/src/rules/html-aria-role-must-be-valid.js.map +1 -1
- package/dist/src/rules/html-attribute-double-quotes.js +29 -2
- package/dist/src/rules/html-attribute-double-quotes.js.map +1 -1
- package/dist/src/rules/html-attribute-equals-spacing.js +18 -2
- package/dist/src/rules/html-attribute-equals-spacing.js.map +1 -1
- package/dist/src/rules/html-attribute-values-require-quotes.js +39 -3
- package/dist/src/rules/html-attribute-values-require-quotes.js.map +1 -1
- package/dist/src/rules/html-avoid-both-disabled-and-aria-disabled.js +7 -1
- package/dist/src/rules/html-avoid-both-disabled-and-aria-disabled.js.map +1 -1
- package/dist/src/rules/html-body-only-elements.js +46 -0
- package/dist/src/rules/html-body-only-elements.js.map +1 -0
- package/dist/src/rules/html-boolean-attributes-no-value.js +18 -1
- package/dist/src/rules/html-boolean-attributes-no-value.js.map +1 -1
- package/dist/src/rules/html-head-only-elements.js +51 -0
- package/dist/src/rules/html-head-only-elements.js.map +1 -0
- package/dist/src/rules/html-iframe-has-title.js +8 -2
- package/dist/src/rules/html-iframe-has-title.js.map +1 -1
- package/dist/src/rules/html-img-require-alt.js +7 -1
- package/dist/src/rules/html-img-require-alt.js.map +1 -1
- package/dist/src/rules/html-input-require-autocomplete.js +70 -0
- package/dist/src/rules/html-input-require-autocomplete.js.map +1 -0
- package/dist/src/rules/html-navigation-has-label.js +7 -1
- package/dist/src/rules/html-navigation-has-label.js.map +1 -1
- package/dist/src/rules/html-no-aria-hidden-on-focusable.js +7 -1
- package/dist/src/rules/html-no-aria-hidden-on-focusable.js.map +1 -1
- package/dist/src/rules/html-no-block-inside-inline.js +7 -1
- package/dist/src/rules/html-no-block-inside-inline.js.map +1 -1
- package/dist/src/rules/html-no-duplicate-attributes.js +7 -1
- package/dist/src/rules/html-no-duplicate-attributes.js.map +1 -1
- package/dist/src/rules/html-no-duplicate-ids.js +9 -3
- package/dist/src/rules/html-no-duplicate-ids.js.map +1 -1
- package/dist/src/rules/html-no-duplicate-meta-names.js +136 -0
- package/dist/src/rules/html-no-duplicate-meta-names.js.map +1 -0
- package/dist/src/rules/html-no-empty-attributes.js +45 -7
- package/dist/src/rules/html-no-empty-attributes.js.map +1 -1
- package/dist/src/rules/html-no-empty-headings.js +7 -6
- package/dist/src/rules/html-no-empty-headings.js.map +1 -1
- package/dist/src/rules/html-no-nested-links.js +7 -1
- package/dist/src/rules/html-no-nested-links.js.map +1 -1
- package/dist/src/rules/html-no-positive-tab-index.js +7 -1
- package/dist/src/rules/html-no-positive-tab-index.js.map +1 -1
- package/dist/src/rules/html-no-self-closing.js +48 -3
- package/dist/src/rules/html-no-self-closing.js.map +1 -1
- package/dist/src/rules/html-no-space-in-tag.js +173 -0
- package/dist/src/rules/html-no-space-in-tag.js.map +1 -0
- package/dist/src/rules/html-no-title-attribute.js +7 -1
- package/dist/src/rules/html-no-title-attribute.js.map +1 -1
- package/dist/src/rules/html-no-underscores-in-attribute-names.js +7 -1
- package/dist/src/rules/html-no-underscores-in-attribute-names.js.map +1 -1
- package/dist/src/rules/html-tag-name-lowercase.js +23 -5
- package/dist/src/rules/html-tag-name-lowercase.js.map +1 -1
- package/dist/src/rules/index.js +19 -3
- package/dist/src/rules/index.js.map +1 -1
- package/dist/src/rules/parser-no-errors.js +6 -0
- package/dist/src/rules/parser-no-errors.js.map +1 -1
- package/dist/src/rules/rule-utils.js +211 -31
- package/dist/src/rules/rule-utils.js.map +1 -1
- package/dist/src/rules/svg-tag-name-capitalization.js +22 -2
- package/dist/src/rules/svg-tag-name-capitalization.js.map +1 -1
- package/dist/src/{default-rules.js → rules.js} +44 -16
- package/dist/src/rules.js.map +1 -0
- package/dist/src/types.js +34 -1
- package/dist/src/types.js.map +1 -1
- package/dist/tsconfig.tsbuildinfo +1 -1
- package/dist/types/cli/argument-parser.d.ts +8 -2
- package/dist/types/cli/file-processor.d.ts +15 -0
- package/dist/types/cli/formatters/json-formatter.d.ts +6 -0
- package/dist/types/cli/formatters/simple-formatter.d.ts +1 -0
- package/dist/types/cli/summary-reporter.d.ts +6 -0
- package/dist/types/cli.d.ts +9 -4
- package/dist/types/custom-rule-loader.d.ts +62 -0
- package/dist/types/herb-disable-comment-utils.d.ts +69 -0
- package/dist/types/index.d.ts +1 -0
- package/dist/types/linter.d.ts +99 -3
- package/dist/types/loader.d.ts +20 -0
- package/dist/types/rules/erb-comment-syntax.d.ts +12 -5
- package/dist/types/rules/erb-no-case-node-children.d.ts +8 -0
- package/dist/types/rules/erb-no-empty-tags.d.ts +3 -2
- package/dist/types/rules/erb-no-extra-newline.d.ts +14 -0
- package/dist/types/rules/erb-no-extra-whitespace-inside-tags.d.ts +18 -0
- package/dist/types/rules/erb-no-output-control-flow.d.ts +3 -2
- package/dist/types/rules/erb-no-silent-tag-in-attribute-name.d.ts +3 -2
- package/dist/types/rules/erb-prefer-image-tag-helper.d.ts +3 -2
- package/dist/types/rules/erb-require-trailing-newline.d.ts +9 -0
- package/dist/types/rules/erb-require-whitespace-inside-tags.d.ts +16 -5
- package/dist/types/rules/erb-right-trim.d.ts +12 -5
- package/dist/types/rules/herb-disable-comment-base.d.ts +37 -0
- package/dist/types/rules/herb-disable-comment-malformed.d.ts +8 -0
- package/dist/types/rules/herb-disable-comment-missing-rules.d.ts +8 -0
- package/dist/types/rules/herb-disable-comment-no-duplicate-rules.d.ts +8 -0
- package/dist/types/rules/herb-disable-comment-no-redundant-all.d.ts +8 -0
- package/dist/types/rules/herb-disable-comment-unnecessary.d.ts +8 -0
- package/dist/types/rules/herb-disable-comment-valid-rule-name.d.ts +8 -0
- package/dist/types/rules/html-anchor-require-href.d.ts +3 -2
- package/dist/types/rules/html-aria-attribute-must-be-valid.d.ts +3 -2
- package/dist/types/rules/html-aria-label-is-well-formatted.d.ts +3 -2
- package/dist/types/rules/html-aria-level-must-be-valid.d.ts +3 -2
- package/dist/types/rules/html-aria-role-heading-requires-level.d.ts +3 -2
- package/dist/types/rules/html-aria-role-must-be-valid.d.ts +3 -2
- package/dist/types/rules/html-attribute-double-quotes.d.ts +13 -5
- package/dist/types/rules/html-attribute-equals-spacing.d.ts +12 -5
- package/dist/types/rules/html-attribute-values-require-quotes.d.ts +13 -5
- package/dist/types/rules/html-avoid-both-disabled-and-aria-disabled.d.ts +3 -2
- package/dist/types/rules/html-body-only-elements.d.ts +9 -0
- package/dist/types/rules/html-boolean-attributes-no-value.d.ts +12 -5
- package/dist/types/rules/html-head-only-elements.d.ts +9 -0
- package/dist/types/rules/html-iframe-has-title.d.ts +3 -2
- package/dist/types/rules/html-img-require-alt.d.ts +3 -2
- package/dist/types/rules/html-input-require-autocomplete.d.ts +8 -0
- package/dist/types/rules/html-navigation-has-label.d.ts +3 -2
- package/dist/types/rules/html-no-aria-hidden-on-focusable.d.ts +3 -2
- package/dist/types/rules/html-no-block-inside-inline.d.ts +3 -2
- package/dist/types/rules/html-no-duplicate-attributes.d.ts +3 -2
- package/dist/types/rules/html-no-duplicate-ids.d.ts +3 -2
- package/dist/types/rules/html-no-duplicate-meta-names.d.ts +9 -0
- package/dist/types/rules/html-no-empty-attributes.d.ts +3 -2
- package/dist/types/rules/html-no-empty-headings.d.ts +3 -2
- package/dist/types/rules/html-no-nested-links.d.ts +3 -2
- package/dist/types/rules/html-no-positive-tab-index.d.ts +3 -2
- package/dist/types/rules/html-no-self-closing.d.ts +14 -5
- package/dist/types/rules/html-no-space-in-tag.d.ts +16 -0
- package/dist/types/rules/html-no-title-attribute.d.ts +3 -2
- package/dist/types/rules/html-no-underscores-in-attribute-names.d.ts +3 -2
- package/dist/types/rules/html-tag-name-lowercase.d.ts +16 -6
- package/dist/types/rules/index.d.ts +19 -3
- package/dist/types/rules/parser-no-errors.d.ts +2 -1
- package/dist/types/rules/rule-utils.d.ts +72 -25
- package/dist/types/rules/svg-tag-name-capitalization.d.ts +13 -4
- package/dist/types/rules.d.ts +2 -0
- package/dist/types/src/cli/argument-parser.d.ts +8 -2
- package/dist/types/src/cli/file-processor.d.ts +15 -0
- package/dist/types/src/cli/formatters/json-formatter.d.ts +6 -0
- package/dist/types/src/cli/formatters/simple-formatter.d.ts +1 -0
- package/dist/types/src/cli/summary-reporter.d.ts +6 -0
- package/dist/types/src/cli.d.ts +9 -4
- package/dist/types/src/custom-rule-loader.d.ts +62 -0
- package/dist/types/src/herb-disable-comment-utils.d.ts +69 -0
- package/dist/types/src/index.d.ts +1 -0
- package/dist/types/src/linter.d.ts +99 -3
- package/dist/types/src/loader.d.ts +20 -0
- package/dist/types/src/rules/erb-comment-syntax.d.ts +12 -5
- package/dist/types/src/rules/erb-no-case-node-children.d.ts +8 -0
- package/dist/types/src/rules/erb-no-empty-tags.d.ts +3 -2
- package/dist/types/src/rules/erb-no-extra-newline.d.ts +14 -0
- package/dist/types/src/rules/erb-no-extra-whitespace-inside-tags.d.ts +18 -0
- package/dist/types/src/rules/erb-no-output-control-flow.d.ts +3 -2
- package/dist/types/src/rules/erb-no-silent-tag-in-attribute-name.d.ts +3 -2
- package/dist/types/src/rules/erb-prefer-image-tag-helper.d.ts +3 -2
- package/dist/types/src/rules/erb-require-trailing-newline.d.ts +9 -0
- package/dist/types/src/rules/erb-require-whitespace-inside-tags.d.ts +16 -5
- package/dist/types/src/rules/erb-right-trim.d.ts +12 -5
- package/dist/types/src/rules/herb-disable-comment-base.d.ts +37 -0
- package/dist/types/src/rules/herb-disable-comment-malformed.d.ts +8 -0
- package/dist/types/src/rules/herb-disable-comment-missing-rules.d.ts +8 -0
- package/dist/types/src/rules/herb-disable-comment-no-duplicate-rules.d.ts +8 -0
- package/dist/types/src/rules/herb-disable-comment-no-redundant-all.d.ts +8 -0
- package/dist/types/src/rules/herb-disable-comment-unnecessary.d.ts +8 -0
- package/dist/types/src/rules/herb-disable-comment-valid-rule-name.d.ts +8 -0
- package/dist/types/src/rules/html-anchor-require-href.d.ts +3 -2
- package/dist/types/src/rules/html-aria-attribute-must-be-valid.d.ts +3 -2
- package/dist/types/src/rules/html-aria-label-is-well-formatted.d.ts +3 -2
- package/dist/types/src/rules/html-aria-level-must-be-valid.d.ts +3 -2
- package/dist/types/src/rules/html-aria-role-heading-requires-level.d.ts +3 -2
- package/dist/types/src/rules/html-aria-role-must-be-valid.d.ts +3 -2
- package/dist/types/src/rules/html-attribute-double-quotes.d.ts +13 -5
- package/dist/types/src/rules/html-attribute-equals-spacing.d.ts +12 -5
- package/dist/types/src/rules/html-attribute-values-require-quotes.d.ts +13 -5
- package/dist/types/src/rules/html-avoid-both-disabled-and-aria-disabled.d.ts +3 -2
- package/dist/types/src/rules/html-body-only-elements.d.ts +9 -0
- package/dist/types/src/rules/html-boolean-attributes-no-value.d.ts +12 -5
- package/dist/types/src/rules/html-head-only-elements.d.ts +9 -0
- package/dist/types/src/rules/html-iframe-has-title.d.ts +3 -2
- package/dist/types/src/rules/html-img-require-alt.d.ts +3 -2
- package/dist/types/src/rules/html-input-require-autocomplete.d.ts +8 -0
- package/dist/types/src/rules/html-navigation-has-label.d.ts +3 -2
- package/dist/types/src/rules/html-no-aria-hidden-on-focusable.d.ts +3 -2
- package/dist/types/src/rules/html-no-block-inside-inline.d.ts +3 -2
- package/dist/types/src/rules/html-no-duplicate-attributes.d.ts +3 -2
- package/dist/types/src/rules/html-no-duplicate-ids.d.ts +3 -2
- package/dist/types/src/rules/html-no-duplicate-meta-names.d.ts +9 -0
- package/dist/types/src/rules/html-no-empty-attributes.d.ts +3 -2
- package/dist/types/src/rules/html-no-empty-headings.d.ts +3 -2
- package/dist/types/src/rules/html-no-nested-links.d.ts +3 -2
- package/dist/types/src/rules/html-no-positive-tab-index.d.ts +3 -2
- package/dist/types/src/rules/html-no-self-closing.d.ts +14 -5
- package/dist/types/src/rules/html-no-space-in-tag.d.ts +16 -0
- package/dist/types/src/rules/html-no-title-attribute.d.ts +3 -2
- package/dist/types/src/rules/html-no-underscores-in-attribute-names.d.ts +3 -2
- package/dist/types/src/rules/html-tag-name-lowercase.d.ts +16 -6
- package/dist/types/src/rules/index.d.ts +19 -3
- package/dist/types/src/rules/parser-no-errors.d.ts +2 -1
- package/dist/types/src/rules/rule-utils.d.ts +72 -25
- package/dist/types/src/rules/svg-tag-name-capitalization.d.ts +13 -4
- package/dist/types/src/rules.d.ts +2 -0
- package/dist/types/src/types.d.ts +102 -11
- package/dist/types/types.d.ts +102 -11
- package/docs/rules/README.md +16 -2
- package/docs/rules/erb-no-case-node-children.md +50 -0
- package/docs/rules/erb-no-extra-newline.md +74 -0
- package/docs/rules/erb-no-extra-whitespace-inside-tags.md +39 -0
- package/docs/rules/{erb-requires-trailing-newline.md → erb-require-trailing-newline.md} +1 -1
- package/docs/rules/erb-right-trim.md +5 -10
- package/docs/rules/herb-disable-comment-malformed.md +45 -0
- package/docs/rules/herb-disable-comment-missing-rules.md +60 -0
- package/docs/rules/herb-disable-comment-no-duplicate-rules.md +49 -0
- package/docs/rules/herb-disable-comment-no-redundant-all.md +53 -0
- package/docs/rules/herb-disable-comment-unnecessary.md +44 -0
- package/docs/rules/herb-disable-comment-valid-rule-name.md +41 -0
- package/docs/rules/html-aria-attribute-must-be-valid.md +2 -5
- package/docs/rules/html-aria-label-is-well-formatted.md +1 -1
- package/docs/rules/html-attribute-double-quotes.md +2 -2
- package/docs/rules/html-attribute-equals-spacing.md +2 -2
- package/docs/rules/html-attribute-values-require-quotes.md +3 -3
- package/docs/rules/html-avoid-both-disabled-and-aria-disabled.md +2 -2
- package/docs/rules/html-body-only-elements.md +99 -0
- package/docs/rules/html-boolean-attributes-no-value.md +2 -2
- package/docs/rules/html-head-only-elements.md +81 -0
- package/docs/rules/html-input-require-autocomplete.md +64 -0
- package/docs/rules/html-no-aria-hidden-on-focusable.md +2 -2
- package/docs/rules/html-no-duplicate-attributes.md +2 -2
- package/docs/rules/html-no-duplicate-meta-names.md +64 -0
- package/docs/rules/html-no-empty-attributes.md +3 -3
- package/docs/rules/html-no-empty-headings.md +4 -26
- package/docs/rules/html-no-positive-tab-index.md +1 -2
- package/docs/rules/html-no-self-closing.md +17 -2
- package/docs/rules/html-no-space-in-tag.md +66 -0
- package/docs/rules/html-no-title-attribute.md +2 -2
- package/docs/rules/html-no-underscores-in-attribute-names.md +2 -2
- package/docs/rules/html-tag-name-lowercase.md +2 -2
- package/package.json +13 -5
- package/src/cli/argument-parser.ts +46 -37
- package/src/cli/file-processor.ts +159 -28
- package/src/cli/formatters/detailed-formatter.ts +21 -3
- package/src/cli/formatters/github-actions-formatter.ts +17 -1
- package/src/cli/formatters/json-formatter.ts +9 -0
- package/src/cli/formatters/simple-formatter.ts +24 -8
- package/src/cli/output-manager.ts +23 -3
- package/src/cli/summary-reporter.ts +40 -3
- package/src/cli.ts +134 -51
- package/src/custom-rule-loader.ts +189 -0
- package/src/herb-disable-comment-utils.ts +175 -0
- package/src/index.ts +2 -0
- package/src/linter.ts +501 -36
- package/src/loader.ts +30 -0
- package/src/rules/erb-comment-syntax.ts +53 -10
- package/src/rules/erb-no-case-node-children.ts +68 -0
- package/src/rules/erb-no-empty-tags.ts +9 -3
- package/src/rules/erb-no-extra-newline.ts +91 -0
- package/src/rules/erb-no-extra-whitespace-inside-tags.ts +147 -0
- package/src/rules/erb-no-output-control-flow.ts +9 -3
- package/src/rules/erb-no-silent-tag-in-attribute-name.ts +9 -3
- package/src/rules/erb-prefer-image-tag-helper.ts +9 -3
- package/src/rules/erb-require-trailing-newline.ts +47 -0
- package/src/rules/erb-require-whitespace-inside-tags.ts +94 -16
- package/src/rules/erb-right-trim.ts +45 -22
- package/src/rules/herb-disable-comment-base.ts +76 -0
- package/src/rules/herb-disable-comment-malformed.ts +66 -0
- package/src/rules/herb-disable-comment-missing-rules.ts +41 -0
- package/src/rules/herb-disable-comment-no-duplicate-rules.ts +46 -0
- package/src/rules/herb-disable-comment-no-redundant-all.ts +40 -0
- package/src/rules/herb-disable-comment-unnecessary.ts +103 -0
- package/src/rules/herb-disable-comment-valid-rule-name.ts +62 -0
- package/src/rules/html-anchor-require-href.ts +9 -3
- package/src/rules/html-aria-attribute-must-be-valid.ts +9 -3
- package/src/rules/html-aria-label-is-well-formatted.ts +9 -5
- package/src/rules/html-aria-level-must-be-valid.ts +9 -2
- package/src/rules/html-aria-role-heading-requires-level.ts +9 -3
- package/src/rules/html-aria-role-must-be-valid.ts +9 -3
- package/src/rules/html-attribute-double-quotes.ts +42 -8
- package/src/rules/html-attribute-equals-spacing.ts +31 -7
- package/src/rules/html-attribute-values-require-quotes.ts +56 -10
- package/src/rules/html-avoid-both-disabled-and-aria-disabled.ts +9 -3
- package/src/rules/html-body-only-elements.ts +60 -0
- package/src/rules/html-boolean-attributes-no-value.ts +31 -6
- package/src/rules/html-head-only-elements.ts +65 -0
- package/src/rules/html-iframe-has-title.ts +9 -4
- package/src/rules/html-img-require-alt.ts +10 -4
- package/src/rules/html-input-require-autocomplete.ts +85 -0
- package/src/rules/html-navigation-has-label.ts +9 -3
- package/src/rules/html-no-aria-hidden-on-focusable.ts +9 -3
- package/src/rules/html-no-block-inside-inline.ts +9 -3
- package/src/rules/html-no-duplicate-attributes.ts +9 -3
- package/src/rules/html-no-duplicate-ids.ts +11 -7
- package/src/rules/html-no-duplicate-meta-names.ts +188 -0
- package/src/rules/html-no-empty-attributes.ts +58 -10
- package/src/rules/html-no-empty-headings.ts +10 -8
- package/src/rules/html-no-nested-links.ts +10 -4
- package/src/rules/html-no-positive-tab-index.ts +9 -3
- package/src/rules/html-no-self-closing.ts +69 -9
- package/src/rules/html-no-space-in-tag.ts +221 -0
- package/src/rules/html-no-title-attribute.ts +9 -3
- package/src/rules/html-no-underscores-in-attribute-names.ts +12 -4
- package/src/rules/html-tag-name-lowercase.ts +41 -10
- package/src/rules/index.ts +23 -3
- package/src/rules/parser-no-errors.ts +8 -1
- package/src/rules/rule-utils.ts +248 -42
- package/src/rules/svg-tag-name-capitalization.ts +39 -6
- package/src/{default-rules.ts → rules.ts} +51 -15
- package/src/types.ts +133 -15
- package/dist/src/default-rules.js.map +0 -1
- package/dist/src/rules/erb-requires-trailing-newline.js +0 -22
- package/dist/src/rules/erb-requires-trailing-newline.js.map +0 -1
- package/dist/types/default-rules.d.ts +0 -2
- package/dist/types/rules/erb-requires-trailing-newline.d.ts +0 -6
- package/dist/types/src/default-rules.d.ts +0 -2
- package/dist/types/src/rules/erb-requires-trailing-newline.d.ts +0 -6
- package/src/rules/erb-requires-trailing-newline.ts +0 -29
|
@@ -0,0 +1,65 @@
|
|
|
1
|
+
import { BaseSourceRuleVisitor } from "./rule-utils.js";
|
|
2
|
+
import { SourceRule } from "../types.js";
|
|
3
|
+
import { Location, Position } from "@herb-tools/core";
|
|
4
|
+
function positionFromOffset(source, offset) {
|
|
5
|
+
let line = 1;
|
|
6
|
+
let column = 0;
|
|
7
|
+
let currentOffset = 0;
|
|
8
|
+
for (let i = 0; i < source.length && currentOffset < offset; i++) {
|
|
9
|
+
const char = source[i];
|
|
10
|
+
currentOffset++;
|
|
11
|
+
if (char === "\n") {
|
|
12
|
+
line++;
|
|
13
|
+
column = 0;
|
|
14
|
+
}
|
|
15
|
+
else {
|
|
16
|
+
column++;
|
|
17
|
+
}
|
|
18
|
+
}
|
|
19
|
+
return new Position(line, column);
|
|
20
|
+
}
|
|
21
|
+
class ERBNoExtraNewLineVisitor extends BaseSourceRuleVisitor {
|
|
22
|
+
visitSource(source) {
|
|
23
|
+
if (source.length === 0)
|
|
24
|
+
return;
|
|
25
|
+
const regex = /\n{4,}/g;
|
|
26
|
+
let match;
|
|
27
|
+
while ((match = regex.exec(source)) !== null) {
|
|
28
|
+
const startOffset = match.index + 3;
|
|
29
|
+
const endOffset = match.index + match[0].length;
|
|
30
|
+
const start = positionFromOffset(source, startOffset);
|
|
31
|
+
const end = positionFromOffset(source, endOffset);
|
|
32
|
+
const location = new Location(start, end);
|
|
33
|
+
const extraLines = match[0].length - 3;
|
|
34
|
+
this.addOffense(`Extra blank line detected. Remove ${extraLines} blank ${extraLines === 1 ? "line" : "lines"} to maintain consistent spacing (max 2 allowed).`, location, {
|
|
35
|
+
node: null,
|
|
36
|
+
startOffset,
|
|
37
|
+
endOffset
|
|
38
|
+
});
|
|
39
|
+
}
|
|
40
|
+
}
|
|
41
|
+
}
|
|
42
|
+
export class ERBNoExtraNewLineRule extends SourceRule {
|
|
43
|
+
static autocorrectable = true;
|
|
44
|
+
name = "erb-no-extra-newline";
|
|
45
|
+
get defaultConfig() {
|
|
46
|
+
return {
|
|
47
|
+
enabled: true,
|
|
48
|
+
severity: "error"
|
|
49
|
+
};
|
|
50
|
+
}
|
|
51
|
+
check(source, context) {
|
|
52
|
+
const visitor = new ERBNoExtraNewLineVisitor(this.name, context);
|
|
53
|
+
visitor.visit(source);
|
|
54
|
+
return visitor.offenses;
|
|
55
|
+
}
|
|
56
|
+
autofix(offense, source, _context) {
|
|
57
|
+
if (!offense.autofixContext)
|
|
58
|
+
return null;
|
|
59
|
+
const { startOffset, endOffset } = offense.autofixContext;
|
|
60
|
+
const before = source.substring(0, startOffset);
|
|
61
|
+
const after = source.substring(endOffset);
|
|
62
|
+
return before + after;
|
|
63
|
+
}
|
|
64
|
+
}
|
|
65
|
+
//# sourceMappingURL=erb-no-extra-newline.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"erb-no-extra-newline.js","sourceRoot":"","sources":["../../../src/rules/erb-no-extra-newline.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,qBAAqB,EAAE,MAAM,iBAAiB,CAAA;AACvD,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,QAAQ,EAAE,QAAQ,EAAE,MAAM,kBAAkB,CAAA;AAUrD,SAAS,kBAAkB,CAAC,MAAc,EAAE,MAAc;IACxD,IAAI,IAAI,GAAG,CAAC,CAAA;IACZ,IAAI,MAAM,GAAG,CAAC,CAAA;IACd,IAAI,aAAa,GAAG,CAAC,CAAA;IAErB,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,MAAM,CAAC,MAAM,IAAI,aAAa,GAAG,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;QACjE,MAAM,IAAI,GAAG,MAAM,CAAC,CAAC,CAAC,CAAA;QACtB,aAAa,EAAE,CAAA;QACf,IAAI,IAAI,KAAK,IAAI,EAAE,CAAC;YAClB,IAAI,EAAE,CAAA;YACN,MAAM,GAAG,CAAC,CAAA;QACZ,CAAC;aAAM,CAAC;YACN,MAAM,EAAE,CAAA;QACV,CAAC;IACH,CAAC;IAED,OAAO,IAAI,QAAQ,CAAC,IAAI,EAAE,MAAM,CAAC,CAAA;AACnC,CAAC;AAED,MAAM,wBAAyB,SAAQ,qBAAsD;IACjF,WAAW,CAAC,MAAc;QAClC,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC;YAAE,OAAM;QAE/B,MAAM,KAAK,GAAG,SAAS,CAAA;QAEvB,IAAI,KAA6B,CAAA;QAEjC,OAAO,CAAC,KAAK,GAAG,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,KAAK,IAAI,EAAE,CAAC;YAC7C,MAAM,WAAW,GAAG,KAAK,CAAC,KAAK,GAAG,CAAC,CAAA;YACnC,MAAM,SAAS,GAAG,KAAK,CAAC,KAAK,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC,MAAM,CAAA;YAC/C,MAAM,KAAK,GAAG,kBAAkB,CAAC,MAAM,EAAE,WAAW,CAAC,CAAA;YACrD,MAAM,GAAG,GAAG,kBAAkB,CAAC,MAAM,EAAE,SAAS,CAAC,CAAA;YACjD,MAAM,QAAQ,GAAG,IAAI,QAAQ,CAAC,KAAK,EAAE,GAAG,CAAC,CAAA;YAEzC,MAAM,UAAU,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC,MAAM,GAAG,CAAC,CAAA;YAEtC,IAAI,CAAC,UAAU,CACb,qCAAqC,UAAU,UAAU,UAAU,KAAK,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,OAAO,kDAAkD,EAC9I,QAAQ,EACR;gBACE,IAAI,EAAE,IAAmB;gBACzB,WAAW;gBACX,SAAS;aACV,CACF,CAAA;QACH,CAAC;IACH,CAAC;CACF;AAED,MAAM,OAAO,qBAAsB,SAAQ,UAAU;IACnD,MAAM,CAAC,eAAe,GAAG,IAAI,CAAA;IAC7B,IAAI,GAAG,sBAAsB,CAAA;IAE7B,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,OAAO;SAClB,CAAA;IACH,CAAC;IAED,KAAK,CAAC,MAAc,EAAE,OAA8B;QAClD,MAAM,OAAO,GAAG,IAAI,wBAAwB,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAEhE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,CAAA;QAErB,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;IAED,OAAO,CAAC,OAAqD,EAAE,MAAc,EAAE,QAA+B;QAC5G,IAAI,CAAC,OAAO,CAAC,cAAc;YAAE,OAAO,IAAI,CAAA;QAExC,MAAM,EAAE,WAAW,EAAE,SAAS,EAAE,GAAG,OAAO,CAAC,cAAc,CAAA;QAEzD,MAAM,MAAM,GAAG,MAAM,CAAC,SAAS,CAAC,CAAC,EAAE,WAAW,CAAC,CAAA;QAC/C,MAAM,KAAK,GAAG,MAAM,CAAC,SAAS,CAAC,SAAS,CAAC,CAAA;QAEzC,OAAO,MAAM,GAAG,KAAK,CAAA;IACvB,CAAC"}
|
|
@@ -0,0 +1,95 @@
|
|
|
1
|
+
import { ParserRule } from "../types.js";
|
|
2
|
+
import { BaseRuleVisitor } from "./rule-utils.js";
|
|
3
|
+
import { Location } from "@herb-tools/core";
|
|
4
|
+
class ERBNoExtraWhitespaceInsideTagsVisitor extends BaseRuleVisitor {
|
|
5
|
+
visitERBNode(node) {
|
|
6
|
+
const openTag = node.tag_opening;
|
|
7
|
+
const closeTag = node.tag_closing;
|
|
8
|
+
const { value } = node.content ?? {};
|
|
9
|
+
if (!openTag || !closeTag || !value)
|
|
10
|
+
return;
|
|
11
|
+
if (this.hasExtraLeadingWhitespace(value)) {
|
|
12
|
+
this.reportWhitespace(node, openTag, closeTag, value, "start", 0, `Remove extra whitespace after \`${openTag.value}\`.`, "after-open");
|
|
13
|
+
}
|
|
14
|
+
if (openTag.value === "<%#" && value.startsWith("=") && value.length > 1) {
|
|
15
|
+
const afterEquals = value.substring(1);
|
|
16
|
+
if (afterEquals.match(/^\s{2,}/) && !afterEquals.startsWith(" \n") && !afterEquals.startsWith("\n")) {
|
|
17
|
+
this.reportWhitespace(node, openTag, closeTag, value, "start", 1, `Remove extra whitespace after \`<%#=\`.`, "after-comment-equals");
|
|
18
|
+
}
|
|
19
|
+
}
|
|
20
|
+
if (this.hasExtraTrailingWhitespace(value)) {
|
|
21
|
+
this.reportWhitespace(node, openTag, closeTag, value, "end", 0, `Remove extra whitespace before \`${closeTag.value}\`.`, "before-close");
|
|
22
|
+
}
|
|
23
|
+
}
|
|
24
|
+
hasExtraLeadingWhitespace(content) {
|
|
25
|
+
return content.startsWith(" ") && !content.startsWith(" \n");
|
|
26
|
+
}
|
|
27
|
+
hasExtraTrailingWhitespace(content) {
|
|
28
|
+
return !content.includes("\n") && /\s{2,}$/.test(content);
|
|
29
|
+
}
|
|
30
|
+
getWhitespaceLocation(node, content, position, offset = 0) {
|
|
31
|
+
const contentLocation = node.content.location;
|
|
32
|
+
if (position === "start") {
|
|
33
|
+
const match = content.substring(offset).match(/^\s+/);
|
|
34
|
+
const length = match ? match[0].length : 0;
|
|
35
|
+
const startColumn = contentLocation.start.column + offset;
|
|
36
|
+
return Location.from(contentLocation.start.line, startColumn, contentLocation.start.line, startColumn + length);
|
|
37
|
+
}
|
|
38
|
+
else {
|
|
39
|
+
const match = content.match(/\s+$/);
|
|
40
|
+
const length = match ? match[0].length : 0;
|
|
41
|
+
return Location.from(contentLocation.end.line, contentLocation.end.column - length, contentLocation.end.line, contentLocation.end.column);
|
|
42
|
+
}
|
|
43
|
+
}
|
|
44
|
+
reportWhitespace(node, openTag, closeTag, content, position, offset, message, fixType) {
|
|
45
|
+
const location = this.getWhitespaceLocation(node, content, position, offset);
|
|
46
|
+
this.addOffense(message, location, {
|
|
47
|
+
node,
|
|
48
|
+
openTag,
|
|
49
|
+
closeTag,
|
|
50
|
+
content,
|
|
51
|
+
fixType
|
|
52
|
+
});
|
|
53
|
+
}
|
|
54
|
+
}
|
|
55
|
+
export class ERBNoExtraWhitespaceRule extends ParserRule {
|
|
56
|
+
static autocorrectable = true;
|
|
57
|
+
name = "erb-no-extra-whitespace-inside-tags";
|
|
58
|
+
get defaultConfig() {
|
|
59
|
+
return {
|
|
60
|
+
enabled: true,
|
|
61
|
+
severity: "error"
|
|
62
|
+
};
|
|
63
|
+
}
|
|
64
|
+
check(result, context) {
|
|
65
|
+
const visitor = new ERBNoExtraWhitespaceInsideTagsVisitor(this.name, context);
|
|
66
|
+
visitor.visit(result.value);
|
|
67
|
+
return visitor.offenses;
|
|
68
|
+
}
|
|
69
|
+
autofix(offense, result, _context) {
|
|
70
|
+
if (!offense.autofixContext)
|
|
71
|
+
return null;
|
|
72
|
+
const { node, fixType } = offense.autofixContext;
|
|
73
|
+
if (!node.content)
|
|
74
|
+
return null;
|
|
75
|
+
const content = node.content.value;
|
|
76
|
+
switch (fixType) {
|
|
77
|
+
case "before-close":
|
|
78
|
+
node.content.value = content.replace(/\s{2,}$/, " ");
|
|
79
|
+
break;
|
|
80
|
+
case "after-open":
|
|
81
|
+
node.content.value = content.replace(/^\s{2,}/, " ");
|
|
82
|
+
break;
|
|
83
|
+
case "after-comment-equals":
|
|
84
|
+
if (content.startsWith("=")) {
|
|
85
|
+
const afterEquals = content.substring(1);
|
|
86
|
+
node.content.value = "= " + afterEquals.replace(/^\s{2,}/, "");
|
|
87
|
+
}
|
|
88
|
+
break;
|
|
89
|
+
default:
|
|
90
|
+
return null;
|
|
91
|
+
}
|
|
92
|
+
return result;
|
|
93
|
+
}
|
|
94
|
+
}
|
|
95
|
+
//# sourceMappingURL=erb-no-extra-whitespace-inside-tags.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"erb-no-extra-whitespace-inside-tags.js","sourceRoot":"","sources":["../../../src/rules/erb-no-extra-whitespace-inside-tags.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAA+B,MAAM,aAAa,CAAA;AACrE,OAAO,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAA;AAGjD,OAAO,EAAE,QAAQ,EAAE,MAAM,kBAAkB,CAAA;AAW3C,MAAM,qCAAsC,SAAQ,eAAmD;IAErG,YAAY,CAAC,IAAa;QACxB,MAAM,OAAO,GAAG,IAAI,CAAC,WAAW,CAAA;QAChC,MAAM,QAAQ,GAAG,IAAI,CAAC,WAAW,CAAA;QACjC,MAAM,EAAE,KAAK,EAAE,GAAG,IAAI,CAAC,OAAO,IAAI,EAAE,CAAA;QAEpC,IAAI,CAAC,OAAO,IAAI,CAAC,QAAQ,IAAI,CAAC,KAAK;YAAE,OAAM;QAE3C,IAAI,IAAI,CAAC,yBAAyB,CAAC,KAAK,CAAC,EAAE,CAAC;YAC1C,IAAI,CAAC,gBAAgB,CAAC,IAAI,EAAE,OAAO,EAAE,QAAQ,EAAE,KAAK,EAAE,OAAO,EAAE,CAAC,EAAE,mCAAmC,OAAO,CAAC,KAAK,KAAK,EAAE,YAAY,CAAC,CAAA;QACxI,CAAC;QAED,IAAI,OAAO,CAAC,KAAK,KAAK,KAAK,IAAI,KAAK,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,KAAK,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACzE,MAAM,WAAW,GAAG,KAAK,CAAC,SAAS,CAAC,CAAC,CAAC,CAAA;YAEtC,IAAI,WAAW,CAAC,KAAK,CAAC,SAAS,CAAC,IAAI,CAAC,WAAW,CAAC,UAAU,CAAC,MAAM,CAAC,IAAI,CAAC,WAAW,CAAC,UAAU,CAAC,IAAI,CAAC,EAAE,CAAC;gBACrG,IAAI,CAAC,gBAAgB,CAAC,IAAI,EAAE,OAAO,EAAE,QAAQ,EAAE,KAAK,EAAE,OAAO,EAAE,CAAC,EAAE,yCAAyC,EAAE,sBAAsB,CAAC,CAAA;YACtI,CAAC;QACH,CAAC;QAED,IAAI,IAAI,CAAC,0BAA0B,CAAC,KAAK,CAAC,EAAE,CAAC;YAC3C,IAAI,CAAC,gBAAgB,CAAC,IAAI,EAAE,OAAO,EAAE,QAAQ,EAAE,KAAK,EAAE,KAAK,EAAE,CAAC,EAAE,oCAAoC,QAAQ,CAAC,KAAK,KAAK,EAAE,cAAc,CAAC,CAAA;QAC1I,CAAC;IACH,CAAC;IAEO,yBAAyB,CAAC,OAAe;QAC/C,OAAO,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,MAAM,CAAC,CAAA;IAChE,CAAC;IAEO,0BAA0B,CAAC,OAAe;QAChD,OAAO,CAAC,OAAO,CAAC,QAAQ,CAAC,IAAI,CAAC,IAAI,SAAS,CAAC,IAAI,CAAC,OAAO,CAAC,CAAA;IAC3D,CAAC;IAEO,qBAAqB,CAAC,IAAa,EAAE,OAAe,EAAE,QAAyB,EAAE,SAAiB,CAAC;QACzG,MAAM,eAAe,GAAG,IAAI,CAAC,OAAQ,CAAC,QAAQ,CAAA;QAE9C,IAAI,QAAQ,KAAK,OAAO,EAAE,CAAC;YACzB,MAAM,KAAK,GAAG,OAAO,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC,KAAK,CAAC,MAAM,CAAC,CAAA;YACrD,MAAM,MAAM,GAAG,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,CAAA;YAC1C,MAAM,WAAW,GAAG,eAAe,CAAC,KAAK,CAAC,MAAM,GAAG,MAAM,CAAA;YAEzD,OAAO,QAAQ,CAAC,IAAI,CAClB,eAAe,CAAC,KAAK,CAAC,IAAI,EAC1B,WAAW,EACX,eAAe,CAAC,KAAK,CAAC,IAAI,EAC1B,WAAW,GAAG,MAAM,CACrB,CAAA;QACH,CAAC;aAAM,CAAC;YACN,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,CAAA;YACnC,MAAM,MAAM,GAAG,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,CAAA;YAE1C,OAAO,QAAQ,CAAC,IAAI,CAClB,eAAe,CAAC,GAAG,CAAC,IAAI,EACxB,eAAe,CAAC,GAAG,CAAC,MAAM,GAAG,MAAM,EACnC,eAAe,CAAC,GAAG,CAAC,IAAI,EACxB,eAAe,CAAC,GAAG,CAAC,MAAM,CAC3B,CAAA;QACH,CAAC;IACH,CAAC;IAEO,gBAAgB,CACtB,IAAa,EACb,OAAc,EACd,QAAe,EACf,OAAe,EACf,QAAyB,EACzB,MAAc,EACd,OAAe,EACf,OAA+D;QAE/D,MAAM,QAAQ,GAAG,IAAI,CAAC,qBAAqB,CAAC,IAAI,EAAE,OAAO,EAAE,QAAQ,EAAE,MAAM,CAAC,CAAA;QAC5E,IAAI,CAAC,UAAU,CAAC,OAAO,EAAE,QAAQ,EAAE;YACjC,IAAI;YACJ,OAAO;YACP,QAAQ;YACR,OAAO;YACP,OAAO;SACR,CAAC,CAAA;IACJ,CAAC;CACF;AAED,MAAM,OAAO,wBAAyB,SAAQ,UAA8C;IAC1F,MAAM,CAAC,eAAe,GAAG,IAAI,CAAA;IAC7B,IAAI,GAAG,qCAAqC,CAAA;IAE5C,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,OAAO;SAClB,CAAA;IACH,CAAC;IAED,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,qCAAqC,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAE7E,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;IAED,OAAO,CAAC,OAAwD,EAAE,MAAmB,EAAE,QAA+B;QACpH,IAAI,CAAC,OAAO,CAAC,cAAc;YAAE,OAAO,IAAI,CAAA;QAExC,MAAM,EAAE,IAAI,EAAE,OAAO,EAAE,GAAG,OAAO,CAAC,cAAc,CAAA;QAChD,IAAI,CAAC,IAAI,CAAC,OAAO;YAAE,OAAO,IAAI,CAAA;QAE9B,MAAM,OAAO,GAAG,IAAI,CAAC,OAAO,CAAC,KAAK,CAAA;QAElC,QAAQ,OAAO,EAAE,CAAC;YAChB,KAAK,cAAc;gBACjB,IAAI,CAAC,OAAO,CAAC,KAAK,GAAG,OAAO,CAAC,OAAO,CAAC,SAAS,EAAE,GAAG,CAAC,CAAA;gBACpD,MAAK;YAEP,KAAK,YAAY;gBACf,IAAI,CAAC,OAAO,CAAC,KAAK,GAAG,OAAO,CAAC,OAAO,CAAC,SAAS,EAAE,GAAG,CAAC,CAAA;gBACpD,MAAK;YAEP,KAAK,sBAAsB;gBACzB,IAAI,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,EAAE,CAAC;oBAC5B,MAAM,WAAW,GAAG,OAAO,CAAC,SAAS,CAAC,CAAC,CAAC,CAAA;oBACxC,IAAI,CAAC,OAAO,CAAC,KAAK,GAAG,IAAI,GAAG,WAAW,CAAC,OAAO,CAAC,SAAS,EAAE,EAAE,CAAC,CAAA;gBAChE,CAAC;gBAED,MAAK;YACP;gBACE,OAAO,IAAI,CAAA;QACf,CAAC;QAED,OAAO,MAAM,CAAA;IACf,CAAC"}
|
|
@@ -32,13 +32,19 @@ class ERBNoOutputControlFlowRuleVisitor extends BaseRuleVisitor {
|
|
|
32
32
|
controlBlockType = "end";
|
|
33
33
|
if (controlBlock.type === "AST_ERB_UNLESS_NODE")
|
|
34
34
|
controlBlockType = "unless";
|
|
35
|
-
this.addOffense(`Control flow statements like \`${controlBlockType}\` should not be used with output tags. Use \`<% ${controlBlockType} ... %>\` instead.`, openTag.location
|
|
35
|
+
this.addOffense(`Control flow statements like \`${controlBlockType}\` should not be used with output tags. Use \`<% ${controlBlockType} ... %>\` instead.`, openTag.location);
|
|
36
36
|
}
|
|
37
37
|
return;
|
|
38
38
|
}
|
|
39
39
|
}
|
|
40
40
|
export class ERBNoOutputControlFlowRule extends ParserRule {
|
|
41
41
|
name = "erb-no-output-control-flow";
|
|
42
|
+
get defaultConfig() {
|
|
43
|
+
return {
|
|
44
|
+
enabled: true,
|
|
45
|
+
severity: "error"
|
|
46
|
+
};
|
|
47
|
+
}
|
|
42
48
|
check(result, context) {
|
|
43
49
|
const visitor = new ERBNoOutputControlFlowRuleVisitor(this.name, context);
|
|
44
50
|
visitor.visit(result.value);
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"erb-no-output-control-flow.js","sourceRoot":"","sources":["../../../src/rules/erb-no-output-control-flow.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAA;AAGjD,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AAGxC,MAAM,iCAAkC,SAAQ,eAAe;IAC7D,cAAc,CAAC,IAAe;QAC5B,IAAI,CAAC,sBAAsB,CAAC,IAAI,CAAC,CAAA;QACjC,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAED,kBAAkB,CAAC,IAAmB;QACpC,IAAI,CAAC,sBAAsB,CAAC,IAAI,CAAC,CAAA;QACjC,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAED,gBAAgB,CAAC,IAAiB;QAChC,IAAI,CAAC,sBAAsB,CAAC,IAAI,CAAC,CAAA;QACjC,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAED,eAAe,CAAC,IAAgB;QAC9B,IAAI,CAAC,sBAAsB,CAAC,IAAI,CAAC,CAAA;QACjC,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAEO,sBAAsB,CAAC,YAAkE;QAC/F,MAAM,OAAO,GAAG,YAAY,CAAC,WAAW,CAAC;QACzC,IAAI,CAAC,OAAO,EAAE,CAAC;YACb,OAAM;QACR,CAAC;QAED,IAAI,OAAO,CAAC,KAAK,KAAK,KAAK,EAAC,CAAC;YAC3B,IAAI,gBAAgB,GAAW,YAAY,CAAC,IAAI,CAAA;YAEhD,IAAI,YAAY,CAAC,IAAI,KAAK,iBAAiB;gBAAE,gBAAgB,GAAG,IAAI,CAAA;YACpE,IAAI,YAAY,CAAC,IAAI,KAAK,mBAAmB;gBAAE,gBAAgB,GAAG,MAAM,CAAA;YACxE,IAAI,YAAY,CAAC,IAAI,KAAK,kBAAkB;gBAAE,gBAAgB,GAAG,KAAK,CAAA;YACtE,IAAI,YAAY,CAAC,IAAI,KAAK,qBAAqB;gBAAE,gBAAgB,GAAG,QAAQ,CAAA;YAE5E,IAAI,CAAC,UAAU,CACb,kCAAkC,gBAAgB,oDAAoD,gBAAgB,oBAAoB,EAC1I,OAAO,CAAC,QAAQ,
|
|
1
|
+
{"version":3,"file":"erb-no-output-control-flow.js","sourceRoot":"","sources":["../../../src/rules/erb-no-output-control-flow.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAA;AAGjD,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AAGxC,MAAM,iCAAkC,SAAQ,eAAe;IAC7D,cAAc,CAAC,IAAe;QAC5B,IAAI,CAAC,sBAAsB,CAAC,IAAI,CAAC,CAAA;QACjC,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAED,kBAAkB,CAAC,IAAmB;QACpC,IAAI,CAAC,sBAAsB,CAAC,IAAI,CAAC,CAAA;QACjC,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAED,gBAAgB,CAAC,IAAiB;QAChC,IAAI,CAAC,sBAAsB,CAAC,IAAI,CAAC,CAAA;QACjC,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAED,eAAe,CAAC,IAAgB;QAC9B,IAAI,CAAC,sBAAsB,CAAC,IAAI,CAAC,CAAA;QACjC,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAEO,sBAAsB,CAAC,YAAkE;QAC/F,MAAM,OAAO,GAAG,YAAY,CAAC,WAAW,CAAC;QACzC,IAAI,CAAC,OAAO,EAAE,CAAC;YACb,OAAM;QACR,CAAC;QAED,IAAI,OAAO,CAAC,KAAK,KAAK,KAAK,EAAC,CAAC;YAC3B,IAAI,gBAAgB,GAAW,YAAY,CAAC,IAAI,CAAA;YAEhD,IAAI,YAAY,CAAC,IAAI,KAAK,iBAAiB;gBAAE,gBAAgB,GAAG,IAAI,CAAA;YACpE,IAAI,YAAY,CAAC,IAAI,KAAK,mBAAmB;gBAAE,gBAAgB,GAAG,MAAM,CAAA;YACxE,IAAI,YAAY,CAAC,IAAI,KAAK,kBAAkB;gBAAE,gBAAgB,GAAG,KAAK,CAAA;YACtE,IAAI,YAAY,CAAC,IAAI,KAAK,qBAAqB;gBAAE,gBAAgB,GAAG,QAAQ,CAAA;YAE5E,IAAI,CAAC,UAAU,CACb,kCAAkC,gBAAgB,oDAAoD,gBAAgB,oBAAoB,EAC1I,OAAO,CAAC,QAAQ,CACjB,CAAA;QACH,CAAC;QAED,OAAM;IACR,CAAC;CACF;AAED,MAAM,OAAO,0BAA2B,SAAQ,UAAU;IACxD,IAAI,GAAG,4BAA4B,CAAA;IAEnC,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,OAAO;SAClB,CAAA;IACH,CAAC;IAED,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,iCAAiC,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAEzE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}
|
|
@@ -6,7 +6,7 @@ class ERBNoSilentTagInAttributeNameVisitor extends BaseRuleVisitor {
|
|
|
6
6
|
const erbNodes = filterERBContentNodes(node.children);
|
|
7
7
|
const silentNodes = erbNodes.filter(this.isSilentERBTag);
|
|
8
8
|
for (const node of silentNodes) {
|
|
9
|
-
this.addOffense(`Remove silent ERB tag from HTML attribute name. Silent ERB tags (\`${node.tag_opening?.value}\`) do not output content and should not be used in attribute names.`, node.location
|
|
9
|
+
this.addOffense(`Remove silent ERB tag from HTML attribute name. Silent ERB tags (\`${node.tag_opening?.value}\`) do not output content and should not be used in attribute names.`, node.location);
|
|
10
10
|
}
|
|
11
11
|
}
|
|
12
12
|
// TODO: might be worth to extract
|
|
@@ -17,6 +17,12 @@ class ERBNoSilentTagInAttributeNameVisitor extends BaseRuleVisitor {
|
|
|
17
17
|
}
|
|
18
18
|
export class ERBNoSilentTagInAttributeNameRule extends ParserRule {
|
|
19
19
|
name = "erb-no-silent-tag-in-attribute-name";
|
|
20
|
+
get defaultConfig() {
|
|
21
|
+
return {
|
|
22
|
+
enabled: true,
|
|
23
|
+
severity: "error"
|
|
24
|
+
};
|
|
25
|
+
}
|
|
20
26
|
check(result, context) {
|
|
21
27
|
const visitor = new ERBNoSilentTagInAttributeNameVisitor(this.name, context);
|
|
22
28
|
visitor.visit(result.value);
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"erb-no-silent-tag-in-attribute-name.js","sourceRoot":"","sources":["../../../src/rules/erb-no-silent-tag-in-attribute-name.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAA;AACjD,OAAO,EAAE,qBAAqB,EAAE,MAAM,kBAAkB,CAAA;AAKxD,MAAM,oCAAqC,SAAQ,eAAe;IAChE,0BAA0B,CAAC,IAA2B;QACpD,MAAM,QAAQ,GAAG,qBAAqB,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAA;QACrD,MAAM,WAAW,GAAG,QAAQ,CAAC,MAAM,CAAC,IAAI,CAAC,cAAc,CAAC,CAAA;QAExD,KAAK,MAAM,IAAI,IAAI,WAAW,EAAE,CAAC;YAC/B,IAAI,CAAC,UAAU,CACb,sEAAsE,IAAI,CAAC,WAAW,EAAE,KAAK,sEAAsE,EACnK,IAAI,CAAC,QAAQ,
|
|
1
|
+
{"version":3,"file":"erb-no-silent-tag-in-attribute-name.js","sourceRoot":"","sources":["../../../src/rules/erb-no-silent-tag-in-attribute-name.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAA;AACjD,OAAO,EAAE,qBAAqB,EAAE,MAAM,kBAAkB,CAAA;AAKxD,MAAM,oCAAqC,SAAQ,eAAe;IAChE,0BAA0B,CAAC,IAA2B;QACpD,MAAM,QAAQ,GAAG,qBAAqB,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAA;QACrD,MAAM,WAAW,GAAG,QAAQ,CAAC,MAAM,CAAC,IAAI,CAAC,cAAc,CAAC,CAAA;QAExD,KAAK,MAAM,IAAI,IAAI,WAAW,EAAE,CAAC;YAC/B,IAAI,CAAC,UAAU,CACb,sEAAsE,IAAI,CAAC,WAAW,EAAE,KAAK,sEAAsE,EACnK,IAAI,CAAC,QAAQ,CACd,CAAA;QACH,CAAC;IACH,CAAC;IAED,kCAAkC;IAC1B,cAAc,CAAC,IAAoB;QACzC,MAAM,UAAU,GAAG,CAAC,IAAI,EAAE,KAAK,EAAE,KAAK,CAAC,CAAA;QAEvC,OAAO,UAAU,CAAC,QAAQ,CAAC,IAAI,CAAC,WAAW,EAAE,KAAK,IAAI,EAAE,CAAC,CAAA;IAC3D,CAAC;CACF;AAED,MAAM,OAAO,iCAAkC,SAAQ,UAAU;IAC/D,IAAI,GAAG,qCAAqC,CAAA;IAE5C,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,OAAO;SAClB,CAAA;IACH,CAAC;IAED,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,oCAAoC,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAE5E,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}
|
|
@@ -24,7 +24,7 @@ class ERBPreferImageTagHelperVisitor extends BaseRuleVisitor {
|
|
|
24
24
|
return;
|
|
25
25
|
if (this.shouldFlagAsImageTagCandidate(node)) {
|
|
26
26
|
const suggestedExpression = this.buildSuggestedExpression(node);
|
|
27
|
-
this.addOffense(`Prefer \`image_tag\` helper over manual \`<img>\` with dynamic ERB expressions. Use \`<%= image_tag ${suggestedExpression}, alt: "..." %>\` instead.`, srcAttribute.location
|
|
27
|
+
this.addOffense(`Prefer \`image_tag\` helper over manual \`<img>\` with dynamic ERB expressions. Use \`<%= image_tag ${suggestedExpression}, alt: "..." %>\` instead.`, srcAttribute.location);
|
|
28
28
|
}
|
|
29
29
|
}
|
|
30
30
|
}
|
|
@@ -70,6 +70,12 @@ class ERBPreferImageTagHelperVisitor extends BaseRuleVisitor {
|
|
|
70
70
|
}
|
|
71
71
|
export class ERBPreferImageTagHelperRule extends ParserRule {
|
|
72
72
|
name = "erb-prefer-image-tag-helper";
|
|
73
|
+
get defaultConfig() {
|
|
74
|
+
return {
|
|
75
|
+
enabled: true,
|
|
76
|
+
severity: "warning"
|
|
77
|
+
};
|
|
78
|
+
}
|
|
73
79
|
check(result, context) {
|
|
74
80
|
const visitor = new ERBPreferImageTagHelperVisitor(this.name, context);
|
|
75
81
|
visitor.visit(result.value);
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"erb-prefer-image-tag-helper.js","sourceRoot":"","sources":["../../../src/rules/erb-prefer-image-tag-helper.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,eAAe,EAAE,UAAU,EAAE,mBAAmB,EAAE,aAAa,EAAE,MAAM,iBAAiB,CAAA;AAEjG,OAAO,EAAE,sBAAsB,EAAE,MAAM,qBAAqB,CAAA;AAC5D,OAAO,EAAE,WAAW,EAAE,cAAc,EAAE,WAAW,EAAE,MAAM,EAAE,MAAM,kBAAkB,CAAA;AAKnF,MAAM,8BAA+B,SAAQ,eAAe;IAC1D,oBAAoB,CAAC,IAAqB;QACxC,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,CAAA;QACtB,KAAK,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAA;IAClC,CAAC;IAEO,WAAW,CAAC,OAAwB;QAC1C,MAAM,OAAO,GAAG,UAAU,CAAC,OAAO,CAAC,CAAA;QAEnC,IAAI,OAAO,KAAK,KAAK;YAAE,OAAM;QAE7B,MAAM,UAAU,GAAG,aAAa,CAAC,OAAO,CAAC,CAAA;QACzC,MAAM,YAAY,GAAG,mBAAmB,CAAC,UAAU,EAAE,KAAK,CAAC,CAAA;QAE3D,IAAI,CAAC,YAAY;YAAE,OAAM;QACzB,IAAI,CAAC,YAAY,CAAC,KAAK;YAAE,OAAM;QAE/B,MAAM,IAAI,GAAG,YAAY,CAAC,KAAK,CAAA;QAC/B,MAAM,aAAa,GAAG,IAAI,CAAC,kBAAkB,CAAC,IAAI,CAAC,CAAA;QAEnD,IAAI,aAAa,EAAE,CAAC;YAClB,IAAI,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC;gBAAE,OAAM;YAEhC,IAAI,IAAI,CAAC,6BAA6B,CAAC,IAAI,CAAC,EAAE,CAAC;gBAC7C,MAAM,mBAAmB,GAAG,IAAI,CAAC,wBAAwB,CAAC,IAAI,CAAC,CAAA;gBAE/D,IAAI,CAAC,UAAU,CACb,uGAAuG,mBAAmB,4BAA4B,EACtJ,YAAY,CAAC,QAAQ,
|
|
1
|
+
{"version":3,"file":"erb-prefer-image-tag-helper.js","sourceRoot":"","sources":["../../../src/rules/erb-prefer-image-tag-helper.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,eAAe,EAAE,UAAU,EAAE,mBAAmB,EAAE,aAAa,EAAE,MAAM,iBAAiB,CAAA;AAEjG,OAAO,EAAE,sBAAsB,EAAE,MAAM,qBAAqB,CAAA;AAC5D,OAAO,EAAE,WAAW,EAAE,cAAc,EAAE,WAAW,EAAE,MAAM,EAAE,MAAM,kBAAkB,CAAA;AAKnF,MAAM,8BAA+B,SAAQ,eAAe;IAC1D,oBAAoB,CAAC,IAAqB;QACxC,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,CAAA;QACtB,KAAK,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAA;IAClC,CAAC;IAEO,WAAW,CAAC,OAAwB;QAC1C,MAAM,OAAO,GAAG,UAAU,CAAC,OAAO,CAAC,CAAA;QAEnC,IAAI,OAAO,KAAK,KAAK;YAAE,OAAM;QAE7B,MAAM,UAAU,GAAG,aAAa,CAAC,OAAO,CAAC,CAAA;QACzC,MAAM,YAAY,GAAG,mBAAmB,CAAC,UAAU,EAAE,KAAK,CAAC,CAAA;QAE3D,IAAI,CAAC,YAAY;YAAE,OAAM;QACzB,IAAI,CAAC,YAAY,CAAC,KAAK;YAAE,OAAM;QAE/B,MAAM,IAAI,GAAG,YAAY,CAAC,KAAK,CAAA;QAC/B,MAAM,aAAa,GAAG,IAAI,CAAC,kBAAkB,CAAC,IAAI,CAAC,CAAA;QAEnD,IAAI,aAAa,EAAE,CAAC;YAClB,IAAI,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC;gBAAE,OAAM;YAEhC,IAAI,IAAI,CAAC,6BAA6B,CAAC,IAAI,CAAC,EAAE,CAAC;gBAC7C,MAAM,mBAAmB,GAAG,IAAI,CAAC,wBAAwB,CAAC,IAAI,CAAC,CAAA;gBAE/D,IAAI,CAAC,UAAU,CACb,uGAAuG,mBAAmB,4BAA4B,EACtJ,YAAY,CAAC,QAAQ,CACtB,CAAA;YACH,CAAC;QACH,CAAC;IACH,CAAC;IAEO,kBAAkB,CAAC,IAA4B;QACrD,OAAO,WAAW,CAAC,IAAI,CAAC,QAAQ,EAAE,cAAc,CAAC,CAAC,MAAM,GAAG,CAAC,CAAA;IAC9D,CAAC;IAEO,gBAAgB,CAAC,IAA4B;QACnD,OAAO,IAAI,CAAC,QAAQ,CAAC,MAAM,GAAG,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,MAAM,KAAK,WAAW,CAAC,IAAI,CAAC,QAAQ,EAAE,cAAc,CAAC,CAAC,MAAM,CAAA;IAC/G,CAAC;IAEO,sBAAsB,CAAC,IAA4B;QACzD,IAAI,CAAC,IAAI,CAAC,QAAQ,IAAI,IAAI,CAAC,QAAQ,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,EAAE,CAAA;QAE3D,MAAM,UAAU,GAAG,IAAI,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAA;QAEnC,IAAI,MAAM,CAAC,UAAU,EAAE,WAAW,CAAC,EAAE,CAAC;YACpC,OAAO,CAAC,UAAU,CAAC,OAAO,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,CAAA;QAC1C,CAAC;QAED,OAAO,EAAE,CAAA;IACX,CAAC;IAEO,SAAS,CAAC,IAA4B;QAC5C,OAAO,IAAI,CAAC,sBAAsB,CAAC,IAAI,CAAC,CAAC,UAAU,CAAC,OAAO,CAAC,CAAA;IAC9D,CAAC;IAEO,SAAS,CAAC,IAA4B;QAC5C,MAAM,OAAO,GAAG,IAAI,CAAC,sBAAsB,CAAC,IAAI,CAAC,CAAA;QAEjD,OAAO,OAAO,CAAC,UAAU,CAAC,SAAS,CAAC,IAAI,OAAO,CAAC,UAAU,CAAC,UAAU,CAAC,CAAA;IACxE,CAAC;IAEO,6BAA6B,CAAC,IAA4B;QAChE,IAAI,IAAI,CAAC,gBAAgB,CAAC,IAAI,CAAC;YAAE,OAAO,IAAI,CAAA;QAC5C,IAAI,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC;YAAE,OAAO,KAAK,CAAA;QAEtC,OAAO,IAAI,CAAA;IACb,CAAC;IAEO,wBAAwB,CAAC,IAA4B;QAC3D,IAAI,CAAC,IAAI,CAAC,QAAQ;YAAE,OAAO,YAAY,CAAA;QAEvC,IAAI,CAAC;YACH,OAAO,sBAAsB,CAAC,KAAK,CAAC,IAAI,EAAE,EAAE,YAAY,EAAE,KAAK,EAAE,CAAC,CAAA;QACpE,CAAC;QAAC,MAAM,CAAC;YACP,OAAO,YAAY,CAAA;QACrB,CAAC;IACH,CAAC;CACF;AAED,MAAM,OAAO,2BAA4B,SAAQ,UAAU;IACzD,IAAI,GAAG,6BAA6B,CAAA;IAEpC,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,SAAS;SACpB,CAAA;IACH,CAAC;IAED,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,8BAA8B,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QACtE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAC3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}
|
|
@@ -0,0 +1,35 @@
|
|
|
1
|
+
import { SourceRule } from "../types.js";
|
|
2
|
+
import { BaseSourceRuleVisitor, createEndOfFileLocation } from "./rule-utils.js";
|
|
3
|
+
class ERBRequireTrailingNewlineVisitor extends BaseSourceRuleVisitor {
|
|
4
|
+
visitSource(source) {
|
|
5
|
+
if (source.length === 0)
|
|
6
|
+
return;
|
|
7
|
+
if (!this.context.fileName)
|
|
8
|
+
return;
|
|
9
|
+
if (!source.endsWith('\n')) {
|
|
10
|
+
this.addOffense("File must end with trailing newline.", createEndOfFileLocation(source));
|
|
11
|
+
}
|
|
12
|
+
else if (source.endsWith('\n\n')) {
|
|
13
|
+
this.addOffense("File must end with exactly one trailing newline.", createEndOfFileLocation(source));
|
|
14
|
+
}
|
|
15
|
+
}
|
|
16
|
+
}
|
|
17
|
+
export class ERBRequireTrailingNewlineRule extends SourceRule {
|
|
18
|
+
static autocorrectable = true;
|
|
19
|
+
name = "erb-require-trailing-newline";
|
|
20
|
+
get defaultConfig() {
|
|
21
|
+
return {
|
|
22
|
+
enabled: true,
|
|
23
|
+
severity: "error"
|
|
24
|
+
};
|
|
25
|
+
}
|
|
26
|
+
check(source, context) {
|
|
27
|
+
const visitor = new ERBRequireTrailingNewlineVisitor(this.name, context);
|
|
28
|
+
visitor.visit(source);
|
|
29
|
+
return visitor.offenses;
|
|
30
|
+
}
|
|
31
|
+
autofix(_offense, source, _context) {
|
|
32
|
+
return source.trimEnd() + "\n";
|
|
33
|
+
}
|
|
34
|
+
}
|
|
35
|
+
//# sourceMappingURL=erb-require-trailing-newline.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"erb-require-trailing-newline.js","sourceRoot":"","sources":["../../../src/rules/erb-require-trailing-newline.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,qBAAqB,EAAE,uBAAuB,EAAE,MAAM,iBAAiB,CAAA;AAIhF,MAAM,gCAAiC,SAAQ,qBAAqB;IACxD,WAAW,CAAC,MAAc;QAClC,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC;YAAE,OAAM;QAC/B,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,QAAQ;YAAE,OAAM;QAElC,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,CAAC;YAC3B,IAAI,CAAC,UAAU,CACb,sCAAsC,EACtC,uBAAuB,CAAC,MAAM,CAAC,CAChC,CAAA;QACH,CAAC;aAAM,IAAI,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,EAAE,CAAC;YACnC,IAAI,CAAC,UAAU,CACb,kDAAkD,EAClD,uBAAuB,CAAC,MAAM,CAAC,CAChC,CAAA;QACH,CAAC;IACH,CAAC;CACF;AAED,MAAM,OAAO,6BAA8B,SAAQ,UAAU;IAC3D,MAAM,CAAC,eAAe,GAAG,IAAI,CAAA;IAC7B,IAAI,GAAG,8BAA8B,CAAA;IAErC,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,OAAO;SAClB,CAAA;IACH,CAAC;IAED,KAAK,CAAC,MAAc,EAAE,OAA8B;QAClD,MAAM,OAAO,GAAG,IAAI,gCAAgC,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAExE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,CAAA;QAErB,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;IAED,OAAO,CAAC,QAAqB,EAAE,MAAc,EAAE,QAA+B;QAC5E,OAAO,MAAM,CAAC,OAAO,EAAE,GAAG,IAAI,CAAA;IAChC,CAAC"}
|
|
@@ -10,43 +10,101 @@ class RequireWhitespaceInsideTags extends BaseRuleVisitor {
|
|
|
10
10
|
}
|
|
11
11
|
const value = content.value;
|
|
12
12
|
if (openTag.value === "<%#") {
|
|
13
|
-
this.checkCommentTagWhitespace(openTag, closeTag, value);
|
|
13
|
+
this.checkCommentTagWhitespace(node, openTag, closeTag, value);
|
|
14
14
|
}
|
|
15
15
|
else {
|
|
16
|
-
this.checkOpenTagWhitespace(openTag, value);
|
|
17
|
-
this.checkCloseTagWhitespace(closeTag, value);
|
|
16
|
+
this.checkOpenTagWhitespace(node, openTag, closeTag, value);
|
|
17
|
+
this.checkCloseTagWhitespace(node, openTag, closeTag, value);
|
|
18
18
|
}
|
|
19
19
|
}
|
|
20
|
-
checkCommentTagWhitespace(openTag, closeTag, content) {
|
|
20
|
+
checkCommentTagWhitespace(node, openTag, closeTag, content) {
|
|
21
21
|
if (!content.startsWith(" ") && !content.startsWith("\n") && !content.startsWith("=")) {
|
|
22
|
-
this.addOffense(`Add whitespace after \`${openTag.value}\`.`, openTag.location,
|
|
22
|
+
this.addOffense(`Add whitespace after \`${openTag.value}\`.`, openTag.location, {
|
|
23
|
+
node,
|
|
24
|
+
openTag,
|
|
25
|
+
closeTag,
|
|
26
|
+
content,
|
|
27
|
+
fixType: "after-open"
|
|
28
|
+
});
|
|
23
29
|
}
|
|
24
30
|
else if (content.startsWith("=") && content.length > 1 && !content[1].match(/\s/)) {
|
|
25
|
-
this.addOffense(`Add whitespace after \`<%#=\`.`, openTag.location,
|
|
31
|
+
this.addOffense(`Add whitespace after \`<%#=\`.`, openTag.location, {
|
|
32
|
+
node,
|
|
33
|
+
openTag,
|
|
34
|
+
closeTag,
|
|
35
|
+
content,
|
|
36
|
+
fixType: "after-comment-equals"
|
|
37
|
+
});
|
|
26
38
|
}
|
|
27
39
|
if (!content.endsWith(" ") && !content.endsWith("\n")) {
|
|
28
|
-
this.addOffense(`Add whitespace before \`${closeTag.value}\`.`, closeTag.location,
|
|
40
|
+
this.addOffense(`Add whitespace before \`${closeTag.value}\`.`, closeTag.location, {
|
|
41
|
+
node,
|
|
42
|
+
openTag,
|
|
43
|
+
closeTag,
|
|
44
|
+
content,
|
|
45
|
+
fixType: "before-close"
|
|
46
|
+
});
|
|
29
47
|
}
|
|
30
48
|
}
|
|
31
|
-
checkOpenTagWhitespace(openTag, content) {
|
|
49
|
+
checkOpenTagWhitespace(node, openTag, closeTag, content) {
|
|
32
50
|
if (content.startsWith(" ") || content.startsWith("\n")) {
|
|
33
51
|
return;
|
|
34
52
|
}
|
|
35
|
-
this.addOffense(`Add whitespace after \`${openTag.value}\`.`, openTag.location,
|
|
53
|
+
this.addOffense(`Add whitespace after \`${openTag.value}\`.`, openTag.location, {
|
|
54
|
+
node,
|
|
55
|
+
openTag,
|
|
56
|
+
closeTag,
|
|
57
|
+
content,
|
|
58
|
+
fixType: "after-open"
|
|
59
|
+
});
|
|
36
60
|
}
|
|
37
|
-
checkCloseTagWhitespace(closeTag, content) {
|
|
61
|
+
checkCloseTagWhitespace(node, openTag, closeTag, content) {
|
|
38
62
|
if (content.endsWith(" ") || content.endsWith("\n")) {
|
|
39
63
|
return;
|
|
40
64
|
}
|
|
41
|
-
this.addOffense(`Add whitespace before \`${closeTag.value}\`.`, closeTag.location,
|
|
65
|
+
this.addOffense(`Add whitespace before \`${closeTag.value}\`.`, closeTag.location, {
|
|
66
|
+
node,
|
|
67
|
+
openTag,
|
|
68
|
+
closeTag,
|
|
69
|
+
content,
|
|
70
|
+
fixType: "before-close"
|
|
71
|
+
});
|
|
42
72
|
}
|
|
43
73
|
}
|
|
44
74
|
export class ERBRequireWhitespaceRule extends ParserRule {
|
|
75
|
+
static autocorrectable = true;
|
|
45
76
|
name = "erb-require-whitespace-inside-tags";
|
|
77
|
+
get defaultConfig() {
|
|
78
|
+
return {
|
|
79
|
+
enabled: true,
|
|
80
|
+
severity: "error"
|
|
81
|
+
};
|
|
82
|
+
}
|
|
46
83
|
check(result, context) {
|
|
47
84
|
const visitor = new RequireWhitespaceInsideTags(this.name, context);
|
|
48
85
|
visitor.visit(result.value);
|
|
49
86
|
return visitor.offenses;
|
|
50
87
|
}
|
|
88
|
+
autofix(offense, result, _context) {
|
|
89
|
+
if (!offense.autofixContext)
|
|
90
|
+
return null;
|
|
91
|
+
const { node, fixType } = offense.autofixContext;
|
|
92
|
+
if (!node.content)
|
|
93
|
+
return null;
|
|
94
|
+
const content = node.content.value;
|
|
95
|
+
if (fixType === "before-close") {
|
|
96
|
+
node.content.value = content + " ";
|
|
97
|
+
return result;
|
|
98
|
+
}
|
|
99
|
+
if (fixType === "after-open") {
|
|
100
|
+
node.content.value = " " + content;
|
|
101
|
+
return result;
|
|
102
|
+
}
|
|
103
|
+
if (fixType === "after-comment-equals" && content.startsWith("=")) {
|
|
104
|
+
node.content.value = "= " + content.substring(1);
|
|
105
|
+
return result;
|
|
106
|
+
}
|
|
107
|
+
return null;
|
|
108
|
+
}
|
|
51
109
|
}
|
|
52
110
|
//# sourceMappingURL=erb-require-whitespace-inside-tags.js.map
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"erb-require-whitespace-inside-tags.js","sourceRoot":"","sources":["../../../src/rules/erb-require-whitespace-inside-tags.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,
|
|
1
|
+
{"version":3,"file":"erb-require-whitespace-inside-tags.js","sourceRoot":"","sources":["../../../src/rules/erb-require-whitespace-inside-tags.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAA+B,MAAM,aAAa,CAAA;AACrE,OAAO,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAA;AAajD,MAAM,2BAA4B,SAAQ,eAAmD;IAE3F,YAAY,CAAC,IAAa;QACxB,MAAM,OAAO,GAAG,IAAI,CAAC,WAAW,CAAA;QAChC,MAAM,QAAQ,GAAG,IAAI,CAAC,WAAW,CAAA;QACjC,MAAM,OAAO,GAAG,IAAI,CAAC,OAAO,CAAA;QAE5B,IAAI,CAAC,OAAO,IAAI,CAAC,QAAQ,IAAI,CAAC,OAAO,EAAE,CAAC;YACtC,OAAM;QACR,CAAC;QAED,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,CAAA;QAE3B,IAAI,OAAO,CAAC,KAAK,KAAK,KAAK,EAAE,CAAC;YAC5B,IAAI,CAAC,yBAAyB,CAAC,IAAI,EAAE,OAAO,EAAE,QAAQ,EAAE,KAAK,CAAC,CAAA;QAChE,CAAC;aAAM,CAAC;YACN,IAAI,CAAC,sBAAsB,CAAC,IAAI,EAAE,OAAO,EAAE,QAAQ,EAAE,KAAK,CAAC,CAAA;YAC3D,IAAI,CAAC,uBAAuB,CAAC,IAAI,EAAE,OAAO,EAAE,QAAQ,EAAE,KAAK,CAAC,CAAA;QAC9D,CAAC;IACH,CAAC;IAEO,yBAAyB,CAAC,IAAa,EAAE,OAAc,EAAE,QAAe,EAAE,OAAe;QAC/F,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,EAAE,CAAC;YACtF,IAAI,CAAC,UAAU,CACb,0BAA0B,OAAO,CAAC,KAAK,KAAK,EAC5C,OAAO,CAAC,QAAQ,EAChB;gBACE,IAAI;gBACJ,OAAO;gBACP,QAAQ;gBACR,OAAO;gBACP,OAAO,EAAE,YAAY;aACtB,CACF,CAAA;QACH,CAAC;aAAM,IAAI,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,OAAO,CAAC,MAAM,GAAG,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC;YACpF,IAAI,CAAC,UAAU,CACb,gCAAgC,EAChC,OAAO,CAAC,QAAQ,EAChB;gBACE,IAAI;gBACJ,OAAO;gBACP,QAAQ;gBACR,OAAO;gBACP,OAAO,EAAE,sBAAsB;aAChC,CACF,CAAA;QACH,CAAC;QAED,IAAI,CAAC,OAAO,CAAC,QAAQ,CAAC,GAAG,CAAC,IAAI,CAAC,OAAO,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,CAAC;YACtD,IAAI,CAAC,UAAU,CACb,2BAA2B,QAAQ,CAAC,KAAK,KAAK,EAC9C,QAAQ,CAAC,QAAQ,EACjB;gBACE,IAAI;gBACJ,OAAO;gBACP,QAAQ;gBACR,OAAO;gBACP,OAAO,EAAE,cAAc;aACxB,CACF,CAAA;QACH,CAAC;IACH,CAAC;IAEO,sBAAsB,CAAC,IAAa,EAAE,OAAc,EAAE,QAAe,EAAE,OAAe;QAC5F,IAAI,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC,EAAE,CAAC;YACxD,OAAM;QACR,CAAC;QAED,IAAI,CAAC,UAAU,CACb,0BAA0B,OAAO,CAAC,KAAK,KAAK,EAC5C,OAAO,CAAC,QAAQ,EAChB;YACE,IAAI;YACJ,OAAO;YACP,QAAQ;YACR,OAAO;YACP,OAAO,EAAE,YAAY;SACtB,CACF,CAAA;IACH,CAAC;IAEO,uBAAuB,CAAC,IAAa,EAAE,OAAc,EAAE,QAAe,EAAE,OAAe;QAC7F,IAAI,OAAO,CAAC,QAAQ,CAAC,GAAG,CAAC,IAAI,OAAO,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,CAAC;YACpD,OAAM;QACR,CAAC;QAED,IAAI,CAAC,UAAU,CACb,2BAA2B,QAAQ,CAAC,KAAK,KAAK,EAC9C,QAAQ,CAAC,QAAQ,EACjB;YACE,IAAI;YACJ,OAAO;YACP,QAAQ;YACR,OAAO;YACP,OAAO,EAAE,cAAc;SACxB,CACF,CAAA;IACH,CAAC;CACF;AAED,MAAM,OAAO,wBAAyB,SAAQ,UAA8C;IAC1F,MAAM,CAAC,eAAe,GAAG,IAAI,CAAA;IAC7B,IAAI,GAAG,oCAAoC,CAAA;IAE3C,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,OAAO;SAClB,CAAA;IACH,CAAC;IAED,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,2BAA2B,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAEnE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;IAED,OAAO,CAAC,OAAwD,EAAE,MAAmB,EAAE,QAA+B;QACpH,IAAI,CAAC,OAAO,CAAC,cAAc;YAAE,OAAO,IAAI,CAAA;QAExC,MAAM,EAAE,IAAI,EAAE,OAAO,EAAE,GAAG,OAAO,CAAC,cAAc,CAAA;QAEhD,IAAI,CAAC,IAAI,CAAC,OAAO;YAAE,OAAO,IAAI,CAAA;QAE9B,MAAM,OAAO,GAAG,IAAI,CAAC,OAAO,CAAC,KAAK,CAAA;QAElC,IAAI,OAAO,KAAK,cAAc,EAAE,CAAC;YAC/B,IAAI,CAAC,OAAO,CAAC,KAAK,GAAG,OAAO,GAAG,GAAG,CAAA;YAElC,OAAO,MAAM,CAAA;QACf,CAAC;QAED,IAAI,OAAO,KAAK,YAAY,EAAE,CAAC;YAC7B,IAAI,CAAC,OAAO,CAAC,KAAK,GAAG,GAAG,GAAG,OAAO,CAAA;YAElC,OAAO,MAAM,CAAA;QACf,CAAC;QAED,IAAI,OAAO,KAAK,sBAAsB,IAAI,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,EAAE,CAAC;YAClE,IAAI,CAAC,OAAO,CAAC,KAAK,GAAG,IAAI,GAAG,OAAO,CAAC,SAAS,CAAC,CAAC,CAAC,CAAA;YAEhD,OAAO,MAAM,CAAA;QACf,CAAC;QAED,OAAO,IAAI,CAAA;IACb,CAAC"}
|
|
@@ -1,28 +1,45 @@
|
|
|
1
1
|
import { BaseRuleVisitor } from "./rule-utils.js";
|
|
2
2
|
import { ParserRule } from "../types.js";
|
|
3
|
-
import { isERBOutputNode } from "@herb-tools/core";
|
|
4
3
|
class ERBRightTrimVisitor extends BaseRuleVisitor {
|
|
5
4
|
visitERBNode(node) {
|
|
6
5
|
if (!node.tag_closing)
|
|
7
6
|
return;
|
|
8
7
|
const trimClosing = node.tag_closing.value;
|
|
9
|
-
if (trimClosing !== "=%>"
|
|
8
|
+
if (trimClosing !== "=%>")
|
|
10
9
|
return;
|
|
11
|
-
|
|
12
|
-
this.addOffense(`Right-trimming with \`${trimClosing}\` has no effect on non-output ERB tags. Use \`%>\` instead`, node.tag_closing.location);
|
|
13
|
-
return;
|
|
14
|
-
}
|
|
15
|
-
if (trimClosing === "=%>") {
|
|
16
|
-
this.addOffense("Use `-%>` instead of `=%>` for right-trimming. The `=%>` syntax is obscure and not well-supported in most ERB engines", node.tag_closing.location);
|
|
17
|
-
}
|
|
10
|
+
this.addOffense("Use `-%>` instead of `=%>` for right-trimming. The `=%>` syntax is obscure and not well-supported in most ERB engines.", node.tag_closing.location, { node });
|
|
18
11
|
}
|
|
19
12
|
}
|
|
20
13
|
export class ERBRightTrimRule extends ParserRule {
|
|
14
|
+
static autocorrectable = true;
|
|
21
15
|
name = "erb-right-trim";
|
|
16
|
+
get defaultConfig() {
|
|
17
|
+
return {
|
|
18
|
+
enabled: true,
|
|
19
|
+
severity: "error"
|
|
20
|
+
};
|
|
21
|
+
}
|
|
22
22
|
check(result, context) {
|
|
23
23
|
const visitor = new ERBRightTrimVisitor(this.name, context);
|
|
24
24
|
visitor.visit(result.value);
|
|
25
25
|
return visitor.offenses;
|
|
26
26
|
}
|
|
27
|
+
autofix(offense, result, _context) {
|
|
28
|
+
if (!offense.autofixContext)
|
|
29
|
+
return null;
|
|
30
|
+
const { node } = offense.autofixContext;
|
|
31
|
+
if (!node.tag_closing)
|
|
32
|
+
return null;
|
|
33
|
+
const closing = node.tag_closing;
|
|
34
|
+
if (closing.value === "=%>") {
|
|
35
|
+
closing.value = "-%>";
|
|
36
|
+
return result;
|
|
37
|
+
}
|
|
38
|
+
if (closing.value === "-%>") {
|
|
39
|
+
closing.value = "%>";
|
|
40
|
+
return result;
|
|
41
|
+
}
|
|
42
|
+
return null;
|
|
43
|
+
}
|
|
27
44
|
}
|
|
28
45
|
//# sourceMappingURL=erb-right-trim.js.map
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"erb-right-trim.js","sourceRoot":"","sources":["../../../src/rules/erb-right-trim.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAA;AACjD,OAAO,EAAE,UAAU,
|
|
1
|
+
{"version":3,"file":"erb-right-trim.js","sourceRoot":"","sources":["../../../src/rules/erb-right-trim.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAA;AACjD,OAAO,EAAE,UAAU,EAA+B,MAAM,aAAa,CAAA;AASrE,MAAM,mBAAoB,SAAQ,eAA2C;IAC3E,YAAY,CAAC,IAAa;QACxB,IAAI,CAAC,IAAI,CAAC,WAAW;YAAE,OAAM;QAE7B,MAAM,WAAW,GAAG,IAAI,CAAC,WAAW,CAAC,KAAK,CAAA;QAE1C,IAAI,WAAW,KAAK,KAAK;YAAE,OAAM;QAEjC,IAAI,CAAC,UAAU,CACb,wHAAwH,EACxH,IAAI,CAAC,WAAW,CAAC,QAAQ,EACzB,EAAE,IAAI,EAAE,CACT,CAAA;IACH,CAAC;CACF;AAED,MAAM,OAAO,gBAAiB,SAAQ,UAAsC;IAC1E,MAAM,CAAC,eAAe,GAAG,IAAI,CAAA;IAC7B,IAAI,GAAG,gBAAgB,CAAA;IAEvB,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,OAAO;SAClB,CAAA;IACH,CAAC;IAED,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,mBAAmB,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAE3D,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;IAED,OAAO,CAAC,OAAgD,EAAE,MAAmB,EAAE,QAA+B;QAC5G,IAAI,CAAC,OAAO,CAAC,cAAc;YAAE,OAAO,IAAI,CAAA;QAExC,MAAM,EAAE,IAAI,EAAE,GAAG,OAAO,CAAC,cAAc,CAAA;QAEvC,IAAI,CAAC,IAAI,CAAC,WAAW;YAAE,OAAO,IAAI,CAAA;QAElC,MAAM,OAAO,GAAG,IAAI,CAAC,WAAW,CAAA;QAEhC,IAAI,OAAO,CAAC,KAAK,KAAK,KAAK,EAAE,CAAC;YAC5B,OAAO,CAAC,KAAK,GAAG,KAAK,CAAA;YACrB,OAAO,MAAM,CAAA;QACf,CAAC;QAED,IAAI,OAAO,CAAC,KAAK,KAAK,KAAK,EAAE,CAAC;YAC5B,OAAO,CAAC,KAAK,GAAG,IAAI,CAAA;YACpB,OAAO,MAAM,CAAA;QACf,CAAC;QAED,OAAO,IAAI,CAAA;IACb,CAAC"}
|
|
@@ -0,0 +1,51 @@
|
|
|
1
|
+
import { BaseRuleVisitor } from "./rule-utils.js";
|
|
2
|
+
import { Location } from "@herb-tools/core";
|
|
3
|
+
import { parseHerbDisableContent } from "../herb-disable-comment-utils.js";
|
|
4
|
+
/**
|
|
5
|
+
* Base visitor class for herb:disable comment validation rules.
|
|
6
|
+
* Handles common patterns like checking ERB comments and parsing herb:disable content.
|
|
7
|
+
*/
|
|
8
|
+
export class HerbDisableCommentBaseVisitor extends BaseRuleVisitor {
|
|
9
|
+
constructor(ruleName, context) {
|
|
10
|
+
super(ruleName, context);
|
|
11
|
+
}
|
|
12
|
+
visitERBContentNode(node) {
|
|
13
|
+
if (node.tag_opening?.value !== "<%#")
|
|
14
|
+
return;
|
|
15
|
+
const content = node.content?.value;
|
|
16
|
+
if (!content)
|
|
17
|
+
return;
|
|
18
|
+
this.checkHerbDisableComment(node, content);
|
|
19
|
+
}
|
|
20
|
+
/**
|
|
21
|
+
* Helper to create a precise location for a specific rule name within the comment.
|
|
22
|
+
* Returns null if content location is not available.
|
|
23
|
+
*/
|
|
24
|
+
createRuleNameLocation(node, ruleDetail) {
|
|
25
|
+
const contentLocation = node.content?.location;
|
|
26
|
+
if (!contentLocation)
|
|
27
|
+
return null;
|
|
28
|
+
const startLine = contentLocation.start.line;
|
|
29
|
+
const startColumn = contentLocation.start.column + ruleDetail.offset;
|
|
30
|
+
return Location.from(startLine, startColumn, startLine, startColumn + ruleDetail.length);
|
|
31
|
+
}
|
|
32
|
+
/**
|
|
33
|
+
* Helper to add an offense with a fallback to node location if precise location unavailable.
|
|
34
|
+
*/
|
|
35
|
+
addOffenseWithFallback(message, preciseLocation, node) {
|
|
36
|
+
this.addOffense(message, preciseLocation || node.location);
|
|
37
|
+
}
|
|
38
|
+
}
|
|
39
|
+
/**
|
|
40
|
+
* Base visitor for rules that need to process parsed herb:disable comments.
|
|
41
|
+
* Only calls the abstract method if the content successfully parses as a herb:disable comment.
|
|
42
|
+
*/
|
|
43
|
+
export class HerbDisableCommentParsedVisitor extends HerbDisableCommentBaseVisitor {
|
|
44
|
+
checkHerbDisableComment(node, content) {
|
|
45
|
+
const herbDisable = parseHerbDisableContent(content);
|
|
46
|
+
if (!herbDisable)
|
|
47
|
+
return;
|
|
48
|
+
this.checkParsedHerbDisable(node, content, herbDisable);
|
|
49
|
+
}
|
|
50
|
+
}
|
|
51
|
+
//# sourceMappingURL=herb-disable-comment-base.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"herb-disable-comment-base.js","sourceRoot":"","sources":["../../../src/rules/herb-disable-comment-base.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAA;AACjD,OAAO,EAAkB,QAAQ,EAAE,MAAM,kBAAkB,CAAA;AAE3D,OAAO,EAAE,uBAAuB,EAAE,MAAM,kCAAkC,CAAA;AAK1E;;;GAGG;AACH,MAAM,OAAgB,6BAA8B,SAAQ,eAAe;IACzE,YAAY,QAAgB,EAAE,OAA8B;QAC1D,KAAK,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAA;IAC1B,CAAC;IAED,mBAAmB,CAAC,IAAoB;QACtC,IAAI,IAAI,CAAC,WAAW,EAAE,KAAK,KAAK,KAAK;YAAE,OAAM;QAE7C,MAAM,OAAO,GAAG,IAAI,CAAC,OAAO,EAAE,KAAK,CAAA;QACnC,IAAI,CAAC,OAAO;YAAE,OAAM;QAEpB,IAAI,CAAC,uBAAuB,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;IAC7C,CAAC;IAQD;;;OAGG;IACO,sBAAsB,CAAC,IAAoB,EAAE,UAA+B;QACpF,MAAM,eAAe,GAAG,IAAI,CAAC,OAAO,EAAE,QAAQ,CAAA;QAC9C,IAAI,CAAC,eAAe;YAAE,OAAO,IAAI,CAAA;QAEjC,MAAM,SAAS,GAAG,eAAe,CAAC,KAAK,CAAC,IAAI,CAAA;QAC5C,MAAM,WAAW,GAAG,eAAe,CAAC,KAAK,CAAC,MAAM,GAAG,UAAU,CAAC,MAAM,CAAA;QAEpE,OAAO,QAAQ,CAAC,IAAI,CAClB,SAAS,EACT,WAAW,EACX,SAAS,EACT,WAAW,GAAG,UAAU,CAAC,MAAM,CAChC,CAAA;IACH,CAAC;IAED;;OAEG;IACO,sBAAsB,CAAC,OAAe,EAAE,eAAgC,EAAE,IAAoB;QACtG,IAAI,CAAC,UAAU,CAAC,OAAO,EAAE,eAAe,IAAI,IAAI,CAAC,QAAQ,CAAC,CAAA;IAC5D,CAAC;CACF;AAED;;;GAGG;AACH,MAAM,OAAgB,+BAAgC,SAAQ,6BAA6B;IAC/E,uBAAuB,CAAC,IAAoB,EAAE,OAAe;QACrE,MAAM,WAAW,GAAG,uBAAuB,CAAC,OAAO,CAAC,CAAA;QACpD,IAAI,CAAC,WAAW;YAAE,OAAM;QAExB,IAAI,CAAC,sBAAsB,CAAC,IAAI,EAAE,OAAO,EAAE,WAAW,CAAC,CAAA;IACzD,CAAC;CAMF"}
|
|
@@ -0,0 +1,51 @@
|
|
|
1
|
+
import { ParserRule } from "../types.js";
|
|
2
|
+
import { HerbDisableCommentBaseVisitor } from "./herb-disable-comment-base.js";
|
|
3
|
+
import { parseHerbDisableContent } from "../herb-disable-comment-utils.js";
|
|
4
|
+
class HerbDisableCommentMalformedVisitor extends HerbDisableCommentBaseVisitor {
|
|
5
|
+
checkHerbDisableComment(node, content) {
|
|
6
|
+
const trimmed = content.trim();
|
|
7
|
+
const looksLikeHerbDisable = trimmed.startsWith("herb:disable");
|
|
8
|
+
if (!looksLikeHerbDisable)
|
|
9
|
+
return;
|
|
10
|
+
if (trimmed.length > "herb:disable".length) {
|
|
11
|
+
const charAfterPrefix = trimmed["herb:disable".length];
|
|
12
|
+
if (charAfterPrefix !== ' ' && charAfterPrefix !== '\t' && charAfterPrefix !== '\n') {
|
|
13
|
+
this.addOffense("`herb:disable` comment is missing a space after `herb:disable`. Add a space before the rule names.", node.location);
|
|
14
|
+
return;
|
|
15
|
+
}
|
|
16
|
+
}
|
|
17
|
+
const afterPrefix = trimmed.substring("herb:disable".length).trim();
|
|
18
|
+
if (afterPrefix.length === 0)
|
|
19
|
+
return;
|
|
20
|
+
const parsed = parseHerbDisableContent(content);
|
|
21
|
+
if (parsed !== null)
|
|
22
|
+
return;
|
|
23
|
+
let message = "`herb:disable` comment is malformed.";
|
|
24
|
+
const rulesString = afterPrefix.trim();
|
|
25
|
+
if (rulesString.endsWith(',')) {
|
|
26
|
+
message = "`herb:disable` comment has a trailing comma. Remove the trailing comma.";
|
|
27
|
+
}
|
|
28
|
+
else if (rulesString.includes(',,') || rulesString.match(/,\s*,/)) {
|
|
29
|
+
message = "`herb:disable` comment has consecutive commas. Remove extra commas.";
|
|
30
|
+
}
|
|
31
|
+
else if (rulesString.startsWith(',')) {
|
|
32
|
+
message = "`herb:disable` comment starts with a comma. Remove the leading comma.";
|
|
33
|
+
}
|
|
34
|
+
this.addOffense(message, node.location);
|
|
35
|
+
}
|
|
36
|
+
}
|
|
37
|
+
export class HerbDisableCommentMalformedRule extends ParserRule {
|
|
38
|
+
name = "herb-disable-comment-malformed";
|
|
39
|
+
get defaultConfig() {
|
|
40
|
+
return {
|
|
41
|
+
enabled: true,
|
|
42
|
+
severity: "error"
|
|
43
|
+
};
|
|
44
|
+
}
|
|
45
|
+
check(result, context) {
|
|
46
|
+
const visitor = new HerbDisableCommentMalformedVisitor(this.name, context);
|
|
47
|
+
visitor.visit(result.value);
|
|
48
|
+
return visitor.offenses;
|
|
49
|
+
}
|
|
50
|
+
}
|
|
51
|
+
//# sourceMappingURL=herb-disable-comment-malformed.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"herb-disable-comment-malformed.js","sourceRoot":"","sources":["../../../src/rules/herb-disable-comment-malformed.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,6BAA6B,EAAE,MAAM,gCAAgC,CAAA;AAC9E,OAAO,EAAE,uBAAuB,EAAE,MAAM,kCAAkC,CAAA;AAK1E,MAAM,kCAAmC,SAAQ,6BAA6B;IAClE,uBAAuB,CAAC,IAAoB,EAAE,OAAe;QACrE,MAAM,OAAO,GAAG,OAAO,CAAC,IAAI,EAAE,CAAA;QAC9B,MAAM,oBAAoB,GAAG,OAAO,CAAC,UAAU,CAAC,cAAc,CAAC,CAAA;QAC/D,IAAI,CAAC,oBAAoB;YAAE,OAAM;QAEjC,IAAI,OAAO,CAAC,MAAM,GAAG,cAAc,CAAC,MAAM,EAAE,CAAC;YAC3C,MAAM,eAAe,GAAG,OAAO,CAAC,cAAc,CAAC,MAAM,CAAC,CAAA;YAEtD,IAAI,eAAe,KAAK,GAAG,IAAI,eAAe,KAAK,IAAI,IAAI,eAAe,KAAK,IAAI,EAAE,CAAC;gBACpF,IAAI,CAAC,UAAU,CACb,oGAAoG,EACpG,IAAI,CAAC,QAAQ,CACd,CAAA;gBAED,OAAM;YACR,CAAC;QACH,CAAC;QAED,MAAM,WAAW,GAAG,OAAO,CAAC,SAAS,CAAC,cAAc,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,CAAA;QACnE,IAAI,WAAW,CAAC,MAAM,KAAK,CAAC;YAAE,OAAM;QAEpC,MAAM,MAAM,GAAG,uBAAuB,CAAC,OAAO,CAAC,CAAA;QAC/C,IAAI,MAAM,KAAK,IAAI;YAAE,OAAM;QAE3B,IAAI,OAAO,GAAG,sCAAsC,CAAA;QAEpD,MAAM,WAAW,GAAG,WAAW,CAAC,IAAI,EAAE,CAAA;QAEtC,IAAI,WAAW,CAAC,QAAQ,CAAC,GAAG,CAAC,EAAE,CAAC;YAC9B,OAAO,GAAG,yEAAyE,CAAA;QACrF,CAAC;aAAM,IAAI,WAAW,CAAC,QAAQ,CAAC,IAAI,CAAC,IAAI,WAAW,CAAC,KAAK,CAAC,OAAO,CAAC,EAAE,CAAC;YACpE,OAAO,GAAG,qEAAqE,CAAA;QACjF,CAAC;aAAM,IAAI,WAAW,CAAC,UAAU,CAAC,GAAG,CAAC,EAAE,CAAC;YACvC,OAAO,GAAG,uEAAuE,CAAA;QACnF,CAAC;QAED,IAAI,CAAC,UAAU,CAAC,OAAO,EAAE,IAAI,CAAC,QAAQ,CAAC,CAAA;IACzC,CAAC;CACF;AAED,MAAM,OAAO,+BAAgC,SAAQ,UAAU;IAC7D,IAAI,GAAG,gCAAgC,CAAA;IAEvC,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,OAAO;SAClB,CAAA;IACH,CAAC;IAED,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,kCAAkC,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAE1E,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}
|