@herb-tools/linter 0.7.2 → 0.7.3

package/dist/src/rules/html-no-empty-attributes.js

@@ -1,5 +1,6 @@
 import { ParserRule } from "../types.js";
 import { AttributeVisitorMixin } from "./rule-utils.js";
+import { IdentityPrinter } from "@herb-tools/printer";
 // Attributes that must not have empty values
 const RESTRICTED_ATTRIBUTES = new Set([
     'id',
@@ -28,21 +29,30 @@ function isRestrictedAttribute(attributeName) {
     }
     return false;
 }
+function isDataAttribute(attributeName) {
+    return attributeName.startsWith('data-');
+}
 class NoEmptyAttributesVisitor extends AttributeVisitorMixin {
     checkStaticAttributeStaticValue({ attributeName, attributeValue, attributeNode }) {
-        if (!isRestrictedAttribute(attributeName))
-            return;
-        if (attributeValue.trim() !== "")
-            return;
-        this.addOffense(`Attribute \`${attributeName}\` must not be empty. Either provide a meaningful value or remove the attribute entirely.`, attributeNode.name.location, "warning");
+        this.checkEmptyAttribute(attributeName, attributeValue, attributeNode);
     }
     checkDynamicAttributeStaticValue({ combinedName, attributeValue, attributeNode }) {
         const name = (combinedName || "").toLowerCase();
-        if (!isRestrictedAttribute(name))
+        this.checkEmptyAttribute(name, attributeValue, attributeNode);
+    }
+    checkEmptyAttribute(attributeName, attributeValue, attributeNode) {
+        if (!isRestrictedAttribute(attributeName))
             return;
         if (attributeValue.trim() !== "")
             return;
-        this.addOffense(`Attribute \`${combinedName}\` must not be empty. Either provide a meaningful value or remove the attribute entirely.`, attributeNode.name.location, "warning");
+        const hasExplicitValue = attributeNode.value !== null;
+        if (isDataAttribute(attributeName)) {
+            if (hasExplicitValue) {
+                this.addOffense(`Data attribute \`${attributeName}\` should not have an empty value. Either provide a meaningful value or use \`${attributeName}\` instead of \`${IdentityPrinter.print(attributeNode)}\`.`, attributeNode.location, "warning");
+            }
+            return;
+        }
+        this.addOffense(`Attribute \`${attributeName}\` must not be empty. Either provide a meaningful value or remove the attribute entirely.`, attributeNode.location, "warning");
     }
 }
 export class HTMLNoEmptyAttributesRule extends ParserRule {

package/dist/src/rules/html-no-empty-attributes.js.map

@@ -1 +1 @@
-{"version":3,"file":"html-no-empty-attributes.js","sourceRoot":"","sources":["../../../src/rules/html-no-empty-attributes.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,qBAAqB,EAAuE,MAAM,iBAAiB,CAAA;AAK5H,6CAA6C;AAC7C,MAAM,qBAAqB,GAAG,IAAI,GAAG,CAAC;IACpC,IAAI;IACJ,OAAO;IACP,MAAM;IACN,KAAK;IACL,KAAK;IACL,MAAM;IACN,OAAO;IACP,MAAM;IACN,MAAM;CACP,CAAC,CAAA;AAEF,0DAA0D;AAC1D,SAAS,qBAAqB,CAAC,aAAqB;IAClD,uBAAuB;IACvB,IAAI,qBAAqB,CAAC,GAAG,CAAC,aAAa,CAAC,EAAE,CAAC;QAC7C,OAAO,IAAI,CAAA;IACb,CAAC;IAED,8BAA8B;IAC9B,IAAI,aAAa,CAAC,UAAU,CAAC,OAAO,CAAC,EAAE,CAAC;QACtC,OAAO,IAAI,CAAA;IACb,CAAC;IAED,8BAA8B;IAC9B,IAAI,aAAa,CAAC,UAAU,CAAC,OAAO,CAAC,EAAE,CAAC;QACtC,OAAO,IAAI,CAAA;IACb,CAAC;IAED,OAAO,KAAK,CAAA;AACd,CAAC;AAED,MAAM,wBAAyB,SAAQ,qBAAqB;IAChD,+BAA+B,CAAC,EAAE,aAAa,EAAE,cAAc,EAAE,aAAa,EAAoC;QAC1H,IAAI,CAAC,qBAAqB,CAAC,aAAa,CAAC;YAAE,OAAM;QACjD,IAAI,cAAc,CAAC,IAAI,EAAE,KAAK,EAAE;YAAE,OAAM;QAExC,IAAI,CAAC,UAAU,CACb,eAAe,aAAa,2FAA2F,EACvH,aAAa,CAAC,IAAK,CAAC,QAAQ,EAC5B,SAAS,CACV,CAAA;IACH,CAAC;IAES,gCAAgC,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,aAAa,EAAqC;QAC3H,MAAM,IAAI,GAAG,CAAC,YAAY,IAAI,EAAE,CAAC,CAAC,WAAW,EAAE,CAAA;QAC/C,IAAI,CAAC,qBAAqB,CAAC,IAAI,CAAC;YAAE,OAAM;QACxC,IAAI,cAAc,CAAC,IAAI,EAAE,KAAK,EAAE;YAAE,OAAM;QAExC,IAAI,CAAC,UAAU,CACb,eAAe,YAAY,2FAA2F,EACtH,aAAa,CAAC,IAAK,CAAC,QAAQ,EAC5B,SAAS,CACV,CAAA;IACH,CAAC;CACF;AAED,MAAM,OAAO,yBAA0B,SAAQ,UAAU;IACvD,IAAI,GAAG,0BAA0B,CAAA;IAEjC,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,wBAAwB,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAEhE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}
+{"version":3,"file":"html-no-empty-attributes.js","sourceRoot":"","sources":["../../../src/rules/html-no-empty-attributes.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,qBAAqB,EAAuE,MAAM,iBAAiB,CAAA;AAC5H,OAAO,EAAE,eAAe,EAAE,MAAM,qBAAqB,CAAA;AAKrD,6CAA6C;AAC7C,MAAM,qBAAqB,GAAG,IAAI,GAAG,CAAC;IACpC,IAAI;IACJ,OAAO;IACP,MAAM;IACN,KAAK;IACL,KAAK;IACL,MAAM;IACN,OAAO;IACP,MAAM;IACN,MAAM;CACP,CAAC,CAAA;AAEF,0DAA0D;AAC1D,SAAS,qBAAqB,CAAC,aAAqB;IAClD,uBAAuB;IACvB,IAAI,qBAAqB,CAAC,GAAG,CAAC,aAAa,CAAC,EAAE,CAAC;QAC7C,OAAO,IAAI,CAAA;IACb,CAAC;IAED,8BAA8B;IAC9B,IAAI,aAAa,CAAC,UAAU,CAAC,OAAO,CAAC,EAAE,CAAC;QACtC,OAAO,IAAI,CAAA;IACb,CAAC;IAED,8BAA8B;IAC9B,IAAI,aAAa,CAAC,UAAU,CAAC,OAAO,CAAC,EAAE,CAAC;QACtC,OAAO,IAAI,CAAA;IACb,CAAC;IAED,OAAO,KAAK,CAAA;AACd,CAAC;AAED,SAAS,eAAe,CAAC,aAAqB;IAC5C,OAAO,aAAa,CAAC,UAAU,CAAC,OAAO,CAAC,CAAA;AAC1C,CAAC;AAED,MAAM,wBAAyB,SAAQ,qBAAqB;IAChD,+BAA+B,CAAC,EAAE,aAAa,EAAE,cAAc,EAAE,aAAa,EAAoC;QAC1H,IAAI,CAAC,mBAAmB,CAAC,aAAa,EAAE,cAAc,EAAE,aAAa,CAAC,CAAA;IACxE,CAAC;IAES,gCAAgC,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,aAAa,EAAqC;QAC3H,MAAM,IAAI,GAAG,CAAC,YAAY,IAAI,EAAE,CAAC,CAAC,WAAW,EAAE,CAAA;QAC/C,IAAI,CAAC,mBAAmB,CAAC,IAAI,EAAE,cAAc,EAAE,aAAa,CAAC,CAAA;IAC/D,CAAC;IAEO,mBAAmB,CAAC,aAAqB,EAAE,cAAsB,EAAE,aAAgC;QACzG,IAAI,CAAC,qBAAqB,CAAC,aAAa,CAAC;YAAE,OAAM;QACjD,IAAI,cAAc,CAAC,IAAI,EAAE,KAAK,EAAE;YAAE,OAAM;QAExC,MAAM,gBAAgB,GAAG,aAAa,CAAC,KAAK,KAAK,IAAI,CAAA;QAErD,IAAI,eAAe,CAAC,aAAa,CAAC,EAAE,CAAC;YACnC,IAAI,gBAAgB,EAAE,CAAC;gBACrB,IAAI,CAAC,UAAU,CACb,oBAAoB,aAAa,iFAAiF,aAAa,mBAAmB,eAAe,CAAC,KAAK,CAAC,aAAa,CAAC,KAAK,EAC3L,aAAa,CAAC,QAAQ,EACtB,SAAS,CACV,CAAA;YACH,CAAC;YAED,OAAM;QACR,CAAC;QAED,IAAI,CAAC,UAAU,CACb,eAAe,aAAa,2FAA2F,EACvH,aAAa,CAAC,QAAQ,EACtB,SAAS,CACV,CAAA;IACH,CAAC;CACF;AAED,MAAM,OAAO,yBAA0B,SAAQ,UAAU;IACvD,IAAI,GAAG,0BAA0B,CAAA;IAEjC,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,wBAAwB,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAEhE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@herb-tools/linter",
-  "version": "0.7.2",
+  "version": "0.7.3",
   "description": "HTML+ERB linter for validating HTML structure and enforcing best practices",
   "license": "MIT",
   "homepage": "https://herb-tools.dev",
@@ -39,10 +39,10 @@
     }
   },
   "dependencies": {
-    "@herb-tools/core": "0.7.2",
-    "@herb-tools/highlighter": "0.7.2",
-    "@herb-tools/node-wasm": "0.7.2",
-    "@herb-tools/printer": "0.7.2",
+    "@herb-tools/core": "0.7.3",
+    "@herb-tools/highlighter": "0.7.3",
+    "@herb-tools/node-wasm": "0.7.3",
+    "@herb-tools/printer": "0.7.3",
     "glob": "^11.0.3"
   },
   "files": [

package/src/rules/html-no-empty-attributes.ts

@@ -1,8 +1,9 @@
 import { ParserRule } from "../types.js"
 import { AttributeVisitorMixin, StaticAttributeStaticValueParams, DynamicAttributeStaticValueParams } from "./rule-utils.js"
+import { IdentityPrinter } from "@herb-tools/printer"
 
 import type { LintOffense, LintContext } from "../types.js"
-import type { ParseResult } from "@herb-tools/core"
+import type { ParseResult, HTMLAttributeNode } from "@herb-tools/core"
 
 // Attributes that must not have empty values
 const RESTRICTED_ATTRIBUTES = new Set([
@@ -37,26 +38,41 @@ function isRestrictedAttribute(attributeName: string): boolean {
   return false
 }
 
+function isDataAttribute(attributeName: string): boolean {
+  return attributeName.startsWith('data-')
+}
+
 class NoEmptyAttributesVisitor extends AttributeVisitorMixin {
   protected checkStaticAttributeStaticValue({ attributeName, attributeValue, attributeNode }: StaticAttributeStaticValueParams): void {
-    if (!isRestrictedAttribute(attributeName)) return
-    if (attributeValue.trim() !== "") return
-
-    this.addOffense(
-      `Attribute \`${attributeName}\` must not be empty. Either provide a meaningful value or remove the attribute entirely.`,
-      attributeNode.name!.location,
-      "warning"
-    )
+    this.checkEmptyAttribute(attributeName, attributeValue, attributeNode)
   }
 
   protected checkDynamicAttributeStaticValue({ combinedName, attributeValue, attributeNode }: DynamicAttributeStaticValueParams): void {
     const name = (combinedName || "").toLowerCase()
-    if (!isRestrictedAttribute(name)) return
+    this.checkEmptyAttribute(name, attributeValue, attributeNode)
+  }
+
+  private checkEmptyAttribute(attributeName: string, attributeValue: string, attributeNode: HTMLAttributeNode): void {
+    if (!isRestrictedAttribute(attributeName)) return
     if (attributeValue.trim() !== "") return
 
+    const hasExplicitValue = attributeNode.value !== null
+
+    if (isDataAttribute(attributeName)) {
+      if (hasExplicitValue) {
+        this.addOffense(
+          `Data attribute \`${attributeName}\` should not have an empty value. Either provide a meaningful value or use \`${attributeName}\` instead of \`${IdentityPrinter.print(attributeNode)}\`.`,
+          attributeNode.location,
+          "warning"
+        )
+      }
+
+      return
+    }
+
     this.addOffense(
-      `Attribute \`${combinedName}\` must not be empty. Either provide a meaningful value or remove the attribute entirely.`,
-      attributeNode.name!.location,
+      `Attribute \`${attributeName}\` must not be empty. Either provide a meaningful value or remove the attribute entirely.`,
+      attributeNode.location,
       "warning"
     )
   }