@herb-tools/linter 0.6.0 → 0.7.0

package/dist/src/rules/erb-prefer-image-tag-helper.js

@@ -1,81 +1,71 @@
-import { BaseRuleVisitor, getTagName, findAttributeByName, getAttributes } from "./rule-utils.js";
 import { ParserRule } from "../types.js";
+import { BaseRuleVisitor, getTagName, findAttributeByName, getAttributes } from "./rule-utils.js";
+import { ERBToRubyStringPrinter } from "@herb-tools/printer";
+import { filterNodes, ERBContentNode, LiteralNode, isNode } from "@herb-tools/core";
 class ERBPreferImageTagHelperVisitor extends BaseRuleVisitor {
     visitHTMLOpenTagNode(node) {
         this.checkImgTag(node);
         super.visitHTMLOpenTagNode(node);
     }
-    checkImgTag(node) {
-        const tagName = getTagName(node);
-        if (tagName !== "img") {
+    checkImgTag(openTag) {
+        const tagName = getTagName(openTag);
+        if (tagName !== "img")
             return;
-        }
-        const attributes = getAttributes(node);
+        const attributes = getAttributes(openTag);
         const srcAttribute = findAttributeByName(attributes, "src");
-        if (!srcAttribute) {
+        if (!srcAttribute)
             return;
-        }
-        if (!srcAttribute.value) {
+        if (!srcAttribute.value)
             return;
-        }
-        const valueNode = srcAttribute.value;
-        const hasERBContent = this.containsERBContent(valueNode);
+        const node = srcAttribute.value;
+        const hasERBContent = this.containsERBContent(node);
         if (hasERBContent) {
-            const suggestedExpression = this.buildSuggestedExpression(valueNode);
-            this.addOffense(`Prefer \`image_tag\` helper over manual \`<img>\` with dynamic ERB expressions. Use \`<%= image_tag ${suggestedExpression}, alt: "..." %>\` instead.`, srcAttribute.location, "warning");
+            if (this.isDataUri(node))
+                return;
+            if (this.shouldFlagAsImageTagCandidate(node)) {
+                const suggestedExpression = this.buildSuggestedExpression(node);
+                this.addOffense(`Prefer \`image_tag\` helper over manual \`<img>\` with dynamic ERB expressions. Use \`<%= image_tag ${suggestedExpression}, alt: "..." %>\` instead.`, srcAttribute.location, "warning");
+            }
+        }
+    }
+    containsERBContent(node) {
+        return filterNodes(node.children, ERBContentNode).length > 0;
+    }
+    isOnlyERBContent(node) {
+        return node.children.length > 0 && node.children.length === filterNodes(node.children, ERBContentNode).length;
+    }
+    getContentofFirstChild(node) {
+        if (!node.children || node.children.length === 0)
+            return "";
+        const firstChild = node.children[0];
+        if (isNode(firstChild, LiteralNode)) {
+            return (firstChild.content || "").trim();
         }
+        return "";
     }
-    containsERBContent(valueNode) {
-        if (!valueNode.children)
+    isDataUri(node) {
+        return this.getContentofFirstChild(node).startsWith("data:");
+    }
+    isFullUrl(node) {
+        const content = this.getContentofFirstChild(node);
+        return content.startsWith("http://") || content.startsWith("https://");
+    }
+    shouldFlagAsImageTagCandidate(node) {
+        if (this.isOnlyERBContent(node))
+            return true;
+        if (this.isFullUrl(node))
             return false;
-        return valueNode.children.some(child => child.type === "AST_ERB_CONTENT_NODE");
+        return true;
     }
-    buildSuggestedExpression(valueNode) {
-        if (!valueNode.children)
+    buildSuggestedExpression(node) {
+        if (!node.children)
             return "expression";
-        let hasText = false;
-        let hasERB = false;
-        for (const child of valueNode.children) {
-            if (child.type === "AST_ERB_CONTENT_NODE") {
-                hasERB = true;
-            }
-            else if (child.type === "AST_LITERAL_NODE") {
-                const literalNode = child;
-                if (literalNode.content && literalNode.content.trim()) {
-                    hasText = true;
-                }
-            }
+        try {
+            return ERBToRubyStringPrinter.print(node, { ignoreErrors: false });
         }
-        if (hasText && hasERB) {
-            let result = '"';
-            for (const child of valueNode.children) {
-                if (child.type === "AST_ERB_CONTENT_NODE") {
-                    const erbNode = child;
-                    result += `#{${(erbNode.content?.value || "").trim()}}`;
-                }
-                else if (child.type === "AST_LITERAL_NODE") {
-                    const literalNode = child;
-                    result += literalNode.content || "";
-                }
-            }
-            result += '"';
-            return result;
-        }
-        if (hasERB && !hasText) {
-            const erbNodes = valueNode.children.filter(child => child.type === "AST_ERB_CONTENT_NODE");
-            if (erbNodes.length === 1) {
-                return (erbNodes[0].content?.value || "").trim();
-            }
-            else if (erbNodes.length > 1) {
-                let result = '"';
-                for (const erbNode of erbNodes) {
-                    result += `#{${(erbNode.content?.value || "").trim()}}`;
-                }
-                result += '"';
-                return result;
-            }
+        catch {
+            return "expression";
         }
-        return "expression";
     }
 }
 export class ERBPreferImageTagHelperRule extends ParserRule {

package/dist/src/rules/erb-prefer-image-tag-helper.js.map

@@ -1 +1 @@
-{"version":3,"file":"erb-prefer-image-tag-helper.js","sourceRoot":"","sources":["../../../src/rules/erb-prefer-image-tag-helper.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,eAAe,EAAE,UAAU,EAAE,mBAAmB,EAAE,aAAa,EAAE,MAAM,iBAAiB,CAAA;AAEjG,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AAIxC,MAAM,8BAA+B,SAAQ,eAAe;IAC1D,oBAAoB,CAAC,IAAqB;QACxC,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,CAAA;QACtB,KAAK,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAA;IAClC,CAAC;IAEO,WAAW,CAAC,IAAqB;QACvC,MAAM,OAAO,GAAG,UAAU,CAAC,IAAI,CAAC,CAAA;QAEhC,IAAI,OAAO,KAAK,KAAK,EAAE,CAAC;YACtB,OAAM;QACR,CAAC;QAED,MAAM,UAAU,GAAG,aAAa,CAAC,IAAI,CAAC,CAAA;QACtC,MAAM,YAAY,GAAG,mBAAmB,CAAC,UAAU,EAAE,KAAK,CAAC,CAAA;QAE3D,IAAI,CAAC,YAAY,EAAE,CAAC;YAClB,OAAM;QACR,CAAC;QAED,IAAI,CAAC,YAAY,CAAC,KAAK,EAAE,CAAC;YACxB,OAAM;QACR,CAAC;QAED,MAAM,SAAS,GAAG,YAAY,CAAC,KAA+B,CAAA;QAC9D,MAAM,aAAa,GAAG,IAAI,CAAC,kBAAkB,CAAC,SAAS,CAAC,CAAA;QAExD,IAAI,aAAa,EAAE,CAAC;YAClB,MAAM,mBAAmB,GAAG,IAAI,CAAC,wBAAwB,CAAC,SAAS,CAAC,CAAA;YAEpE,IAAI,CAAC,UAAU,CACb,uGAAuG,mBAAmB,4BAA4B,EACtJ,YAAY,CAAC,QAAQ,EACrB,SAAS,CACV,CAAA;QACH,CAAC;IACH,CAAC;IAEO,kBAAkB,CAAC,SAAiC;QAC1D,IAAI,CAAC,SAAS,CAAC,QAAQ;YAAE,OAAO,KAAK,CAAA;QAErC,OAAO,SAAS,CAAC,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC,KAAK,CAAC,IAAI,KAAK,sBAAsB,CAAC,CAAA;IAChF,CAAC;IAEO,wBAAwB,CAAC,SAAiC;QAChE,IAAI,CAAC,SAAS,CAAC,QAAQ;YAAE,OAAO,YAAY,CAAA;QAE5C,IAAI,OAAO,GAAG,KAAK,CAAA;QACnB,IAAI,MAAM,GAAG,KAAK,CAAA;QAElB,KAAK,MAAM,KAAK,IAAI,SAAS,CAAC,QAAQ,EAAE,CAAC;YACvC,IAAI,KAAK,CAAC,IAAI,KAAK,sBAAsB,EAAE,CAAC;gBAC1C,MAAM,GAAG,IAAI,CAAA;YACf,CAAC;iBAAM,IAAI,KAAK,CAAC,IAAI,KAAK,kBAAkB,EAAE,CAAC;gBAC7C,MAAM,WAAW,GAAG,KAAoB,CAAA;gBAExC,IAAI,WAAW,CAAC,OAAO,IAAI,WAAW,CAAC,OAAO,CAAC,IAAI,EAAE,EAAE,CAAC;oBACtD,OAAO,GAAG,IAAI,CAAA;gBAChB,CAAC;YACH,CAAC;QACH,CAAC;QAED,IAAI,OAAO,IAAI,MAAM,EAAE,CAAC;YACtB,IAAI,MAAM,GAAG,GAAG,CAAA;YAEhB,KAAK,MAAM,KAAK,IAAI,SAAS,CAAC,QAAQ,EAAE,CAAC;gBACvC,IAAI,KAAK,CAAC,IAAI,KAAK,sBAAsB,EAAE,CAAC;oBAC1C,MAAM,OAAO,GAAG,KAAuB,CAAA;oBAEvC,MAAM,IAAI,KAAK,CAAC,OAAO,CAAC,OAAO,EAAE,KAAK,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,GAAG,CAAA;gBACzD,CAAC;qBAAM,IAAI,KAAK,CAAC,IAAI,KAAK,kBAAkB,EAAE,CAAC;oBAC7C,MAAM,WAAW,GAAG,KAAoB,CAAA;oBAExC,MAAM,IAAI,WAAW,CAAC,OAAO,IAAI,EAAE,CAAA;gBACrC,CAAC;YACH,CAAC;YAED,MAAM,IAAI,GAAG,CAAA;YAEb,OAAO,MAAM,CAAA;QACf,CAAC;QAED,IAAI,MAAM,IAAI,CAAC,OAAO,EAAE,CAAC;YACvB,MAAM,QAAQ,GAAG,SAAS,CAAC,QAAQ,CAAC,MAAM,CAAC,KAAK,CAAC,EAAE,CAAC,KAAK,CAAC,IAAI,KAAK,sBAAsB,CAAqB,CAAA;YAE9G,IAAI,QAAQ,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;gBAC1B,OAAO,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,OAAO,EAAE,KAAK,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,CAAA;YAClD,CAAC;iBAAM,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;gBAC/B,IAAI,MAAM,GAAG,GAAG,CAAA;gBAEhB,KAAK,MAAM,OAAO,IAAI,QAAQ,EAAE,CAAC;oBAC/B,MAAM,IAAI,KAAK,CAAC,OAAO,CAAC,OAAO,EAAE,KAAK,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,GAAG,CAAA;gBACzD,CAAC;gBAED,MAAM,IAAI,GAAG,CAAA;gBAEb,OAAO,MAAM,CAAA;YACf,CAAC;QACH,CAAC;QAED,OAAO,YAAY,CAAA;IACrB,CAAC;CACF;AAED,MAAM,OAAO,2BAA4B,SAAQ,UAAU;IACzD,IAAI,GAAG,6BAA6B,CAAA;IAEpC,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,8BAA8B,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QACtE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAC3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}
+{"version":3,"file":"erb-prefer-image-tag-helper.js","sourceRoot":"","sources":["../../../src/rules/erb-prefer-image-tag-helper.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,eAAe,EAAE,UAAU,EAAE,mBAAmB,EAAE,aAAa,EAAE,MAAM,iBAAiB,CAAA;AAEjG,OAAO,EAAE,sBAAsB,EAAE,MAAM,qBAAqB,CAAA;AAC5D,OAAO,EAAE,WAAW,EAAE,cAAc,EAAE,WAAW,EAAE,MAAM,EAAE,MAAM,kBAAkB,CAAA;AAKnF,MAAM,8BAA+B,SAAQ,eAAe;IAC1D,oBAAoB,CAAC,IAAqB;QACxC,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,CAAA;QACtB,KAAK,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAA;IAClC,CAAC;IAEO,WAAW,CAAC,OAAwB;QAC1C,MAAM,OAAO,GAAG,UAAU,CAAC,OAAO,CAAC,CAAA;QAEnC,IAAI,OAAO,KAAK,KAAK;YAAE,OAAM;QAE7B,MAAM,UAAU,GAAG,aAAa,CAAC,OAAO,CAAC,CAAA;QACzC,MAAM,YAAY,GAAG,mBAAmB,CAAC,UAAU,EAAE,KAAK,CAAC,CAAA;QAE3D,IAAI,CAAC,YAAY;YAAE,OAAM;QACzB,IAAI,CAAC,YAAY,CAAC,KAAK;YAAE,OAAM;QAE/B,MAAM,IAAI,GAAG,YAAY,CAAC,KAAK,CAAA;QAC/B,MAAM,aAAa,GAAG,IAAI,CAAC,kBAAkB,CAAC,IAAI,CAAC,CAAA;QAEnD,IAAI,aAAa,EAAE,CAAC;YAClB,IAAI,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC;gBAAE,OAAM;YAEhC,IAAI,IAAI,CAAC,6BAA6B,CAAC,IAAI,CAAC,EAAE,CAAC;gBAC7C,MAAM,mBAAmB,GAAG,IAAI,CAAC,wBAAwB,CAAC,IAAI,CAAC,CAAA;gBAE/D,IAAI,CAAC,UAAU,CACb,uGAAuG,mBAAmB,4BAA4B,EACtJ,YAAY,CAAC,QAAQ,EACrB,SAAS,CACV,CAAA;YACH,CAAC;QACH,CAAC;IACH,CAAC;IAEO,kBAAkB,CAAC,IAA4B;QACrD,OAAO,WAAW,CAAC,IAAI,CAAC,QAAQ,EAAE,cAAc,CAAC,CAAC,MAAM,GAAG,CAAC,CAAA;IAC9D,CAAC;IAEO,gBAAgB,CAAC,IAA4B;QACnD,OAAO,IAAI,CAAC,QAAQ,CAAC,MAAM,GAAG,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,MAAM,KAAK,WAAW,CAAC,IAAI,CAAC,QAAQ,EAAE,cAAc,CAAC,CAAC,MAAM,CAAA;IAC/G,CAAC;IAEO,sBAAsB,CAAC,IAA4B;QACzD,IAAI,CAAC,IAAI,CAAC,QAAQ,IAAI,IAAI,CAAC,QAAQ,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,EAAE,CAAA;QAE3D,MAAM,UAAU,GAAG,IAAI,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAA;QAEnC,IAAI,MAAM,CAAC,UAAU,EAAE,WAAW,CAAC,EAAE,CAAC;YACpC,OAAO,CAAC,UAAU,CAAC,OAAO,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,CAAA;QAC1C,CAAC;QAED,OAAO,EAAE,CAAA;IACX,CAAC;IAEO,SAAS,CAAC,IAA4B;QAC5C,OAAO,IAAI,CAAC,sBAAsB,CAAC,IAAI,CAAC,CAAC,UAAU,CAAC,OAAO,CAAC,CAAA;IAC9D,CAAC;IAEO,SAAS,CAAC,IAA4B;QAC5C,MAAM,OAAO,GAAG,IAAI,CAAC,sBAAsB,CAAC,IAAI,CAAC,CAAA;QAEjD,OAAO,OAAO,CAAC,UAAU,CAAC,SAAS,CAAC,IAAI,OAAO,CAAC,UAAU,CAAC,UAAU,CAAC,CAAA;IACxE,CAAC;IAEO,6BAA6B,CAAC,IAA4B;QAChE,IAAI,IAAI,CAAC,gBAAgB,CAAC,IAAI,CAAC;YAAE,OAAO,IAAI,CAAA;QAC5C,IAAI,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC;YAAE,OAAO,KAAK,CAAA;QAEtC,OAAO,IAAI,CAAA;IACb,CAAC;IAEO,wBAAwB,CAAC,IAA4B;QAC3D,IAAI,CAAC,IAAI,CAAC,QAAQ;YAAE,OAAO,YAAY,CAAA;QAEvC,IAAI,CAAC;YACH,OAAO,sBAAsB,CAAC,KAAK,CAAC,IAAI,EAAE,EAAE,YAAY,EAAE,KAAK,EAAE,CAAC,CAAA;QACpE,CAAC;QAAC,MAAM,CAAC;YACP,OAAO,YAAY,CAAA;QACrB,CAAC;IACH,CAAC;CACF;AAED,MAAM,OAAO,2BAA4B,SAAQ,UAAU;IACzD,IAAI,GAAG,6BAA6B,CAAA;IAEpC,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,8BAA8B,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QACtE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAC3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}

package/dist/src/rules/html-boolean-attributes-no-value.js

@@ -1,19 +1,19 @@
 import { ParserRule } from "../types.js";
 import { AttributeVisitorMixin, isBooleanAttribute, hasAttributeValue } from "./rule-utils.js";
+import { IdentityPrinter } from "@herb-tools/printer";
 class BooleanAttributesNoValueVisitor extends AttributeVisitorMixin {
-    checkStaticAttributeStaticValue({ attributeName, attributeNode }) {
-        if (!isBooleanAttribute(attributeName))
-            return;
-        if (!hasAttributeValue(attributeNode))
-            return;
-        this.addOffense(`Boolean attribute \`${attributeName}\` should not have a value. Use \`${attributeName}\` instead of \`${attributeName}="${attributeName}"\`.`, attributeNode.value.location, "error");
+    checkStaticAttributeStaticValue({ originalAttributeName, attributeNode }) {
+        this.checkAttribute(originalAttributeName, attributeNode);
+    }
+    checkStaticAttributeDynamicValue({ originalAttributeName, attributeNode }) {
+        this.checkAttribute(originalAttributeName, attributeNode);
     }
-    checkStaticAttributeDynamicValue({ attributeName, attributeNode, combinedValue }) {
+    checkAttribute(attributeName, attributeNode) {
         if (!isBooleanAttribute(attributeName))
             return;
         if (!hasAttributeValue(attributeNode))
             return;
-        this.addOffense(`Boolean attribute \`${attributeName}\` should not have a value. Use \`${attributeName}\` instead of \`${attributeName}="${combinedValue}"\`.`, attributeNode.value.location, "error");
+        this.addOffense(`Boolean attribute \`${IdentityPrinter.print(attributeNode.name)}\` should not have a value. Use \`${attributeName.toLowerCase()}\` instead of \`${IdentityPrinter.print(attributeNode)}\`.`, attributeNode.value.location, "error");
     }
 }
 export class HTMLBooleanAttributesNoValueRule extends ParserRule {

package/dist/src/rules/html-boolean-attributes-no-value.js.map

@@ -1 +1 @@
-{"version":3,"file":"html-boolean-attributes-no-value.js","sourceRoot":"","sources":["../../../src/rules/html-boolean-attributes-no-value.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,qBAAqB,EAAuE,kBAAkB,EAAE,iBAAiB,EAAE,MAAM,iBAAiB,CAAA;AAKnK,MAAM,+BAAgC,SAAQ,qBAAqB;IACvD,+BAA+B,CAAC,EAAE,aAAa,EAAE,aAAa,EAAoC;QAC1G,IAAI,CAAC,kBAAkB,CAAC,aAAa,CAAC;YAAE,OAAM;QAC9C,IAAI,CAAC,iBAAiB,CAAC,aAAa,CAAC;YAAE,OAAM;QAE7C,IAAI,CAAC,UAAU,CACb,uBAAuB,aAAa,qCAAqC,aAAa,mBAAmB,aAAa,KAAK,aAAa,MAAM,EAC9I,aAAa,CAAC,KAAM,CAAC,QAAQ,EAC7B,OAAO,CACR,CAAA;IACH,CAAC;IAES,gCAAgC,CAAC,EAAE,aAAa,EAAE,aAAa,EAAE,aAAa,EAAqC;QAC3H,IAAI,CAAC,kBAAkB,CAAC,aAAa,CAAC;YAAE,OAAM;QAC9C,IAAI,CAAC,iBAAiB,CAAC,aAAa,CAAC;YAAE,OAAM;QAE7C,IAAI,CAAC,UAAU,CACb,uBAAuB,aAAa,qCAAqC,aAAa,mBAAmB,aAAa,KAAK,aAAa,MAAM,EAC9I,aAAa,CAAC,KAAM,CAAC,QAAQ,EAC7B,OAAO,CACR,CAAA;IACH,CAAC;CACF;AAED,MAAM,OAAO,gCAAiC,SAAQ,UAAU;IAC9D,IAAI,GAAG,kCAAkC,CAAA;IAEzC,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,+BAA+B,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAEvE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}
+{"version":3,"file":"html-boolean-attributes-no-value.js","sourceRoot":"","sources":["../../../src/rules/html-boolean-attributes-no-value.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,qBAAqB,EAAuE,kBAAkB,EAAE,iBAAiB,EAAE,MAAM,iBAAiB,CAAA;AACnK,OAAO,EAAE,eAAe,EAAE,MAAM,qBAAqB,CAAA;AAKrD,MAAM,+BAAgC,SAAQ,qBAAqB;IACvD,+BAA+B,CAAC,EAAE,qBAAqB,EAAE,aAAa,EAAoC;QAClH,IAAI,CAAC,cAAc,CAAC,qBAAqB,EAAE,aAAa,CAAC,CAAA;IAC3D,CAAC;IAES,gCAAgC,CAAC,EAAE,qBAAqB,EAAE,aAAa,EAAqC;QACpH,IAAI,CAAC,cAAc,CAAC,qBAAqB,EAAE,aAAa,CAAC,CAAA;IAC3D,CAAC;IAEO,cAAc,CAAC,aAAqB,EAAE,aAAgC;QAC5E,IAAI,CAAC,kBAAkB,CAAC,aAAa,CAAC;YAAE,OAAM;QAC9C,IAAI,CAAC,iBAAiB,CAAC,aAAa,CAAC;YAAE,OAAM;QAE7C,IAAI,CAAC,UAAU,CACb,uBAAuB,eAAe,CAAC,KAAK,CAAC,aAAa,CAAC,IAAI,CAAC,qCAAqC,aAAa,CAAC,WAAW,EAAE,mBAAmB,eAAe,CAAC,KAAK,CAAC,aAAa,CAAC,KAAK,EAC5L,aAAa,CAAC,KAAM,CAAC,QAAQ,EAC7B,OAAO,CACR,CAAA;IACH,CAAC;CACF;AAED,MAAM,OAAO,gCAAiC,SAAQ,UAAU;IAC9D,IAAI,GAAG,kCAAkC,CAAA;IAEzC,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,+BAA+B,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAEvE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}

package/dist/src/rules/html-no-duplicate-ids.js

@@ -1,18 +1,143 @@
 import { ParserRule } from "../types";
-import { AttributeVisitorMixin } from "./rule-utils";
-class NoDuplicateIdsVisitor extends AttributeVisitorMixin {
+import { ControlFlowTrackingVisitor, ControlFlowType } from "./rule-utils";
+import { LiteralNode } from "@herb-tools/core";
+import { Printer, IdentityPrinter } from "@herb-tools/printer";
+import { hasERBOutput, getValidatableStaticContent, isEffectivelyStatic, isNode, getStaticAttributeName, isERBOutputNode } from "@herb-tools/core";
+class OutputPrinter extends Printer {
+    visitLiteralNode(node) {
+        this.write(IdentityPrinter.print(node));
+    }
+    visitERBContentNode(node) {
+        if (isERBOutputNode(node)) {
+            this.write(IdentityPrinter.print(node));
+        }
+    }
+}
+class NoDuplicateIdsVisitor extends ControlFlowTrackingVisitor {
     documentIds = new Set();
-    checkStaticAttributeStaticValue({ attributeName, attributeValue, attributeNode }) {
-        if (attributeName.toLowerCase() !== "id")
+    currentBranchIds = new Set();
+    controlFlowIds = new Set();
+    visitHTMLAttributeNode(node) {
+        this.checkAttribute(node);
+    }
+    onEnterControlFlow(_controlFlowType, wasAlreadyInControlFlow) {
+        const stateToRestore = {
+            previousBranchIds: this.currentBranchIds,
+            previousControlFlowIds: this.controlFlowIds
+        };
+        this.currentBranchIds = new Set();
+        if (!wasAlreadyInControlFlow) {
+            this.controlFlowIds = new Set();
+        }
+        return stateToRestore;
+    }
+    onExitControlFlow(controlFlowType, wasAlreadyInControlFlow, stateToRestore) {
+        if (controlFlowType === ControlFlowType.CONDITIONAL && !wasAlreadyInControlFlow) {
+            this.controlFlowIds.forEach(id => this.documentIds.add(id));
+        }
+        this.currentBranchIds = stateToRestore.previousBranchIds;
+        this.controlFlowIds = stateToRestore.previousControlFlowIds;
+    }
+    onEnterBranch() {
+        const stateToRestore = {
+            previousBranchIds: this.currentBranchIds
+        };
+        if (this.isInControlFlow) {
+            this.currentBranchIds = new Set();
+        }
+        return stateToRestore;
+    }
+    onExitBranch(_stateToRestore) { }
+    checkAttribute(attributeNode) {
+        if (!this.isIdAttribute(attributeNode))
             return;
-        if (!attributeValue)
+        const idValue = this.extractIdValue(attributeNode);
+        if (!idValue)
             return;
-        const id = attributeValue.trim();
-        if (this.documentIds.has(id)) {
-            this.addOffense(`Duplicate ID \`${id}\` found. IDs must be unique within a document.`, attributeNode.location, "error");
+        if (this.isWhitespaceOnlyId(idValue.identifier))
             return;
+        this.processIdDuplicate(idValue, attributeNode);
+    }
+    isIdAttribute(attributeNode) {
+        if (!attributeNode.name?.children || !attributeNode.value)
+            return false;
+        return getStaticAttributeName(attributeNode.name) === "id";
+    }
+    extractIdValue(attributeNode) {
+        const valueNodes = attributeNode.value?.children || [];
+        if (hasERBOutput(valueNodes) && this.isInControlFlow && this.currentControlFlowType === ControlFlowType.LOOP) {
+            return null;
         }
-        this.documentIds.add(id);
+        const identifier = isEffectivelyStatic(valueNodes) ? getValidatableStaticContent(valueNodes) : OutputPrinter.print(valueNodes);
+        if (!identifier)
+            return null;
+        return { identifier, shouldTrackDuplicates: true };
+    }
+    isWhitespaceOnlyId(identifier) {
+        return identifier !== '' && identifier.trim() === '';
+    }
+    processIdDuplicate(idValue, attributeNode) {
+        const { identifier, shouldTrackDuplicates } = idValue;
+        if (!shouldTrackDuplicates)
+            return;
+        if (this.isInControlFlow) {
+            this.handleControlFlowId(identifier, attributeNode);
+        }
+        else {
+            this.handleGlobalId(identifier, attributeNode);
+        }
+    }
+    handleControlFlowId(identifier, attributeNode) {
+        if (this.currentControlFlowType === ControlFlowType.LOOP) {
+            this.handleLoopId(identifier, attributeNode);
+        }
+        else {
+            this.handleConditionalId(identifier, attributeNode);
+        }
+        this.currentBranchIds.add(identifier);
+    }
+    handleLoopId(identifier, attributeNode) {
+        const isStaticId = this.isStaticId(attributeNode);
+        if (isStaticId) {
+            this.addDuplicateIdOffense(identifier, attributeNode.location);
+            return;
+        }
+        if (this.currentBranchIds.has(identifier)) {
+            this.addSameLoopIterationOffense(identifier, attributeNode.location);
+        }
+    }
+    handleConditionalId(identifier, attributeNode) {
+        if (this.currentBranchIds.has(identifier)) {
+            this.addSameBranchOffense(identifier, attributeNode.location);
+            return;
+        }
+        if (this.documentIds.has(identifier)) {
+            this.addDuplicateIdOffense(identifier, attributeNode.location);
+            return;
+        }
+        this.controlFlowIds.add(identifier);
+    }
+    handleGlobalId(identifier, attributeNode) {
+        if (this.documentIds.has(identifier)) {
+            this.addDuplicateIdOffense(identifier, attributeNode.location);
+            return;
+        }
+        this.documentIds.add(identifier);
+    }
+    isStaticId(attributeNode) {
+        const valueNodes = attributeNode.value.children;
+        const isCompletelyStatic = valueNodes.every(child => isNode(child, LiteralNode));
+        const isEffectivelyStaticValue = isEffectivelyStatic(valueNodes);
+        return isCompletelyStatic || isEffectivelyStaticValue;
+    }
+    addDuplicateIdOffense(identifier, location) {
+        this.addOffense(`Duplicate ID \`${identifier}\` found. IDs must be unique within a document.`, location, "error");
+    }
+    addSameLoopIterationOffense(identifier, location) {
+        this.addOffense(`Duplicate ID \`${identifier}\` found within the same loop iteration. IDs must be unique within the same loop iteration.`, location, "error");
+    }
+    addSameBranchOffense(identifier, location) {
+        this.addOffense(`Duplicate ID \`${identifier}\` found within the same control flow branch. IDs must be unique within the same control flow branch.`, location, "error");
     }
 }
 export class HTMLNoDuplicateIdsRule extends ParserRule {

package/dist/src/rules/html-no-duplicate-ids.js.map

@@ -1 +1 @@
-{"version":3,"file":"html-no-duplicate-ids.js","sourceRoot":"","sources":["../../../src/rules/html-no-duplicate-ids.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAA;AACrC,OAAO,EAAE,qBAAqB,EAAoC,MAAM,cAAc,CAAA;AAKtF,MAAM,qBAAsB,SAAQ,qBAAqB;IAC/C,WAAW,GAAgB,IAAI,GAAG,EAAU,CAAA;IAE1C,+BAA+B,CAAC,EAAE,aAAa,EAAE,cAAc,EAAE,aAAa,EAAoC;QAC1H,IAAI,aAAa,CAAC,WAAW,EAAE,KAAK,IAAI;YAAE,OAAM;QAChD,IAAI,CAAC,cAAc;YAAE,OAAM;QAE3B,MAAM,EAAE,GAAG,cAAc,CAAC,IAAI,EAAE,CAAA;QAEhC,IAAI,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,EAAE,CAAC,EAAE,CAAC;YAC7B,IAAI,CAAC,UAAU,CACb,kBAAkB,EAAE,iDAAiD,EACrE,aAAa,CAAC,QAAQ,EACtB,OAAO,CACR,CAAA;YAED,OAAM;QACR,CAAC;QAED,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,EAAE,CAAC,CAAA;IAC1B,CAAC;CACF;AAED,MAAM,OAAO,sBAAuB,SAAQ,UAAU;IACpD,IAAI,GAAG,uBAAuB,CAAA;IAE9B,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,qBAAqB,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAE7D,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}
+{"version":3,"file":"html-no-duplicate-ids.js","sourceRoot":"","sources":["../../../src/rules/html-no-duplicate-ids.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAA;AACrC,OAAO,EAAE,0BAA0B,EAAE,eAAe,EAAE,MAAM,cAAc,CAAA;AAC1E,OAAO,EAAE,WAAW,EAAE,MAAM,kBAAkB,CAAA;AAC9C,OAAO,EAAE,OAAO,EAAE,eAAe,EAAE,MAAM,qBAAqB,CAAA;AAE9D,OAAO,EAAE,YAAY,EAAE,2BAA2B,EAAE,mBAAmB,EAAE,MAAM,EAAE,sBAAsB,EAAE,eAAe,EAAE,MAAM,kBAAkB,CAAA;AAclJ,MAAM,aAAc,SAAQ,OAAO;IACjC,gBAAgB,CAAC,IAAiB;QAChC,IAAI,CAAC,KAAK,CAAC,eAAe,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAA;IACzC,CAAC;IAED,mBAAmB,CAAC,IAAoB;QACtC,IAAI,eAAe,CAAC,IAAI,CAAC,EAAE,CAAC;YAC1B,IAAI,CAAC,KAAK,CAAC,eAAe,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAA;QACzC,CAAC;IACH,CAAC;CACF;AAED,MAAM,qBAAsB,SAAQ,0BAAyD;IACnF,WAAW,GAAgB,IAAI,GAAG,EAAU,CAAA;IAC5C,gBAAgB,GAAgB,IAAI,GAAG,EAAU,CAAA;IACjD,cAAc,GAAgB,IAAI,GAAG,EAAU,CAAA;IAEvD,sBAAsB,CAAC,IAAuB;QAC5C,IAAI,CAAC,cAAc,CAAC,IAAI,CAAC,CAAA;IAC3B,CAAC;IAES,kBAAkB,CAAC,gBAAiC,EAAE,uBAAgC;QAC9F,MAAM,cAAc,GAAqB;YACvC,iBAAiB,EAAE,IAAI,CAAC,gBAAgB;YACxC,sBAAsB,EAAE,IAAI,CAAC,cAAc;SAC5C,CAAA;QAED,IAAI,CAAC,gBAAgB,GAAG,IAAI,GAAG,EAAU,CAAA;QAEzC,IAAI,CAAC,uBAAuB,EAAE,CAAC;YAC7B,IAAI,CAAC,cAAc,GAAG,IAAI,GAAG,EAAU,CAAA;QACzC,CAAC;QAED,OAAO,cAAc,CAAA;IACvB,CAAC;IAES,iBAAiB,CAAC,eAAgC,EAAE,uBAAgC,EAAE,cAAgC;QAC9H,IAAI,eAAe,KAAK,eAAe,CAAC,WAAW,IAAI,CAAC,uBAAuB,EAAE,CAAC;YAChF,IAAI,CAAC,cAAc,CAAC,OAAO,CAAC,EAAE,CAAC,EAAE,CAAC,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC,CAAA;QAC7D,CAAC;QAED,IAAI,CAAC,gBAAgB,GAAG,cAAc,CAAC,iBAAiB,CAAA;QACxD,IAAI,CAAC,cAAc,GAAG,cAAc,CAAC,sBAAsB,CAAA;IAC7D,CAAC;IAES,aAAa;QACrB,MAAM,cAAc,GAAgB;YAClC,iBAAiB,EAAE,IAAI,CAAC,gBAAgB;SACzC,CAAA;QAED,IAAI,IAAI,CAAC,eAAe,EAAE,CAAC;YACzB,IAAI,CAAC,gBAAgB,GAAG,IAAI,GAAG,EAAU,CAAA;QAC3C,CAAC;QAED,OAAO,cAAc,CAAA;IACvB,CAAC;IAES,YAAY,CAAC,eAA4B,IAAS,CAAC;IAErD,cAAc,CAAC,aAAgC;QACrD,IAAI,CAAC,IAAI,CAAC,aAAa,CAAC,aAAa,CAAC;YAAE,OAAM;QAE9C,MAAM,OAAO,GAAG,IAAI,CAAC,cAAc,CAAC,aAAa,CAAC,CAAA;QAElD,IAAI,CAAC,OAAO;YAAE,OAAM;QACpB,IAAI,IAAI,CAAC,kBAAkB,CAAC,OAAO,CAAC,UAAU,CAAC;YAAE,OAAM;QAEvD,IAAI,CAAC,kBAAkB,CAAC,OAAO,EAAE,aAAa,CAAC,CAAA;IACjD,CAAC;IAEO,aAAa,CAAC,aAAgC;QACpD,IAAI,CAAC,aAAa,CAAC,IAAI,EAAE,QAAQ,IAAI,CAAC,aAAa,CAAC,KAAK;YAAE,OAAO,KAAK,CAAA;QAEvE,OAAO,sBAAsB,CAAC,aAAa,CAAC,IAAI,CAAC,KAAK,IAAI,CAAA;IAC5D,CAAC;IAEO,cAAc,CAAC,aAAgC;QACrD,MAAM,UAAU,GAAG,aAAa,CAAC,KAAK,EAAE,QAAQ,IAAI,EAAE,CAAA;QAEtD,IAAI,YAAY,CAAC,UAAU,CAAC,IAAI,IAAI,CAAC,eAAe,IAAI,IAAI,CAAC,sBAAsB,KAAK,eAAe,CAAC,IAAI,EAAE,CAAC;YAC7G,OAAO,IAAI,CAAA;QACb,CAAC;QAED,MAAM,UAAU,GAAG,mBAAmB,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,2BAA2B,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,aAAa,CAAC,KAAK,CAAC,UAAU,CAAC,CAAA;QAC9H,IAAI,CAAC,UAAU;YAAE,OAAO,IAAI,CAAA;QAE5B,OAAO,EAAE,UAAU,EAAE,qBAAqB,EAAE,IAAI,EAAE,CAAA;IACpD,CAAC;IAEO,kBAAkB,CAAC,UAAkB;QAC3C,OAAO,UAAU,KAAK,EAAE,IAAI,UAAU,CAAC,IAAI,EAAE,KAAK,EAAE,CAAA;IACtD,CAAC;IAEO,kBAAkB,CAAC,OAA+D,EAAE,aAAgC;QAC1H,MAAM,EAAE,UAAU,EAAE,qBAAqB,EAAE,GAAG,OAAO,CAAA;QAErD,IAAI,CAAC,qBAAqB;YAAE,OAAM;QAElC,IAAI,IAAI,CAAC,eAAe,EAAE,CAAC;YACzB,IAAI,CAAC,mBAAmB,CAAC,UAAU,EAAE,aAAa,CAAC,CAAA;QACrD,CAAC;aAAM,CAAC;YACN,IAAI,CAAC,cAAc,CAAC,UAAU,EAAE,aAAa,CAAC,CAAA;QAChD,CAAC;IACH,CAAC;IAEO,mBAAmB,CAAC,UAAkB,EAAE,aAAgC;QAC9E,IAAI,IAAI,CAAC,sBAAsB,KAAK,eAAe,CAAC,IAAI,EAAE,CAAC;YACzD,IAAI,CAAC,YAAY,CAAC,UAAU,EAAE,aAAa,CAAC,CAAA;QAC9C,CAAC;aAAM,CAAC;YACN,IAAI,CAAC,mBAAmB,CAAC,UAAU,EAAE,aAAa,CAAC,CAAA;QACrD,CAAC;QAED,IAAI,CAAC,gBAAgB,CAAC,GAAG,CAAC,UAAU,CAAC,CAAA;IACvC,CAAC;IAEO,YAAY,CAAC,UAAkB,EAAE,aAAgC;QACvE,MAAM,UAAU,GAAG,IAAI,CAAC,UAAU,CAAC,aAAa,CAAC,CAAA;QAEjD,IAAI,UAAU,EAAE,CAAC;YACf,IAAI,CAAC,qBAAqB,CAAC,UAAU,EAAE,aAAa,CAAC,QAAQ,CAAC,CAAA;YAC9D,OAAM;QACR,CAAC;QAED,IAAI,IAAI,CAAC,gBAAgB,CAAC,GAAG,CAAC,UAAU,CAAC,EAAE,CAAC;YAC1C,IAAI,CAAC,2BAA2B,CAAC,UAAU,EAAE,aAAa,CAAC,QAAQ,CAAC,CAAA;QACtE,CAAC;IACH,CAAC;IAEO,mBAAmB,CAAC,UAAkB,EAAE,aAAgC;QAC9E,IAAI,IAAI,CAAC,gBAAgB,CAAC,GAAG,CAAC,UAAU,CAAC,EAAE,CAAC;YAC1C,IAAI,CAAC,oBAAoB,CAAC,UAAU,EAAE,aAAa,CAAC,QAAQ,CAAC,CAAA;YAC7D,OAAM;QACR,CAAC;QAED,IAAI,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,UAAU,CAAC,EAAE,CAAC;YACrC,IAAI,CAAC,qBAAqB,CAAC,UAAU,EAAE,aAAa,CAAC,QAAQ,CAAC,CAAA;YAC9D,OAAM;QACR,CAAC;QAED,IAAI,CAAC,cAAc,CAAC,GAAG,CAAC,UAAU,CAAC,CAAA;IACrC,CAAC;IAEO,cAAc,CAAC,UAAkB,EAAE,aAAgC;QACzE,IAAI,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,UAAU,CAAC,EAAE,CAAC;YACrC,IAAI,CAAC,qBAAqB,CAAC,UAAU,EAAE,aAAa,CAAC,QAAQ,CAAC,CAAA;YAC9D,OAAM;QACR,CAAC;QAED,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,UAAU,CAAC,CAAA;IAClC,CAAC;IAEO,UAAU,CAAC,aAAgC;QACjD,MAAM,UAAU,GAAG,aAAa,CAAC,KAAM,CAAC,QAAQ,CAAA;QAChD,MAAM,kBAAkB,GAAG,UAAU,CAAC,KAAK,CAAC,KAAK,CAAC,EAAE,CAAC,MAAM,CAAC,KAAK,EAAE,WAAW,CAAC,CAAC,CAAA;QAChF,MAAM,wBAAwB,GAAG,mBAAmB,CAAC,UAAU,CAAC,CAAA;QAEhE,OAAO,kBAAkB,IAAI,wBAAwB,CAAA;IACvD,CAAC;IAEO,qBAAqB,CAAC,UAAkB,EAAE,QAAa;QAC7D,IAAI,CAAC,UAAU,CACb,kBAAkB,UAAU,iDAAiD,EAC7E,QAAQ,EACR,OAAO,CACR,CAAA;IACH,CAAC;IAEO,2BAA2B,CAAC,UAAkB,EAAE,QAAa;QACnE,IAAI,CAAC,UAAU,CACb,kBAAkB,UAAU,6FAA6F,EACzH,QAAQ,EACR,OAAO,CACR,CAAA;IACH,CAAC;IAEO,oBAAoB,CAAC,UAAkB,EAAE,QAAa;QAC5D,IAAI,CAAC,UAAU,CACb,kBAAkB,UAAU,uGAAuG,EACnI,QAAQ,EACR,OAAO,CACR,CAAA;IACH,CAAC;CACF;AAED,MAAM,OAAO,sBAAuB,SAAQ,UAAU;IACpD,IAAI,GAAG,uBAAuB,CAAA;IAE9B,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,qBAAqB,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAE7D,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}

package/dist/src/rules/html-no-empty-attributes.js

@@ -0,0 +1,56 @@
+import { ParserRule } from "../types.js";
+import { AttributeVisitorMixin } from "./rule-utils.js";
+// Attributes that must not have empty values
+const RESTRICTED_ATTRIBUTES = new Set([
+    'id',
+    'class',
+    'name',
+    'for',
+    'src',
+    'href',
+    'title',
+    'data',
+    'role'
+]);
+// Check if attribute name matches any restricted patterns
+function isRestrictedAttribute(attributeName) {
+    // Check direct matches
+    if (RESTRICTED_ATTRIBUTES.has(attributeName)) {
+        return true;
+    }
+    // Check for data-* attributes
+    if (attributeName.startsWith('data-')) {
+        return true;
+    }
+    // Check for aria-* attributes
+    if (attributeName.startsWith('aria-')) {
+        return true;
+    }
+    return false;
+}
+class NoEmptyAttributesVisitor extends AttributeVisitorMixin {
+    checkStaticAttributeStaticValue({ attributeName, attributeValue, attributeNode }) {
+        if (!isRestrictedAttribute(attributeName))
+            return;
+        if (attributeValue.trim() !== "")
+            return;
+        this.addOffense(`Attribute \`${attributeName}\` must not be empty. Either provide a meaningful value or remove the attribute entirely.`, attributeNode.name.location, "warning");
+    }
+    checkDynamicAttributeStaticValue({ combinedName, attributeValue, attributeNode }) {
+        const name = (combinedName || "").toLowerCase();
+        if (!isRestrictedAttribute(name))
+            return;
+        if (attributeValue.trim() !== "")
+            return;
+        this.addOffense(`Attribute \`${combinedName}\` must not be empty. Either provide a meaningful value or remove the attribute entirely.`, attributeNode.name.location, "warning");
+    }
+}
+export class HTMLNoEmptyAttributesRule extends ParserRule {
+    name = "html-no-empty-attributes";
+    check(result, context) {
+        const visitor = new NoEmptyAttributesVisitor(this.name, context);
+        visitor.visit(result.value);
+        return visitor.offenses;
+    }
+}
+//# sourceMappingURL=html-no-empty-attributes.js.map

package/dist/src/rules/html-no-empty-attributes.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"html-no-empty-attributes.js","sourceRoot":"","sources":["../../../src/rules/html-no-empty-attributes.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,qBAAqB,EAAuE,MAAM,iBAAiB,CAAA;AAK5H,6CAA6C;AAC7C,MAAM,qBAAqB,GAAG,IAAI,GAAG,CAAC;IACpC,IAAI;IACJ,OAAO;IACP,MAAM;IACN,KAAK;IACL,KAAK;IACL,MAAM;IACN,OAAO;IACP,MAAM;IACN,MAAM;CACP,CAAC,CAAA;AAEF,0DAA0D;AAC1D,SAAS,qBAAqB,CAAC,aAAqB;IAClD,uBAAuB;IACvB,IAAI,qBAAqB,CAAC,GAAG,CAAC,aAAa,CAAC,EAAE,CAAC;QAC7C,OAAO,IAAI,CAAA;IACb,CAAC;IAED,8BAA8B;IAC9B,IAAI,aAAa,CAAC,UAAU,CAAC,OAAO,CAAC,EAAE,CAAC;QACtC,OAAO,IAAI,CAAA;IACb,CAAC;IAED,8BAA8B;IAC9B,IAAI,aAAa,CAAC,UAAU,CAAC,OAAO,CAAC,EAAE,CAAC;QACtC,OAAO,IAAI,CAAA;IACb,CAAC;IAED,OAAO,KAAK,CAAA;AACd,CAAC;AAED,MAAM,wBAAyB,SAAQ,qBAAqB;IAChD,+BAA+B,CAAC,EAAE,aAAa,EAAE,cAAc,EAAE,aAAa,EAAoC;QAC1H,IAAI,CAAC,qBAAqB,CAAC,aAAa,CAAC;YAAE,OAAM;QACjD,IAAI,cAAc,CAAC,IAAI,EAAE,KAAK,EAAE;YAAE,OAAM;QAExC,IAAI,CAAC,UAAU,CACb,eAAe,aAAa,2FAA2F,EACvH,aAAa,CAAC,IAAK,CAAC,QAAQ,EAC5B,SAAS,CACV,CAAA;IACH,CAAC;IAES,gCAAgC,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,aAAa,EAAqC;QAC3H,MAAM,IAAI,GAAG,CAAC,YAAY,IAAI,EAAE,CAAC,CAAC,WAAW,EAAE,CAAA;QAC/C,IAAI,CAAC,qBAAqB,CAAC,IAAI,CAAC;YAAE,OAAM;QACxC,IAAI,cAAc,CAAC,IAAI,EAAE,KAAK,EAAE;YAAE,OAAM;QAExC,IAAI,CAAC,UAAU,CACb,eAAe,YAAY,2FAA2F,EACtH,aAAa,CAAC,IAAK,CAAC,QAAQ,EAC5B,SAAS,CACV,CAAA;IACH,CAAC;CACF;AAED,MAAM,OAAO,yBAA0B,SAAQ,UAAU;IACvD,IAAI,GAAG,0BAA0B,CAAA;IAEjC,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,wBAAwB,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAEhE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}

package/dist/src/rules/html-no-positive-tab-index.js

@@ -6,7 +6,7 @@ class NoPositiveTabIndexVisitor extends AttributeVisitorMixin {
             return;
         const tabIndexValue = parseInt(attributeValue, 10);
         if (!isNaN(tabIndexValue) && tabIndexValue > 0) {
-            this.addOffense(`Do not use positive \`tabindex\` values as they are error prone and can severely disrupt navigation experience for keyboard users. Use \`tabindex="0"\` to make an element focusable or \`tabindex=\"-1\"\` to remove it from the tab sequence.`, attributeNode.location, "error");
+            this.addOffense(`Do not use positive \`tabindex\` values as they are error prone and can severely disrupt navigation experience for keyboard users. Use \`tabindex="0"\` to make an element focusable or \`tabindex="-1"\` to remove it from the tab sequence.`, attributeNode.location, "error");
         }
     }
 }

package/dist/src/rules/html-no-positive-tab-index.js.map

@@ -1 +1 @@
-{"version":3,"file":"html-no-positive-tab-index.js","sourceRoot":"","sources":["../../../src/rules/html-no-positive-tab-index.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,qBAAqB,EAAoC,MAAM,iBAAiB,CAAA;AAKzF,MAAM,yBAA0B,SAAQ,qBAAqB;IACjD,+BAA+B,CAAC,EAAE,aAAa,EAAE,cAAc,EAAE,aAAa,EAAoC;QAC1H,IAAI,aAAa,KAAK,UAAU;YAAE,OAAM;QAExC,MAAM,aAAa,GAAG,QAAQ,CAAC,cAAc,EAAE,EAAE,CAAC,CAAA;QAElD,IAAI,CAAC,KAAK,CAAC,aAAa,CAAC,IAAI,aAAa,GAAG,CAAC,EAAE,CAAC;YAC/C,IAAI,CAAC,UAAU,CACb,iPAAiP,EACjP,aAAa,CAAC,QAAQ,EACtB,OAAO,CACR,CAAA;QACH,CAAC;IACH,CAAC;CACF;AAED,MAAM,OAAO,0BAA2B,SAAQ,UAAU;IACxD,IAAI,GAAG,4BAA4B,CAAA;IAEnC,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,yBAAyB,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAEjE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}
+{"version":3,"file":"html-no-positive-tab-index.js","sourceRoot":"","sources":["../../../src/rules/html-no-positive-tab-index.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,qBAAqB,EAAoC,MAAM,iBAAiB,CAAA;AAKzF,MAAM,yBAA0B,SAAQ,qBAAqB;IACjD,+BAA+B,CAAC,EAAE,aAAa,EAAE,cAAc,EAAE,aAAa,EAAoC;QAC1H,IAAI,aAAa,KAAK,UAAU;YAAE,OAAM;QAExC,MAAM,aAAa,GAAG,QAAQ,CAAC,cAAc,EAAE,EAAE,CAAC,CAAA;QAElD,IAAI,CAAC,KAAK,CAAC,aAAa,CAAC,IAAI,aAAa,GAAG,CAAC,EAAE,CAAC;YAC/C,IAAI,CAAC,UAAU,CACb,+OAA+O,EAC/O,aAAa,CAAC,QAAQ,EACtB,OAAO,CACR,CAAA;QACH,CAAC;IACH,CAAC;CACF;AAED,MAAM,OAAO,0BAA2B,SAAQ,UAAU;IACxD,IAAI,GAAG,4BAA4B,CAAA;IAEnC,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,yBAAyB,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAEjE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}

package/dist/src/rules/html-no-self-closing.js

@@ -1,14 +1,21 @@
 import { ParserRule } from "../types.js";
-import { BaseRuleVisitor, getTagName, isVoidElement } from "./rule-utils.js";
+import { BaseRuleVisitor, isVoidElement } from "./rule-utils.js";
+import { getTagName } from "@herb-tools/core";
 class NoSelfClosingVisitor extends BaseRuleVisitor {
+    visitHTMLElementNode(node) {
+        if (getTagName(node) === "svg") {
+            this.visit(node.open_tag);
+        }
+        else {
+            this.visitChildNodes(node);
+        }
+    }
     visitHTMLOpenTagNode(node) {
         if (node.tag_closing?.value === "/>") {
             const tagName = getTagName(node);
-            const shouldBeVoid = tagName ? isVoidElement(tagName) : false;
-            const instead = shouldBeVoid ? `Use \`<${tagName}>\` instead.` : `Use \`<${tagName}></${tagName}>\` instead.`;
-            this.addOffense(`Self-closing syntax \`<${tagName} />\` is not allowed in HTML. ${instead}`, node.location, "error");
+            const instead = isVoidElement(tagName) ? `<${tagName}>` : `<${tagName}></${tagName}>`;
+            this.addOffense(`Use \`${instead}\` instead of self-closing \`<${tagName} />\` for HTML compatibility.`, node.location, "error");
         }
-        super.visitHTMLOpenTagNode(node);
     }
 }
 export class HTMLNoSelfClosingRule extends ParserRule {

package/dist/src/rules/html-no-self-closing.js.map

@@ -1 +1 @@
-{"version":3,"file":"html-no-self-closing.js","sourceRoot":"","sources":["../../../src/rules/html-no-self-closing.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,eAAe,EAAE,UAAU,EAAE,aAAa,EAAE,MAAM,iBAAiB,CAAA;AAK5E,MAAM,oBAAqB,SAAQ,eAAe;IAChD,oBAAoB,CAAC,IAAqB;QACxC,IAAI,IAAI,CAAC,WAAW,EAAE,KAAK,KAAK,IAAI,EAAE,CAAC;YACrC,MAAM,OAAO,GAAG,UAAU,CAAC,IAAI,CAAC,CAAA;YAEhC,MAAM,YAAY,GAAG,OAAO,CAAC,CAAC,CAAC,aAAa,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,KAAK,CAAA;YAC7D,MAAM,OAAO,GAAG,YAAY,CAAC,CAAC,CAAC,UAAU,OAAO,cAAc,CAAC,CAAC,CAAC,UAAU,OAAO,MAAM,OAAO,cAAc,CAAA;YAE7G,IAAI,CAAC,UAAU,CACb,0BAA0B,OAAO,iCAAiC,OAAO,EAAE,EAC3E,IAAI,CAAC,QAAQ,EACb,OAAO,CACR,CAAA;QACH,CAAC;QAED,KAAK,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAA;IAClC,CAAC;CACF;AAED,MAAM,OAAO,qBAAsB,SAAQ,UAAU;IACnD,IAAI,GAAG,sBAAsB,CAAA;IAE7B,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,oBAAoB,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAE5D,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}
+{"version":3,"file":"html-no-self-closing.js","sourceRoot":"","sources":["../../../src/rules/html-no-self-closing.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,eAAe,EAAE,aAAa,EAAE,MAAM,iBAAiB,CAAA;AAChE,OAAO,EAAE,UAAU,EAAE,MAAM,kBAAkB,CAAA;AAK7C,MAAM,oBAAqB,SAAQ,eAAe;IAChD,oBAAoB,CAAC,IAAqB;QACxC,IAAI,UAAU,CAAC,IAAI,CAAC,KAAK,KAAK,EAAE,CAAC;YAC/B,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAA;QAC3B,CAAC;aAAM,CAAC;YACN,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;QAC5B,CAAC;IACH,CAAC;IAED,oBAAoB,CAAC,IAAqB;QACxC,IAAI,IAAI,CAAC,WAAW,EAAE,KAAK,KAAK,IAAI,EAAE,CAAC;YACrC,MAAM,OAAO,GAAG,UAAU,CAAC,IAAI,CAAC,CAAA;YAChC,MAAM,OAAO,GAAG,aAAa,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,IAAI,OAAO,GAAG,CAAC,CAAC,CAAC,IAAI,OAAO,MAAM,OAAO,GAAG,CAAA;YAErF,IAAI,CAAC,UAAU,CACb,SAAS,OAAO,iCAAiC,OAAO,+BAA+B,EACvF,IAAI,CAAC,QAAQ,EACb,OAAO,CACR,CAAA;QACH,CAAC;IACH,CAAC;CACF;AAED,MAAM,OAAO,qBAAsB,SAAQ,UAAU;IACnD,IAAI,GAAG,sBAAsB,CAAA;IAE7B,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,oBAAoB,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAE5D,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}

package/dist/src/rules/html-no-underscores-in-attribute-names.js

@@ -0,0 +1,36 @@
+import { ParserRule } from "../types.js";
+import { AttributeVisitorMixin } from "./rule-utils.js";
+import { getStaticContentFromNodes } from "@herb-tools/core";
+import { IdentityPrinter } from "@herb-tools/printer";
+class HTMLNoUnderscoresInAttributeNamesVisitor extends AttributeVisitorMixin {
+    checkStaticAttributeStaticValue({ attributeName, attributeNode }) {
+        this.check(attributeName, attributeNode);
+    }
+    checkStaticAttributeDynamicValue({ attributeName, attributeNode }) {
+        this.check(attributeName, attributeNode);
+    }
+    checkDynamicAttributeStaticValue({ nameNodes, attributeNode }) {
+        const attributeName = getStaticContentFromNodes(nameNodes);
+        this.check(attributeName, attributeNode);
+    }
+    checkDynamicAttributeDynamicValue({ nameNodes, attributeNode }) {
+        const attributeName = getStaticContentFromNodes(nameNodes);
+        this.check(attributeName, attributeNode);
+    }
+    check(attributeName, attributeNode) {
+        if (!attributeName)
+            return;
+        if (attributeName.includes("_")) {
+            this.addOffense(`Attribute \`${IdentityPrinter.print(attributeNode.name)}\` should not contain underscores. Use hyphens (-) instead.`, attributeNode.value.location, "warning");
+        }
+    }
+}
+export class HTMLNoUnderscoresInAttributeNamesRule extends ParserRule {
+    name = "html-no-underscores-in-attribute-names";
+    check(result, context) {
+        const visitor = new HTMLNoUnderscoresInAttributeNamesVisitor(this.name, context);
+        visitor.visit(result.value);
+        return visitor.offenses;
+    }
+}
+//# sourceMappingURL=html-no-underscores-in-attribute-names.js.map

package/dist/src/rules/html-no-underscores-in-attribute-names.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"html-no-underscores-in-attribute-names.js","sourceRoot":"","sources":["../../../src/rules/html-no-underscores-in-attribute-names.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EACL,qBAAqB,EAKtB,MAAM,iBAAiB,CAAA;AACxB,OAAO,EAAE,yBAAyB,EAAE,MAAM,kBAAkB,CAAA;AAC5D,OAAO,EAAE,eAAe,EAAE,MAAM,qBAAqB,CAAA;AAIrD,MAAM,wCAAyC,SAAQ,qBAAqB;IAChE,+BAA+B,CAAC,EAAE,aAAa,EAAE,aAAa,EAAoC;QAC1G,IAAI,CAAC,KAAK,CAAC,aAAa,EAAE,aAAa,CAAC,CAAA;IAC1C,CAAC;IAES,gCAAgC,CAAC,EAAE,aAAa,EAAE,aAAa,EAAqC;QAC5G,IAAI,CAAC,KAAK,CAAC,aAAa,EAAE,aAAa,CAAC,CAAA;IAC1C,CAAC;IAES,gCAAgC,CAAC,EAAE,SAAS,EAAE,aAAa,EAAqC;QACxG,MAAM,aAAa,GAAG,yBAAyB,CAAC,SAAS,CAAC,CAAA;QAE1D,IAAI,CAAC,KAAK,CAAC,aAAa,EAAE,aAAa,CAAC,CAAA;IAC1C,CAAC;IAES,iCAAiC,CAAC,EAAE,SAAS,EAAE,aAAa,EAAsC;QAC1G,MAAM,aAAa,GAAG,yBAAyB,CAAC,SAAS,CAAC,CAAA;QAE1D,IAAI,CAAC,KAAK,CAAC,aAAa,EAAE,aAAa,CAAC,CAAA;IAC1C,CAAC;IAEO,KAAK,CAAC,aAA4B,EAAE,aAAgC;QAC1E,IAAI,CAAC,aAAa;YAAE,OAAM;QAE1B,IAAI,aAAa,CAAC,QAAQ,CAAC,GAAG,CAAC,EAAE,CAAC;YAChC,IAAI,CAAC,UAAU,CACb,eAAe,eAAe,CAAC,KAAK,CAAC,aAAa,CAAC,IAAI,CAAC,6DAA6D,EACrH,aAAa,CAAC,KAAM,CAAC,QAAQ,EAC7B,SAAS,CACV,CAAA;QACH,CAAC;IACH,CAAC;CACF;AAED,MAAM,OAAO,qCAAsC,SAAQ,UAAU;IACnE,IAAI,GAAG,wCAAwC,CAAA;IAE/C,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,wCAAwC,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAEhF,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}

package/dist/src/rules/index.js

@@ -1,3 +1,4 @@
+export * from "./rule-utils.js";
 export * from "./erb-no-empty-tags.js";
 export * from "./erb-no-output-control-flow.js";
 export * from "./erb-no-silent-tag-in-attribute-name.js";
@@ -20,6 +21,7 @@ export * from "./html-no-aria-hidden-on-focusable.js";
 export * from "./html-no-block-inside-inline.js";
 export * from "./html-no-duplicate-attributes.js";
 export * from "./html-no-duplicate-ids.js";
+export * from "./html-no-empty-attributes.js";
 export * from "./html-no-empty-headings.js";
 export * from "./html-no-nested-links.js";
 export * from "./html-no-positive-tab-index.js";
@@ -27,4 +29,5 @@ export * from "./html-no-self-closing.js";
 export * from "./html-no-title-attribute.js";
 export * from "./html-tag-name-lowercase.js";
 export * from "./svg-tag-name-capitalization.js";
+export * from "./html-no-underscores-in-attribute-names.js";
 //# sourceMappingURL=index.js.map

package/dist/src/rules/index.js.map

@@ -1 +1 @@
-{"version":3,"file":"index.js","sourceRoot":"","sources":["../../../src/rules/index.ts"],"names":[],"mappings":"AAAA,cAAc,wBAAwB,CAAA;AACtC,cAAc,iCAAiC,CAAA;AAC/C,cAAc,0CAA0C,CAAA;AACxD,cAAc,kCAAkC,CAAA;AAChD,cAAc,oCAAoC,CAAA;AAClD,cAAc,+BAA+B,CAAA;AAC7C,cAAc,wCAAwC,CAAA;AACtD,cAAc,oCAAoC,CAAA;AAClD,cAAc,4CAA4C,CAAA;AAC1D,cAAc,mCAAmC,CAAA;AACjD,cAAc,mCAAmC,CAAA;AACjD,cAAc,oCAAoC,CAAA;AAClD,cAAc,2CAA2C,CAAA;AACzD,cAAc,iDAAiD,CAAA;AAC/D,cAAc,uCAAuC,CAAA;AACrD,cAAc,4BAA4B,CAAA;AAC1C,cAAc,2BAA2B,CAAA;AACzC,cAAc,gCAAgC,CAAA;AAC9C,cAAc,uCAAuC,CAAA;AACrD,cAAc,kCAAkC,CAAA;AAChD,cAAc,mCAAmC,CAAA;AACjD,cAAc,4BAA4B,CAAA;AAC1C,cAAc,6BAA6B,CAAA;AAC3C,cAAc,2BAA2B,CAAA;AACzC,cAAc,iCAAiC,CAAA;AAC/C,cAAc,2BAA2B,CAAA;AACzC,cAAc,8BAA8B,CAAA;AAC5C,cAAc,8BAA8B,CAAA;AAC5C,cAAc,kCAAkC,CAAA"}
+{"version":3,"file":"index.js","sourceRoot":"","sources":["../../../src/rules/index.ts"],"names":[],"mappings":"AAAA,cAAc,iBAAiB,CAAA;AAC/B,cAAc,wBAAwB,CAAA;AACtC,cAAc,iCAAiC,CAAA;AAC/C,cAAc,0CAA0C,CAAA;AACxD,cAAc,kCAAkC,CAAA;AAChD,cAAc,oCAAoC,CAAA;AAClD,cAAc,+BAA+B,CAAA;AAC7C,cAAc,wCAAwC,CAAA;AACtD,cAAc,oCAAoC,CAAA;AAClD,cAAc,4CAA4C,CAAA;AAC1D,cAAc,mCAAmC,CAAA;AACjD,cAAc,mCAAmC,CAAA;AACjD,cAAc,oCAAoC,CAAA;AAClD,cAAc,2CAA2C,CAAA;AACzD,cAAc,iDAAiD,CAAA;AAC/D,cAAc,uCAAuC,CAAA;AACrD,cAAc,4BAA4B,CAAA;AAC1C,cAAc,2BAA2B,CAAA;AACzC,cAAc,gCAAgC,CAAA;AAC9C,cAAc,uCAAuC,CAAA;AACrD,cAAc,kCAAkC,CAAA;AAChD,cAAc,mCAAmC,CAAA;AACjD,cAAc,4BAA4B,CAAA;AAC1C,cAAc,+BAA+B,CAAA;AAC7C,cAAc,6BAA6B,CAAA;AAC3C,cAAc,2BAA2B,CAAA;AACzC,cAAc,iCAAiC,CAAA;AAC/C,cAAc,2BAA2B,CAAA;AACzC,cAAc,8BAA8B,CAAA;AAC5C,cAAc,8BAA8B,CAAA;AAC5C,cAAc,kCAAkC,CAAA;AAChD,cAAc,6CAA6C,CAAA"}