@herb-tools/linter 0.6.0 → 0.6.1

package/dist/index.cjs

@@ -18,6 +18,11 @@ class SourceRule {
     static type = "source";
 }
 
+var ControlFlowType;
+(function (ControlFlowType) {
+    ControlFlowType[ControlFlowType["CONDITIONAL"] = 0] = "CONDITIONAL";
+    ControlFlowType[ControlFlowType["LOOP"] = 1] = "LOOP";
+})(ControlFlowType || (ControlFlowType = {}));
 /**
  * Base visitor class that provides common functionality for rule visitors
  */
@@ -50,6 +55,70 @@ class BaseRuleVisitor extends core.Visitor {
         this.offenses.push(this.createOffense(message, location, severity));
     }
 }
+/**
+ * Mixin that adds control flow tracking capabilities to rule visitors
+ * This allows rules to track state across different control flow structures
+ * like if/else branches, loops, etc.
+ *
+ * @template TControlFlowState - Type for state passed between onEnterControlFlow and onExitControlFlow
+ * @template TBranchState - Type for state passed between onEnterBranch and onExitBranch
+ */
+class ControlFlowTrackingVisitor extends BaseRuleVisitor {
+    isInControlFlow = false;
+    currentControlFlowType = null;
+    /**
+     * Handle visiting a control flow node with proper scope management
+     */
+    handleControlFlowNode(node, controlFlowType, visitChildren) {
+        const wasInControlFlow = this.isInControlFlow;
+        const previousControlFlowType = this.currentControlFlowType;
+        this.isInControlFlow = true;
+        this.currentControlFlowType = controlFlowType;
+        const stateToRestore = this.onEnterControlFlow(controlFlowType, wasInControlFlow);
+        visitChildren();
+        this.onExitControlFlow(controlFlowType, wasInControlFlow, stateToRestore);
+        this.isInControlFlow = wasInControlFlow;
+        this.currentControlFlowType = previousControlFlowType;
+    }
+    /**
+     * Handle visiting a branch node (like else, when) with proper scope management
+     */
+    startNewBranch(visitChildren) {
+        const stateToRestore = this.onEnterBranch();
+        visitChildren();
+        this.onExitBranch(stateToRestore);
+    }
+    visitERBIfNode(node) {
+        this.handleControlFlowNode(node, ControlFlowType.CONDITIONAL, () => super.visitERBIfNode(node));
+    }
+    visitERBUnlessNode(node) {
+        this.handleControlFlowNode(node, ControlFlowType.CONDITIONAL, () => super.visitERBUnlessNode(node));
+    }
+    visitERBCaseNode(node) {
+        this.handleControlFlowNode(node, ControlFlowType.CONDITIONAL, () => super.visitERBCaseNode(node));
+    }
+    visitERBCaseMatchNode(node) {
+        this.handleControlFlowNode(node, ControlFlowType.CONDITIONAL, () => super.visitERBCaseMatchNode(node));
+    }
+    visitERBWhileNode(node) {
+        this.handleControlFlowNode(node, ControlFlowType.LOOP, () => super.visitERBWhileNode(node));
+    }
+    visitERBForNode(node) {
+        this.handleControlFlowNode(node, ControlFlowType.LOOP, () => super.visitERBForNode(node));
+    }
+    visitERBUntilNode(node) {
+        this.handleControlFlowNode(node, ControlFlowType.LOOP, () => super.visitERBUntilNode(node));
+    }
+    visitERBBlockNode(node) {
+        this.handleControlFlowNode(node, ControlFlowType.CONDITIONAL, () => super.visitERBBlockNode(node));
+    }
+    visitERBElseNode(node) {
+        this.startNewBranch(() => super.visitERBElseNode(node));
+    }
+    visitERBWhenNode(node) {
+        this.startNewBranch(() => super.visitERBWhenNode(node));
+    }
+}
 /**
  * Gets attributes from an HTMLOpenTagNode
  */
@@ -612,82 +681,732 @@ class ERBNoSilentTagInAttributeNameRule extends ParserRule {
     }
 }
 
-class ERBPreferImageTagHelperVisitor extends BaseRuleVisitor {
+class PrintContext {
+    output = "";
+    indentLevel = 0;
+    currentColumn = 0;
+    preserveStack = [];
+    /**
+     * Write text to the output
+     */
+    write(text) {
+        this.output += text;
+        this.currentColumn += text.length;
+    }
+    /**
+     * Write text and update column tracking for newlines
+     */
+    writeWithColumnTracking(text) {
+        this.output += text;
+        const lines = text.split('\n');
+        if (lines.length > 1) {
+            this.currentColumn = lines[lines.length - 1].length;
+        }
+        else {
+            this.currentColumn += text.length;
+        }
+    }
+    /**
+     * Increase indentation level
+     */
+    indent() {
+        this.indentLevel++;
+    }
+    /**
+     * Decrease indentation level
+     */
+    dedent() {
+        if (this.indentLevel > 0) {
+            this.indentLevel--;
+        }
+    }
+    /**
+     * Enter a tag that may preserve whitespace
+     */
+    enterTag(tagName) {
+        this.preserveStack.push(tagName.toLowerCase());
+    }
+    /**
+     * Exit the current tag
+     */
+    exitTag() {
+        this.preserveStack.pop();
+    }
+    /**
+     * Check if we're at the start of a line
+     */
+    isAtStartOfLine() {
+        return this.currentColumn === 0;
+    }
+    /**
+     * Get current indentation level
+     */
+    getCurrentIndentLevel() {
+        return this.indentLevel;
+    }
+    /**
+     * Get current column position
+     */
+    getCurrentColumn() {
+        return this.currentColumn;
+    }
+    /**
+     * Get the current tag stack (for debugging)
+     */
+    getTagStack() {
+        return [...this.preserveStack];
+    }
+    /**
+     * Get the complete output string
+     */
+    getOutput() {
+        return this.output;
+    }
+    /**
+     * Reset the context for reuse
+     */
+    reset() {
+        this.output = "";
+        this.indentLevel = 0;
+        this.currentColumn = 0;
+        this.preserveStack = [];
+    }
+}
+
+/**
+ * Default print options used when none are provided
+ */
+const DEFAULT_PRINT_OPTIONS = {
+    ignoreErrors: false
+};
+class Printer extends core.Visitor {
+    context = new PrintContext();
+    /**
+     * Static method to print a node without creating an instance
+     *
+     * @param input - The AST Node, Token, or ParseResult to print
+     * @param options - Print options to control behavior
+     * @returns The printed string representation of the input
+     * @throws {Error} When node has parse errors and ignoreErrors is false
+     */
+    static print(input, options = DEFAULT_PRINT_OPTIONS) {
+        const printer = new this();
+        return printer.print(input, options);
+    }
+    /**
+     * Print a node, token, or parse result to a string
+     *
+     * @param input - The AST Node, Token, or ParseResult to print
+     * @param options - Print options to control behavior
+     * @returns The printed string representation of the input
+     * @throws {Error} When node has parse errors and ignoreErrors is false
+     */
+    print(input, options = DEFAULT_PRINT_OPTIONS) {
+        if (core.isToken(input)) {
+            return input.value;
+        }
+        if (Array.isArray(input)) {
+            this.context.reset();
+            input.forEach(node => this.visit(node));
+            return this.context.getOutput();
+        }
+        const node = core.isParseResult(input) ? input.value : input;
+        if (options.ignoreErrors === false && node.recursiveErrors().length > 0) {
+            throw new Error(`Cannot print the node (${node.type}) since it or any of its children has parse errors. Either pass in a valid Node or call \`print()\` using \`print(node, { ignoreErrors: true })\``);
+        }
+        this.context.reset();
+        this.visit(node);
+        return this.context.getOutput();
+    }
+    write(content) {
+        this.context.write(content);
+    }
+}
+
+/**
+ * IdentityPrinter - Provides lossless reconstruction of the original source
+ *
+ * This printer aims to reconstruct the original input as faithfully as possible,
+ * preserving all whitespace, formatting, and structure. It's useful for:
+ * - Testing parser accuracy (input should equal output)
+ * - Baseline printing before applying transformations
+ * - Verifying AST round-trip fidelity
+ */
+class IdentityPrinter extends Printer {
+    visitLiteralNode(node) {
+        this.write(node.content);
+    }
+    visitHTMLTextNode(node) {
+        this.write(node.content);
+    }
+    visitWhitespaceNode(node) {
+        if (node.value) {
+            this.write(node.value.value);
+        }
+    }
     visitHTMLOpenTagNode(node) {
-        this.checkImgTag(node);
-        super.visitHTMLOpenTagNode(node);
+        if (node.tag_opening) {
+            this.write(node.tag_opening.value);
+        }
+        if (node.tag_name) {
+            this.write(node.tag_name.value);
+        }
+        this.visitChildNodes(node);
+        if (node.tag_closing) {
+            this.write(node.tag_closing.value);
+        }
     }
-    checkImgTag(node) {
-        const tagName = getTagName(node);
-        if (tagName !== "img") {
-            return;
+    visitHTMLCloseTagNode(node) {
+        if (node.tag_opening) {
+            this.write(node.tag_opening.value);
         }
-        const attributes = getAttributes(node);
-        const srcAttribute = findAttributeByName(attributes, "src");
-        if (!srcAttribute) {
-            return;
+        if (node.tag_name) {
+            const before = core.getNodesBeforePosition(node.children, node.tag_name.location.start, true);
+            const after = core.getNodesAfterPosition(node.children, node.tag_name.location.end);
+            this.visitAll(before);
+            this.write(node.tag_name.value);
+            this.visitAll(after);
         }
-        if (!srcAttribute.value) {
-            return;
+        else {
+            this.visitAll(node.children);
         }
-        const valueNode = srcAttribute.value;
-        const hasERBContent = this.containsERBContent(valueNode);
-        if (hasERBContent) {
-            const suggestedExpression = this.buildSuggestedExpression(valueNode);
-            this.addOffense(`Prefer \`image_tag\` helper over manual \`<img>\` with dynamic ERB expressions. Use \`<%= image_tag ${suggestedExpression}, alt: "..." %>\` instead.`, srcAttribute.location, "warning");
+        if (node.tag_closing) {
+            this.write(node.tag_closing.value);
         }
     }
-    containsERBContent(valueNode) {
-        if (!valueNode.children)
-            return false;
-        return valueNode.children.some(child => child.type === "AST_ERB_CONTENT_NODE");
+    visitHTMLElementNode(node) {
+        const tagName = node.tag_name?.value;
+        if (tagName) {
+            this.context.enterTag(tagName);
+        }
+        if (node.open_tag) {
+            this.visit(node.open_tag);
+        }
+        if (node.body) {
+            node.body.forEach(child => this.visit(child));
+        }
+        if (node.close_tag) {
+            this.visit(node.close_tag);
+        }
+        if (tagName) {
+            this.context.exitTag();
+        }
     }
-    buildSuggestedExpression(valueNode) {
-        if (!valueNode.children)
-            return "expression";
-        let hasText = false;
-        let hasERB = false;
-        for (const child of valueNode.children) {
-            if (child.type === "AST_ERB_CONTENT_NODE") {
-                hasERB = true;
+    visitHTMLAttributeNode(node) {
+        if (node.name) {
+            this.visit(node.name);
+        }
+        if (node.equals) {
+            this.write(node.equals.value);
+        }
+        if (node.equals && node.value) {
+            this.visit(node.value);
+        }
+    }
+    visitHTMLAttributeNameNode(node) {
+        this.visitChildNodes(node);
+    }
+    visitHTMLAttributeValueNode(node) {
+        if (node.quoted && node.open_quote) {
+            this.write(node.open_quote.value);
+        }
+        this.visitChildNodes(node);
+        if (node.quoted && node.close_quote) {
+            this.write(node.close_quote.value);
+        }
+    }
+    visitHTMLCommentNode(node) {
+        if (node.comment_start) {
+            this.write(node.comment_start.value);
+        }
+        this.visitChildNodes(node);
+        if (node.comment_end) {
+            this.write(node.comment_end.value);
+        }
+    }
+    visitHTMLDoctypeNode(node) {
+        if (node.tag_opening) {
+            this.write(node.tag_opening.value);
+        }
+        this.visitChildNodes(node);
+        if (node.tag_closing) {
+            this.write(node.tag_closing.value);
+        }
+    }
+    visitXMLDeclarationNode(node) {
+        if (node.tag_opening) {
+            this.write(node.tag_opening.value);
+        }
+        this.visitChildNodes(node);
+        if (node.tag_closing) {
+            this.write(node.tag_closing.value);
+        }
+    }
+    visitCDATANode(node) {
+        if (node.tag_opening) {
+            this.write(node.tag_opening.value);
+        }
+        this.visitChildNodes(node);
+        if (node.tag_closing) {
+            this.write(node.tag_closing.value);
+        }
+    }
+    visitERBContentNode(node) {
+        this.printERBNode(node);
+    }
+    visitERBIfNode(node) {
+        this.printERBNode(node);
+        if (node.statements) {
+            node.statements.forEach(statement => this.visit(statement));
+        }
+        if (node.subsequent) {
+            this.visit(node.subsequent);
+        }
+        if (node.end_node) {
+            this.visit(node.end_node);
+        }
+    }
+    visitERBElseNode(node) {
+        this.printERBNode(node);
+        if (node.statements) {
+            node.statements.forEach(statement => this.visit(statement));
+        }
+    }
+    visitERBEndNode(node) {
+        this.printERBNode(node);
+    }
+    visitERBBlockNode(node) {
+        this.printERBNode(node);
+        if (node.body) {
+            node.body.forEach(child => this.visit(child));
+        }
+        if (node.end_node) {
+            this.visit(node.end_node);
+        }
+    }
+    visitERBCaseNode(node) {
+        this.printERBNode(node);
+        if (node.children) {
+            node.children.forEach(child => this.visit(child));
+        }
+        if (node.conditions) {
+            node.conditions.forEach(condition => this.visit(condition));
+        }
+        if (node.else_clause) {
+            this.visit(node.else_clause);
+        }
+        if (node.end_node) {
+            this.visit(node.end_node);
+        }
+    }
+    visitERBWhenNode(node) {
+        this.printERBNode(node);
+        if (node.statements) {
+            node.statements.forEach(statement => this.visit(statement));
+        }
+    }
+    visitERBWhileNode(node) {
+        this.printERBNode(node);
+        if (node.statements) {
+            node.statements.forEach(statement => this.visit(statement));
+        }
+        if (node.end_node) {
+            this.visit(node.end_node);
+        }
+    }
+    visitERBUntilNode(node) {
+        this.printERBNode(node);
+        if (node.statements) {
+            node.statements.forEach(statement => this.visit(statement));
+        }
+        if (node.end_node) {
+            this.visit(node.end_node);
+        }
+    }
+    visitERBForNode(node) {
+        this.printERBNode(node);
+        if (node.statements) {
+            node.statements.forEach(statement => this.visit(statement));
+        }
+        if (node.end_node) {
+            this.visit(node.end_node);
+        }
+    }
+    visitERBBeginNode(node) {
+        this.printERBNode(node);
+        if (node.statements) {
+            node.statements.forEach(statement => this.visit(statement));
+        }
+        if (node.rescue_clause) {
+            this.visit(node.rescue_clause);
+        }
+        if (node.else_clause) {
+            this.visit(node.else_clause);
+        }
+        if (node.ensure_clause) {
+            this.visit(node.ensure_clause);
+        }
+        if (node.end_node) {
+            this.visit(node.end_node);
+        }
+    }
+    visitERBRescueNode(node) {
+        this.printERBNode(node);
+        if (node.statements) {
+            node.statements.forEach(statement => this.visit(statement));
+        }
+        if (node.subsequent) {
+            this.visit(node.subsequent);
+        }
+    }
+    visitERBEnsureNode(node) {
+        this.printERBNode(node);
+        if (node.statements) {
+            node.statements.forEach(statement => this.visit(statement));
+        }
+    }
+    visitERBUnlessNode(node) {
+        this.printERBNode(node);
+        if (node.statements) {
+            node.statements.forEach(statement => this.visit(statement));
+        }
+        if (node.else_clause) {
+            this.visit(node.else_clause);
+        }
+        if (node.end_node) {
+            this.visit(node.end_node);
+        }
+    }
+    visitERBYieldNode(node) {
+        this.printERBNode(node);
+    }
+    visitERBInNode(node) {
+        this.printERBNode(node);
+        if (node.statements) {
+            node.statements.forEach(statement => this.visit(statement));
+        }
+    }
+    visitERBCaseMatchNode(node) {
+        this.printERBNode(node);
+        if (node.children) {
+            node.children.forEach(child => this.visit(child));
+        }
+        if (node.conditions) {
+            node.conditions.forEach(condition => this.visit(condition));
+        }
+        if (node.else_clause) {
+            this.visit(node.else_clause);
+        }
+        if (node.end_node) {
+            this.visit(node.end_node);
+        }
+    }
+    /**
+     * Print ERB node tags and content
+     */
+    printERBNode(node) {
+        if (node.tag_opening) {
+            this.write(node.tag_opening.value);
+        }
+        if (node.content) {
+            this.write(node.content.value);
+        }
+        if (node.tag_closing) {
+            this.write(node.tag_closing.value);
+        }
+    }
+}
+
+const DEFAULT_ERB_TO_RUBY_STRING_OPTIONS = {
+    ...DEFAULT_PRINT_OPTIONS,
+    forceQuotes: false
+};
+/**
+ * ERBToRubyStringPrinter - Converts ERB snippets to Ruby strings with interpolation
+ *
+ * This printer transforms ERB templates into Ruby strings by:
+ * - Converting literal text to string content
+ * - Converting <%= %> tags to #{} interpolation
+ * - Converting simple if/else blocks to ternary operators
+ * - Ignoring <% %> tags (they don't produce output)
+ *
+ * Examples:
+ * - `hello world <%= hello %>` => `"hello world #{hello}"`
+ * - `hello world <% hello %>` => `"hello world "`
+ * - `Welcome <%= user.name %>!` => `"Welcome #{user.name}!"`
+ * - `<% if logged_in? %>Welcome<% else %>Login<% end %>` => `"logged_in? ? "Welcome" : "Login"`
+ * - `<% if logged_in? %>Welcome<% else %>Login<% end %>!` => `"#{logged_in? ? "Welcome" : "Login"}!"`
+ */
+class ERBToRubyStringPrinter extends IdentityPrinter {
+    // TODO: cleanup `.type === "AST_*" checks`
+    static print(node, options = DEFAULT_ERB_TO_RUBY_STRING_OPTIONS) {
+        const erbNodes = core.filterNodes([node], core.ERBContentNode);
+        if (erbNodes.length === 1 && core.isERBOutputNode(erbNodes[0]) && !options.forceQuotes) {
+            return (erbNodes[0].content?.value || "").trim();
+        }
+        if ('children' in node && Array.isArray(node.children)) {
+            const childErbNodes = core.filterNodes(node.children, core.ERBContentNode);
+            const hasOnlyERBContent = node.children.length > 0 && node.children.length === childErbNodes.length;
+            if (hasOnlyERBContent && childErbNodes.length === 1 && core.isERBOutputNode(childErbNodes[0]) && !options.forceQuotes) {
+                return (childErbNodes[0].content?.value || "").trim();
             }
-            else if (child.type === "AST_LITERAL_NODE") {
-                const literalNode = child;
-                if (literalNode.content && literalNode.content.trim()) {
-                    hasText = true;
+            if (node.children.length === 1 && node.children[0].type === "AST_ERB_IF_NODE" && !options.forceQuotes) {
+                const ifNode = node.children[0];
+                const printer = new ERBToRubyStringPrinter();
+                if (printer.canConvertToTernary(ifNode)) {
+                    printer.convertToTernaryWithoutWrapper(ifNode);
+                    return printer.context.getOutput();
                 }
             }
-        }
-        if (hasText && hasERB) {
-            let result = '"';
-            for (const child of valueNode.children) {
-                if (child.type === "AST_ERB_CONTENT_NODE") {
-                    const erbNode = child;
-                    result += `#{${(erbNode.content?.value || "").trim()}}`;
-                }
-                else if (child.type === "AST_LITERAL_NODE") {
-                    const literalNode = child;
-                    result += literalNode.content || "";
+            if (node.children.length === 1 && node.children[0].type === "AST_ERB_UNLESS_NODE" && !options.forceQuotes) {
+                const unlessNode = node.children[0];
+                const printer = new ERBToRubyStringPrinter();
+                if (printer.canConvertUnlessToTernary(unlessNode)) {
+                    printer.convertUnlessToTernaryWithoutWrapper(unlessNode);
+                    return printer.context.getOutput();
                 }
             }
-            result += '"';
-            return result;
         }
-        if (hasERB && !hasText) {
-            const erbNodes = valueNode.children.filter(child => child.type === "AST_ERB_CONTENT_NODE");
-            if (erbNodes.length === 1) {
-                return (erbNodes[0].content?.value || "").trim();
+        const printer = new ERBToRubyStringPrinter();
+        printer.context.write('"');
+        printer.visit(node);
+        printer.context.write('"');
+        return printer.context.getOutput();
+    }
+    visitHTMLTextNode(node) {
+        if (node.content) {
+            const escapedContent = node.content.replace(/\\/g, '\\\\').replace(/"/g, '\\"');
+            this.context.write(escapedContent);
+        }
+    }
+    visitERBContentNode(node) {
+        if (core.isERBOutputNode(node)) {
+            this.context.write("#{");
+            if (node.content?.value) {
+                this.context.write(node.content.value.trim());
             }
-            else if (erbNodes.length > 1) {
-                let result = '"';
-                for (const erbNode of erbNodes) {
-                    result += `#{${(erbNode.content?.value || "").trim()}}`;
-                }
-                result += '"';
-                return result;
+            this.context.write("}");
+        }
+    }
+    visitERBIfNode(node) {
+        if (this.canConvertToTernary(node)) {
+            this.convertToTernary(node);
+        }
+    }
+    visitERBUnlessNode(node) {
+        if (this.canConvertUnlessToTernary(node)) {
+            this.convertUnlessToTernary(node);
+        }
+    }
+    visitHTMLAttributeValueNode(node) {
+        this.visitChildNodes(node);
+    }
+    canConvertToTernary(node) {
+        if (node.subsequent && node.subsequent.type !== "AST_ERB_ELSE_NODE") {
+            return false;
+        }
+        const ifOnlyText = node.statements ? node.statements.every(statement => statement.type === "AST_HTML_TEXT_NODE") : true;
+        if (!ifOnlyText)
+            return false;
+        if (node.subsequent && node.subsequent.type === "AST_ERB_ELSE_NODE") {
+            return node.subsequent.statements
+                ? node.subsequent.statements.every(statement => statement.type === "AST_HTML_TEXT_NODE")
+                : true;
+        }
+        return true;
+    }
+    convertToTernary(node) {
+        this.context.write("#{");
+        if (node.content?.value) {
+            const condition = node.content.value.trim();
+            const cleanCondition = condition.replace(/^if\s+/, '');
+            const needsParentheses = cleanCondition.includes(' ');
+            if (needsParentheses) {
+                this.context.write("(");
+            }
+            this.context.write(cleanCondition);
+            if (needsParentheses) {
+                this.context.write(")");
             }
         }
-        return "expression";
+        this.context.write(" ? ");
+        this.context.write('"');
+        if (node.statements) {
+            node.statements.forEach(statement => this.visit(statement));
+        }
+        this.context.write('"');
+        this.context.write(" : ");
+        this.context.write('"');
+        if (node.subsequent && node.subsequent.type === "AST_ERB_ELSE_NODE" && node.subsequent.statements) {
+            node.subsequent.statements.forEach(statement => this.visit(statement));
+        }
+        this.context.write('"');
+        this.context.write("}");
+    }
+    convertToTernaryWithoutWrapper(node) {
+        if (node.subsequent && node.subsequent.type !== "AST_ERB_ELSE_NODE") {
+            return false;
+        }
+        if (node.content?.value) {
+            const condition = node.content.value.trim();
+            const cleanCondition = condition.replace(/^if\s+/, '');
+            const needsParentheses = cleanCondition.includes(' ');
+            if (needsParentheses) {
+                this.context.write("(");
+            }
+            this.context.write(cleanCondition);
+            if (needsParentheses) {
+                this.context.write(")");
+            }
+        }
+        this.context.write(" ? ");
+        this.context.write('"');
+        if (node.statements) {
+            node.statements.forEach(statement => this.visit(statement));
+        }
+        this.context.write('"');
+        this.context.write(" : ");
+        this.context.write('"');
+        if (node.subsequent && node.subsequent.type === "AST_ERB_ELSE_NODE" && node.subsequent.statements) {
+            node.subsequent.statements.forEach(statement => this.visit(statement));
+        }
+        this.context.write('"');
+    }
+    canConvertUnlessToTernary(node) {
+        const unlessOnlyText = node.statements ? node.statements.every(statement => statement.type === "AST_HTML_TEXT_NODE") : true;
+        if (!unlessOnlyText)
+            return false;
+        if (node.else_clause && node.else_clause.type === "AST_ERB_ELSE_NODE") {
+            return node.else_clause.statements
+                ? node.else_clause.statements.every(statement => statement.type === "AST_HTML_TEXT_NODE")
+                : true;
+        }
+        return true;
+    }
+    convertUnlessToTernary(node) {
+        this.context.write("#{");
+        if (node.content?.value) {
+            const condition = node.content.value.trim();
+            const cleanCondition = condition.replace(/^unless\s+/, '');
+            const needsParentheses = cleanCondition.includes(' ');
+            this.context.write("!(");
+            if (needsParentheses) {
+                this.context.write("(");
+            }
+            this.context.write(cleanCondition);
+            if (needsParentheses) {
+                this.context.write(")");
+            }
+            this.context.write(")");
+        }
+        this.context.write(" ? ");
+        this.context.write('"');
+        if (node.statements) {
+            node.statements.forEach(statement => this.visit(statement));
+        }
+        this.context.write('"');
+        this.context.write(" : ");
+        this.context.write('"');
+        if (node.else_clause && node.else_clause.type === "AST_ERB_ELSE_NODE") {
+            node.else_clause.statements.forEach(statement => this.visit(statement));
+        }
+        this.context.write('"');
+        this.context.write("}");
+    }
+    convertUnlessToTernaryWithoutWrapper(node) {
+        if (node.content?.value) {
+            const condition = node.content.value.trim();
+            const cleanCondition = condition.replace(/^unless\s+/, '');
+            const needsParentheses = cleanCondition.includes(' ');
+            this.context.write("!(");
+            if (needsParentheses) {
+                this.context.write("(");
+            }
+            this.context.write(cleanCondition);
+            if (needsParentheses) {
+                this.context.write(")");
+            }
+            this.context.write(")");
+        }
+        this.context.write(" ? ");
+        this.context.write('"');
+        if (node.statements) {
+            node.statements.forEach(statement => this.visit(statement));
+        }
+        this.context.write('"');
+        this.context.write(" : ");
+        this.context.write('"');
+        if (node.else_clause && node.else_clause.type === "AST_ERB_ELSE_NODE") {
+            node.else_clause.statements.forEach(statement => this.visit(statement));
+        }
+        this.context.write('"');
+    }
+}
+
+class ERBPreferImageTagHelperVisitor extends BaseRuleVisitor {
+    visitHTMLOpenTagNode(node) {
+        this.checkImgTag(node);
+        super.visitHTMLOpenTagNode(node);
+    }
+    checkImgTag(openTag) {
+        const tagName = getTagName(openTag);
+        if (tagName !== "img")
+            return;
+        const attributes = getAttributes(openTag);
+        const srcAttribute = findAttributeByName(attributes, "src");
+        if (!srcAttribute)
+            return;
+        if (!srcAttribute.value)
+            return;
+        const node = srcAttribute.value;
+        const hasERBContent = this.containsERBContent(node);
+        if (hasERBContent) {
+            if (this.isDataUri(node))
+                return;
+            if (this.shouldFlagAsImageTagCandidate(node)) {
+                const suggestedExpression = this.buildSuggestedExpression(node);
+                this.addOffense(`Prefer \`image_tag\` helper over manual \`<img>\` with dynamic ERB expressions. Use \`<%= image_tag ${suggestedExpression}, alt: "..." %>\` instead.`, srcAttribute.location, "warning");
+            }
+        }
+    }
+    containsERBContent(node) {
+        return core.filterNodes(node.children, core.ERBContentNode).length > 0;
+    }
+    isOnlyERBContent(node) {
+        return node.children.length > 0 && node.children.length === core.filterNodes(node.children, core.ERBContentNode).length;
+    }
+    getContentofFirstChild(node) {
+        if (!node.children || node.children.length === 0)
+            return "";
+        const firstChild = node.children[0];
+        if (core.isNode(firstChild, core.LiteralNode)) {
+            return (firstChild.content || "").trim();
+        }
+        return "";
+    }
+    isDataUri(node) {
+        return this.getContentofFirstChild(node).startsWith("data:");
+    }
+    isFullUrl(node) {
+        const content = this.getContentofFirstChild(node);
+        return content.startsWith("http://") || content.startsWith("https://");
+    }
+    shouldFlagAsImageTagCandidate(node) {
+        if (this.isOnlyERBContent(node))
+            return true;
+        if (this.isFullUrl(node))
+            return false;
+        return true;
+    }
+    buildSuggestedExpression(node) {
+        if (!node.children)
+            return "expression";
+        try {
+            return ERBToRubyStringPrinter.print(node, { ignoreErrors: false });
+        }
+        catch (error) {
+            return "expression";
+        }
     }
 }
 class ERBPreferImageTagHelperRule extends ParserRule {
@@ -1299,19 +2018,141 @@ class HTMLNoDuplicateAttributesRule extends ParserRule {
     }
 }
 
-class NoDuplicateIdsVisitor extends AttributeVisitorMixin {
+class OutputPrinter extends Printer {
+    visitLiteralNode(node) {
+        this.write(IdentityPrinter.print(node));
+    }
+    visitERBContentNode(node) {
+        if (core.isERBOutputNode(node)) {
+            this.write(IdentityPrinter.print(node));
+        }
+    }
+}
+class NoDuplicateIdsVisitor extends ControlFlowTrackingVisitor {
     documentIds = new Set();
-    checkStaticAttributeStaticValue({ attributeName, attributeValue, attributeNode }) {
-        if (attributeName.toLowerCase() !== "id")
+    currentBranchIds = new Set();
+    controlFlowIds = new Set();
+    visitHTMLAttributeNode(node) {
+        this.checkAttribute(node);
+    }
+    onEnterControlFlow(_controlFlowType, wasAlreadyInControlFlow) {
+        const stateToRestore = {
+            previousBranchIds: this.currentBranchIds,
+            previousControlFlowIds: this.controlFlowIds
+        };
+        this.currentBranchIds = new Set();
+        if (!wasAlreadyInControlFlow) {
+            this.controlFlowIds = new Set();
+        }
+        return stateToRestore;
+    }
+    onExitControlFlow(controlFlowType, wasAlreadyInControlFlow, stateToRestore) {
+        if (controlFlowType === ControlFlowType.CONDITIONAL && !wasAlreadyInControlFlow) {
+            this.controlFlowIds.forEach(id => this.documentIds.add(id));
+        }
+        this.currentBranchIds = stateToRestore.previousBranchIds;
+        this.controlFlowIds = stateToRestore.previousControlFlowIds;
+    }
+    onEnterBranch() {
+        const stateToRestore = {
+            previousBranchIds: this.currentBranchIds
+        };
+        if (this.isInControlFlow) {
+            this.currentBranchIds = new Set();
+        }
+        return stateToRestore;
+    }
+    onExitBranch(_stateToRestore) { }
+    checkAttribute(attributeNode) {
+        if (!this.isIdAttribute(attributeNode))
             return;
-        if (!attributeValue)
+        const idValue = this.extractIdValue(attributeNode);
+        if (!idValue)
             return;
-        const id = attributeValue.trim();
-        if (this.documentIds.has(id)) {
-            this.addOffense(`Duplicate ID \`${id}\` found. IDs must be unique within a document.`, attributeNode.location, "error");
+        if (this.isWhitespaceOnlyId(idValue.identifier))
             return;
+        this.processIdDuplicate(idValue, attributeNode);
+    }
+    isIdAttribute(attributeNode) {
+        if (!attributeNode.name?.children || !attributeNode.value)
+            return false;
+        return core.getStaticAttributeName(attributeNode.name) === "id";
+    }
+    extractIdValue(attributeNode) {
+        const valueNodes = attributeNode.value?.children || [];
+        if (core.hasERBOutput(valueNodes) && this.isInControlFlow && this.currentControlFlowType === ControlFlowType.LOOP) {
+            return null;
         }
-        this.documentIds.add(id);
+        const identifier = core.isEffectivelyStatic(valueNodes) ? core.getValidatableStaticContent(valueNodes) : OutputPrinter.print(valueNodes);
+        if (!identifier)
+            return null;
+        return { identifier, shouldTrackDuplicates: true };
+    }
+    isWhitespaceOnlyId(identifier) {
+        return identifier !== '' && identifier.trim() === '';
+    }
+    processIdDuplicate(idValue, attributeNode) {
+        const { identifier, shouldTrackDuplicates } = idValue;
+        if (!shouldTrackDuplicates)
+            return;
+        if (this.isInControlFlow) {
+            this.handleControlFlowId(identifier, attributeNode);
+        }
+        else {
+            this.handleGlobalId(identifier, attributeNode);
+        }
+    }
+    handleControlFlowId(identifier, attributeNode) {
+        if (this.currentControlFlowType === ControlFlowType.LOOP) {
+            this.handleLoopId(identifier, attributeNode);
+        }
+        else {
+            this.handleConditionalId(identifier, attributeNode);
+        }
+        this.currentBranchIds.add(identifier);
+    }
+    handleLoopId(identifier, attributeNode) {
+        const isStaticId = this.isStaticId(attributeNode);
+        if (isStaticId) {
+            this.addDuplicateIdOffense(identifier, attributeNode.location);
+            return;
+        }
+        if (this.currentBranchIds.has(identifier)) {
+            this.addSameLoopIterationOffense(identifier, attributeNode.location);
+        }
+    }
+    handleConditionalId(identifier, attributeNode) {
+        if (this.currentBranchIds.has(identifier)) {
+            this.addSameBranchOffense(identifier, attributeNode.location);
+            return;
+        }
+        if (this.documentIds.has(identifier)) {
+            this.addDuplicateIdOffense(identifier, attributeNode.location);
+            return;
+        }
+        this.controlFlowIds.add(identifier);
+    }
+    handleGlobalId(identifier, attributeNode) {
+        if (this.documentIds.has(identifier)) {
+            this.addDuplicateIdOffense(identifier, attributeNode.location);
+            return;
+        }
+        this.documentIds.add(identifier);
+    }
+    isStaticId(attributeNode) {
+        const valueNodes = attributeNode.value.children;
+        const isCompletelyStatic = valueNodes.every(child => core.isNode(child, core.LiteralNode));
+        const isEffectivelyStaticValue = core.isEffectivelyStatic(valueNodes);
+        return isCompletelyStatic || isEffectivelyStaticValue;
+    }
+    addDuplicateIdOffense(identifier, location) {
+        this.addOffense(`Duplicate ID \`${identifier}\` found. IDs must be unique within a document.`, location, "error");
+    }
+    addSameLoopIterationOffense(identifier, location) {
+        this.addOffense(`Duplicate ID \`${identifier}\` found within the same loop iteration. IDs must be unique within the same loop iteration.`, location, "error");
+    }
+    addSameBranchOffense(identifier, location) {
+        this.addOffense(`Duplicate ID \`${identifier}\` found within the same control flow branch. IDs must be unique within the same control flow branch.`, location, "error");
     }
 }
 class HTMLNoDuplicateIdsRule extends ParserRule {
@@ -1513,14 +2354,20 @@ class HTMLNoPositiveTabIndexRule extends ParserRule {
 }
 
 class NoSelfClosingVisitor extends BaseRuleVisitor {
+    visitHTMLElementNode(node) {
+        if (core.getTagName(node) === "svg") {
+            this.visit(node.open_tag);
+        }
+        else {
+            this.visitChildNodes(node);
+        }
+    }
     visitHTMLOpenTagNode(node) {
         if (node.tag_closing?.value === "/>") {
-            const tagName = getTagName(node);
-            const shouldBeVoid = tagName ? isVoidElement(tagName) : false;
-            const instead = shouldBeVoid ? `Use \`<${tagName}>\` instead.` : `Use \`<${tagName}></${tagName}>\` instead.`;
-            this.addOffense(`Self-closing syntax \`<${tagName} />\` is not allowed in HTML. ${instead}`, node.location, "error");
+            const tagName = core.getTagName(node);
+            const instead = isVoidElement(tagName) ? `<${tagName}>` : `<${tagName}></${tagName}>`;
+            this.addOffense(`Use \`${instead}\` instead of self-closing \`<${tagName} />\` for HTML compatibility.`, node.location, "error");
         }
-        super.visitHTMLOpenTagNode(node);
     }
 }
 class HTMLNoSelfClosingRule extends ParserRule {