@herb-tools/linter 0.5.0 → 0.6.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/herb-lint.js +6627 -1937
- package/dist/herb-lint.js.map +1 -1
- package/dist/index.cjs +1574 -210
- package/dist/index.cjs.map +1 -1
- package/dist/index.js +1566 -212
- package/dist/index.js.map +1 -1
- package/dist/package.json +5 -4
- package/dist/src/cli/argument-parser.js +0 -4
- package/dist/src/cli/argument-parser.js.map +1 -1
- package/dist/src/default-rules.js +20 -0
- package/dist/src/default-rules.js.map +1 -1
- package/dist/src/linter.js +29 -4
- package/dist/src/linter.js.map +1 -1
- package/dist/src/rules/erb-no-silent-tag-in-attribute-name.js +26 -0
- package/dist/src/rules/erb-no-silent-tag-in-attribute-name.js.map +1 -0
- package/dist/src/rules/erb-prefer-image-tag-helper.js +50 -64
- package/dist/src/rules/erb-prefer-image-tag-helper.js.map +1 -1
- package/dist/src/rules/html-aria-attribute-must-be-valid.js +11 -10
- package/dist/src/rules/html-aria-attribute-must-be-valid.js.map +1 -1
- package/dist/src/rules/html-aria-label-is-well-formatted.js +33 -0
- package/dist/src/rules/html-aria-label-is-well-formatted.js.map +1 -0
- package/dist/src/rules/html-aria-level-must-be-valid.js +26 -4
- package/dist/src/rules/html-aria-level-must-be-valid.js.map +1 -1
- package/dist/src/rules/html-aria-role-heading-requires-level.js +7 -13
- package/dist/src/rules/html-aria-role-heading-requires-level.js.map +1 -1
- package/dist/src/rules/html-aria-role-must-be-valid.js +3 -3
- package/dist/src/rules/html-aria-role-must-be-valid.js.map +1 -1
- package/dist/src/rules/html-attribute-double-quotes.js +14 -4
- package/dist/src/rules/html-attribute-double-quotes.js.map +1 -1
- package/dist/src/rules/html-attribute-equals-spacing.js +24 -0
- package/dist/src/rules/html-attribute-equals-spacing.js.map +1 -0
- package/dist/src/rules/html-attribute-values-require-quotes.js +19 -8
- package/dist/src/rules/html-attribute-values-require-quotes.js.map +1 -1
- package/dist/src/rules/html-avoid-both-disabled-and-aria-disabled.js +47 -0
- package/dist/src/rules/html-avoid-both-disabled-and-aria-disabled.js.map +1 -0
- package/dist/src/rules/html-boolean-attributes-no-value.js +9 -2
- package/dist/src/rules/html-boolean-attributes-no-value.js.map +1 -1
- package/dist/src/rules/html-iframe-has-title.js +39 -0
- package/dist/src/rules/html-iframe-has-title.js.map +1 -0
- package/dist/src/rules/html-img-require-alt.js +0 -4
- package/dist/src/rules/html-img-require-alt.js.map +1 -1
- package/dist/src/rules/html-navigation-has-label.js +43 -0
- package/dist/src/rules/html-navigation-has-label.js.map +1 -0
- package/dist/src/rules/html-no-aria-hidden-on-focusable.js +67 -0
- package/dist/src/rules/html-no-aria-hidden-on-focusable.js.map +1 -0
- package/dist/src/rules/html-no-duplicate-attributes.js +22 -25
- package/dist/src/rules/html-no-duplicate-attributes.js.map +1 -1
- package/dist/src/rules/html-no-duplicate-ids.js +134 -9
- package/dist/src/rules/html-no-duplicate-ids.js.map +1 -1
- package/dist/src/rules/html-no-empty-headings.js +0 -21
- package/dist/src/rules/html-no-empty-headings.js.map +1 -1
- package/dist/src/rules/html-no-positive-tab-index.js +21 -0
- package/dist/src/rules/html-no-positive-tab-index.js.map +1 -0
- package/dist/src/rules/html-no-self-closing.js +29 -0
- package/dist/src/rules/html-no-self-closing.js.map +1 -0
- package/dist/src/rules/html-no-title-attribute.js +27 -0
- package/dist/src/rules/html-no-title-attribute.js.map +1 -0
- package/dist/src/rules/html-tag-name-lowercase.js +35 -23
- package/dist/src/rules/html-tag-name-lowercase.js.map +1 -1
- package/dist/src/rules/index.js +10 -0
- package/dist/src/rules/index.js.map +1 -1
- package/dist/src/rules/rule-utils.js +245 -22
- package/dist/src/rules/rule-utils.js.map +1 -1
- package/dist/src/rules/svg-tag-name-capitalization.js +0 -8
- package/dist/src/rules/svg-tag-name-capitalization.js.map +1 -1
- package/dist/src/types.js.map +1 -1
- package/dist/tsconfig.tsbuildinfo +1 -1
- package/dist/types/cli/index.d.ts +4 -0
- package/dist/types/rules/erb-no-silent-tag-in-attribute-name.d.ts +7 -0
- package/dist/types/rules/html-aria-label-is-well-formatted.d.ts +7 -0
- package/dist/types/rules/html-attribute-equals-spacing.d.ts +7 -0
- package/dist/types/rules/html-avoid-both-disabled-and-aria-disabled.d.ts +7 -0
- package/dist/types/rules/html-iframe-has-title.d.ts +7 -0
- package/dist/types/rules/html-navigation-has-label.d.ts +7 -0
- package/dist/types/rules/html-no-aria-hidden-on-focusable.d.ts +7 -0
- package/dist/types/rules/html-no-positive-tab-index.d.ts +7 -0
- package/dist/types/rules/html-no-self-closing.d.ts +7 -0
- package/dist/types/rules/html-no-title-attribute.d.ts +7 -0
- package/dist/types/rules/html-tag-name-lowercase.d.ts +2 -1
- package/dist/types/rules/index.d.ts +10 -0
- package/dist/types/rules/rule-utils.d.ts +146 -13
- package/dist/types/src/rules/erb-no-silent-tag-in-attribute-name.d.ts +7 -0
- package/dist/types/src/rules/html-aria-label-is-well-formatted.d.ts +7 -0
- package/dist/types/src/rules/html-attribute-equals-spacing.d.ts +7 -0
- package/dist/types/src/rules/html-avoid-both-disabled-and-aria-disabled.d.ts +7 -0
- package/dist/types/src/rules/html-iframe-has-title.d.ts +7 -0
- package/dist/types/src/rules/html-navigation-has-label.d.ts +7 -0
- package/dist/types/src/rules/html-no-aria-hidden-on-focusable.d.ts +7 -0
- package/dist/types/src/rules/html-no-positive-tab-index.d.ts +7 -0
- package/dist/types/src/rules/html-no-self-closing.d.ts +7 -0
- package/dist/types/src/rules/html-no-title-attribute.d.ts +7 -0
- package/dist/types/src/rules/html-tag-name-lowercase.d.ts +2 -1
- package/dist/types/src/rules/index.d.ts +10 -0
- package/dist/types/src/rules/rule-utils.d.ts +146 -13
- package/dist/types/src/types.d.ts +24 -0
- package/dist/types/types.d.ts +24 -0
- package/docs/rules/README.md +12 -2
- package/docs/rules/erb-no-silent-tag-in-attribute-name.md +34 -0
- package/docs/rules/html-aria-label-is-well-formatted.md +49 -0
- package/docs/rules/html-attribute-equals-spacing.md +35 -0
- package/docs/rules/html-avoid-both-disabled-and-aria-disabled.md +48 -0
- package/docs/rules/html-iframe-has-title.md +43 -0
- package/docs/rules/html-navigation-has-label.md +61 -0
- package/docs/rules/html-no-aria-hidden-on-focusable.md +54 -0
- package/docs/rules/html-no-positive-tab-index.md +55 -0
- package/docs/rules/html-no-self-closing.md +65 -0
- package/docs/rules/html-no-title-attribute.md +69 -0
- package/docs/rules/html-tag-name-lowercase.md +16 -3
- package/package.json +5 -4
- package/src/cli/argument-parser.ts +0 -5
- package/src/default-rules.ts +20 -0
- package/src/linter.ts +30 -4
- package/src/rules/erb-no-silent-tag-in-attribute-name.ts +40 -0
- package/src/rules/erb-prefer-image-tag-helper.ts +53 -76
- package/src/rules/html-aria-attribute-must-be-valid.ts +28 -32
- package/src/rules/html-aria-label-is-well-formatted.ts +59 -0
- package/src/rules/html-aria-level-must-be-valid.ts +38 -5
- package/src/rules/html-aria-role-heading-requires-level.ts +16 -28
- package/src/rules/html-aria-role-must-be-valid.ts +5 -5
- package/src/rules/html-attribute-double-quotes.ts +21 -6
- package/src/rules/html-attribute-equals-spacing.ts +41 -0
- package/src/rules/html-attribute-values-require-quotes.ts +29 -9
- package/src/rules/html-avoid-both-disabled-and-aria-disabled.ts +66 -0
- package/src/rules/html-boolean-attributes-no-value.ts +17 -4
- package/src/rules/html-iframe-has-title.ts +62 -0
- package/src/rules/html-img-require-alt.ts +2 -7
- package/src/rules/html-navigation-has-label.ts +64 -0
- package/src/rules/html-no-aria-hidden-on-focusable.ts +90 -0
- package/src/rules/html-no-duplicate-attributes.ts +28 -28
- package/src/rules/html-no-duplicate-ids.ts +189 -14
- package/src/rules/html-no-empty-headings.ts +2 -31
- package/src/rules/html-no-positive-tab-index.ts +33 -0
- package/src/rules/html-no-self-closing.ts +41 -0
- package/src/rules/html-no-title-attribute.ts +42 -0
- package/src/rules/html-tag-name-lowercase.ts +42 -29
- package/src/rules/index.ts +10 -0
- package/src/rules/rule-utils.ts +357 -39
- package/src/rules/svg-tag-name-capitalization.ts +2 -9
- package/src/types.ts +27 -0
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"html-img-require-alt.js","sourceRoot":"","sources":["../../../src/rules/html-img-require-alt.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,eAAe,EAAE,UAAU,EAAE,YAAY,EAAE,MAAM,iBAAiB,CAAA;AAE3E,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AAIxC,MAAM,oBAAqB,SAAQ,eAAe;IAChD,oBAAoB,CAAC,IAAqB;QACxC,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,CAAA;QACtB,KAAK,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAA;IAClC,CAAC;
|
|
1
|
+
{"version":3,"file":"html-img-require-alt.js","sourceRoot":"","sources":["../../../src/rules/html-img-require-alt.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,eAAe,EAAE,UAAU,EAAE,YAAY,EAAE,MAAM,iBAAiB,CAAA;AAE3E,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AAIxC,MAAM,oBAAqB,SAAQ,eAAe;IAChD,oBAAoB,CAAC,IAAqB;QACxC,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,CAAA;QACtB,KAAK,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAA;IAClC,CAAC;IAEO,WAAW,CAAC,IAAqB;QACvC,MAAM,OAAO,GAAG,UAAU,CAAC,IAAI,CAAC,CAAA;QAEhC,IAAI,OAAO,KAAK,KAAK,EAAE,CAAC;YACtB,OAAM;QACR,CAAC;QAED,IAAI,CAAC,YAAY,CAAC,IAAI,EAAE,KAAK,CAAC,EAAE,CAAC;YAC/B,IAAI,CAAC,UAAU,CACb,oIAAoI,EACpI,IAAI,CAAC,QAAS,CAAC,QAAQ,EACvB,OAAO,CACR,CAAA;QACH,CAAC;IACH,CAAC;CACF;AAED,MAAM,OAAO,qBAAsB,SAAQ,UAAU;IACnD,IAAI,GAAG,sBAAsB,CAAA;IAE7B,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,oBAAoB,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAC5D,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAC3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}
|
|
@@ -0,0 +1,43 @@
|
|
|
1
|
+
import { ParserRule } from "../types.js";
|
|
2
|
+
import { BaseRuleVisitor, getTagName, hasAttribute, getAttributeValue, findAttributeByName, getAttributes } from "./rule-utils.js";
|
|
3
|
+
class NavigationHasLabelVisitor extends BaseRuleVisitor {
|
|
4
|
+
visitHTMLOpenTagNode(node) {
|
|
5
|
+
this.checkNavigationElement(node);
|
|
6
|
+
super.visitHTMLOpenTagNode(node);
|
|
7
|
+
}
|
|
8
|
+
checkNavigationElement(node) {
|
|
9
|
+
const tagName = getTagName(node);
|
|
10
|
+
const isNavElement = tagName === "nav";
|
|
11
|
+
const hasNavigationRole = this.hasRoleNavigation(node);
|
|
12
|
+
if (!isNavElement && !hasNavigationRole) {
|
|
13
|
+
return;
|
|
14
|
+
}
|
|
15
|
+
const hasAriaLabel = hasAttribute(node, "aria-label");
|
|
16
|
+
const hasAriaLabelledby = hasAttribute(node, "aria-labelledby");
|
|
17
|
+
if (!hasAriaLabel && !hasAriaLabelledby) {
|
|
18
|
+
let message = `The navigation landmark should have a unique accessible name via \`aria-label\` or \`aria-labelledby\`. Remember that the name does not need to include "navigation" or "nav" since it will already be announced.`;
|
|
19
|
+
if (hasNavigationRole && !isNavElement) {
|
|
20
|
+
message += ` Additionally, you can safely drop the \`role="navigation"\` and replace it with the native HTML \`<nav>\` element.`;
|
|
21
|
+
}
|
|
22
|
+
this.addOffense(message, node.tag_name.location, "error");
|
|
23
|
+
}
|
|
24
|
+
}
|
|
25
|
+
hasRoleNavigation(node) {
|
|
26
|
+
const attributes = getAttributes(node);
|
|
27
|
+
const roleAttribute = findAttributeByName(attributes, "role");
|
|
28
|
+
if (!roleAttribute) {
|
|
29
|
+
return false;
|
|
30
|
+
}
|
|
31
|
+
const roleValue = getAttributeValue(roleAttribute);
|
|
32
|
+
return roleValue === "navigation";
|
|
33
|
+
}
|
|
34
|
+
}
|
|
35
|
+
export class HTMLNavigationHasLabelRule extends ParserRule {
|
|
36
|
+
name = "html-navigation-has-label";
|
|
37
|
+
check(result, context) {
|
|
38
|
+
const visitor = new NavigationHasLabelVisitor(this.name, context);
|
|
39
|
+
visitor.visit(result.value);
|
|
40
|
+
return visitor.offenses;
|
|
41
|
+
}
|
|
42
|
+
}
|
|
43
|
+
//# sourceMappingURL=html-navigation-has-label.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"html-navigation-has-label.js","sourceRoot":"","sources":["../../../src/rules/html-navigation-has-label.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,eAAe,EAAE,UAAU,EAAE,YAAY,EAAE,iBAAiB,EAAE,mBAAmB,EAAE,aAAa,EAAE,MAAM,iBAAiB,CAAA;AAKlI,MAAM,yBAA0B,SAAQ,eAAe;IACrD,oBAAoB,CAAC,IAAqB;QACxC,IAAI,CAAC,sBAAsB,CAAC,IAAI,CAAC,CAAA;QACjC,KAAK,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAA;IAClC,CAAC;IAEO,sBAAsB,CAAC,IAAqB;QAClD,MAAM,OAAO,GAAG,UAAU,CAAC,IAAI,CAAC,CAAA;QAChC,MAAM,YAAY,GAAG,OAAO,KAAK,KAAK,CAAA;QACtC,MAAM,iBAAiB,GAAG,IAAI,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAA;QAEtD,IAAI,CAAC,YAAY,IAAI,CAAC,iBAAiB,EAAE,CAAC;YACxC,OAAM;QACR,CAAC;QAED,MAAM,YAAY,GAAG,YAAY,CAAC,IAAI,EAAE,YAAY,CAAC,CAAA;QACrD,MAAM,iBAAiB,GAAG,YAAY,CAAC,IAAI,EAAE,iBAAiB,CAAC,CAAA;QAE/D,IAAI,CAAC,YAAY,IAAI,CAAC,iBAAiB,EAAE,CAAC;YACxC,IAAI,OAAO,GAAG,mNAAmN,CAAA;YAEjO,IAAI,iBAAiB,IAAI,CAAC,YAAY,EAAE,CAAC;gBACvC,OAAO,IAAI,qHAAqH,CAAA;YAClI,CAAC;YAED,IAAI,CAAC,UAAU,CACb,OAAO,EACP,IAAI,CAAC,QAAS,CAAC,QAAQ,EACvB,OAAO,CACR,CAAA;QACH,CAAC;IACH,CAAC;IAEO,iBAAiB,CAAC,IAAqB;QAC7C,MAAM,UAAU,GAAG,aAAa,CAAC,IAAI,CAAC,CAAA;QACtC,MAAM,aAAa,GAAG,mBAAmB,CAAC,UAAU,EAAE,MAAM,CAAC,CAAA;QAE7D,IAAI,CAAC,aAAa,EAAE,CAAC;YACnB,OAAO,KAAK,CAAA;QACd,CAAC;QAED,MAAM,SAAS,GAAG,iBAAiB,CAAC,aAAa,CAAC,CAAA;QAElD,OAAO,SAAS,KAAK,YAAY,CAAA;IACnC,CAAC;CACF;AAED,MAAM,OAAO,0BAA2B,SAAQ,UAAU;IACxD,IAAI,GAAG,2BAA2B,CAAA;IAElC,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,yBAAyB,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAEjE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}
|
|
@@ -0,0 +1,67 @@
|
|
|
1
|
+
import { ParserRule } from "../types.js";
|
|
2
|
+
import { BaseRuleVisitor, getTagName, hasAttribute, getAttributeValue, findAttributeByName, getAttributes } from "./rule-utils.js";
|
|
3
|
+
const INTERACTIVE_ELEMENTS = new Set([
|
|
4
|
+
"button", "summary", "input", "select", "textarea", "a"
|
|
5
|
+
]);
|
|
6
|
+
class NoAriaHiddenOnFocusableVisitor extends BaseRuleVisitor {
|
|
7
|
+
visitHTMLOpenTagNode(node) {
|
|
8
|
+
this.checkAriaHiddenOnFocusable(node);
|
|
9
|
+
super.visitHTMLOpenTagNode(node);
|
|
10
|
+
}
|
|
11
|
+
checkAriaHiddenOnFocusable(node) {
|
|
12
|
+
if (!this.hasAriaHiddenTrue(node))
|
|
13
|
+
return;
|
|
14
|
+
if (this.isFocusable(node)) {
|
|
15
|
+
this.addOffense(`Elements that are focusable should not have \`aria-hidden="true"\` because it will cause confusion for assistive technology users.`, node.tag_name.location, "error");
|
|
16
|
+
}
|
|
17
|
+
}
|
|
18
|
+
hasAriaHiddenTrue(node) {
|
|
19
|
+
const attributes = getAttributes(node);
|
|
20
|
+
const ariaHiddenAttr = findAttributeByName(attributes, "aria-hidden");
|
|
21
|
+
if (!ariaHiddenAttr)
|
|
22
|
+
return false;
|
|
23
|
+
const value = getAttributeValue(ariaHiddenAttr);
|
|
24
|
+
return value === "true";
|
|
25
|
+
}
|
|
26
|
+
isFocusable(node) {
|
|
27
|
+
const tagName = getTagName(node);
|
|
28
|
+
if (!tagName)
|
|
29
|
+
return false;
|
|
30
|
+
const tabIndexValue = this.getTabIndexValue(node);
|
|
31
|
+
if (tagName === "a") {
|
|
32
|
+
const hasHref = hasAttribute(node, "href");
|
|
33
|
+
if (!hasHref) {
|
|
34
|
+
return tabIndexValue !== null && tabIndexValue >= 0;
|
|
35
|
+
}
|
|
36
|
+
return tabIndexValue === null || tabIndexValue >= 0;
|
|
37
|
+
}
|
|
38
|
+
if (INTERACTIVE_ELEMENTS.has(tagName)) {
|
|
39
|
+
// Interactive elements are focusable unless tabindex is negative
|
|
40
|
+
return tabIndexValue === null || tabIndexValue >= 0;
|
|
41
|
+
}
|
|
42
|
+
else {
|
|
43
|
+
// Non-interactive elements are focusable only if tabindex >= 0
|
|
44
|
+
return tabIndexValue !== null && tabIndexValue >= 0;
|
|
45
|
+
}
|
|
46
|
+
}
|
|
47
|
+
getTabIndexValue(node) {
|
|
48
|
+
const attributes = getAttributes(node);
|
|
49
|
+
const tabIndexAttribute = findAttributeByName(attributes, "tabindex");
|
|
50
|
+
if (!tabIndexAttribute)
|
|
51
|
+
return null;
|
|
52
|
+
const value = getAttributeValue(tabIndexAttribute);
|
|
53
|
+
if (!value)
|
|
54
|
+
return null;
|
|
55
|
+
const parsed = parseInt(value, 10);
|
|
56
|
+
return isNaN(parsed) ? null : parsed;
|
|
57
|
+
}
|
|
58
|
+
}
|
|
59
|
+
export class HTMLNoAriaHiddenOnFocusableRule extends ParserRule {
|
|
60
|
+
name = "html-no-aria-hidden-on-focusable";
|
|
61
|
+
check(result, context) {
|
|
62
|
+
const visitor = new NoAriaHiddenOnFocusableVisitor(this.name, context);
|
|
63
|
+
visitor.visit(result.value);
|
|
64
|
+
return visitor.offenses;
|
|
65
|
+
}
|
|
66
|
+
}
|
|
67
|
+
//# sourceMappingURL=html-no-aria-hidden-on-focusable.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"html-no-aria-hidden-on-focusable.js","sourceRoot":"","sources":["../../../src/rules/html-no-aria-hidden-on-focusable.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,eAAe,EAAE,UAAU,EAAE,YAAY,EAAE,iBAAiB,EAAE,mBAAmB,EAAE,aAAa,EAAE,MAAM,iBAAiB,CAAA;AAKlI,MAAM,oBAAoB,GAAG,IAAI,GAAG,CAAC;IACnC,QAAQ,EAAE,SAAS,EAAE,OAAO,EAAE,QAAQ,EAAE,UAAU,EAAE,GAAG;CACxD,CAAC,CAAA;AAEF,MAAM,8BAA+B,SAAQ,eAAe;IAC1D,oBAAoB,CAAC,IAAqB;QACxC,IAAI,CAAC,0BAA0B,CAAC,IAAI,CAAC,CAAA;QACrC,KAAK,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAA;IAClC,CAAC;IAEO,0BAA0B,CAAC,IAAqB;QACtD,IAAI,CAAC,IAAI,CAAC,iBAAiB,CAAC,IAAI,CAAC;YAAE,OAAM;QAEzC,IAAI,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,EAAE,CAAC;YAC3B,IAAI,CAAC,UAAU,CACb,oIAAoI,EACpI,IAAI,CAAC,QAAS,CAAC,QAAQ,EACvB,OAAO,CACR,CAAA;QACH,CAAC;IACH,CAAC;IAEO,iBAAiB,CAAC,IAAqB;QAC7C,MAAM,UAAU,GAAG,aAAa,CAAC,IAAI,CAAC,CAAA;QACtC,MAAM,cAAc,GAAG,mBAAmB,CAAC,UAAU,EAAE,aAAa,CAAC,CAAA;QAErE,IAAI,CAAC,cAAc;YAAE,OAAO,KAAK,CAAA;QAEjC,MAAM,KAAK,GAAG,iBAAiB,CAAC,cAAc,CAAC,CAAA;QAE/C,OAAO,KAAK,KAAK,MAAM,CAAA;IACzB,CAAC;IAEO,WAAW,CAAC,IAAqB;QACvC,MAAM,OAAO,GAAG,UAAU,CAAC,IAAI,CAAC,CAAA;QAChC,IAAI,CAAC,OAAO;YAAE,OAAO,KAAK,CAAA;QAE1B,MAAM,aAAa,GAAG,IAAI,CAAC,gBAAgB,CAAC,IAAI,CAAC,CAAA;QAEjD,IAAI,OAAO,KAAK,GAAG,EAAE,CAAC;YACpB,MAAM,OAAO,GAAG,YAAY,CAAC,IAAI,EAAE,MAAM,CAAC,CAAA;YAE1C,IAAI,CAAC,OAAO,EAAE,CAAC;gBACb,OAAO,aAAa,KAAK,IAAI,IAAI,aAAa,IAAI,CAAC,CAAA;YACrD,CAAC;YAED,OAAO,aAAa,KAAK,IAAI,IAAI,aAAa,IAAI,CAAC,CAAA;QACrD,CAAC;QAED,IAAI,oBAAoB,CAAC,GAAG,CAAC,OAAO,CAAC,EAAE,CAAC;YACtC,iEAAiE;YACjE,OAAO,aAAa,KAAK,IAAI,IAAI,aAAa,IAAI,CAAC,CAAA;QACrD,CAAC;aAAM,CAAC;YACN,+DAA+D;YAC/D,OAAO,aAAa,KAAK,IAAI,IAAI,aAAa,IAAI,CAAC,CAAA;QACrD,CAAC;IACH,CAAC;IAEO,gBAAgB,CAAC,IAAqB;QAC5C,MAAM,UAAU,GAAG,aAAa,CAAC,IAAI,CAAC,CAAA;QACtC,MAAM,iBAAiB,GAAG,mBAAmB,CAAC,UAAU,EAAE,UAAU,CAAC,CAAA;QAErE,IAAI,CAAC,iBAAiB;YAAE,OAAO,IAAI,CAAA;QAEnC,MAAM,KAAK,GAAG,iBAAiB,CAAC,iBAAiB,CAAC,CAAA;QAClD,IAAI,CAAC,KAAK;YAAE,OAAO,IAAI,CAAA;QAEvB,MAAM,MAAM,GAAG,QAAQ,CAAC,KAAK,EAAE,EAAE,CAAC,CAAA;QAElC,OAAO,KAAK,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,MAAM,CAAA;IACtC,CAAC;CACF;AAED,MAAM,OAAO,+BAAgC,SAAQ,UAAU;IAC7D,IAAI,GAAG,kCAAkC,CAAA;IAEzC,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,8BAA8B,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAEtE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}
|
|
@@ -1,33 +1,30 @@
|
|
|
1
|
-
import { BaseRuleVisitor, forEachAttribute } from "./rule-utils.js";
|
|
2
1
|
import { ParserRule } from "../types.js";
|
|
3
|
-
|
|
2
|
+
import { AttributeVisitorMixin } from "./rule-utils.js";
|
|
3
|
+
class NoDuplicateAttributesVisitor extends AttributeVisitorMixin {
|
|
4
|
+
attributeNames = new Map();
|
|
4
5
|
visitHTMLOpenTagNode(node) {
|
|
5
|
-
this.
|
|
6
|
+
this.attributeNames.clear();
|
|
6
7
|
super.visitHTMLOpenTagNode(node);
|
|
8
|
+
this.reportDuplicates();
|
|
7
9
|
}
|
|
8
|
-
|
|
9
|
-
this.
|
|
10
|
-
super.visitHTMLSelfCloseTagNode(node);
|
|
10
|
+
checkStaticAttributeStaticValue({ attributeName, attributeNode }) {
|
|
11
|
+
this.trackAttributeName(attributeName, attributeNode);
|
|
11
12
|
}
|
|
12
|
-
|
|
13
|
-
|
|
14
|
-
|
|
15
|
-
|
|
16
|
-
|
|
17
|
-
|
|
18
|
-
|
|
19
|
-
|
|
20
|
-
|
|
21
|
-
|
|
22
|
-
|
|
23
|
-
|
|
24
|
-
|
|
25
|
-
|
|
26
|
-
|
|
27
|
-
if (nameNodes.length > 1) {
|
|
28
|
-
for (let i = 1; i < nameNodes.length; i++) {
|
|
29
|
-
const nameNode = nameNodes[i];
|
|
30
|
-
this.addOffense(`Duplicate attribute \`${attributeName}\` found on tag. Remove the duplicate occurrence.`, nameNode.location, "error");
|
|
13
|
+
checkStaticAttributeDynamicValue({ attributeName, attributeNode }) {
|
|
14
|
+
this.trackAttributeName(attributeName, attributeNode);
|
|
15
|
+
}
|
|
16
|
+
trackAttributeName(attributeName, attributeNode) {
|
|
17
|
+
if (!this.attributeNames.has(attributeName)) {
|
|
18
|
+
this.attributeNames.set(attributeName, []);
|
|
19
|
+
}
|
|
20
|
+
this.attributeNames.get(attributeName).push(attributeNode);
|
|
21
|
+
}
|
|
22
|
+
reportDuplicates() {
|
|
23
|
+
for (const [attributeName, attributeNodes] of this.attributeNames) {
|
|
24
|
+
if (attributeNodes.length > 1) {
|
|
25
|
+
for (let i = 1; i < attributeNodes.length; i++) {
|
|
26
|
+
const attributeNode = attributeNodes[i];
|
|
27
|
+
this.addOffense(`Duplicate attribute \`${attributeName}\` found on tag. Remove the duplicate occurrence.`, attributeNode.name.location, "error");
|
|
31
28
|
}
|
|
32
29
|
}
|
|
33
30
|
}
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"html-no-duplicate-attributes.js","sourceRoot":"","sources":["../../../src/rules/html-no-duplicate-attributes.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,
|
|
1
|
+
{"version":3,"file":"html-no-duplicate-attributes.js","sourceRoot":"","sources":["../../../src/rules/html-no-duplicate-attributes.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,qBAAqB,EAAuE,MAAM,iBAAiB,CAAA;AAK5H,MAAM,4BAA6B,SAAQ,qBAAqB;IACtD,cAAc,GAAG,IAAI,GAAG,EAA+B,CAAA;IAE/D,oBAAoB,CAAC,IAAqB;QACxC,IAAI,CAAC,cAAc,CAAC,KAAK,EAAE,CAAA;QAC3B,KAAK,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAA;QAChC,IAAI,CAAC,gBAAgB,EAAE,CAAA;IACzB,CAAC;IAGS,+BAA+B,CAAC,EAAE,aAAa,EAAE,aAAa,EAAoC;QAC1G,IAAI,CAAC,kBAAkB,CAAC,aAAa,EAAE,aAAa,CAAC,CAAA;IACvD,CAAC;IAES,gCAAgC,CAAC,EAAE,aAAa,EAAE,aAAa,EAAqC;QAC5G,IAAI,CAAC,kBAAkB,CAAC,aAAa,EAAE,aAAa,CAAC,CAAA;IACvD,CAAC;IAEO,kBAAkB,CAAC,aAAqB,EAAE,aAAgC;QAChF,IAAI,CAAC,IAAI,CAAC,cAAc,CAAC,GAAG,CAAC,aAAa,CAAC,EAAE,CAAC;YAC5C,IAAI,CAAC,cAAc,CAAC,GAAG,CAAC,aAAa,EAAE,EAAE,CAAC,CAAA;QAC5C,CAAC;QAED,IAAI,CAAC,cAAc,CAAC,GAAG,CAAC,aAAa,CAAE,CAAC,IAAI,CAAC,aAAa,CAAC,CAAA;IAC7D,CAAC;IAEO,gBAAgB;QACtB,KAAK,MAAM,CAAC,aAAa,EAAE,cAAc,CAAC,IAAI,IAAI,CAAC,cAAc,EAAE,CAAC;YAClE,IAAI,cAAc,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;gBAC9B,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,cAAc,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;oBAC/C,MAAM,aAAa,GAAG,cAAc,CAAC,CAAC,CAAC,CAAA;oBAEvC,IAAI,CAAC,UAAU,CACb,yBAAyB,aAAa,mDAAmD,EACzF,aAAa,CAAC,IAAK,CAAC,QAAQ,EAC5B,OAAO,CACR,CAAA;gBACH,CAAC;YACH,CAAC;QACH,CAAC;IACH,CAAC;CACF;AAED,MAAM,OAAO,6BAA8B,SAAQ,UAAU;IAC3D,IAAI,GAAG,8BAA8B,CAAA;IAErC,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,4BAA4B,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAEpE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}
|
|
@@ -1,18 +1,143 @@
|
|
|
1
|
-
import { AttributeVisitorMixin } from "./rule-utils";
|
|
2
1
|
import { ParserRule } from "../types";
|
|
3
|
-
|
|
2
|
+
import { ControlFlowTrackingVisitor, ControlFlowType } from "./rule-utils";
|
|
3
|
+
import { LiteralNode } from "@herb-tools/core";
|
|
4
|
+
import { Printer, IdentityPrinter } from "@herb-tools/printer";
|
|
5
|
+
import { hasERBOutput, getValidatableStaticContent, isEffectivelyStatic, isNode, getStaticAttributeName, isERBOutputNode } from "@herb-tools/core";
|
|
6
|
+
class OutputPrinter extends Printer {
|
|
7
|
+
visitLiteralNode(node) {
|
|
8
|
+
this.write(IdentityPrinter.print(node));
|
|
9
|
+
}
|
|
10
|
+
visitERBContentNode(node) {
|
|
11
|
+
if (isERBOutputNode(node)) {
|
|
12
|
+
this.write(IdentityPrinter.print(node));
|
|
13
|
+
}
|
|
14
|
+
}
|
|
15
|
+
}
|
|
16
|
+
class NoDuplicateIdsVisitor extends ControlFlowTrackingVisitor {
|
|
4
17
|
documentIds = new Set();
|
|
5
|
-
|
|
6
|
-
|
|
18
|
+
currentBranchIds = new Set();
|
|
19
|
+
controlFlowIds = new Set();
|
|
20
|
+
visitHTMLAttributeNode(node) {
|
|
21
|
+
this.checkAttribute(node);
|
|
22
|
+
}
|
|
23
|
+
onEnterControlFlow(_controlFlowType, wasAlreadyInControlFlow) {
|
|
24
|
+
const stateToRestore = {
|
|
25
|
+
previousBranchIds: this.currentBranchIds,
|
|
26
|
+
previousControlFlowIds: this.controlFlowIds
|
|
27
|
+
};
|
|
28
|
+
this.currentBranchIds = new Set();
|
|
29
|
+
if (!wasAlreadyInControlFlow) {
|
|
30
|
+
this.controlFlowIds = new Set();
|
|
31
|
+
}
|
|
32
|
+
return stateToRestore;
|
|
33
|
+
}
|
|
34
|
+
onExitControlFlow(controlFlowType, wasAlreadyInControlFlow, stateToRestore) {
|
|
35
|
+
if (controlFlowType === ControlFlowType.CONDITIONAL && !wasAlreadyInControlFlow) {
|
|
36
|
+
this.controlFlowIds.forEach(id => this.documentIds.add(id));
|
|
37
|
+
}
|
|
38
|
+
this.currentBranchIds = stateToRestore.previousBranchIds;
|
|
39
|
+
this.controlFlowIds = stateToRestore.previousControlFlowIds;
|
|
40
|
+
}
|
|
41
|
+
onEnterBranch() {
|
|
42
|
+
const stateToRestore = {
|
|
43
|
+
previousBranchIds: this.currentBranchIds
|
|
44
|
+
};
|
|
45
|
+
if (this.isInControlFlow) {
|
|
46
|
+
this.currentBranchIds = new Set();
|
|
47
|
+
}
|
|
48
|
+
return stateToRestore;
|
|
49
|
+
}
|
|
50
|
+
onExitBranch(_stateToRestore) { }
|
|
51
|
+
checkAttribute(attributeNode) {
|
|
52
|
+
if (!this.isIdAttribute(attributeNode))
|
|
7
53
|
return;
|
|
8
|
-
|
|
54
|
+
const idValue = this.extractIdValue(attributeNode);
|
|
55
|
+
if (!idValue)
|
|
9
56
|
return;
|
|
10
|
-
|
|
11
|
-
if (this.documentIds.has(id)) {
|
|
12
|
-
this.addOffense(`Duplicate ID \`${id}\` found. IDs must be unique within a document.`, attributeNode.location, "error");
|
|
57
|
+
if (this.isWhitespaceOnlyId(idValue.identifier))
|
|
13
58
|
return;
|
|
59
|
+
this.processIdDuplicate(idValue, attributeNode);
|
|
60
|
+
}
|
|
61
|
+
isIdAttribute(attributeNode) {
|
|
62
|
+
if (!attributeNode.name?.children || !attributeNode.value)
|
|
63
|
+
return false;
|
|
64
|
+
return getStaticAttributeName(attributeNode.name) === "id";
|
|
65
|
+
}
|
|
66
|
+
extractIdValue(attributeNode) {
|
|
67
|
+
const valueNodes = attributeNode.value?.children || [];
|
|
68
|
+
if (hasERBOutput(valueNodes) && this.isInControlFlow && this.currentControlFlowType === ControlFlowType.LOOP) {
|
|
69
|
+
return null;
|
|
14
70
|
}
|
|
15
|
-
|
|
71
|
+
const identifier = isEffectivelyStatic(valueNodes) ? getValidatableStaticContent(valueNodes) : OutputPrinter.print(valueNodes);
|
|
72
|
+
if (!identifier)
|
|
73
|
+
return null;
|
|
74
|
+
return { identifier, shouldTrackDuplicates: true };
|
|
75
|
+
}
|
|
76
|
+
isWhitespaceOnlyId(identifier) {
|
|
77
|
+
return identifier !== '' && identifier.trim() === '';
|
|
78
|
+
}
|
|
79
|
+
processIdDuplicate(idValue, attributeNode) {
|
|
80
|
+
const { identifier, shouldTrackDuplicates } = idValue;
|
|
81
|
+
if (!shouldTrackDuplicates)
|
|
82
|
+
return;
|
|
83
|
+
if (this.isInControlFlow) {
|
|
84
|
+
this.handleControlFlowId(identifier, attributeNode);
|
|
85
|
+
}
|
|
86
|
+
else {
|
|
87
|
+
this.handleGlobalId(identifier, attributeNode);
|
|
88
|
+
}
|
|
89
|
+
}
|
|
90
|
+
handleControlFlowId(identifier, attributeNode) {
|
|
91
|
+
if (this.currentControlFlowType === ControlFlowType.LOOP) {
|
|
92
|
+
this.handleLoopId(identifier, attributeNode);
|
|
93
|
+
}
|
|
94
|
+
else {
|
|
95
|
+
this.handleConditionalId(identifier, attributeNode);
|
|
96
|
+
}
|
|
97
|
+
this.currentBranchIds.add(identifier);
|
|
98
|
+
}
|
|
99
|
+
handleLoopId(identifier, attributeNode) {
|
|
100
|
+
const isStaticId = this.isStaticId(attributeNode);
|
|
101
|
+
if (isStaticId) {
|
|
102
|
+
this.addDuplicateIdOffense(identifier, attributeNode.location);
|
|
103
|
+
return;
|
|
104
|
+
}
|
|
105
|
+
if (this.currentBranchIds.has(identifier)) {
|
|
106
|
+
this.addSameLoopIterationOffense(identifier, attributeNode.location);
|
|
107
|
+
}
|
|
108
|
+
}
|
|
109
|
+
handleConditionalId(identifier, attributeNode) {
|
|
110
|
+
if (this.currentBranchIds.has(identifier)) {
|
|
111
|
+
this.addSameBranchOffense(identifier, attributeNode.location);
|
|
112
|
+
return;
|
|
113
|
+
}
|
|
114
|
+
if (this.documentIds.has(identifier)) {
|
|
115
|
+
this.addDuplicateIdOffense(identifier, attributeNode.location);
|
|
116
|
+
return;
|
|
117
|
+
}
|
|
118
|
+
this.controlFlowIds.add(identifier);
|
|
119
|
+
}
|
|
120
|
+
handleGlobalId(identifier, attributeNode) {
|
|
121
|
+
if (this.documentIds.has(identifier)) {
|
|
122
|
+
this.addDuplicateIdOffense(identifier, attributeNode.location);
|
|
123
|
+
return;
|
|
124
|
+
}
|
|
125
|
+
this.documentIds.add(identifier);
|
|
126
|
+
}
|
|
127
|
+
isStaticId(attributeNode) {
|
|
128
|
+
const valueNodes = attributeNode.value.children;
|
|
129
|
+
const isCompletelyStatic = valueNodes.every(child => isNode(child, LiteralNode));
|
|
130
|
+
const isEffectivelyStaticValue = isEffectivelyStatic(valueNodes);
|
|
131
|
+
return isCompletelyStatic || isEffectivelyStaticValue;
|
|
132
|
+
}
|
|
133
|
+
addDuplicateIdOffense(identifier, location) {
|
|
134
|
+
this.addOffense(`Duplicate ID \`${identifier}\` found. IDs must be unique within a document.`, location, "error");
|
|
135
|
+
}
|
|
136
|
+
addSameLoopIterationOffense(identifier, location) {
|
|
137
|
+
this.addOffense(`Duplicate ID \`${identifier}\` found within the same loop iteration. IDs must be unique within the same loop iteration.`, location, "error");
|
|
138
|
+
}
|
|
139
|
+
addSameBranchOffense(identifier, location) {
|
|
140
|
+
this.addOffense(`Duplicate ID \`${identifier}\` found within the same control flow branch. IDs must be unique within the same control flow branch.`, location, "error");
|
|
16
141
|
}
|
|
17
142
|
}
|
|
18
143
|
export class HTMLNoDuplicateIdsRule extends ParserRule {
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"html-no-duplicate-ids.js","sourceRoot":"","sources":["../../../src/rules/html-no-duplicate-ids.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,
|
|
1
|
+
{"version":3,"file":"html-no-duplicate-ids.js","sourceRoot":"","sources":["../../../src/rules/html-no-duplicate-ids.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAA;AACrC,OAAO,EAAE,0BAA0B,EAAE,eAAe,EAAE,MAAM,cAAc,CAAA;AAC1E,OAAO,EAAE,WAAW,EAAE,MAAM,kBAAkB,CAAA;AAC9C,OAAO,EAAE,OAAO,EAAE,eAAe,EAAE,MAAM,qBAAqB,CAAA;AAE9D,OAAO,EAAE,YAAY,EAAE,2BAA2B,EAAE,mBAAmB,EAAE,MAAM,EAAE,sBAAsB,EAAE,eAAe,EAAE,MAAM,kBAAkB,CAAA;AAclJ,MAAM,aAAc,SAAQ,OAAO;IACjC,gBAAgB,CAAC,IAAiB;QAChC,IAAI,CAAC,KAAK,CAAC,eAAe,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAA;IACzC,CAAC;IAED,mBAAmB,CAAC,IAAoB;QACtC,IAAI,eAAe,CAAC,IAAI,CAAC,EAAE,CAAC;YAC1B,IAAI,CAAC,KAAK,CAAC,eAAe,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAA;QACzC,CAAC;IACH,CAAC;CACF;AAED,MAAM,qBAAsB,SAAQ,0BAAyD;IACnF,WAAW,GAAgB,IAAI,GAAG,EAAU,CAAA;IAC5C,gBAAgB,GAAgB,IAAI,GAAG,EAAU,CAAA;IACjD,cAAc,GAAgB,IAAI,GAAG,EAAU,CAAA;IAEvD,sBAAsB,CAAC,IAAuB;QAC5C,IAAI,CAAC,cAAc,CAAC,IAAI,CAAC,CAAA;IAC3B,CAAC;IAES,kBAAkB,CAAC,gBAAiC,EAAE,uBAAgC;QAC9F,MAAM,cAAc,GAAqB;YACvC,iBAAiB,EAAE,IAAI,CAAC,gBAAgB;YACxC,sBAAsB,EAAE,IAAI,CAAC,cAAc;SAC5C,CAAA;QAED,IAAI,CAAC,gBAAgB,GAAG,IAAI,GAAG,EAAU,CAAA;QAEzC,IAAI,CAAC,uBAAuB,EAAE,CAAC;YAC7B,IAAI,CAAC,cAAc,GAAG,IAAI,GAAG,EAAU,CAAA;QACzC,CAAC;QAED,OAAO,cAAc,CAAA;IACvB,CAAC;IAES,iBAAiB,CAAC,eAAgC,EAAE,uBAAgC,EAAE,cAAgC;QAC9H,IAAI,eAAe,KAAK,eAAe,CAAC,WAAW,IAAI,CAAC,uBAAuB,EAAE,CAAC;YAChF,IAAI,CAAC,cAAc,CAAC,OAAO,CAAC,EAAE,CAAC,EAAE,CAAC,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC,CAAA;QAC7D,CAAC;QAED,IAAI,CAAC,gBAAgB,GAAG,cAAc,CAAC,iBAAiB,CAAA;QACxD,IAAI,CAAC,cAAc,GAAG,cAAc,CAAC,sBAAsB,CAAA;IAC7D,CAAC;IAES,aAAa;QACrB,MAAM,cAAc,GAAgB;YAClC,iBAAiB,EAAE,IAAI,CAAC,gBAAgB;SACzC,CAAA;QAED,IAAI,IAAI,CAAC,eAAe,EAAE,CAAC;YACzB,IAAI,CAAC,gBAAgB,GAAG,IAAI,GAAG,EAAU,CAAA;QAC3C,CAAC;QAED,OAAO,cAAc,CAAA;IACvB,CAAC;IAES,YAAY,CAAC,eAA4B,IAAS,CAAC;IAErD,cAAc,CAAC,aAAgC;QACrD,IAAI,CAAC,IAAI,CAAC,aAAa,CAAC,aAAa,CAAC;YAAE,OAAM;QAE9C,MAAM,OAAO,GAAG,IAAI,CAAC,cAAc,CAAC,aAAa,CAAC,CAAA;QAElD,IAAI,CAAC,OAAO;YAAE,OAAM;QACpB,IAAI,IAAI,CAAC,kBAAkB,CAAC,OAAO,CAAC,UAAU,CAAC;YAAE,OAAM;QAEvD,IAAI,CAAC,kBAAkB,CAAC,OAAO,EAAE,aAAa,CAAC,CAAA;IACjD,CAAC;IAEO,aAAa,CAAC,aAAgC;QACpD,IAAI,CAAC,aAAa,CAAC,IAAI,EAAE,QAAQ,IAAI,CAAC,aAAa,CAAC,KAAK;YAAE,OAAO,KAAK,CAAA;QAEvE,OAAO,sBAAsB,CAAC,aAAa,CAAC,IAAI,CAAC,KAAK,IAAI,CAAA;IAC5D,CAAC;IAEO,cAAc,CAAC,aAAgC;QACrD,MAAM,UAAU,GAAG,aAAa,CAAC,KAAK,EAAE,QAAQ,IAAI,EAAE,CAAA;QAEtD,IAAI,YAAY,CAAC,UAAU,CAAC,IAAI,IAAI,CAAC,eAAe,IAAI,IAAI,CAAC,sBAAsB,KAAK,eAAe,CAAC,IAAI,EAAE,CAAC;YAC7G,OAAO,IAAI,CAAA;QACb,CAAC;QAED,MAAM,UAAU,GAAG,mBAAmB,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,2BAA2B,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,aAAa,CAAC,KAAK,CAAC,UAAU,CAAC,CAAA;QAC9H,IAAI,CAAC,UAAU;YAAE,OAAO,IAAI,CAAA;QAE5B,OAAO,EAAE,UAAU,EAAE,qBAAqB,EAAE,IAAI,EAAE,CAAA;IACpD,CAAC;IAEO,kBAAkB,CAAC,UAAkB;QAC3C,OAAO,UAAU,KAAK,EAAE,IAAI,UAAU,CAAC,IAAI,EAAE,KAAK,EAAE,CAAA;IACtD,CAAC;IAEO,kBAAkB,CAAC,OAA+D,EAAE,aAAgC;QAC1H,MAAM,EAAE,UAAU,EAAE,qBAAqB,EAAE,GAAG,OAAO,CAAA;QAErD,IAAI,CAAC,qBAAqB;YAAE,OAAM;QAElC,IAAI,IAAI,CAAC,eAAe,EAAE,CAAC;YACzB,IAAI,CAAC,mBAAmB,CAAC,UAAU,EAAE,aAAa,CAAC,CAAA;QACrD,CAAC;aAAM,CAAC;YACN,IAAI,CAAC,cAAc,CAAC,UAAU,EAAE,aAAa,CAAC,CAAA;QAChD,CAAC;IACH,CAAC;IAEO,mBAAmB,CAAC,UAAkB,EAAE,aAAgC;QAC9E,IAAI,IAAI,CAAC,sBAAsB,KAAK,eAAe,CAAC,IAAI,EAAE,CAAC;YACzD,IAAI,CAAC,YAAY,CAAC,UAAU,EAAE,aAAa,CAAC,CAAA;QAC9C,CAAC;aAAM,CAAC;YACN,IAAI,CAAC,mBAAmB,CAAC,UAAU,EAAE,aAAa,CAAC,CAAA;QACrD,CAAC;QAED,IAAI,CAAC,gBAAgB,CAAC,GAAG,CAAC,UAAU,CAAC,CAAA;IACvC,CAAC;IAEO,YAAY,CAAC,UAAkB,EAAE,aAAgC;QACvE,MAAM,UAAU,GAAG,IAAI,CAAC,UAAU,CAAC,aAAa,CAAC,CAAA;QAEjD,IAAI,UAAU,EAAE,CAAC;YACf,IAAI,CAAC,qBAAqB,CAAC,UAAU,EAAE,aAAa,CAAC,QAAQ,CAAC,CAAA;YAC9D,OAAM;QACR,CAAC;QAED,IAAI,IAAI,CAAC,gBAAgB,CAAC,GAAG,CAAC,UAAU,CAAC,EAAE,CAAC;YAC1C,IAAI,CAAC,2BAA2B,CAAC,UAAU,EAAE,aAAa,CAAC,QAAQ,CAAC,CAAA;QACtE,CAAC;IACH,CAAC;IAEO,mBAAmB,CAAC,UAAkB,EAAE,aAAgC;QAC9E,IAAI,IAAI,CAAC,gBAAgB,CAAC,GAAG,CAAC,UAAU,CAAC,EAAE,CAAC;YAC1C,IAAI,CAAC,oBAAoB,CAAC,UAAU,EAAE,aAAa,CAAC,QAAQ,CAAC,CAAA;YAC7D,OAAM;QACR,CAAC;QAED,IAAI,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,UAAU,CAAC,EAAE,CAAC;YACrC,IAAI,CAAC,qBAAqB,CAAC,UAAU,EAAE,aAAa,CAAC,QAAQ,CAAC,CAAA;YAC9D,OAAM;QACR,CAAC;QAED,IAAI,CAAC,cAAc,CAAC,GAAG,CAAC,UAAU,CAAC,CAAA;IACrC,CAAC;IAEO,cAAc,CAAC,UAAkB,EAAE,aAAgC;QACzE,IAAI,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,UAAU,CAAC,EAAE,CAAC;YACrC,IAAI,CAAC,qBAAqB,CAAC,UAAU,EAAE,aAAa,CAAC,QAAQ,CAAC,CAAA;YAC9D,OAAM;QACR,CAAC;QAED,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,UAAU,CAAC,CAAA;IAClC,CAAC;IAEO,UAAU,CAAC,aAAgC;QACjD,MAAM,UAAU,GAAG,aAAa,CAAC,KAAM,CAAC,QAAQ,CAAA;QAChD,MAAM,kBAAkB,GAAG,UAAU,CAAC,KAAK,CAAC,KAAK,CAAC,EAAE,CAAC,MAAM,CAAC,KAAK,EAAE,WAAW,CAAC,CAAC,CAAA;QAChF,MAAM,wBAAwB,GAAG,mBAAmB,CAAC,UAAU,CAAC,CAAA;QAEhE,OAAO,kBAAkB,IAAI,wBAAwB,CAAA;IACvD,CAAC;IAEO,qBAAqB,CAAC,UAAkB,EAAE,QAAa;QAC7D,IAAI,CAAC,UAAU,CACb,kBAAkB,UAAU,iDAAiD,EAC7E,QAAQ,EACR,OAAO,CACR,CAAA;IACH,CAAC;IAEO,2BAA2B,CAAC,UAAkB,EAAE,QAAa;QACnE,IAAI,CAAC,UAAU,CACb,kBAAkB,UAAU,6FAA6F,EACzH,QAAQ,EACR,OAAO,CACR,CAAA;IACH,CAAC;IAEO,oBAAoB,CAAC,UAAkB,EAAE,QAAa;QAC5D,IAAI,CAAC,UAAU,CACb,kBAAkB,UAAU,uGAAuG,EACnI,QAAQ,EACR,OAAO,CACR,CAAA;IACH,CAAC;CACF;AAED,MAAM,OAAO,sBAAuB,SAAQ,UAAU;IACpD,IAAI,GAAG,uBAAuB,CAAA;IAE9B,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,qBAAqB,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAE7D,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}
|
|
@@ -5,10 +5,6 @@ class NoEmptyHeadingsVisitor extends BaseRuleVisitor {
|
|
|
5
5
|
this.checkHeadingElement(node);
|
|
6
6
|
super.visitHTMLElementNode(node);
|
|
7
7
|
}
|
|
8
|
-
visitHTMLSelfCloseTagNode(node) {
|
|
9
|
-
this.checkSelfClosingHeading(node);
|
|
10
|
-
super.visitHTMLSelfCloseTagNode(node);
|
|
11
|
-
}
|
|
12
8
|
checkHeadingElement(node) {
|
|
13
9
|
if (!node.open_tag || node.open_tag.type !== "AST_HTML_OPEN_TAG_NODE") {
|
|
14
10
|
return;
|
|
@@ -30,23 +26,6 @@ class NoEmptyHeadingsVisitor extends BaseRuleVisitor {
|
|
|
30
26
|
this.addOffense(`Heading element ${elementDescription} must not be empty. Provide accessible text content for screen readers and SEO.`, node.location, "error");
|
|
31
27
|
}
|
|
32
28
|
}
|
|
33
|
-
checkSelfClosingHeading(node) {
|
|
34
|
-
const tagName = getTagName(node);
|
|
35
|
-
if (!tagName) {
|
|
36
|
-
return;
|
|
37
|
-
}
|
|
38
|
-
// Check if it's a standard heading tag (h1-h6) or has role="heading"
|
|
39
|
-
const isStandardHeading = HEADING_TAGS.has(tagName);
|
|
40
|
-
const isAriaHeading = this.hasHeadingRole(node);
|
|
41
|
-
if (!isStandardHeading && !isAriaHeading) {
|
|
42
|
-
return;
|
|
43
|
-
}
|
|
44
|
-
// Self-closing headings are always empty
|
|
45
|
-
const elementDescription = isStandardHeading
|
|
46
|
-
? `\`<${tagName}>\``
|
|
47
|
-
: `\`<${tagName} role="heading">\``;
|
|
48
|
-
this.addOffense(`Heading element ${elementDescription} must not be empty. Provide accessible text content for screen readers and SEO.`, node.tag_name.location, "error");
|
|
49
|
-
}
|
|
50
29
|
isEmptyHeading(node) {
|
|
51
30
|
if (!node.body || node.body.length === 0) {
|
|
52
31
|
return true;
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"html-no-empty-headings.js","sourceRoot":"","sources":["../../../src/rules/html-no-empty-headings.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,eAAe,EAAE,UAAU,EAAE,aAAa,EAAE,mBAAmB,EAAE,iBAAiB,EAAE,YAAY,EAAE,MAAM,iBAAiB,CAAA;AAElI,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AAIxC,MAAM,sBAAuB,SAAQ,eAAe;IAClD,oBAAoB,CAAC,IAAqB;QACxC,IAAI,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAA;QAC9B,KAAK,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAA;IAClC,CAAC;
|
|
1
|
+
{"version":3,"file":"html-no-empty-headings.js","sourceRoot":"","sources":["../../../src/rules/html-no-empty-headings.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,eAAe,EAAE,UAAU,EAAE,aAAa,EAAE,mBAAmB,EAAE,iBAAiB,EAAE,YAAY,EAAE,MAAM,iBAAiB,CAAA;AAElI,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AAIxC,MAAM,sBAAuB,SAAQ,eAAe;IAClD,oBAAoB,CAAC,IAAqB;QACxC,IAAI,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAA;QAC9B,KAAK,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAA;IAClC,CAAC;IAGO,mBAAmB,CAAC,IAAqB;QAC/C,IAAI,CAAC,IAAI,CAAC,QAAQ,IAAI,IAAI,CAAC,QAAQ,CAAC,IAAI,KAAK,wBAAwB,EAAE,CAAC;YACtE,OAAM;QACR,CAAC;QAED,MAAM,OAAO,GAAG,IAAI,CAAC,QAA2B,CAAA;QAChD,MAAM,OAAO,GAAG,UAAU,CAAC,OAAO,CAAC,CAAA;QAEnC,IAAI,CAAC,OAAO,EAAE,CAAC;YACb,OAAM;QACR,CAAC;QAED,MAAM,iBAAiB,GAAG,YAAY,CAAC,GAAG,CAAC,OAAO,CAAC,CAAA;QACnD,MAAM,aAAa,GAAG,IAAI,CAAC,cAAc,CAAC,OAAO,CAAC,CAAA;QAElD,IAAI,CAAC,iBAAiB,IAAI,CAAC,aAAa,EAAE,CAAC;YACzC,OAAM;QACR,CAAC;QAED,IAAI,IAAI,CAAC,cAAc,CAAC,IAAI,CAAC,EAAE,CAAC;YAC9B,MAAM,kBAAkB,GAAG,iBAAiB;gBAC1C,CAAC,CAAC,MAAM,OAAO,KAAK;gBACpB,CAAC,CAAC,MAAM,OAAO,oBAAoB,CAAA;YAErC,IAAI,CAAC,UAAU,CACb,mBAAmB,kBAAkB,iFAAiF,EACtH,IAAI,CAAC,QAAQ,EACb,OAAO,CACR,CAAA;QACH,CAAC;IACH,CAAC;IAGO,cAAc,CAAC,IAAqB;QAC1C,IAAI,CAAC,IAAI,CAAC,IAAI,IAAI,IAAI,CAAC,IAAI,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YACzC,OAAO,IAAI,CAAA;QACb,CAAC;QAED,0DAA0D;QAC1D,IAAI,oBAAoB,GAAG,KAAK,CAAA;QAEhC,KAAK,MAAM,KAAK,IAAI,IAAI,CAAC,IAAI,EAAE,CAAC;YAC9B,IAAI,KAAK,CAAC,IAAI,KAAK,kBAAkB,EAAE,CAAC;gBACtC,MAAM,WAAW,GAAG,KAAoB,CAAA;gBAExC,IAAI,WAAW,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;oBAC1C,oBAAoB,GAAG,IAAI,CAAA;oBAC3B,MAAK;gBACP,CAAC;YACH,CAAC;iBAAM,IAAI,KAAK,CAAC,IAAI,KAAK,oBAAoB,EAAE,CAAC;gBAC/C,MAAM,QAAQ,GAAG,KAAqB,CAAA;gBAEtC,IAAI,QAAQ,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;oBACvC,oBAAoB,GAAG,IAAI,CAAA;oBAC3B,MAAK;gBACP,CAAC;YACH,CAAC;iBAAM,IAAI,KAAK,CAAC,IAAI,KAAK,uBAAuB,EAAE,CAAC;gBAClD,MAAM,WAAW,GAAG,KAAwB,CAAA;gBAE5C,+DAA+D;gBAC/D,IAAI,IAAI,CAAC,mBAAmB,CAAC,WAAW,CAAC,EAAE,CAAC;oBAC1C,oBAAoB,GAAG,IAAI,CAAA;oBAC3B,MAAK;gBACP,CAAC;YACH,CAAC;iBAAM,CAAC;gBACN,6FAA6F;gBAC7F,oBAAoB,GAAG,IAAI,CAAA;gBAC3B,MAAK;YACP,CAAC;QACH,CAAC;QAED,OAAO,CAAC,oBAAoB,CAAA;IAC9B,CAAC;IAEO,cAAc,CAAC,IAAqB;QAC1C,MAAM,UAAU,GAAG,aAAa,CAAC,IAAI,CAAC,CAAA;QACtC,MAAM,aAAa,GAAG,mBAAmB,CAAC,UAAU,EAAE,MAAM,CAAC,CAAA;QAE7D,IAAI,CAAC,aAAa,EAAE,CAAC;YACnB,OAAO,KAAK,CAAA;QACd,CAAC;QAED,MAAM,SAAS,GAAG,iBAAiB,CAAC,aAAa,CAAC,CAAA;QAClD,OAAO,SAAS,KAAK,SAAS,CAAA;IAChC,CAAC;IAEO,mBAAmB,CAAC,IAAqB;QAC/C,8CAA8C;QAC9C,IAAI,CAAC,IAAI,CAAC,QAAQ,IAAI,IAAI,CAAC,QAAQ,CAAC,IAAI,KAAK,wBAAwB,EAAE,CAAC;YACtE,OAAO,IAAI,CAAA;QACb,CAAC;QAED,MAAM,OAAO,GAAG,IAAI,CAAC,QAA2B,CAAA;QAChD,MAAM,UAAU,GAAG,aAAa,CAAC,OAAO,CAAC,CAAA;QACzC,MAAM,mBAAmB,GAAG,mBAAmB,CAAC,UAAU,EAAE,aAAa,CAAC,CAAA;QAE1E,IAAI,mBAAmB,EAAE,CAAC;YACxB,MAAM,eAAe,GAAG,iBAAiB,CAAC,mBAAmB,CAAC,CAAA;YAE9D,IAAI,eAAe,KAAK,MAAM,EAAE,CAAC;gBAC/B,OAAO,KAAK,CAAA;YACd,CAAC;QACH,CAAC;QAED,8DAA8D;QAC9D,IAAI,CAAC,IAAI,CAAC,IAAI,IAAI,IAAI,CAAC,IAAI,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YACzC,OAAO,KAAK,CAAA;QACd,CAAC;QAED,KAAK,MAAM,KAAK,IAAI,IAAI,CAAC,IAAI,EAAE,CAAC;YAC9B,IAAI,KAAK,CAAC,IAAI,KAAK,kBAAkB,EAAE,CAAC;gBACtC,MAAM,WAAW,GAAG,KAAoB,CAAA;gBACxC,IAAI,WAAW,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;oBAC1C,OAAO,IAAI,CAAA;gBACb,CAAC;YACH,CAAC;iBAAM,IAAI,KAAK,CAAC,IAAI,KAAK,oBAAoB,EAAE,CAAC;gBAC/C,MAAM,QAAQ,GAAG,KAAqB,CAAA;gBACtC,IAAI,QAAQ,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;oBACvC,OAAO,IAAI,CAAA;gBACb,CAAC;YACH,CAAC;iBAAM,IAAI,KAAK,CAAC,IAAI,KAAK,uBAAuB,EAAE,CAAC;gBAClD,MAAM,WAAW,GAAG,KAAwB,CAAA;gBAC5C,IAAI,IAAI,CAAC,mBAAmB,CAAC,WAAW,CAAC,EAAE,CAAC;oBAC1C,OAAO,IAAI,CAAA;gBACb,CAAC;YACH,CAAC;iBAAM,CAAC;gBACN,6FAA6F;gBAC7F,OAAO,IAAI,CAAA;YACb,CAAC;QACH,CAAC;QAED,OAAO,KAAK,CAAA;IACd,CAAC;CACF;AAED,MAAM,OAAO,uBAAwB,SAAQ,UAAU;IACrD,IAAI,GAAG,wBAAwB,CAAA;IAE/B,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,sBAAsB,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAC9D,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAC3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}
|
|
@@ -0,0 +1,21 @@
|
|
|
1
|
+
import { ParserRule } from "../types.js";
|
|
2
|
+
import { AttributeVisitorMixin } from "./rule-utils.js";
|
|
3
|
+
class NoPositiveTabIndexVisitor extends AttributeVisitorMixin {
|
|
4
|
+
checkStaticAttributeStaticValue({ attributeName, attributeValue, attributeNode }) {
|
|
5
|
+
if (attributeName !== "tabindex")
|
|
6
|
+
return;
|
|
7
|
+
const tabIndexValue = parseInt(attributeValue, 10);
|
|
8
|
+
if (!isNaN(tabIndexValue) && tabIndexValue > 0) {
|
|
9
|
+
this.addOffense(`Do not use positive \`tabindex\` values as they are error prone and can severely disrupt navigation experience for keyboard users. Use \`tabindex="0"\` to make an element focusable or \`tabindex=\"-1\"\` to remove it from the tab sequence.`, attributeNode.location, "error");
|
|
10
|
+
}
|
|
11
|
+
}
|
|
12
|
+
}
|
|
13
|
+
export class HTMLNoPositiveTabIndexRule extends ParserRule {
|
|
14
|
+
name = "html-no-positive-tab-index";
|
|
15
|
+
check(result, context) {
|
|
16
|
+
const visitor = new NoPositiveTabIndexVisitor(this.name, context);
|
|
17
|
+
visitor.visit(result.value);
|
|
18
|
+
return visitor.offenses;
|
|
19
|
+
}
|
|
20
|
+
}
|
|
21
|
+
//# sourceMappingURL=html-no-positive-tab-index.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"html-no-positive-tab-index.js","sourceRoot":"","sources":["../../../src/rules/html-no-positive-tab-index.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,qBAAqB,EAAoC,MAAM,iBAAiB,CAAA;AAKzF,MAAM,yBAA0B,SAAQ,qBAAqB;IACjD,+BAA+B,CAAC,EAAE,aAAa,EAAE,cAAc,EAAE,aAAa,EAAoC;QAC1H,IAAI,aAAa,KAAK,UAAU;YAAE,OAAM;QAExC,MAAM,aAAa,GAAG,QAAQ,CAAC,cAAc,EAAE,EAAE,CAAC,CAAA;QAElD,IAAI,CAAC,KAAK,CAAC,aAAa,CAAC,IAAI,aAAa,GAAG,CAAC,EAAE,CAAC;YAC/C,IAAI,CAAC,UAAU,CACb,iPAAiP,EACjP,aAAa,CAAC,QAAQ,EACtB,OAAO,CACR,CAAA;QACH,CAAC;IACH,CAAC;CACF;AAED,MAAM,OAAO,0BAA2B,SAAQ,UAAU;IACxD,IAAI,GAAG,4BAA4B,CAAA;IAEnC,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,yBAAyB,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAEjE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}
|
|
@@ -0,0 +1,29 @@
|
|
|
1
|
+
import { ParserRule } from "../types.js";
|
|
2
|
+
import { BaseRuleVisitor, isVoidElement } from "./rule-utils.js";
|
|
3
|
+
import { getTagName } from "@herb-tools/core";
|
|
4
|
+
class NoSelfClosingVisitor extends BaseRuleVisitor {
|
|
5
|
+
visitHTMLElementNode(node) {
|
|
6
|
+
if (getTagName(node) === "svg") {
|
|
7
|
+
this.visit(node.open_tag);
|
|
8
|
+
}
|
|
9
|
+
else {
|
|
10
|
+
this.visitChildNodes(node);
|
|
11
|
+
}
|
|
12
|
+
}
|
|
13
|
+
visitHTMLOpenTagNode(node) {
|
|
14
|
+
if (node.tag_closing?.value === "/>") {
|
|
15
|
+
const tagName = getTagName(node);
|
|
16
|
+
const instead = isVoidElement(tagName) ? `<${tagName}>` : `<${tagName}></${tagName}>`;
|
|
17
|
+
this.addOffense(`Use \`${instead}\` instead of self-closing \`<${tagName} />\` for HTML compatibility.`, node.location, "error");
|
|
18
|
+
}
|
|
19
|
+
}
|
|
20
|
+
}
|
|
21
|
+
export class HTMLNoSelfClosingRule extends ParserRule {
|
|
22
|
+
name = "html-no-self-closing";
|
|
23
|
+
check(result, context) {
|
|
24
|
+
const visitor = new NoSelfClosingVisitor(this.name, context);
|
|
25
|
+
visitor.visit(result.value);
|
|
26
|
+
return visitor.offenses;
|
|
27
|
+
}
|
|
28
|
+
}
|
|
29
|
+
//# sourceMappingURL=html-no-self-closing.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"html-no-self-closing.js","sourceRoot":"","sources":["../../../src/rules/html-no-self-closing.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,eAAe,EAAE,aAAa,EAAE,MAAM,iBAAiB,CAAA;AAChE,OAAO,EAAE,UAAU,EAAE,MAAM,kBAAkB,CAAA;AAK7C,MAAM,oBAAqB,SAAQ,eAAe;IAChD,oBAAoB,CAAC,IAAqB;QACxC,IAAI,UAAU,CAAC,IAAI,CAAC,KAAK,KAAK,EAAE,CAAC;YAC/B,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAA;QAC3B,CAAC;aAAM,CAAC;YACN,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;QAC5B,CAAC;IACH,CAAC;IAED,oBAAoB,CAAC,IAAqB;QACxC,IAAI,IAAI,CAAC,WAAW,EAAE,KAAK,KAAK,IAAI,EAAE,CAAC;YACrC,MAAM,OAAO,GAAG,UAAU,CAAC,IAAI,CAAC,CAAA;YAChC,MAAM,OAAO,GAAG,aAAa,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,IAAI,OAAO,GAAG,CAAC,CAAC,CAAC,IAAI,OAAO,MAAM,OAAO,GAAG,CAAA;YAErF,IAAI,CAAC,UAAU,CACb,SAAS,OAAO,iCAAiC,OAAO,+BAA+B,EACvF,IAAI,CAAC,QAAQ,EACb,OAAO,CACR,CAAA;QACH,CAAC;IACH,CAAC;CACF;AAED,MAAM,OAAO,qBAAsB,SAAQ,UAAU;IACnD,IAAI,GAAG,sBAAsB,CAAA;IAE7B,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,oBAAoB,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAE5D,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}
|
|
@@ -0,0 +1,27 @@
|
|
|
1
|
+
import { ParserRule } from "../types.js";
|
|
2
|
+
import { BaseRuleVisitor, getTagName, hasAttribute } from "./rule-utils.js";
|
|
3
|
+
class NoTitleAttributeVisitor extends BaseRuleVisitor {
|
|
4
|
+
ALLOWED_ELEMENTS_WITH_TITLE = new Set(["iframe", "link"]);
|
|
5
|
+
visitHTMLOpenTagNode(node) {
|
|
6
|
+
this.checkTitleAttribute(node);
|
|
7
|
+
super.visitHTMLOpenTagNode(node);
|
|
8
|
+
}
|
|
9
|
+
checkTitleAttribute(node) {
|
|
10
|
+
const tagName = getTagName(node);
|
|
11
|
+
if (!tagName || this.ALLOWED_ELEMENTS_WITH_TITLE.has(tagName)) {
|
|
12
|
+
return;
|
|
13
|
+
}
|
|
14
|
+
if (hasAttribute(node, "title")) {
|
|
15
|
+
this.addOffense("The `title` attribute should never be used as it is inaccessible for several groups of users. Use `aria-label` or `aria-describedby` instead. Exceptions are provided for `<iframe>` and `<link>` elements.", node.tag_name.location, "error");
|
|
16
|
+
}
|
|
17
|
+
}
|
|
18
|
+
}
|
|
19
|
+
export class HTMLNoTitleAttributeRule extends ParserRule {
|
|
20
|
+
name = "html-no-title-attribute";
|
|
21
|
+
check(result, context) {
|
|
22
|
+
const visitor = new NoTitleAttributeVisitor(this.name, context);
|
|
23
|
+
visitor.visit(result.value);
|
|
24
|
+
return visitor.offenses;
|
|
25
|
+
}
|
|
26
|
+
}
|
|
27
|
+
//# sourceMappingURL=html-no-title-attribute.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"html-no-title-attribute.js","sourceRoot":"","sources":["../../../src/rules/html-no-title-attribute.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,eAAe,EAAE,UAAU,EAAE,YAAY,EAAE,MAAM,iBAAiB,CAAA;AAK3E,MAAM,uBAAwB,SAAQ,eAAe;IACnD,2BAA2B,GAAG,IAAI,GAAG,CAAC,CAAC,QAAQ,EAAE,MAAM,CAAC,CAAC,CAAA;IAEzD,oBAAoB,CAAC,IAAqB;QACxC,IAAI,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAA;QAC9B,KAAK,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAA;IAClC,CAAC;IAEO,mBAAmB,CAAC,IAAqB;QAC/C,MAAM,OAAO,GAAG,UAAU,CAAC,IAAI,CAAC,CAAA;QAEhC,IAAI,CAAC,OAAO,IAAI,IAAI,CAAC,2BAA2B,CAAC,GAAG,CAAC,OAAO,CAAC,EAAE,CAAC;YAC9D,OAAM;QACR,CAAC;QAED,IAAI,YAAY,CAAC,IAAI,EAAE,OAAO,CAAC,EAAE,CAAC;YAChC,IAAI,CAAC,UAAU,CACb,6MAA6M,EAC7M,IAAI,CAAC,QAAS,CAAC,QAAQ,EACvB,OAAO,CACR,CAAA;QACH,CAAC;IACH,CAAC;CACF;AAED,MAAM,OAAO,wBAAyB,SAAQ,UAAU;IACtD,IAAI,GAAG,yBAAyB,CAAA;IAEhC,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,uBAAuB,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAE/D,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}
|
|
@@ -1,45 +1,57 @@
|
|
|
1
|
-
import { BaseRuleVisitor } from "./rule-utils.js";
|
|
2
1
|
import { ParserRule } from "../types.js";
|
|
2
|
+
import { BaseRuleVisitor } from "./rule-utils.js";
|
|
3
|
+
import { isNode, getTagName, HTMLOpenTagNode } from "@herb-tools/core";
|
|
4
|
+
class XMLDeclarationChecker extends BaseRuleVisitor {
|
|
5
|
+
hasXMLDeclaration = false;
|
|
6
|
+
visitXMLDeclarationNode(_node) {
|
|
7
|
+
this.hasXMLDeclaration = true;
|
|
8
|
+
}
|
|
9
|
+
visitChildNodes(node) {
|
|
10
|
+
if (this.hasXMLDeclaration)
|
|
11
|
+
return;
|
|
12
|
+
super.visitChildNodes(node);
|
|
13
|
+
}
|
|
14
|
+
}
|
|
3
15
|
class TagNameLowercaseVisitor extends BaseRuleVisitor {
|
|
4
16
|
visitHTMLElementNode(node) {
|
|
5
|
-
|
|
6
|
-
if (node.open_tag) {
|
|
17
|
+
if (getTagName(node).toLowerCase() === "svg") {
|
|
7
18
|
this.checkTagName(node.open_tag);
|
|
8
|
-
}
|
|
9
|
-
if (tagName && ["svg"].includes(tagName.toLowerCase())) {
|
|
10
|
-
if (node.close_tag) {
|
|
11
|
-
this.checkTagName(node.close_tag);
|
|
12
|
-
}
|
|
13
|
-
return;
|
|
14
|
-
}
|
|
15
|
-
this.visitChildNodes(node);
|
|
16
|
-
if (node.close_tag) {
|
|
17
19
|
this.checkTagName(node.close_tag);
|
|
18
20
|
}
|
|
21
|
+
else {
|
|
22
|
+
super.visitHTMLElementNode(node);
|
|
23
|
+
}
|
|
24
|
+
}
|
|
25
|
+
visitHTMLOpenTagNode(node) {
|
|
26
|
+
this.checkTagName(node);
|
|
19
27
|
}
|
|
20
|
-
|
|
28
|
+
visitHTMLCloseTagNode(node) {
|
|
21
29
|
this.checkTagName(node);
|
|
22
|
-
this.visitChildNodes(node);
|
|
23
30
|
}
|
|
24
31
|
checkTagName(node) {
|
|
25
|
-
|
|
32
|
+
if (!node)
|
|
33
|
+
return;
|
|
34
|
+
const tagName = getTagName(node);
|
|
26
35
|
if (!tagName)
|
|
27
36
|
return;
|
|
28
37
|
const lowercaseTagName = tagName.toLowerCase();
|
|
38
|
+
const type = isNode(node, HTMLOpenTagNode) ? "Opening" : "Closing";
|
|
39
|
+
const open = isNode(node, HTMLOpenTagNode) ? "<" : "</";
|
|
29
40
|
if (tagName !== lowercaseTagName) {
|
|
30
|
-
|
|
31
|
-
if (node.type == "AST_HTML_OPEN_TAG_NODE")
|
|
32
|
-
type = "Opening";
|
|
33
|
-
if (node.type == "AST_HTML_CLOSE_TAG_NODE")
|
|
34
|
-
type = "Closing";
|
|
35
|
-
if (node.type == "AST_HTML_SELF_CLOSE_TAG_NODE")
|
|
36
|
-
type = "Self-closing";
|
|
37
|
-
this.addOffense(`${type} tag name \`${tagName}\` should be lowercase. Use \`${lowercaseTagName}\` instead.`, node.tag_name.location, "error");
|
|
41
|
+
this.addOffense(`${type} tag name \`${open}${tagName}>\` should be lowercase. Use \`${open}${lowercaseTagName}>\` instead.`, node.tag_name.location, "error");
|
|
38
42
|
}
|
|
39
43
|
}
|
|
40
44
|
}
|
|
41
45
|
export class HTMLTagNameLowercaseRule extends ParserRule {
|
|
42
46
|
name = "html-tag-name-lowercase";
|
|
47
|
+
isEnabled(result, context) {
|
|
48
|
+
if (context?.fileName?.endsWith(".xml") || context?.fileName?.endsWith(".xml.erb")) {
|
|
49
|
+
return false;
|
|
50
|
+
}
|
|
51
|
+
const checker = new XMLDeclarationChecker(this.name);
|
|
52
|
+
checker.visit(result.value);
|
|
53
|
+
return !checker.hasXMLDeclaration;
|
|
54
|
+
}
|
|
43
55
|
check(result, context) {
|
|
44
56
|
const visitor = new TagNameLowercaseVisitor(this.name, context);
|
|
45
57
|
visitor.visit(result.value);
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"html-tag-name-lowercase.js","sourceRoot":"","sources":["../../../src/rules/html-tag-name-lowercase.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,
|
|
1
|
+
{"version":3,"file":"html-tag-name-lowercase.js","sourceRoot":"","sources":["../../../src/rules/html-tag-name-lowercase.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAA;AAEjD,OAAO,EAAE,MAAM,EAAE,UAAU,EAAmB,eAAe,EAA2D,MAAM,kBAAkB,CAAA;AAIhJ,MAAM,qBAAsB,SAAQ,eAAe;IACjD,iBAAiB,GAAY,KAAK,CAAA;IAElC,uBAAuB,CAAC,KAAyB;QAC/C,IAAI,CAAC,iBAAiB,GAAG,IAAI,CAAA;IAC/B,CAAC;IAED,eAAe,CAAC,IAAU;QACxB,IAAI,IAAI,CAAC,iBAAiB;YAAE,OAAM;QAClC,KAAK,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC7B,CAAC;CACF;AAED,MAAM,uBAAwB,SAAQ,eAAe;IACnD,oBAAoB,CAAC,IAAqB;QACxC,IAAI,UAAU,CAAC,IAAI,CAAC,CAAC,WAAW,EAAE,KAAK,KAAK,EAAE,CAAC;YAC7C,IAAI,CAAC,YAAY,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAA;YAChC,IAAI,CAAC,YAAY,CAAC,IAAI,CAAC,SAAS,CAAC,CAAA;QACnC,CAAC;aAAM,CAAC;YACN,KAAK,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAA;QAClC,CAAC;IACH,CAAC;IAED,oBAAoB,CAAC,IAAqB;QACxC,IAAI,CAAC,YAAY,CAAC,IAAI,CAAC,CAAA;IACzB,CAAC;IAED,qBAAqB,CAAC,IAAsB;QAC1C,IAAI,CAAC,YAAY,CAAC,IAAI,CAAC,CAAA;IACzB,CAAC;IAEO,YAAY,CAAC,IAA+C;QAClE,IAAI,CAAC,IAAI;YAAE,OAAM;QAEjB,MAAM,OAAO,GAAG,UAAU,CAAC,IAAI,CAAC,CAAA;QAEhC,IAAI,CAAC,OAAO;YAAE,OAAM;QAEpB,MAAM,gBAAgB,GAAG,OAAO,CAAC,WAAW,EAAE,CAAA;QAE9C,MAAM,IAAI,GAAG,MAAM,CAAC,IAAI,EAAE,eAAe,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,SAAS,CAAA;QAClE,MAAM,IAAI,GAAG,MAAM,CAAC,IAAI,EAAE,eAAe,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAA;QAEvD,IAAI,OAAO,KAAK,gBAAgB,EAAE,CAAC;YACjC,IAAI,CAAC,UAAU,CACb,GAAG,IAAI,eAAe,IAAI,GAAG,OAAO,kCAAkC,IAAI,GAAG,gBAAgB,cAAc,EAC3G,IAAI,CAAC,QAAS,CAAC,QAAQ,EACvB,OAAO,CACR,CAAA;QACH,CAAC;IACH,CAAC;CACF;AAED,MAAM,OAAO,wBAAyB,SAAQ,UAAU;IACtD,IAAI,GAAG,yBAAyB,CAAA;IAEhC,SAAS,CAAC,MAAmB,EAAE,OAA8B;QAC3D,IAAI,OAAO,EAAE,QAAQ,EAAE,QAAQ,CAAC,MAAM,CAAC,IAAI,OAAO,EAAE,QAAQ,EAAE,QAAQ,CAAC,UAAU,CAAC,EAAE,CAAC;YACnF,OAAO,KAAK,CAAA;QACd,CAAC;QAED,MAAM,OAAO,GAAG,IAAI,qBAAqB,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QACpD,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAC3B,OAAO,CAAC,OAAO,CAAC,iBAAiB,CAAA;IACnC,CAAC;IAED,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,uBAAuB,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAA;QAC/D,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAC3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;CACF"}
|