@henryqw/pi-prompt-creator 3.1.4 → 3.1.6

package/CONTEXT.md

@@ -1,24 +1,23 @@
-# pi-prompt-creator — Context
+# Pi Prompt Creator
 
-## Domain
+Pi Prompt Creator finds reusable prompt ideas in the current conversation. Main and the user review each idea before the user approves a new global prompt.
 
-Turn repetition and correction in the current Pi conversation into one editable prompt template candidate. The user decides whether the candidate becomes a global Pi prompt.
+## Language
 
-## Glossary
+**Current Conversation**:
+The model-visible conversation on the active branch, including its retained summary and effective user and completed assistant text. Inactive branches, removed context, tool traffic, and thinking are not prompt-analysis evidence.
 
-- **Current Conversation**: The active conversation branch, including summaries that replace compacted history. Inactive branches are outside the scope.
-- **Signal**: Evidence in the Current Conversation that a reusable prompt may help. Signals are explicit recurrence language, repetition of the same underlying request, or repeated correction of the agent's behavior.
-- **Prompt Candidate**: One unsaved, editable prompt template proposed from the strongest Signal. A session has at most one pending Prompt Candidate; the user may explicitly request another after the pending candidate is shown or dismissed.
-- **Prompt Review**: Conversational refinement of a Prompt Candidate by the user and Main.
-- **Final Prompt Draft**: Complete prompt-template Markdown authored by Main after Prompt Review. A Prompt Candidate is not a Final Prompt Draft.
-- **Approved Prompt**: A Final Prompt Draft the user explicitly accepts for creation as a global Pi prompt. Approval never authorizes replacing an existing prompt.
+**Signal**:
+Evidence that a reusable prompt could help: explicit recurrence language, requests with the same intent, or repeated corrections of Main's behavior.
 
-## Boundary
+**Prompt Candidate**:
+One unsaved prompt template proposed from a Signal. A pending candidate is untrusted review material, not an approved prompt.
 
-| Concern | Home |
-| --- | --- |
-| Cross-session evidence and historical search | `@henryqw/pi-session-recall` |
-| Scripts, Skills, and other automation | Their owning package or repository |
-| This extension | Current-conversation Signal detection, Prompt Candidate generation, and Prompt Review |
+**Prompt Review**:
+Conversational refinement of a displayed Prompt Candidate by the user and Main.
 
-The extension stays silent when it finds no Prompt Candidate. Background analysis remains visible while it is running. Manually requested candidates display when ready; automatic candidates wait for explicit user display, so background work never steals editor focus.
+**Final Prompt Draft**:
+The complete prompt-template Markdown in Main's latest valid retained review reply after the candidate was displayed. A Prompt Candidate is not a Final Prompt Draft.
+
+**Approved Prompt**:
+A Final Prompt Draft that the user explicitly accepts for creation as a new global Pi prompt. Approval does not permit replacement of an existing prompt.

package/README.md

@@ -89,7 +89,7 @@ A successful save reloads Pi resources. If reload fails, the prompt remains save
 
 The extension registers `pi-prompt-creator/draft`. Its default task profile is `fast`.
 
-Use `/task-models` to select the model and thinking level. The extension owns no model configuration.
+Use `/task-models` to select the model and thinking level. The extension owns no model configuration. At session start and before each analysis, it shows each problem in the shared task-model config one time in each session.
 
 ## Config
 
@@ -104,9 +104,11 @@ Edit either field. Then run `/reload` to apply the change. Omitted fields use th
 
 A missing file quietly uses both defaults. Startup never creates or rewrites the file.
 
-Malformed config or unknown keys disable automatic analysis. Pi warns once and leaves the file unchanged.
+At session start, Pi shows a warning with the file path and each problem for an unknown key or an invalid value. Pi ignores the unknown key. A misspelled key near a missing field, such as `automatc`, counts as an invalid value of that field. An invalid `inputThreshold` uses the default `3`.
 
-Only `/promptor automatic on` or `/promptor automatic off` writes the config. A toggle keeps the configured threshold.
+Automatic analysis stays off for the session when `automatic` is invalid or misspelled, or when the file has malformed JSON, invalid UTF-8, more than 64 KiB, a read error, or a non-object root. Startup leaves the file unchanged.
+
+Only `/promptor automatic on` or `/promptor automatic off` writes the config. A toggle reads the file again and keeps its current `inputThreshold`, also when another session changed it. A toggle also replaces a file with problems: it first shows the problems, then keeps the usable values and removes unknown keys. If another session changes that file before the write, the toggle stops and writes nothing.
 
 ## State and storage
 

package/extensions/prompt-creator.ts

@@ -10,7 +10,7 @@ import {
 	type ExtensionContext,
 	type SessionEntry,
 } from "@earendil-works/pi-coding-agent";
-import { createConfigStore } from "@henryqw/pi-config-store";
+import { createConfigStore, field, parsers, registerConfigReporting } from "@henryqw/pi-config-store";
 import {
 	createEphemeralSubagentExecutor,
 	resolveRoleLaunch,
@@ -19,6 +19,7 @@ import {
 } from "@henryqw/pi-subagent";
 import {
 	registerModelTask,
+	registerTaskModelsConfigReporting,
 	type ModelTask,
 } from "@henryqw/pi-task-models";
 
@@ -60,7 +61,6 @@ or
 The object must have exactly these keys. name must start with a lowercase ASCII letter, use only lowercase ASCII letters, digits, and single hyphens, and be at most ${MAX_NAME_CHARS} characters. markdown must be nonempty, at most ${MAX_MARKDOWN_BYTES} UTF-8 bytes, and contain no C0 or C1 controls except tab and LF.`,
 } satisfies Role;
 
-type Config = { automatic: boolean; inputThreshold: number };
 type PromptCandidate = { name: string; markdown: string };
 type ConversationItem = { role: "summary" | "user" | "assistant"; text: string };
 type ContextMessage = ReturnType<typeof buildSessionContext>["messages"][number];
@@ -80,21 +80,6 @@ function exactKeys(value: Record<string, unknown>, keys: readonly string[]): boo
 	return actual.length === keys.length && keys.every((key) => Object.hasOwn(value, key));
 }
 
-function parseConfig(value: unknown): Config {
-	if (!value || typeof value !== "object" || Array.isArray(value)) throw new Error("Config must be an object.");
-	const config = value as Record<string, unknown>;
-	const validKeys = Object.keys(config).every((key) => key === "automatic" || key === "inputThreshold");
-	const { automatic = true, inputThreshold = DEFAULT_INPUT_THRESHOLD } = config;
-	if (
-		!validKeys
-		|| typeof automatic !== "boolean"
-		|| typeof inputThreshold !== "number"
-		|| !Number.isSafeInteger(inputThreshold)
-		|| inputThreshold < 1
-	) throw new Error("Config may contain automatic:boolean and inputThreshold:positive integer.");
-	return { automatic, inputThreshold };
-}
-
 function isPromptName(value: unknown): value is string {
 	return typeof value === "string" && value.length <= MAX_NAME_CHARS && NAME.test(value);
 }
@@ -253,17 +238,20 @@ async function createPromptFile(path: string, markdown: string): Promise<void> {
 export default function promptCreatorExtension(pi: ExtensionAPI, options: PromptCreatorOptions = {}): void {
 	registerModelTask(pi, DRAFT_TASK);
 	const agentDir = options.agentDir ?? getAgentDir();
-	const configStore = createConfigStore<Config>({
+	const configStore = createConfigStore({
 		extensionId: EXTENSION_ID,
 		agentDir,
-		defaults: () => ({ automatic: true, inputThreshold: DEFAULT_INPUT_THRESHOLD }),
-		parse: parseConfig,
+		fields: {
+			automatic: field(parsers.boolean(), true),
+			inputThreshold: field(parsers.integer({ min: 1 }), DEFAULT_INPUT_THRESHOLD),
+		},
 	});
+	const configReporter = registerConfigReporting(pi, [configStore]);
+	const reportTaskModels = registerTaskModelsConfigReporting(pi, agentDir);
 	let executor = options.executor;
 	let automatic = false;
 	let inputThreshold = DEFAULT_INPUT_THRESHOLD;
 	let automaticConsumed = false;
-	let configWarned = false;
 	let inputCount = 0;
 	let branchGeneration = 0;
 	let candidate: PromptCandidate | undefined;
@@ -328,6 +316,7 @@ export default function promptCreatorExtension(pi: ExtensionAPI, options: Prompt
 		void Promise.resolve().then(() => getExecutor().run({
 			signal: run.controller.signal,
 			prepare: async () => {
+				reportTaskModels(ctx);
 				const launch = resolveRoleLaunch(pi, ctx, {
 					role: DRAFT_ROLE,
 					task: DRAFT_TASK,
@@ -397,18 +386,11 @@ export default function promptCreatorExtension(pi: ExtensionAPI, options: Prompt
 		activeRun?.controller.abort(new Error("Prompt Creator session changed."));
 		activeRun = undefined;
 		resetBranch(ctx);
-		try {
-			const config = configStore.loadSync().value;
-			automatic = config.automatic;
-			inputThreshold = config.inputThreshold;
-		} catch {
-			automatic = false;
-			inputThreshold = DEFAULT_INPUT_THRESHOLD;
-			if (!configWarned) {
-				configWarned = true;
-				ctx.ui.notify("Prompt Creator config is invalid. Automatic analysis is disabled; the file was left unchanged.", "warning");
-			}
-		}
+		const loaded = configStore.loadSync();
+		configReporter.report(ctx, configStore, loaded);
+		// A file-level problem or an invalid or misspelled `automatic` keeps automatic analysis off; a missing file uses the default.
+		automatic = loaded.status === "ok" && loaded.value.automatic && !loaded.issues.some(({ key }) => key === "" || key === "automatic");
+		inputThreshold = loaded.status === "ok" ? loaded.value.inputThreshold : DEFAULT_INPUT_THRESHOLD;
 	});
 
 	pi.on("input", (event, ctx) => {
@@ -491,11 +473,20 @@ export default function promptCreatorExtension(pi: ExtensionAPI, options: Prompt
 			if (action === "automatic" && values.length === 1 && (values[0] === "on" || values[0] === "off")) {
 				const next = values[0] === "on";
 				try {
-					await configStore.save({ automatic: next, inputThreshold });
+					// Write the latest file, not the session's cached threshold, and report its problems first.
+					const loaded = configStore.loadSync();
+					configReporter.report(ctx, configStore, loaded);
+					// No field disables this config, so a load always has a value.
+					if (loaded.status !== "ok") return;
+					let written = { ...loaded.value, automatic: next };
+					if (!loaded.issues.length) written = await configStore.update((latest) => ({ ...latest, automatic: next }));
+					// A file with problems is replaced with its usable values, and only if no other session changed it meanwhile.
+					else await configStore.replaceIfUnchanged(loaded, written);
 					automatic = next;
+					inputThreshold = written.inputThreshold;
 					ctx.ui.notify(`Automatic analysis ${next ? "enabled" : "disabled"}.`, "info");
-				} catch {
-					ctx.ui.notify("Could not save Prompt Creator config.", "error");
+				} catch (error) {
+					ctx.ui.notify(`Could not save Prompt Creator config: ${error instanceof Error ? error.message : String(error)}`, "error");
 				}
 				return;
 			}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@henryqw/pi-prompt-creator",
-  "version": "3.1.4",
+  "version": "3.1.6",
   "description": "Turn current Pi conversation signals into user-approved prompt templates.",
   "keywords": [
     "pi-package",
@@ -45,9 +45,9 @@
     ]
   },
   "dependencies": {
-    "@henryqw/pi-config-store": "^3.0.0",
+    "@henryqw/pi-config-store": "^4.0.0",
     "@henryqw/pi-subagent": "^22.0.0 || ^23.0.0 || ^24.0.0 || ^25.0.0 || ^26.0.0 || ^27.0.0",
-    "@henryqw/pi-task-models": "^8.0.0"
+    "@henryqw/pi-task-models": "^9.0.0"
   },
   "devDependencies": {
     "@earendil-works/pi-coding-agent": "1.1.0"