@henryqw/pi-prompt-creator 2.0.5 → 2.0.7

package/README.md

@@ -2,7 +2,7 @@
 
 Turn repeated requests or corrections in the current conversation into a reviewed global Pi prompt. A tool-free child drafts one candidate, while Main and the user control review and saving.
 
-Nothing is shown or saved until you choose it.
+Automatic analysis only prepares a candidate; the extension never saves it without your approval.
 
 ## Install
 
@@ -29,13 +29,11 @@ Run `/promptor` in the interactive TUI after a repeated request or correction ap
 
 The prompt is created at `~/.pi/agent/prompts/<name>.md`, then Pi reloads its resources. No selection menu or name prompt is required.
 
-| Command | Action |
-| --- | --- |
-| `/promptor` | Start analysis, or show a candidate prepared by automatic analysis. |
-| `/promptor analyze` | Analyze again after a candidate has been reviewed or dismissed. |
-| `/promptor save [name]` | Save Main's newest completed review reply, using the suggested name by default. |
-| `/promptor dismiss` | Forget a candidate prepared by automatic analysis. |
-| `/promptor automatic <on\|off>` | Enable or disable automatic analysis. |
+| Surface | Type | Purpose |
+| --- | --- | --- |
+| `/promptor [analyze|dismiss|save [name]|automatic <on\|off>]` | command | For users in the interactive TUI: start or show analysis, dismiss a pending candidate, save a reviewed prompt, or control automatic analysis. |
+| `pi-prompt-creator/draft` | task | For users configuring `/task-models`: choose the child model and thinking level for drafting. |
+| Analysis status widget and candidate message | ui | Show analysis progress, readiness, or failure; a displayed candidate is marked as untrusted. |
 
 ## Flow
 
@@ -65,23 +63,19 @@ New user input does not stop a running child. Branch navigation discards its old
 
 ### Review and save
 
-A manually requested analysis displays its completed candidate immediately. Automatic background analysis keeps its candidate behind the `Prompt ready — /promptor` widget until you run `/promptor` or `/promptor dismiss`, so background work never interrupts the conversation.
+A manually requested analysis displays its completed candidate immediately. Automatic analysis shows a running widget, then keeps a completed candidate behind the `Prompt ready — /promptor` widget until you run `/promptor` or `/promptor dismiss`, so background work never interrupts the conversation.
 
 Displayed candidates are visible messages marked as untrusted.
 
 Refine the candidate with Main. Ask Main to return only the complete Final Prompt Draft before saving it with `/promptor save [name]`.
 
-The save item appears only after you show a candidate and Main then completes a valid Markdown review reply.
-
-Saving uses that latest retained Main reply as the entire file. Replies before the active compaction or branch summary cannot be saved.
+Saving is allowed only after you show a candidate and Main then completes a valid Markdown review reply. Saving uses that latest retained Main reply as the entire file. Replies before the active compaction or branch summary cannot be saved.
 
 An interrupted, failed, empty, or tool-use reply cannot be saved. The extension never falls back to an older reply.
 
 A successful save ends that review. Show another candidate and complete another Main review reply before saving again.
 
-The menu asks for a lowercase kebab-case name. A candidate name appears only as a hint.
-
-Names start with a letter and contain at most 64 ASCII characters. Existing command names and prompt files are rejected.
+`/promptor save` uses the suggested candidate name. Pass `/promptor save <name>` to choose another. Names must be lowercase kebab-case, start with a letter, and contain at most 64 ASCII characters. Existing command names and prompt files are rejected.
 
 A successful save reloads Pi resources. If reload fails, the prompt remains saved and `/reload` can load it.
 
@@ -98,7 +92,7 @@ Package-owned: `~/.pi/agent/config/pi-prompt-creator/config.json`
 | Name | Description | Values | Default |
 | --- | --- | --- | --- |
 | `automatic` | Runs automatic analysis after enough user inputs. | Boolean. | `true` |
-| `inputThreshold` | Sets the number of non-empty user inputs before automatic analysis. | Positive integer. | `3` |
+| `inputThreshold` | Sets the number of non-empty user inputs before automatic analysis. | Positive safe integer (`1`–`9007199254740991`). | `3` |
 
 Edit either field, then run `/reload` to apply the change. Omitted fields use their defaults.
 
@@ -106,7 +100,7 @@ A missing file quietly uses both defaults. Startup never creates or rewrites the
 
 Malformed config or unknown keys disable automatic analysis. Pi warns once and leaves the file unchanged.
 
-Only `Automatic On` or `Automatic Off` writes the config. Toggling preserves the configured threshold.
+Only `/promptor automatic on` or `/promptor automatic off` writes the config. Toggling preserves the configured threshold.
 
 ## State and storage
 
@@ -128,7 +122,7 @@ Candidate and Final Prompt Draft Markdown must be non-empty and at most 16 KiB.
 
 Candidate and saved Markdown reject NUL and other terminal controls. Ordinary tabs and line feeds are allowed.
 
-No candidate clears the running widget without a notice. Invalid output or child failure shows `Prompt analysis failed — /promptor`.
+No candidate clears the running widget without a notice. Invalid output or child failure shows `Prompt analysis failed — /promptor`. Failed analysis is not retried automatically; run `/promptor` or `/promptor analyze` to start again.
 
 The failure widget clears after the next non-empty user input. Analysis has a two-minute idle timeout and five-minute hard timeout.
 

package/extensions/prompt-creator.ts

@@ -146,34 +146,31 @@ function conversationItem(message: ContextMessage): ConversationItem | undefined
 }
 
 function boundedConversation(messages: ContextMessage[], maxChars: number): ConversationItem[] {
-	const items = messages.flatMap((message, index) => {
+	const items = messages.flatMap((message) => {
 		const item = conversationItem(message);
-		return item ? [{ index, item, chars: JSON.stringify(item).length }] : [];
+		return item ? [item] : [];
 	});
 	let summaryIndex = -1;
 	for (let index = items.length - 1; index >= 0; index--) {
-		if (items[index]!.item.role === "summary") {
+		if (items[index]!.role === "summary") {
 			summaryIndex = index;
 			break;
 		}
 	}
-	const selected = new Set<number>();
-	let used = 0;
-	if (summaryIndex >= 0 && items[summaryIndex]!.chars <= maxChars) {
-		selected.add(items[summaryIndex]!.index);
-		used = items[summaryIndex]!.chars;
-	}
+	const summary = items[summaryIndex];
+	const summaryChars = summary ? JSON.stringify(summary).length : 0;
+	const keepSummary = !!summary && summaryChars <= maxChars;
+	const selected: ConversationItem[] = [];
+	let used = keepSummary ? summaryChars : 0;
 	for (let index = items.length - 1; index > summaryIndex; index--) {
 		const item = items[index]!;
-		const cost = item.chars + (selected.size ? 1 : 0);
+		const cost = JSON.stringify(item).length + (used ? 1 : 0);
 		if (used + cost > maxChars) continue;
-		selected.add(item.index);
+		selected.push(item);
 		used += cost;
 	}
-	return items
-		.slice(summaryIndex < 0 ? 0 : summaryIndex)
-		.filter(({ index }) => selected.has(index))
-		.map(({ item }) => item);
+	selected.reverse();
+	return keepSummary ? [summary, ...selected] : selected;
 }
 
 function analysisPayload(pi: ExtensionAPI, ctx: ExtensionContext): AnalysisPayload {
@@ -378,10 +375,8 @@ export default function promptCreatorExtension(pi: ExtensionAPI, options: Prompt
 		draft: string,
 		requestedName: string | undefined,
 		expectedReview: ReviewBoundary,
-		expectedBranch: number,
 		ctx: ExtensionCommandContext,
 	) => {
-		if (expectedBranch !== branchGeneration || reviewBoundary !== expectedReview) return;
 		const name = requestedName ?? candidateNameHint ?? "";
 		if (!isPromptName(name)) {
 			ctx.ui.notify(`Use lowercase kebab-case starting with a letter, up to ${MAX_NAME_CHARS} characters.`, "warning");
@@ -471,7 +466,6 @@ export default function promptCreatorExtension(pi: ExtensionAPI, options: Prompt
 				ctx.ui.notify("/promptor requires the interactive TUI.", "warning");
 				return;
 			}
-			const commandBranch = branchGeneration;
 			const review = reviewBoundary;
 			const draft = latestAssistantDraft(ctx, review);
 			const [action = "", ...values] = args.trim().split(/\s+/);
@@ -502,7 +496,7 @@ export default function promptCreatorExtension(pi: ExtensionAPI, options: Prompt
 					ctx.ui.notify("No reviewed Main draft is ready to save.", "warning");
 					return;
 				}
-				await saveLatestDraft(draft, values[0], review, commandBranch, ctx);
+				await saveLatestDraft(draft, values[0], review, ctx);
 				return;
 			}
 			if (action === "automatic" && values.length === 1 && (values[0] === "on" || values[0] === "off")) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@henryqw/pi-prompt-creator",
-  "version": "2.0.5",
+  "version": "2.0.7",
   "description": "Turn current Pi conversation signals into user-approved prompt templates.",
   "keywords": [
     "pi-package",