@henryqw/pi-open-in 0.2.8 → 1.0.0

package/README.md

@@ -22,7 +22,7 @@ pi install npm:@henryqw/pi-open-in
 
 ## Config
 
-`~/.pi/agent/config/pi-open-in.json`
+`~/.pi/agent/config/pi-open-in/config.json`
 
 ```json
 {
@@ -30,10 +30,25 @@ pi install npm:@henryqw/pi-open-in
 }
 ```
 
-- When the file is missing, the default editor command is `"code"`.
+- A missing file silently uses the default command, `"code"`.
+- Reads do not create or write the config home.
 - When the file exists, `command` is required. It must be a non-empty string.
 - The command splits on whitespace into an executable and arguments. Tokens cannot contain spaces, and quoting is unsupported. Use a wrapper script for executables in spaced paths.
 - An existing file must be a JSON object with exactly one non-empty string `command` property. Otherwise `/open` fails with a visible error and offers no open URI.
-- This extension never rewrites the file except through `/set-open-in`.
+- Malformed files remain unchanged.
+- Only `/set-open-in` writes the file. Its write is atomic.
 
-This package uses no shared config.
+## Owner API
+
+Consumers use the owner API instead of reading this file.
+
+```ts
+import { loadOpenInConfig } from "@henryqw/pi-open-in/open-uri";
+
+const { source, value } = loadOpenInConfig();
+```
+
+`source` is `"missing"` or `"file"`. `value.command` is validated.
+Pass an agent directory to `loadOpenInConfig(agentDir)` when needed.
+
+This extension owns command validation. `@henryqw/pi-config-store` owns the config home and storage.

package/extensions/open.ts

@@ -1,41 +1,38 @@
-import { readFileSync } from "node:fs";
-import { mkdir, writeFile } from "node:fs/promises";
-import { dirname, join } from "node:path";
 import { pathToFileURL } from "node:url";
-import {
-	getAgentDir,
-	type ExtensionAPI,
-} from "@earendil-works/pi-coding-agent";
+import { type ExtensionAPI } from "@earendil-works/pi-coding-agent";
+import { createConfigStore } from "@henryqw/pi-config-store";
 
 const DEFAULT_COMMAND = "code";
-const configPath = () => join(getAgentDir(), "config", "pi-open-in.json");
 
-function loadCommand(): string {
-	let raw: string;
-	try {
-		raw = readFileSync(configPath(), "utf8");
-	} catch (error) {
-		// Only a missing file falls back to the default command.
-		if ((error as NodeJS.ErrnoException).code === "ENOENT") return DEFAULT_COMMAND;
-		throw error;
-	}
-	let config: unknown;
-	try {
-		config = JSON.parse(raw);
-	} catch {
-		throw new Error(`Invalid ${configPath()}: not valid JSON`);
+export type OpenInConfig = { command: string };
+
+function parseOpenInConfig(value: unknown): OpenInConfig {
+	if (!value || typeof value !== "object" || Array.isArray(value)) {
+		throw new Error('Invalid open-in config: expected exactly one non-empty string "command" property');
 	}
-	const isObject = (value: unknown): value is Record<string, unknown> =>
-		typeof value === "object" && value !== null && !Array.isArray(value);
-	if (!isObject(config) || Object.keys(config).length !== 1 || typeof config.command !== "string" || !config.command.trim()) {
-		throw new Error(`Invalid ${configPath()}: expected exactly one non-empty string "command" property`);
+	const config = value as Record<string, unknown>;
+	if (Object.keys(config).length !== 1 || typeof config.command !== "string" || !config.command.trim()) {
+		throw new Error('Invalid open-in config: expected exactly one non-empty string "command" property');
 	}
-	return config.command.trim();
+	return { command: config.command.trim() };
+}
+
+function createOpenInConfigStore(agentDir?: string) {
+	return createConfigStore<OpenInConfig>({
+		extensionId: "pi-open-in",
+		agentDir,
+		defaults: () => ({ command: DEFAULT_COMMAND }),
+		parse: parseOpenInConfig,
+	});
+}
+
+export function loadOpenInConfig(agentDir?: string): { source: "file" | "missing"; value: OpenInConfig } {
+	return createOpenInConfigStore(agentDir).loadSync();
 }
 
 export function configuredOpenUri(path: string): string | undefined {
 	try {
-		if (loadCommand() !== "code") return undefined;
+		if (loadOpenInConfig().value.command !== "code") return undefined;
 	} catch {
 		// Invalid config must not break footer render; just omit the URI.
 		return undefined;
@@ -50,13 +47,15 @@ export function configuredOpenUri(path: string): string | undefined {
 }
 
 export default function openInExtension(pi: ExtensionAPI): void {
+	const configStore = createOpenInConfigStore();
+
 	// ponytail: static description so it never goes stale after /set-open-in
 	// (handler re-reads config per invocation); per-token whitespace splitting,
 	// tokens with spaces not supported.
 	pi.registerCommand("open", {
 		description: "Open the current path with the configured command",
 		handler: async (_args, ctx) => {
-			const [executable, ...args] = loadCommand().split(/\s+/);
+			const [executable, ...args] = configStore.loadSync().value.command.split(/\s+/);
 			const result = await pi.exec(executable, [...args, ctx.cwd]);
 			if (result.code !== 0) {
 				throw new Error(`Open command failed: ${result.stderr.trim() || `exit code ${result.code}`}`);
@@ -69,9 +68,7 @@ export default function openInExtension(pi: ExtensionAPI): void {
 		handler: async (args, ctx) => {
 			const command = args.trim();
 			if (!command) throw new Error("Usage: /set-open-in <command>");
-			const path = configPath();
-			await mkdir(dirname(path), { recursive: true });
-			await writeFile(path, `${JSON.stringify({ command }, null, 2)}\n`, "utf8");
+			await configStore.save({ command });
 			ctx.ui.notify(`Saved open-in command: ${command}`, "info");
 		},
 	});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@henryqw/pi-open-in",
-  "version": "0.2.8",
+  "version": "1.0.0",
   "description": "Open the current Pi working directory with a configurable command.",
   "keywords": [
     "pi-package",
@@ -45,5 +45,8 @@
     "extensions": [
       "./extensions"
     ]
+  },
+  "dependencies": {
+    "@henryqw/pi-config-store": "^0.1.0"
   }
 }