@henryqw/pi-herdr-tools 1.4.0 → 1.4.1

package/README.md

@@ -152,7 +152,7 @@ Normal cleanup does these steps. It checks whether a tab in another Herdr worksp
 - The consumer-owned `pi-herdr-btw/btw` task defaults to `fast`.
 - Before the pane starts, `/btw` selects the first authenticated viable effective profile route.
 
-`~/.pi/agent/config/pi-task-models/config.json` is shared, and `@henryqw/pi-task-models` owns it. A task entry is an explicit user override. Routes resolve before the pane starts. If this file is missing, BTW shows a warning one time per session.
+`~/.pi/agent/config/pi-task-models/config.json` is shared, and `@henryqw/pi-task-models` owns it. A task entry is an explicit user override. Routes resolve before the pane starts. If this file is missing or unreadable, or a task profile is not configured, the package shows one warning one time per session.
 
 #### Merge delivery
 
@@ -253,7 +253,7 @@ A large Main context can be more than the context limit of the side thread. Make
 
 Display titles are natural task phrases. They usually have two or three words, and they always have a maximum of four words and 20 characters. Models that answer in another language still make English display titles.
 
-If the shared task-model config is missing, the extension shows a warning one time at session start. Run `/task-models` to configure rename routing. If no route is viable, display titles do not change. `/rename` shows a warning if the session has no user text to rename.
+If the shared task-model config is missing, the package shows one warning one time per session at session start. Run `/task-models` to configure rename routing. If no route is viable, display titles do not change. `/rename` shows a warning if the session has no user text to rename.
 
 Herdr and Git synchronization failures show as warnings. Correct the reported problem. Then run `/rename` to try again. When a newer rename cancels an older rename, the extension shows no message. Older titles get no migration.
 

package/extensions/index.ts

@@ -1,11 +1,13 @@
 import type { ExtensionAPI, ExtensionContext } from "@earendil-works/pi-coding-agent";
-import registerBtwExtension from "../internal/btw.ts";
+import registerBtwExtension, { BTW_TASK } from "../internal/btw.ts";
 import herdrCloneExtension from "../internal/clone-tab.ts";
 import herdrDoneExtension from "../internal/done.ts";
 import herdrHandoffExtension from "../internal/handoff.ts";
-import herdrRenameExtension from "../internal/rename.ts";
+import herdrRenameExtension, { RENAME_TASK } from "../internal/rename.ts";
+import { registerTaskModelsWarning } from "../internal/task-models.ts";
 
 export default async function herdrToolsExtension(pi: ExtensionAPI): Promise<void> {
+	registerTaskModelsWarning(pi, [RENAME_TASK, BTW_TASK]);
 	herdrRenameExtension(pi);
 	await registerBtwExtension(pi);
 	herdrCloneExtension(pi);

package/internal/btw.ts

@@ -1,14 +1,7 @@
 import { randomUUID } from "node:crypto";
 import type { ExtensionAPI, ExtensionCommandContext, ExtensionContext } from "@earendil-works/pi-coding-agent";
 import { createHerdrClient, hasHerdrErrorCode, startPiAgent } from "@henryqw/pi-herdr";
-import {
-	loadTaskModelsConfig,
-	registerModelTask,
-	resolveConfiguredTaskRoutes,
-	type ModelTask,
-	type ResolvedTaskRoute,
-	type TaskRouteError,
-} from "@henryqw/pi-task-models";
+import { registerModelTask, type ModelTask, type ResolvedTaskRoute } from "@henryqw/pi-task-models";
 import {
 	buildSessionContext,
 	convertToLlm,
@@ -51,6 +44,7 @@ import {
 	type MergeRequest,
 } from "./merge.ts";
 import { HELP_TEXT, parseBtwCommand } from "./router.ts";
+import { configuredTaskRoutes } from "./task-models.ts";
 
 export const BTW_TASK = {
 	id: "pi-herdr-btw/btw",
@@ -97,21 +91,6 @@ function sameStringArray(a: string[], b: string[]): boolean {
 	return a.length === b.length && a.every((value, index) => value === b[index]);
 }
 
-function configuredBtwRoutes(ctx: ExtensionContext): ResolvedTaskRoute[] {
-	try {
-		return resolveConfiguredTaskRoutes(ctx, BTW_TASK);
-	} catch (error) {
-		const { taskRouteCode, profileName } = error as TaskRouteError;
-		throw new Error(
-			taskRouteCode === "profile-missing"
-				? `BTW task profile ${profileName} is not configured. Run /task-models.`
-				: taskRouteCode === "no-route"
-					? `BTW task profile ${profileName} has no available route. Run /task-models.`
-					: "Couldn't read task model config. Run /task-models.",
-		);
-	}
-}
-
 /**
  * Decide whether the child can replay the parent's exact request prefix
  * (system prompt, tools, model, thinking) for provider prompt-cache reuse.
@@ -401,7 +380,6 @@ export async function registerBtwExtension(
 		| Pick<ExtensionCommandContext, "sessionManager" | "isIdle" | "model" | "modelRegistry">
 		| undefined;
 	let sessionGeneration = 0;
-	let missingTaskModelsConfigWarningSessionId: string | undefined;
 	// Notifications need a UI context; route them through the last known ctx.
 	let notifyFn: ((message: string, type: "info" | "warning" | "error") => void) | undefined;
 	const coordinator = new MergeCoordinator(store, {
@@ -454,17 +432,6 @@ export async function registerBtwExtension(
 	}
 
 	pi.on("session_start", (_event, ctx) => {
-		const sessionId = ctx.sessionManager.getSessionId();
-		let taskModelsConfig: ReturnType<typeof loadTaskModelsConfig> | undefined;
-		try {
-			taskModelsConfig = loadTaskModelsConfig();
-		} catch {
-			ctx.ui.notify("Couldn't read task model config. Run /task-models.", "warning");
-		}
-		if (missingTaskModelsConfigWarningSessionId !== sessionId && taskModelsConfig?.source === "missing") {
-			missingTaskModelsConfigWarningSessionId = sessionId;
-			ctx.ui.notify("Task model config is missing; run /task-models to configure it.", "warning");
-		}
 		sessionGeneration += 1;
 		sessionCtx = ctx;
 		notifyFn = (message, type) => ctx.ui.notify(message, type);
@@ -599,7 +566,7 @@ export async function registerBtwExtension(
 				const currentModel = ctx.model ? `${ctx.model.provider}/${ctx.model.id}` : null;
 				const thinkingLevel = pi.getThinkingLevel();
 				let launchRoute: ResolvedTaskRoute | undefined;
-				for (const route of configuredBtwRoutes(ctx)) {
+				for (const route of configuredTaskRoutes(ctx, BTW_TASK, "BTW")) {
 					try {
 						const authenticated = (await ctx.modelRegistry.getApiKeyAndHeaders(route.model)).ok;
 						if (launchGeneration !== sessionGeneration) return;

package/internal/rename.ts

@@ -4,15 +4,8 @@ import {
 	type ExtensionContext,
 } from "@earendil-works/pi-coding-agent";
 import { createHerdrClient, withWorktreeLock } from "@henryqw/pi-herdr";
-import {
-	executeTaskRoutes,
-	loadTaskModelsConfig,
-	registerModelTask,
-	resolveConfiguredTaskRoutes,
-	type ModelTask,
-	type ResolvedTaskRoute,
-	type TaskRouteError,
-} from "@henryqw/pi-task-models";
+import { executeTaskRoutes, registerModelTask, type ModelTask, type ResolvedTaskRoute } from "@henryqw/pi-task-models";
+import { configuredTaskRoutes } from "./task-models.ts";
 
 const WIDGET_KEY = "pi-herdr-rename";
 const WIDGET_RESULT_MS = 2_000;
@@ -39,21 +32,6 @@ type GeneratedTitle = { display: string; branch: string };
 
 class RenameModelError extends Error {}
 
-function configuredRenameRoutes(ctx: ExtensionContext): ResolvedTaskRoute[] {
-	try {
-		return resolveConfiguredTaskRoutes(ctx, RENAME_TASK);
-	} catch (error) {
-		const { taskRouteCode, profileName } = error as TaskRouteError;
-		throw new RenameModelError(
-			taskRouteCode === "profile-missing"
-				? `Rename task profile ${profileName} is not configured. Run /task-models.`
-				: taskRouteCode === "no-route"
-					? `Rename task profile ${profileName} has no available route. Run /task-models.`
-					: "Couldn't read task model config. Run /task-models.",
-		);
-	}
-}
-
 function validSubject(subject: string): boolean {
 	return /^[a-z0-9]+(?: [a-z0-9]+)*$/.test(subject)
 		&& subject.length <= DISPLAY_MAX_CHARS
@@ -192,7 +170,7 @@ async function generateTitle(text: string, ctx: ExtensionContext, signal: AbortS
 	};
 
 	return executeTaskRoutes(
-		configuredRenameRoutes(ctx),
+		configuredTaskRoutes(ctx, RENAME_TASK, "Rename"),
 		async (route) => {
 			const firstMessages = [{ role: "user" as const, content: prompt, timestamp: Date.now() }];
 			const response = await complete(route, firstMessages);
@@ -358,19 +336,6 @@ export default function herdrRenameExtension(pi: ExtensionAPI): void {
 		sequence++;
 		automaticPending = false;
 		latestUserText = latestSessionUserText(ctx);
-		try {
-			const taskModels = loadTaskModelsConfig();
-			if (taskModels.source === "missing") {
-				ctx.ui.notify("Task model config is missing; run /task-models to configure rename routing.", "warning");
-			} else {
-				const profileName = taskModels.value.tasks[RENAME_TASK.id] ?? RENAME_TASK.defaultProfile;
-				if (!taskModels.value.profiles[profileName]) {
-					ctx.ui.notify(`Configure rename task profile ${profileName} with /task-models.`, "warning");
-				}
-			}
-		} catch {
-			ctx.ui.notify("Couldn't read task model config. Run /task-models.", "warning");
-		}
 		const title = pi.getSessionName();
 		automaticStarted = Boolean(title || latestUserText);
 		const saved = savedTitle(ctx);

package/internal/task-models.ts

@@ -0,0 +1,48 @@
+import type { ExtensionAPI, ExtensionContext } from "@earendil-works/pi-coding-agent";
+import {
+	loadTaskModelsConfig,
+	resolveConfiguredTaskRoutes,
+	type ModelTask,
+	type ResolvedTaskRoute,
+	type TaskRouteError,
+} from "@henryqw/pi-task-models";
+
+// Pi reloads extensions without a module cache, so process state keeps the warning once per session.
+const WARNED_SESSION = Symbol.for("pi-herdr-tools/task-models-warned-session");
+
+/** Resolve routes for `task`; profile errors name the feature, config errors keep pi-task-models' message. */
+export function configuredTaskRoutes(ctx: ExtensionContext, task: ModelTask, label: string): ResolvedTaskRoute[] {
+	try {
+		return resolveConfiguredTaskRoutes(ctx, task);
+	} catch (error) {
+		const { taskRouteCode, profileName } = error as TaskRouteError;
+		if (taskRouteCode === "profile-missing") throw new Error(`${label} task profile ${profileName} is not configured. Run /task-models.`);
+		if (taskRouteCode === "no-route") throw new Error(`${label} task profile ${profileName} has no available route. Run /task-models.`);
+		throw error;
+	}
+}
+
+/** Warn at most once per session when the shared config cannot route `tasks`. */
+export function registerTaskModelsWarning(pi: ExtensionAPI, tasks: readonly ModelTask[]): void {
+	pi.on("session_start", (_event, ctx) => {
+		const state = globalThis as { [WARNED_SESSION]?: string };
+		const sessionId = ctx.sessionManager.getSessionId();
+		if (state[WARNED_SESSION] === sessionId) return;
+		let message: string | undefined;
+		try {
+			const config = loadTaskModelsConfig();
+			if (config.source === "missing") {
+				message = "Task model config is missing. Run /task-models to configure task routes.";
+			} else {
+				const missing = [...new Set(tasks.map((task) => config.value.tasks[task.id] ?? task.defaultProfile))]
+					.filter((profile) => !config.value.profiles[profile]);
+				if (missing.length) message = `Task model profile ${missing.join(", ")} is not configured. Run /task-models.`;
+			}
+		} catch {
+			message = "Couldn't read task model config. Run /task-models.";
+		}
+		if (!message) return;
+		state[WARNED_SESSION] = sessionId;
+		ctx.ui.notify(message, "warning");
+	});
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@henryqw/pi-herdr-tools",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "description": "Clone, hand off, name, and finish Pi conversations in Herdr, with mergeable side questions.",
   "keywords": ["pi-package", "pi", "herdr", "session", "clone", "side-thread", "title"],
   "type": "module",