@henryqw/pi-herdr-rename 0.2.0 → 0.3.1

package/README.md

@@ -17,9 +17,9 @@ pi remove npm:@henryqw/pi-herdr-rename
 ## Behavior
 
 - On the first real, non-empty text prompt in a new session, title generation starts in the background and does not delay the main Pi response. Extension-injected prompts, empty prompts, and image-only input are ignored.
-- Successful titles are lowercase, at most five words, and at most 60 characters. The first 1,000 characters of user text are sent to the rename model; prompt content is never logged.
+- Successful titles are lowercase and, by default, at most four words and 40 characters. The first 1,000 characters of user text are sent to the rename model; prompt content is never logged.
 - A successful title updates the Pi session name and current Herdr pane. The enclosing Herdr tab is updated only when the current tab has one pane. Outside Herdr, only the Pi session name changes.
-- Resuming a named session reapplies its saved title without another rename-model request. Automatic failures stay quiet and do not change labels; there is no local fallback or retry.
+- Resuming a named session reapplies its saved title without another rename-model request. Automatic rename-model errors show a warning; other automatic failures stay quiet. Failures do not change labels, fall back locally, or retry.
 
 ## Manual rename
 
@@ -35,11 +35,13 @@ The selection is saved in:
 
 ```json
 {
-  "model": "provider/model"
+  "model": "provider/model",
+  "maxWords": 4,
+  "maxChars": 40
 }
 ```
 
-Missing, malformed, or unavailable configuration never falls back to another model.
+`maxWords` and `maxChars` accept positive integers and default to 4 and 40. Invalid limits use their defaults. Missing, malformed, or unavailable model selection never falls back to another model.
 
 ## Development
 

package/extensions/rename.ts

@@ -6,29 +6,43 @@ import {
 	type ExtensionAPI,
 	type ExtensionContext,
 } from "@earendil-works/pi-coding-agent";
+import { createHerdrClient } from "@henryqw/pi-herdr";
 
 const WIDGET_KEY = "pi-herdr-rename";
 const WIDGET_RESULT_MS = 2_000;
 const MAX_MESSAGE_CHARS = 1_000;
 const MAX_CONTEXT_CHARS = 4_000;
-const TITLE_PROMPT =
-	"Return only a short chat title for the current conversation topic, prioritizing the most recent user intent: lowercase, at most five words, and at most 60 characters.";
+const DEFAULT_MAX_WORDS = 4;
+const DEFAULT_MAX_CHARS = 40;
 const configPath = () => join(getAgentDir(), "config", "pi-herdr-rename.json");
 
-async function configuredModel(): Promise<string | undefined> {
+type RenameConfig = { model?: string; maxWords: number; maxChars: number };
+
+class RenameModelError extends Error {}
+
+const positiveInteger = (value: unknown, fallback: number) =>
+	typeof value === "number" && Number.isInteger(value) && value > 0 ? value : fallback;
+
+async function configured(): Promise<RenameConfig> {
 	try {
 		const config: unknown = JSON.parse(await readFile(configPath(), "utf8"));
 		if (config && typeof config === "object" && !Array.isArray(config)) {
-			const model = (config as { model?: unknown }).model;
-			if (typeof model === "string" && /^[^\s/]+\/\S+$/.test(model)) return model;
+			const values = config as { model?: unknown; maxWords?: unknown; maxChars?: unknown };
+			return {
+				model: typeof values.model === "string" && /^[^\s/]+\/\S+$/.test(values.model) ? values.model : undefined,
+				maxWords: positiveInteger(values.maxWords, DEFAULT_MAX_WORDS),
+				maxChars: positiveInteger(values.maxChars, DEFAULT_MAX_CHARS),
+			};
 		}
 	} catch {}
+	return { maxWords: DEFAULT_MAX_WORDS, maxChars: DEFAULT_MAX_CHARS };
 }
 
 async function saveModel(model: string): Promise<void> {
 	const path = configPath();
+	const { maxWords, maxChars } = await configured();
 	await mkdir(dirname(path), { recursive: true });
-	await writeFile(path, `${JSON.stringify({ model }, null, 2)}\n`, "utf8");
+	await writeFile(path, `${JSON.stringify({ model, maxWords, maxChars }, null, 2)}\n`, "utf8");
 }
 
 function messageText(content: unknown): string {
@@ -85,7 +99,7 @@ function recentConversation(ctx: ExtensionContext, fallback?: string): string |
 }
 
 async function generateTitle(text: string, ctx: ExtensionContext, signal: AbortSignal): Promise<string> {
-	const key = await configuredModel();
+	const { model: key, maxWords, maxChars } = await configured();
 	if (!key) throw new Error("Rename model is not configured. Run /rename-model.");
 	const separator = key.indexOf("/");
 	const provider = key.slice(0, separator);
@@ -98,11 +112,14 @@ async function generateTitle(text: string, ctx: ExtensionContext, signal: AbortS
 	const response = await ctx.modelRegistry.complete(
 		model,
 		{
-			systemPrompt: TITLE_PROMPT,
+			systemPrompt: `Return only a short chat title for the current conversation topic, prioritizing the most recent user intent: lowercase, at most ${maxWords} words, and at most ${maxChars} characters.`,
 			messages: [{ role: "user", content: text.slice(0, MAX_CONTEXT_CHARS), timestamp: Date.now() }],
 		},
 		{ signal, maxRetries: 0, maxTokens: 64 },
 	);
+	if (response.stopReason === "error") {
+		throw new RenameModelError(response.errorMessage || "Rename model failed.");
+	}
 	if (response.stopReason !== "stop") throw new Error("Rename model did not return a complete title.");
 
 	const title = response.content
@@ -112,21 +129,15 @@ async function generateTitle(text: string, ctx: ExtensionContext, signal: AbortS
 		.trim()
 		.toLowerCase()
 		.replace(/\s+/g, " ");
-	if (!title || title.length > 60 || title.split(" ").length > 5) {
+	if (!title || title.length > maxChars || title.split(" ").length > maxWords) {
 		throw new Error("Rename model returned an invalid title.");
 	}
 	return title;
 }
 
-async function herdr(pi: ExtensionAPI, args: string[], signal: AbortSignal): Promise<string> {
-	const result = await pi.exec("herdr", args, { signal });
-	if (result.code !== 0 || result.killed) {
-		throw new Error(`Herdr ${args[0]} failed: ${result.stderr.trim() || `exit code ${result.code}`}`);
-	}
-	return result.stdout;
-}
-
 export default function herdrRenameExtension(pi: ExtensionAPI): void {
+	const herdr = createHerdrClient<{ signal: AbortSignal }>((command, args, options) =>
+		pi.exec(command, [...args], options));
 	let latestUserText: string | undefined;
 	let automaticStarted = false;
 	let sequence = 0;
@@ -142,21 +153,19 @@ export default function herdrRenameExtension(pi: ExtensionAPI): void {
 		if (!paneId) return;
 
 		if (!isCurrent(request, controller)) return;
-		await herdr(pi, ["pane", "rename", paneId, title], controller.signal);
+		await herdr.run(["pane", "rename", paneId, title], { signal: controller.signal });
 		if (!isCurrent(request, controller)) return;
 
-		const paneResponse: unknown = JSON.parse(
-			await herdr(pi, ["pane", "get", paneId], controller.signal),
-		);
+		const paneResponse: unknown = await herdr.json(["pane", "get", paneId], { signal: controller.signal });
 		const tabId = (paneResponse as { result?: { pane?: { tab_id?: unknown } } }).result?.pane?.tab_id;
 		if (typeof tabId !== "string" || !tabId) throw new Error("Herdr pane response omitted tab_id.");
 		if (!isCurrent(request, controller)) return;
 
-		const tabResponse: unknown = JSON.parse(await herdr(pi, ["tab", "get", tabId], controller.signal));
+		const tabResponse: unknown = await herdr.json(["tab", "get", tabId], { signal: controller.signal });
 		const paneCount = (tabResponse as { result?: { tab?: { pane_count?: unknown } } }).result?.tab?.pane_count;
 		if (typeof paneCount !== "number") throw new Error("Herdr tab response omitted pane_count.");
 		if (paneCount === 1 && isCurrent(request, controller)) {
-			await herdr(pi, ["tab", "rename", tabId, title], controller.signal);
+			await herdr.run(["tab", "rename", tabId, title], { signal: controller.signal });
 		}
 	};
 
@@ -180,7 +189,7 @@ export default function herdrRenameExtension(pi: ExtensionAPI): void {
 			await applyHerdr(title, request, controller);
 			return title;
 		} catch (error) {
-			if (manual && isCurrent(request, controller)) {
+			if (isCurrent(request, controller) && (manual || error instanceof RenameModelError)) {
 				ctx.ui.notify(error instanceof Error ? error.message : "Rename failed.", "warning");
 			}
 			return undefined;
@@ -202,7 +211,7 @@ export default function herdrRenameExtension(pi: ExtensionAPI): void {
 		active = undefined;
 		sequence++;
 		latestUserText = latestSessionUserText(ctx);
-		if (!(await configuredModel())) {
+		if (!(await configured()).model) {
 			ctx.ui.notify("Run /rename-model to configure chat title generation.", "warning");
 		}
 		const title = pi.getSessionName();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@henryqw/pi-herdr-rename",
-  "version": "0.2.0",
+  "version": "0.3.1",
   "description": "Generate short Pi chat titles and rename the current Herdr location.",
   "keywords": [
     "pi-package",
@@ -42,5 +42,8 @@
     "extensions": [
       "./extensions"
     ]
+  },
+  "dependencies": {
+    "@henryqw/pi-herdr": "^0.1.0"
   }
 }