@henryqw/pi-herdr-rename 0.1.0 → 0.3.0

package/README.md

@@ -17,17 +17,17 @@ pi remove npm:@henryqw/pi-herdr-rename
 ## Behavior
 
 - On the first real, non-empty text prompt in a new session, title generation starts in the background and does not delay the main Pi response. Extension-injected prompts, empty prompts, and image-only input are ignored.
-- Successful titles are lowercase, at most five words, and at most 60 characters. The first 1,000 characters of user text are sent to the rename model; prompt content is never logged.
+- Successful titles are lowercase and, by default, at most four words and 40 characters. The first 1,000 characters of user text are sent to the rename model; prompt content is never logged.
 - A successful title updates the Pi session name and current Herdr pane. The enclosing Herdr tab is updated only when the current tab has one pane. Outside Herdr, only the Pi session name changes.
-- Resuming a named session reapplies its saved title without another rename-model request. Automatic failures stay quiet and do not change labels; there is no local fallback or retry.
+- Resuming a named session reapplies its saved title without another rename-model request. Automatic rename-model errors show a warning; other automatic failures stay quiet. Failures do not change labels, fall back locally, or retry.
 
 ## Manual rename
 
-Run `/rename` to generate a title from up to the three most recent user/assistant rounds. It uses text only, caps each message at 1,000 characters and the complete context at 4,000 characters, and applies the same Pi and Herdr rules. The command warns without changing anything when no user text exists or generation fails. If requests overlap, the latest rename request wins.
+Run `/rename` to generate a title from up to the three most recent user/assistant rounds. It uses text only, caps each message at 1,000 characters and the complete context at 4,000 characters, and applies the same Pi and Herdr rules. An animated widget shows `renaming...`, briefly changes to `renamed to <title>`, then disappears. The command warns without changing anything when no user text exists or generation fails. If requests overlap, the latest rename request wins.
 
 ## Rename model
 
-Run `/rename-model` to choose an available authenticated text model with Pi's native selector. The default is `openai-codex/gpt-5.6-luna`.
+Run `/rename-model` to choose the model from Pi's available authenticated text models. Until a valid selection is saved, every session start prompts you to run the command and title generation remains disabled.
 
 The selection is saved in:
 
@@ -35,11 +35,13 @@ The selection is saved in:
 
 ```json
 {
-  "model": "provider/model"
+  "model": "provider/model",
+  "maxWords": 4,
+  "maxChars": 40
 }
 ```
 
-Missing or malformed configuration uses the default. An unavailable configured model is not silently replaced; run `/rename-model` to choose another model.
+`maxWords` and `maxChars` accept positive integers and default to 4 and 40. Invalid limits use their defaults. Missing, malformed, or unavailable model selection never falls back to another model.
 
 ## Development
 

package/extensions/rename.ts

@@ -1,35 +1,47 @@
 import { mkdir, readFile, writeFile } from "node:fs/promises";
 import { dirname, join } from "node:path";
 import {
+	BorderedLoader,
 	getAgentDir,
 	type ExtensionAPI,
 	type ExtensionContext,
 } from "@earendil-works/pi-coding-agent";
 
-const DEFAULT_MODEL = "openai-codex/gpt-5.6-luna";
+const WIDGET_KEY = "pi-herdr-rename";
+const WIDGET_RESULT_MS = 2_000;
 const MAX_MESSAGE_CHARS = 1_000;
 const MAX_CONTEXT_CHARS = 4_000;
-const TITLE_PROMPT =
-	"Return only a short chat title for the current conversation topic, prioritizing the most recent user intent: lowercase, at most five words, and at most 60 characters.";
+const DEFAULT_MAX_WORDS = 4;
+const DEFAULT_MAX_CHARS = 40;
 const configPath = () => join(getAgentDir(), "config", "pi-herdr-rename.json");
 
-async function configuredModel(): Promise<string> {
+type RenameConfig = { model?: string; maxWords: number; maxChars: number };
+
+class RenameModelError extends Error {}
+
+const positiveInteger = (value: unknown, fallback: number) =>
+	typeof value === "number" && Number.isInteger(value) && value > 0 ? value : fallback;
+
+async function configured(): Promise<RenameConfig> {
 	try {
 		const config: unknown = JSON.parse(await readFile(configPath(), "utf8"));
 		if (config && typeof config === "object" && !Array.isArray(config)) {
-			const model = (config as { model?: unknown }).model;
-			if (typeof model === "string" && /^[^\s/]+\/\S+$/.test(model)) return model;
+			const values = config as { model?: unknown; maxWords?: unknown; maxChars?: unknown };
+			return {
+				model: typeof values.model === "string" && /^[^\s/]+\/\S+$/.test(values.model) ? values.model : undefined,
+				maxWords: positiveInteger(values.maxWords, DEFAULT_MAX_WORDS),
+				maxChars: positiveInteger(values.maxChars, DEFAULT_MAX_CHARS),
+			};
 		}
-	} catch {
-		// Missing or malformed config uses the default model.
-	}
-	return DEFAULT_MODEL;
+	} catch {}
+	return { maxWords: DEFAULT_MAX_WORDS, maxChars: DEFAULT_MAX_CHARS };
 }
 
 async function saveModel(model: string): Promise<void> {
 	const path = configPath();
+	const { maxWords, maxChars } = await configured();
 	await mkdir(dirname(path), { recursive: true });
-	await writeFile(path, `${JSON.stringify({ model }, null, 2)}\n`, "utf8");
+	await writeFile(path, `${JSON.stringify({ model, maxWords, maxChars }, null, 2)}\n`, "utf8");
 }
 
 function messageText(content: unknown): string {
@@ -86,7 +98,8 @@ function recentConversation(ctx: ExtensionContext, fallback?: string): string |
 }
 
 async function generateTitle(text: string, ctx: ExtensionContext, signal: AbortSignal): Promise<string> {
-	const key = await configuredModel();
+	const { model: key, maxWords, maxChars } = await configured();
+	if (!key) throw new Error("Rename model is not configured. Run /rename-model.");
 	const separator = key.indexOf("/");
 	const provider = key.slice(0, separator);
 	const id = key.slice(separator + 1);
@@ -98,11 +111,14 @@ async function generateTitle(text: string, ctx: ExtensionContext, signal: AbortS
 	const response = await ctx.modelRegistry.complete(
 		model,
 		{
-			systemPrompt: TITLE_PROMPT,
+			systemPrompt: `Return only a short chat title for the current conversation topic, prioritizing the most recent user intent: lowercase, at most ${maxWords} words, and at most ${maxChars} characters.`,
 			messages: [{ role: "user", content: text.slice(0, MAX_CONTEXT_CHARS), timestamp: Date.now() }],
 		},
 		{ signal, maxRetries: 0, maxTokens: 64 },
 	);
+	if (response.stopReason === "error") {
+		throw new RenameModelError(response.errorMessage || "Rename model failed.");
+	}
 	if (response.stopReason !== "stop") throw new Error("Rename model did not return a complete title.");
 
 	const title = response.content
@@ -112,7 +128,7 @@ async function generateTitle(text: string, ctx: ExtensionContext, signal: AbortS
 		.trim()
 		.toLowerCase()
 		.replace(/\s+/g, " ");
-	if (!title || title.length > 60 || title.split(" ").length > 5) {
+	if (!title || title.length > maxChars || title.split(" ").length > maxWords) {
 		throw new Error("Rename model returned an invalid title.");
 	}
 	return title;
@@ -131,6 +147,8 @@ export default function herdrRenameExtension(pi: ExtensionAPI): void {
 	let automaticStarted = false;
 	let sequence = 0;
 	let active: AbortController | undefined;
+	let widgetSequence = 0;
+	let widgetTimer: ReturnType<typeof setTimeout> | undefined;
 
 	const isCurrent = (request: number, controller: AbortController) =>
 		request === sequence && active === controller && !controller.signal.aborted;
@@ -169,27 +187,40 @@ export default function herdrRenameExtension(pi: ExtensionAPI): void {
 		if (isCurrent(request, controller)) active = undefined;
 	};
 
-	const rename = async (text: string, ctx: ExtensionContext, manual: boolean): Promise<void> => {
+	const rename = async (text: string, ctx: ExtensionContext, manual: boolean): Promise<string | undefined> => {
 		const { request, controller } = begin();
 		try {
 			const title = await generateTitle(text, ctx, controller.signal);
 			if (!isCurrent(request, controller)) return;
 			pi.setSessionName(title);
 			await applyHerdr(title, request, controller);
+			return title;
 		} catch (error) {
-			if (manual && isCurrent(request, controller)) {
+			if (isCurrent(request, controller) && (manual || error instanceof RenameModelError)) {
 				ctx.ui.notify(error instanceof Error ? error.message : "Rename failed.", "warning");
 			}
+			return undefined;
 		} finally {
 			finish(request, controller);
 		}
 	};
 
-	pi.on("session_start", (_event, ctx) => {
+	const clearWidget = (ctx: ExtensionContext) => {
+		widgetSequence++;
+		if (widgetTimer) clearTimeout(widgetTimer);
+		widgetTimer = undefined;
+		ctx.ui.setWidget(WIDGET_KEY, undefined);
+	};
+
+	pi.on("session_start", async (_event, ctx) => {
+		clearWidget(ctx);
 		active?.abort();
 		active = undefined;
 		sequence++;
 		latestUserText = latestSessionUserText(ctx);
+		if (!(await configured()).model) {
+			ctx.ui.notify("Run /rename-model to configure chat title generation.", "warning");
+		}
 		const title = pi.getSessionName();
 		automaticStarted = Boolean(title || latestUserText);
 		if (!title) return;
@@ -210,7 +241,8 @@ export default function herdrRenameExtension(pi: ExtensionAPI): void {
 		return { action: "continue" };
 	});
 
-	pi.on("session_shutdown", () => {
+	pi.on("session_shutdown", (_event, ctx) => {
+		clearWidget(ctx);
 		active?.abort();
 		active = undefined;
 		sequence++;
@@ -224,7 +256,26 @@ export default function herdrRenameExtension(pi: ExtensionAPI): void {
 				ctx.ui.notify("No user text is available to rename this chat.", "warning");
 				return;
 			}
-			await rename(context, ctx, true);
+			if (widgetTimer) clearTimeout(widgetTimer);
+			widgetTimer = undefined;
+			const widgetRequest = ++widgetSequence;
+			ctx.ui.setWidget(
+				WIDGET_KEY,
+				(tui, theme) => new BorderedLoader(tui, theme, "renaming...", { cancellable: false }),
+			);
+			const title = await rename(context, ctx, true);
+			if (widgetRequest !== widgetSequence) return;
+			if (!title) {
+				ctx.ui.setWidget(WIDGET_KEY, undefined);
+				return;
+			}
+			ctx.ui.setWidget(WIDGET_KEY, [`renamed to ${title}`]);
+			widgetTimer = setTimeout(() => {
+				if (widgetRequest !== widgetSequence) return;
+				ctx.ui.setWidget(WIDGET_KEY, undefined);
+				widgetTimer = undefined;
+			}, WIDGET_RESULT_MS);
+			widgetTimer.unref?.();
 		},
 	});
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@henryqw/pi-herdr-rename",
-  "version": "0.1.0",
+  "version": "0.3.0",
   "description": "Generate short Pi chat titles and rename the current Herdr location.",
   "keywords": [
     "pi-package",