@henryqw/pi-add-dir 3.1.2 → 3.1.3

package/README.md

@@ -50,7 +50,7 @@ Package-owned: `~/.pi/agent/config/pi-add-dir/config.json`
 | --- | --- | --- | --- |
 | `directories` | Directories loaded for every workspace. `/dir-add --global` updates this list. | Array of unique absolute paths without control characters. | `[]` |
 
-If the file is missing, the extension uses the default. Invalid config stops the load, and the extension does not overwrite the file. Reload Pi after you edit the file manually.
+If the file is missing, the extension uses the default. At launch, the extension shows a warning for each unknown key and each invalid or duplicate directory entry. It ignores that key or entry and loads the other directories. If the file is malformed or `directories` is not an array, it shows a warning and uses the default. It does not change the file. `/dir-add --global` and global removal with `/dir-ls` fail until you fix the reported issues. Reload Pi after you edit the file manually.
 
 ## State and storage
 

package/extensions/add-dir-config.ts

@@ -1,40 +1,11 @@
-import { isAbsolute } from "node:path";
-import { createConfigStore } from "@henryqw/pi-config-store";
-
-export interface AddDirConfig {
-	directories: string[];
-}
-
-function parseConfig(value: unknown): AddDirConfig {
-	if (!value || typeof value !== "object" || Array.isArray(value)) {
-		throw new Error("Invalid pi-add-dir config: expected an object.");
-	}
-	const config = value as Record<string, unknown>;
-	if (Object.keys(config).length !== 1 || !Array.isArray(config.directories)) {
-		throw new Error('Invalid pi-add-dir config: expected only a "directories" array.');
-	}
-	const directories = config.directories;
-	if (
-		directories.some(
-			(directory) =>
-				typeof directory !== "string" ||
-				!isAbsolute(directory) ||
-				/\p{C}/u.test(directory),
-		)
-	) {
-		throw new Error("Invalid pi-add-dir config: directories must be absolute paths without control characters.");
-	}
-	if (new Set(directories).size !== directories.length) {
-		throw new Error("Invalid pi-add-dir config: directories must be unique.");
-	}
-	return { directories: [...directories] };
-}
+import { createConfigStore, field, parsers } from "@henryqw/pi-config-store";
 
 export function createAddDirConfigStore(agentDir?: string) {
-	return createConfigStore<AddDirConfig>({
+	return createConfigStore({
 		extensionId: "pi-add-dir",
 		agentDir,
-		defaults: () => ({ directories: [] }),
-		parse: parseConfig,
+		fields: {
+			directories: field(parsers.array(parsers.absolutePath(), { unique: (directory) => directory }), []),
+		},
 	});
 }

package/extensions/add-dir.ts

@@ -9,6 +9,7 @@ import {
 	type AutocompleteSuggestions,
 } from "@earendil-works/pi-tui";
 import type { ExtensionAPI, ExtensionContext } from "@earendil-works/pi-coding-agent";
+import { registerConfigReporting } from "@henryqw/pi-config-store";
 import { Type } from "typebox";
 import {
 	buildContextInjection,
@@ -227,6 +228,9 @@ export function createExternalAutocompleteProvider(
 
 export default function addDirExtension(pi: ExtensionAPI, options: ExtensionOptions = {}): void {
 	const globalStore = createAddDirConfigStore(options.agentDir);
+	const configReporter = registerConfigReporting(pi, [globalStore]);
+	// Report the latest file before a global write, so issues found after launch use the same deduplicated report.
+	const reportGlobalConfig = (ctx: ExtensionContext) => configReporter.report(ctx, globalStore, globalStore.loadSync());
 	let sessionDirs: SessionDir[] = [];
 	let projectPaths: string[] = [];
 	let globalPaths: string[] = [];
@@ -234,17 +238,10 @@ export default function addDirExtension(pi: ExtensionAPI, options: ExtensionOpti
 	let addedDirs: ScopedDir[] = [];
 	let currentCwd = "";
 
-	function globalConfigError(error: unknown): Error {
-		const message = error instanceof Error ? error.message : String(error);
-		return new Error(`Cannot load pi-add-dir global config at ${globalStore.path}: ${message}`, { cause: error });
-	}
-
+	// No field disables this config, so a load always has a value; bad entries are dropped and reported at launch.
 	function loadGlobalPaths(): string[] {
-		try {
-			return globalStore.loadSync().value.directories;
-		} catch (error) {
-			throw globalConfigError(error);
-		}
+		const loaded = globalStore.loadSync();
+		return loaded.status === "ok" ? loaded.value.directories : [];
 	}
 
 	function updateWidget(ctx: ExtensionContext): void {
@@ -391,17 +388,14 @@ export default function addDirExtension(pi: ExtensionAPI, options: ExtensionOpti
 
 	async function writePersistentPath(source: "project" | "global", absolutePath: string, ctx: ExtensionContext): Promise<void> {
 		if (source === "global") {
-			try {
-				const config = await globalStore.update((current) => ({
-					directories: current.directories.includes(absolutePath)
-						? current.directories
-						: [...current.directories, absolutePath],
-				}));
-				globalPaths = config.directories;
-				return;
-			} catch (error) {
-				throw globalConfigError(error);
-			}
+			reportGlobalConfig(ctx);
+			const config = await globalStore.update((current) => ({
+				directories: current.directories.includes(absolutePath)
+					? current.directories
+					: [...current.directories, absolutePath],
+			}));
+			globalPaths = config.directories;
+			return;
 		}
 		projectPaths = await readProjectPaths(ctx.cwd, true);
 		if (projectPaths.some((path) => resolveDir(path, ctx.cwd) === absolutePath)) return;
@@ -498,14 +492,11 @@ export default function addDirExtension(pi: ExtensionAPI, options: ExtensionOpti
 				);
 				persistState();
 			} else if (dir.source === "global") {
-				try {
-					const config = await globalStore.update((current) => ({
-						directories: current.directories.filter((path) => path !== dir.storedPath),
-					}));
-					globalPaths = config.directories;
-				} catch (error) {
-					throw globalConfigError(error);
-				}
+				reportGlobalConfig(ctx);
+				const config = await globalStore.update((current) => ({
+					directories: current.directories.filter((path) => path !== dir.storedPath),
+				}));
+				globalPaths = config.directories;
 			} else {
 				await mutateProjectConfig(
 					["--unset-all", "--fixed-value", PROJECT_CONFIG_KEY, dir.storedPath],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@henryqw/pi-add-dir",
-  "version": "3.1.2",
+  "version": "3.1.3",
   "description": "Add external directories to a Pi session with context, skills, and file search.",
   "keywords": [
     "pi-package",
@@ -47,7 +47,7 @@
     "image": "https://raw.githubusercontent.com/HenryQW/pi-harness/main/extensions/pi-add-dir/example.png"
   },
   "dependencies": {
-    "@henryqw/pi-config-store": "^3.0.0"
+    "@henryqw/pi-config-store": "^4.0.0"
   },
   "devDependencies": {
     "@earendil-works/pi-coding-agent": "1.1.0",