@henrylabs-interview/payment-processor 0.1.13 → 0.1.14

package/dist/index.d.ts

@@ -11,7 +11,7 @@ export declare class PaymentProcessor {
 export declare class EmbeddedCheckout {
     private checkoutId;
     constructor(config: {
-        checkoutId: number;
+        checkoutId: string;
     });
     /**
      * Renders the embedded checkout UI

package/dist/resources/checkout.d.ts

@@ -12,7 +12,7 @@ interface CheckoutCreateSuccessImmediate extends CheckoutCreateGeneric {
     status: 'success';
     substatus: '201-immediate';
     data: {
-        checkoutId: number;
+        checkoutId: string;
         paymentMethodOptions: string[];
     };
 }
@@ -54,7 +54,7 @@ interface CheckoutConfirmSuccessImmediate extends CheckoutConfirmGeneric {
     status: 'success';
     substatus: '201-immediate';
     data: {
-        confirmationId: number;
+        confirmationId: string;
         amount: number;
         currency: string;
         customerId?: string;

package/dist/resources/checkout.js

@@ -1,5 +1,5 @@
 import { readHistory, writeHistory } from '../utils/store';
-import { generateID, generateTimeBasedID, hashToNumber, signPayload } from '../utils/crypto';
+import { generateTimeBasedID, hashToString, signPayload } from '../utils/crypto';
 import { INTERNAL_WEBHOOKS } from './webhooks';
 import { sleep } from '../utils/async';
 // checkoutId -> { historyRecordId }
@@ -130,7 +130,7 @@ export class Checkout {
         };
     }
     createCheckoutRecord(hashId) {
-        const checkoutId = generateTimeBasedID('checkout');
+        const checkoutId = `cki_${generateTimeBasedID('checkout')}`;
         INTERNAL_CHECKOUTS[`${checkoutId}`] = {
             historyRecordId: hashId,
         };
@@ -170,7 +170,7 @@ export class Checkout {
         }, webhookDelay);
     }
     buildHistoryHash(params) {
-        return hashToNumber(JSON.stringify({
+        return hashToString(JSON.stringify({
             type: 'HISTORY_RECORD',
             amount: params.amount,
             currency: params.currency,
@@ -179,7 +179,7 @@ export class Checkout {
     }
     ///
     async validateConfirm(params) {
-        if (`${params.checkoutId}`.length !== 12) {
+        if (`${params.checkoutId}`.length !== 20 || !`${params.checkoutId}`.startsWith('cki_')) {
             return {
                 status: 'failure',
                 substatus: '500-error',
@@ -195,13 +195,15 @@ export class Checkout {
                 message: 'Expired checkout ID',
             };
         }
-        if (params.type === 'embedded' && params.data.paymentToken.length !== 12) {
-            return {
-                status: 'failure',
-                substatus: '500-error',
-                code: 500,
-                message: 'Invalid payment token',
-            };
+        if (params.type === 'embedded') {
+            if (params.data.paymentToken.length !== 20 || !params.data.paymentToken.startsWith('pmt_')) {
+                return {
+                    status: 'failure',
+                    substatus: '500-error',
+                    code: 500,
+                    message: 'Invalid payment token',
+                };
+            }
         }
         if (params.type === 'embedded') {
             const paymentToken = `pmt_${generateTimeBasedID('payment-token')}`;
@@ -291,12 +293,13 @@ export class Checkout {
                 message: 'Missing history record',
             };
         }
-        const confirmationId = hashToNumber(JSON.stringify({
-            type: 'CONFIRMATION_ID',
-            amount: record.amount,
-            currency: record.currency,
-            customerId: record.customerId,
-        }));
+        const confirmationId = 'cof_' +
+            hashToString(JSON.stringify({
+                type: 'CONFIRMATION_ID',
+                amount: record.amount,
+                currency: record.currency,
+                customerId: record.customerId,
+            }));
         return {
             status: 'success',
             substatus: '201-immediate',

package/dist/resources/embedded.d.ts

@@ -1 +1 @@
-export declare function renderEmbeddedCheckout(containerElementId: string, checkoutId: number, callbackFn: (paymentToken: string) => void): boolean;
+export declare function renderEmbeddedCheckout(containerElementId: string, checkoutId: string, callbackFn: (paymentToken: string) => void): boolean;

package/dist/resources/embedded.js

@@ -5,11 +5,11 @@ export function renderEmbeddedCheckout(containerElementId, checkoutId, callbackF
         console.warn('EmbeddedCheckoutUI can only be used in a browser environment.');
         return false;
     }
-    if (checkoutId.toString().length !== 12) {
+    if (checkoutId.toString().length !== 20 && !checkoutId.startsWith('cki_')) {
         console.warn(`Invalid checkout ID: "${checkoutId}".`);
         return false;
     }
-    if (`${checkoutId}` === `${generateTimeBasedID('checkout')}`) {
+    if (`${checkoutId}` === `cki_${generateTimeBasedID('checkout')}`) {
         console.warn(`Expired checkout ID: "${checkoutId}".`);
         return false;
     }

package/dist/utils/crypto.d.ts

@@ -1,4 +1,4 @@
 export declare function generateID(length?: number): number;
-export declare function generateTimeBasedID(extra?: string): number;
-export declare function hashToNumber(input: string, length?: number): number;
+export declare function generateTimeBasedID(extra?: string): string;
+export declare function hashToString(input: string): string;
 export declare function signPayload(payload: string, secret: string): string;

package/dist/utils/crypto.js

@@ -11,14 +11,12 @@ export function generateTimeBasedID(extra = '') {
     const now = Date.now(); // current time in ms
     const oneMinute = 60 * 1000;
     const ms = Math.floor(now / oneMinute) * oneMinute;
-    return hashToNumber(`${ms}---${extra}`);
+    return hashToString(`${ms}---${extra}`);
 }
-export function hashToNumber(input, length = 12) {
-    if (length > 16) {
-        throw new Error('Length is greater than max length of 16!');
-    }
+export function hashToString(input) {
     const hash = crypto.createHash('sha256').update(input).digest('hex');
-    return parseInt(hash.slice(0, length), 16);
+    // 16 hex characters = 64 bits
+    return hash.slice(0, 16);
 }
 export function signPayload(payload, secret) {
     return crypto.createHmac('sha256', secret).update(payload).digest('hex');

package/dist/utils/store.d.ts

@@ -1,5 +1,5 @@
 export type HistoryRecord = {
-    id: number;
+    id: string;
     amount: number;
     currency: 'USD' | 'EUR' | 'JPY';
     customerId: string | null;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@henrylabs-interview/payment-processor",
-	"version": "0.1.13",
+	"version": "0.1.14",
 	"type": "module",
 	"main": "./dist/index.js",
 	"types": "./dist/index.d.ts",