@henrylabs-interview/payment-processor 0.1.12 → 0.1.13

package/dist/index.d.ts

@@ -11,7 +11,7 @@ export declare class PaymentProcessor {
 export declare class EmbeddedCheckout {
     private checkoutId;
     constructor(config: {
-        checkoutId: string;
+        checkoutId: number;
     });
     /**
      * Renders the embedded checkout UI

package/dist/resources/checkout.d.ts

@@ -64,15 +64,6 @@ interface CheckoutConfirmFailure extends CheckoutConfirmGeneric {
     status: 'failure';
     substatus: '500-error' | '502-fraud' | '503-retry';
 }
-export declare const INTERNAL_CHECKOUTS: Record<string, {
-    historyRecordId: number;
-}>;
-export declare const INTERNAL_CARDS: Record<string, {
-    number: string;
-    expMonth: number;
-    expYear: number;
-    cvc: string;
-}>;
 export declare class Checkout {
     /**
      * Create a new checkout session

package/dist/resources/checkout.js

@@ -1,11 +1,9 @@
 import { readHistory, writeHistory } from '../utils/store';
-import { generateID, hashToNumber, signPayload } from '../utils/crypto';
+import { generateID, generateTimeBasedID, hashToNumber, signPayload } from '../utils/crypto';
 import { INTERNAL_WEBHOOKS } from './webhooks';
 import { sleep } from '../utils/async';
 // checkoutId -> { historyRecordId }
-export const INTERNAL_CHECKOUTS = {};
-// paymentToken -> card details
-export const INTERNAL_CARDS = {};
+const INTERNAL_CHECKOUTS = {};
 export class Checkout {
     /**
      * Create a new checkout session
@@ -132,7 +130,7 @@ export class Checkout {
         };
     }
     createCheckoutRecord(hashId) {
-        const checkoutId = generateID();
+        const checkoutId = generateTimeBasedID('checkout');
         INTERNAL_CHECKOUTS[`${checkoutId}`] = {
             historyRecordId: hashId,
         };
@@ -181,7 +179,7 @@ export class Checkout {
     }
     ///
     async validateConfirm(params) {
-        if (!INTERNAL_CHECKOUTS[`${params.checkoutId}`]) {
+        if (`${params.checkoutId}`.length !== 12) {
             return {
                 status: 'failure',
                 substatus: '500-error',
@@ -189,14 +187,30 @@ export class Checkout {
                 message: 'Invalid checkout ID',
             };
         }
+        if (!INTERNAL_CHECKOUTS[`${params.checkoutId}`]) {
+            return {
+                status: 'failure',
+                substatus: '503-retry',
+                code: 504,
+                message: 'Expired checkout ID',
+            };
+        }
+        if (params.type === 'embedded' && params.data.paymentToken.length !== 12) {
+            return {
+                status: 'failure',
+                substatus: '500-error',
+                code: 500,
+                message: 'Invalid payment token',
+            };
+        }
         if (params.type === 'embedded') {
-            const stored = INTERNAL_CARDS[`${params.data.paymentToken}`];
-            if (!stored) {
+            const paymentToken = `pmt_${generateTimeBasedID('payment-token')}`;
+            if (params.data.paymentToken !== paymentToken) {
                 return {
                     status: 'failure',
-                    substatus: '500-error',
-                    code: 500,
-                    message: 'Invalid payment token',
+                    substatus: '503-retry',
+                    code: 503,
+                    message: 'Expired payment token',
                 };
             }
         }
@@ -230,21 +244,6 @@ export class Checkout {
         return null;
     }
     async processConfirmDecision(params) {
-        if (params.type === 'raw-card') {
-            // Add new card to internal storage
-            const cardDetails = {
-                number: params.data.number,
-                expMonth: params.data.expMonth,
-                expYear: params.data.expYear > 2000 ? params.data.expYear : params.data.expYear + 2000,
-                cvc: params.data.cvc,
-            };
-            const paymentToken = 'pmt_' +
-                hashToNumber(JSON.stringify({
-                    type: 'PAYMENT_TOKEN',
-                    ...cardDetails,
-                }));
-            INTERNAL_CARDS[`${paymentToken}`] = cardDetails;
-        }
         const decision = Math.random();
         if (decision > 0.85) {
             return {

package/dist/resources/embedded.d.ts

@@ -1 +1 @@
-export declare function renderEmbeddedCheckout(containerElementId: string, checkoutId: string, callbackFn: (paymentToken: string) => void): boolean;
+export declare function renderEmbeddedCheckout(containerElementId: string, checkoutId: number, callbackFn: (paymentToken: string) => void): boolean;

package/dist/resources/embedded.js

@@ -1,16 +1,18 @@
-import { hashToNumber } from '../utils/crypto';
-import { INTERNAL_CARDS, INTERNAL_CHECKOUTS } from './checkout';
+import { generateTimeBasedID } from '../utils/crypto';
 export function renderEmbeddedCheckout(containerElementId, checkoutId, callbackFn) {
     // Ensure browser environment
     if (typeof window === 'undefined' || typeof document === 'undefined') {
         console.warn('EmbeddedCheckoutUI can only be used in a browser environment.');
         return false;
     }
-    const { historyRecordId } = INTERNAL_CHECKOUTS[`${checkoutId}`] ?? {};
-    if (!historyRecordId) {
+    if (checkoutId.toString().length !== 12) {
         console.warn(`Invalid checkout ID: "${checkoutId}".`);
         return false;
     }
+    if (`${checkoutId}` === `${generateTimeBasedID('checkout')}`) {
+        console.warn(`Expired checkout ID: "${checkoutId}".`);
+        return false;
+    }
     const container = document.getElementById(containerElementId);
     if (!container) {
         console.warn(`Container element "${containerElementId}" not found.`);
@@ -147,18 +149,13 @@ export function renderEmbeddedCheckout(containerElementId, checkoutId, callbackF
         const expYear = Number(container.querySelector('#exp-year')?.value);
         const cvc = container.querySelector('#cvc')?.value ?? '';
         // Add new card to internal storage
-        const cardDetails = {
-            number: number,
-            expMonth: expMonth,
-            expYear: expYear > 2000 ? expYear : expYear + 2000,
-            cvc: cvc,
-        };
-        const paymentToken = 'pmt_' +
-            hashToNumber(JSON.stringify({
-                type: 'PAYMENT_TOKEN',
-                ...cardDetails,
-            }));
-        INTERNAL_CARDS[`${paymentToken}`] = cardDetails;
+        // const cardDetails = {
+        // 	number: number,
+        // 	expMonth: expMonth,
+        // 	expYear: expYear > 2000 ? expYear : expYear + 2000,
+        // 	cvc: cvc,
+        // };
+        const paymentToken = `pmt_${generateTimeBasedID('payment-token')}`;
         callbackFn(paymentToken);
     });
     return true;

package/dist/utils/crypto.d.ts

@@ -1,3 +1,4 @@
 export declare function generateID(length?: number): number;
+export declare function generateTimeBasedID(extra?: string): number;
 export declare function hashToNumber(input: string, length?: number): number;
 export declare function signPayload(payload: string, secret: string): string;

package/dist/utils/crypto.js

@@ -7,6 +7,12 @@ export function generateID(length = 12) {
     }
     return parseInt(digits.join(''));
 }
+export function generateTimeBasedID(extra = '') {
+    const now = Date.now(); // current time in ms
+    const oneMinute = 60 * 1000;
+    const ms = Math.floor(now / oneMinute) * oneMinute;
+    return hashToNumber(`${ms}---${extra}`);
+}
 export function hashToNumber(input, length = 12) {
     if (length > 16) {
         throw new Error('Length is greater than max length of 16!');

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@henrylabs-interview/payment-processor",
-	"version": "0.1.12",
+	"version": "0.1.13",
 	"type": "module",
 	"main": "./dist/index.js",
 	"types": "./dist/index.d.ts",