@hellotext/hellotext 1.1.1 → 1.1.3

package/README.md

@@ -188,10 +188,10 @@ To listen to an event, you can call the `on` method, like so
 Hellotext.on(eventName, callback)
 ```
 
-To disconnect an event listener, you can call `disconnect`
+To remove an event listener, you can call `removeEventListener`
 
 ```javascript
-Hellotext.disconnect(eventName, callback)
+Hellotext.removeEventListener(eventName, callback)
 ```
 
 ### List of events

package/__tests__/hellotext_test.js

@@ -129,7 +129,19 @@ describe(".on", () => {
   });
 });
 
-describe(".disconnect", () => {
+describe("when session is stored in the cookie", function () {
+  beforeAll(() => {
+    document.cookie = `hello_session=12345`
+    Hellotext.initialize(123)
+  })
+
+  it("Assigns session from cookie", function () {
+    expect(Hellotext.session).toEqual("12345")
+  });
+});
+
+
+describe(".removeEventListener", () => {
   const business_id = "xy76ks"
 
   beforeAll(() => {
@@ -141,7 +153,7 @@ describe(".disconnect", () => {
 
   it("throws an error when event is invalid", () => {
     expect(
-      () => Hellotext.disconnect("undefined-event", () => {})
+      () => Hellotext.removeEventListener("undefined-event", () => {})
     ).toThrowError()
   });
 
@@ -149,7 +161,7 @@ describe(".disconnect", () => {
     const callback = jest.fn()
 
     Hellotext.on("session-set", callback)
-    Hellotext.disconnect("session-set", callback)
+    Hellotext.removeEventListener("session-set", callback)
 
     expect(callback).toHaveBeenCalledTimes(0)
   });

package/lib/hellotext.js

@@ -74,7 +74,7 @@ class Hellotext {
    * @param event the name of the event to remove
    * @param callback the callback to remove
    */
-  static disconnect(event, callback) {
+  static removeEventListener(event, callback) {
     if(Event.invalid(event)) { throw new InvalidEvent(event) }
 
     this.#eventEmitter.removeSubscriber(event, callback)
@@ -137,7 +137,7 @@ class Hellotext {
     document.cookie = `hello_session=${this.#session}`
   }
 
-  static #cookie() {
+  static get #cookie() {
     return document.cookie.match('(^|;)\\s*' + 'hello_session' + '\\s*=\\s*([^;]+)')?.pop()
   }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hellotext/hellotext",
-  "version": "1.1.1",
+  "version": "1.1.3",
   "description": "Hellotext JavaScript Client",
   "main": "index.js",
   "author": "Hellotext",