@helix3/helix-cli 0.1.18-helix3.266 → 0.1.18-helix3.268

package/bridge-plugins/helix.bridge.unreal/bin/unreal-skeletal-mesh-extract.js

@@ -433,7 +433,8 @@ function validateTextureBinding(value, outputRoot, label) {
   }
   const colorSpace = object(binding.colorSpace, `${label}.colorSpace`);
   const colorKeys = Object.keys(colorSpace).sort();
-  if (colorKeys.some((key) => key !== 'compressionSettings' && key !== 'srgb')) {
+  const SUPPORTED_COLOR_SPACE_KEYS = ['compressionSettings', 'flipGreenChannel', 'srgb'];
+  if (colorKeys.some((key) => !SUPPORTED_COLOR_SPACE_KEYS.includes(key))) {
     fail(`${label}.colorSpace contains unsupported metadata`);
   }
   if ('srgb' in colorSpace && typeof colorSpace.srgb !== 'boolean') {
@@ -442,6 +443,9 @@ function validateTextureBinding(value, outputRoot, label) {
   if ('compressionSettings' in colorSpace) {
     nonEmptyString(colorSpace.compressionSettings, `${label}.colorSpace.compressionSettings`);
   }
+  if ('flipGreenChannel' in colorSpace && typeof colorSpace.flipGreenChannel !== 'boolean') {
+    fail(`${label}.colorSpace.flipGreenChannel must be a boolean`);
+  }
 
   const texturePath = resolve(outputRoot, relativePath);
   containedPath(outputRoot, texturePath, label);

package/bridge-plugins/helix.bridge.unreal/test/handler.test.js

@@ -61,7 +61,9 @@ function fixture(profileOverrides = {}) {
     "  if (process.env.HELIX_TEST_SIDECAR_KIND === 'missing') continue;",
     "  const bindingSha = process.env.HELIX_TEST_SIDECAR_KIND === 'hash-mismatch' ? 'f'.repeat(64) : textureSha;",
     "  const bindingPath = process.env.HELIX_TEST_SIDECAR_KIND === 'escape' ? '../escaped.png' : 'textures/' + bindingSha + '.png';",
-    "  const sidecar = { schemaVersion: 'helix.bridge.unreal-material-sidecar/1', asset: { slug: job.slug, sourceMeshAssetPath: job.assetPath }, materials: [{ slotIndex: 0, slotName: 'Body', importedSlotName: 'Body_skin00', sourceMaterialAssetPath: '/Game/Materials/MI_Body.MI_Body', sourceRootMaterialAssetPath: '/Game/Materials/M_Body.M_Body', parameters: { scalars: { Roughness: 0.5 }, vectors: { Tint: { r: 1, g: 0.5, b: 0.25, a: 1 } }, textures: { BaseColor: { sourceAssetPath: '/Game/Textures/T_Body.T_Body', path: bindingPath, sha256: bindingSha, sizeBytes: textureBytes.length, colorSpace: { srgb: true, compressionSettings: 'TC_Default' } } } } }] };",
+    "  const colorSpace = { srgb: true, compressionSettings: 'TC_Default' };",
+    "  if (process.env.HELIX_TEST_SIDECAR_KIND === 'flip-green') colorSpace.flipGreenChannel = true;",
+    "  const sidecar = { schemaVersion: 'helix.bridge.unreal-material-sidecar/1', asset: { slug: job.slug, sourceMeshAssetPath: job.assetPath }, materials: [{ slotIndex: 0, slotName: 'Body', importedSlotName: 'Body_skin00', sourceMaterialAssetPath: '/Game/Materials/MI_Body.MI_Body', sourceRootMaterialAssetPath: '/Game/Materials/M_Body.M_Body', parameters: { scalars: { Roughness: 0.5 }, vectors: { Tint: { r: 1, g: 0.5, b: 0.25, a: 1 } }, textures: { BaseColor: { sourceAssetPath: '/Game/Textures/T_Body.T_Body', path: bindingPath, sha256: bindingSha, sizeBytes: textureBytes.length, colorSpace } } } }] };",
     "  const sidecarPath = join(dirname(job.outputPath), job.slug + '.materials.json');",
     "  if (process.env.HELIX_TEST_SIDECAR_KIND === 'corrupt') writeFileSync(sidecarPath, '{');",
     "  else if (process.env.HELIX_TEST_SIDECAR_KIND === 'symlink') symlinkSync(process.env.HELIX_TEST_INVOCATION, sidecarPath);",
@@ -272,3 +274,15 @@ test('does not walk into Binaries/Intermediate/Saved/DerivedDataCache when findi
   const response = JSON.parse(result.stdout);
   assert.equal(response.artifacts[0].kind, 'format.fbx');
 });
+
+test('accepts a material sidecar texture binding that records flipGreenChannel', () => {
+  // export_skeletal_mesh.py (texture_color_space) has recorded flipGreenChannel for every
+  // texture since the "Flip Green Channel" DirectX/OpenGL convention was added, but this
+  // handler's own sidecar validator never learned the key — every real export failed with
+  // "colorSpace contains unsupported metadata" until now.
+  const entry = fixture();
+  const result = run(entry, { HELIX_TEST_SIDECAR_KIND: 'flip-green' });
+  assert.equal(result.status, 0, result.stderr);
+  const sidecar = JSON.parse(readFileSync(join(entry.output, 'base-male.materials.json'), 'utf8'));
+  assert.equal(sidecar.materials[0].parameters.textures.BaseColor.colorSpace.flipGreenChannel, true);
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@helix3/helix-cli",
-  "version": "0.1.18-helix3.266",
+  "version": "0.1.18-helix3.268",
   "description": "helix — the HELIX creator CLI: scaffold, validate, and publish Instant Worlds",
   "main": "dist/lib.js",
   "types": "dist/lib.d.ts",