@heihei0299/matt-skills 1.3.0 → 1.3.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.agents/skills/ask-matt/PHASE-BOUNDARIES.md +55 -0
- package/.agents/skills/ask-matt/SKILL.md +37 -25
- package/.agents/skills/code-review/SKILL.md +28 -35
- package/.agents/skills/codebase-design/DEEPENING.md +4 -4
- package/.agents/skills/codebase-design/DESIGN-IT-TWICE.md +10 -10
- package/.agents/skills/codebase-design/SKILL.md +13 -13
- package/.agents/skills/diagnosing-bugs/SKILL.md +34 -30
- package/.agents/skills/diagnosing-bugs/scripts/hitl-loop.template.sh +3 -0
- package/.agents/skills/domain-modeling/ADR-FORMAT.md +11 -11
- package/.agents/skills/domain-modeling/CONTEXT-FORMAT.md +3 -3
- package/.agents/skills/domain-modeling/SKILL.md +10 -10
- package/.agents/skills/grill-me/SKILL.md +1 -1
- package/.agents/skills/grill-with-docs/SKILL.md +1 -1
- package/.agents/skills/grilling/SKILL.md +20 -4
- package/.agents/skills/grilling/agents/openai.yaml +1 -1
- package/.agents/skills/handoff/SKILL.md +1 -1
- package/.agents/skills/improve-codebase-architecture/HTML-REPORT.md +19 -19
- package/.agents/skills/improve-codebase-architecture/SKILL.md +21 -21
- package/.agents/skills/prototype/LOGIC.md +30 -42
- package/.agents/skills/prototype/SKILL.md +7 -7
- package/.agents/skills/prototype/UI.md +23 -23
- package/.agents/skills/research/SKILL.md +1 -1
- package/.agents/skills/resolving-merge-conflicts/SKILL.md +1 -1
- package/.agents/skills/setup-matt-pocock-skills/SKILL.md +30 -30
- package/.agents/skills/setup-matt-pocock-skills/domain.md +4 -4
- package/.agents/skills/setup-matt-pocock-skills/issue-tracker-github.md +5 -5
- package/.agents/skills/setup-matt-pocock-skills/issue-tracker-gitlab.md +6 -6
- package/.agents/skills/setup-matt-pocock-skills/issue-tracker-local.md +3 -3
- package/.agents/skills/tdd/SKILL.md +9 -7
- package/.agents/skills/teach/GLOSSARY-FORMAT.md +3 -3
- package/.agents/skills/teach/LEARNING-RECORD-FORMAT.md +10 -10
- package/.agents/skills/teach/MISSION-FORMAT.md +4 -4
- package/.agents/skills/teach/RESOURCES-FORMAT.md +2 -2
- package/.agents/skills/teach/SKILL.md +4 -4
- package/.agents/skills/to-questionnaire/SKILL.md +54 -0
- package/.agents/skills/to-questionnaire/agents/openai.yaml +5 -0
- package/.agents/skills/to-spec/SKILL.md +4 -4
- package/.agents/skills/to-tickets/SKILL.md +16 -16
- package/.agents/skills/triage/AGENT-BRIEF.md +9 -9
- package/.agents/skills/triage/OUT-OF-SCOPE.md +15 -15
- package/.agents/skills/triage/SKILL.md +29 -29
- package/.agents/skills/wait-what/SKILL.md +7 -0
- package/.agents/skills/wait-what/agents/openai.yaml +5 -0
- package/.agents/skills/wayfinder/SKILL.md +37 -37
- package/.agents/skills/wizard/SKILL.md +44 -0
- package/.agents/skills/wizard/agents/openai.yaml +3 -0
- package/.agents/skills/wizard/template.sh +204 -0
- package/.agents/skills/writing-for-agents/SKILL-MECHANICS.md +22 -0
- package/.agents/skills/writing-for-agents/SKILL.md +81 -0
- package/.agents/skills/writing-for-agents/agents/openai.yaml +3 -0
- package/README.md +20 -16
- package/bin/cli.js +90 -58
- package/package.json +1 -1
- package/template/.opencode/CONTEXT.md +4 -0
- package/template/.opencode/commands/{writing-great-skills.md → writing-for-agents.md} +1 -1
- package/template/.opencode/docs/agents/skill-design.md +3 -3
- package/template/.pi/CONTEXT.md +55 -0
- package/template/.pi/docs/agents/runtime-discipline.md +3 -2
- package/template/.pi/docs/agents/skill-design.md +10 -5
- package/template/AGENTS.md +2 -2
- package/.agents/skills/writing-great-skills/GLOSSARY.md +0 -201
- package/.agents/skills/writing-great-skills/SKILL.md +0 -83
- package/.agents/skills/writing-great-skills/agents/openai.yaml +0 -5
|
@@ -0,0 +1,54 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: to-questionnaire
|
|
3
|
+
description: Turn a decision you can't fully answer into a questionnaire for someone else to fill in.
|
|
4
|
+
disable-model-invocation: true
|
|
5
|
+
---
|
|
6
|
+
|
|
7
|
+
Turn something the user can't answer alone into a **questionnaire**: a Markdown document they hand to one person to fill in async, or fill out together over a meeting. The recipient holds knowledge the user lacks; the questionnaire pulls it out of them.
|
|
8
|
+
|
|
9
|
+
**Grill the send, not the subject.** Interview the user only about the _send_, which they can always answer: who it goes to, and what they need back. The questions in the document then target the **gap** between what the recipient knows and what the user needs.
|
|
10
|
+
|
|
11
|
+
|
|
12
|
+
1. **Who is it going to?** Ask, in one exchange, the recipient's role, expertise, and relationship to the user. This fixes the questionnaire's tone and how much context it must carry. Done when you know who the recipient is and what they know that the user doesn't.
|
|
13
|
+
|
|
14
|
+
2. **What do you need back?** Ask, in one exchange, the specific decisions or facts the user can't resolve alone and needs from this person. Done when you have a concrete list of what the user must walk away able to do or decide.
|
|
15
|
+
|
|
16
|
+
3. **Write the questionnaire.** Draft questions aimed at the gap from steps 1–2, following the Document structure below. Write it to `to-questionnaire-<slug>.md` in the current directory (slug from the topic) and report the path. Done when the file exists and every item the user named in step 2 is covered by a question.
|
|
17
|
+
|
|
18
|
+
## Document structure
|
|
19
|
+
|
|
20
|
+
Frame the document as a **discovery questionnaire**: the user lacks context, the recipient holds it. Order questions most-important-first, since async means you may only get one pass, and group them under `##` headings by theme once there are more than a handful. Write it using the template below.
|
|
21
|
+
|
|
22
|
+
<questionnaire-template>
|
|
23
|
+
|
|
24
|
+
# <Questionnaire title>
|
|
25
|
+
|
|
26
|
+
**Purpose:** why this questionnaire exists and the decision riding on it.
|
|
27
|
+
|
|
28
|
+
**From:** <the user>, **To:** <the recipient>, **How your answers will be used:** <where they go>
|
|
29
|
+
|
|
30
|
+
## Context
|
|
31
|
+
|
|
32
|
+
One paragraph orienting a recipient who wasn't in the user's head. Enough to answer well, not a page.
|
|
33
|
+
|
|
34
|
+
## How to answer
|
|
35
|
+
|
|
36
|
+
Deadline and rough effort. Partial answers and "I don't know" are useful: flag anything you're unsure of rather than skipping it.
|
|
37
|
+
|
|
38
|
+
## <Theme heading>
|
|
39
|
+
|
|
40
|
+
One `##` section per theme. Under each, its questions, most-important-first. Every question is one idea, never compound, with an answer stub directly beneath, and a one-line _why this matters_ only where the question could be misread or invite a throwaway answer.
|
|
41
|
+
|
|
42
|
+
<question-example>
|
|
43
|
+
### What load is the system expected to handle at launch?
|
|
44
|
+
|
|
45
|
+
_Why this matters: it decides whether we provision for burst traffic now or defer it._
|
|
46
|
+
|
|
47
|
+
>
|
|
48
|
+
</question-example>
|
|
49
|
+
|
|
50
|
+
## Anything else?
|
|
51
|
+
|
|
52
|
+
A closing catch-all: anything we didn't ask that we should know?
|
|
53
|
+
|
|
54
|
+
</questionnaire-template>
|
|
@@ -1,12 +1,12 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: to-spec
|
|
3
|
-
description: Turn the current conversation into a spec and publish it to the project issue tracker
|
|
3
|
+
description: "Turn the current conversation into a spec and publish it to the project issue tracker: no interview, just synthesis of what you've already discussed."
|
|
4
4
|
disable-model-invocation: true
|
|
5
5
|
---
|
|
6
6
|
|
|
7
|
-
This skill takes the current conversation context and codebase understanding and produces a spec
|
|
7
|
+
This skill takes the current conversation context and codebase understanding and produces a spec. Do NOT interview the user; just synthesize what you already know.
|
|
8
8
|
|
|
9
|
-
The issue tracker and triage label vocabulary should have been provided to you
|
|
9
|
+
The issue tracker and triage label vocabulary should have been provided to you. If not, tell the user to run `/setup-matt-pocock-skills`.
|
|
10
10
|
|
|
11
11
|
## Process
|
|
12
12
|
|
|
@@ -54,7 +54,7 @@ A list of implementation decisions that were made. This can include:
|
|
|
54
54
|
|
|
55
55
|
Do NOT include specific file paths or code snippets. They may end up being outdated very quickly.
|
|
56
56
|
|
|
57
|
-
Exception: if a prototype produced a snippet that encodes a decision more precisely than prose can (state machine, reducer, schema, type shape), inline it within the relevant decision and note briefly that it came from a prototype. Trim to the decision-rich parts
|
|
57
|
+
Exception: if a prototype produced a snippet that encodes a decision more precisely than prose can (state machine, reducer, schema, type shape), inline it within the relevant decision and note briefly that it came from a prototype. Trim to the decision-rich parts, not a working demo, just the important bits.
|
|
58
58
|
|
|
59
59
|
## Testing Decisions
|
|
60
60
|
|
|
@@ -1,14 +1,14 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: to-tickets
|
|
3
|
-
description: Break a plan, spec, or the current conversation into a set of tracer-bullet tickets, each declaring its blocking edges, published to the configured tracker
|
|
3
|
+
description: Break a plan, spec, or the current conversation into a set of tracer-bullet tickets, each declaring its blocking edges, published to the configured tracker (edges as text in one file per ticket locally, or native blocking links on a real tracker).
|
|
4
4
|
disable-model-invocation: true
|
|
5
5
|
---
|
|
6
6
|
|
|
7
7
|
# To Tickets
|
|
8
8
|
|
|
9
|
-
Break a plan, spec, or conversation into a set of **tickets
|
|
9
|
+
Break a plan, spec, or conversation into a set of **tickets**: tracer-bullet vertical slices, each declaring the tickets that **block** it.
|
|
10
10
|
|
|
11
|
-
The issue tracker and triage label vocabulary should have been provided to you
|
|
11
|
+
The issue tracker and triage label vocabulary should have been provided to you. If not, tell the user to run `/setup-matt-pocock-skills`.
|
|
12
12
|
|
|
13
13
|
## Process
|
|
14
14
|
|
|
@@ -28,16 +28,16 @@ Break the work into **tracer bullet** tickets.
|
|
|
28
28
|
|
|
29
29
|
<vertical-slice-rules>
|
|
30
30
|
|
|
31
|
-
- Each slice cuts a narrow but COMPLETE path through every layer (schema, API, UI, tests)
|
|
31
|
+
- Each slice cuts a narrow but COMPLETE path through every layer (schema, API, UI, tests): vertical, NOT a horizontal slice of one layer
|
|
32
32
|
- A completed slice is demoable or verifiable on its own
|
|
33
33
|
- Each slice is sized to fit in a single fresh context window
|
|
34
34
|
- Any prefactoring should be done first
|
|
35
35
|
|
|
36
36
|
</vertical-slice-rules>
|
|
37
37
|
|
|
38
|
-
Give each ticket its **blocking edges
|
|
38
|
+
Give each ticket its **blocking edges**: the other tickets that must complete before it can start. A ticket with no blockers can start immediately.
|
|
39
39
|
|
|
40
|
-
**Wide refactors are the exception to vertical slicing.** A **wide refactor** is one mechanical change
|
|
40
|
+
**Wide refactors are the exception to vertical slicing.** A **wide refactor** is one mechanical change (rename a column, retype a shared symbol) whose **blast radius** fans across the whole codebase, so a single edit breaks thousands of call sites at once and no vertical slice can land green. Don't force it into a tracer bullet; sequence it as **expand–contract**. First expand: add the new form beside the old so nothing breaks. Then migrate the call sites over in batches sized by blast radius (per package, per directory), each batch its own ticket blocked by the expand, keeping CI green batch to batch because the old form still exists. Finally contract: delete the old form once no caller remains, in a ticket blocked by every migrate batch. When even the batches can't stay green alone, keep the sequence but let them share an integration branch that all block a final integrate-and-verify ticket; green is promised only there.
|
|
41
41
|
|
|
42
42
|
### 4. Quiz the user
|
|
43
43
|
|
|
@@ -50,17 +50,17 @@ Present the proposed breakdown as a numbered list. For each ticket, show:
|
|
|
50
50
|
Ask the user:
|
|
51
51
|
|
|
52
52
|
- Does the granularity feel right? (too coarse / too fine)
|
|
53
|
-
- Are the blocking edges correct
|
|
53
|
+
- Are the blocking edges correct: does each ticket only depend on tickets that genuinely gate it?
|
|
54
54
|
- Should any tickets be merged or split further?
|
|
55
55
|
|
|
56
56
|
Iterate until the user approves the breakdown.
|
|
57
57
|
|
|
58
58
|
### 5. Publish the tickets to the configured tracker
|
|
59
59
|
|
|
60
|
-
Publish the approved tickets. **How** depends on the tracker `/setup-matt-pocock-skills` configured
|
|
60
|
+
Publish the approved tickets. **How** depends on the tracker `/setup-matt-pocock-skills` configured; the tickets are the same either way, only the shape of the blocking edges changes:
|
|
61
61
|
|
|
62
|
-
- **Local files** → write one file per ticket under `.scratch/<feature-slug>/issues/<NN>-<slug>.md`, numbered from `01` in dependency order (blockers first). Each file's "Blocked by" lists the numbers/titles it depends on. Use the per-ticket file template below
|
|
63
|
-
- **A real issue tracker (GitHub, Linear, …)** → publish one issue per ticket in dependency order (blockers first) so each ticket's blocking edges can reference real identifiers. Use the platform's native blocking / sub-issue relationship where it has one; otherwise set each ticket's "Blocked by" to the blocking issues. Apply the `ready-for-agent` triage label unless instructed otherwise
|
|
62
|
+
- **Local files** → write one file per ticket under `.scratch/<feature-slug>/issues/<NN>-<slug>.md`, numbered from `01` in dependency order (blockers first). Each file's "Blocked by" lists the numbers/titles it depends on. Use the per-ticket file template below: one ticket per file, never a single combined file.
|
|
63
|
+
- **A real issue tracker (GitHub, Linear, …)** → publish one issue per ticket in dependency order (blockers first) so each ticket's blocking edges can reference real identifiers. Use the platform's native blocking / sub-issue relationship where it has one; otherwise set each ticket's "Blocked by" to the blocking issues. Apply the `ready-for-agent` triage label unless instructed otherwise; the tickets are agent-grabbable by construction.
|
|
64
64
|
|
|
65
65
|
Work the **frontier**: any ticket whose blockers are all done. For a purely linear chain that means top to bottom.
|
|
66
66
|
|
|
@@ -68,11 +68,11 @@ Do NOT close or modify any parent issue.
|
|
|
68
68
|
|
|
69
69
|
<local-ticket-template>
|
|
70
70
|
|
|
71
|
-
# <NN
|
|
71
|
+
# <NN>: <Ticket title>
|
|
72
72
|
|
|
73
|
-
**What to build:** the end-to-end behaviour this ticket makes work, from the user's perspective
|
|
73
|
+
**What to build:** the end-to-end behaviour this ticket makes work, from the user's perspective, not a layer-by-layer implementation list.
|
|
74
74
|
|
|
75
|
-
**Blocked by:** the numbers/titles of the tickets that gate this one, or "None
|
|
75
|
+
**Blocked by:** the numbers/titles of the tickets that gate this one, or "None (can start immediately)".
|
|
76
76
|
|
|
77
77
|
**Status:** ready-for-agent
|
|
78
78
|
|
|
@@ -89,7 +89,7 @@ A reference to the parent issue on the tracker (if the source was an existing is
|
|
|
89
89
|
|
|
90
90
|
## What to build
|
|
91
91
|
|
|
92
|
-
The end-to-end behaviour this ticket makes work, from the user's perspective
|
|
92
|
+
The end-to-end behaviour this ticket makes work, from the user's perspective, not layer-by-layer implementation.
|
|
93
93
|
|
|
94
94
|
## Acceptance criteria
|
|
95
95
|
|
|
@@ -98,8 +98,8 @@ The end-to-end behaviour this ticket makes work, from the user's perspective —
|
|
|
98
98
|
|
|
99
99
|
## Blocked by
|
|
100
100
|
|
|
101
|
-
- A reference to each blocking ticket, or "None
|
|
101
|
+
- A reference to each blocking ticket, or "None (can start immediately)".
|
|
102
102
|
|
|
103
103
|
</issue-template>
|
|
104
104
|
|
|
105
|
-
In either form, avoid specific file paths or code snippets
|
|
105
|
+
In either form, avoid specific file paths or code snippets: they go stale fast. Exception: if a prototype produced a snippet that encodes a decision more precisely than prose can (state machine, reducer, schema, type shape), inline it and note briefly that it came from a prototype. Trim to the decision-rich parts, not a working demo, just the important bits.
|
|
@@ -1,8 +1,8 @@
|
|
|
1
1
|
# Writing Agent Briefs
|
|
2
2
|
|
|
3
|
-
An agent brief is a structured comment posted on a GitHub issue or PR when it moves to `ready-for-agent`. It is the authoritative specification that an AFK agent will work from. The original body and discussion are context
|
|
3
|
+
An agent brief is a structured comment posted on a GitHub issue or PR when it moves to `ready-for-agent`. It is the authoritative specification that an AFK agent will work from. The original body and discussion are context: the agent brief is the contract.
|
|
4
4
|
|
|
5
|
-
The brief states **what the agent should do**, which stretches to both surfaces: for an issue, that's building the change from nothing; for a PR, it's what's left to do *to the existing diff
|
|
5
|
+
The brief states **what the agent should do**, which stretches to both surfaces: for an issue, that's building the change from nothing; for a PR, it's what's left to do *to the existing diff*: finish it, close gaps, address review points. Same principles either way; the PR example below shows the difference.
|
|
6
6
|
|
|
7
7
|
## Principles
|
|
8
8
|
|
|
@@ -12,7 +12,7 @@ The issue may sit in `ready-for-agent` for days or weeks. The codebase will chan
|
|
|
12
12
|
|
|
13
13
|
- **Do** describe interfaces, types, and behavioral contracts
|
|
14
14
|
- **Do** name specific types, function signatures, or config shapes that the agent should look for or modify
|
|
15
|
-
- **Don't** reference file paths
|
|
15
|
+
- **Don't** reference file paths: they go stale
|
|
16
16
|
- **Don't** reference line numbers
|
|
17
17
|
- **Don't** assume the current implementation structure will remain the same
|
|
18
18
|
|
|
@@ -53,9 +53,9 @@ Describe what should happen after the agent's work is complete.
|
|
|
53
53
|
Be specific about edge cases and error conditions.
|
|
54
54
|
|
|
55
55
|
**Key interfaces:**
|
|
56
|
-
- `TypeName
|
|
57
|
-
- `functionName()` return type
|
|
58
|
-
- Config shape
|
|
56
|
+
- `TypeName`: what needs to change and why
|
|
57
|
+
- `functionName()` return type: what it currently returns vs what it should return
|
|
58
|
+
- Config shape: any new configuration options needed
|
|
59
59
|
|
|
60
60
|
**Acceptance criteria:**
|
|
61
61
|
- [ ] Specific, testable criterion 1
|
|
@@ -87,7 +87,7 @@ Truncation should break at the last word boundary before 1024 characters
|
|
|
87
87
|
and append "..." to indicate truncation.
|
|
88
88
|
|
|
89
89
|
**Key interfaces:**
|
|
90
|
-
- The `SkillMetadata` type's `description` field
|
|
90
|
+
- The `SkillMetadata` type's `description` field: no type change needed,
|
|
91
91
|
but the validation/processing logic that populates it needs to respect
|
|
92
92
|
word boundaries
|
|
93
93
|
- Any function that reads SKILL.md frontmatter and extracts the description
|
|
@@ -125,7 +125,7 @@ requested the feature. When triaging new issues, these files should be
|
|
|
125
125
|
checked for matches.
|
|
126
126
|
|
|
127
127
|
**Key interfaces:**
|
|
128
|
-
- Markdown file format in `.out-of-scope
|
|
128
|
+
- Markdown file format in `.out-of-scope/`: each file should have a
|
|
129
129
|
`# Concept Name` heading, a `**Decision:**` line, a `**Reason:**` line,
|
|
130
130
|
and a `**Prior requests:**` list with issue links
|
|
131
131
|
- The triage workflow should read all `.out-of-scope/*.md` files early
|
|
@@ -162,7 +162,7 @@ remain: errors are still printed as human text (not JSON), and the new flag has
|
|
|
162
162
|
no test coverage.
|
|
163
163
|
|
|
164
164
|
**Desired behavior:**
|
|
165
|
-
With `--json`, all output
|
|
165
|
+
With `--json`, all output (including errors) is well-formed JSON on stdout,
|
|
166
166
|
and the command's exit codes are unchanged. The existing human-readable output
|
|
167
167
|
is untouched when the flag is absent.
|
|
168
168
|
|
|
@@ -2,8 +2,8 @@
|
|
|
2
2
|
|
|
3
3
|
The `.out-of-scope/` directory in a repo stores persistent records of rejected feature requests. It serves two purposes:
|
|
4
4
|
|
|
5
|
-
1. **Institutional memory
|
|
6
|
-
2. **Deduplication
|
|
5
|
+
1. **Institutional memory**: why a feature was rejected, so the reasoning isn't lost when the issue is closed
|
|
6
|
+
2. **Deduplication**: when a new issue comes in that matches a prior rejection, the skill can surface the previous decision instead of re-litigating it
|
|
7
7
|
|
|
8
8
|
## Directory structure
|
|
9
9
|
|
|
@@ -18,7 +18,7 @@ One file per **concept**, not per issue. Multiple issues requesting the same thi
|
|
|
18
18
|
|
|
19
19
|
## File format
|
|
20
20
|
|
|
21
|
-
The file should be written in a relaxed, readable style
|
|
21
|
+
The file should be written in a relaxed, readable style, more like a short design document than a database entry. Use paragraphs, code samples, and examples to make the reasoning clear and useful to someone encountering it for the first time.
|
|
22
22
|
|
|
23
23
|
```markdown
|
|
24
24
|
# Dark Mode
|
|
@@ -48,9 +48,9 @@ interface ThemeConfig {
|
|
|
48
48
|
|
|
49
49
|
## Prior requests
|
|
50
50
|
|
|
51
|
-
- #42
|
|
52
|
-
- #87
|
|
53
|
-
- #134
|
|
51
|
+
- #42: "Add dark mode support"
|
|
52
|
+
- #87: "Night theme for accessibility"
|
|
53
|
+
- #134: "Dark theme option"
|
|
54
54
|
```
|
|
55
55
|
|
|
56
56
|
### Naming the file
|
|
@@ -59,31 +59,31 @@ Use a short, descriptive kebab-case name for the concept: `dark-mode.md`, `plugi
|
|
|
59
59
|
|
|
60
60
|
### Writing the reason
|
|
61
61
|
|
|
62
|
-
The reason should be substantive
|
|
62
|
+
The reason should be substantive: not "we don't want this" but why. Good reasons reference:
|
|
63
63
|
|
|
64
64
|
- Project scope or philosophy ("This project focuses on X; theming is a downstream concern")
|
|
65
65
|
- Technical constraints ("Supporting this would require Y, which conflicts with our Z architecture")
|
|
66
66
|
- Strategic decisions ("We chose to use A instead of B because...")
|
|
67
67
|
|
|
68
|
-
The reason should be durable. Avoid referencing temporary circumstances ("we're too busy right now")
|
|
68
|
+
The reason should be durable. Avoid referencing temporary circumstances ("we're too busy right now"); those aren't real rejections, they're deferrals.
|
|
69
69
|
|
|
70
70
|
## When to check `.out-of-scope/`
|
|
71
71
|
|
|
72
72
|
During triage (Step 1: Gather context), read all files in `.out-of-scope/`. When evaluating a new issue:
|
|
73
73
|
|
|
74
74
|
- Check if the request matches an existing out-of-scope concept
|
|
75
|
-
- Matching is by concept similarity, not keyword
|
|
76
|
-
- If there's a match, surface it to the maintainer: "This is similar to `.out-of-scope/dark-mode.md
|
|
75
|
+
- Matching is by concept similarity, not keyword: "night theme" matches `dark-mode.md`
|
|
76
|
+
- If there's a match, surface it to the maintainer: "This is similar to `.out-of-scope/dark-mode.md`. We rejected this before because [reason]. Do you still feel the same way?"
|
|
77
77
|
|
|
78
78
|
The maintainer may:
|
|
79
79
|
|
|
80
|
-
- **Confirm
|
|
81
|
-
- **Reconsider
|
|
82
|
-
- **Disagree
|
|
80
|
+
- **Confirm**: the new issue gets added to the existing file's "Prior requests" list, then closed
|
|
81
|
+
- **Reconsider**: the out-of-scope file gets deleted or updated, and the issue proceeds through normal triage
|
|
82
|
+
- **Disagree**: the issues are related but distinct, proceed with normal triage
|
|
83
83
|
|
|
84
84
|
## When to write to `.out-of-scope/`
|
|
85
85
|
|
|
86
|
-
Only when an **enhancement** (not a bug) is *rejected* as `wontfix`. This applies to enhancement PRs exactly as it does to issues
|
|
86
|
+
Only when an **enhancement** (not a bug) is *rejected* as `wontfix`. This applies to enhancement PRs exactly as it does to issues: a rejected PR is recorded here so the same request doesn't return as fresh code.
|
|
87
87
|
|
|
88
88
|
Do **not** write here when something is closed as `wontfix` because it's **already implemented**. That's a built feature, not a rejected one; recording it would poison the dedup checks with false rejections. Instead, the closing comment points to where the feature already lives.
|
|
89
89
|
|
|
@@ -101,5 +101,5 @@ The flow:
|
|
|
101
101
|
If the maintainer changes their mind about a previously rejected concept:
|
|
102
102
|
|
|
103
103
|
- Delete the `.out-of-scope/` file
|
|
104
|
-
- The skill does not need to reopen old issues
|
|
104
|
+
- The skill does not need to reopen old issues; they're historical records
|
|
105
105
|
- The new issue that triggered the reconsideration proceeds through normal triage
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: triage
|
|
3
|
-
description: Move issues and external PRs through a state machine of triage roles
|
|
3
|
+
description: Move issues and external PRs through a state machine of triage roles, categorise, verify, grill if needed, and write agent-ready briefs.
|
|
4
4
|
disable-model-invocation: true
|
|
5
5
|
---
|
|
6
6
|
|
|
@@ -8,7 +8,7 @@ disable-model-invocation: true
|
|
|
8
8
|
|
|
9
9
|
Move issues on the project issue tracker through a small state machine of triage roles.
|
|
10
10
|
|
|
11
|
-
If this repo treats external pull requests as a request surface (see the issue-tracker config), triage covers them too: **a PR is an issue with attached code
|
|
11
|
+
If this repo treats external pull requests as a request surface (see the issue-tracker config), triage covers them too: **a PR is an issue with attached code**, using the same roles, same states, and same machine, with a few deltas marked "for a PR" below. Resolve a bare `#42` to an issue or PR per the tracker config.
|
|
12
12
|
|
|
13
13
|
Every comment or issue posted to the issue tracker during triage **must** start with this disclaimer:
|
|
14
14
|
|
|
@@ -18,31 +18,31 @@ Every comment or issue posted to the issue tracker during triage **must** start
|
|
|
18
18
|
|
|
19
19
|
## Reference docs
|
|
20
20
|
|
|
21
|
-
- [AGENT-BRIEF.md](AGENT-BRIEF.md)
|
|
22
|
-
- [OUT-OF-SCOPE.md](OUT-OF-SCOPE.md)
|
|
21
|
+
- [AGENT-BRIEF.md](AGENT-BRIEF.md): how to write durable agent briefs
|
|
22
|
+
- [OUT-OF-SCOPE.md](OUT-OF-SCOPE.md): how the `.out-of-scope/` knowledge base works
|
|
23
23
|
|
|
24
24
|
## Roles
|
|
25
25
|
|
|
26
26
|
Two **category** roles:
|
|
27
27
|
|
|
28
|
-
- `bug
|
|
29
|
-
- `enhancement
|
|
28
|
+
- `bug`: something is broken
|
|
29
|
+
- `enhancement`: new feature or improvement
|
|
30
30
|
|
|
31
31
|
Five **state** roles:
|
|
32
32
|
|
|
33
|
-
- `needs-triage
|
|
34
|
-
- `needs-info
|
|
35
|
-
- `ready-for-agent
|
|
36
|
-
- `ready-for-human
|
|
37
|
-
- `wontfix
|
|
33
|
+
- `needs-triage`: maintainer needs to evaluate
|
|
34
|
+
- `needs-info`: waiting on reporter for more information
|
|
35
|
+
- `ready-for-agent`: fully specified, ready for an AFK agent
|
|
36
|
+
- `ready-for-human`: needs human implementation
|
|
37
|
+
- `wontfix`: will not be actioned
|
|
38
38
|
|
|
39
39
|
For a PR, the same states read against the attached code: `ready-for-agent` means a brief is attached and an agent should take the next step on the diff; `ready-for-human` means it's ready for a human to merge.
|
|
40
40
|
|
|
41
41
|
Every triaged issue should carry exactly one category role and one state role. If state roles conflict, flag it and ask the maintainer before doing anything else.
|
|
42
42
|
|
|
43
|
-
These are canonical role names
|
|
43
|
+
These are canonical role names. The actual label strings used in the issue tracker may differ. The mapping should have been provided to you. If not, tell the user to run `/setup-matt-pocock-skills`.
|
|
44
44
|
|
|
45
|
-
State transitions: an unlabeled issue normally goes to `needs-triage` first; from there it moves to `needs-info`, `ready-for-agent`, `ready-for-human`, or `wontfix`. `needs-info` returns to `needs-triage` once the reporter replies. The maintainer can override at any time
|
|
45
|
+
State transitions: an unlabeled issue normally goes to `needs-triage` first; from there it moves to `needs-info`, `ready-for-agent`, `ready-for-human`, or `wontfix`. `needs-info` returns to `needs-triage` once the reporter replies. The maintainer can override at any time; flag transitions that look unusual and ask before proceeding.
|
|
46
46
|
|
|
47
47
|
## Invocation
|
|
48
48
|
|
|
@@ -57,33 +57,33 @@ The maintainer invokes `/triage` and describes what they want in natural languag
|
|
|
57
57
|
|
|
58
58
|
Query the issue tracker and present three buckets, oldest first:
|
|
59
59
|
|
|
60
|
-
1. **Unlabeled
|
|
61
|
-
2. **`needs-triage
|
|
62
|
-
3. **`needs-info` with reporter activity since the last triage notes
|
|
60
|
+
1. **Unlabeled**: never triaged.
|
|
61
|
+
2. **`needs-triage`**: evaluation in progress.
|
|
62
|
+
3. **`needs-info` with reporter activity since the last triage notes**: needs re-evaluation.
|
|
63
63
|
|
|
64
|
-
When PRs are in scope, include external PRs in these buckets and tag each line `[PR]` or `[issue]`. Discovery surfaces only *external* PRs (the tracker config defines who counts as external)
|
|
64
|
+
When PRs are in scope, include external PRs in these buckets and tag each line `[PR]` or `[issue]`. Discovery surfaces only *external* PRs (the tracker config defines who counts as external), so a collaborator's in-flight PR is not triage work. This filter is discovery-only; an explicitly named PR is always triaged regardless of author.
|
|
65
65
|
|
|
66
66
|
Show counts and a one-line summary per item. Let the maintainer pick.
|
|
67
67
|
|
|
68
68
|
## Triage a specific issue or PR
|
|
69
69
|
|
|
70
|
-
1. **Gather context.** Read the full issue or PR (body, comments, labels, author, dates; for a PR, the diff too). Parse any prior triage notes so you don't re-ask resolved questions. Explore the codebase using the project's domain glossary, respecting ADRs in the area. Run two checks against the codebase: (a) **redundancy
|
|
70
|
+
1. **Gather context.** Read the full issue or PR (body, comments, labels, author, dates; for a PR, the diff too). Parse any prior triage notes so you don't re-ask resolved questions. Explore the codebase using the project's domain glossary, respecting ADRs in the area. Run two checks against the codebase: (a) **redundancy**: search for an existing implementation of the requested behavior by domain concept (not just the request's wording), and report where you looked. If found, it's an already-implemented `wontfix` (step 5). (b) **prior rejection**: read `.out-of-scope/*.md` and surface any that resembles this request.
|
|
71
71
|
|
|
72
|
-
2. **Recommend.** Tell the maintainer your category and state recommendation with reasoning, plus a brief codebase summary relevant to the request
|
|
72
|
+
2. **Recommend.** Tell the maintainer your category and state recommendation with reasoning, plus a brief codebase summary relevant to the request (including whether it's already implemented). Wait for direction.
|
|
73
73
|
|
|
74
|
-
3. **Verify the claim.** Before any grilling, check that the claim holds up. For a bug, reproduce it from the reporter's steps. For a PR, confirm the diff does what it claims
|
|
74
|
+
3. **Verify the claim.** Before any grilling, check that the claim holds up. For a bug, reproduce it from the reporter's steps. For a PR, confirm the diff does what it claims: check it out, run the relevant tests or commands. Report what happened: confirmed (with code path), failed, or insufficient detail (a strong `needs-info` signal). A confirmed verification makes a much stronger agent brief.
|
|
75
75
|
|
|
76
|
-
4. **Grill (if needed).** If the request needs fleshing out,
|
|
76
|
+
4. **Grill (if needed).** If the request needs fleshing out, call the Skill tool twice, for "grilling" and "domain-modeling", and grill it into shape a round of questions at a time, sharpening domain terms and updating `CONTEXT.md`/ADRs inline as decisions land.
|
|
77
77
|
|
|
78
78
|
5. **Apply the outcome:**
|
|
79
|
-
- `ready-for-agent
|
|
80
|
-
- `ready-for-human
|
|
81
|
-
- `needs-info
|
|
82
|
-
- `wontfix
|
|
83
|
-
- **Already implemented
|
|
84
|
-
- **Rejected (bug)
|
|
85
|
-
- **Rejected (enhancement)
|
|
86
|
-
- `needs-triage
|
|
79
|
+
- `ready-for-agent`: post an agent brief comment ([AGENT-BRIEF.md](AGENT-BRIEF.md)).
|
|
80
|
+
- `ready-for-human`: same structure as an agent brief, but note why it can't be delegated (judgment calls, external access, design decisions, manual testing).
|
|
81
|
+
- `needs-info`: post triage notes (template below).
|
|
82
|
+
- For `wontfix`, close the issue, with the comment depending on *why*:
|
|
83
|
+
- **Already implemented**: the change already exists in the codebase. Point to where it lives; do **not** write to `.out-of-scope/` (that KB is for *rejected* requests, not built ones).
|
|
84
|
+
- **Rejected (bug)**: give a polite explanation, then close.
|
|
85
|
+
- **Rejected (enhancement)**: write to `.out-of-scope/`, link to it from a comment, then close ([OUT-OF-SCOPE.md](OUT-OF-SCOPE.md)).
|
|
86
|
+
- `needs-triage`: apply the role. Optional comment if there's partial progress.
|
|
87
87
|
|
|
88
88
|
## Quick state override
|
|
89
89
|
|
|
@@ -0,0 +1,7 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: wait-what
|
|
3
|
+
description: "Stop. That last message did not land: re-pitch it."
|
|
4
|
+
disable-model-invocation: true
|
|
5
|
+
---
|
|
6
|
+
|
|
7
|
+
Wait, I don't understand where you've got to here. Re-pitch that: give me a little bit of context, talk in ASD-STE100 Simplified Technical English, and use the ubiquitous language from `CONTEXT.md` (follow `CONTEXT-MAP.md` to the right one if the repo has more than one).
|