@heidi-dang/oh-my-opencode 3.13.0 → 3.13.1

package/dist/cli/index.js

@@ -7096,11 +7096,14 @@ var init_session_category_registry = __esm(() => {
 });
 
 // src/shared/verify-task-completion.ts
-async function verifyTaskCompletionState(client, sessionID) {
+async function verifyTaskCompletionState(client, sessionID, options) {
   try {
     const response = await client.session.messages({
       path: { id: sessionID }
     });
+    if (response === null || response === undefined) {
+      throw new Error("SDK returned null or undefined session messages");
+    }
     const messages = normalizeSDKResponse(response, [], { preferResponseOnMissingData: true });
     let lastCompleteTaskIndex = -1;
     let lastCompleteTaskPart = null;
@@ -7156,10 +7159,14 @@ async function verifyTaskCompletionState(client, sessionID) {
         return false;
       }
     }
+    if (options?.requireCompleteTask && lastCompleteTaskIndex === -1) {
+      log("[verifyTaskCompletionState] complete_task was required but not found, fail-closed:", sessionID);
+      return false;
+    }
     return true;
   } catch (error) {
-    log("[verifyTaskCompletionState] Error verifying task completion state, defaulting to true:", error);
-    return true;
+    log("[verifyTaskCompletionState] Error verifying task completion state, fail-closed:", error);
+    return false;
   }
 }
 var init_verify_task_completion = __esm(() => {
@@ -8924,7 +8931,7 @@ var {
 // package.json
 var package_default = {
   name: "@heidi-dang/oh-my-opencode",
-  version: "3.13.0",
+  version: "3.13.1",
   description: "The Best AI Agent Harness - Batteries-Included OpenCode Plugin with Multi-Model Orchestration, Parallel Background Agents, and Crafted LSP/AST Tools",
   main: "dist/index.js",
   types: "dist/index.d.ts",
@@ -9000,17 +9007,17 @@ var package_default = {
     typescript: "^5.7.3"
   },
   optionalDependencies: {
-    "@heidi-dang/oh-my-opencode-darwin-arm64": "3.12.5",
-    "@heidi-dang/oh-my-opencode-darwin-x64": "3.12.5",
-    "@heidi-dang/oh-my-opencode-darwin-x64-baseline": "3.12.5",
-    "@heidi-dang/oh-my-opencode-linux-arm64": "3.12.5",
-    "@heidi-dang/oh-my-opencode-linux-arm64-musl": "3.12.5",
-    "@heidi-dang/oh-my-opencode-linux-x64": "3.12.5",
-    "@heidi-dang/oh-my-opencode-linux-x64-baseline": "3.12.5",
-    "@heidi-dang/oh-my-opencode-linux-x64-musl": "3.12.5",
-    "@heidi-dang/oh-my-opencode-linux-x64-musl-baseline": "3.12.5",
-    "@heidi-dang/oh-my-opencode-windows-x64": "3.12.5",
-    "@heidi-dang/oh-my-opencode-windows-x64-baseline": "3.12.5"
+    "@heidi-dang/oh-my-opencode-darwin-arm64": "3.13.1",
+    "@heidi-dang/oh-my-opencode-darwin-x64": "3.13.1",
+    "@heidi-dang/oh-my-opencode-darwin-x64-baseline": "3.13.1",
+    "@heidi-dang/oh-my-opencode-linux-arm64": "3.13.1",
+    "@heidi-dang/oh-my-opencode-linux-arm64-musl": "3.13.1",
+    "@heidi-dang/oh-my-opencode-linux-x64": "3.13.1",
+    "@heidi-dang/oh-my-opencode-linux-x64-baseline": "3.13.1",
+    "@heidi-dang/oh-my-opencode-linux-x64-musl": "3.13.1",
+    "@heidi-dang/oh-my-opencode-linux-x64-musl-baseline": "3.13.1",
+    "@heidi-dang/oh-my-opencode-windows-x64": "3.13.1",
+    "@heidi-dang/oh-my-opencode-windows-x64-baseline": "3.13.1"
   },
   overrides: {
     "@opencode-ai/sdk": "^1.2.17",

package/dist/index.js

@@ -19945,11 +19945,14 @@ var SessionCategoryRegistry = {
 };
 // src/shared/verify-task-completion.ts
 init_logger();
-async function verifyTaskCompletionState(client, sessionID) {
+async function verifyTaskCompletionState(client, sessionID, options) {
   try {
     const response = await client.session.messages({
       path: { id: sessionID }
     });
+    if (response === null || response === undefined) {
+      throw new Error("SDK returned null or undefined session messages");
+    }
     const messages = normalizeSDKResponse(response, [], { preferResponseOnMissingData: true });
     let lastCompleteTaskIndex = -1;
     let lastCompleteTaskPart = null;
@@ -20005,10 +20008,14 @@ async function verifyTaskCompletionState(client, sessionID) {
         return false;
       }
     }
+    if (options?.requireCompleteTask && lastCompleteTaskIndex === -1) {
+      log("[verifyTaskCompletionState] complete_task was required but not found, fail-closed:", sessionID);
+      return false;
+    }
     return true;
   } catch (error) {
-    log("[verifyTaskCompletionState] Error verifying task completion state, defaulting to true:", error);
-    return true;
+    log("[verifyTaskCompletionState] Error verifying task completion state, fail-closed:", error);
+    return false;
   }
 }
 // src/cli/config-manager/config-context.ts
@@ -59927,25 +59934,6 @@ Session ID: ${input.sessionID}`;
       log("[task] Poll complete - terminal finish detected", { sessionID: input.sessionID, pollCount });
       break;
     }
-    const lastAssistant = [...msgs].reverse().find((m) => m.info?.role === "assistant");
-    const hasAssistantText = msgs.some((m) => {
-      if (m.info?.role !== "assistant")
-        return false;
-      const parts = m.parts ?? [];
-      return parts.some((p) => {
-        if (p.type !== "text" && p.type !== "reasoning")
-          return false;
-        const text = (p.text ?? "").trim();
-        return text.length > 0;
-      });
-    });
-    if (!lastAssistant?.info?.finish && hasAssistantText) {
-      log("[task] Poll complete - assistant text detected (fallback)", {
-        sessionID: input.sessionID,
-        pollCount
-      });
-      break;
-    }
   }
   if (Date.now() - pollStart >= maxPollTimeMs) {
     timedOut = true;
@@ -60588,6 +60576,11 @@ async function executeSyncTask(args, ctx, executorCtx, parentContext, agentToUse
       if (pollError) {
         return pollError;
       }
+      const isLegitimatelyComplete = await verifyTaskCompletionState(client2, sessionID, { requireCompleteTask: true });
+      if (!isLegitimatelyComplete) {
+        const duration4 = formatDuration2(startTime);
+        return `Task verification failed after ${duration4}. The subagent session completed but could not verify successful completion. This may indicate the subagent did not call complete_task, or the task was rejected. Agent: ${agentToUse}${args.category ? ` (category: ${args.category})` : ""} Session ID: ${sessionID}`;
+      }
       const result = await deps.fetchSyncResult(client2, sessionID);
       if (!result.ok) {
         return result.error;

package/dist/shared/verify-task-completion.d.ts

@@ -1 +1,4 @@
-export declare function verifyTaskCompletionState(client: any, sessionID: string): Promise<boolean>;
+export declare function verifyTaskCompletionState(client: any, sessionID: string, options?: {
+    /** If true, requires complete_task to have been called. If false (default), allows completion when no complete_task found. */
+    requireCompleteTask?: boolean;
+}): Promise<boolean>;

package/dist/tools/delegate-task/sync-session-poller.d.ts

@@ -1,3 +1,17 @@
+/**
+ * Poll a sync session until completion or timeout.
+ *
+ * IMPORTANT: This function returns null ONLY when:
+ * 1. isSessionComplete() returns true (verified terminal finish), OR
+ * 2. Timeout is reached (timedOut = true)
+ *
+ * The fallback path "assistant text detected" was REMOVED because it cannot verify
+ * that complete_task was actually called and succeeded. Treating assistant text
+ * as completion is a security vulnerability - it allows bypass of the authoritative
+ * completion gate.
+ *
+ * @returns null if session completed (verified), error string if failed, timeout message if timed out
+ */
 import type { ToolContextWithMetadata, OpencodeClient } from "./types";
 import type { SessionMessage } from "./executor-types";
 export declare function isSessionComplete(messages: SessionMessage[]): boolean;

package/dist/tools/delegate-task/sync-task-completion-verification.test.d.ts

@@ -0,0 +1 @@
+export {};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@heidi-dang/oh-my-opencode",
-  "version": "3.13.0",
+  "version": "3.13.1",
   "description": "The Best AI Agent Harness - Batteries-Included OpenCode Plugin with Multi-Model Orchestration, Parallel Background Agents, and Crafted LSP/AST Tools",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -76,17 +76,17 @@
     "typescript": "^5.7.3"
   },
   "optionalDependencies": {
-    "@heidi-dang/oh-my-opencode-darwin-arm64": "3.12.5",
-    "@heidi-dang/oh-my-opencode-darwin-x64": "3.12.5",
-    "@heidi-dang/oh-my-opencode-darwin-x64-baseline": "3.12.5",
-    "@heidi-dang/oh-my-opencode-linux-arm64": "3.12.5",
-    "@heidi-dang/oh-my-opencode-linux-arm64-musl": "3.12.5",
-    "@heidi-dang/oh-my-opencode-linux-x64": "3.12.5",
-    "@heidi-dang/oh-my-opencode-linux-x64-baseline": "3.12.5",
-    "@heidi-dang/oh-my-opencode-linux-x64-musl": "3.12.5",
-    "@heidi-dang/oh-my-opencode-linux-x64-musl-baseline": "3.12.5",
-    "@heidi-dang/oh-my-opencode-windows-x64": "3.12.5",
-    "@heidi-dang/oh-my-opencode-windows-x64-baseline": "3.12.5"
+    "@heidi-dang/oh-my-opencode-darwin-arm64": "3.13.1",
+    "@heidi-dang/oh-my-opencode-darwin-x64": "3.13.1",
+    "@heidi-dang/oh-my-opencode-darwin-x64-baseline": "3.13.1",
+    "@heidi-dang/oh-my-opencode-linux-arm64": "3.13.1",
+    "@heidi-dang/oh-my-opencode-linux-arm64-musl": "3.13.1",
+    "@heidi-dang/oh-my-opencode-linux-x64": "3.13.1",
+    "@heidi-dang/oh-my-opencode-linux-x64-baseline": "3.13.1",
+    "@heidi-dang/oh-my-opencode-linux-x64-musl": "3.13.1",
+    "@heidi-dang/oh-my-opencode-linux-x64-musl-baseline": "3.13.1",
+    "@heidi-dang/oh-my-opencode-windows-x64": "3.13.1",
+    "@heidi-dang/oh-my-opencode-windows-x64-baseline": "3.13.1"
   },
   "overrides": {
     "@opencode-ai/sdk": "^1.2.17",