@hegemonart/get-design-done 1.28.0 → 1.28.5
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.claude-plugin/marketplace.json +2 -2
- package/.claude-plugin/plugin.json +1 -1
- package/CHANGELOG.md +78 -0
- package/SKILL.md +1 -1
- package/hooks/gdd-decision-injector.js +149 -3
- package/package.json +1 -1
- package/reference/adr-format.md +96 -0
- package/reference/apply-reflections-procedure.md +68 -0
- package/reference/architecture-vocabulary.md +102 -0
- package/reference/cache-policy.md +126 -0
- package/reference/compare-rubric.md +171 -0
- package/reference/connections-onboarding.md +417 -0
- package/reference/context-md-format.md +106 -0
- package/reference/darkmode-audit-procedure.md +258 -0
- package/reference/debug-feedback-loops.md +119 -0
- package/reference/design-procedure.md +304 -0
- package/reference/discover-procedure.md +204 -0
- package/reference/explore-procedure.md +267 -0
- package/reference/health-mcp-detection.md +44 -0
- package/reference/health-skill-length-report.md +69 -0
- package/reference/heuristics.md +84 -0
- package/reference/milestone-completeness-rubric.md +87 -0
- package/reference/peer-cli-protocol.md +161 -0
- package/reference/plan-procedure.md +278 -0
- package/reference/registry.json +169 -1
- package/reference/registry.schema.json +1 -1
- package/reference/router-rules.md +84 -0
- package/reference/scan-procedure.md +731 -0
- package/reference/shared-preamble.md +78 -6
- package/reference/skill-authoring-contract.md +128 -0
- package/reference/start-procedure.md +115 -0
- package/reference/style-doc-procedure.md +150 -0
- package/reference/threat-modeling.md +101 -0
- package/reference/verify-procedure.md +512 -0
- package/scripts/validate-skill-length.cjs +283 -0
- package/skills/add-backlog/SKILL.md +1 -0
- package/skills/analyze-dependencies/SKILL.md +33 -122
- package/skills/apply-reflections/SKILL.md +1 -40
- package/skills/audit/SKILL.md +3 -1
- package/skills/bandit-status/SKILL.md +31 -66
- package/skills/benchmark/SKILL.md +15 -55
- package/skills/brief/SKILL.md +12 -1
- package/skills/cache-manager/SKILL.md +3 -57
- package/skills/check-update/SKILL.md +38 -75
- package/skills/compare/SKILL.md +29 -269
- package/skills/complete-cycle/SKILL.md +1 -1
- package/skills/connections/SKILL.md +21 -427
- package/skills/continue/SKILL.md +1 -0
- package/skills/darkmode/SKILL.md +32 -287
- package/skills/debug/SKILL.md +11 -8
- package/skills/design/SKILL.md +27 -245
- package/skills/discover/SKILL.md +26 -133
- package/skills/discuss/SKILL.md +18 -2
- package/skills/explore/SKILL.md +40 -205
- package/skills/fast/SKILL.md +1 -0
- package/skills/figma-write/SKILL.md +2 -2
- package/skills/health/SKILL.md +11 -33
- package/skills/help/SKILL.md +1 -0
- package/skills/list-assumptions/SKILL.md +1 -0
- package/skills/map/SKILL.md +8 -31
- package/skills/new-cycle/SKILL.md +3 -1
- package/skills/next/SKILL.md +1 -0
- package/skills/note/SKILL.md +1 -0
- package/skills/optimize/SKILL.md +21 -44
- package/skills/pause/SKILL.md +1 -0
- package/skills/peer-cli-add/SKILL.md +26 -108
- package/skills/peer-cli-customize/SKILL.md +22 -42
- package/skills/peers/SKILL.md +33 -57
- package/skills/plan/SKILL.md +33 -220
- package/skills/plant-seed/SKILL.md +1 -0
- package/skills/pr-branch/SKILL.md +1 -0
- package/skills/progress/SKILL.md +1 -7
- package/skills/quality-gate/SKILL.md +34 -166
- package/skills/quick/SKILL.md +1 -0
- package/skills/reapply-patches/SKILL.md +1 -0
- package/skills/recall/SKILL.md +1 -0
- package/skills/resume/SKILL.md +1 -0
- package/skills/review-backlog/SKILL.md +1 -0
- package/skills/router/SKILL.md +3 -59
- package/skills/scan/SKILL.md +36 -675
- package/skills/settings/SKILL.md +1 -0
- package/skills/ship/SKILL.md +1 -0
- package/skills/sketch/SKILL.md +1 -1
- package/skills/sketch-wrap-up/SKILL.md +13 -54
- package/skills/spike/SKILL.md +1 -1
- package/skills/spike-wrap-up/SKILL.md +12 -46
- package/skills/start/SKILL.md +13 -112
- package/skills/stats/SKILL.md +1 -0
- package/skills/style/SKILL.md +18 -140
- package/skills/synthesize/SKILL.md +1 -0
- package/skills/timeline/SKILL.md +1 -0
- package/skills/todo/SKILL.md +1 -0
- package/skills/turn-closeout/SKILL.md +36 -56
- package/skills/undo/SKILL.md +1 -0
- package/skills/update/SKILL.md +1 -0
- package/skills/verify/SKILL.md +42 -457
- package/skills/warm-cache/SKILL.md +3 -35
- package/skills/zoom-out/SKILL.md +26 -0
|
@@ -0,0 +1,512 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: verify-procedure
|
|
3
|
+
type: meta-rules
|
|
4
|
+
version: 1.0.0
|
|
5
|
+
phase: 28.5
|
|
6
|
+
tags: [verify, procedure, extracted, pipeline-stage, gap-loop, must-have, quality-gate]
|
|
7
|
+
last_updated: 2026-05-18
|
|
8
|
+
---
|
|
9
|
+
|
|
10
|
+
Source: extracted from `skills/verify/SKILL.md` (Phase 28.5 rework — D-10 extract-then-link).
|
|
11
|
+
The skill's load-bearing workflow stays in `../skills/verify/SKILL.md`; this file holds the
|
|
12
|
+
detail the agent reaches for when executing a specific step (state integration, quality-gate
|
|
13
|
+
decision tree, agent spawn protocols, gap-response loop, must-have flipping).
|
|
14
|
+
|
|
15
|
+
# Verify Procedure
|
|
16
|
+
|
|
17
|
+
Detailed procedure for the get-design-done `verify` Stage 5 orchestrator. Companion to
|
|
18
|
+
`../skills/verify/SKILL.md`. Read this file when executing a specific verify step; the
|
|
19
|
+
SKILL.md keeps the load-bearing workflow + decision tree, this file holds the deep
|
|
20
|
+
methodology, agent prompts, and gap-loop semantics.
|
|
21
|
+
|
|
22
|
+
---
|
|
23
|
+
|
|
24
|
+
## State Integration
|
|
25
|
+
|
|
26
|
+
### Stage entry
|
|
27
|
+
|
|
28
|
+
1. `mcp__gdd_state__transition_stage` with `to: "verify"`.
|
|
29
|
+
2. `mcp__gdd_state__get` → snapshot `state`. Read `state.must_haves` — this is the verification checklist; each M-XX starts at `status: pending` and will be flipped to `pass` or `fail` as verification concludes.
|
|
30
|
+
|
|
31
|
+
#### Step 2.5 — Quality-gate gate (D-08, D-09)
|
|
32
|
+
|
|
33
|
+
Before resume detection, inspect `state.quality_gate` from the same snapshot. The Stage 4.5 quality-gate skill (see `skills/quality-gate/SKILL.md`) writes a single `<run/>` element capturing the most recent run; this step is the verify-side consumer of that result. Three branches, evaluated in order:
|
|
34
|
+
|
|
35
|
+
- **`state.quality_gate?.run?.status === "fail"`** → Refuse to advance. The fix loop in `quality-gate/SKILL.md` Step 4 reached `max_iters` without converging, and the verify stage MUST NOT paper over it. Print a blocker reason that includes the iteration count and the `commands_run` field from the run, then call:
|
|
36
|
+
|
|
37
|
+
```
|
|
38
|
+
mcp__gdd_state__add_blocker({
|
|
39
|
+
stage: "verify",
|
|
40
|
+
text: "quality-gate failed at iteration <N> (commands: <commands_run>) — re-run /gdd:quality-gate before /gdd:verify"
|
|
41
|
+
})
|
|
42
|
+
```
|
|
43
|
+
|
|
44
|
+
Exit immediately with the failure surface visible to the user. Do NOT call `mcp__gdd_state__update_progress` to open the verify stage; the gate refused entry, so the stage was never opened.
|
|
45
|
+
|
|
46
|
+
- **`state.quality_gate?.run?.status === "timeout"` OR `=== "skipped"`** → Print a one-line warning naming the status and the `commands_run` value, then continue normally. Per D-07 these are signals, not walls: a slow test suite must not hostage the pipeline, and a project with no detectable quality commands must not block verify entry. The warning surfaces the degraded state without halting.
|
|
47
|
+
|
|
48
|
+
- **`state.quality_gate?.run?.status === "pass"` OR `state.quality_gate === null`** → Continue silently. `pass` is the happy path; `null` means the gate has never been run for this cycle (the user skipped Stage 4.5 entirely, which is permitted — verify only *checks* the gate result, never *runs* the gate itself, per the 25-07 out-of-scope clause).
|
|
49
|
+
|
|
50
|
+
This step is a pure read against the snapshot already loaded in Step 2 — no extra MCP call is required.
|
|
51
|
+
|
|
52
|
+
3. Resume detection (read `state.position.status` from the snapshot):
|
|
53
|
+
- If `status==in_progress` and `.design/DESIGN-VERIFICATION.md` exists: RESUME — skip re-spawning agents, go to Step 2 (gap-response loop).
|
|
54
|
+
- Otherwise: call `mcp__gdd_state__update_progress` with `task_progress: "0/3"`, `status: "in_progress"` to open the stage, then proceed to Step 1.
|
|
55
|
+
4. If STATE.md is missing entirely (edge case — verify is never the entry point): block with "No STATE.md found — run /get-design-done:discover first." Do NOT attempt to create a skeleton from verify; upstream stages own bootstrap.
|
|
56
|
+
|
|
57
|
+
---
|
|
58
|
+
|
|
59
|
+
## Flipping a must-have status
|
|
60
|
+
|
|
61
|
+
When verification concludes that M-XX is satisfied (or failed), record the result by issuing:
|
|
62
|
+
|
|
63
|
+
`mcp__gdd_state__add_must_have` with the SAME `id` as the existing entry and the updated `status`:
|
|
64
|
+
|
|
65
|
+
```json
|
|
66
|
+
{ "id": "M-03", "text": "Dark mode toggle persists to localStorage", "status": "pass" }
|
|
67
|
+
```
|
|
68
|
+
|
|
69
|
+
The gdd-state mutator treats an `add_must_have` with an existing id as an **update-in-place**, not a duplicate append. The entry's position in the `<must_haves>` block is preserved. This is intentional design — verify doesn't need a dedicated `update_must_have_status` tool because `add_must_have` handles both cases correctly.
|
|
70
|
+
|
|
71
|
+
Pass the original `text` verbatim when you're only flipping the status; supplying a changed `text` overwrites the prose in-place as well (useful when the M-XX description was imprecise and the verifier can restate it). Omit `text` by passing the value from the earlier `mcp__gdd_state__get` snapshot.
|
|
72
|
+
|
|
73
|
+
---
|
|
74
|
+
|
|
75
|
+
## Connection Probes
|
|
76
|
+
|
|
77
|
+
### Probe Preview connection
|
|
78
|
+
|
|
79
|
+
Run at stage entry, after reading STATE.md:
|
|
80
|
+
|
|
81
|
+
```
|
|
82
|
+
Step P1 — ToolSearch check:
|
|
83
|
+
ToolSearch({ query: "Claude_Preview", max_results: 5 })
|
|
84
|
+
-> Empty result -> preview: not_loaded (MCP not registered — skip all Preview steps in this stage)
|
|
85
|
+
-> Non-empty result -> proceed to Step P2
|
|
86
|
+
|
|
87
|
+
Step P2 — Live tool call:
|
|
88
|
+
call mcp__Claude_Preview__preview_list
|
|
89
|
+
-> Success -> preview: available
|
|
90
|
+
-> Error containing "permission"/blocked -> preview: permission_denied
|
|
91
|
+
-> Any other error -> preview: unreachable
|
|
92
|
+
|
|
93
|
+
Record the preview probe result via `mcp__gdd_state__probe_connections` (batched with the storybook and chromatic probes below — one call per stage, see "Batched connections write" at the end of this section).
|
|
94
|
+
```
|
|
95
|
+
|
|
96
|
+
When `preview: available`, the design-verifier agent runs Phase 4B — Screenshot Evidence to resolve `? VISUAL` heuristic flags with real screenshot evidence. See `agents/design-verifier.md` Phase 4B for the screenshot evidence loop.
|
|
97
|
+
|
|
98
|
+
### Probe Storybook connection
|
|
99
|
+
|
|
100
|
+
Run at stage entry, after reading STATE.md:
|
|
101
|
+
|
|
102
|
+
Step B1 — Project detection:
|
|
103
|
+
Bash: ls .storybook/ 2>/dev/null || grep -l '"storybook"' package.json 2>/dev/null
|
|
104
|
+
-> Found -> storybook_project: true -> proceed to Step B2
|
|
105
|
+
-> Not found -> storybook: not_configured (skip all Storybook steps)
|
|
106
|
+
|
|
107
|
+
Step B2 — Dev server detection:
|
|
108
|
+
Bash: curl -sf http://localhost:6006/index.json 2>/dev/null | head -1
|
|
109
|
+
-> Returns JSON -> storybook: available
|
|
110
|
+
-> Fails -> Bash: curl -sf http://localhost:6006/stories.json 2>/dev/null | head -1
|
|
111
|
+
-> Returns JSON -> storybook: available (compat endpoint)
|
|
112
|
+
-> Fails -> storybook: unavailable
|
|
113
|
+
|
|
114
|
+
Record the storybook probe result for the batched `mcp__gdd_state__probe_connections` call (see below).
|
|
115
|
+
|
|
116
|
+
### Storybook A11y Loop (when storybook: available)
|
|
117
|
+
|
|
118
|
+
If `state.connections.storybook === "available"` (from the earlier `mcp__gdd_state__get` snapshot):
|
|
119
|
+
1. Run: Bash: npx storybook test --ci 2>&1 | tee .design/storybook-a11y-report.txt
|
|
120
|
+
2. Read .design/storybook-a11y-report.txt — pass to design-verifier as additional a11y evidence
|
|
121
|
+
3. design-verifier reads this file in its a11y gap analysis section and annotates DESIGN-VERIFICATION.md with per-story violations
|
|
122
|
+
|
|
123
|
+
If storybook: unavailable — skip this section; run standard WCAG grep-based a11y checks only.
|
|
124
|
+
If storybook: not_configured — skip; emit no note (opt-in feature).
|
|
125
|
+
|
|
126
|
+
### Probe Chromatic connection
|
|
127
|
+
|
|
128
|
+
Run at stage entry, after reading STATE.md:
|
|
129
|
+
|
|
130
|
+
Step C1 — CLI presence:
|
|
131
|
+
Bash: command -v chromatic 2>/dev/null || npx chromatic --version 2>/dev/null
|
|
132
|
+
-> found -> proceed to Step C2
|
|
133
|
+
-> not found -> chromatic: not_configured (skip all Chromatic steps)
|
|
134
|
+
|
|
135
|
+
Step C2 — Token check:
|
|
136
|
+
Bash: test -n "${CHROMATIC_PROJECT_TOKEN}"
|
|
137
|
+
-> true -> chromatic: available
|
|
138
|
+
-> false -> chromatic: unavailable
|
|
139
|
+
|
|
140
|
+
Also check: if storybook: not_configured -> chromatic effectively unavailable (emit note, do not run).
|
|
141
|
+
Record the chromatic probe result for the batched `mcp__gdd_state__probe_connections` call below.
|
|
142
|
+
|
|
143
|
+
### Batched connections write
|
|
144
|
+
|
|
145
|
+
After all three probes (preview, storybook, chromatic) have a verdict, call `mcp__gdd_state__probe_connections` ONCE with `probe_results` = an array of `{ name, status }` entries — one per probed connection. Example:
|
|
146
|
+
|
|
147
|
+
```json
|
|
148
|
+
[
|
|
149
|
+
{ "name": "preview", "status": "available" },
|
|
150
|
+
{ "name": "storybook", "status": "unavailable" },
|
|
151
|
+
{ "name": "chromatic", "status": "not_configured" }
|
|
152
|
+
]
|
|
153
|
+
```
|
|
154
|
+
|
|
155
|
+
Unspecified connections keep their existing value. Do NOT issue multiple `probe_connections` calls — the tool is designed for a single batch write per stage.
|
|
156
|
+
|
|
157
|
+
### Chromatic Visual Delta (when chromatic: available)
|
|
158
|
+
|
|
159
|
+
After design executor has run (when verifying post-design):
|
|
160
|
+
1. Run: Bash: npx chromatic --project-token $CHROMATIC_PROJECT_TOKEN --output json 2>&1 | tee .design/chromatic-results.json
|
|
161
|
+
2. Pass .design/chromatic-results.json to design-verifier for narration (see design-verifier.md Chromatic Delta Narration section)
|
|
162
|
+
If chromatic: unavailable or not_configured: skip; note in DESIGN-VERIFICATION.md "visual regression check skipped".
|
|
163
|
+
|
|
164
|
+
---
|
|
165
|
+
|
|
166
|
+
## Prerequisite Checks
|
|
167
|
+
|
|
168
|
+
**DESIGN-PLAN.md prerequisite check:**
|
|
169
|
+
- **Normal mode:** Check that `.design/DESIGN-PLAN.md` exists. If missing, block with: "Verify requires DESIGN-PLAN.md. Run `/gdd:plan` first, or use `--post-handoff` if starting from a Claude Design handoff bundle."
|
|
170
|
+
- **Post-handoff mode** (`post_handoff=true` OR STATE.md `status: handoff-sourced`): Skip the DESIGN-PLAN.md check entirely — handoff workflows have no DESIGN-PLAN.md.
|
|
171
|
+
|
|
172
|
+
Abort only if no `.design/` directory exists (user has not run prior stages). Output: "No .design/ directory found. Run /get-design-done:discover first."
|
|
173
|
+
|
|
174
|
+
## Post-Handoff Mode
|
|
175
|
+
|
|
176
|
+
When `--post-handoff` flag is present OR STATE.md `<position>` contains `status: handoff-sourced`:
|
|
177
|
+
|
|
178
|
+
1. **Skip DESIGN-PLAN.md prerequisite check** (no plan exists in handoff flows)
|
|
179
|
+
2. **Pass `post_handoff: true` to design-verifier** spawn prompt (see Step 1b below)
|
|
180
|
+
3. **Pass `handoff_path`** from STATE.md to design-verifier spawn prompt
|
|
181
|
+
4. **DESIGN-VERIFICATION.md** will include a `## Handoff Faithfulness` section generated by design-verifier (see `agents/design-verifier.md` Handoff Faithfulness Phase)
|
|
182
|
+
|
|
183
|
+
Also pass post-handoff context to design-auditor: auditor skips DESIGN-PLAN.md reads and focuses on implementation-vs-bundle gap analysis.
|
|
184
|
+
|
|
185
|
+
## Flag Parsing
|
|
186
|
+
|
|
187
|
+
- `--auto` -> `auto_mode=true` (no interactive prompts; skip visual UAT interactive steps; on gaps: save-and-exit rather than prompt for fix)
|
|
188
|
+
- `--post-handoff` -> `post_handoff=true` (relax DESIGN-PLAN.md prerequisite; instruct verifier to add Handoff Faithfulness section; see ## Post-Handoff Mode below)
|
|
189
|
+
|
|
190
|
+
## Parallelism Decision (before agent spawns)
|
|
191
|
+
|
|
192
|
+
- Read `.design/config.json` `parallelism` (or defaults from `reference/config-schema.md`).
|
|
193
|
+
- Apply rules from `reference/parallelism-rules.md`.
|
|
194
|
+
- `design-verifier` depends on `design-auditor` output (rule 1) -> serial between those two. `design-integration-checker` is independent of the auditor's *file* output but runs after verifier in the current sequence; if config opts in, `design-auditor` and `design-integration-checker` can parallelize (disjoint writes). Default: serial.
|
|
195
|
+
- Record `<parallelism_decision>` via `mcp__gdd_state__set_status` (e.g., `status: "verify_parallelism_decided: <serial|parallel>"`) before spawning. Do not write STATE.md directly.
|
|
196
|
+
|
|
197
|
+
---
|
|
198
|
+
|
|
199
|
+
## Step 1 — Spawn Auditor + Verifier + Integration Checker
|
|
200
|
+
|
|
201
|
+
Initialize iteration counter to 0 (used for fix loop limit in Step 3).
|
|
202
|
+
|
|
203
|
+
Three agents run in sequence. Each waits for its completion marker before the next is spawned.
|
|
204
|
+
|
|
205
|
+
**Note on lazy gates (Plan 10.1-04 / D-21):** Each full checker is preceded by a cheap Haiku gate that reads the diff and may return `{spawn: false}` to short-circuit. When gated out, `lazy_skipped: true` is appended to `.design/telemetry/costs.jsonl`. Gates: `design-verifier-gate` (before 1b), `design-integration-checker-gate` (before 1c). `design-context-checker-gate` is wired into `skills/discover/SKILL.md` Step 1.75.
|
|
206
|
+
|
|
207
|
+
### 1a. Run design-auditor first (retrospective 6-pillar audit)
|
|
208
|
+
|
|
209
|
+
```
|
|
210
|
+
Task("design-auditor", """
|
|
211
|
+
<required_reading>
|
|
212
|
+
@.design/STATE.md
|
|
213
|
+
@.design/DESIGN-CONTEXT.md
|
|
214
|
+
@.design/DESIGN-PLAN.md
|
|
215
|
+
@.design/tasks/
|
|
216
|
+
@reference/audit-scoring.md
|
|
217
|
+
</required_reading>
|
|
218
|
+
|
|
219
|
+
You are the design-auditor agent. Run the 6-pillar retrospective audit (copy, visual hierarchy,
|
|
220
|
+
color, typography, layout/spacing, experience design) against the completed design work.
|
|
221
|
+
|
|
222
|
+
Score each pillar 1-4. Write your findings to .design/DESIGN-AUDIT.md.
|
|
223
|
+
|
|
224
|
+
This audit SUPPLEMENTS the 7-category 0-10 system in reference/audit-scoring.md — do not replace
|
|
225
|
+
or contradict it. Your output will be read by design-verifier as additional context.
|
|
226
|
+
|
|
227
|
+
Emit `## AUDIT COMPLETE` when done.
|
|
228
|
+
""")
|
|
229
|
+
```
|
|
230
|
+
|
|
231
|
+
Wait for `## AUDIT COMPLETE` in the agent response. Once detected, call `mcp__gdd_state__update_progress` with `task_progress: "1/3"` and a short `status` summary (e.g., `status: "audit_done"`).
|
|
232
|
+
|
|
233
|
+
### 1b-gate. Lazy gate — should design-verifier run?
|
|
234
|
+
|
|
235
|
+
Spawn the cheap Haiku gate before the expensive verifier:
|
|
236
|
+
|
|
237
|
+
Task("design-verifier-gate", """
|
|
238
|
+
<required_reading>
|
|
239
|
+
@.design/STATE.md
|
|
240
|
+
</required_reading>
|
|
241
|
+
|
|
242
|
+
You are the design-verifier-gate. Read the diff since the last verified commit
|
|
243
|
+
and decide whether design-verifier should spawn.
|
|
244
|
+
|
|
245
|
+
Context:
|
|
246
|
+
diff_files: <output of `git diff --name-only <baseline_sha>..HEAD`>
|
|
247
|
+
diff_body: <output of `git diff <baseline_sha>..HEAD` truncated to 4000 lines>
|
|
248
|
+
baseline_sha: <from .design/STATE.md last_verified_sha, or HEAD~1 if absent>
|
|
249
|
+
|
|
250
|
+
Apply the heuristic. Emit JSON + `## GATE COMPLETE`.
|
|
251
|
+
""")
|
|
252
|
+
|
|
253
|
+
Wait for `## GATE COMPLETE`. Parse the JSON:
|
|
254
|
+
|
|
255
|
+
- `spawn: false` -> append pending telemetry row `{ts, agent: "design-verifier", tier: "skipped", tokens_in: 0, tokens_out: 0, cache_hit: false, est_cost_usd: 0, lazy_skipped: true, gate_rationale: "<from gate>", cycle, phase}` (PreToolUse hook from 10.1-01 flushes on next tool use; orchestrator MAY stub-append directly to `.design/telemetry/costs.jsonl` until 10.1-05 lands). Skip 1b. Call `mcp__gdd_state__update_progress` with `task_progress: "2/3"` and `status: "verifier_gate_skipped"`. Emit `design-verifier skipped — gate rationale: <rationale>`.
|
|
256
|
+
- `spawn: true` -> proceed to 1b as currently written.
|
|
257
|
+
|
|
258
|
+
### 1b. Run design-verifier (reads auditor output as additional input)
|
|
259
|
+
|
|
260
|
+
```
|
|
261
|
+
Task("design-verifier", """
|
|
262
|
+
<required_reading>
|
|
263
|
+
@.design/STATE.md
|
|
264
|
+
@.design/DESIGN-AUDIT.md
|
|
265
|
+
@.design/DESIGN-PLAN.md
|
|
266
|
+
@.design/DESIGN-CONTEXT.md
|
|
267
|
+
@.design/tasks/
|
|
268
|
+
@reference/audit-scoring.md
|
|
269
|
+
@reference/heuristics.md
|
|
270
|
+
@reference/review-format.md
|
|
271
|
+
@reference/accessibility.md
|
|
272
|
+
</required_reading>
|
|
273
|
+
|
|
274
|
+
You are the design-verifier agent. Run the 5-phase verification against completed design work.
|
|
275
|
+
|
|
276
|
+
DESIGN-AUDIT.md (above) contains a retrospective 6-pillar qualitative audit from design-auditor.
|
|
277
|
+
Read it as supplementary signal — incorporate the priority fix list into your Phase 5 gap analysis
|
|
278
|
+
where relevant. The auditor's 1-4 scores complement your 0-10 category scores; they do not
|
|
279
|
+
replace your Phase 1 category scoring.
|
|
280
|
+
|
|
281
|
+
Context:
|
|
282
|
+
auto_mode: <true|false>
|
|
283
|
+
re_verify: false
|
|
284
|
+
post_handoff: <true|false — true when --post-handoff flag active or STATE.md status==handoff-sourced>
|
|
285
|
+
handoff_path: <value from STATE.md handoff_path, or empty string>
|
|
286
|
+
|
|
287
|
+
Write .design/DESIGN-VERIFICATION.md. If post_handoff is true, include ## Handoff Faithfulness section
|
|
288
|
+
(see agents/design-verifier.md Handoff Faithfulness Phase). If gaps found, emit `## GAPS FOUND` followed
|
|
289
|
+
by structured gap list, then `## VERIFICATION COMPLETE`. If no gaps, just emit `## VERIFICATION COMPLETE`.
|
|
290
|
+
""")
|
|
291
|
+
```
|
|
292
|
+
|
|
293
|
+
Wait for `## VERIFICATION COMPLETE` in the agent response. Once detected, call `mcp__gdd_state__update_progress` with `task_progress: "2/3"` and a short `status` summary (e.g., `status: "verifier_done"`).
|
|
294
|
+
|
|
295
|
+
### 1c-gate. Lazy gate — should design-integration-checker run?
|
|
296
|
+
|
|
297
|
+
Same pattern as 1b-gate:
|
|
298
|
+
|
|
299
|
+
Task("design-integration-checker-gate", """
|
|
300
|
+
<required_reading>
|
|
301
|
+
@.design/STATE.md
|
|
302
|
+
</required_reading>
|
|
303
|
+
|
|
304
|
+
You are the design-integration-checker-gate. Read the diff and decide whether
|
|
305
|
+
design-integration-checker should spawn.
|
|
306
|
+
|
|
307
|
+
Context:
|
|
308
|
+
diff_files: <git diff --name-only output>
|
|
309
|
+
diff_body: <git diff output, truncated>
|
|
310
|
+
baseline_sha: <from STATE.md or HEAD~1>
|
|
311
|
+
|
|
312
|
+
Apply the heuristic. Emit JSON + `## GATE COMPLETE`.
|
|
313
|
+
""")
|
|
314
|
+
|
|
315
|
+
Wait for `## GATE COMPLETE`. Parse JSON:
|
|
316
|
+
|
|
317
|
+
- `spawn: false` -> append `lazy_skipped: true` telemetry row (same shape), skip 1c, call `mcp__gdd_state__update_progress` with `task_progress: "3/3"` and `status: "integration_checker_gate_skipped"`, emit `design-integration-checker skipped — gate rationale: <rationale>`.
|
|
318
|
+
- `spawn: true` -> proceed to 1c as currently written.
|
|
319
|
+
|
|
320
|
+
### 1c. Run design-integration-checker (post-verification decision wiring check)
|
|
321
|
+
|
|
322
|
+
```
|
|
323
|
+
Task("design-integration-checker", """
|
|
324
|
+
<required_reading>
|
|
325
|
+
@.design/STATE.md
|
|
326
|
+
@.design/DESIGN-CONTEXT.md
|
|
327
|
+
@.design/DESIGN-VERIFICATION.md
|
|
328
|
+
</required_reading>
|
|
329
|
+
|
|
330
|
+
You are the design-integration-checker agent. Verify that each D-XX design decision recorded
|
|
331
|
+
in DESIGN-CONTEXT.md is actually reflected in the source code.
|
|
332
|
+
|
|
333
|
+
Check each decision by type:
|
|
334
|
+
- Typography decisions -> grep font-size/scale values against declared scale
|
|
335
|
+
- Color decisions -> grep for removed colors (expect 0 hits) and added tokens (expect >=1 hit)
|
|
336
|
+
- Layout/spacing decisions -> grep spacing values against declared grid
|
|
337
|
+
- Component decisions -> grep for old patterns (expect 0) and new patterns (expect >=1)
|
|
338
|
+
|
|
339
|
+
Return: Connected count, Orphaned count, Missing count with per-decision evidence.
|
|
340
|
+
Emit `## INTEGRATION CHECK COMPLETE` when done.
|
|
341
|
+
""")
|
|
342
|
+
```
|
|
343
|
+
|
|
344
|
+
Wait for `## INTEGRATION CHECK COMPLETE` in the agent response. Once detected, call `mcp__gdd_state__update_progress` with `task_progress: "3/3"` and a short `status` summary (e.g., `status: "integration_check_done"`).
|
|
345
|
+
|
|
346
|
+
**Note:** Integration-checker findings (Orphaned and Missing decisions) are treated as additional gaps and fed into the gap-response loop in Step 2 alongside verifier gaps.
|
|
347
|
+
|
|
348
|
+
---
|
|
349
|
+
|
|
350
|
+
## Step 2 — Interpret Result
|
|
351
|
+
|
|
352
|
+
Check agent responses for gaps. Gaps come from two sources:
|
|
353
|
+
- design-verifier: `## GAPS FOUND` marker in the verifier response (G-NN entries)
|
|
354
|
+
- design-integration-checker: Orphaned or Missing decisions in the integration checker response (any decision with status Orphaned or Missing is a gap)
|
|
355
|
+
|
|
356
|
+
### Consolidate gaps:
|
|
357
|
+
|
|
358
|
+
Merge verifier gaps (G-NN entries) and integration-checker gaps (Orphaned/Missing D-XX decisions) into a single gap list. Integration-checker Orphaned decisions become MAJOR gaps; Missing decisions become BLOCKER gaps (a decision that was never applied).
|
|
359
|
+
|
|
360
|
+
### If NO gaps from either source (PASS):
|
|
361
|
+
|
|
362
|
+
- For each M-XX from the earlier `mcp__gdd_state__get` snapshot (`state.must_haves`): call `mcp__gdd_state__add_must_have` with the same `id`, the same `text`, and `status: "pass"`. The mutator updates in-place (see "Flipping a must-have status" above).
|
|
363
|
+
- Go to **Stage exit** with status=completed.
|
|
364
|
+
|
|
365
|
+
### If GAPS FOUND (from either source):
|
|
366
|
+
|
|
367
|
+
- Parse all gaps (verifier + integration-checker combined).
|
|
368
|
+
- Count gaps by severity (BLOCKER, MAJOR, MINOR, COSMETIC).
|
|
369
|
+
- If `auto_mode=true`: preserve DESIGN-VERIFICATION.md, call `mcp__gdd_state__set_status` with `status: "blocked"`, then call `mcp__gdd_state__add_blocker` with `stage: "verify"` and `text: "N blockers found — see .design/DESIGN-VERIFICATION.md and integration-checker output"` (the mutator stamps the ISO date automatically). Exit with message:
|
|
370
|
+
```
|
|
371
|
+
Verification failed — N gaps found (X blockers, Y majors, Z minors, W cosmetics).
|
|
372
|
+
Report: .design/DESIGN-VERIFICATION.md
|
|
373
|
+
Fix gaps and re-run: /get-design-done:verify
|
|
374
|
+
```
|
|
375
|
+
- If `auto_mode=false`: present gap summary and menu (go to Step 3).
|
|
376
|
+
|
|
377
|
+
---
|
|
378
|
+
|
|
379
|
+
## Step 3 — Gap Response Loop
|
|
380
|
+
|
|
381
|
+
Present to the user:
|
|
382
|
+
|
|
383
|
+
```
|
|
384
|
+
=== Verification found N gaps ===
|
|
385
|
+
BLOCKER: X
|
|
386
|
+
MAJOR: Y
|
|
387
|
+
MINOR: Z
|
|
388
|
+
COSMETIC:W
|
|
389
|
+
|
|
390
|
+
Options:
|
|
391
|
+
[1] Fix now — inline fix for addressable gaps, then re-verify
|
|
392
|
+
[2] Save and exit — work preserved; fix in a later session
|
|
393
|
+
[3] Accept as-is — mark verify complete despite gaps (not recommended for blockers)
|
|
394
|
+
|
|
395
|
+
Choose:
|
|
396
|
+
=================================
|
|
397
|
+
```
|
|
398
|
+
|
|
399
|
+
### If user chose [2] Save and exit:
|
|
400
|
+
|
|
401
|
+
- Preserve DESIGN-VERIFICATION.md.
|
|
402
|
+
- Call `mcp__gdd_state__set_status` with `status: "blocked"`.
|
|
403
|
+
- Call `mcp__gdd_state__add_blocker` with `stage: "verify"` and `text: "N gaps outstanding — see .design/DESIGN-VERIFICATION.md"` (ISO date stamped by the mutator).
|
|
404
|
+
- Call `mcp__gdd_state__checkpoint` to record the save-and-exit checkpoint.
|
|
405
|
+
- Exit:
|
|
406
|
+
```
|
|
407
|
+
Gaps saved. Resume with: /get-design-done:verify
|
|
408
|
+
Report: .design/DESIGN-VERIFICATION.md
|
|
409
|
+
```
|
|
410
|
+
|
|
411
|
+
### If user chose [3] Accept as-is:
|
|
412
|
+
|
|
413
|
+
- For each unmet must-have (from the earlier snapshot, comparing against verifier gaps): call `mcp__gdd_state__add_must_have` with the same `id`, the same `text`, and `status: "fail"` (update-in-place idiom). Then proceed to exit.
|
|
414
|
+
- Call `mcp__gdd_state__add_blocker` with `stage: "verify"` and `text: "accepted with N unresolved gaps"`.
|
|
415
|
+
- Go to **Stage exit** with status=completed.
|
|
416
|
+
|
|
417
|
+
### If user chose [1] Fix now:
|
|
418
|
+
|
|
419
|
+
Check fix iteration counter. If counter >= 3:
|
|
420
|
+
```
|
|
421
|
+
Maximum fix iterations (3) reached. Saving current state and exiting.
|
|
422
|
+
Outstanding gaps remain — see .design/DESIGN-VERIFICATION.md.
|
|
423
|
+
```
|
|
424
|
+
Treat as Save and exit (option 2 above).
|
|
425
|
+
|
|
426
|
+
Otherwise: increment iteration counter and spawn design-fixer:
|
|
427
|
+
|
|
428
|
+
Task("design-fixer", """
|
|
429
|
+
<required_reading>
|
|
430
|
+
@.design/STATE.md
|
|
431
|
+
@.design/DESIGN-VERIFICATION.md
|
|
432
|
+
@.design/DESIGN-CONTEXT.md
|
|
433
|
+
</required_reading>
|
|
434
|
+
|
|
435
|
+
Fix all BLOCKER and MAJOR gaps from ## Phase 5 — Gaps in DESIGN-VERIFICATION.md.
|
|
436
|
+
For each gap: apply the targeted fix to the file/location in the gap's Location field.
|
|
437
|
+
After each fix, make an atomic commit: fix(design-gap-GNN): [gap title].
|
|
438
|
+
|
|
439
|
+
Context:
|
|
440
|
+
auto_mode: <true|false>
|
|
441
|
+
|
|
442
|
+
Emit ## FIX COMPLETE when all in-scope gaps have been attempted (partial success is still ## FIX COMPLETE).
|
|
443
|
+
Record any gap that could not be fixed via mcp__gdd_state__add_blocker with stage: "verify".
|
|
444
|
+
""")
|
|
445
|
+
|
|
446
|
+
Wait for `## FIX COMPLETE` in the agent response before continuing.
|
|
447
|
+
|
|
448
|
+
After the design-fixer spawn returns `## FIX COMPLETE`, re-spawn design-verifier with `re_verify=true` and loop to Step 2:
|
|
449
|
+
|
|
450
|
+
```
|
|
451
|
+
Task("design-verifier", """
|
|
452
|
+
<required_reading>
|
|
453
|
+
@.design/STATE.md
|
|
454
|
+
@.design/DESIGN-AUDIT.md
|
|
455
|
+
@.design/DESIGN-PLAN.md
|
|
456
|
+
@.design/DESIGN-CONTEXT.md
|
|
457
|
+
@.design/tasks/
|
|
458
|
+
@reference/audit-scoring.md
|
|
459
|
+
@reference/heuristics.md
|
|
460
|
+
@reference/review-format.md
|
|
461
|
+
@reference/accessibility.md
|
|
462
|
+
</required_reading>
|
|
463
|
+
|
|
464
|
+
You are the design-verifier agent. This is a re-verification run after inline fixes.
|
|
465
|
+
|
|
466
|
+
DESIGN-AUDIT.md contains the retrospective 6-pillar audit from design-auditor (read as supplementary context).
|
|
467
|
+
|
|
468
|
+
Context:
|
|
469
|
+
auto_mode: <true|false>
|
|
470
|
+
re_verify: true
|
|
471
|
+
|
|
472
|
+
Focus verification on previously-failed must-haves first. Run full 5-phase pass.
|
|
473
|
+
Write updated .design/DESIGN-VERIFICATION.md. Emit ## GAPS FOUND (if any), then ## VERIFICATION COMPLETE.
|
|
474
|
+
""")
|
|
475
|
+
```
|
|
476
|
+
|
|
477
|
+
---
|
|
478
|
+
|
|
479
|
+
## Stage exit
|
|
480
|
+
|
|
481
|
+
1. Call `mcp__gdd_state__update_progress` with `task_progress: "<verified>/<total>"` (the total is `state.must_haves.length` from the entry snapshot; verified is the count set to `pass`) and `status: "verify_complete"`.
|
|
482
|
+
2. Call `mcp__gdd_state__set_status` with one of:
|
|
483
|
+
- `status: "pipeline_complete"` — all must-haves passed and no outstanding gaps.
|
|
484
|
+
- `status: "verify_failed_requires_loop"` — gaps remain (save-and-exit, accept-as-is with fails, or auto-mode blocker).
|
|
485
|
+
3. Call `mcp__gdd_state__checkpoint` — stamps `frontmatter.last_checkpoint` and appends a `verify_completed_at` timestamp entry. No direct STATE.md writes; the checkpoint tool owns the final persist.
|
|
486
|
+
|
|
487
|
+
---
|
|
488
|
+
|
|
489
|
+
## After Completion
|
|
490
|
+
|
|
491
|
+
Print summary:
|
|
492
|
+
|
|
493
|
+
```
|
|
494
|
+
=== Verify complete ===
|
|
495
|
+
Status: PASS | FAIL | ACCEPTED-WITH-GAPS
|
|
496
|
+
Gaps: X blockers, Y majors, Z minors, W cosmetics
|
|
497
|
+
|
|
498
|
+
Agents run:
|
|
499
|
+
design-auditor -> .design/DESIGN-AUDIT.md (6-pillar qualitative)
|
|
500
|
+
design-verifier-gate -> JSON gate decision (may skip design-verifier)
|
|
501
|
+
design-verifier -> .design/DESIGN-VERIFICATION.md (7-category + heuristics + UAT)
|
|
502
|
+
design-integration-checker-gate -> JSON gate decision (may skip design-integration-checker)
|
|
503
|
+
design-integration-checker -> inline (D-XX decision wiring)
|
|
504
|
+
|
|
505
|
+
Reports:
|
|
506
|
+
Qualitative audit: .design/DESIGN-AUDIT.md
|
|
507
|
+
Full verification: .design/DESIGN-VERIFICATION.md
|
|
508
|
+
|
|
509
|
+
Next: [if pass] pipeline complete — run /get-design-done:discover for next session
|
|
510
|
+
[if fail] fix gaps and re-run /get-design-done:verify
|
|
511
|
+
======================
|
|
512
|
+
```
|