@hegemonart/get-design-done 1.14.2 → 1.14.4

package/skills/explore/SKILL.md

@@ -2,7 +2,7 @@
 name: gdd-explore
 description: "Codebase inventory + design context — runs scan patterns and design-discussant interview, produces DESIGN.md + DESIGN-DEBT.md + DESIGN-CONTEXT.md (Stage 2 of 5)"
 argument-hint: "[--skip-interview] [--skip-scan]"
-tools: Read, Write, Bash, Grep, Glob, Task
+tools: Read, Write, Bash, Grep, Glob, Task, AskUserQuestion
 ---
 
 # Get Design Done — Explore
@@ -17,11 +17,20 @@ tools: Read, Write, Bash, Grep, Glob, Task
 
 Probe connection availability and update `.design/STATE.md` `<connections>`:
 
-**A — Figma probe:**
+**A — Figma probe (variant-agnostic):**
 ```
-ToolSearch({ query: "select:mcp__figma__get_metadata", max_results: 1 })
-Empty → figma: not_configured
-Non-empty → call mcp__figma__get_metadata; success → available; error → unavailable
+ToolSearch({ query: "figma get_metadata use_figma", max_results: 10 })
+Parse tool names matching /^mcp__([^_]*figma[^_]*)__(get_metadata|use_figma)$/i
+  into read-capable and write-capable prefix sets.
+Empty read set → figma: not_configured
+One+ matches  → pick prefix via tiebreaker:
+                (1) both-sets > reads-only,
+                (2) `figma` > others,
+                (3) non-`figma-desktop` > desktop,
+                (4) alphabetical.
+Then call {prefix}get_metadata:
+  success → figma: available (prefix=mcp__<prefix>__, writes=<true|false>)
+  error   → figma: unavailable
 ```
 
 **B — Refero probe:**
@@ -120,27 +129,55 @@ Mark STATE.md `task_progress` for the scan pass.
 
 ## Step 3 — Design interview (unless `--skip-interview`)
 
-Spawn the `design-discussant` agent:
+**Run this inline — do NOT spawn `design-discussant` as a subagent.** Subagent UI tools (`AskUserQuestion`) only render the native picker when called from the top-level skill context; spawning a Task() degrades the interview to plain markdown in chat (broken in Claude Desktop).
 
-```
-Task("design-discussant", """
-<required_reading>
-@.design/STATE.md
-@.design/BRIEF.md
-@.design/DESIGN.md
-@./.claude/skills
-</required_reading>
+### 3.a — Pre-load context
 
-<mode>normal</mode>
+Read in this order:
+1. `.design/STATE.md` — existing `<decisions>` D-XX entries (do NOT re-ask anything covered)
+2. `.design/BRIEF.md` — problem statement, audience, constraints
+3. `.design/DESIGN.md` — auto-detected inventory from Step 2
+4. `.design/DESIGN-CONTEXT.md` if it exists — `<gray_areas>` block lists unresolved topics
+5. `./.claude/skills/design-*-conventions.md` if any — locked project conventions, treat as authoritative
 
-Run an adaptive interview for areas not already covered by D-XX decisions.
-Append D-XX decisions to STATE.md <decisions>. Produce/update .design/DESIGN-CONTEXT.md.
+If `<connections>` in STATE.md shows `figma: available`, read the resolved `prefix=` from the same line and call `{prefix}get_variable_defs`, then draft tentative D-XX entries (mark `(tentative — confirm with user)`) before asking.
 
-Emit `## DISCUSS COMPLETE` when done.
-""")
-```
+### 3.b — Identify question set
+
+Build the list of areas needing input. Skip any area already answered by an existing D-XX or covered by a project convention. Default coverage:
+
+- Cycle goal / outcome that matters most
+- Audience and primary use context
+- Brand direction (only if no tokens detected in DESIGN.md)
+- Color primitives (only if no palette detected)
+- Typography scale (only if no type system detected)
+- Spacing scale (only if no spacing tokens detected)
+- Motion preferences (only if no motion patterns detected)
+- Any `<gray_areas>` from DESIGN-CONTEXT.md
+
+### 3.c — Ask, one question at a time
+
+For each area, call `AskUserQuestion` with a single focused question. Provide 4 concrete options plus "Other" / "Skip" where it helps. Do not batch questions into one call. Do not print the question as markdown — always go through the tool.
+
+Reject generic answers ("modern", "clean", "professional"). If the answer is vague, ask one follow-up before recording.
+
+### 3.d — Record after each answer
+
+After each confirmed answer:
+1. Append a `D-XX` entry to `.design/STATE.md` `<decisions>` block. Format:
+   ```
+   D-NN: [Category] Decision summary — short rationale
+   ```
+2. Append one JSON line to `.design/learnings/question-quality.jsonl` (create if absent):
+   ```json
+   {"ts":"<iso>","question_id":"Q-NN","question_text":"<verbatim>","answer_summary":"<one sentence>","quality":"high|medium|low|skipped","evidence":"<why>","cycle":"<active-cycle-slug>"}
+   ```
+   Quality classification: `skipped` if user picked Skip / "doesn't matter"; `low` if < 10 words and not a specific value; `medium` if hedged ("maybe", "I think", "not sure"); `high` otherwise.
+3. Save STATE.md immediately (incremental save — survives crash mid-interview).
+
+### 3.e — Produce DESIGN-CONTEXT.md
 
-Wait for `## DISCUSS COMPLETE`.
+When all questions are answered, write `.design/DESIGN-CONTEXT.md` summarizing the locked decisions, remaining gray areas, and any Figma-sourced tentatives that were confirmed or rejected. Set frontmatter `status: complete`.
 
 ## Step 4 — Update STATE.md
 

package/skills/figma-write/SKILL.md

@@ -24,10 +24,9 @@ Flags:
 
 ## Prerequisites
 
-1. Figma desktop app running with Dev Mode enabled
-2. Remote Figma MCP registered: `claude mcp add figma --transport http https://mcp.figma.com/v1/sse`
-3. `.design/DESIGN-CONTEXT.md` exists (run `discover` first)
-4. `figma: available` in `.design/STATE.md` `<connections>` block
+1. Remote Figma MCP registered (writes are remote-only). Preferred: `claude plugin install figma@claude-plugins-official`. Manual: `claude mcp add --transport http figma https://mcp.figma.com/mcp`.
+2. `.design/DESIGN-CONTEXT.md` exists (run `discover` first)
+3. `.design/STATE.md` `<connections>` shows `figma: available (…, writes=true)`. If `writes=false` (desktop-only variant), writes are not supported — the agent will STOP with an instruction to install the remote MCP.
 
 ## Required Reading
 

package/skills/scan/SKILL.md

@@ -39,18 +39,30 @@ At scan entry, before running any step:
 
 Run both probes below. MCP tools may be in the deferred tool set — **always call ToolSearch first**; without it, a deferred tool invocation fails silently.
 
-**Figma probe (single probe covers both reads and writes — remote MCP exposes `get_metadata`, `get_variable_defs`, `use_figma` on the same server):**
+**Figma probe (variant-agnostic — resolves any server prefix matching `/figma/i`):**
 
 ```
-Step A1 — ToolSearch check:
-  ToolSearch({ query: "select:mcp__figma__get_metadata", max_results: 1 })
-  → Empty result      → figma: not_configured  (skip all Figma steps)
-  → Non-empty result  → proceed to Step A2
+Step A1 — Keyword ToolSearch:
+  ToolSearch({ query: "figma get_metadata use_figma", max_results: 10 })
 
-Step A2 — Live tool call:
-  call mcp__figma__get_metadata
-  → Success           → figma: available   (reads AND use_figma writes both available)
-  → Error             → figma: unavailable  (skip all Figma steps)
+  Parse results for tool names matching:
+    - /^mcp__([^_]*figma[^_]*)__get_metadata$/i  → read-capable prefix set
+    - /^mcp__([^_]*figma[^_]*)__use_figma$/i     → write-capable prefix set
+
+  Empty read set      → figma: not_configured   (skip all Figma steps)
+  One or more matches → proceed to Step A2
+
+Step A2 — Tiebreaker selection:
+  Preference order when multiple read prefixes match:
+    1. Prefer prefixes that appear in BOTH read set and write set
+    2. Prefer `figma` (canonical remote server name)
+    3. Prefer non-`figma-desktop`
+    4. Alphabetical
+
+Step A3 — Live tool call on resolved prefix:
+  call mcp__<prefix>__get_metadata
+  → Success → figma: available (prefix=mcp__<prefix>__, writes=<true|false>)
+  → Error   → figma: unavailable  (skip all Figma steps)
 ```
 
 **Refero probe:**
@@ -228,7 +240,7 @@ Produce a color inventory table:
 
 ### If `figma: available`
 
-Call `mcp__figma__get_variable_defs` (no arguments — returns all variables in the active Figma file).
+Read the resolved prefix from STATE.md `<connections>` (e.g., `prefix=mcp__figma__` or `prefix=mcp__figma-desktop__`) and call `{prefix}get_variable_defs` (no arguments — returns all variables in the active Figma file).
 
 > If no Figma file is open, the call errors. Treat any error as a graceful skip: update STATE.md `<connections>` to `figma: unavailable` and continue with Step 2 results only.