@hecer/yoke 1.11.0 → 1.12.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (128) hide show
  1. package/.claude-plugin/plugin.json +13 -13
  2. package/.codex-plugin/plugin.json +7 -7
  3. package/CHANGELOG.md +416 -398
  4. package/README.md +931 -915
  5. package/TODOS.md +5 -5
  6. package/agents/docs.toml +6 -6
  7. package/agents/implementer.toml +6 -6
  8. package/agents/reviewer.toml +6 -6
  9. package/agents/security.toml +6 -6
  10. package/bench/README.md +86 -86
  11. package/bench/RESULTS.md +35 -35
  12. package/bench/output-compaction.mjs +65 -65
  13. package/bench/result-schema.mjs +12 -12
  14. package/bench/results/claude-2026-07-27T18-03-26.json +50 -50
  15. package/bench/results/codex-unavailable-1785175418318.json +15 -15
  16. package/bench/results/gemini-2026-07-27T18-03-44.json +46 -46
  17. package/bench/run-matrix.mjs +26 -26
  18. package/bench/run.mjs +106 -106
  19. package/canon/AGENTS.md +30 -30
  20. package/canon/context/DECISIONS.md +4 -4
  21. package/canon/context/GLOSSARY.md +11 -11
  22. package/canon/context/KNOWLEDGE.md +4 -4
  23. package/canon/context/PROJECT.md +15 -15
  24. package/canon/loop/loop-spec.md +65 -65
  25. package/canon/loop/prd.schema.md +41 -41
  26. package/canon/manifest.yaml +59 -59
  27. package/canon/policy/gates.md +7 -7
  28. package/canon/policy/roles.md +9 -9
  29. package/canon/skills/ATTRIBUTION.md +99 -99
  30. package/canon/skills/authoring-prd/SKILL.md +56 -56
  31. package/canon/skills/brainstorming/SKILL.md +164 -164
  32. package/canon/skills/codebase-design/DEEPENING.md +15 -15
  33. package/canon/skills/codebase-design/DESIGN-IT-TWICE.md +12 -12
  34. package/canon/skills/codebase-design/SKILL.md +39 -39
  35. package/canon/skills/dispatching-parallel-agents/SKILL.md +182 -182
  36. package/canon/skills/document-release/SKILL.md +302 -302
  37. package/canon/skills/domain-modeling/ADR-FORMAT.md +19 -19
  38. package/canon/skills/domain-modeling/CONTEXT-FORMAT.md +39 -39
  39. package/canon/skills/domain-modeling/SKILL.md +35 -35
  40. package/canon/skills/executing-plans/SKILL.md +70 -70
  41. package/canon/skills/finishing-a-development-branch/SKILL.md +200 -200
  42. package/canon/skills/health/SKILL.md +177 -177
  43. package/canon/skills/maintaining-context/SKILL.md +34 -34
  44. package/canon/skills/minimal-code/SKILL.md +21 -21
  45. package/canon/skills/no-ai-slop/SKILL.md +103 -103
  46. package/canon/skills/no-ai-slop/eval.md +43 -43
  47. package/canon/skills/plan-ceo-review/SKILL.md +541 -541
  48. package/canon/skills/plan-eng-review/SKILL.md +362 -362
  49. package/canon/skills/receiving-code-review/SKILL.md +213 -213
  50. package/canon/skills/requesting-code-review/SKILL.md +105 -105
  51. package/canon/skills/resolving-merge-conflicts/SKILL.md +18 -18
  52. package/canon/skills/retro/SKILL.md +397 -397
  53. package/canon/skills/review/SKILL.md +246 -246
  54. package/canon/skills/ship/SKILL.md +691 -691
  55. package/canon/skills/subagent-driven-development/SKILL.md +277 -277
  56. package/canon/skills/systematic-debugging/SKILL.md +296 -296
  57. package/canon/skills/tdd/SKILL.md +371 -371
  58. package/canon/skills/unslop-ui/SKILL.md +34 -34
  59. package/canon/skills/using-git-worktrees/SKILL.md +218 -218
  60. package/canon/skills/verification-before-completion/SKILL.md +139 -139
  61. package/canon/skills/visual-verification/SKILL.md +54 -54
  62. package/canon/skills/workflow/SKILL.md +22 -22
  63. package/canon/skills/writing-for-agents/SKILL-MECHANICS.md +27 -27
  64. package/canon/skills/writing-for-agents/SKILL.md +42 -42
  65. package/canon/skills/writing-plans/SKILL.md +152 -152
  66. package/canon/skills/writing-skills/SKILL.md +655 -655
  67. package/canon/skills/yoke-retrofit/SKILL.md +26 -26
  68. package/canon/skills/yoke-workflow/SKILL.md +20 -20
  69. package/canon/tools/codex-rtk-hook.mjs +35 -35
  70. package/canon/tools/gemini-rtk-hook.mjs +25 -25
  71. package/canon/tools/graphify.md +3 -3
  72. package/canon/tools/playwright-mcp.md +3 -3
  73. package/canon/tools/qwen-rtk-hook.mjs +25 -0
  74. package/canon/tools/rtk.md +7 -7
  75. package/canon/tools/serena.md +6 -6
  76. package/dist/agents/host.js +1 -1
  77. package/dist/agents/providers.js +18 -5
  78. package/dist/agents/telemetry.js +35 -36
  79. package/dist/cli.js +18 -10
  80. package/dist/dashboard/page.js +122 -122
  81. package/dist/dashboard/panels.js +91 -91
  82. package/dist/loop/run-command.js +3 -3
  83. package/dist/prd/command.js +17 -17
  84. package/dist/retrofit/apply.js +8 -1
  85. package/dist/retrofit/config.js +1 -1
  86. package/dist/retrofit/detect.js +2 -0
  87. package/dist/retrofit/planners/claude.js +14 -14
  88. package/dist/retrofit/planners/qwen.js +3 -3
  89. package/dist/retrofit/preserve.js +2 -2
  90. package/dist/retrofit/qwen-settings.js +17 -0
  91. package/dist/retrofit/skill-actions.js +1 -1
  92. package/dist/setup/command.js +22 -8
  93. package/dist/setup/model-presets.js +48 -0
  94. package/docs/CAPABILITY-ROUTING.md +51 -51
  95. package/docs/DASHBOARD-EVOLUTION.md +33 -33
  96. package/docs/MIGRATING-TO-1.0.md +33 -33
  97. package/docs/MIGRATING-TO-1.1.md +27 -27
  98. package/docs/MIGRATING-TO-1.4.md +70 -70
  99. package/docs/PRODUCT-DIRECTION-2026-09-05.md +210 -210
  100. package/docs/PUBLISHING.md +114 -114
  101. package/docs/QWEN-MODEL-SUPPORT.md +142 -0
  102. package/docs/VERIFIED-PROJECTS-VALIDATION.md +29 -29
  103. package/docs/VERIFIED-PROJECTS.md +167 -167
  104. package/docs/superpowers/plans/2026-06-28-baustein-e-context-layer.md +981 -981
  105. package/docs/superpowers/plans/2026-06-29-baustein-f-routing.md +258 -258
  106. package/docs/superpowers/plans/2026-06-29-baustein-g-loop-observability.md +1006 -1006
  107. package/docs/superpowers/plans/2026-06-29-baustein-h-loop-robustness.md +374 -374
  108. package/docs/superpowers/plans/2026-06-30-baustein-i-visual-design-verification.md +450 -450
  109. package/docs/superpowers/plans/2026-07-02-baustein-k-zero-to-100-bootstrap.md +1024 -1024
  110. package/docs/superpowers/plans/2026-07-02-baustein-m-flow-smoke-proofs.md +574 -574
  111. package/docs/superpowers/plans/2026-08-13-gauntlet-quality-loop.md +537 -537
  112. package/docs/superpowers/plans/2026-08-16-artifact-backed-output-compaction.md +329 -329
  113. package/docs/superpowers/plans/2026-09-05-verified-projects.md +83 -83
  114. package/docs/superpowers/specs/2026-06-28-baustein-e-context-layer-design.md +146 -146
  115. package/docs/superpowers/specs/2026-06-29-baustein-f-routing-design.md +106 -106
  116. package/docs/superpowers/specs/2026-06-29-baustein-g-loop-observability-design.md +186 -186
  117. package/docs/superpowers/specs/2026-06-29-baustein-h-loop-robustness-design.md +113 -113
  118. package/docs/superpowers/specs/2026-06-30-baustein-i-visual-design-verification-design.md +98 -98
  119. package/docs/superpowers/specs/2026-07-02-baustein-k-zero-to-100-bootstrap-design.md +200 -200
  120. package/docs/superpowers/specs/2026-07-02-baustein-m-flow-smoke-proofs-design.md +155 -155
  121. package/docs/superpowers/specs/2026-08-13-gauntlet-quality-loop-design.md +422 -422
  122. package/docs/superpowers/specs/2026-08-16-artifact-backed-output-compaction-design.md +166 -166
  123. package/gemini-extension.json +6 -6
  124. package/hooks/hooks.json +19 -19
  125. package/package.json +87 -87
  126. package/dist/dashboard/discovery.js +0 -73
  127. package/docs/community-outreach-2026-08-20.md +0 -85
  128. package/docs/launch-copy-2026-08-21.md +0 -193
@@ -1,213 +1,213 @@
1
- ---
2
- name: receiving-code-review
3
- description: Use when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementation
4
- ---
5
-
6
- # Code Review Reception
7
-
8
- ## Overview
9
-
10
- Code review requires technical evaluation, not emotional performance.
11
-
12
- **Core principle:** Verify before implementing. Ask before assuming. Technical correctness over social comfort.
13
-
14
- ## The Response Pattern
15
-
16
- ```
17
- WHEN receiving code review feedback:
18
-
19
- 1. READ: Complete feedback without reacting
20
- 2. UNDERSTAND: Restate requirement in own words (or ask)
21
- 3. VERIFY: Check against codebase reality
22
- 4. EVALUATE: Technically sound for THIS codebase?
23
- 5. RESPOND: Technical acknowledgment or reasoned pushback
24
- 6. IMPLEMENT: One item at a time, test each
25
- ```
26
-
27
- ## Forbidden Responses
28
-
29
- **NEVER:**
30
- - "You're absolutely right!" (explicit CLAUDE.md violation)
31
- - "Great point!" / "Excellent feedback!" (performative)
32
- - "Let me implement that now" (before verification)
33
-
34
- **INSTEAD:**
35
- - Restate the technical requirement
36
- - Ask clarifying questions
37
- - Push back with technical reasoning if wrong
38
- - Just start working (actions > words)
39
-
40
- ## Handling Unclear Feedback
41
-
42
- ```
43
- IF any item is unclear:
44
- STOP - do not implement anything yet
45
- ASK for clarification on unclear items
46
-
47
- WHY: Items may be related. Partial understanding = wrong implementation.
48
- ```
49
-
50
- **Example:**
51
- ```
52
- your human partner: "Fix 1-6"
53
- You understand 1,2,3,6. Unclear on 4,5.
54
-
55
- ❌ WRONG: Implement 1,2,3,6 now, ask about 4,5 later
56
- ✅ RIGHT: "I understand items 1,2,3,6. Need clarification on 4 and 5 before proceeding."
57
- ```
58
-
59
- ## Source-Specific Handling
60
-
61
- ### From your human partner
62
- - **Trusted** - implement after understanding
63
- - **Still ask** if scope unclear
64
- - **No performative agreement**
65
- - **Skip to action** or technical acknowledgment
66
-
67
- ### From External Reviewers
68
- ```
69
- BEFORE implementing:
70
- 1. Check: Technically correct for THIS codebase?
71
- 2. Check: Breaks existing functionality?
72
- 3. Check: Reason for current implementation?
73
- 4. Check: Works on all platforms/versions?
74
- 5. Check: Does reviewer understand full context?
75
-
76
- IF suggestion seems wrong:
77
- Push back with technical reasoning
78
-
79
- IF can't easily verify:
80
- Say so: "I can't verify this without [X]. Should I [investigate/ask/proceed]?"
81
-
82
- IF conflicts with your human partner's prior decisions:
83
- Stop and discuss with your human partner first
84
- ```
85
-
86
- **your human partner's rule:** "External feedback - be skeptical, but check carefully"
87
-
88
- ## YAGNI Check for "Professional" Features
89
-
90
- ```
91
- IF reviewer suggests "implementing properly":
92
- grep codebase for actual usage
93
-
94
- IF unused: "This endpoint isn't called. Remove it (YAGNI)?"
95
- IF used: Then implement properly
96
- ```
97
-
98
- **your human partner's rule:** "You and reviewer both report to me. If we don't need this feature, don't add it."
99
-
100
- ## Implementation Order
101
-
102
- ```
103
- FOR multi-item feedback:
104
- 1. Clarify anything unclear FIRST
105
- 2. Then implement in this order:
106
- - Blocking issues (breaks, security)
107
- - Simple fixes (typos, imports)
108
- - Complex fixes (refactoring, logic)
109
- 3. Test each fix individually
110
- 4. Verify no regressions
111
- ```
112
-
113
- ## When To Push Back
114
-
115
- Push back when:
116
- - Suggestion breaks existing functionality
117
- - Reviewer lacks full context
118
- - Violates YAGNI (unused feature)
119
- - Technically incorrect for this stack
120
- - Legacy/compatibility reasons exist
121
- - Conflicts with your human partner's architectural decisions
122
-
123
- **How to push back:**
124
- - Use technical reasoning, not defensiveness
125
- - Ask specific questions
126
- - Reference working tests/code
127
- - Involve your human partner if architectural
128
-
129
- **Signal if uncomfortable pushing back out loud:** "Strange things are afoot at the Circle K"
130
-
131
- ## Acknowledging Correct Feedback
132
-
133
- When feedback IS correct:
134
- ```
135
- ✅ "Fixed. [Brief description of what changed]"
136
- ✅ "Good catch - [specific issue]. Fixed in [location]."
137
- ✅ [Just fix it and show in the code]
138
-
139
- ❌ "You're absolutely right!"
140
- ❌ "Great point!"
141
- ❌ "Thanks for catching that!"
142
- ❌ "Thanks for [anything]"
143
- ❌ ANY gratitude expression
144
- ```
145
-
146
- **Why no thanks:** Actions speak. Just fix it. The code itself shows you heard the feedback.
147
-
148
- **If you catch yourself about to write "Thanks":** DELETE IT. State the fix instead.
149
-
150
- ## Gracefully Correcting Your Pushback
151
-
152
- If you pushed back and were wrong:
153
- ```
154
- ✅ "You were right - I checked [X] and it does [Y]. Implementing now."
155
- ✅ "Verified this and you're correct. My initial understanding was wrong because [reason]. Fixing."
156
-
157
- ❌ Long apology
158
- ❌ Defending why you pushed back
159
- ❌ Over-explaining
160
- ```
161
-
162
- State the correction factually and move on.
163
-
164
- ## Common Mistakes
165
-
166
- | Mistake | Fix |
167
- |---------|-----|
168
- | Performative agreement | State requirement or just act |
169
- | Blind implementation | Verify against codebase first |
170
- | Batch without testing | One at a time, test each |
171
- | Assuming reviewer is right | Check if breaks things |
172
- | Avoiding pushback | Technical correctness > comfort |
173
- | Partial implementation | Clarify all items first |
174
- | Can't verify, proceed anyway | State limitation, ask for direction |
175
-
176
- ## Real Examples
177
-
178
- **Performative Agreement (Bad):**
179
- ```
180
- Reviewer: "Remove legacy code"
181
- ❌ "You're absolutely right! Let me remove that..."
182
- ```
183
-
184
- **Technical Verification (Good):**
185
- ```
186
- Reviewer: "Remove legacy code"
187
- ✅ "Checking... build target is 10.15+, this API needs 13+. Need legacy for backward compat. Current impl has wrong bundle ID - fix it or drop pre-13 support?"
188
- ```
189
-
190
- **YAGNI (Good):**
191
- ```
192
- Reviewer: "Implement proper metrics tracking with database, date filters, CSV export"
193
- ✅ "Grepped codebase - nothing calls this endpoint. Remove it (YAGNI)? Or is there usage I'm missing?"
194
- ```
195
-
196
- **Unclear Item (Good):**
197
- ```
198
- your human partner: "Fix items 1-6"
199
- You understand 1,2,3,6. Unclear on 4,5.
200
- ✅ "Understand 1,2,3,6. Need clarification on 4 and 5 before implementing."
201
- ```
202
-
203
- ## GitHub Thread Replies
204
-
205
- When replying to inline review comments on GitHub, reply in the comment thread (`gh api repos/{owner}/{repo}/pulls/{pr}/comments/{id}/replies`), not as a top-level PR comment.
206
-
207
- ## The Bottom Line
208
-
209
- **External feedback = suggestions to evaluate, not orders to follow.**
210
-
211
- Verify. Question. Then implement.
212
-
213
- No performative agreement. Technical rigor always.
1
+ ---
2
+ name: receiving-code-review
3
+ description: Use when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementation
4
+ ---
5
+
6
+ # Code Review Reception
7
+
8
+ ## Overview
9
+
10
+ Code review requires technical evaluation, not emotional performance.
11
+
12
+ **Core principle:** Verify before implementing. Ask before assuming. Technical correctness over social comfort.
13
+
14
+ ## The Response Pattern
15
+
16
+ ```
17
+ WHEN receiving code review feedback:
18
+
19
+ 1. READ: Complete feedback without reacting
20
+ 2. UNDERSTAND: Restate requirement in own words (or ask)
21
+ 3. VERIFY: Check against codebase reality
22
+ 4. EVALUATE: Technically sound for THIS codebase?
23
+ 5. RESPOND: Technical acknowledgment or reasoned pushback
24
+ 6. IMPLEMENT: One item at a time, test each
25
+ ```
26
+
27
+ ## Forbidden Responses
28
+
29
+ **NEVER:**
30
+ - "You're absolutely right!" (explicit CLAUDE.md violation)
31
+ - "Great point!" / "Excellent feedback!" (performative)
32
+ - "Let me implement that now" (before verification)
33
+
34
+ **INSTEAD:**
35
+ - Restate the technical requirement
36
+ - Ask clarifying questions
37
+ - Push back with technical reasoning if wrong
38
+ - Just start working (actions > words)
39
+
40
+ ## Handling Unclear Feedback
41
+
42
+ ```
43
+ IF any item is unclear:
44
+ STOP - do not implement anything yet
45
+ ASK for clarification on unclear items
46
+
47
+ WHY: Items may be related. Partial understanding = wrong implementation.
48
+ ```
49
+
50
+ **Example:**
51
+ ```
52
+ your human partner: "Fix 1-6"
53
+ You understand 1,2,3,6. Unclear on 4,5.
54
+
55
+ ❌ WRONG: Implement 1,2,3,6 now, ask about 4,5 later
56
+ ✅ RIGHT: "I understand items 1,2,3,6. Need clarification on 4 and 5 before proceeding."
57
+ ```
58
+
59
+ ## Source-Specific Handling
60
+
61
+ ### From your human partner
62
+ - **Trusted** - implement after understanding
63
+ - **Still ask** if scope unclear
64
+ - **No performative agreement**
65
+ - **Skip to action** or technical acknowledgment
66
+
67
+ ### From External Reviewers
68
+ ```
69
+ BEFORE implementing:
70
+ 1. Check: Technically correct for THIS codebase?
71
+ 2. Check: Breaks existing functionality?
72
+ 3. Check: Reason for current implementation?
73
+ 4. Check: Works on all platforms/versions?
74
+ 5. Check: Does reviewer understand full context?
75
+
76
+ IF suggestion seems wrong:
77
+ Push back with technical reasoning
78
+
79
+ IF can't easily verify:
80
+ Say so: "I can't verify this without [X]. Should I [investigate/ask/proceed]?"
81
+
82
+ IF conflicts with your human partner's prior decisions:
83
+ Stop and discuss with your human partner first
84
+ ```
85
+
86
+ **your human partner's rule:** "External feedback - be skeptical, but check carefully"
87
+
88
+ ## YAGNI Check for "Professional" Features
89
+
90
+ ```
91
+ IF reviewer suggests "implementing properly":
92
+ grep codebase for actual usage
93
+
94
+ IF unused: "This endpoint isn't called. Remove it (YAGNI)?"
95
+ IF used: Then implement properly
96
+ ```
97
+
98
+ **your human partner's rule:** "You and reviewer both report to me. If we don't need this feature, don't add it."
99
+
100
+ ## Implementation Order
101
+
102
+ ```
103
+ FOR multi-item feedback:
104
+ 1. Clarify anything unclear FIRST
105
+ 2. Then implement in this order:
106
+ - Blocking issues (breaks, security)
107
+ - Simple fixes (typos, imports)
108
+ - Complex fixes (refactoring, logic)
109
+ 3. Test each fix individually
110
+ 4. Verify no regressions
111
+ ```
112
+
113
+ ## When To Push Back
114
+
115
+ Push back when:
116
+ - Suggestion breaks existing functionality
117
+ - Reviewer lacks full context
118
+ - Violates YAGNI (unused feature)
119
+ - Technically incorrect for this stack
120
+ - Legacy/compatibility reasons exist
121
+ - Conflicts with your human partner's architectural decisions
122
+
123
+ **How to push back:**
124
+ - Use technical reasoning, not defensiveness
125
+ - Ask specific questions
126
+ - Reference working tests/code
127
+ - Involve your human partner if architectural
128
+
129
+ **Signal if uncomfortable pushing back out loud:** "Strange things are afoot at the Circle K"
130
+
131
+ ## Acknowledging Correct Feedback
132
+
133
+ When feedback IS correct:
134
+ ```
135
+ ✅ "Fixed. [Brief description of what changed]"
136
+ ✅ "Good catch - [specific issue]. Fixed in [location]."
137
+ ✅ [Just fix it and show in the code]
138
+
139
+ ❌ "You're absolutely right!"
140
+ ❌ "Great point!"
141
+ ❌ "Thanks for catching that!"
142
+ ❌ "Thanks for [anything]"
143
+ ❌ ANY gratitude expression
144
+ ```
145
+
146
+ **Why no thanks:** Actions speak. Just fix it. The code itself shows you heard the feedback.
147
+
148
+ **If you catch yourself about to write "Thanks":** DELETE IT. State the fix instead.
149
+
150
+ ## Gracefully Correcting Your Pushback
151
+
152
+ If you pushed back and were wrong:
153
+ ```
154
+ ✅ "You were right - I checked [X] and it does [Y]. Implementing now."
155
+ ✅ "Verified this and you're correct. My initial understanding was wrong because [reason]. Fixing."
156
+
157
+ ❌ Long apology
158
+ ❌ Defending why you pushed back
159
+ ❌ Over-explaining
160
+ ```
161
+
162
+ State the correction factually and move on.
163
+
164
+ ## Common Mistakes
165
+
166
+ | Mistake | Fix |
167
+ |---------|-----|
168
+ | Performative agreement | State requirement or just act |
169
+ | Blind implementation | Verify against codebase first |
170
+ | Batch without testing | One at a time, test each |
171
+ | Assuming reviewer is right | Check if breaks things |
172
+ | Avoiding pushback | Technical correctness > comfort |
173
+ | Partial implementation | Clarify all items first |
174
+ | Can't verify, proceed anyway | State limitation, ask for direction |
175
+
176
+ ## Real Examples
177
+
178
+ **Performative Agreement (Bad):**
179
+ ```
180
+ Reviewer: "Remove legacy code"
181
+ ❌ "You're absolutely right! Let me remove that..."
182
+ ```
183
+
184
+ **Technical Verification (Good):**
185
+ ```
186
+ Reviewer: "Remove legacy code"
187
+ ✅ "Checking... build target is 10.15+, this API needs 13+. Need legacy for backward compat. Current impl has wrong bundle ID - fix it or drop pre-13 support?"
188
+ ```
189
+
190
+ **YAGNI (Good):**
191
+ ```
192
+ Reviewer: "Implement proper metrics tracking with database, date filters, CSV export"
193
+ ✅ "Grepped codebase - nothing calls this endpoint. Remove it (YAGNI)? Or is there usage I'm missing?"
194
+ ```
195
+
196
+ **Unclear Item (Good):**
197
+ ```
198
+ your human partner: "Fix items 1-6"
199
+ You understand 1,2,3,6. Unclear on 4,5.
200
+ ✅ "Understand 1,2,3,6. Need clarification on 4 and 5 before implementing."
201
+ ```
202
+
203
+ ## GitHub Thread Replies
204
+
205
+ When replying to inline review comments on GitHub, reply in the comment thread (`gh api repos/{owner}/{repo}/pulls/{pr}/comments/{id}/replies`), not as a top-level PR comment.
206
+
207
+ ## The Bottom Line
208
+
209
+ **External feedback = suggestions to evaluate, not orders to follow.**
210
+
211
+ Verify. Question. Then implement.
212
+
213
+ No performative agreement. Technical rigor always.
@@ -1,105 +1,105 @@
1
- ---
2
- name: requesting-code-review
3
- description: Use when completing tasks, implementing major features, or before merging to verify work meets requirements
4
- ---
5
-
6
- # Requesting Code Review
7
-
8
- Dispatch superpowers:code-reviewer subagent to catch issues before they cascade. The reviewer gets precisely crafted context for evaluation — never your session's history. This keeps the reviewer focused on the work product, not your thought process, and preserves your own context for continued work.
9
-
10
- **Core principle:** Review early, review often.
11
-
12
- ## When to Request Review
13
-
14
- **Mandatory:**
15
- - After each task in subagent-driven development
16
- - After completing major feature
17
- - Before merge to main
18
-
19
- **Optional but valuable:**
20
- - When stuck (fresh perspective)
21
- - Before refactoring (baseline check)
22
- - After fixing complex bug
23
-
24
- ## How to Request
25
-
26
- **1. Get git SHAs:**
27
- ```bash
28
- BASE_SHA=$(git rev-parse HEAD~1) # or origin/main
29
- HEAD_SHA=$(git rev-parse HEAD)
30
- ```
31
-
32
- **2. Dispatch code-reviewer subagent:**
33
-
34
- Use Task tool with superpowers:code-reviewer type, fill template at `code-reviewer.md`
35
-
36
- **Placeholders:**
37
- - `{WHAT_WAS_IMPLEMENTED}` - What you just built
38
- - `{PLAN_OR_REQUIREMENTS}` - What it should do
39
- - `{BASE_SHA}` - Starting commit
40
- - `{HEAD_SHA}` - Ending commit
41
- - `{DESCRIPTION}` - Brief summary
42
-
43
- **3. Act on feedback:**
44
- - Fix Critical issues immediately
45
- - Fix Important issues before proceeding
46
- - Note Minor issues for later
47
- - Push back if reviewer is wrong (with reasoning)
48
-
49
- ## Example
50
-
51
- ```
52
- [Just completed Task 2: Add verification function]
53
-
54
- You: Let me request code review before proceeding.
55
-
56
- BASE_SHA=$(git log --oneline | grep "Task 1" | head -1 | awk '{print $1}')
57
- HEAD_SHA=$(git rev-parse HEAD)
58
-
59
- [Dispatch superpowers:code-reviewer subagent]
60
- WHAT_WAS_IMPLEMENTED: Verification and repair functions for conversation index
61
- PLAN_OR_REQUIREMENTS: Task 2 from docs/superpowers/plans/deployment-plan.md
62
- BASE_SHA: a7981ec
63
- HEAD_SHA: 3df7661
64
- DESCRIPTION: Added verifyIndex() and repairIndex() with 4 issue types
65
-
66
- [Subagent returns]:
67
- Strengths: Clean architecture, real tests
68
- Issues:
69
- Important: Missing progress indicators
70
- Minor: Magic number (100) for reporting interval
71
- Assessment: Ready to proceed
72
-
73
- You: [Fix progress indicators]
74
- [Continue to Task 3]
75
- ```
76
-
77
- ## Integration with Workflows
78
-
79
- **Subagent-Driven Development:**
80
- - Review after EACH task
81
- - Catch issues before they compound
82
- - Fix before moving to next task
83
-
84
- **Executing Plans:**
85
- - Review after each batch (3 tasks)
86
- - Get feedback, apply, continue
87
-
88
- **Ad-Hoc Development:**
89
- - Review before merge
90
- - Review when stuck
91
-
92
- ## Red Flags
93
-
94
- **Never:**
95
- - Skip review because "it's simple"
96
- - Ignore Critical issues
97
- - Proceed with unfixed Important issues
98
- - Argue with valid technical feedback
99
-
100
- **If reviewer wrong:**
101
- - Push back with technical reasoning
102
- - Show code/tests that prove it works
103
- - Request clarification
104
-
105
- See template at: requesting-code-review/code-reviewer.md
1
+ ---
2
+ name: requesting-code-review
3
+ description: Use when completing tasks, implementing major features, or before merging to verify work meets requirements
4
+ ---
5
+
6
+ # Requesting Code Review
7
+
8
+ Dispatch superpowers:code-reviewer subagent to catch issues before they cascade. The reviewer gets precisely crafted context for evaluation — never your session's history. This keeps the reviewer focused on the work product, not your thought process, and preserves your own context for continued work.
9
+
10
+ **Core principle:** Review early, review often.
11
+
12
+ ## When to Request Review
13
+
14
+ **Mandatory:**
15
+ - After each task in subagent-driven development
16
+ - After completing major feature
17
+ - Before merge to main
18
+
19
+ **Optional but valuable:**
20
+ - When stuck (fresh perspective)
21
+ - Before refactoring (baseline check)
22
+ - After fixing complex bug
23
+
24
+ ## How to Request
25
+
26
+ **1. Get git SHAs:**
27
+ ```bash
28
+ BASE_SHA=$(git rev-parse HEAD~1) # or origin/main
29
+ HEAD_SHA=$(git rev-parse HEAD)
30
+ ```
31
+
32
+ **2. Dispatch code-reviewer subagent:**
33
+
34
+ Use Task tool with superpowers:code-reviewer type, fill template at `code-reviewer.md`
35
+
36
+ **Placeholders:**
37
+ - `{WHAT_WAS_IMPLEMENTED}` - What you just built
38
+ - `{PLAN_OR_REQUIREMENTS}` - What it should do
39
+ - `{BASE_SHA}` - Starting commit
40
+ - `{HEAD_SHA}` - Ending commit
41
+ - `{DESCRIPTION}` - Brief summary
42
+
43
+ **3. Act on feedback:**
44
+ - Fix Critical issues immediately
45
+ - Fix Important issues before proceeding
46
+ - Note Minor issues for later
47
+ - Push back if reviewer is wrong (with reasoning)
48
+
49
+ ## Example
50
+
51
+ ```
52
+ [Just completed Task 2: Add verification function]
53
+
54
+ You: Let me request code review before proceeding.
55
+
56
+ BASE_SHA=$(git log --oneline | grep "Task 1" | head -1 | awk '{print $1}')
57
+ HEAD_SHA=$(git rev-parse HEAD)
58
+
59
+ [Dispatch superpowers:code-reviewer subagent]
60
+ WHAT_WAS_IMPLEMENTED: Verification and repair functions for conversation index
61
+ PLAN_OR_REQUIREMENTS: Task 2 from docs/superpowers/plans/deployment-plan.md
62
+ BASE_SHA: a7981ec
63
+ HEAD_SHA: 3df7661
64
+ DESCRIPTION: Added verifyIndex() and repairIndex() with 4 issue types
65
+
66
+ [Subagent returns]:
67
+ Strengths: Clean architecture, real tests
68
+ Issues:
69
+ Important: Missing progress indicators
70
+ Minor: Magic number (100) for reporting interval
71
+ Assessment: Ready to proceed
72
+
73
+ You: [Fix progress indicators]
74
+ [Continue to Task 3]
75
+ ```
76
+
77
+ ## Integration with Workflows
78
+
79
+ **Subagent-Driven Development:**
80
+ - Review after EACH task
81
+ - Catch issues before they compound
82
+ - Fix before moving to next task
83
+
84
+ **Executing Plans:**
85
+ - Review after each batch (3 tasks)
86
+ - Get feedback, apply, continue
87
+
88
+ **Ad-Hoc Development:**
89
+ - Review before merge
90
+ - Review when stuck
91
+
92
+ ## Red Flags
93
+
94
+ **Never:**
95
+ - Skip review because "it's simple"
96
+ - Ignore Critical issues
97
+ - Proceed with unfixed Important issues
98
+ - Argue with valid technical feedback
99
+
100
+ **If reviewer wrong:**
101
+ - Push back with technical reasoning
102
+ - Show code/tests that prove it works
103
+ - Request clarification
104
+
105
+ See template at: requesting-code-review/code-reviewer.md
@@ -1,18 +1,18 @@
1
- ---
2
- name: resolving-merge-conflicts
3
- description: Resolve an in-progress Git merge or rebase conflict by tracing both sides to commits and available issue or spec evidence, preserving compatible intent, and running project checks. Use only when a merge or rebase is currently conflicted.
4
- ---
5
-
6
- # Resolving merge conflicts
7
-
8
- 1. Inspect the current merge or rebase state, history, and every conflicted file.
9
- 2. Trace both sides to their commits and available pull request, issue, specification, and test
10
- evidence. Identify what each change was trying to preserve.
11
- 3. Resolve each hunk. Preserve both intents when compatible. When they conflict, follow the current
12
- operation's stated goal and report the trade-off. Do not invent unrelated behavior.
13
- 4. Discover and run the project's scoped checks, then the broader checks justified by the merge.
14
- 5. Stage resolved files and continue the current operation until Git reports it complete.
15
-
16
- Keep all process actions scoped to the current repository and recorded operation. Never abort a
17
- merge or rebase unless the user explicitly requests that destructive reversal. Stop for direction
18
- when the evidence cannot distinguish two materially different product behaviors.
1
+ ---
2
+ name: resolving-merge-conflicts
3
+ description: Resolve an in-progress Git merge or rebase conflict by tracing both sides to commits and available issue or spec evidence, preserving compatible intent, and running project checks. Use only when a merge or rebase is currently conflicted.
4
+ ---
5
+
6
+ # Resolving merge conflicts
7
+
8
+ 1. Inspect the current merge or rebase state, history, and every conflicted file.
9
+ 2. Trace both sides to their commits and available pull request, issue, specification, and test
10
+ evidence. Identify what each change was trying to preserve.
11
+ 3. Resolve each hunk. Preserve both intents when compatible. When they conflict, follow the current
12
+ operation's stated goal and report the trade-off. Do not invent unrelated behavior.
13
+ 4. Discover and run the project's scoped checks, then the broader checks justified by the merge.
14
+ 5. Stage resolved files and continue the current operation until Git reports it complete.
15
+
16
+ Keep all process actions scoped to the current repository and recorded operation. Never abort a
17
+ merge or rebase unless the user explicitly requests that destructive reversal. Stop for direction
18
+ when the evidence cannot distinguish two materially different product behaviors.