@hebcal/noaa 0.8.4 → 0.8.6

package/dist/cjs/index.js

@@ -4,6 +4,7 @@ exports.NOAACalculator = exports.GeoLocation = void 0;
 const temporal_polyfill_1 = require("temporal-polyfill");
 /**
  * java.lang.Math.toRadians
+ * @private
  * @param degrees
  */
 function degreesToRadians(degrees) {
@@ -11,6 +12,7 @@ function degreesToRadians(degrees) {
 }
 /**
  * java.lang.Math.toDegrees
+ * @private
  * @param radians
  */
 function radiansToDegrees(radians) {
@@ -28,24 +30,26 @@ const Long_MIN_VALUE = NaN;
  */
 class GeoLocation {
     /**
-     * Method to get the elevation in Meters.
+     * GeoLocation constructor with parameters for all required fields.
      *
-     * @return Returns the elevation in Meters.
+     * @param {string} name
+     *            The location name for display use such as "Lakewood, NJ"
+     * @param {number} latitude
+     *            the latitude in a double format such as 40.095965 for Lakewood, NJ.
+     *            <b>Note: </b> For latitudes south of the equator, a negative value should be used.
+     * @param {number} longitude
+     *            double the longitude in a double format such as -74.222130 for Lakewood, NJ.
+     *            <b>Note: </b> For longitudes east of the <a href="http://en.wikipedia.org/wiki/Prime_Meridian">Prime
+     *            Meridian </a> (Greenwich), a negative value should be used.
+     * @param {number} elevation
+     *            the elevation above sea level in Meters. Elevation is not used in most algorithms used for calculating
+     *            sunrise and set.
+     * @param {string} timeZoneId
+     *            the <code>TimeZone</code> for the location.
      */
-    getElevation() {
-        return this.elevation;
-    }
-    /**
-     * Method to set the elevation in Meters <b>above </b> sea level.
-     *
-     * @param elevation
-     *            The elevation to set in Meters. An IllegalArgumentException will be thrown if the value is a negative.
-     */
-    setElevation(elevation) {
-        this.elevation = elevation;
-    }
-    constructor(name = 'Greenwich, England', latitude = 51.4772, longitude = 0, elevationOrTimeZoneId, timeZoneId) {
+    constructor(name, latitude, longitude, elevationOrTimeZoneId, timeZoneId) {
         /**
+         * @private
          * @see #getLocationName()
          * @see #setLocationName(String)
          */
@@ -63,39 +67,66 @@ class GeoLocation {
         this.setElevation(elevation);
         this.setTimeZone(timeZoneId);
     }
+    /**
+     * Method to get the elevation in Meters.
+     *
+     * @return {number} Returns the elevation in Meters.
+     */
+    getElevation() {
+        return this.elevation;
+    }
+    /**
+     * Method to set the elevation in Meters <b>above </b> sea level.
+     *
+     * @param {number} elevation
+     *            The elevation to set in Meters. An IllegalArgumentException will be thrown if the value is a negative.
+     */
+    setElevation(elevation) {
+        this.elevation = elevation;
+    }
     setLatitude(latitude) {
+        if (typeof latitude !== 'number')
+            throw new TypeError('Invalid latitude');
+        if (latitude < -90 || latitude > 90) {
+            throw new RangeError(`Latitude ${latitude} out of range [-90,90]`);
+        }
         this.latitude = latitude;
     }
     /**
-     * @return Returns the latitude.
+     * @return {number} Returns the latitude.
      */
     getLatitude() {
         return this.latitude;
     }
     setLongitude(longitude) {
+        if (typeof longitude !== 'number')
+            throw new TypeError('Invalid longitude');
+        if (longitude < -180 || longitude > 180) {
+            throw new RangeError(`Longitude ${longitude} out of range [-180,180]`);
+        }
         this.longitude = longitude;
     }
     /**
-     * @return Returns the longitude.
+     * @return {number} Returns the longitude.
      */
     getLongitude() {
         return this.longitude;
     }
     /**
-     * @return Returns the location name.
+     * @return {string|null} Returns the location name.
      */
     getLocationName() {
         return this.locationName;
     }
     /**
-     * @param name
+     * @param {string|null} name
      *            The setter method for the display name.
      */
     setLocationName(name) {
         this.locationName = name;
     }
     /**
-     * @return Returns the timeZone.
+     * @return {string} Returns the timeZone.
      */
     getTimeZone() {
         return this.timeZoneId;
@@ -108,7 +139,7 @@ class GeoLocation {
      * AstronomicalCalendar to output times in the expected offset. This situation will arise if the
      * AstronomicalCalendar is ever {@link AstronomicalCalendar#clone() cloned}.
      *
-     * @param timeZone
+     * @param {string} timeZone
      *            The timeZone to set.
      */
     setTimeZone(timeZoneId) {
@@ -149,7 +180,22 @@ const earthRadius = 6356.9; // in KM
  */
 class NOAACalculator {
     /**
-     * The getSunrise method Returns a <code>Date</code> representing the
+     * A constructor that takes in <a href="http://en.wikipedia.org/wiki/Geolocation">geolocation</a> information as a
+     * parameter. The default {@link AstronomicalCalculator#getDefault() AstronomicalCalculator} used for solar
+     * calculations is the the {@link NOAACalculator}.
+     *
+     * @param {GeoLocation} geoLocation
+     *            The location information used for calculating astronomical sun times.
+     * @param {Temporal.PlainDate} date
+     *
+     * @see #setAstronomicalCalculator(AstronomicalCalculator) for changing the calculator class.
+     */
+    constructor(geoLocation, date) {
+        this.date = date;
+        this.geoLocation = geoLocation;
+    }
+    /**
+     * The getSunrise method Returns a `Date` representing the
      * {@link AstronomicalCalculator#getElevationAdjustment(double) elevation adjusted} sunrise time. The zenith used
      * for the calculation uses {@link #GEOMETRIC_ZENITH geometric zenith} of 90&deg; plus
      * {@link AstronomicalCalculator#getElevationAdjustment(double)}. This is adjusted by the
@@ -157,7 +203,7 @@ class NOAACalculator {
      * and 16 archminutes for the sun's radius for a total of {@link AstronomicalCalculator#adjustZenith 90.83333&deg;}.
      * See documentation for the specific implementation of the {@link AstronomicalCalculator} that you are using.
      *
-     * @return the <code>Date</code> representing the exact sunrise time. If the calculation can't be computed such as
+     * @return {Temporal.ZonedDateTime | null} the `Date` representing the exact sunrise time. If the calculation can't be computed such as
      *         in the Arctic Circle where there is at least one day a year where the sun does not rise, and one where it
      *         does not set, a null will be returned. See detailed explanation on top of the page.
      * @see AstronomicalCalculator#adjustZenith
@@ -176,7 +222,7 @@ class NOAACalculator {
      * something that is not affected by elevation. This method returns sunrise calculated at sea level. This forms the
      * base for dawn calculations that are calculated as a dip below the horizon before sunrise.
      *
-     * @return the <code>Date</code> representing the exact sea-level sunrise time. If the calculation can't be computed
+     * @return {Temporal.ZonedDateTime | null} the `Date` representing the exact sea-level sunrise time. If the calculation can't be computed
      *         such as in the Arctic Circle where there is at least one day a year where the sun does not rise, and one
      *         where it does not set, a null will be returned. See detailed explanation on top of the page.
      * @see AstronomicalCalendar#getSunrise
@@ -192,7 +238,7 @@ class NOAACalculator {
     /**
      * A method that returns the beginning of civil twilight (dawn) using a zenith of {@link #CIVIL_ZENITH 96&deg;}.
      *
-     * @return The <code>Date</code> of the beginning of civil twilight using a zenith of 96&deg;. If the calculation
+     * @return {Temporal.ZonedDateTime | null} The `Date` of the beginning of civil twilight using a zenith of 96&deg;. If the calculation
      *         can't be computed, null will be returned. See detailed explanation on top of the page.
      * @see #CIVIL_ZENITH
      */
@@ -202,7 +248,7 @@ class NOAACalculator {
     /**
      * A method that returns the beginning of nautical twilight using a zenith of {@link #NAUTICAL_ZENITH 102&deg;}.
      *
-     * @return The <code>Date</code> of the beginning of nautical twilight using a zenith of 102&deg;. If the
+     * @return {Temporal.ZonedDateTime | null} The `Date` of the beginning of nautical twilight using a zenith of 102&deg;. If the
      *         calculation can't be computed null will be returned. See detailed explanation on top of the page.
      * @see #NAUTICAL_ZENITH
      */
@@ -213,7 +259,7 @@ class NOAACalculator {
      * A method that returns the beginning of astronomical twilight using a zenith of {@link #ASTRONOMICAL_ZENITH
      * 108&deg;}.
      *
-     * @return The <code>Date</code> of the beginning of astronomical twilight using a zenith of 108&deg;. If the
+     * @return {Temporal.ZonedDateTime | null} The `Date` of the beginning of astronomical twilight using a zenith of 108&deg;. If the
      *         calculation can't be computed, null will be returned. See detailed explanation on top of the page.
      * @see #ASTRONOMICAL_ZENITH
      */
@@ -221,7 +267,7 @@ class NOAACalculator {
         return this.getSunriseOffsetByDegrees(NOAACalculator.ASTRONOMICAL_ZENITH);
     }
     /**
-     * The getSunset method Returns a <code>Date</code> representing the
+     * The getSunset method Returns a `Date` representing the
      * {@link AstronomicalCalculator#getElevationAdjustment(double) elevation adjusted} sunset time. The zenith used for
      * the calculation uses {@link #GEOMETRIC_ZENITH geometric zenith} of 90&deg; plus
      * {@link AstronomicalCalculator#getElevationAdjustment(double)}. This is adjusted by the
@@ -232,7 +278,7 @@ class NOAACalculator {
      * other than the local timezone is used (calculating Los Angeles sunset using a GMT timezone for example). In this
      * case the sunset date will be incremented to the following date.
      *
-     * @return the <code>Date</code> representing the exact sunset time. If the calculation can't be computed such as in
+     * @return {Temporal.ZonedDateTime | null} The `Date` representing the exact sunset time. If the calculation can't be computed such as in
      *         the Arctic Circle where there is at least one day a year where the sun does not rise, and one where it
      *         does not set, a null will be returned. See detailed explanation on top of the page.
      * @see AstronomicalCalculator#adjustZenith
@@ -251,7 +297,7 @@ class NOAACalculator {
      * something that is not affected by elevation. This method returns sunset calculated at sea level. This forms the
      * base for dusk calculations that are calculated as a dip below the horizon after sunset.
      *
-     * @return the <code>Date</code> representing the exact sea-level sunset time. If the calculation can't be computed
+     * @return {Temporal.ZonedDateTime | null} The `Date` representing the exact sea-level sunset time. If the calculation can't be computed
      *         such as in the Arctic Circle where there is at least one day a year where the sun does not rise, and one
      *         where it does not set, a null will be returned. See detailed explanation on top of the page.
      * @see AstronomicalCalendar#getSunset
@@ -266,7 +312,7 @@ class NOAACalculator {
     /**
      * A method that returns the end of civil twilight using a zenith of {@link #CIVIL_ZENITH 96&deg;}.
      *
-     * @return The <code>Date</code> of the end of civil twilight using a zenith of {@link #CIVIL_ZENITH 96&deg;}. If
+     * @return {Temporal.ZonedDateTime | null} The `Date` of the end of civil twilight using a zenith of {@link #CIVIL_ZENITH 96&deg;}. If
      *         the calculation can't be computed, null will be returned. See detailed explanation on top of the page.
      * @see #CIVIL_ZENITH
      */
@@ -276,7 +322,7 @@ class NOAACalculator {
     /**
      * A method that returns the end of nautical twilight using a zenith of {@link #NAUTICAL_ZENITH 102&deg;}.
      *
-     * @return The <code>Date</code> of the end of nautical twilight using a zenith of {@link #NAUTICAL_ZENITH 102&deg;}
+     * @return {Temporal.ZonedDateTime | null} The `Date` of the end of nautical twilight using a zenith of {@link #NAUTICAL_ZENITH 102&deg;}
      *         . If the calculation can't be computed, null will be returned. See detailed explanation on top of the
      *         page.
      * @see #NAUTICAL_ZENITH
@@ -287,7 +333,7 @@ class NOAACalculator {
     /**
      * A method that returns the end of astronomical twilight using a zenith of {@link #ASTRONOMICAL_ZENITH 108&deg;}.
      *
-     * @return the <code>Date</code> of the end of astronomical twilight using a zenith of {@link #ASTRONOMICAL_ZENITH
+     * @return {Temporal.ZonedDateTime | null} The `Date` of the end of astronomical twilight using a zenith of {@link #ASTRONOMICAL_ZENITH
      *         108&deg;}. If the calculation can't be computed, null will be returned. See detailed explanation on top
      *         of the page.
      * @see #ASTRONOMICAL_ZENITH
@@ -301,11 +347,11 @@ class NOAACalculator {
      * after sunset with the intent of getting a rough "level of light" calculation, the sunrise or sunset time passed
      * to this method should be sea level sunrise and sunset.
      *
-     * @param time
+     * @param {Temporal.ZonedDateTime | null} time
      *            the start time
-     * @param offset
+     * @param {number} offset
      *            the offset in milliseconds to add to the time.
-     * @return the {@link java.util.Date} with the offset in milliseconds added to it
+     * @return {Temporal.ZonedDateTime | null} the `Date` with the offset in milliseconds added to it
      */
     static getTimeOffset(time, offset) {
         if (time === null || offset === Long_MIN_VALUE || Number.isNaN(offset)) {
@@ -318,12 +364,12 @@ class NOAACalculator {
      * {@link #getSunrise() sunrise}. Note that the degree offset is from the vertical, so for a calculation of 14&deg;
      * before sunrise, an offset of 14 + {@link #GEOMETRIC_ZENITH} = 104 would have to be passed as a parameter.
      *
-     * @param offsetZenith
+     * @param {number} offsetZenith
      *            the degrees before {@link #getSunrise()} to use in the calculation. For time after sunrise use
      *            negative numbers. Note that the degree offset is from the vertical, so for a calculation of 14&deg;
      *            before sunrise, an offset of 14 + {@link #GEOMETRIC_ZENITH} = 104 would have to be passed as a
      *            parameter.
-     * @return The {@link java.util.Date} of the offset after (or before) {@link #getSunrise()}. If the calculation
+     * @return {Temporal.ZonedDateTime | null} The `Date` of the offset after (or before) {@link #getSunrise()}. If the calculation
      *         can't be computed such as in the Arctic Circle where there is at least one day a year where the sun does
      *         not rise, and one where it does not set, a null will be returned. See detailed explanation on top of the
      *         page.
@@ -339,11 +385,11 @@ class NOAACalculator {
      * sunset}. Note that the degree offset is from the vertical, so for a calculation of 14&deg; after sunset, an
      * offset of 14 + {@link #GEOMETRIC_ZENITH} = 104 would have to be passed as a parameter.
      *
-     * @param offsetZenith
+     * @param {number} offsetZenith
      *            the degrees after {@link #getSunset()} to use in the calculation. For time before sunset use negative
      *            numbers. Note that the degree offset is from the vertical, so for a calculation of 14&deg; after
      *            sunset, an offset of 14 + {@link #GEOMETRIC_ZENITH} = 104 would have to be passed as a parameter.
-     * @return The {@link java.util.Date}of the offset after (or before) {@link #getSunset()}. If the calculation can't
+     * @return {Temporal.ZonedDateTime | null} The `Date`of the offset after (or before) {@link #getSunset()}. If the calculation can't
      *         be computed such as in the Arctic Circle where there is at least one day a year where the sun does not
      *         rise, and one where it does not set, a null will be returned. See detailed explanation on top of the
      *         page.
@@ -354,27 +400,13 @@ class NOAACalculator {
             return null;
         return this.getDateFromTime(sunset, false);
     }
-    /**
-     * A constructor that takes in <a href="http://en.wikipedia.org/wiki/Geolocation">geolocation</a> information as a
-     * parameter. The default {@link AstronomicalCalculator#getDefault() AstronomicalCalculator} used for solar
-     * calculations is the the {@link NOAACalculator}.
-     *
-     * @param geoLocation
-     *            The location information used for calculating astronomical sun times.
-     *
-     * @see #setAstronomicalCalculator(AstronomicalCalculator) for changing the calculator class.
-     */
-    constructor(geoLocation, date) {
-        this.date = date;
-        this.geoLocation = geoLocation;
-    }
     /**
      * A method that returns the sunrise in UTC time without correction for time zone offset from GMT and without using
      * daylight savings time.
      *
-     * @param zenith
+     * @param {number} zenith
      *            the degrees below the horizon. For time after sunrise use negative numbers.
-     * @return The time in the format: 18.75 for 18:45:00 UTC/GMT. If the calculation can't be computed such as in the
+     * @return {number} The time in the format: 18.75 for 18:45:00 UTC/GMT. If the calculation can't be computed such as in the
      *         Arctic Circle where there is at least one day a year where the sun does not rise, and one where it does
      *         not set, {@link Double#NaN} will be returned. See detailed explanation on top of the page.
      */
@@ -387,9 +419,9 @@ class NOAACalculator {
      * light, something that is not affected by elevation. This method returns UTC sunrise calculated at sea level. This
      * forms the base for dawn calculations that are calculated as a dip below the horizon before sunrise.
      *
-     * @param zenith
+     * @param {number} zenith
      *            the degrees below the horizon. For time after sunrise use negative numbers.
-     * @return The time in the format: 18.75 for 18:45:00 UTC/GMT. If the calculation can't be computed such as in the
+     * @return {number} The time in the format: 18.75 for 18:45:00 UTC/GMT. If the calculation can't be computed such as in the
      *         Arctic Circle where there is at least one day a year where the sun does not rise, and one where it does
      *         not set, {@link Double#NaN} will be returned. See detailed explanation on top of the page.
      * @see AstronomicalCalendar#getUTCSunrise
@@ -402,9 +434,9 @@ class NOAACalculator {
      * A method that returns the sunset in UTC time without correction for time zone offset from GMT and without using
      * daylight savings time.
      *
-     * @param zenith
+     * @param {number} zenith
      *            the degrees below the horizon. For time after sunset use negative numbers.
-     * @return The time in the format: 18.75 for 18:45:00 UTC/GMT. If the calculation can't be computed such as in the
+     * @return {number} The time in the format: 18.75 for 18:45:00 UTC/GMT. If the calculation can't be computed such as in the
      *         Arctic Circle where there is at least one day a year where the sun does not rise, and one where it does
      *         not set, {@link Double#NaN} will be returned. See detailed explanation on top of the page.
      * @see AstronomicalCalendar#getUTCSeaLevelSunset
@@ -419,9 +451,9 @@ class NOAACalculator {
      * at sea level. This forms the base for dusk calculations that are calculated as a dip below the horizon after
      * sunset.
      *
-     * @param zenith
+     * @param {number} zenith
      *            the degrees below the horizon. For time before sunset use negative numbers.
-     * @return The time in the format: 18.75 for 18:45:00 UTC/GMT. If the calculation can't be computed such as in the
+     * @return {number} The time in the format: 18.75 for 18:45:00 UTC/GMT. If the calculation can't be computed such as in the
      *         Arctic Circle where there is at least one day a year where the sun does not rise, and one where it does
      *         not set, {@link Double#NaN} will be returned. See detailed explanation on top of the page.
      * @see AstronomicalCalendar#getUTCSunset
@@ -460,9 +492,9 @@ class NOAACalculator {
      * elevationAdjustment = 0.0347 * Math.sqrt(elevationMeters);
      * </pre>
      *
-     * @param elevation
+     * @param {number} elevation
      *            elevation in Meters.
-     * @return the adjusted zenith
+     * @return {number} the adjusted zenith
      */
     getElevationAdjustment(elevation) {
         // double elevationAdjustment = 0.0347 * Math.sqrt(elevation);
@@ -489,15 +521,15 @@ class NOAACalculator {
      * {@link ZmanimCalendar#ZENITH_16_POINT_1 16.1&deg;} dip used in
      * {@link ComplexZmanimCalendar#getAlos16Point1Degrees()}.
      *
-     * @param zenith
+     * @param {number} zenith
      *            the azimuth below the vertical zenith of 90&deg;. For sunset typically the {@link #adjustZenith
      *            zenith} used for the calculation uses geometric zenith of 90&deg; and {@link #adjustZenith adjusts}
      *            this slightly to account for solar refraction and the sun's radius. Another example would be
      *            {@link AstronomicalCalendar#getEndNauticalTwilight()} that passes
      *            {@link AstronomicalCalendar#NAUTICAL_ZENITH} to this method.
-     * @param elevation
+     * @param {number} elevation
      *            elevation in Meters.
-     * @return The zenith adjusted to include the {@link #getSolarRadius sun's radius}, {@link #getRefraction
+     * @return {number} The zenith adjusted to include the {@link #getSolarRadius sun's radius}, {@link #getRefraction
      *         refraction} and {@link #getElevationAdjustment elevation} adjustment. This will only be adjusted for
      *         sunrise and sunset (if the zenith == 90&deg;)
      * @see #getElevationAdjustment(double)
@@ -556,21 +588,21 @@ class NOAACalculator {
      * non-elevation adjusted temporal hour by passing in {@link #getSeaLevelSunrise() sea level sunrise} and
      * {@link #getSeaLevelSunset() sea level sunset} as parameters.
      *
-     * @param startOfday
+     * @param {Temporal.ZonedDateTime | null} startOfDay
      *            The start of the day.
-     * @param endOfDay
+     * @param {Temporal.ZonedDateTime | null} endOfDay
      *            The end of the day.
      *
-     * @return the <code>long</code> millisecond length of the temporal hour. If the calculation can't be computed a
+     * @return {number} the <code>long</code> millisecond length of the temporal hour. If the calculation can't be computed a
      *         {@link Long#MIN_VALUE} will be returned. See detailed explanation on top of the page.
      *
      * @see #getTemporalHour()
      */
-    getTemporalHour(startOfday = this.getSeaLevelSunrise(), endOfDay = this.getSeaLevelSunset()) {
-        if (startOfday === null || endOfDay === null) {
+    getTemporalHour(startOfDay = this.getSeaLevelSunrise(), endOfDay = this.getSeaLevelSunset()) {
+        if (startOfDay === null || endOfDay === null) {
             return Long_MIN_VALUE;
         }
-        const delta = endOfDay.epochMilliseconds - startOfday.epochMilliseconds;
+        const delta = endOfDay.epochMilliseconds - startOfDay.epochMilliseconds;
         return Math.floor(delta / 12);
     }
     /**
@@ -580,14 +612,14 @@ class NOAACalculator {
      * calculated as halfway between the sunrise and sunset passed to this method. This time can be slightly off the
      * real transit time due to changes in declination (the lengthening or shortening day).
      *
-     * @param startOfDay
+     * @param {Temporal.ZonedDateTime | null} startOfDay
      *            the start of day for calculating the sun's transit. This can be sea level sunrise, visual sunrise (or
      *            any arbitrary start of day) passed to this method.
-     * @param endOfDay
+     * @param {Temporal.ZonedDateTime | null} endOfDay
      *            the end of day for calculating the sun's transit. This can be sea level sunset, visual sunset (or any
      *            arbitrary end of day) passed to this method.
      *
-     * @return the <code>Date</code> representing Sun's transit. If the calculation can't be computed such as in the
+     * @return {Temporal.ZonedDateTime | null} The `Date` representing Sun's transit. If the calculation can't be computed such as in the
      *         Arctic Circle where there is at least one day a year where the sun does not rise, and one where it does
      *         not set, null will be returned. See detailed explanation on top of the page.
      */
@@ -596,13 +628,13 @@ class NOAACalculator {
         return NOAACalculator.getTimeOffset(startOfDay, temporalHour * 6);
     }
     /**
-     * A method that returns a <code>Date</code> from the time passed in as a parameter.
+     * A method that returns a `Date` from the time passed in as a parameter.
      * @protected
-     * @param time
-     *            The time to be set as the time for the <code>Date</code>. The time expected is in the format: 18.75
+     * @param {number} time
+     *            The time to be set as the time for the `Date`. The time expected is in the format: 18.75
      *            for 6:45:00 PM.
-     * @param isSunrise true if the time is sunrise, and false if it is sunset
-     * @return The Date.
+     * @param {boolean} isSunrise true if the time is sunrise, and false if it is sunset
+     * @return {Temporal.ZonedDateTime | null} The Date.
      */
     getDateFromTime(time, isSunrise) {
         if (Number.isNaN(time)) {
@@ -637,7 +669,7 @@ class NOAACalculator {
     /**
      * Return the <a href="http://en.wikipedia.org/wiki/Julian_day">Julian day</a> from a Java Calendar
      * @private
-     * @param calendar
+     * @param {Temporal.ZonedDateTime} date
      *            The Java Calendar
      * @return the Julian day corresponding to the date Note: Number is returned for start of day. Fractional days
      *         should be added later.
@@ -833,11 +865,11 @@ class NOAACalculator {
      * Return the <a href="http://en.wikipedia.org/wiki/Hour_angle">hour angle</a> of the sun at sunrise for the
      * latitude.
      * @private
-     * @param lat
+     * @param {number} lat
      *            , the latitude of observer in degrees
      * @param solarDec
      *            the declination angle of sun in degrees
-     * @param zenith
+     * @param {number} zenith
      *            the zenith
      * @return hour angle of sunrise in radians
      */
@@ -853,11 +885,11 @@ class NOAACalculator {
      * latitude. TODO: use - {@link #getSunHourAngleAtSunrise(double, double, double)} implementation to avoid
      * duplication of code.
      * @private
-     * @param lat
+     * @param {number} lat
      *            the latitude of observer in degrees
      * @param solarDec
      *            the declination angle of sun in degrees
-     * @param zenith
+     * @param {number} zenith
      *            the zenith
      * @return the hour angle of sunset in radians
      */
@@ -874,13 +906,13 @@ class NOAACalculator {
      * horizontal coordinate system at the given location at the given time. Can be negative if the sun is below the
      * horizon. Not corrected for altitude.
      *
-     * @param cal
+     * @param {Temporal.ZonedDateTime} date
      *            time of calculation
-     * @param lat
+     * @param {number} lat
      *            latitude of location for calculation
-     * @param lon
+     * @param {number} lon
      *            longitude of location for calculation
-     * @return solar elevation in degrees - horizon is 0 degrees, civil twilight is -6 degrees
+     * @return {number} solar elevation in degrees - horizon is 0 degrees, civil twilight is -6 degrees
      */
     static getSolarElevation(date, lat, lon) {
         const julianDay = NOAACalculator.getJulianDay(date.toPlainDate());
@@ -900,13 +932,13 @@ class NOAACalculator {
      * horizontal coordinate system at the given location at the given time. Not corrected for altitude. True south is 0
      * degrees.
      *
-     * @param cal
+     * @param {Temporal.ZonedDateTime} date
      *            time of calculation
-     * @param latitude
+     * @param {number} latitude
      *            latitude of location for calculation
-     * @param lon
+     * @param {number} lon
      *            longitude of location for calculation
-     * @return FIXME
+     * @return {number}
      */
     static getSolarAzimuth(date, latitude, lon) {
         const julianDay = NOAACalculator.getJulianDay(date.toPlainDate());
@@ -928,11 +960,11 @@ class NOAACalculator {
      * @private
      * @param julianDay
      *            the Julian day
-     * @param latitude
+     * @param {number} latitude
      *            the latitude of observer in degrees
-     * @param longitude
+     * @param {number} longitude
      *            the longitude of observer in degrees
-     * @param zenith
+     * @param {number} zenith
      *            the zenith
      * @return the time in minutes from zero UTC
      */
@@ -967,7 +999,7 @@ class NOAACalculator {
      * @private
      * @param julianCenturies
      *            the number of Julian centuries since J2000.0
-     * @param longitude
+     * @param {number} longitude
      *            the longitude of observer in degrees
      * @return the time in minutes from zero UTC
      */
@@ -989,11 +1021,11 @@ class NOAACalculator {
      * @private
      * @param julianDay
      *            the Julian day
-     * @param latitude
+     * @param {number} latitude
      *            the latitude of observer in degrees
-     * @param longitude
+     * @param {number} longitude
      *            : longitude of observer in degrees
-     * @param zenith
+     * @param {number} zenith
      *            the zenith
      * @return the time in minutes from zero Universal Coordinated Time (UTC)
      */