@hebcal/noaa 0.8.1 → 0.8.3

package/dist/cjs/index.js

@@ -119,16 +119,19 @@ exports.GeoLocation = GeoLocation;
 /**
  * The commonly used average solar refraction. Calendrical Calculations lists a more accurate global average of
  * 34.478885263888294
+ * @private
  */
 const refraction = 34 / 60;
 // private double refraction = 34.478885263888294 / 60d;
 /**
  * The commonly used average solar radius in minutes of a degree.
+ * @private
  */
 const solarRadius = 16 / 60;
 /**
  * The commonly used average earth radius in KM. At this time, this only affects elevation adjustment and not the
  * sunrise and sunset calculations. The value currently defaults to 6356.9 KM.
+ * @private
  */
 const earthRadius = 6356.9; // in KM
 /**
@@ -429,7 +432,7 @@ class NOAACalculator {
     }
     /**
      * Adjusts the <code>Calendar</code> to deal with edge cases where the location crosses the antimeridian.
-     *
+     * @private
      * @see GeoLocation#getAntimeridianAdjustment()
      * @return the adjusted Calendar
      */
@@ -567,7 +570,8 @@ class NOAACalculator {
         if (startOfday === null || endOfDay === null) {
             return Long_MIN_VALUE;
         }
-        return (endOfDay.valueOf() - startOfday.valueOf()) / 12;
+        const delta = endOfDay.epochMilliseconds - startOfday.epochMilliseconds;
+        return Math.floor(delta / 12);
     }
     /**
      * A method that returns sundial or solar noon. It occurs when the Sun is <a href
@@ -593,7 +597,7 @@ class NOAACalculator {
     }
     /**
      * A method that returns a <code>Date</code> from the time passed in as a parameter.
-     *
+     * @protected
      * @param time
      *            The time to be set as the time for the <code>Date</code>. The time expected is in the format: 18.75
      *            for 6:45:00 PM.
@@ -632,7 +636,7 @@ class NOAACalculator {
     }
     /**
      * Return the <a href="http://en.wikipedia.org/wiki/Julian_day">Julian day</a> from a Java Calendar
-     *
+     * @private
      * @param calendar
      *            The Java Calendar
      * @return the Julian day corresponding to the date Note: Number is returned for start of day. Fractional days
@@ -655,7 +659,7 @@ class NOAACalculator {
     }
     /**
      * Convert <a href="http://en.wikipedia.org/wiki/Julian_day">Julian day</a> to centuries since J2000.0.
-     *
+     * @private
      * @param julianDay
      *            the Julian Day to convert
      * @return the centuries since 2000 Julian corresponding to the Julian Day
@@ -666,7 +670,7 @@ class NOAACalculator {
     }
     /**
      * Convert centuries since J2000.0 to <a href="http://en.wikipedia.org/wiki/Julian_day">Julian day</a>.
-     *
+     * @private
      * @param julianCenturies
      *            the number of Julian centuries since J2000.0
      * @return the Julian Day corresponding to the Julian centuries passed in
@@ -677,7 +681,7 @@ class NOAACalculator {
     }
     /**
      * Returns the Geometric <a href="http://en.wikipedia.org/wiki/Mean_longitude">Mean Longitude</a> of the Sun.
-     *
+     * @private
      * @param julianCenturies
      *            the number of Julian centuries since J2000.0
      * @return the Geometric Mean Longitude of the Sun in degrees
@@ -694,7 +698,7 @@ class NOAACalculator {
     }
     /**
      * Returns the Geometric <a href="http://en.wikipedia.org/wiki/Mean_anomaly">Mean Anomaly</a> of the Sun.
-     *
+     * @private
      * @param julianCenturies
      *            the number of Julian centuries since J2000.0
      * @return the Geometric Mean Anomaly of the Sun in degrees
@@ -704,7 +708,7 @@ class NOAACalculator {
     }
     /**
      * Return the <a href="http://en.wikipedia.org/wiki/Eccentricity_%28orbit%29">eccentricity of earth's orbit</a>.
-     *
+     * @private
      * @param julianCenturies
      *            the number of Julian centuries since J2000.0
      * @return the unitless eccentricity
@@ -715,7 +719,7 @@ class NOAACalculator {
     }
     /**
      * Returns the <a href="http://en.wikipedia.org/wiki/Equation_of_the_center">equation of center</a> for the sun.
-     *
+     * @private
      * @param julianCenturies
      *            the number of Julian centuries since J2000.0
      * @return the equation of center for the sun in degrees
@@ -733,7 +737,7 @@ class NOAACalculator {
     }
     /**
      * Return the true longitude of the sun
-     *
+     * @private
      * @param julianCenturies
      *            the number of Julian centuries since J2000.0
      * @return the sun's true longitude in degrees
@@ -743,22 +747,9 @@ class NOAACalculator {
         const center = NOAACalculator.getSunEquationOfCenter(julianCenturies);
         return sunLongitude + center; // in degrees
     }
-    // /**
-    // * Returns the <a href="http://en.wikipedia.org/wiki/True_anomaly">true anamoly</a> of the sun.
-    // *
-    // * @param julianCenturies
-    // * the number of Julian centuries since J2000.0
-    // * @return the sun's true anamoly in degrees
-    // */
-    // private static double getSunTrueAnomaly(double julianCenturies) {
-    // double meanAnomaly = getSunGeometricMeanAnomaly(julianCenturies);
-    // double equationOfCenter = getSunEquationOfCenter(julianCenturies);
-    //
-    // return meanAnomaly + equationOfCenter; // in degrees
-    // }
     /**
      * Return the apparent longitude of the sun
-     *
+     * @private
      * @param julianCenturies
      *            the number of Julian centuries since J2000.0
      * @return sun's apparent longitude in degrees
@@ -771,7 +762,7 @@ class NOAACalculator {
     }
     /**
      * Returns the mean <a href="http://en.wikipedia.org/wiki/Axial_tilt">obliquity of the ecliptic</a> (Axial tilt).
-     *
+     * @private
      * @param julianCenturies
      *            the number of Julian centuries since J2000.0
      * @return the mean obliquity in degrees
@@ -785,7 +776,7 @@ class NOAACalculator {
     /**
      * Returns the corrected <a href="http://en.wikipedia.org/wiki/Axial_tilt">obliquity of the ecliptic</a> (Axial
      * tilt).
-     *
+     * @private
      * @param julianCenturies
      *            the number of Julian centuries since J2000.0
      * @return the corrected obliquity in degrees
@@ -797,7 +788,7 @@ class NOAACalculator {
     }
     /**
      * Return the <a href="http://en.wikipedia.org/wiki/Declination">declination</a> of the sun.
-     *
+     * @private
      * @param julianCenturies
      *            the number of Julian centuries since J2000.0
      * @return
@@ -814,7 +805,7 @@ class NOAACalculator {
     /**
      * Return the <a href="http://en.wikipedia.org/wiki/Equation_of_time">Equation of Time</a> - the difference between
      * true solar time and mean solar time
-     *
+     * @private
      * @param julianCenturies
      *            the number of Julian centuries since J2000.0
      * @return equation of time in minutes of time
@@ -841,7 +832,7 @@ class NOAACalculator {
     /**
      * Return the <a href="http://en.wikipedia.org/wiki/Hour_angle">hour angle</a> of the sun at sunrise for the
      * latitude.
-     *
+     * @private
      * @param lat
      *            , the latitude of observer in degrees
      * @param solarDec
@@ -861,7 +852,7 @@ class NOAACalculator {
      * Returns the <a href="http://en.wikipedia.org/wiki/Hour_angle">hour angle</a> of the sun at sunset for the
      * latitude. TODO: use - {@link #getSunHourAngleAtSunrise(double, double, double)} implementation to avoid
      * duplication of code.
-     *
+     * @private
      * @param lat
      *            the latitude of observer in degrees
      * @param solarDec
@@ -934,7 +925,7 @@ class NOAACalculator {
     /**
      * Return the <a href="http://en.wikipedia.org/wiki/Universal_Coordinated_Time">Universal Coordinated Time</a> (UTC)
      * of sunrise for the given day at the given location on earth
-     *
+     * @private
      * @param julianDay
      *            the Julian day
      * @param latitude
@@ -973,7 +964,7 @@ class NOAACalculator {
      * Return the <a href="http://en.wikipedia.org/wiki/Universal_Coordinated_Time">Universal Coordinated Time</a> (UTC)
      * of <a href="http://en.wikipedia.org/wiki/Noon#Solar_noon">solar noon</a> for the given day at the given location
      * on earth.
-     *
+     * @private
      * @param julianCenturies
      *            the number of Julian centuries since J2000.0
      * @param longitude
@@ -995,7 +986,7 @@ class NOAACalculator {
     /**
      * Return the <a href="http://en.wikipedia.org/wiki/Universal_Coordinated_Time">Universal Coordinated Time</a> (UTC)
      * of sunset for the given day at the given location on earth
-     *
+     * @private
      * @param julianDay
      *            the Julian day
      * @param latitude
@@ -1034,6 +1025,7 @@ class NOAACalculator {
 exports.NOAACalculator = NOAACalculator;
 /**
  * The zenith of astronomical sunrise and sunset. The sun is 90&deg; from the vertical 0&deg;
+ * @private
  */
 NOAACalculator.GEOMETRIC_ZENITH = 90;
 /**
@@ -1056,9 +1048,11 @@ NOAACalculator.NAUTICAL_ZENITH = 102;
 NOAACalculator.ASTRONOMICAL_ZENITH = 108;
 /**
  * The <a href="http://en.wikipedia.org/wiki/Julian_day">Julian day</a> of January 1, 2000
+ * @private
  */
 NOAACalculator.JULIAN_DAY_JAN_1_2000 = 2451545;
 /**
  * Julian days per century
+ * @private
  */
 NOAACalculator.JULIAN_DAYS_PER_CENTURY = 36525;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hebcal/noaa",
-  "version": "0.8.1",
+  "version": "0.8.3",
   "description": "sunrise and sunset via NOAA algorithm with elevation, based on KosherJava",
   "author": "Michael J. Radwin (https://github.com/mjradwin)",
   "contributors": [
@@ -40,9 +40,9 @@
     "dist/*"
   ],
   "devDependencies": {
-    "@types/node": "20.9.2",
+    "@types/node": "20.9.3",
     "gts": "^5.2.0",
-    "typescript": "^5.2.2"
+    "typescript": "^5.3.2"
   },
   "dependencies": {
     "temporal-polyfill": "^0.1.1"