@headless-tree/core 0.0.0-20250630160730 → 0.0.0-20250716233347

package/CHANGELOG.md

@@ -1,6 +1,12 @@
 # @headless-tree/core
 
-## 0.0.0-20250630160730
+## 0.0.0-20250716233347
+
+### Patch Changes
+
+- b413f74: Fix `aria-posinset` and `aria-level` to be 1-based indexing
+
+## 1.2.1
 
 ### Patch Changes
 

package/lib/cjs/features/sync-data-loader/feature.js

@@ -12,9 +12,13 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.syncDataLoaderFeature = void 0;
 const utils_1 = require("../../utils");
 const errors_1 = require("../../utilities/errors");
+const undefErrorMessage = "sync dataLoader returned undefined";
 const promiseErrorMessage = "sync dataLoader returned promise";
 const unpromise = (data) => {
-    if (!data || (typeof data === "object" && "then" in data)) {
+    if (!data) {
+        throw (0, errors_1.throwError)(undefErrorMessage);
+    }
+    if (typeof data === "object" && "then" in data) {
         throw (0, errors_1.throwError)(promiseErrorMessage);
     }
     return data;

package/lib/cjs/features/tree/feature.js

@@ -107,7 +107,7 @@ exports.treeFeature = {
         getKey: ({ itemId }) => itemId, // TODO apply to all stories to use
         getProps: ({ item, prev }) => {
             const itemMeta = item.getItemMeta();
-            return Object.assign(Object.assign({}, prev === null || prev === void 0 ? void 0 : prev()), { ref: item.registerElement, role: "treeitem", "aria-setsize": itemMeta.setSize, "aria-posinset": itemMeta.posInSet, "aria-selected": "false", "aria-label": item.getItemName(), "aria-level": itemMeta.level, tabIndex: item.isFocused() ? 0 : -1, onClick: (e) => {
+            return Object.assign(Object.assign({}, prev === null || prev === void 0 ? void 0 : prev()), { ref: item.registerElement, role: "treeitem", "aria-setsize": itemMeta.setSize, "aria-posinset": itemMeta.posInSet + 1, "aria-selected": "false", "aria-label": item.getItemName(), "aria-level": itemMeta.level + 1, tabIndex: item.isFocused() ? 0 : -1, onClick: (e) => {
                     item.setFocused();
                     item.primaryAction();
                     if (e.ctrlKey || e.shiftKey || e.metaKey) {

package/lib/esm/features/sync-data-loader/feature.js

@@ -9,9 +9,13 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
 };
 import { makeStateUpdater } from "../../utils";
 import { throwError } from "../../utilities/errors";
+const undefErrorMessage = "sync dataLoader returned undefined";
 const promiseErrorMessage = "sync dataLoader returned promise";
 const unpromise = (data) => {
-    if (!data || (typeof data === "object" && "then" in data)) {
+    if (!data) {
+        throw throwError(undefErrorMessage);
+    }
+    if (typeof data === "object" && "then" in data) {
         throw throwError(promiseErrorMessage);
     }
     return data;

package/lib/esm/features/tree/feature.js

@@ -104,7 +104,7 @@ export const treeFeature = {
         getKey: ({ itemId }) => itemId, // TODO apply to all stories to use
         getProps: ({ item, prev }) => {
             const itemMeta = item.getItemMeta();
-            return Object.assign(Object.assign({}, prev === null || prev === void 0 ? void 0 : prev()), { ref: item.registerElement, role: "treeitem", "aria-setsize": itemMeta.setSize, "aria-posinset": itemMeta.posInSet, "aria-selected": "false", "aria-label": item.getItemName(), "aria-level": itemMeta.level, tabIndex: item.isFocused() ? 0 : -1, onClick: (e) => {
+            return Object.assign(Object.assign({}, prev === null || prev === void 0 ? void 0 : prev()), { ref: item.registerElement, role: "treeitem", "aria-setsize": itemMeta.setSize, "aria-posinset": itemMeta.posInSet + 1, "aria-selected": "false", "aria-label": item.getItemName(), "aria-level": itemMeta.level + 1, tabIndex: item.isFocused() ? 0 : -1, onClick: (e) => {
                     item.setFocused();
                     item.primaryAction();
                     if (e.ctrlKey || e.shiftKey || e.metaKey) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@headless-tree/core",
-  "version": "0.0.0-20250630160730",
+  "version": "0.0.0-20250716233347",
   "main": "lib/cjs/index.js",
   "module": "lib/esm/index.js",
   "types": "lib/esm/index.d.ts",

package/src/features/sync-data-loader/feature.ts

@@ -2,9 +2,13 @@ import { FeatureImplementation } from "../../types/core";
 import { makeStateUpdater } from "../../utils";
 import { throwError } from "../../utilities/errors";
 
+const undefErrorMessage = "sync dataLoader returned undefined";
 const promiseErrorMessage = "sync dataLoader returned promise";
 const unpromise = <T>(data: T | Promise<T>): T => {
-  if (!data || (typeof data === "object" && "then" in data)) {
+  if (!data) {
+    throw throwError(undefErrorMessage);
+  }
+  if (typeof data === "object" && "then" in data) {
     throw throwError(promiseErrorMessage);
   }
   return data;

package/src/features/tree/feature.ts

@@ -139,10 +139,10 @@ export const treeFeature: FeatureImplementation<any> = {
         ref: item.registerElement,
         role: "treeitem",
         "aria-setsize": itemMeta.setSize,
-        "aria-posinset": itemMeta.posInSet,
+        "aria-posinset": itemMeta.posInSet + 1,
         "aria-selected": "false",
         "aria-label": item.getItemName(),
-        "aria-level": itemMeta.level,
+        "aria-level": itemMeta.level + 1,
         tabIndex: item.isFocused() ? 0 : -1,
         onClick: (e: MouseEvent) => {
           item.setFocused();

package/src/features/tree/tree.spec.ts

@@ -235,8 +235,8 @@ describe("core-feature/selections", () => {
       it("generates item props for random item", () => {
         expect(tree.instance.getItemInstance("x2").getProps()).toEqual({
           "aria-label": "x2",
-          "aria-level": 0,
-          "aria-posinset": 1,
+          "aria-level": 1,
+          "aria-posinset": 2,
           "aria-selected": "false",
           "aria-setsize": 4,
           onClick: expect.any(Function),
@@ -249,8 +249,8 @@ describe("core-feature/selections", () => {
       it("generates item props for focused", () => {
         expect(tree.instance.getItemInstance("x1").getProps()).toEqual({
           "aria-label": "x1",
-          "aria-level": 0,
-          "aria-posinset": 0,
+          "aria-level": 1,
+          "aria-posinset": 1,
           "aria-selected": "false",
           "aria-setsize": 4,
           onClick: expect.any(Function),