@headless-tree/core 0.0.0-20250415151520 → 0.0.0-20250426160300

package/CHANGELOG.md

@@ -1,6 +1,12 @@
 # @headless-tree/core
 
-## 0.0.0-20250415151520
+## 0.0.0-20250426160300
+
+### Patch Changes
+
+- 6ed84b4: recursive item references are filtered out when rendering (#89)
+
+## 1.0.0
 
 ### Minor Changes
 

package/lib/cjs/features/hotkeys-core/feature.js

@@ -30,7 +30,6 @@ exports.hotkeysCoreFeature = {
             (_a = (_e = data.current).pressedKeys) !== null && _a !== void 0 ? _a : (_e.pressedKeys = new Set());
             const newMatch = !data.current.pressedKeys.has(e.key);
             data.current.pressedKeys.add(e.key);
-            console.log("HOTKEYS", data.current.pressedKeys);
             const hotkeyName = findHotkeyMatch(data.current.pressedKeys, tree, tree.getHotkeyPresets(), tree.getConfig().hotkeys);
             if (!hotkeyName)
                 return;

package/lib/cjs/features/tree/feature.js

@@ -11,6 +11,7 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.treeFeature = void 0;
 const utils_1 = require("../../utils");
+const errors_1 = require("../../utilities/errors");
 exports.treeFeature = {
     key: "tree",
     getInitialState: (initialState) => (Object.assign({ expandedItems: [], focusedItem: null }, initialState)),
@@ -25,13 +26,17 @@ exports.treeFeature = {
             const { expandedItems } = tree.getState();
             const flatItems = [];
             const expandedItemsSet = new Set(expandedItems); // TODO support setting state expandedItems as set instead of array
-            const recursiveAdd = (itemId, parentId, level, setSize, posInSet) => {
+            const recursiveAdd = (itemId, path, level, setSize, posInSet) => {
                 var _a;
+                if (path.includes(itemId)) {
+                    (0, errors_1.logWarning)(`Circular reference for ${path.join(".")}`);
+                    return;
+                }
                 flatItems.push({
                     itemId,
                     level,
                     index: flatItems.length,
-                    parentId,
+                    parentId: path.at(-1),
                     setSize,
                     posInSet,
                 });
@@ -39,14 +44,14 @@ exports.treeFeature = {
                     const children = (_a = tree.retrieveChildrenIds(itemId)) !== null && _a !== void 0 ? _a : [];
                     let i = 0;
                     for (const childId of children) {
-                        recursiveAdd(childId, itemId, level + 1, children.length, i++);
+                        recursiveAdd(childId, path.concat(itemId), level + 1, children.length, i++);
                     }
                 }
             };
             const children = tree.retrieveChildrenIds(rootItemId);
             let i = 0;
             for (const itemId of children) {
-                recursiveAdd(itemId, rootItemId, 0, children.length, i++);
+                recursiveAdd(itemId, [rootItemId], 0, children.length, i++);
             }
             return flatItems;
         },

package/lib/cjs/utilities/errors.d.ts

@@ -1 +1,2 @@
 export declare const throwError: (message: string) => Error;
+export declare const logWarning: (message: string) => void;

package/lib/cjs/utilities/errors.js

@@ -1,5 +1,9 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.throwError = void 0;
-const throwError = (message) => Error(`Headless Tree: ${message}`);
+exports.logWarning = exports.throwError = void 0;
+const prefix = "Headless Tree: ";
+const throwError = (message) => Error(prefix + message);
 exports.throwError = throwError;
+// eslint-disable-next-line no-console
+const logWarning = (message) => console.warn(prefix + message);
+exports.logWarning = logWarning;

package/lib/esm/features/hotkeys-core/feature.js

@@ -27,7 +27,6 @@ export const hotkeysCoreFeature = {
             (_a = (_e = data.current).pressedKeys) !== null && _a !== void 0 ? _a : (_e.pressedKeys = new Set());
             const newMatch = !data.current.pressedKeys.has(e.key);
             data.current.pressedKeys.add(e.key);
-            console.log("HOTKEYS", data.current.pressedKeys);
             const hotkeyName = findHotkeyMatch(data.current.pressedKeys, tree, tree.getHotkeyPresets(), tree.getConfig().hotkeys);
             if (!hotkeyName)
                 return;

package/lib/esm/features/tree/feature.js

@@ -8,6 +8,7 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
     });
 };
 import { makeStateUpdater, poll } from "../../utils";
+import { logWarning } from "../../utilities/errors";
 export const treeFeature = {
     key: "tree",
     getInitialState: (initialState) => (Object.assign({ expandedItems: [], focusedItem: null }, initialState)),
@@ -22,13 +23,17 @@ export const treeFeature = {
             const { expandedItems } = tree.getState();
             const flatItems = [];
             const expandedItemsSet = new Set(expandedItems); // TODO support setting state expandedItems as set instead of array
-            const recursiveAdd = (itemId, parentId, level, setSize, posInSet) => {
+            const recursiveAdd = (itemId, path, level, setSize, posInSet) => {
                 var _a;
+                if (path.includes(itemId)) {
+                    logWarning(`Circular reference for ${path.join(".")}`);
+                    return;
+                }
                 flatItems.push({
                     itemId,
                     level,
                     index: flatItems.length,
-                    parentId,
+                    parentId: path.at(-1),
                     setSize,
                     posInSet,
                 });
@@ -36,14 +41,14 @@ export const treeFeature = {
                     const children = (_a = tree.retrieveChildrenIds(itemId)) !== null && _a !== void 0 ? _a : [];
                     let i = 0;
                     for (const childId of children) {
-                        recursiveAdd(childId, itemId, level + 1, children.length, i++);
+                        recursiveAdd(childId, path.concat(itemId), level + 1, children.length, i++);
                     }
                 }
             };
             const children = tree.retrieveChildrenIds(rootItemId);
             let i = 0;
             for (const itemId of children) {
-                recursiveAdd(itemId, rootItemId, 0, children.length, i++);
+                recursiveAdd(itemId, [rootItemId], 0, children.length, i++);
             }
             return flatItems;
         },

package/lib/esm/utilities/errors.d.ts

@@ -1 +1,2 @@
 export declare const throwError: (message: string) => Error;
+export declare const logWarning: (message: string) => void;

package/lib/esm/utilities/errors.js

@@ -1 +1,4 @@
-export const throwError = (message) => Error(`Headless Tree: ${message}`);
+const prefix = "Headless Tree: ";
+export const throwError = (message) => Error(prefix + message);
+// eslint-disable-next-line no-console
+export const logWarning = (message) => console.warn(prefix + message);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@headless-tree/core",
-  "version": "0.0.0-20250415151520",
+  "version": "0.0.0-20250426160300",
   "type": "module",
   "main": "lib/cjs/index.js",
   "module": "lib/esm/index.js",

package/src/features/hotkeys-core/feature.ts

@@ -48,7 +48,6 @@ export const hotkeysCoreFeature: FeatureImplementation = {
       data.current.pressedKeys ??= new Set();
       const newMatch = !data.current.pressedKeys.has(e.key);
       data.current.pressedKeys.add(e.key);
-      console.log("HOTKEYS", data.current.pressedKeys);
 
       const hotkeyName = findHotkeyMatch(
         data.current.pressedKeys,

package/src/features/search/types.ts

@@ -22,7 +22,7 @@ export type SearchFeatureDef<T> = {
     closeSearch: () => void;
     isSearchOpen: () => boolean;
     getSearchValue: () => string;
-    registerSearchInputElement: (element: HTMLInputElement | null) => void;
+    registerSearchInputElement: (element: HTMLInputElement | null) => void; // TODO remove
     getSearchInputElement: () => HTMLInputElement | null;
     getSearchInputElementProps: () => any;
     getSearchMatchingItems: () => ItemInstance<T>[];

package/src/features/tree/feature.ts

@@ -1,6 +1,7 @@
 import { FeatureImplementation, ItemInstance } from "../../types/core";
 import { ItemMeta } from "./types";
 import { makeStateUpdater, poll } from "../../utils";
+import { logWarning } from "../../utilities/errors";
 
 export const treeFeature: FeatureImplementation<any> = {
   key: "tree",
@@ -31,16 +32,21 @@ export const treeFeature: FeatureImplementation<any> = {
 
       const recursiveAdd = (
         itemId: string,
-        parentId: string,
+        path: string[],
         level: number,
         setSize: number,
         posInSet: number,
       ) => {
+        if (path.includes(itemId)) {
+          logWarning(`Circular reference for ${path.join(".")}`);
+          return;
+        }
+
         flatItems.push({
           itemId,
           level,
           index: flatItems.length,
-          parentId,
+          parentId: path.at(-1) as string,
           setSize,
           posInSet,
         });
@@ -49,7 +55,13 @@ export const treeFeature: FeatureImplementation<any> = {
           const children = tree.retrieveChildrenIds(itemId) ?? [];
           let i = 0;
           for (const childId of children) {
-            recursiveAdd(childId, itemId, level + 1, children.length, i++);
+            recursiveAdd(
+              childId,
+              path.concat(itemId),
+              level + 1,
+              children.length,
+              i++,
+            );
           }
         }
       };
@@ -57,7 +69,7 @@ export const treeFeature: FeatureImplementation<any> = {
       const children = tree.retrieveChildrenIds(rootItemId);
       let i = 0;
       for (const itemId of children) {
-        recursiveAdd(itemId, rootItemId, 0, children.length, i++);
+        recursiveAdd(itemId, [rootItemId], 0, children.length, i++);
       }
 
       return flatItems;

package/src/utilities/errors.ts

@@ -1,2 +1,6 @@
-export const throwError = (message: string) =>
-  Error(`Headless Tree: ${message}`);
+const prefix = "Headless Tree: ";
+
+export const throwError = (message: string) => Error(prefix + message);
+
+// eslint-disable-next-line no-console
+export const logWarning = (message: string) => console.warn(prefix + message);