@haystackeditor/cli 0.25.1 → 0.26.0

package/dist/commands/production-source-deny-policy.js

@@ -1,100 +0,0 @@
-// Which repository paths never reach a reviewer snapshot. Relocated verbatim
-// from the customer-replica connector protocol package when that customer-side
-// plumbing was removed: Haystack builds replicas itself, so the only consumer
-// left is `haystack skills prepare-universe-review`.
-export const CUSTOMER_REPLICA_PRODUCTION_SOURCE_DENY_POLICY = {
-    schemaVersion: 2,
-    policyId: 'haystack-production-source-no-existing-tests-v2',
-    deniedDirectoryNames: [
-        '.git', '.haystack', '.nyc_output', '.pytest_cache', '__tests__', 'acceptance-test',
-        'acceptance-tests', 'acceptance_test', 'acceptance_tests', 'cypress',
-        'e2e', 'integration-test', 'integration-tests',
-        'integration_test', 'integration_tests', 'playwright',
-        'playwright-report', 'system-test',
-        'system-tests', 'system_test', 'system_tests', 'test', 'test-data',
-        'test-results', 'testdata', 'tests',
-    ],
-    conditionalDirectoryNames: [
-        '__fixtures__', '__mocks__', '__snapshots__', 'fixtures', 'mocks',
-        'snapshots', 'spec', 'specs',
-    ],
-    conditionalDirectoryRule: 'exclude root spec/specs when a test framework is detected; exclude fixture/mock/snapshot components only below a detected test root',
-    deniedFilePatterns: [
-        '*.test.{js,jsx,ts,tsx,mjs,cjs}',
-        '*.spec.{js,jsx,ts,tsx,mjs,cjs,rb}',
-        '*.e2e.{js,jsx,ts,tsx}',
-        '*.e2e-spec.{js,jsx,ts,tsx}',
-        'test-*.{js,jsx,ts,tsx,py,rb,go,rs}',
-        '*-test.{js,jsx,ts,tsx,py,rb,go,rs}',
-        '*_test.{py,go,rs,cc,cpp}',
-        '*_tests.{py,rb}',
-        'test_*.py',
-        '*_unittest.{cc,cpp,py}',
-        '*Test.{java,kt,kts,scala,groovy,cs,php,swift}',
-        '*Tests.{java,kt,kts,scala,groovy,cs,php,swift}',
-        '*ITCase.{java,kt,kts,scala,groovy,cs,php,swift}',
-        '*.{snap,golden,approved}',
-        '{jest,vitest,playwright,cypress}.config.*',
-        'karma.conf.*', 'mocha.config.*', 'pytest.ini', 'tox.ini',
-        '.coveragerc', 'junit*.xml',
-    ],
-    inlineTestScan: {
-        maximumTextFileBytes: 2 * 1024 * 1024,
-        oversizedTextFileAction: 'reject',
-        binaryFileAction: 'retain',
-        markerRuleIds: [
-            'rust-cfg-test', 'zig-inline-test', 'vitest-import-meta',
-            'deno-inline-test', 'bun-inline-test', 'c-unit-test-conditional',
-            'rust-test-attribute', 'jvm-test-annotation',
-            'dotnet-test-attribute', 'xctest-case', 'python-unittest-case',
-            'python-test-function',
-        ],
-    },
-};
-export function isCustomerReplicaProductionSourceDeniedPath(path) {
-    const components = path.split('/');
-    if (components.slice(0, -1).some(component => CUSTOMER_REPLICA_PRODUCTION_SOURCE_DENY_POLICY.deniedDirectoryNames
-        .some(denied => denied === component.toLowerCase())))
-        return true;
-    const name = components[components.length - 1];
-    const lowerName = name.toLowerCase();
-    const dot = name.lastIndexOf('.');
-    const stem = dot > 0 && dot < name.length - 1 ? name.slice(0, dot) : name;
-    const extension = dot > 0 && dot < name.length - 1
-        ? name.slice(dot + 1).toLowerCase()
-        : '';
-    const lowerStem = stem.toLowerCase();
-    const js = new Set(['js', 'jsx', 'ts', 'tsx', 'mjs', 'cjs']);
-    if (js.has(extension) && /\.(?:test|e2e|e2e-spec)$/i.test(stem))
-        return true;
-    if ((js.has(extension) || extension === 'rb') && /\.spec$/i.test(stem)) {
-        return true;
-    }
-    if (new Set([...js, 'py', 'rb', 'go', 'rs']).has(extension)
-        && (lowerStem.startsWith('test-') || lowerStem.endsWith('-test')))
-        return true;
-    if (new Set(['py', 'go', 'rs', 'cc', 'cpp']).has(extension)
-        && lowerStem.endsWith('_test'))
-        return true;
-    if (new Set(['py', 'rb']).has(extension) && lowerStem.endsWith('_tests')) {
-        return true;
-    }
-    if (extension === 'py' && lowerStem.startsWith('test_'))
-        return true;
-    if (new Set(['cc', 'cpp', 'py']).has(extension)
-        && lowerStem.endsWith('_unittest'))
-        return true;
-    if (new Set(['java', 'kt', 'kts', 'scala', 'groovy', 'cs', 'php', 'swift'])
-        .has(extension)
-        && (stem.endsWith('Test') || stem.endsWith('Tests') || stem.endsWith('ITCase')))
-        return true;
-    if (new Set(['snap', 'golden', 'approved']).has(extension))
-        return true;
-    if (/^(?:jest|vitest|playwright|cypress)\.config\..+$/i.test(name))
-        return true;
-    if (/^karma\.conf\..+$/i.test(name) || /^mocha\.config\..+$/i.test(name)) {
-        return true;
-    }
-    return new Set(['.coveragerc', 'pytest.ini', 'tox.ini']).has(lowerName)
-        || /^junit.*\.xml$/i.test(name);
-}

package/dist/commands/request-review.js

@@ -1,74 +0,0 @@
-/**
- * request-review command — Tag a PR as needing human review after creation.
- *
- * haystack request-review <pr> [reviewer]
- *
- * Adds the `haystack:needs-review` label to the PR. Optionally requests
- * review from a specific GitHub user. The PR will move to the
- * "Needs Assignment" or "Awaiting Review" bucket in the Haystack feed.
- *
- * Accepts a PR identifier in several formats:
- *   123                                    # Uses current repo's owner/repo
- *   owner/repo#123                         # Fully qualified
- *   https://github.com/owner/repo/pull/123 # GitHub URL
- */
-import chalk from 'chalk';
-import { emitActionPayload, failAction } from '../utils/action-output.js';
-import { resolveAuthContext } from '../utils/auth.js';
-import { parsePrRef } from '../utils/pr-ref.js';
-import { ensureHaystackLabels, addLabelsToIssue, requestReviewers, } from '../utils/github-api.js';
-/** Apply the needs-review label (and optional reviewer). Throws on failure. */
-export async function performRequestReview(identifier, reviewer) {
-    const pr = parsePrRef(identifier, 'request-review');
-    const authContext = await resolveAuthContext({ owner: pr.owner, repo: pr.repo });
-    const ref = `${pr.owner}/${pr.repo}#${pr.prNumber}`;
-    await ensureHaystackLabels(pr.owner, pr.repo, ['haystack:needs-review'], authContext.token);
-    await addLabelsToIssue(pr.owner, pr.repo, pr.prNumber, ['haystack:needs-review'], authContext.token);
-    let reviewerRequestFailed = null;
-    if (reviewer) {
-        try {
-            await requestReviewers(pr.owner, pr.repo, pr.prNumber, [reviewer], authContext.token);
-        }
-        catch (err) {
-            // Label was added successfully, just the reviewer request failed —
-            // report the partial outcome instead of failing the whole action.
-            reviewerRequestFailed = err.message;
-        }
-    }
-    return {
-        action: 'request_review',
-        status: 'ok',
-        ref,
-        reviewer: reviewer && !reviewerRequestFailed ? reviewer : null,
-        reviewer_request_failed: reviewerRequestFailed,
-        detail: reviewer && !reviewerRequestFailed
-            ? `Review requested from ${reviewer}; the PR moves to the "Needs Assignment" queue.`
-            : 'PR marked for human review; it moves to the "Needs Assignment" queue.',
-    };
-}
-export async function requestReviewCommand(identifier, reviewer, options = {}) {
-    if (!options.json)
-        console.log(chalk.dim(`\nRequesting review for ${identifier}...`));
-    let payload;
-    try {
-        payload = await performRequestReview(identifier, reviewer);
-    }
-    catch (err) {
-        failAction(options.json, 'request_review', null, err.message);
-        return; // unreachable — satisfies TS narrowing
-    }
-    if (options.json) {
-        emitActionPayload(payload);
-        return;
-    }
-    if (payload.reviewer) {
-        console.log(chalk.green(`\n  Review requested from ${payload.reviewer} on ${payload.ref}`));
-    }
-    else {
-        console.log(chalk.green(`\n  Marked ${payload.ref} for human review`));
-        if (payload.reviewer_request_failed) {
-            console.log(chalk.yellow(`  Could not request reviewer "${reviewer}": ${payload.reviewer_request_failed}`));
-        }
-    }
-    console.log(chalk.dim('  The PR will appear in the "Needs Assignment" queue in the feed.\n'));
-}

package/dist/commands/review.js

@@ -1,191 +0,0 @@
-/**
- * review command — Trigger a fresh Haystack analysis for a PR.
- *
- * haystack review [pr] [--no-wait]
- *
- * Haystack runs a full analysis when a PR is opened (or marked ready);
- * later pushes only get a resolution check against the existing findings.
- * This command is the explicit escape hatch: it re-runs full detection on
- * the PR's current head — use it after substantial new commits, or any
- * time you want a fresh second opinion.
- *
- * When called without a PR identifier, reads the last submitted PR from
- * `.haystack/pending-submit.json` (written by `haystack submit`).
- *
- * Accepts a PR identifier in several formats:
- *   haystack review                      # Last submitted PR
- *   haystack review 123                  # Uses current repo's owner/repo
- *   haystack review owner/repo#123       # Fully qualified
- *   haystack review https://github.com/owner/repo/pull/123
- */
-import chalk from 'chalk';
-import { emitActionPayload, failAction } from '../utils/action-output.js';
-import { triggerAnalysis, fetchTriggerStatus } from '../utils/analysis-api.js';
-import { fetchTriageHeadSha } from './triage.js';
-import { loadToken } from '../utils/auth.js';
-import { loadPendingSubmit } from '../utils/pending-state.js';
-import { parsePrRef } from '../utils/pr-ref.js';
-import { triageCommand } from './triage.js';
-// ============================================================================
-// Constants
-// ============================================================================
-const STATUS_POLL_INTERVAL_MS = 10_000;
-// Full analyses regularly take 10+ minutes on large PRs; this bounds the
-// CLI's wait, not the analysis itself (results land on the feed regardless).
-const STATUS_POLL_TIMEOUT_MS = 25 * 60 * 1000;
-function resolvePR(identifier, json) {
-    if (identifier) {
-        try {
-            return parsePrRef(identifier, 'review');
-        }
-        catch (err) {
-            failAction(json, 'trigger_review', null, err.message);
-        }
-    }
-    const pending = loadPendingSubmit();
-    if (!pending) {
-        console.log(chalk.dim('No pending submits. Pass a PR number to review a specific PR.\n'));
-        return null;
-    }
-    return { owner: pending.owner, repo: pending.repo, prNumber: pending.prNumber };
-}
-// ============================================================================
-// Waiting
-// ============================================================================
-async function waitForRun(requestId, token) {
-    const deadline = Date.now() + STATUS_POLL_TIMEOUT_MS;
-    let consecutiveErrors = 0;
-    while (Date.now() < deadline) {
-        const result = await fetchTriggerStatus(requestId, token);
-        if (result.status === 'COMPLETED')
-            return 'completed';
-        if (result.status === 'FAILED')
-            return 'failed';
-        if (result.status === 'SUPERSEDED')
-            return 'superseded';
-        if (result.status === 'error') {
-            consecutiveErrors++;
-            if (consecutiveErrors >= 5)
-                return 'failed';
-        }
-        else {
-            consecutiveErrors = 0;
-        }
-        process.stderr.write(`\r  ${chalk.dim('Analysis in progress...')}${'  '.repeat(5)}`);
-        // Deliberately NOT unref'd: during the wait this timer can be the only
-        // live handle, and an unref'd timer lets Node exit mid-wait.
-        await new Promise((resolve) => {
-            setTimeout(resolve, STATUS_POLL_INTERVAL_MS);
-        });
-    }
-    return 'timeout';
-}
-// ============================================================================
-// Main command
-// ============================================================================
-export async function reviewCommand(identifier, options) {
-    if (options.json && identifier === undefined && !loadPendingSubmit()) {
-        failAction(true, 'trigger_review', null, 'No pending submit to review. Pass a PR identifier: haystack review owner/repo#123 --json');
-    }
-    const pr = resolvePR(identifier, options.json);
-    if (!pr)
-        return;
-    const prLabel = `${pr.owner}/${pr.repo}#${pr.prNumber}`;
-    let token = null;
-    try {
-        token = await loadToken({ owner: pr.owner, repo: pr.repo });
-    }
-    catch (err) {
-        failAction(options.json, 'trigger_review', prLabel, `Could not load Haystack credentials: ${err.message}`);
-    }
-    if (!token) {
-        failAction(options.json, 'trigger_review', prLabel, 'Triggering an analysis requires authentication. Run `haystack login` first.');
-        return; // unreachable — satisfies TS narrowing
-    }
-    if (!options.json)
-        console.log(chalk.dim(`\nRequesting a fresh analysis for ${prLabel}...`));
-    // Resolve the current head so ingestion's dedup compares commits — an
-    // in-flight run for an OLDER head must be superseded, not reused. A
-    // failed metadata fetch degrades to a head-less trigger (the dedup is a
-    // freshness aid, not a correctness requirement) instead of crashing.
-    let headSha;
-    try {
-        headSha = await fetchTriageHeadSha(pr, token) ?? undefined;
-    }
-    catch (err) {
-        console.error(chalk.dim(`  Could not resolve the PR head (${err.message}) — continuing without it.`));
-    }
-    const trigger = await triggerAnalysis(pr.owner, pr.repo, pr.prNumber, token, headSha);
-    if (trigger.status === 'rate_limited') {
-        const retryHint = trigger.retryAfterSeconds
-            ? ` Try again in ~${Math.ceil(trigger.retryAfterSeconds / 60)} minute(s).`
-            : '';
-        failAction(options.json, 'trigger_review', prLabel, `${trigger.message}${retryHint}`);
-    }
-    if (trigger.status === 'denied') {
-        failAction(options.json, 'trigger_review', prLabel, trigger.message);
-    }
-    if (trigger.status === 'error') {
-        failAction(options.json, 'trigger_review', prLabel, `Failed to trigger analysis: ${trigger.message}`);
-        return; // unreachable — satisfies TS narrowing
-    }
-    if (!options.json) {
-        if (trigger.status === 'already_processing') {
-            console.log(chalk.yellow('  An analysis for this PR is already running — waiting on it instead.'));
-        }
-        else {
-            console.log(chalk.green('  Analysis started.'));
-        }
-    }
-    /** One envelope for every terminal state of the trigger. */
-    const emitJson = (runStatus, detail, done) => {
-        emitActionPayload({
-            action: 'trigger_review',
-            status: 'ok',
-            ref: prLabel,
-            detail,
-            request_id: trigger.requestId,
-            run_status: runStatus,
-            next: done ? `haystack triage ${prLabel} --json` : null,
-        });
-    };
-    if (options.wait === false) {
-        if (options.json) {
-            emitJson(trigger.status, 'Analysis triggered; not waiting for completion.', true);
-            return;
-        }
-        console.log(chalk.dim('  Check results later with: ') + chalk.cyan(`haystack triage ${prLabel}`));
-        console.log(chalk.dim('  Or view the review: ') + chalk.cyan(`https://haystackeditor.com/review/${pr.owner}/${pr.repo}/${pr.prNumber}\n`));
-        return;
-    }
-    const outcome = await waitForRun(trigger.requestId, token);
-    process.stderr.write('\r' + ' '.repeat(60) + '\r');
-    if (outcome === 'failed') {
-        failAction(options.json, 'trigger_review', prLabel, `Analysis run failed. Check the review page: https://haystackeditor.com/review/${pr.owner}/${pr.repo}/${pr.prNumber}`);
-    }
-    if (outcome === 'superseded') {
-        if (options.json) {
-            emitJson('superseded', 'This run was superseded by a newer analysis (a push likely landed meanwhile). The latest results stand.', true);
-            return;
-        }
-        console.log(chalk.yellow('\n  This run was superseded by a newer analysis (a push likely landed meanwhile).'));
-        console.log(chalk.dim('  Showing the latest results instead.'));
-        await triageCommand(prLabel, { wait: false });
-        return;
-    }
-    if (outcome === 'timeout') {
-        if (options.json) {
-            emitJson('running', 'Still running after 25 minutes; the analysis continues server-side.', true);
-            return;
-        }
-        console.log(chalk.yellow('\n  Still running after 25 minutes — giving up on waiting.'));
-        console.log(chalk.dim('  Check results later with: ') + chalk.cyan(`haystack triage ${prLabel}\n`));
-        return;
-    }
-    // Completed — render results through the triage view (no extra wait).
-    if (options.json) {
-        emitJson('completed', 'Analysis completed.', true);
-        return;
-    }
-    await triageCommand(prLabel, { wait: false });
-}

package/dist/commands/rules.js

@@ -1,98 +0,0 @@
-/**
- * `haystack rules edit|validate` — manage .haystack/pr-rules.yml.
- *
- * Why local, not server-round-trip:
- *   pr-rules.yml is the source of truth, checked into the repo. The CLI's job
- *   is to make it ergonomic to edit (open in $EDITOR) and to fail loudly if
- *   the file would break the server-side parser (`packages/custom-rules`).
- *   The same parser is used here so "validate passes locally" == "won't
- *   break the next PR analysis."
- */
-import { existsSync, mkdirSync, readFileSync, writeFileSync, statSync } from 'node:fs';
-import { spawnSync } from 'node:child_process';
-import { resolve, dirname } from 'node:path';
-import chalk from 'chalk';
-const RULES_PATH = '.haystack/pr-rules.yml';
-const STARTER_YAML = `version: 1
-
-rules:
-  # Replace with your own rules. Each rule is either type: llm (judged by an
-  # LLM) or type: deterministic (regex / structural). See
-  # packages/custom-rules/README.md for the full schema.
-  - id: EXAMPLE001
-    name: Example rule
-    type: llm
-    severity: info
-    message: Replace this rule with one that matters to your team
-    llm:
-      prompt: >
-        This is a placeholder. Edit .haystack/pr-rules.yml and remove this rule.
-`;
-function rulesAbsPath() {
-    return resolve(process.cwd(), RULES_PATH);
-}
-export async function editRulesCommand() {
-    const path = rulesAbsPath();
-    if (!existsSync(path)) {
-        mkdirSync(dirname(path), { recursive: true });
-        writeFileSync(path, STARTER_YAML, 'utf8');
-        console.log(chalk.dim(`Created ${RULES_PATH} with a starter rule.`));
-    }
-    const editor = process.env.VISUAL ?? process.env.EDITOR;
-    if (!editor) {
-        console.error(chalk.red('No $EDITOR or $VISUAL set.') +
-            `\nOpen ${chalk.bold(RULES_PATH)} manually, then run ` +
-            chalk.bold('haystack rules validate') + ' to check it.');
-        process.exit(2);
-    }
-    const before = statSync(path).mtimeMs;
-    const result = spawnSync(editor, [path], { stdio: 'inherit' });
-    if (result.status !== 0) {
-        console.error(chalk.red(`Editor exited with status ${result.status}.`));
-        process.exit(result.status ?? 1);
-    }
-    const after = statSync(path).mtimeMs;
-    if (after === before) {
-        console.log(chalk.dim('No changes.'));
-        return;
-    }
-    console.log(chalk.dim('Validating…'));
-    await validateRulesCommand({ silent: false });
-}
-export async function validateRulesCommand(opts = {}) {
-    const path = rulesAbsPath();
-    if (!existsSync(path)) {
-        console.error(chalk.red(`${RULES_PATH} not found.`));
-        console.error(`Run ${chalk.bold('haystack rules edit')} to create one.`);
-        process.exit(1);
-    }
-    const raw = readFileSync(path, 'utf8');
-    // Use the canonical parser. Importing dynamically keeps the CLI's hot path
-    // free of haystack-custom-rules unless this subcommand is actually run.
-    let parser = null;
-    try {
-        parser = (await import('haystack-custom-rules'));
-    }
-    catch (err) {
-        console.error(chalk.red('Could not load the rules parser (haystack-custom-rules).'), err instanceof Error ? err.message : err);
-        console.error(chalk.dim('The CLI uses the same parser as the server. If this failed, the workspace install is incomplete — run `pnpm install` from the repo root.'));
-        process.exit(1);
-    }
-    try {
-        const cfg = parser.parseRulesYaml(raw);
-        const ruleCount = cfg.rules?.length ?? 0;
-        if (!opts.silent) {
-            console.log(chalk.green(`✓ ${RULES_PATH} is valid (${ruleCount} rule${ruleCount === 1 ? '' : 's'}).`));
-        }
-    }
-    catch (err) {
-        console.error(chalk.red(`✗ ${RULES_PATH} is invalid:`));
-        if (err && typeof err === 'object' && 'message' in err) {
-            console.error(`  ${err.message}`);
-        }
-        else {
-            console.error('  ' + String(err));
-        }
-        process.exit(1);
-    }
-}