@haystackeditor/cli 0.15.18 → 0.15.20

package/dist/commands/request-review.d.ts

@@ -12,4 +12,15 @@
  *   owner/repo#123                         # Fully qualified
  *   https://github.com/owner/repo/pull/123 # GitHub URL
  */
-export declare function requestReviewCommand(identifier: string, reviewer?: string): Promise<void>;
+import { type ActionPayload } from '../utils/action-output.js';
+export interface RequestReviewPayload extends ActionPayload {
+    reviewer: string | null;
+    /** Set when the label was applied but the specific-reviewer request failed. */
+    reviewer_request_failed: string | null;
+}
+/** Apply the needs-review label (and optional reviewer). Throws on failure. */
+export declare function performRequestReview(identifier: string, reviewer?: string): Promise<RequestReviewPayload>;
+export interface RequestReviewOptions {
+    json?: boolean;
+}
+export declare function requestReviewCommand(identifier: string, reviewer?: string, options?: RequestReviewOptions): Promise<void>;

package/dist/commands/request-review.js

@@ -13,85 +13,62 @@
  *   https://github.com/owner/repo/pull/123 # GitHub URL
  */
 import chalk from 'chalk';
+import { emitActionPayload, failAction } from '../utils/action-output.js';
 import { resolveAuthContext } from '../utils/auth.js';
-import { parseRemoteUrl } from '../utils/git.js';
+import { parsePrRef } from '../utils/pr-ref.js';
 import { ensureHaystackLabels, addLabelsToIssue, requestReviewers, } from '../utils/github-api.js';
-// ============================================================================
-// PR identifier parsing (shared pattern with dismiss.ts)
-// ============================================================================
-function parsePRIdentifier(identifier) {
-    const urlMatch = identifier.match(/^https?:\/\/github\.com\/([^/]+)\/([^/]+)\/pull\/(\d+)\/?$/);
-    if (urlMatch) {
-        return { owner: urlMatch[1], repo: urlMatch[2], prNumber: parseInt(urlMatch[3], 10) };
-    }
-    const qualifiedMatch = identifier.match(/^([^/]+)\/([^#]+)#(\d+)$/);
-    if (qualifiedMatch) {
-        return { owner: qualifiedMatch[1], repo: qualifiedMatch[2], prNumber: parseInt(qualifiedMatch[3], 10) };
-    }
-    const numberMatch = identifier.match(/^#?(\d+)$/);
-    if (numberMatch) {
-        const prNumber = parseInt(numberMatch[1], 10);
+/** Apply the needs-review label (and optional reviewer). Throws on failure. */
+export async function performRequestReview(identifier, reviewer) {
+    const pr = parsePrRef(identifier, 'request-review');
+    const authContext = await resolveAuthContext({ owner: pr.owner, repo: pr.repo });
+    const ref = `${pr.owner}/${pr.repo}#${pr.prNumber}`;
+    await ensureHaystackLabels(pr.owner, pr.repo, ['haystack:needs-review'], authContext.token);
+    await addLabelsToIssue(pr.owner, pr.repo, pr.prNumber, ['haystack:needs-review'], authContext.token);
+    let reviewerRequestFailed = null;
+    if (reviewer) {
         try {
-            const remote = parseRemoteUrl('origin');
-            return { owner: remote.owner, repo: remote.repo, prNumber };
+            await requestReviewers(pr.owner, pr.repo, pr.prNumber, [reviewer], authContext.token);
         }
-        catch {
-            throw new Error(`Cannot determine repository for PR #${prNumber}.\n` +
-                `Use the full format: haystack request-review owner/repo#${prNumber}`);
+        catch (err) {
+            // Label was added successfully, just the reviewer request failed —
+            // report the partial outcome instead of failing the whole action.
+            reviewerRequestFailed = err.message;
         }
     }
-    throw new Error(`Invalid PR identifier: "${identifier}"\n\n` +
-        `Accepted formats:\n` +
-        `  haystack request-review 123\n` +
-        `  haystack request-review owner/repo#123\n` +
-        `  haystack request-review https://github.com/owner/repo/pull/123`);
+    return {
+        action: 'request_review',
+        status: 'ok',
+        ref,
+        reviewer: reviewer && !reviewerRequestFailed ? reviewer : null,
+        reviewer_request_failed: reviewerRequestFailed,
+        detail: reviewer && !reviewerRequestFailed
+            ? `Review requested from ${reviewer}; the PR moves to the "Needs Assignment" queue.`
+            : 'PR marked for human review; it moves to the "Needs Assignment" queue.',
+    };
 }
-// ============================================================================
-// Main command
-// ============================================================================
-export async function requestReviewCommand(identifier, reviewer) {
-    // Parse PR identifier
-    let pr;
+export async function requestReviewCommand(identifier, reviewer, options = {}) {
+    if (!options.json)
+        console.log(chalk.dim(`\nRequesting review for ${identifier}...`));
+    let payload;
     try {
-        pr = parsePRIdentifier(identifier);
+        payload = await performRequestReview(identifier, reviewer);
     }
     catch (err) {
-        console.error(chalk.red(`\n${err.message}\n`));
-        process.exit(1);
+        failAction(options.json, 'request_review', null, err.message);
+        return; // unreachable — satisfies TS narrowing
     }
-    let authContext;
-    try {
-        authContext = await resolveAuthContext({ owner: pr.owner, repo: pr.repo });
+    if (options.json) {
+        emitActionPayload(payload);
+        return;
     }
-    catch (err) {
-        console.error(chalk.red(`\n${err.message}\n`));
-        process.exit(1);
-    }
-    const prLabel = `${pr.owner}/${pr.repo}#${pr.prNumber}`;
-    console.log(chalk.dim(`\nRequesting review for ${prLabel}...`));
-    // Ensure the label exists in the repo, then add it to the PR
-    try {
-        await ensureHaystackLabels(pr.owner, pr.repo, ['haystack:needs-review'], authContext.token);
-        await addLabelsToIssue(pr.owner, pr.repo, pr.prNumber, ['haystack:needs-review'], authContext.token);
-    }
-    catch (err) {
-        console.error(chalk.red(`\nFailed to add label: ${err.message}\n`));
-        process.exit(1);
-    }
-    // Request specific reviewer if provided
-    if (reviewer) {
-        try {
-            await requestReviewers(pr.owner, pr.repo, pr.prNumber, [reviewer], authContext.token);
-            console.log(chalk.green(`\n  Review requested from ${reviewer} on ${prLabel}`));
-        }
-        catch (err) {
-            // Label was added successfully, just the reviewer request failed
-            console.log(chalk.green(`\n  Marked ${prLabel} for review`));
-            console.log(chalk.yellow(`  Could not request reviewer "${reviewer}": ${err.message}`));
-        }
+    if (payload.reviewer) {
+        console.log(chalk.green(`\n  Review requested from ${payload.reviewer} on ${payload.ref}`));
     }
     else {
-        console.log(chalk.green(`\n  Marked ${prLabel} for human review`));
+        console.log(chalk.green(`\n  Marked ${payload.ref} for human review`));
+        if (payload.reviewer_request_failed) {
+            console.log(chalk.yellow(`  Could not request reviewer "${reviewer}": ${payload.reviewer_request_failed}`));
+        }
     }
     console.log(chalk.dim('  The PR will appear in the "Needs Assignment" queue in the feed.\n'));
 }

package/dist/commands/review.d.ts

@@ -0,0 +1,25 @@
+/**
+ * review command — Trigger a fresh Haystack analysis for a PR.
+ *
+ * haystack review [pr] [--no-wait]
+ *
+ * Haystack runs a full analysis when a PR is opened (or marked ready);
+ * later pushes only get a resolution check against the existing findings.
+ * This command is the explicit escape hatch: it re-runs full detection on
+ * the PR's current head — use it after substantial new commits, or any
+ * time you want a fresh second opinion.
+ *
+ * When called without a PR identifier, reads the last submitted PR from
+ * `.haystack/pending-submit.json` (written by `haystack submit`).
+ *
+ * Accepts a PR identifier in several formats:
+ *   haystack review                      # Last submitted PR
+ *   haystack review 123                  # Uses current repo's owner/repo
+ *   haystack review owner/repo#123       # Fully qualified
+ *   haystack review https://github.com/owner/repo/pull/123
+ */
+export interface ReviewOptions {
+    wait?: boolean;
+    json?: boolean;
+}
+export declare function reviewCommand(identifier: string | undefined, options: ReviewOptions): Promise<void>;

package/dist/commands/review.js

@@ -0,0 +1,191 @@
+/**
+ * review command — Trigger a fresh Haystack analysis for a PR.
+ *
+ * haystack review [pr] [--no-wait]
+ *
+ * Haystack runs a full analysis when a PR is opened (or marked ready);
+ * later pushes only get a resolution check against the existing findings.
+ * This command is the explicit escape hatch: it re-runs full detection on
+ * the PR's current head — use it after substantial new commits, or any
+ * time you want a fresh second opinion.
+ *
+ * When called without a PR identifier, reads the last submitted PR from
+ * `.haystack/pending-submit.json` (written by `haystack submit`).
+ *
+ * Accepts a PR identifier in several formats:
+ *   haystack review                      # Last submitted PR
+ *   haystack review 123                  # Uses current repo's owner/repo
+ *   haystack review owner/repo#123       # Fully qualified
+ *   haystack review https://github.com/owner/repo/pull/123
+ */
+import chalk from 'chalk';
+import { emitActionPayload, failAction } from '../utils/action-output.js';
+import { triggerAnalysis, fetchTriggerStatus } from '../utils/analysis-api.js';
+import { fetchTriageHeadSha } from './triage.js';
+import { loadToken } from '../utils/auth.js';
+import { loadPendingSubmit } from '../utils/pending-state.js';
+import { parsePrRef } from '../utils/pr-ref.js';
+import { triageCommand } from './triage.js';
+// ============================================================================
+// Constants
+// ============================================================================
+const STATUS_POLL_INTERVAL_MS = 10_000;
+// Full analyses regularly take 10+ minutes on large PRs; this bounds the
+// CLI's wait, not the analysis itself (results land on the feed regardless).
+const STATUS_POLL_TIMEOUT_MS = 25 * 60 * 1000;
+function resolvePR(identifier, json) {
+    if (identifier) {
+        try {
+            return parsePrRef(identifier, 'review');
+        }
+        catch (err) {
+            failAction(json, 'trigger_review', null, err.message);
+        }
+    }
+    const pending = loadPendingSubmit();
+    if (!pending) {
+        console.log(chalk.dim('No pending submits. Pass a PR number to review a specific PR.\n'));
+        return null;
+    }
+    return { owner: pending.owner, repo: pending.repo, prNumber: pending.prNumber };
+}
+// ============================================================================
+// Waiting
+// ============================================================================
+async function waitForRun(requestId, token) {
+    const deadline = Date.now() + STATUS_POLL_TIMEOUT_MS;
+    let consecutiveErrors = 0;
+    while (Date.now() < deadline) {
+        const result = await fetchTriggerStatus(requestId, token);
+        if (result.status === 'COMPLETED')
+            return 'completed';
+        if (result.status === 'FAILED')
+            return 'failed';
+        if (result.status === 'SUPERSEDED')
+            return 'superseded';
+        if (result.status === 'error') {
+            consecutiveErrors++;
+            if (consecutiveErrors >= 5)
+                return 'failed';
+        }
+        else {
+            consecutiveErrors = 0;
+        }
+        process.stderr.write(`\r  ${chalk.dim('Analysis in progress...')}${'  '.repeat(5)}`);
+        // Deliberately NOT unref'd: during the wait this timer can be the only
+        // live handle, and an unref'd timer lets Node exit mid-wait.
+        await new Promise((resolve) => {
+            setTimeout(resolve, STATUS_POLL_INTERVAL_MS);
+        });
+    }
+    return 'timeout';
+}
+// ============================================================================
+// Main command
+// ============================================================================
+export async function reviewCommand(identifier, options) {
+    if (options.json && identifier === undefined && !loadPendingSubmit()) {
+        failAction(true, 'trigger_review', null, 'No pending submit to review. Pass a PR identifier: haystack review owner/repo#123 --json');
+    }
+    const pr = resolvePR(identifier, options.json);
+    if (!pr)
+        return;
+    const prLabel = `${pr.owner}/${pr.repo}#${pr.prNumber}`;
+    let token = null;
+    try {
+        token = await loadToken({ owner: pr.owner, repo: pr.repo });
+    }
+    catch (err) {
+        failAction(options.json, 'trigger_review', prLabel, `Could not load Haystack credentials: ${err.message}`);
+    }
+    if (!token) {
+        failAction(options.json, 'trigger_review', prLabel, 'Triggering an analysis requires authentication. Run `haystack login` first.');
+        return; // unreachable — satisfies TS narrowing
+    }
+    if (!options.json)
+        console.log(chalk.dim(`\nRequesting a fresh analysis for ${prLabel}...`));
+    // Resolve the current head so ingestion's dedup compares commits — an
+    // in-flight run for an OLDER head must be superseded, not reused. A
+    // failed metadata fetch degrades to a head-less trigger (the dedup is a
+    // freshness aid, not a correctness requirement) instead of crashing.
+    let headSha;
+    try {
+        headSha = await fetchTriageHeadSha(pr, token) ?? undefined;
+    }
+    catch (err) {
+        console.error(chalk.dim(`  Could not resolve the PR head (${err.message}) — continuing without it.`));
+    }
+    const trigger = await triggerAnalysis(pr.owner, pr.repo, pr.prNumber, token, headSha);
+    if (trigger.status === 'rate_limited') {
+        const retryHint = trigger.retryAfterSeconds
+            ? ` Try again in ~${Math.ceil(trigger.retryAfterSeconds / 60)} minute(s).`
+            : '';
+        failAction(options.json, 'trigger_review', prLabel, `${trigger.message}${retryHint}`);
+    }
+    if (trigger.status === 'denied') {
+        failAction(options.json, 'trigger_review', prLabel, trigger.message);
+    }
+    if (trigger.status === 'error') {
+        failAction(options.json, 'trigger_review', prLabel, `Failed to trigger analysis: ${trigger.message}`);
+        return; // unreachable — satisfies TS narrowing
+    }
+    if (!options.json) {
+        if (trigger.status === 'already_processing') {
+            console.log(chalk.yellow('  An analysis for this PR is already running — waiting on it instead.'));
+        }
+        else {
+            console.log(chalk.green('  Analysis started.'));
+        }
+    }
+    /** One envelope for every terminal state of the trigger. */
+    const emitJson = (runStatus, detail, done) => {
+        emitActionPayload({
+            action: 'trigger_review',
+            status: 'ok',
+            ref: prLabel,
+            detail,
+            request_id: trigger.requestId,
+            run_status: runStatus,
+            next: done ? `haystack triage ${prLabel} --json` : null,
+        });
+    };
+    if (options.wait === false) {
+        if (options.json) {
+            emitJson(trigger.status, 'Analysis triggered; not waiting for completion.', true);
+            return;
+        }
+        console.log(chalk.dim('  Check results later with: ') + chalk.cyan(`haystack triage ${prLabel}`));
+        console.log(chalk.dim('  Or view the review: ') + chalk.cyan(`https://haystackeditor.com/review/${pr.owner}/${pr.repo}/${pr.prNumber}\n`));
+        return;
+    }
+    const outcome = await waitForRun(trigger.requestId, token);
+    process.stderr.write('\r' + ' '.repeat(60) + '\r');
+    if (outcome === 'failed') {
+        failAction(options.json, 'trigger_review', prLabel, `Analysis run failed. Check the review page: https://haystackeditor.com/review/${pr.owner}/${pr.repo}/${pr.prNumber}`);
+    }
+    if (outcome === 'superseded') {
+        if (options.json) {
+            emitJson('superseded', 'This run was superseded by a newer analysis (a push likely landed meanwhile). The latest results stand.', true);
+            return;
+        }
+        console.log(chalk.yellow('\n  This run was superseded by a newer analysis (a push likely landed meanwhile).'));
+        console.log(chalk.dim('  Showing the latest results instead.'));
+        await triageCommand(prLabel, { wait: false });
+        return;
+    }
+    if (outcome === 'timeout') {
+        if (options.json) {
+            emitJson('running', 'Still running after 25 minutes; the analysis continues server-side.', true);
+            return;
+        }
+        console.log(chalk.yellow('\n  Still running after 25 minutes — giving up on waiting.'));
+        console.log(chalk.dim('  Check results later with: ') + chalk.cyan(`haystack triage ${prLabel}\n`));
+        return;
+    }
+    // Completed — render results through the triage view (no extra wait).
+    if (options.json) {
+        emitJson('completed', 'Analysis completed.', true);
+        return;
+    }
+    await triageCommand(prLabel, { wait: false });
+}

package/dist/commands/setup.js

@@ -48,8 +48,11 @@ function buildAnswerMap(options) {
             answers.want_to_toggle = false;
         if (!('confirm_write' in answers))
             answers.confirm_write = true;
-        if (!('auto_merge' in answers))
+        if (!('auto_merge' in answers)) {
             answers.auto_merge = true;
+            // Consequential default applied without an interactive prompt — say so.
+            console.error('--yes: enabling auto-merge (the wizard default). Pass --no-auto-merge to opt out.');
+        }
         if (!('install_entire' in answers))
             answers.install_entire = true;
         if (!('upgrade_entire' in answers))

package/dist/commands/skills.js

@@ -15,6 +15,7 @@ function getSkillsSourceDir() {
 const SKILL_FILES = [
     'setup-haystack.md',
     'submit.md',
+    'map-your-system.md',
 ];
 function installSkillFiles(targetDir) {
     const sourceDir = getSkillsSourceDir();
@@ -55,6 +56,7 @@ export async function installSkills(options) {
     }
     const claudeCommandPath = join(claudeCommandsDir, 'setup-haystack.md');
     writeFileSync(claudeCommandPath, '# Set Up Haystack\n\nFollow .agents/skills/setup-haystack.md to set up Haystack for this repo.\n');
+    writeFileSync(join(claudeCommandsDir, 'map-your-system.md'), '# Map Your System for Haystack QA\n\nFollow .agents/skills/map-your-system.md to create .haystack/system.yml — verified facts about how this system builds, boots, seeds data, and logs in, so Haystack QA can run it.\n');
     showSuccessMessage();
 }
 function showSuccessMessage() {
@@ -62,6 +64,7 @@ function showSuccessMessage() {
     console.log(chalk.white('Available skills:'));
     console.log(chalk.cyan('  /setup-haystack         ') + chalk.gray('- Create .haystack.json with AI assistance'));
     console.log(chalk.cyan('  /submit                 ') + chalk.gray('- Submit a PR via Haystack'));
+    console.log(chalk.cyan('  /map-your-system        ') + chalk.gray('- Write .haystack/system.yml so Haystack QA can run this system'));
     console.log();
     console.log(chalk.white('Run in your coding CLI:'));
     console.log(chalk.cyan('  /setup-haystack'));
@@ -71,5 +74,6 @@ export async function listSkills() {
     console.log(chalk.white('\nAvailable Haystack skills:\n'));
     console.log(chalk.cyan('  /setup-haystack         ') + chalk.gray('- Master setup - creates .haystack.json'));
     console.log(chalk.cyan('  /submit                 ') + chalk.gray('- Submit a PR via Haystack'));
+    console.log(chalk.cyan('  /map-your-system        ') + chalk.gray('- Write .haystack/system.yml so Haystack QA can run this system'));
     console.log();
 }

package/dist/commands/submit.d.ts

@@ -19,8 +19,11 @@ export interface SubmitOptions {
     review?: string | true;
     force?: boolean;
     wait?: boolean;
+    json?: boolean;
     autoFix?: boolean;
     autoMerge?: boolean;
+    autoMergeSource?: 'flag' | 'config';
+    autoFixSource?: 'flag' | 'config';
     maxTurns?: number;
     triageTimeout?: number;
 }