@hayasaka7/haya-pet 0.2.1 → 0.2.2

package/.github/workflows/ci.yml

@@ -0,0 +1,75 @@
+name: CI
+
+# Run code quality checks and the test suite on every push that touches code.
+on:
+  push:
+    paths:
+      - "**/*.js"
+      - "**/*.mjs"
+      - "**/*.cjs"
+      - "package.json"
+      - "package-lock.json"
+      - ".github/workflows/ci.yml"
+  pull_request:
+    paths:
+      - "**/*.js"
+      - "**/*.mjs"
+      - "**/*.cjs"
+      - "package.json"
+      - "package-lock.json"
+      - ".github/workflows/ci.yml"
+
+concurrency:
+  group: ci-${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+permissions:
+  contents: read
+
+jobs:
+  lint:
+    name: Code quality (ESLint)
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 22
+          cache: npm
+
+      - name: Install dependencies
+        # Electron's binary isn't needed for linting or tests; skip the ~150 MB
+        # download so CI is fast and isn't at the mercy of the Electron CDN.
+        env:
+          ELECTRON_SKIP_BINARY_DOWNLOAD: "1"
+        run: npm ci
+
+      - name: Run ESLint
+        run: npm run lint
+
+  test:
+    name: Tests (Node ${{ matrix.node }} on ${{ matrix.os }})
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, windows-latest, macos-latest]
+        node: [20, 22]
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node }}
+          cache: npm
+
+      - name: Install dependencies
+        env:
+          ELECTRON_SKIP_BINARY_DOWNLOAD: "1"
+        run: npm ci
+
+      - name: Run the test suite
+        run: npm test

package/CHANGELOG.md

@@ -7,6 +7,24 @@ All notable changes to Haya Pet are documented here. This project adheres to
 > 0.2.0 npm publish; they are listed under 0.2.1, which is the first version that
 > ships them.
 
+## [0.2.2]
+
+### Fixed
+- **Session bubbles no longer reshuffle while sessions run.** Bubbles used to be
+  sorted by state urgency and latest activity, so every status change could move
+  a bubble up or down the stack mid-progress. They now stack by the time each
+  session **connected to the pet** — newest on top, first one at the bottom —
+  and that order stays fixed for the session's whole life. Urgency still shows
+  through each bubble's status icon, the collapsed-folder summary dot, and the
+  pet animation.
+
+### Internal
+- **CI on every code push** — a new GitHub Actions workflow lints and runs the
+  test suite (Ubuntu + Windows + macOS, Node 20/22) for any push or PR touching
+  code.
+- **ESLint adopted** (`npm run lint`, flat config); the few existing findings
+  were fixed with no behavior change.
+
 ## [0.2.1]
 
 ### Added

package/README.md

@@ -38,8 +38,9 @@ Haya Pet watches all of them and presents one ambient interface:
   draggable, and position-persistent like a real desktop companion.
 - **Session bubbles** — one compact bubble per active session showing client,
   project, the latest activity, and a status icon (a spinning *working* circle, a
-  green *done* check, a yellow *needs you*, or a red *failed* cross). A folder
-  button beside the pet folds them away.
+  green *done* check, a yellow *needs you*, or a red *failed* cross). Bubbles stack
+  by connect time — the newest session on top — so the stack never reshuffles while
+  work is in progress. A folder button beside the pet folds them away.
 
 ## Features
 

package/apps/companion/src/renderer/task-talk-window.js

@@ -121,7 +121,7 @@ function renderComposer(bubble, replyMode, bridge) {
   return composer;
 }
 
-function renderControls(controlsPromise, bubble, bridge) {
+function renderControls(controlsPromise, _bubble, _bridge) {
   const wrap = document.createElement("div");
   wrap.className = "controls";
 

package/eslint.config.js

@@ -0,0 +1,32 @@
+import js from "@eslint/js";
+import globals from "globals";
+
+export default [
+  {
+    ignores: [
+      "node_modules/**",
+      "native/**",
+      "tmp/**",
+      "docs/**",
+      ".gax/**",
+    ],
+  },
+  js.configs.recommended,
+  {
+    files: ["**/*.js", "**/*.mjs", "**/*.cjs"],
+    languageOptions: {
+      ecmaVersion: "latest",
+      sourceType: "module",
+      globals: {
+        ...globals.node,
+        ...globals.browser,
+      },
+    },
+    rules: {
+      "no-unused-vars": [
+        "error",
+        { argsIgnorePattern: "^_", varsIgnorePattern: "^_" },
+      ],
+    },
+  },
+];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hayasaka7/haya-pet",
-  "version": "0.2.1",
+  "version": "0.2.2",
   "type": "module",
   "description": "Generic AI CLI pet runtime foundation.",
   "license": "MIT",
@@ -17,6 +17,7 @@
     "haya-pet": "apps/cli/src/haya-pet.js"
   },
   "scripts": {
+    "lint": "eslint .",
     "test": "node test/run-tests.mjs"
   },
   "workspaces": [
@@ -31,5 +32,10 @@
   },
   "engines": {
     "node": ">=16.20.0"
+  },
+  "devDependencies": {
+    "@eslint/js": "^10.0.1",
+    "eslint": "^10.4.1",
+    "globals": "^17.6.0"
   }
 }

package/packages/cli-core/src/run-command.js

@@ -256,7 +256,6 @@ async function runObservedCommand({
   registered = true;
   if (pendingState) {
     emitState(pendingState);
-    pendingState = undefined;
   }
 
   await sendProtocolMessage(send, { type: "heartbeat", sessionId, updatedAt: now() });

package/packages/session-core/src/bubble-view.js

@@ -1,5 +1,4 @@
 import { mapAiStateToPetAction } from "../../pet-core/src/atlas.js";
-import { getSessionPriorityRank } from "./priority.js";
 import { buildSessionSummary, buildStatusLabel, formatElapsed } from "./summaries.js";
 
 // Collapses the full AI-state vocabulary into the four progress kinds the
@@ -53,17 +52,21 @@ export function buildBubbleViews(sessions, now = Date.now(), options = {}) {
   return sessions
     .filter(Boolean)
     .slice()
-    .sort(compareByPriority)
+    .sort(compareByConnectTime)
     .map((session) => buildBubbleView(session, now, options));
 }
 
-function compareByPriority(left, right) {
-  const rankDelta = getSessionPriorityRank(left) - getSessionPriorityRank(right);
-  if (rankDelta !== 0) {
-    return rankDelta;
+// Bubbles stack by connect time — the newest session on top, the first one at
+// the bottom — and never reshuffle while sessions are in progress. State
+// urgency only drives the collapsed-folder dot and the pet animation, not the
+// list order.
+function compareByConnectTime(left, right) {
+  const startedDelta = numeric(right.startedAt) - numeric(left.startedAt);
+  if (startedDelta !== 0) {
+    return startedDelta;
   }
 
-  return numeric(right.updatedAt) - numeric(left.updatedAt);
+  return String(left.sessionId).localeCompare(String(right.sessionId));
 }
 
 function safePetAction(state) {

package/packages/session-core/test/bubble-view.test.mjs

@@ -28,15 +28,40 @@ test("builds a bubble view model with label, summary, action, and elapsed", () =
   assert.equal(view.elapsedLabel, "1m 4s");
 });
 
-test("orders bubbles by session priority then recency", () => {
+test("stacks bubbles by connect time, newest on top, so they never reshuffle mid-session", () => {
   const sessions = [
-    { ...baseSession, sessionId: "sess_idle", state: "idle", updatedAt: 9_000 },
-    { ...baseSession, sessionId: "sess_wait", state: "waiting_approval", updatedAt: 4_000 },
-    { ...baseSession, sessionId: "sess_run", state: "running_tool", updatedAt: 8_000 }
+    { ...baseSession, sessionId: "sess_third", state: "waiting_approval", startedAt: 3_000, updatedAt: 4_000 },
+    { ...baseSession, sessionId: "sess_first", state: "idle", startedAt: 1_000, updatedAt: 9_000 },
+    { ...baseSession, sessionId: "sess_second", state: "running_tool", startedAt: 2_000, updatedAt: 8_000 }
   ];
 
   const views = buildBubbleViews(sessions, 10_000);
-  assert.deepEqual(views.map((view) => view.sessionId), ["sess_wait", "sess_run", "sess_idle"]);
+  assert.deepEqual(views.map((view) => view.sessionId), ["sess_third", "sess_second", "sess_first"]);
+});
+
+test("keeps bubble order stable when states and activity change", () => {
+  const before = [
+    { ...baseSession, sessionId: "sess_first", state: "running_tool", startedAt: 1_000, updatedAt: 2_000 },
+    { ...baseSession, sessionId: "sess_second", state: "idle", startedAt: 2_000, updatedAt: 2_500 }
+  ];
+  // Later, the second session becomes urgent and more recently active.
+  const after = [
+    { ...baseSession, sessionId: "sess_first", state: "idle", startedAt: 1_000, updatedAt: 3_000 },
+    { ...baseSession, sessionId: "sess_second", state: "waiting_approval", startedAt: 2_000, updatedAt: 9_000 }
+  ];
+
+  const order = (sessions) => buildBubbleViews(sessions, 10_000).map((view) => view.sessionId);
+  assert.deepEqual(order(before), order(after));
+});
+
+test("breaks connect-time ties by session id for a deterministic order", () => {
+  const sessions = [
+    { ...baseSession, sessionId: "sess_b", startedAt: 1_000 },
+    { ...baseSession, sessionId: "sess_a", startedAt: 1_000 }
+  ];
+
+  const views = buildBubbleViews(sessions, 10_000);
+  assert.deepEqual(views.map((view) => view.sessionId), ["sess_a", "sess_b"]);
 });
 
 test("marks the selected/pinned session", () => {