@hasna/recordings 0.1.23 → 0.1.25

package/src/native/Recordings/RecordingsTests/CLIRunnerTests.swift

@@ -17,6 +17,18 @@ struct CLIRunnerTests {
         #expect(CLIRunner.parseError("ERROR: OpenAI API key not configured") == "OpenAI API key not configured on this Mac")
     }
 
+    @Test("parseError maps invalid API key (401) to a friendly message")
+    func invalidKeyError() {
+        let input = "ERROR: Transcription failed: 401 Incorrect API key provided: sk-proj-****vosA. You can find your API key at https://platform.openai.com."
+        #expect(CLIRunner.parseError(input) == "OpenAI API key invalid or expired — update it in Recordings Settings")
+    }
+
+    @Test("parseError maps quota errors (429) to a friendly message")
+    func quotaError() {
+        let input = "ERROR: Transcription failed: 429 You exceeded your current quota, please check your plan and billing details."
+        #expect(CLIRunner.parseError(input) == "OpenAI quota exceeded — check the OpenAI account billing")
+    }
+
     @Test("parseError truncates long messages to 120 chars")
     func truncation() {
         let longMsg = String(repeating: "a", count: 200)

package/src/native/Recordings/RecordingsTests/OpenAIAPIKeyStoreTests.swift

@@ -74,6 +74,55 @@ struct OpenAIAPIKeyStoreTests {
         #expect(key == "secret-key")
     }
 
+    @Test("Saving a key writes it to config.json so the CLI uses the same key")
+    func saveWritesConfig() throws {
+        let home = try makeHome()
+
+        try OpenAIAPIKeyStore.save(key: "sk-new-key", homePath: home.path)
+
+        let key = OpenAIAPIKeyStore.load(
+            homePath: home.path,
+            environment: [:],
+            userDefaultKey: nil
+        )
+        #expect(key == "sk-new-key")
+    }
+
+    @Test("Saving a key preserves unrelated config.json fields")
+    func savePreservesOtherFields() throws {
+        let home = try makeHome()
+        try writeConfig(home: home, [
+            "openai_api_key": "old-key",
+            "transcription_model": "gpt-4o-mini-transcribe",
+        ])
+
+        try OpenAIAPIKeyStore.save(key: "sk-rotated", homePath: home.path)
+
+        let configURL = home
+            .appendingPathComponent(".hasna")
+            .appendingPathComponent("recordings")
+            .appendingPathComponent("config.json")
+        let data = try Data(contentsOf: configURL)
+        let json = try #require(JSONSerialization.jsonObject(with: data) as? [String: Any])
+        #expect(json["openai_api_key"] as? String == "sk-rotated")
+        #expect(json["transcription_model"] as? String == "gpt-4o-mini-transcribe")
+    }
+
+    @Test("Saving an empty key removes it from config.json")
+    func saveEmptyRemovesKey() throws {
+        let home = try makeHome()
+        try writeConfig(home: home, ["openai_api_key": "old-key"])
+
+        try OpenAIAPIKeyStore.save(key: "   ", homePath: home.path)
+
+        let key = OpenAIAPIKeyStore.load(
+            homePath: home.path,
+            environment: [:],
+            userDefaultKey: nil
+        )
+        #expect(key == "")
+    }
+
     private func makeHome() throws -> URL {
         let url = FileManager.default.temporaryDirectory
             .appendingPathComponent("recordings-key-store-\(UUID().uuidString)")

package/src/native/Recordings/RecordingsTests/PasteTargetTests.swift

@@ -35,4 +35,58 @@ struct PasteTargetTests {
 
         #expect(selected?.pid == 30)
     }
+
+    @Test("paste target prefers the frontmost app over an arbitrary regular app")
+    func prefersFrontmostFallback() {
+        let candidates = [
+            PasteTargetCandidate(pid: 5, bundleIdentifier: "com.background", isRegularApp: true),
+            PasteTargetCandidate(pid: 30, bundleIdentifier: "com.notes", isRegularApp: true),
+        ]
+
+        let selected = RecordingEngine.selectPasteTarget(
+            candidates: candidates,
+            currentPid: 99,
+            targetBundleIdentifier: nil,
+            targetPid: nil,
+            frontmostPid: 30
+        )
+
+        #expect(selected?.pid == 30)
+    }
+
+    @Test("paste target never selects the recorder app even when frontmost")
+    func skipsOwnAppWhenFrontmost() {
+        let candidates = [
+            PasteTargetCandidate(pid: 99, bundleIdentifier: "com.hasna.recordings", isRegularApp: true),
+            PasteTargetCandidate(pid: 30, bundleIdentifier: "com.notes", isRegularApp: true),
+        ]
+
+        let selected = RecordingEngine.selectPasteTarget(
+            candidates: candidates,
+            currentPid: 99,
+            targetBundleIdentifier: nil,
+            targetPid: nil,
+            frontmostPid: 99
+        )
+
+        #expect(selected?.pid == 30)
+    }
+
+    @Test("captured pid wins over frontmost fallback")
+    func capturedPidBeatsFrontmost() {
+        let candidates = [
+            PasteTargetCandidate(pid: 10, bundleIdentifier: "com.editor", isRegularApp: true),
+            PasteTargetCandidate(pid: 30, bundleIdentifier: "com.notes", isRegularApp: true),
+        ]
+
+        let selected = RecordingEngine.selectPasteTarget(
+            candidates: candidates,
+            currentPid: 99,
+            targetBundleIdentifier: nil,
+            targetPid: 10,
+            frontmostPid: 30
+        )
+
+        #expect(selected?.pid == 10)
+    }
 }

package/src/native/Recordings/RecordingsTests/TranscriptResolutionTests.swift

@@ -0,0 +1,58 @@
+import Testing
+@testable import RecordingsLib
+
+struct TranscriptResolutionTests {
+    @Test("CLI transcript is preferred when present")
+    func cliWins() {
+        let resolved = RecordingEngine.resolveFinalTranscript(
+            cliText: "full transcript from whole audio",
+            cliError: nil,
+            realtimeText: "partial realtime"
+        )
+        #expect(resolved.text == "full transcript from whole audio")
+        #expect(resolved.failureStatus == nil)
+    }
+
+    @Test("Realtime transcript is used when CLI transcription fails")
+    func realtimeFallbackOnError() {
+        let resolved = RecordingEngine.resolveFinalTranscript(
+            cliText: nil,
+            cliError: "OpenAI API key invalid or expired — update it in Recordings Settings",
+            realtimeText: "what the user actually said"
+        )
+        #expect(resolved.text == "what the user actually said")
+        #expect(resolved.failureStatus == nil)
+    }
+
+    @Test("Realtime transcript is used when CLI returns empty text")
+    func realtimeFallbackOnEmpty() {
+        let resolved = RecordingEngine.resolveFinalTranscript(
+            cliText: "   ",
+            cliError: nil,
+            realtimeText: "spoken words"
+        )
+        #expect(resolved.text == "spoken words")
+    }
+
+    @Test("CLI error is surfaced when no transcript exists at all")
+    func errorWhenNothing() {
+        let resolved = RecordingEngine.resolveFinalTranscript(
+            cliText: nil,
+            cliError: "OpenAI API key invalid or expired — update it in Recordings Settings",
+            realtimeText: "  "
+        )
+        #expect(resolved.text == nil)
+        #expect(resolved.failureStatus == "OpenAI API key invalid or expired — update it in Recordings Settings")
+    }
+
+    @Test("Generic failure status when both transcripts are empty without error")
+    func genericEmpty() {
+        let resolved = RecordingEngine.resolveFinalTranscript(
+            cliText: "",
+            cliError: nil,
+            realtimeText: nil
+        )
+        #expect(resolved.text == nil)
+        #expect(resolved.failureStatus == "Empty transcription")
+    }
+}

package/dist/cli/cloud.d.ts

@@ -1,3 +0,0 @@
-import type { Command } from "commander";
-export declare function registerCloudCommands(program: Command): void;
-//# sourceMappingURL=cloud.d.ts.map

package/dist/cli/cloud.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"cloud.d.ts","sourceRoot":"","sources":["../../src/cli/cloud.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AA8BzC,wBAAgB,qBAAqB,CAAC,OAAO,EAAE,OAAO,GAAG,IAAI,CAkI5D"}

package/dist/db/cloud-config.d.ts

@@ -1,14 +0,0 @@
-export type CloudMode = "local" | "hybrid" | "cloud";
-export interface CloudConfig {
-    mode: CloudMode;
-    rds: {
-        host: string;
-        port: number;
-        username: string;
-        password_env: string;
-        ssl: boolean;
-    };
-}
-export declare function getCloudConfig(): CloudConfig;
-export declare function getConnectionString(dbName?: string): string;
-//# sourceMappingURL=cloud-config.d.ts.map

package/dist/db/cloud-config.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"cloud-config.d.ts","sourceRoot":"","sources":["../../src/db/cloud-config.ts"],"names":[],"mappings":"AAIA,MAAM,MAAM,SAAS,GAAG,OAAO,GAAG,QAAQ,GAAG,OAAO,CAAC;AAErD,MAAM,WAAW,WAAW;IAC1B,IAAI,EAAE,SAAS,CAAC;IAChB,GAAG,EAAE;QACH,IAAI,EAAE,MAAM,CAAC;QACb,IAAI,EAAE,MAAM,CAAC;QACb,QAAQ,EAAE,MAAM,CAAC;QACjB,YAAY,EAAE,MAAM,CAAC;QACrB,GAAG,EAAE,OAAO,CAAC;KACd,CAAC;CACH;AAgBD,wBAAgB,cAAc,IAAI,WAAW,CAiC5C;AAED,wBAAgB,mBAAmB,CAAC,MAAM,SAAe,GAAG,MAAM,CAiBjE"}

package/dist/db/cloud-sync.d.ts

@@ -1,29 +0,0 @@
-import { type Database } from "bun:sqlite";
-import { PgAdapterAsync } from "./remote-storage.js";
-export interface SyncResult {
-    table: string;
-    direction: "push" | "pull";
-    rows_read: number;
-    rows_written: number;
-    errors: string[];
-}
-export interface CloudStatus {
-    mode: string;
-    enabled: boolean;
-    db_path: string;
-    tables: Array<{
-        table: string;
-        rows: number;
-    }>;
-}
-export declare function getCloudPg(): Promise<PgAdapterAsync>;
-export declare function runCloudMigrations(remote: PgAdapterAsync): Promise<void>;
-export declare function getCloudStatus(db?: Database): CloudStatus;
-export declare function pushCloudChanges(tables?: string[]): Promise<SyncResult[]>;
-export declare function pullCloudChanges(tables?: string[]): Promise<SyncResult[]>;
-export declare function syncCloudChanges(tables?: string[]): Promise<{
-    push: SyncResult[];
-    pull: SyncResult[];
-}>;
-export declare function parseCloudTables(raw?: string): string[];
-//# sourceMappingURL=cloud-sync.d.ts.map

package/dist/db/cloud-sync.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"cloud-sync.d.ts","sourceRoot":"","sources":["../../src/db/cloud-sync.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,QAAQ,EAAE,MAAM,YAAY,CAAC;AAG3C,OAAO,EAAE,cAAc,EAAE,MAAM,qBAAqB,CAAC;AAKrD,MAAM,WAAW,UAAU;IACzB,KAAK,EAAE,MAAM,CAAC;IACd,SAAS,EAAE,MAAM,GAAG,MAAM,CAAC;IAC3B,SAAS,EAAE,MAAM,CAAC;IAClB,YAAY,EAAE,MAAM,CAAC;IACrB,MAAM,EAAE,MAAM,EAAE,CAAC;CAClB;AAED,MAAM,WAAW,WAAW;IAC1B,IAAI,EAAE,MAAM,CAAC;IACb,OAAO,EAAE,OAAO,CAAC;IACjB,OAAO,EAAE,MAAM,CAAC;IAChB,MAAM,EAAE,KAAK,CAAC;QAAE,KAAK,EAAE,MAAM,CAAC;QAAC,IAAI,EAAE,MAAM,CAAA;KAAE,CAAC,CAAC;CAChD;AAqFD,wBAAsB,UAAU,IAAI,OAAO,CAAC,cAAc,CAAC,CAE1D;AAED,wBAAsB,kBAAkB,CAAC,MAAM,EAAE,cAAc,GAAG,OAAO,CAAC,IAAI,CAAC,CAI9E;AAED,wBAAgB,cAAc,CAAC,EAAE,GAAE,QAAwB,GAAG,WAAW,CAexE;AAED,wBAAsB,gBAAgB,CAAC,MAAM,GAAE,MAAM,EAAsB,GAAG,OAAO,CAAC,UAAU,EAAE,CAAC,CAuBlG;AAED,wBAAsB,gBAAgB,CAAC,MAAM,GAAE,MAAM,EAAsB,GAAG,OAAO,CAAC,UAAU,EAAE,CAAC,CAuBlG;AAED,wBAAsB,gBAAgB,CAAC,MAAM,GAAE,MAAM,EAAsB,GAAG,OAAO,CAAC;IAAE,IAAI,EAAE,UAAU,EAAE,CAAC;IAAC,IAAI,EAAE,UAAU,EAAE,CAAA;CAAE,CAAC,CAKhI;AAED,wBAAgB,gBAAgB,CAAC,GAAG,CAAC,EAAE,MAAM,GAAG,MAAM,EAAE,CAIvD"}

package/dist/mcp/cloud-tools.d.ts

@@ -1,3 +0,0 @@
-import type { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
-export declare function registerRecordingsCloudTools(server: McpServer): void;
-//# sourceMappingURL=cloud-tools.d.ts.map

package/dist/mcp/cloud-tools.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"cloud-tools.d.ts","sourceRoot":"","sources":["../../src/mcp/cloud-tools.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,yCAAyC,CAAC;AAsBzE,wBAAgB,4BAA4B,CAAC,MAAM,EAAE,SAAS,GAAG,IAAI,CAmFpE"}