@hasna/microservices 0.0.6 → 0.0.8

package/microservices/microservice-domains/src/lib/brandsight.ts

@@ -1,6 +1,9 @@
 /**
  * Brandsight API integration for brand monitoring and threat detection
  *
+ * Uses the Connector SDK pattern. When a connect-brandsight package
+ * is published, replace the inline connector with the package import.
+ *
  * Requires environment variable:
  *   BRANDSIGHT_API_KEY — API key for Brandsight
  */
@@ -9,6 +12,11 @@
 // Types
 // ============================================================
 
+export interface BrandsightConfig {
+  apiKey: string;
+  baseUrl?: string;
+}
+
 export interface BrandsightAlert {
   domain: string;
   type: "typosquat" | "homoglyph" | "keyword" | "tld_variation";
@@ -53,72 +61,141 @@ export class BrandsightApiError extends Error {
 }
 
 // ============================================================
-// Configuration
+// Brandsight Connector Client (inline SDK pattern)
 // ============================================================
 
-const API_BASE = "https://api.brandsight.com/v1";
+class BrandsightClient {
+  private readonly apiKey: string;
+  private readonly baseUrl: string;
+  private fetchFn: typeof globalThis.fetch;
 
-export function getApiKey(): string {
-  const key = process.env["BRANDSIGHT_API_KEY"];
-  if (!key) {
-    throw new BrandsightApiError(
-      "BRANDSIGHT_API_KEY environment variable is not set"
-    );
+  constructor(config: BrandsightConfig, fetchFn?: typeof globalThis.fetch) {
+    this.apiKey = config.apiKey;
+    this.baseUrl = config.baseUrl || "https://api.brandsight.com/v1";
+    this.fetchFn = fetchFn || globalThis.fetch;
+  }
+
+  setFetch(fn: typeof globalThis.fetch): void {
+    this.fetchFn = fn;
+  }
+
+  async get<T>(path: string): Promise<{ data: T; stub: false } | { data: null; stub: true }> {
+    const url = `${this.baseUrl}${path}`;
+    const headers: Record<string, string> = {
+      Authorization: `Bearer ${this.apiKey}`,
+      "Content-Type": "application/json",
+      Accept: "application/json",
+      "User-Agent": "microservice-domains/0.0.1",
+    };
+
+    try {
+      const response = await this.fetchFn(url, {
+        method: "GET",
+        headers,
+        signal: AbortSignal.timeout(15000),
+      });
+
+      if (!response.ok) {
+        throw new BrandsightApiError(
+          `Brandsight API GET ${path} failed with status ${response.status}`,
+          response.status,
+          await response.text()
+        );
+      }
+
+      const data = (await response.json()) as T;
+      return { data, stub: false };
+    } catch (error) {
+      if (error instanceof BrandsightApiError) throw error;
+      // API unreachable — return stub indicator
+      return { data: null, stub: true };
+    }
   }
-  return key;
 }
 
-function getHeaders(apiKey: string): Record<string, string> {
-  return {
-    Authorization: `Bearer ${apiKey}`,
-    "Content-Type": "application/json",
-    Accept: "application/json",
-    "User-Agent": "microservice-domains/0.0.1",
-  };
+// ============================================================
+// Brandsight Connector (SDK pattern)
+// ============================================================
+
+class BrandsightConnector {
+  private readonly client: BrandsightClient;
+
+  constructor(config: BrandsightConfig, fetchFn?: typeof globalThis.fetch) {
+    this.client = new BrandsightClient(config, fetchFn);
+  }
+
+  static fromEnv(fetchFn?: typeof globalThis.fetch): BrandsightConnector {
+    const apiKey = process.env["BRANDSIGHT_API_KEY"];
+    if (!apiKey) {
+      throw new BrandsightApiError(
+        "BRANDSIGHT_API_KEY environment variable is not set"
+      );
+    }
+    return new BrandsightConnector({ apiKey }, fetchFn);
+  }
+
+  setFetch(fn: typeof globalThis.fetch): void {
+    this.client.setFetch(fn);
+  }
+
+  async monitorBrand(brandName: string): Promise<{ alerts: BrandsightAlert[] } | null> {
+    const result = await this.client.get<{ alerts: BrandsightAlert[] }>(
+      `/brands/${encodeURIComponent(brandName)}/monitor`
+    );
+    return result.stub ? null : result.data;
+  }
+
+  async getSimilarDomains(domain: string): Promise<{ similar: string[] } | null> {
+    const result = await this.client.get<{ similar: string[] }>(
+      `/domains/${encodeURIComponent(domain)}/similar`
+    );
+    return result.stub ? null : result.data;
+  }
+
+  async getWhoisHistory(domain: string): Promise<{ history: WhoisHistoryEntry[] } | null> {
+    const result = await this.client.get<{ history: WhoisHistoryEntry[] }>(
+      `/domains/${encodeURIComponent(domain)}/whois-history`
+    );
+    return result.stub ? null : result.data;
+  }
+
+  async getThreatAssessment(domain: string): Promise<Omit<ThreatAssessment, "stub"> | null> {
+    const result = await this.client.get<Omit<ThreatAssessment, "stub">>(
+      `/domains/${encodeURIComponent(domain)}/threats`
+    );
+    return result.stub ? null : result.data;
+  }
 }
 
 // ============================================================
-// Internal fetch helper (allows test injection)
+// Module-level state (for test injection)
 // ============================================================
 
 type FetchFn = typeof globalThis.fetch;
 
-let _fetchFn: FetchFn = globalThis.fetch;
+let _fetchFn: FetchFn | null = null;
 
 /**
  * Override the fetch implementation (for testing).
  * Pass `null` to restore the default.
  */
 export function _setFetch(fn: FetchFn | null): void {
-  _fetchFn = fn ?? globalThis.fetch;
+  _fetchFn = fn;
 }
 
-async function apiRequest<T>(path: string, apiKey: string): Promise<{ data: T; stub: false } | { data: null; stub: true }> {
-  const url = `${API_BASE}${path}`;
-  const headers = getHeaders(apiKey);
-
-  try {
-    const response = await _fetchFn(url, {
-      method: "GET",
-      headers,
-      signal: AbortSignal.timeout(15000),
-    });
-
-    if (!response.ok) {
-      throw new BrandsightApiError(
-        `Brandsight API GET ${path} failed with status ${response.status}`,
-        response.status,
-        await response.text()
-      );
-    }
-
-    const data = (await response.json()) as T;
-    return { data, stub: false };
-  } catch (error) {
-    if (error instanceof BrandsightApiError) throw error;
-    // API unreachable — return stub indicator
-    return { data: null, stub: true };
+export function getApiKey(): string {
+  const key = process.env["BRANDSIGHT_API_KEY"];
+  if (!key) {
+    throw new BrandsightApiError(
+      "BRANDSIGHT_API_KEY environment variable is not set"
+    );
   }
+  return key;
+}
+
+function createConnector(): BrandsightConnector {
+  const connector = BrandsightConnector.fromEnv(_fetchFn || undefined);
+  return connector;
 }
 
 // ============================================================
@@ -183,20 +260,17 @@ function generateStubThreatAssessment(domain: string): Omit<ThreatAssessment, "s
 }
 
 // ============================================================
-// API Functions
+// API Functions (use connector, fall back to stubs)
 // ============================================================
 
 /**
  * Monitor a brand name for new domain registrations that are similar.
  */
 export async function monitorBrand(brandName: string): Promise<BrandMonitorResult> {
-  const apiKey = getApiKey();
-  const result = await apiRequest<{ alerts: BrandsightAlert[] }>(
-    `/brands/${encodeURIComponent(brandName)}/monitor`,
-    apiKey
-  );
+  const connector = createConnector();
+  const data = await connector.monitorBrand(brandName);
 
-  if (result.stub) {
+  if (data === null) {
     return {
       brand: brandName,
       alerts: generateStubAlerts(brandName),
@@ -206,7 +280,7 @@ export async function monitorBrand(brandName: string): Promise<BrandMonitorResul
 
   return {
     brand: brandName,
-    alerts: result.data!.alerts,
+    alerts: data.alerts,
     stub: false,
   };
 }
@@ -215,13 +289,10 @@ export async function monitorBrand(brandName: string): Promise<BrandMonitorResul
  * Find typosquat/competing domains similar to the given domain.
  */
 export async function getSimilarDomains(domain: string): Promise<{ domain: string; similar: string[]; stub: boolean }> {
-  const apiKey = getApiKey();
-  const result = await apiRequest<{ similar: string[] }>(
-    `/domains/${encodeURIComponent(domain)}/similar`,
-    apiKey
-  );
+  const connector = createConnector();
+  const data = await connector.getSimilarDomains(domain);
 
-  if (result.stub) {
+  if (data === null) {
     return {
       domain,
       similar: generateStubSimilarDomains(domain),
@@ -231,7 +302,7 @@ export async function getSimilarDomains(domain: string): Promise<{ domain: strin
 
   return {
     domain,
-    similar: result.data!.similar,
+    similar: data.similar,
     stub: false,
   };
 }
@@ -240,13 +311,10 @@ export async function getSimilarDomains(domain: string): Promise<{ domain: strin
  * Get historical WHOIS records for a domain.
  */
 export async function getWhoisHistory(domain: string): Promise<WhoisHistoryResult> {
-  const apiKey = getApiKey();
-  const result = await apiRequest<{ history: WhoisHistoryEntry[] }>(
-    `/domains/${encodeURIComponent(domain)}/whois-history`,
-    apiKey
-  );
+  const connector = createConnector();
+  const data = await connector.getWhoisHistory(domain);
 
-  if (result.stub) {
+  if (data === null) {
     return {
       domain,
       history: generateStubWhoisHistory(domain),
@@ -256,7 +324,7 @@ export async function getWhoisHistory(domain: string): Promise<WhoisHistoryResul
 
   return {
     domain,
-    history: result.data!.history,
+    history: data.history,
     stub: false,
   };
 }
@@ -265,13 +333,10 @@ export async function getWhoisHistory(domain: string): Promise<WhoisHistoryResul
  * Get a threat assessment for a domain.
  */
 export async function getThreatAssessment(domain: string): Promise<ThreatAssessment> {
-  const apiKey = getApiKey();
-  const result = await apiRequest<Omit<ThreatAssessment, "stub">>(
-    `/domains/${encodeURIComponent(domain)}/threats`,
-    apiKey
-  );
+  const connector = createConnector();
+  const data = await connector.getThreatAssessment(domain);
 
-  if (result.stub) {
+  if (data === null) {
     return {
       ...generateStubThreatAssessment(domain),
       stub: true,
@@ -279,7 +344,7 @@ export async function getThreatAssessment(domain: string): Promise<ThreatAssessm
   }
 
   return {
-    ...result.data!,
+    ...data,
     stub: false,
   };
 }

package/microservices/microservice-domains/src/lib/godaddy.ts

@@ -1,6 +1,10 @@
 /**
  * GoDaddy API integration for microservice-domains
  *
+ * Uses the Connector SDK pattern from connect-godaddy.
+ * When @hasna/connect-godaddy is published to npm, replace the
+ * relative connector import with the package import.
+ *
  * Environment variables:
  *   GODADDY_API_KEY    — GoDaddy API key
  *   GODADDY_API_SECRET — GoDaddy API secret
@@ -12,51 +16,31 @@ import type {
   Domain,
 } from "../db/domains.js";
 
+// Re-export types used by consumers
+export type {
+  GoDaddyDomain,
+  GoDaddyDomainDetail,
+  GoDaddyDnsRecord,
+  GoDaddyAvailability,
+  GoDaddyRenewResponse,
+} from "../../../../../open-connectors/connectors/connect-godaddy/src/index.js";
+
+import {
+  GoDaddy,
+  GoDaddyApiError,
+  type GoDaddyDomain,
+  type GoDaddyDomainDetail,
+  type GoDaddyDnsRecord,
+  type GoDaddyAvailability,
+  type GoDaddyConfig,
+} from "../../../../../open-connectors/connectors/connect-godaddy/src/index.js";
+
+export { GoDaddyApiError };
+
 // ============================================================
-// Types
+// Sync Result Type (microservice-specific)
 // ============================================================
 
-export interface GoDaddyDomain {
-  domain: string;
-  status: string;
-  expires: string;
-  renewAuto: boolean;
-  nameServers: string[];
-}
-
-export interface GoDaddyDomainDetail extends GoDaddyDomain {
-  domainId: number;
-  createdAt: string;
-  expirationProtected: boolean;
-  holdRegistrar: boolean;
-  locked: boolean;
-  privacy: boolean;
-  registrarCreatedAt: string;
-  renewDeadline: string;
-  transferProtected: boolean;
-  contactAdmin?: Record<string, unknown>;
-  contactBilling?: Record<string, unknown>;
-  contactRegistrant?: Record<string, unknown>;
-  contactTech?: Record<string, unknown>;
-}
-
-export interface GoDaddyDnsRecord {
-  type: string;
-  name: string;
-  data: string;
-  ttl: number;
-  priority?: number;
-}
-
-export interface GoDaddyAvailability {
-  available: boolean;
-  domain: string;
-  definitive: boolean;
-  price: number;
-  currency: string;
-  period: number;
-}
-
 export interface GoDaddySyncResult {
   synced: number;
   created: number;
@@ -64,102 +48,44 @@ export interface GoDaddySyncResult {
   errors: string[];
 }
 
-export class GoDaddyApiError extends Error {
-  constructor(
-    message: string,
-    public statusCode: number,
-    public responseBody?: string
-  ) {
-    super(message);
-    this.name = "GoDaddyApiError";
-  }
-}
-
 // ============================================================
-// Configuration
-// ============================================================
-
-const GODADDY_API_BASE = "https://api.godaddy.com";
-
-function getCredentials(): { key: string; secret: string } {
-  const key = process.env["GODADDY_API_KEY"];
-  const secret = process.env["GODADDY_API_SECRET"];
-
-  if (!key || !secret) {
-    throw new Error(
-      "GoDaddy API credentials not configured. Set GODADDY_API_KEY and GODADDY_API_SECRET environment variables."
-    );
-  }
-
-  return { key, secret };
-}
-
-function getHeaders(): Record<string, string> {
-  const { key, secret } = getCredentials();
-  return {
-    Authorization: `sso-key ${key}:${secret}`,
-    "Content-Type": "application/json",
-    Accept: "application/json",
-  };
-}
-
-// ============================================================
-// Internal fetch helper (allows test injection)
+// Internal fetch override (allows test injection)
 // ============================================================
 
 type FetchFn = typeof globalThis.fetch;
 
-let _fetchFn: FetchFn = globalThis.fetch;
+let _overriddenFetch: FetchFn | null = null;
 
 /**
  * Override the fetch implementation (for testing).
  * Pass `null` to restore the default.
  */
 export function _setFetch(fn: FetchFn | null): void {
-  _fetchFn = fn ?? globalThis.fetch;
+  _overriddenFetch = fn;
 }
 
-async function apiRequest<T>(
-  method: string,
-  path: string,
-  body?: unknown
-): Promise<T> {
-  const url = `${GODADDY_API_BASE}${path}`;
-  const headers = getHeaders();
-
-  const options: RequestInit = { method, headers };
-  if (body !== undefined) {
-    options.body = JSON.stringify(body);
-  }
-
-  const response = await _fetchFn(url, options);
-
-  if (!response.ok) {
-    const text = await response.text();
-    throw new GoDaddyApiError(
-      `GoDaddy API ${method} ${path} failed with status ${response.status}: ${text}`,
-      response.status,
-      text
-    );
-  }
-
-  // Some endpoints return 204 No Content
-  if (response.status === 204) {
-    return undefined as unknown as T;
-  }
+// ============================================================
+// Connector Instance Management
+// ============================================================
 
-  return (await response.json()) as T;
+function createConnector(): GoDaddy {
+  // Use fromEnv() which reads GODADDY_API_KEY and GODADDY_API_SECRET
+  return GoDaddy.fromEnv();
 }
 
 // ============================================================
-// API Functions
+// API Functions (thin wrappers around connector)
 // ============================================================
 
 /**
  * List all domains in the GoDaddy account.
  */
 export async function listGoDaddyDomains(): Promise<GoDaddyDomain[]> {
-  return apiRequest<GoDaddyDomain[]>("GET", "/v1/domains");
+  if (_overriddenFetch) {
+    return _legacyApiRequest<GoDaddyDomain[]>("GET", "/v1/domains");
+  }
+  const connector = createConnector();
+  return connector.domains.list();
 }
 
 /**
@@ -168,10 +94,14 @@ export async function listGoDaddyDomains(): Promise<GoDaddyDomain[]> {
 export async function getDomainInfo(
   domain: string
 ): Promise<GoDaddyDomainDetail> {
-  return apiRequest<GoDaddyDomainDetail>(
-    "GET",
-    `/v1/domains/${encodeURIComponent(domain)}`
-  );
+  if (_overriddenFetch) {
+    return _legacyApiRequest<GoDaddyDomainDetail>(
+      "GET",
+      `/v1/domains/${encodeURIComponent(domain)}`
+    );
+  }
+  const connector = createConnector();
+  return connector.domains.getInfo(domain);
 }
 
 /**
@@ -180,11 +110,15 @@ export async function getDomainInfo(
 export async function renewDomain(
   domain: string
 ): Promise<{ orderId: number; itemCount: number; total: number }> {
-  return apiRequest(
-    "POST",
-    `/v1/domains/${encodeURIComponent(domain)}/renew`,
-    { period: 1 }
-  );
+  if (_overriddenFetch) {
+    return _legacyApiRequest(
+      "POST",
+      `/v1/domains/${encodeURIComponent(domain)}/renew`,
+      { period: 1 }
+    );
+  }
+  const connector = createConnector();
+  return connector.domains.renew(domain);
 }
 
 /**
@@ -194,10 +128,16 @@ export async function getDnsRecords(
   domain: string,
   type?: string
 ): Promise<GoDaddyDnsRecord[]> {
-  const path = type
-    ? `/v1/domains/${encodeURIComponent(domain)}/records/${encodeURIComponent(type)}`
-    : `/v1/domains/${encodeURIComponent(domain)}/records`;
-  return apiRequest<GoDaddyDnsRecord[]>("GET", path);
+  if (_overriddenFetch) {
+    const path = type
+      ? `/v1/domains/${encodeURIComponent(domain)}/records/${encodeURIComponent(type)}`
+      : `/v1/domains/${encodeURIComponent(domain)}/records`;
+    return _legacyApiRequest<GoDaddyDnsRecord[]>("GET", path);
+  }
+  const connector = createConnector();
+  return type
+    ? connector.dns.getRecords(domain, type)
+    : connector.dns.getRecords(domain);
 }
 
 /**
@@ -207,11 +147,16 @@ export async function setDnsRecords(
   domain: string,
   records: GoDaddyDnsRecord[]
 ): Promise<void> {
-  await apiRequest<void>(
-    "PUT",
-    `/v1/domains/${encodeURIComponent(domain)}/records`,
-    records
-  );
+  if (_overriddenFetch) {
+    await _legacyApiRequest<void>(
+      "PUT",
+      `/v1/domains/${encodeURIComponent(domain)}/records`,
+      records
+    );
+    return;
+  }
+  const connector = createConnector();
+  await connector.dns.replaceAllRecords(domain, records);
 }
 
 /**
@@ -220,14 +165,79 @@ export async function setDnsRecords(
 export async function checkAvailability(
   domain: string
 ): Promise<GoDaddyAvailability> {
-  return apiRequest<GoDaddyAvailability>(
-    "GET",
-    `/v1/domains/available?domain=${encodeURIComponent(domain)}`
-  );
+  if (_overriddenFetch) {
+    return _legacyApiRequest<GoDaddyAvailability>(
+      "GET",
+      `/v1/domains/available?domain=${encodeURIComponent(domain)}`
+    );
+  }
+  const connector = createConnector();
+  return connector.domains.checkAvailability(domain);
+}
+
+// ============================================================
+// Legacy fetch helper (for test injection compatibility)
+// ============================================================
+
+const GODADDY_API_BASE = "https://api.godaddy.com";
+
+function _getCredentials(): { key: string; secret: string } {
+  const key = process.env["GODADDY_API_KEY"];
+  const secret = process.env["GODADDY_API_SECRET"];
+
+  if (!key || !secret) {
+    throw new Error(
+      "GoDaddy API credentials not configured. Set GODADDY_API_KEY and GODADDY_API_SECRET environment variables."
+    );
+  }
+
+  return { key, secret };
+}
+
+function _getHeaders(): Record<string, string> {
+  const { key, secret } = _getCredentials();
+  return {
+    Authorization: `sso-key ${key}:${secret}`,
+    "Content-Type": "application/json",
+    Accept: "application/json",
+  };
+}
+
+async function _legacyApiRequest<T>(
+  method: string,
+  path: string,
+  body?: unknown
+): Promise<T> {
+  const fetchFn = _overriddenFetch || globalThis.fetch;
+  const url = `${GODADDY_API_BASE}${path}`;
+  const headers = _getHeaders();
+
+  const options: RequestInit = { method, headers };
+  if (body !== undefined) {
+    options.body = JSON.stringify(body);
+  }
+
+  const response = await fetchFn(url, options);
+
+  if (!response.ok) {
+    const text = await response.text();
+    throw new GoDaddyApiError(
+      `GoDaddy API ${method} ${path} failed with status ${response.status}: ${text}`,
+      response.status,
+      { responseBody: text }
+    );
+  }
+
+  // Some endpoints return 204 No Content
+  if (response.status === 204) {
+    return undefined as unknown as T;
+  }
+
+  return (await response.json()) as T;
 }
 
 // ============================================================
-// Sync to Local DB
+// Sync to Local DB (microservice business logic)
 // ============================================================
 
 /**
@@ -278,7 +288,7 @@ export async function syncToLocalDb(dbFns: {
 
   for (const gd of gdDomains) {
     try {
-      // Fetch full detail for each domain
+      // Fetch full detail for each domain via connector
       let detail: GoDaddyDomainDetail;
       try {
         detail = await getDomainInfo(gd.domain);