@hasna/loops 0.3.47 → 0.3.49

package/dist/lib/store.js

@@ -327,6 +327,13 @@ function optionalPositiveInteger(value, label) {
     throw new Error(`${label} must be a positive integer`);
   return value;
 }
+function optionalBoolean(value, label) {
+  if (value === undefined)
+    return;
+  if (typeof value !== "boolean")
+    throw new Error(`${label} must be a boolean`);
+  return value;
+}
 function optionalStringArray(value, label) {
   if (value === undefined)
     return;
@@ -338,6 +345,18 @@ function optionalStringArray(value, label) {
   }).filter(Boolean);
   return values.length ? values : undefined;
 }
+function optionalAccountRef(value, label) {
+  if (value === undefined)
+    return;
+  assertObject(value, label);
+  assertString(value.profile, `${label}.profile`);
+  if (value.tool !== undefined)
+    assertString(value.tool, `${label}.tool`);
+  return {
+    profile: value.profile.trim(),
+    tool: typeof value.tool === "string" ? value.tool.trim() : undefined
+  };
+}
 function normalizeGoalSpec(value, label = "goal") {
   if (value === undefined)
     return;
@@ -384,8 +403,21 @@ function validateTarget(value, label) {
       if (value.provider !== "codewith")
         throw new Error(`${label}.authProfile is currently supported only for provider codewith`);
     }
+    if (value.configIsolation !== undefined) {
+      assertString(value.configIsolation, `${label}.configIsolation`);
+      if (!["safe", "none"].includes(value.configIsolation))
+        throw new Error(`${label}.configIsolation must be safe or none`);
+    }
+    if (value.model !== undefined)
+      assertString(value.model, `${label}.model`);
     if (value.variant !== undefined)
       assertString(value.variant, `${label}.variant`);
+    if (value.agent !== undefined)
+      assertString(value.agent, `${label}.agent`);
+    if (value.provider === "cursor" && value.variant !== undefined)
+      throw new Error(`${label}.variant is not supported for provider cursor`);
+    if (value.provider === "codex" && value.agent !== undefined)
+      throw new Error(`${label}.agent is not supported for provider codex`);
     optionalStringArray(value.addDirs, `${label}.addDirs`);
     if (Array.isArray(value.addDirs) && value.addDirs.length > 0 && !["codewith", "codex"].includes(value.provider)) {
       throw new Error(`${label}.addDirs is currently supported only for provider codewith or codex`);
@@ -482,8 +514,10 @@ function normalizeCreateWorkflowInput(input) {
       id: step.id,
       goal: normalizeGoalSpec(step.goal, `workflow.steps[${index}].goal`),
       target: validateTarget(step.target, `workflow.steps[${index}].target`),
-      dependsOn: step.dependsOn ?? [],
-      continueOnFailure: step.continueOnFailure ?? false
+      dependsOn: optionalStringArray(step.dependsOn, `workflow.steps[${index}].dependsOn`) ?? [],
+      continueOnFailure: optionalBoolean(step.continueOnFailure, `workflow.steps[${index}].continueOnFailure`) ?? false,
+      timeoutMs: optionalPositiveInteger(step.timeoutMs, `workflow.steps[${index}].timeoutMs`),
+      account: optionalAccountRef(step.account, `workflow.steps[${index}].account`)
     };
   });
   for (const step of steps) {
@@ -584,6 +618,11 @@ function writeWorkflowRunManifest(args) {
 }
 
 // src/lib/store.ts
+var DEFAULT_RECOVERY_BATCH_LIMIT = 100;
+var DEFAULT_RECOVERY_SCAN_MULTIPLIER = 5;
+var LIVE_EXPIRED_RUN_GRACE_MS = 60000;
+var GENERATED_ROUTE_TEMPLATE_IDS = new Set(["todos-task-worker-verifier", "event-worker-verifier"]);
+var GENERATED_ROUTE_KEYS = new Set(["todos-task", "generic-event"]);
 function rowToLoop(row) {
   return {
     id: row.id,
@@ -850,6 +889,7 @@ class Store {
       ensurePrivateStorePath(file);
     this.rootDir = file === ":memory:" ? mkdtempSync(join3(tmpdir(), "open-loops-store-")) : dirname(file);
     this.db = new Database(file);
+    this.db.exec("PRAGMA foreign_keys = ON;");
     this.db.exec("PRAGMA busy_timeout = 5000;");
     this.db.exec("PRAGMA journal_mode = WAL;");
     if (file !== ":memory:")
@@ -913,6 +953,7 @@ class Store {
       );
       CREATE INDEX IF NOT EXISTS idx_runs_loop ON loop_runs(loop_id, created_at);
       CREATE INDEX IF NOT EXISTS idx_runs_status ON loop_runs(status);
+      CREATE INDEX IF NOT EXISTS idx_runs_status_lease ON loop_runs(status, lease_expires_at);
       CREATE INDEX IF NOT EXISTS idx_runs_scheduled ON loop_runs(scheduled_for);
 
       CREATE TABLE IF NOT EXISTS daemon_lease (
@@ -1240,39 +1281,51 @@ class Store {
     }
     return rows.map(rowToLoop);
   }
-  dueLoops(now) {
+  dueLoops(now, limit = 500) {
     const rows = this.db.query(`SELECT * FROM loops
          WHERE status = 'active'
            AND archived_at IS NULL
            AND next_run_at IS NOT NULL
            AND next_run_at <= ?
-         ORDER BY next_run_at ASC`).all(now.toISOString());
+         ORDER BY next_run_at ASC
+         LIMIT ?`).all(now.toISOString(), limit);
     return rows.map(rowToLoop);
   }
   updateLoop(id, patch, opts = {}) {
-    const current = this.getLoop(id);
-    if (!current)
-      throw new Error(`loop not found: ${id}`);
     const updated = (opts.now ?? new Date).toISOString();
-    const merged = { ...current, ...patch, updatedAt: updated };
-    this.db.query(`UPDATE loops SET status=$status, next_run_at=$nextRun, retry_scheduled_for=$retrySlot,
-         expires_at=$expiresAt, updated_at=$updated
-         WHERE id=$id
-           AND ($daemonLeaseId IS NULL OR EXISTS (
-             SELECT 1 FROM daemon_lease WHERE id=$daemonLeaseId AND expires_at > $now
-           ))`).run({
-      $id: id,
-      $status: merged.status,
-      $nextRun: merged.nextRunAt ?? null,
-      $retrySlot: merged.retryScheduledFor ?? null,
-      $expiresAt: merged.expiresAt ?? null,
-      $updated: merged.updatedAt,
-      $daemonLeaseId: opts.daemonLeaseId ?? null,
-      $now: updated
-    });
-    if (patch.status && patch.status !== "active") {
-      const status = patch.status === "paused" ? "deferred" : "cancelled";
-      this.setWorkflowWorkItemsForLoop(id, status, `loop ${patch.status}`, updated);
+    this.db.exec("BEGIN IMMEDIATE");
+    try {
+      const current = this.getLoop(id);
+      if (!current)
+        throw new Error(`loop not found: ${id}`);
+      const merged = { ...current, ...patch, updatedAt: updated };
+      const res = this.db.query(`UPDATE loops SET status=$status, next_run_at=$nextRun, retry_scheduled_for=$retrySlot,
+           expires_at=$expiresAt, updated_at=$updated
+           WHERE id=$id
+             AND ($daemonLeaseId IS NULL OR EXISTS (
+               SELECT 1 FROM daemon_lease WHERE id=$daemonLeaseId AND expires_at > $now
+             ))`).run({
+        $id: id,
+        $status: merged.status,
+        $nextRun: merged.nextRunAt ?? null,
+        $retrySlot: merged.retryScheduledFor ?? null,
+        $expiresAt: merged.expiresAt ?? null,
+        $updated: merged.updatedAt,
+        $daemonLeaseId: opts.daemonLeaseId ?? null,
+        $now: updated
+      });
+      if (res.changes !== 1)
+        throw new Error("daemon lease lost");
+      if (patch.status && patch.status !== "active") {
+        const status = patch.status === "paused" ? "deferred" : "cancelled";
+        this.setWorkflowWorkItemsForLoop(id, status, `loop ${patch.status}`, updated);
+      }
+      this.db.exec("COMMIT");
+    } catch (error) {
+      try {
+        this.db.exec("ROLLBACK");
+      } catch {}
+      throw error;
     }
     const after = this.getLoop(id);
     if (!after)
@@ -1390,10 +1443,23 @@ class Store {
     })();
   }
   listWorkflows(opts = {}) {
-    const limit = opts.limit ?? 200;
-    const rows = opts.status ? this.db.query("SELECT * FROM workflow_specs WHERE status = ? ORDER BY updated_at DESC LIMIT ?").all(opts.status, limit) : this.db.query("SELECT * FROM workflow_specs ORDER BY status ASC, updated_at DESC LIMIT ?").all(limit);
+    const offset = Math.max(0, opts.offset ?? 0);
+    let rows;
+    if (opts.status && opts.limit !== undefined) {
+      rows = this.db.query("SELECT * FROM workflow_specs WHERE status = ? ORDER BY updated_at DESC LIMIT ? OFFSET ?").all(opts.status, opts.limit, offset);
+    } else if (opts.status) {
+      rows = this.db.query("SELECT * FROM workflow_specs WHERE status = ? ORDER BY updated_at DESC LIMIT -1 OFFSET ?").all(opts.status, offset);
+    } else if (opts.limit !== undefined) {
+      rows = this.db.query("SELECT * FROM workflow_specs ORDER BY status ASC, updated_at DESC LIMIT ? OFFSET ?").all(opts.limit, offset);
+    } else {
+      rows = this.db.query("SELECT * FROM workflow_specs ORDER BY status ASC, updated_at DESC LIMIT -1 OFFSET ?").all(offset);
+    }
     return rows.map(rowToWorkflow);
   }
+  countWorkflows(opts = {}) {
+    const row = opts.status ? this.db.query("SELECT COUNT(*) AS count FROM workflow_specs WHERE status = ?").get(opts.status) : this.db.query("SELECT COUNT(*) AS count FROM workflow_specs").get();
+    return row?.count ?? 0;
+  }
   archiveWorkflow(idOrName) {
     const workflow = this.requireWorkflow(idOrName);
     const updated = nowIso();
@@ -1403,6 +1469,64 @@ class Store {
       throw new Error(`workflow not found after archive: ${workflow.id}`);
     return archived;
   }
+  generatedRouteArchiveContext(args) {
+    if (!args.loopId || !args.workItemId)
+      return;
+    const workItem = this.getWorkflowWorkItem(args.workItemId);
+    if (!workItem || !GENERATED_ROUTE_KEYS.has(workItem.routeKey))
+      return;
+    const invocation = this.getWorkflowInvocation(workItem.invocationId);
+    if (!invocation?.templateId || !GENERATED_ROUTE_TEMPLATE_IDS.has(invocation.templateId))
+      return;
+    const loop = this.getLoop(args.loopId);
+    if (!loop || loop.schedule.type !== "once" || loop.target.type !== "workflow" || loop.target.workflowId !== args.workflowId)
+      return;
+    const input = loop.target.input ?? {};
+    if (input.workflowWorkItemId && input.workflowWorkItemId !== workItem.id)
+      return;
+    if (input.workflowInvocationId && input.workflowInvocationId !== invocation.id)
+      return;
+    if (workItem.workflowId && workItem.workflowId !== args.workflowId)
+      return;
+    const workflow = this.getWorkflow(args.workflowId);
+    if (!workflow)
+      return;
+    return { workflow, loop, workItem, invocation };
+  }
+  maybeArchiveGeneratedRouteWorkflow(args) {
+    const context = this.generatedRouteArchiveContext(args);
+    if (!context)
+      return;
+    const { workflow, loop, workItem } = context;
+    if (!workflow || workflow.status !== "active")
+      return;
+    const nonTerminal = this.db.query(`SELECT COUNT(*) AS count FROM workflow_runs
+         WHERE workflow_id = ? AND status NOT IN ('succeeded', 'failed', 'timed_out', 'cancelled')`).get(args.workflowId)?.count ?? 0;
+    if (nonTerminal > 0)
+      return;
+    const res = this.db.query("UPDATE workflow_specs SET status='archived', updated_at=? WHERE id=? AND status='active'").run(args.updated, args.workflowId);
+    if (res.changes === 1 && args.workflowRunId) {
+      this.appendWorkflowEvent(args.workflowRunId, "workflow_archived", undefined, {
+        workflowId: args.workflowId,
+        loopId: loop.id,
+        workItemId: workItem.id,
+        routeKey: workItem.routeKey,
+        reason: "terminal generated one-shot route workflow"
+      });
+    }
+  }
+  maybeArchiveTerminalGeneratedRouteWorkflow(workflowRunId, updated) {
+    const run = this.getWorkflowRun(workflowRunId);
+    if (!run)
+      return;
+    this.maybeArchiveGeneratedRouteWorkflow({
+      workflowId: run.workflowId,
+      loopId: run.loopId,
+      workItemId: run.workItemId,
+      workflowRunId,
+      updated
+    });
+  }
   createWorkflowInvocation(input) {
     const now = nowIso();
     const sourceDedupeKey = input.sourceRef.dedupeKey ?? undefined;
@@ -2188,6 +2312,7 @@ class Store {
       if (changed) {
         const itemStatus = status === "succeeded" ? "succeeded" : status === "cancelled" ? "cancelled" : "failed";
         this.setWorkflowWorkItemsForWorkflowRun(workflowRunId, itemStatus, patch.error, finishedAt);
+        this.maybeArchiveTerminalGeneratedRouteWorkflow(workflowRunId, finishedAt);
       }
       this.db.exec("COMMIT");
     } catch (error) {
@@ -2215,6 +2340,7 @@ class Store {
              WHERE workflow_run_id=$workflowRunId AND status IN ('pending', 'running')`).run({ $workflowRunId: workflowRunId, $finished: now, $reason: reason, $updated: now });
         this.setWorkflowWorkItemsForWorkflowRun(workflowRunId, "cancelled", reason, now);
         this.appendWorkflowEvent(workflowRunId, "cancelled", undefined, { reason });
+        this.maybeArchiveTerminalGeneratedRouteWorkflow(workflowRunId, now);
       }
       this.db.exec("COMMIT");
       return this.requireWorkflowRun(workflowRunId);
@@ -2467,8 +2593,20 @@ class Store {
       throw new Error(`run not found after finalize: ${id}`);
     if (opts.claimedBy && res.changes !== 1)
       return run;
-    if (res.changes === 1)
+    if (res.changes === 1) {
       this.setWorkflowWorkItemsForLoopRun(run, patch.error, finishedAt);
+      const loop = this.getLoop(run.loopId);
+      const itemStatus = workItemStatusForLoopRun(run.status, run.attempt, loop?.maxAttempts);
+      if (loop?.target.type === "workflow" && itemStatus && itemStatus !== "admitted") {
+        const workItemId = loop.target.input?.workflowWorkItemId ?? loop.target.input?.workItemId;
+        this.maybeArchiveGeneratedRouteWorkflow({
+          workflowId: loop.target.workflowId,
+          loopId: loop.id,
+          workItemId,
+          updated: finishedAt
+        });
+      }
+    }
     return run;
   }
   heartbeatRunLease(id, claimedBy, leaseMs, now = new Date, opts = {}) {
@@ -2503,14 +2641,40 @@ class Store {
     }
     return rows.map(rowToRun);
   }
+  deferLiveExpiredRun(id, now, opts = {}) {
+    const updated = now.toISOString();
+    const deferredUntil = new Date(now.getTime() + LIVE_EXPIRED_RUN_GRACE_MS).toISOString();
+    this.db.query(`UPDATE loop_runs SET lease_expires_at=$deferredUntil, updated_at=$updated
+         WHERE id=$id AND status='running' AND lease_expires_at <= $now
+           AND ($daemonLeaseId IS NULL OR EXISTS (
+             SELECT 1 FROM daemon_lease WHERE id=$daemonLeaseId AND expires_at > $now
+           ))`).run({
+      $id: id,
+      $deferredUntil: deferredUntil,
+      $updated: updated,
+      $now: updated,
+      $daemonLeaseId: opts.daemonLeaseId ?? null
+    });
+  }
   recoverExpiredRunLeases(now = new Date, opts = {}) {
-    const rows = this.db.query("SELECT * FROM loop_runs WHERE status = 'running' AND lease_expires_at <= ?").all(now.toISOString());
+    const limit = Math.max(1, Math.min(1000, Math.floor(opts.limit ?? DEFAULT_RECOVERY_BATCH_LIMIT)));
+    const scanLimit = Math.max(limit, Math.min(5000, Math.floor(opts.scanLimit ?? limit * DEFAULT_RECOVERY_SCAN_MULTIPLIER)));
+    const rows = this.db.query(`SELECT * FROM loop_runs
+         WHERE status = 'running' AND lease_expires_at <= ?
+         ORDER BY lease_expires_at ASC
+         LIMIT ?`).all(now.toISOString(), scanLimit);
     const recovered = [];
     for (const row of rows) {
-      if (row.pid && isProcessAlive(row.pid))
+      if (recovered.length >= limit)
+        break;
+      if (row.pid && isProcessAlive(row.pid)) {
+        this.deferLiveExpiredRun(row.id, now, opts);
         continue;
-      if (this.hasLiveWorkflowStepProcesses(row.id))
+      }
+      if (this.hasLiveWorkflowStepProcesses(row.id)) {
+        this.deferLiveExpiredRun(row.id, now, opts);
         continue;
+      }
       const finished = now.toISOString();
       this.db.exec("BEGIN IMMEDIATE");
       try {
@@ -2563,6 +2727,7 @@ class Store {
             loopRunId: row.id
           });
           this.setWorkflowWorkItemsForWorkflowRun(workflowRow.id, "failed", "parent loop run lease expired before completion", finished);
+          this.maybeArchiveTerminalGeneratedRouteWorkflow(workflowRow.id, finished);
         }
         const loop = this.getLoop(row.loop_id);
         const itemStatus = workItemStatusForLoopRun("abandoned", row.attempt, loop?.maxAttempts);
@@ -2570,6 +2735,15 @@ class Store {
           const statuses = itemStatus === "admitted" ? ["admitted", "running", "failed"] : ["admitted", "running"];
           const reason = itemStatus === "admitted" ? "run lease expired before completion; retry pending" : "run lease expired before completion";
           this.setWorkflowWorkItemsForLoop(row.loop_id, itemStatus, reason, finished, statuses);
+          if (loop?.target.type === "workflow" && itemStatus !== "admitted") {
+            const workItemId = loop.target.input?.workflowWorkItemId ?? loop.target.input?.workItemId;
+            this.maybeArchiveGeneratedRouteWorkflow({
+              workflowId: loop.target.workflowId,
+              loopId: loop.id,
+              workItemId,
+              updated: finished
+            });
+          }
         }
         this.db.exec("COMMIT");
       } catch (error) {