@hasna/hooks 0.3.11 → 0.4.1

package/hooks/worktree-guard/src/hook.ts

@@ -1,6 +1,8 @@
 #!/usr/bin/env bun
 
 import {
+  canonicalRepoIdentity,
+  canonicalWorktreeTemplate,
   classifyDangerousOperation,
   claimCommand,
   gitCommandInfo,
@@ -10,7 +12,6 @@ import {
   managedWorktreeInfo,
   readInput,
   respond,
-  runIdFrom,
   taskIdFrom,
   warn,
   type CodewithHookInput,
@@ -40,27 +41,63 @@ export async function evaluate(input: CodewithHookInput): Promise<{ output: Reco
   const managed = managedWorktreeInfo(targetCwd);
   if (managed.managed) return { output: { continue: true }, warnings };
 
+  // Migration shim, temporary and deliberately narrow: worktrees created under the
+  // pre-rule-8 station-id lease layout are non-compliant, but they are real, active
+  // worktrees. Hard-blocking their git work on day one would strand in-flight tasks
+  // with no way to land, so this one recognised layout warns instead of blocking.
+  // Everything else non-canonical is still blocked. Remove once they are re-homed.
+  if (managed.layout === "legacy-station-lease") {
+    const message = `${managed.reason}. This layout will stop being tolerated; re-home this worktree.`;
+    warnings.push(message);
+    return {
+      output: {
+        continue: true,
+        hookSpecificOutput: {
+          hookEventName: "PreToolUse",
+          additionalContext: `[worktree-guard] ${message}`,
+        },
+      },
+      warnings,
+    };
+  }
+
   const repoRoot = await gitRepoRoot(targetCwd);
-  const repo = await gitRemoteSlug(targetCwd) || (repoRoot ? repoRoot.split("/").filter(Boolean).pop() || null : null);
+  // Rule 8 resolution order: the repos CLI is the source of truth for <repo-name>.
+  // The local checkout directory is the next best guess, and the remote slug is the
+  // last resort — for most repos the remote basename is NOT the canonical repo name.
+  const identity = await canonicalRepoIdentity(targetCwd);
+  const repo = identity.name
+    || (repoRoot ? repoRoot.split("/").filter(Boolean).pop() || null : null)
+    || (await gitRemoteSlug(targetCwd))?.split("/").filter(Boolean).pop()
+    || null;
   const taskId = taskIdFrom(input);
-  const runId = runIdFrom(input);
-  const recommended = claimCommand(repo, taskId, runId);
+  const recommended = claimCommand(repo, taskId, identity.defaultBranch);
   const action = gitInfo?.action || null;
+  const canonical = canonicalWorktreeTemplate(managed.root);
+  // Rule 8 requires an exact repos-CLI lookup for <repo-name>. When that lookup did
+  // not resolve, the name below is a local guess, so say so rather than imply it is
+  // authoritative — the repo directory name and the remote basename often differ.
+  const unverifiedRepoName = identity.name
+    ? null
+    : `Confirm <repo-name> with an exact repos CLI lookup first: repos repo ${repo || "<name>"} --json`;
 
   if (action) {
     const reason = [
-      `Blocked git ${action} outside a managed repos worktree (${managed.reason || "not under managed root"}).`,
+      `Blocked git ${action} outside a canonical task worktree (${managed.reason || "not under managed root"}).`,
       `Command target cwd: ${targetCwd}`,
-      `Managed root: ${managed.root}`,
-      `Claim a task worktree first: ${recommended}`,
+      `Canonical worktree path (Agent Operating Rules rule 8): ${canonical}`,
+      `Create one first: ${recommended}`,
+      ...(unverifiedRepoName ? [unverifiedRepoName] : []),
     ].join(" ");
     return { output: { decision: "block", reason }, warnings };
   }
 
   if (isFeatureWork(input, command)) {
     warnings.push([
-      `Feature work appears to be outside a managed repos worktree (${managed.reason || "not under managed root"}).`,
+      `Feature work appears to be outside a canonical task worktree (${managed.reason || "not under managed root"}).`,
+      `Canonical worktree path (Agent Operating Rules rule 8): ${canonical}.`,
       `Use: ${recommended}`,
+      ...(unverifiedRepoName ? [unverifiedRepoName] : []),
     ].join(" "));
     return {
       output: {
@@ -91,4 +128,9 @@ export async function run(): Promise<void> {
 
 if (import.meta.main) {
   await run();
+  // The verdict is written, so the hook is done. Exit rather than waiting for the
+  // event loop to drain: an optional CLI consulted during evaluation may have left a
+  // grandchild holding a pipe open, and a hook that has already answered must never
+  // keep the caller's PreToolUse path waiting on it.
+  process.exit(0);
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hasna/hooks",
-  "version": "0.3.11",
+  "version": "0.4.1",
   "description": "Open source hooks library for AI coding agents - Install safety, quality, and automation hooks with a single command",
   "type": "module",
   "bin": {