@hashicorp/react-components 0.0.0-nightly.2c654ea → 0.0.0-nightly.331cbb5

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@hashicorp/react-components",
-	"version": "0.0.0-nightly.2c654ea",
+	"version": "0.0.0-nightly.331cbb5",
 	"main": "src/index.ts",
 	"scripts": {
 		"lint": "next-hashicorp lint",
@@ -8,7 +8,7 @@
 		"test:watch": "vitest watch"
 	},
 	"dependencies": {
-		"@hashicorp/flight-icons": "^3.5.0",
+		"@hashicorp/flight-icons": "^3.7.0",
 		"@hashicorp/platform-product-meta": "^0.1.1",
 		"@hashicorp/platform-util": "^0.2.0",
 		"@hashicorp/react-design-system-components": "*",

package/src/components/card/index.test.tsx

@@ -56,7 +56,7 @@ describe('<Card />', () => {
 		const metaElement = screen.getByTestId('wpl-card-meta')
 
 		cardMeta.forEach((item) => {
-			expect(metaElement).toContainElement(screen.getByText(item))
+			expect(metaElement).toHaveTextContent(item)
 		})
 		expect(metaElement).toContainElement(screen.getByText('|'))
 	})

package/src/components/card/newsroom-card/index.test.tsx

@@ -26,7 +26,7 @@ describe('<NewsroomCard />', () => {
 		const metaElement = screen.getByTestId('wpl-card-meta')
 
 		expectedMeta.forEach((item) => {
-			expect(metaElement).toContainElement(screen.getByText(item))
+			expect(metaElement).toHaveTextContent(item)
 		})
 
 		expect(metaElement).toContainElement(screen.queryByText('|'))

package/src/components/card/primitives.tsx

@@ -33,6 +33,7 @@ const Card = React.forwardRef<HTMLAnchorElement, CardPrimitiveProps>(
 			hasBorder = true,
 			children,
 			className,
+			'aria-label': ariaLabel,
 		} = props
 
 		const linkProps = isExternal
@@ -58,7 +59,7 @@ const Card = React.forwardRef<HTMLAnchorElement, CardPrimitiveProps>(
 						href={link}
 						ref={ref}
 						className={s.link}
-						aria-label={heading}
+						aria-label={ariaLabel ?? heading}
 						onClickCapture={clickHandler}
 						{...linkProps}
 					/>
@@ -100,23 +101,23 @@ function LogoThumbnail({ src, alt }: ThumbnailProps) {
 
 function Meta({ items }: MetaProps) {
 	return (
-		<ul className={s.meta} data-testid="wpl-card-meta">
-			{items.map((item, stableIdx) => {
-				return (
-					// eslint-disable-next-line react/no-array-index-key
-					<li key={stableIdx}>
-						<TextPlus.Label>
+		<div className={s.meta} data-testid="wpl-card-meta">
+			<TextPlus.Label>
+				{items.map((item, stableIdx) => {
+					const isLastItem = stableIdx === items.length - 1
+					return (
+						<>
 							{item}
-							{stableIdx < items.length - 1 ? (
+							{!isLastItem ? (
 								<span className={s.metaSeparator} aria-hidden={true}>
 									|
 								</span>
 							) : null}
-						</TextPlus.Label>
-					</li>
-				)
-			})}
-		</ul>
+						</>
+					)
+				})}
+			</TextPlus.Label>
+		</div>
 	)
 }
 

package/src/components/card/resource-card/index.test.tsx

@@ -26,7 +26,7 @@ describe('<ResourceCard />', () => {
 		const metaElement = screen.getByTestId('wpl-card-meta')
 
 		expectedMeta.forEach((item) => {
-			expect(metaElement).toContainElement(screen.getByText(item))
+			expect(metaElement).toHaveTextContent(item)
 		})
 
 		expect(metaElement).toContainElement(screen.getByText('|'))

package/src/components/card/types.ts

@@ -10,14 +10,14 @@ import type { PersonCardProps } from './person-card'
 import type { ResourceCardProps } from './resource-card'
 import type { UnifiedCardProps } from './unified-card'
 
-export interface BaseCardProps {
+export interface BaseCardProps
+	extends React.AnchorHTMLAttributes<HTMLAnchorElement> {
 	withArrow?: boolean
 	heading: string
 	link: string
 	clickHandler?: () => void
 	isExternal?: boolean
 	hasBorder?: boolean
-	className?: string
 }
 
 export interface CardPrimitiveProps extends BaseCardProps {

package/src/components/card/unified-card/index.spec.tsx

@@ -0,0 +1,40 @@
+/**
+ * Copyright (c) HashiCorp, Inc.
+ * SPDX-License-Identifier: MPL-2.0
+ */
+
+import { render, screen } from '@testing-library/react'
+import { UnifiedCard, UnifiedCardProps } from '.'
+
+const defaultProps: UnifiedCardProps = {
+	link: 'https://hashicorp.com',
+	heading: 'Example heading',
+	thumbnail: {
+		src: 'https://www.datocms-assets.com/19447/1648680074-screenshot-2022-03-31-at-00-40-47.png',
+		alt: 'HashiConf Europe 2022 Recap',
+	},
+} as const
+
+describe(`<UnifiedCard />`, () => {
+	it('should render the provided meta with a separator if n > 1', () => {
+		const expectedMeta = ['Category', 'Hello']
+		render(<UnifiedCard {...defaultProps} meta={expectedMeta} />)
+
+		const metaElement = screen.getByTestId('wpl-card-meta')
+
+		expectedMeta.forEach((item) => {
+			expect(metaElement).toHaveTextContent(item)
+		})
+
+		expect(metaElement).toContainElement(screen.getByText('|'))
+	})
+
+	it('it should not render a separator if n === 1', () => {
+		render(<UnifiedCard {...defaultProps} meta={['Category']} />)
+		const metaElement = screen.getByTestId('wpl-card-meta')
+
+		expect(metaElement).toContainElement(screen.getByText('Category'))
+
+		expect(metaElement).not.toContainElement(screen.queryByText('|'))
+	})
+})

package/src/components/card/unified-card/index.tsx

@@ -6,18 +6,10 @@
 import type { ReactNode } from 'react'
 import Badge from '@hashicorp/react-design-system-components/src/components/badge'
 import * as CardPrimitives from '../primitives'
-import type { CardProps, ThumbnailProps } from '../types'
+import type { CardProps } from '../types'
 
-export interface UnifiedCardProps {
-	heading: string
-	meta?: string[]
-	link: string
-	productBadges?: CardProps['productBadges']
+export interface UnifiedCardProps extends CardProps {
 	badges?: (string | [ReactNode, string])[]
-	thumbnail?: ThumbnailProps
-	withArrow?: boolean
-	isExternal?: boolean
-	className?: string
 }
 
 export function UnifiedCard({
@@ -30,6 +22,7 @@ export function UnifiedCard({
 	withArrow = false,
 	isExternal = false,
 	className,
+	'aria-label': ariaLabel,
 }: UnifiedCardProps) {
 	return (
 		<CardPrimitives.Card
@@ -38,6 +31,7 @@ export function UnifiedCard({
 			withArrow={withArrow}
 			isExternal={isExternal}
 			className={className}
+			aria-label={ariaLabel ?? heading}
 		>
 			{thumbnail ? <CardPrimitives.Thumbnail {...thumbnail} /> : null}
 			<CardPrimitives.Content>

package/src/components/nav-panel/components/link-list/index.tsx

@@ -1,6 +1,6 @@
 import Link from 'next/link'
 import { parseUrl } from '../../../../lib/parse-url'
-import { v } from '../../../../lib/v'
+import { vercelSplit } from '../../../../lib/v'
 import FlightIcon from '@hashicorp/react-design-system-components/src/components/flight-icon'
 import * as NavigationMenu from '@radix-ui/react-navigation-menu'
 import s from './style.module.css'
@@ -44,8 +44,9 @@ export default function LinkList({ links, linkClickHandler }: LinkListProps) {
 				let style
 				link.iconGradient
 					? (style = {
-							'--iconGradient': GRADIENT_VALUE_MAP.get(v(link.iconGradient))
-								?.iconGradient,
+							'--iconGradient': GRADIENT_VALUE_MAP.get(
+								vercelSplit(link.iconGradient)
+							)?.iconGradient,
 					  } as React.CSSProperties)
 					: (style = null)
 				return (
@@ -60,12 +61,12 @@ export default function LinkList({ links, linkClickHandler }: LinkListProps) {
 							>
 								{link.iconGradient && link.icon ? (
 									<div className={s.iconBackground} style={style}>
-										<FlightIcon name={v(link.icon)} />
+										<FlightIcon name={vercelSplit(link.icon)} />
 									</div>
 								) : (
 									link.icon && (
 										<FlightIcon
-											name={v(link.icon)}
+											name={vercelSplit(link.icon)}
 											color="var(--token-color-foreground-faint)"
 										/>
 									)

package/src/components/nav-panel/components/panel/column/style.module.css

@@ -1,4 +1,4 @@
-@custom-media --dev-dot-viewport (min-width: 1230px);
+@custom-media --dev-dot-viewport (min-width: 924px);
 
 .column {
 	position: relative;
@@ -7,7 +7,7 @@
 	justify-content: flex-start;
 	min-width: 190px;
 	padding: 0;
-	margin: 0 var(--hdsplus-spacing-05);
+	margin: 0 var(--hdsplus-spacing-07);
 	border-radius: var(--hdsplus-spacing-03);
 
 	@media (--large) {

package/src/components/nav-panel/components/panel/root/style.module.css

@@ -1,4 +1,4 @@
-@custom-media --dev-dot-viewport (min-width: 1230px);
+@custom-media --dev-dot-viewport (min-width: 924px);
 
 .root {
 	width: 100%;

package/src/components/nav-panel/components/promo/index.tsx

@@ -1,6 +1,6 @@
 import { useCallback } from 'react'
 import classNames from 'classnames'
-import { v } from '../../../../lib/v'
+import { vercelSplit } from '../../../../lib/v'
 import Link from 'next/link'
 import { parseUrl } from '../../../../lib/parse-url'
 import { trackNavClickEvent } from '../../../../lib/track-nav-click-event'
@@ -51,19 +51,19 @@ export default function Promo({
 			{icon && (
 				<div
 					className={classNames(s.icon, {
-						[s.hashidays]: v(theme) === 'hashidays',
-						[s.hashiconf]: v(theme) === 'hashiconf',
+						[s.hashidays]: vercelSplit(theme) === 'hashidays',
+						[s.hashiconf]: vercelSplit(theme) === 'hashiconf',
 					})}
 				>
-					<FlightIcon name={v(icon)} />
+					<FlightIcon name={vercelSplit(icon)} />
 				</div>
 			)}
 			<div className={s.rightContent}>
 				<div>
 					<div
 						className={classNames(s.title, {
-							[s.hashidays]: v(theme) === 'hashidays',
-							[s.hashiconf]: v(theme) === 'hashiconf',
+							[s.hashidays]: vercelSplit(theme) === 'hashidays',
+							[s.hashiconf]: vercelSplit(theme) === 'hashiconf',
 						})}
 					>
 						{title}

package/src/components/nav-panel/components/promo/style.module.css

@@ -1,4 +1,4 @@
-@custom-media --dev-dot-viewport (min-width: 1230px);
+@custom-media --dev-dot-viewport (min-width: 924px);
 
 .promo {
 	display: flex;
@@ -9,7 +9,8 @@
 		var(--hdsplus-spacing-06) var(--hdsplus-spacing-08);
 	flex-direction: row;
 	gap: var(--hdsplus-spacing-04);
-	margin: var(--hdsplus-spacing-05);
+	margin: var(--hdsplus-spacing-07);
+	margin-bottom: var(--hdsplus-spacing-09);
 
 	@media (--large) {
 		&.noSide {

package/src/components/nav-panel/product-panel/index.tsx

@@ -1,4 +1,3 @@
-import { CSSProperties } from 'react'
 import classNames from 'classnames'
 import Link from 'next/link'
 import * as NavPanel from '../components/panel'
@@ -64,17 +63,7 @@ const ProductPanel = ({
 							return (
 								<li key={title} className={s.productCategory}>
 									<TextPlus.Body className={s.eyebrow}>{title}</TextPlus.Body>
-									<ul
-										className={s.productList}
-										// Dynamically calculate row count based on number of items divided by expected columns
-										style={
-											{
-												'--row-count-above-mobile': Math.ceil(
-													products.length / 2
-												),
-											} as CSSProperties
-										}
-									>
+									<ul className={s.productList}>
 										{products.map((product) => {
 											return (
 												<li key={product.url}>
@@ -106,7 +95,11 @@ const ProductPanel = ({
 						{sidePanel.navItems.map(({ icon, title, description, url }) => {
 							return (
 								<li key={title}>
-									<Link href={parseUrl(url).href} className={s.sidePanelItem}>
+									<Link
+										aria-label={`${title} - ${description}`}
+										href={parseUrl(url).href}
+										className={classNames(s.sidePanelItem, s.focusIndicator)}
+									>
 										<div className={s.iconBackground}>
 											<FlightIcon
 												size={16}
@@ -141,6 +134,7 @@ function NavProduct({ url, product, description }: NavProductProps) {
 	return (
 		<NavigationMenu.Link asChild>
 			<Link
+				aria-label={`${product} - ${description}`}
 				href={parseUrl(url).href}
 				onClickCapture={() => {
 					trackNavClickEvent(product, url, 'products')

package/src/components/nav-panel/product-panel/style.module.css

@@ -1,4 +1,4 @@
-@custom-media --dev-dot-viewport (min-width: 1230px);
+@custom-media --dev-dot-viewport (min-width: 924px);
 
 .productPanel {
 	height: 100%;
@@ -26,7 +26,7 @@
 	list-style: none;
 	padding: 0;
 	display: grid;
-	margin: var(--hdsplus-spacing-06) 0 0;
+	margin: var(--hdsplus-spacing-07) 0 0;
 
 	@media (--large) {
 		@nest .noSide & {
@@ -84,9 +84,9 @@
 		@nest .noSide & {
 			padding: var(--hdsplus-spacing-06) var(--hdsplus-spacing-05)
 				var(--hdsplus-spacing-04);
-			grid-auto-flow: column;
+			grid-auto-flow: row;
 			grid-template-columns: repeat(2, 300px);
-			grid-template-rows: repeat(var(--row-count-above-mobile, 1), max-content);
+			grid-template-rows: repeat(2, max-content);
 			gap: 0;
 		}
 	}
@@ -95,9 +95,9 @@
 		@nest .hasSide & {
 			padding: var(--hdsplus-spacing-06) var(--hdsplus-spacing-05)
 				var(--hdsplus-spacing-04);
-			grid-auto-flow: column;
+			grid-auto-flow: row;
 			grid-template-columns: repeat(2, 300px);
-			grid-template-rows: repeat(var(--row-count-above-mobile, 1), max-content);
+			grid-template-rows: repeat(2, max-content);
 			gap: 0;
 		}
 	}
@@ -197,14 +197,14 @@
 
 	@media (--large) {
 		@nest .noSide & {
-			padding: var(--hdsplus-spacing-07) 0 var(--hdsplus-spacing-05)
+			padding: var(--hdsplus-spacing-07) 0 var(--hdsplus-spacing-09)
 				var(--hdsplus-spacing-04);
 		}
 	}
 
 	@media (--dev-dot-viewport) {
 		@nest .hasSide & {
-			padding: var(--hdsplus-spacing-07) 0 var(--hdsplus-spacing-05)
+			padding: var(--hdsplus-spacing-07) 0 var(--hdsplus-spacing-09)
 				var(--hdsplus-spacing-04);
 		}
 	}

package/src/components/nav-panel/standard-panel/style.module.css

@@ -2,7 +2,7 @@
 	display: flex;
 	gap: var(--hdsplus-spacing-03);
 	flex-direction: column;
-	margin-top: var(--hdsplus-spacing-06);
+	margin-top: var(--hdsplus-spacing-07);
 
 	@media (--large) {
 		flex-direction: row;

package/src/components/subnav/index.tsx

@@ -17,7 +17,6 @@ import CtaLinks, { type CtaLinkProps } from './partials/CtaLinks'
 import traverse, { isObject } from './helpers/traverse'
 import { areBasePathsMatching } from './helpers/areBasePathsMatching'
 import * as NavigationMenu from '@radix-ui/react-navigation-menu'
-import themeStyles from './theme.module.css'
 import s from './style.module.css'
 
 const productAllowList = {
@@ -165,6 +164,10 @@ function Subnav({ className, theme = 'light', ...restProps }: SubnavProps) {
 		setActivePanel(panel)
 	}
 
+	const ariaLabel = restProps?.titleLink?.text
+		? `${restProps.titleLink.text} pages`
+		: 'Subnav pages'
+
 	return (
 		<>
 			{/**
@@ -175,11 +178,12 @@ function Subnav({ className, theme = 'light', ...restProps }: SubnavProps) {
 			<style>{`:root{--subnav-height:${height}px}`}</style>
 			<NavigationMenu.Root
 				ref={wrapperRef}
-				className={classNames(s.root, themeStyles[theme], className, {
+				className={classNames(s.root, className, {
 					[s.isSticky]: isSticky,
 					[s.hasOverflow]: hasOverflow,
+					'hdsplus-dark-mode': theme === 'dark',
 				})}
-				aria-label={`${product} website navigation`}
+				aria-label={ariaLabel}
 				onValueChange={activatePanel}
 				value={activePanel}
 				delayDuration={0}

package/src/components/subnav/partials/CtaLinks/github-stars-link/style.module.css

@@ -3,15 +3,13 @@
  * SPDX-License-Identifier: MPL-2.0
  */
 
-/* Note: consumes from theme.module.css, as marked */
-
 .root {
-	--local-scrim-color: transparent;
-	--local-divider-color: var(--border-color); /* from theme.module.css */
+	--local-scrim-opacity: 0;
+	--local-divider-color: var(--token-color-border-primary);
 
 	position: relative;
-	color: var(--gh-stars-icon-color); /* from theme.module.css */
-	border: 1px solid var(--local-divider-color); /* from theme.module.css */
+	color: var(--token-color-foreground-primary);
+	border: 1px solid var(--local-divider-color);
 	border-radius: 5px;
 	background: none;
 	transition: background 0.2s, border-color 0.2s;
@@ -27,17 +25,15 @@
 		right: -1px;
 		bottom: -1px;
 		border-radius: 5px;
-		transition: background 0.25s ease;
+		transition: opacity 0.25s ease;
+		opacity: var(--local-scrim-opacity);
 		z-index: 0;
-		background-color: var(--local-scrim-color);
+		background-color: var(--token-color-foreground-primary);
 	}
 
 	&:hover,
 	&:active {
-		--local-divider-color: transparent;
-		--local-scrim-color: var(
-			--gh-stars-scrim-color
-		); /* from theme.module.css */
+		--local-scrim-opacity: 0.12;
 	}
 }
 

package/src/components/subnav/partials/CtaLinks/style.module.css

@@ -10,26 +10,26 @@
 	list-style: none;
 	padding: 0 0 0 var(--hdsplus-spacing-05);
 	margin: 0;
-	gap: 0 12px;
+	gap: 0 var(--hdsplus-spacing-04);
 	@media (--medium-up) {
 		gap: 0;
 	}
 
 	& > * + * {
 		/* Spaces consecutive buttons horizontally on desktop */
-		margin-left: 16px;
+		margin-left: var(--hdsplus-spacing-05);
 	}
 
 	&.isInDropdown {
 		/* Allows consecutive buttons to wrap */
 		flex-wrap: wrap;
 		white-space: wrap;
-		padding-left: 0;
+		padding-inline: var(--hdsplus-spacing-04);
 
 		& > * {
 			/* Spaces consecutive buttons vertically */
 			margin-left: 0;
-			margin-top: 16px;
+			margin-top: var(--hdsplus-spacing-05);
 
 			&:last-of-type {
 				margin-bottom: var(--hdsplus-spacing-04);

package/src/components/subnav/partials/DropdownTrigger/index.tsx

@@ -27,7 +27,7 @@ function DropdownTrigger(props: DropdownTriggerProps) {
 			onMouseDown={(e) => e.preventDefault()}
 		>
 			<NavItemText isActive={isActive} text={text} />
-			<FlightIcon name="chevron-down" color="var(--menu-item-text-color)" />
+			<FlightIcon name="chevron-down" />
 		</NavigationMenu.Trigger>
 	)
 }

package/src/components/subnav/partials/DropdownTrigger/style.module.css

@@ -3,8 +3,6 @@
  * SPDX-License-Identifier: MPL-2.0
  */
 
-/* Note: consumes from theme.module.css, as marked */
-
 .root {
 	composes: hds-typography-body-200 from global;
 	composes: hds-font-weight-medium from global;
@@ -26,11 +24,16 @@
 		width: 12px;
 		height: 12px;
 		transition: transform 0.3s;
-		fill: var(--menu-item-text-color); /* from theme.module.css */
+		fill: var(--token-color-foreground-primary);
 	}
 
 	&:hover {
-		background-color: var(--menu-item-hover-color);
+		background-color: var(--token-color-surface-interactive-hover);
 		border-radius: var(--hdsplus-spacing-01);
 	}
+
+	&:focus {
+		outline: 2px solid var(--token-color-focus-action-internal);
+		outline-style: auto;
+	}
 }

package/src/components/subnav/partials/MenuItemsDefault/index.tsx

@@ -9,13 +9,19 @@ import NavItemText from '../nav-item-text'
 import DropdownTrigger from '../DropdownTrigger'
 import * as NavigationMenu from '@radix-ui/react-navigation-menu'
 import s from './style.module.css'
+import FlightIcon from '@hashicorp/react-design-system-components/src/components/flight-icon'
 
 interface MenuItemsDefaultProps {
 	menuItems: (
 		| {
 				text: string
 				url: string
-				submenu: { text: string; url: string; _isActiveUrl: string }[]
+				submenu: {
+					icon: string
+					text: string
+					url: string
+					_isActiveUrl: string
+				}[]
 				_isActiveUrl: boolean
 		  }
 		| 'divider'
@@ -86,7 +92,7 @@ function NavLink(props: NavLinkProps) {
 
 interface NavLinkWithDropdownProps {
 	text: string
-	submenu: { text: string; url: string; _isActiveUrl: string }[]
+	submenu: { icon: string; text: string; url: string; _isActiveUrl: string }[]
 	activatePanel: (panel: string) => void
 }
 
@@ -128,12 +134,13 @@ class NavLinkWithDropdown extends React.Component<
 					<NavigationMenu.Sub>
 						<NavigationMenu.List className={s.dropdownList}>
 							{submenu.map((submenuItem, stableIdx) => {
-								const { text, url } = submenuItem
+								const { icon, text, url } = submenuItem
 								return (
 									// eslint-disable-next-line react/no-array-index-key
 									<NavigationMenu.Item key={stableIdx}>
 										<NavigationMenu.Link asChild>
 											<Link className={s.submenuItem} href={url}>
+												{icon ? <FlightIcon name={icon} /> : null}
 												{text}
 											</Link>
 										</NavigationMenu.Link>