@hashicorp/design-system-components 0.5.0 → 0.5.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,11 @@
1
1
  # @hashicorp/design-system-components
2
2
 
3
+ ## 0.5.1
4
+
5
+ ### Patch Changes
6
+
7
+ - [#133](https://github.com/hashicorp/design-system/pull/133) [`6ed18c7f`](https://github.com/hashicorp/design-system/commit/6ed18c7f9bf211141ac38005e6bd3aea2dbbf1c7) Thanks [@didoo](https://github.com/didoo)! - small change to the “noop“ guard in the “@didInsert“ method of the “Disclosure“ component
8
+
3
9
  ## 0.5.0
4
10
 
5
11
  ### Minor Changes
@@ -1,6 +1,6 @@
1
1
  import Component from '@glimmer/component';
2
2
 
3
- const noop = () => {};
3
+ const NOOP = () => {};
4
4
 
5
5
  export default class HdsBreadcrumbComponent extends Component {
6
6
  /**
@@ -9,8 +9,13 @@ export default class HdsBreadcrumbComponent extends Component {
9
9
  * @default () => {}
10
10
  */
11
11
  get didInsert() {
12
- // TODO discuss with Matthew if this is the right way to create a guard for this method
13
- return this.args.didInsert ?? noop;
12
+ let { didInsert } = this.args;
13
+
14
+ if (typeof didInsert === 'function') {
15
+ return didInsert;
16
+ } else {
17
+ return NOOP;
18
+ }
14
19
  }
15
20
 
16
21
  /**
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@hashicorp/design-system-components",
3
- "version": "0.5.0",
3
+ "version": "0.5.1",
4
4
  "description": "HashiCorp Design System Components",
5
5
  "keywords": [
6
6
  "hashicorp",