@harperfast/harper 5.2.0-beta.4 → 5.2.1

package/dist/resources/DatabaseTransaction.js

@@ -34,12 +34,15 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ImmediateTransaction = exports.DatabaseTransaction = exports.TRANSACTION_STATE = void 0;
+exports.trackOutstandingCommit = trackOutstandingCommit;
+exports.getOutstandingCommits = getOutstandingCommits;
 exports.setCommitLatencyRecorder = setCommitLatencyRecorder;
 exports.getTransactionQueueDepths = getTransactionQueueDepths;
 exports.replicationConfirmation = replicationConfirmation;
 exports.transactionOpenTooLongError = transactionOpenTooLongError;
 exports.priorStagedWrite = priorStagedWrite;
 exports.writeKeyId = writeKeyId;
+exports.resetReplayedWritesWarning = resetReplayedWritesWarning;
 exports.setTxnExpiration = setTxnExpiration;
 const blob_ts_1 = require("./blob.js");
 const commonUtility_ts_1 = require("../utility/lmdb/commonUtility.js");
@@ -69,22 +72,91 @@ const MAX_RETRIES = 40;
 // Cap the per-retry backoff so replication-applied transactions, which retry conflicts without a
 // cap (see the commit rejection handler), don't grow the delay unbounded.
 const MAX_RETRY_DELAY_MS = 1000;
-let outstandingCommit, outstandingCommitStart;
-// Identity references for the commit that armed `outstandingCommit`, kept for the one-time
-// checkOverloaded() log below (harper#2001) — `outstandingCommit` itself is otherwise anonymous, so
-// a stuck commit gives no indication of which database/table/resource to investigate. Snapshotted
-// at arm time (not read from `this.writes`/`this.startedFrom` lazily off the DatabaseTransaction
-// object) because that object can be reused for a later immediate commit while the original native
-// commit is still wedged — its resolve handler runs clearWrites() on the SAME object, which would
-// blank or replace the identity out from under a deferred read. Three reference assignments, no
-// allocation, and no lingering reference to the writes/entries graph (the native transaction handle
-// is retained, but its lifetime is already bounded by the pending outstandingCommit promise).
-let outstandingCommitStore;
-let outstandingCommitStartedFrom;
-let outstandingCommitNativeTransaction;
-// Ensures the checkOverloaded() rejection is logged once per stuck commit, not once per rejected
-// request — under load a wedged thread can reject hundreds of requests per second.
-let outstandingCommitLogged = false;
+let oldestOutstandingCommit;
+let newestOutstandingCommit;
+let outstandingCommitCount = 0;
+// Caps the stuck-commit log (checkOverloaded() below) to at most one line per this interval across
+// the whole thread, regardless of how many distinct commits individually cross the threshold — see
+// the comment at the log site for why a per-commit-only dedup isn't enough under sustained overload.
+const OVERLOAD_LOG_MIN_INTERVAL_MS = 1000;
+let lastOverloadLogAt = -Infinity;
+// Track a submitted commit until it settles. Every attempt is tracked unconditionally: a
+// coordinated retry round and a chained second-store commit are both issued from inside the
+// preceding commit's own resolve handler, which runs before any reaction that could release a
+// single shared slot — so anything conditional on "is something already outstanding" skips them
+// and leaves a wedged retry or chain invisible to checkOverloaded() forever. Each attempt is timed
+// from its own submission, keeping the overload window per-attempt rather than cumulative over a
+// retry ladder. `.then(untrack, untrack)` also marks an ERR_BUSY rejection handled, so this
+// tracking never surfaces as an unhandled rejection alongside the caller's own handler.
+// Exported only so unit tests can drive the list with controllable promises: the unlink order that
+// matters (a middle or tail node settling first) cannot be forced through real writes, and a node
+// left linked would 503 every write on this thread forever. commit() below is the sole caller.
+// Also the single source for write-queue-depth accounting (getTransactionQueueDepths below): every
+// native commit this function tracks is, by definition, exactly the write-queue backlog — see the
+// comment there for why that used to be a second, separately-maintained counter.
+// `store`/`startedFrom`/`nativeTransaction` are the identity snapshot for checkOverloaded()'s stuck-
+// commit log (harper#2001); omit them (as the test seam below does) when a caller has none to give.
+function trackOutstandingCommit(commitResolution, store, startedFrom, nativeTransaction) {
+    // Guards against a future caller passing a non-Promise: today commit() always hands this a real
+    // Promise, but an unguarded link here would leave a node permanently wedged in the list (503ing
+    // every write on this thread) with no settlement to ever unlink it.
+    if (typeof commitResolution?.then !== 'function')
+        return;
+    const outstanding = {
+        start: performance.now(),
+        prev: newestOutstandingCommit,
+        next: undefined,
+        store,
+        startedFrom,
+        nativeTransaction,
+        logged: false,
+    };
+    if (newestOutstandingCommit != null)
+        newestOutstandingCommit.next = outstanding;
+    else
+        oldestOutstandingCommit = outstanding;
+    newestOutstandingCommit = outstanding;
+    outstandingCommitCount++;
+    // Doubles as the write-queue-depth high-water mark (see getTransactionQueueDepths): every
+    // outstanding commit is a write-queue entry, so the peak of one is the peak of the other.
+    if (outstandingCommitCount > writeTxnQueueDepthHighWater)
+        writeTxnQueueDepthHighWater = outstandingCommitCount;
+    // Guards against double-untracking the same node: `.then(untrack, untrack)` below means a promise
+    // that both resolves and later has its rejection handler independently triggered (or is tracked via
+    // a shared/misused resolution) could otherwise run the unlink twice, corrupting the list or driving
+    // outstandingCommitCount negative.
+    let untracked = false;
+    const untrack = () => {
+        if (untracked)
+            return;
+        untracked = true;
+        if (outstanding.prev != null)
+            outstanding.prev.next = outstanding.next;
+        else
+            oldestOutstandingCommit = outstanding.next;
+        if (outstanding.next != null)
+            outstanding.next.prev = outstanding.prev;
+        else
+            newestOutstandingCommit = outstanding.prev;
+        outstandingCommitCount--;
+    };
+    commitResolution.then(untrack, untrack);
+}
+/**
+ * How many write commits are outstanding on this thread and how long the oldest has been waiting
+ * (`oldestAgeMs` is undefined when none is). `oldestAgeMs` is exactly the value checkOverloaded()
+ * rejects on, exposed so a commit that never settles (harper#2001) can be observed directly rather
+ * than inferred from the 503s it eventually produces.
+ */
+function getOutstandingCommits() {
+    return {
+        count: outstandingCommitCount,
+        oldestAgeMs: oldestOutstandingCommit ? performance.now() - oldestOutstandingCommit.start : undefined,
+    };
+}
+// Once per process: committing under open read iterators forces a write replay, so the warning is
+// about the caller's pattern, not the individual commit.
+let replayedWritesWarned = false;
 // The analytics module registers a recorder here at load (dependency inversion, mirroring
 // `replicationConfirmation` below) so the storage layer doesn't statically import the analytics/server
 // modules. Unset until analytics loads, and when analytics is disabled the recorder call is cheap.
@@ -117,29 +189,19 @@ function recordCommitLatency(commitResolution, submittedAt) {
 }
 // Queue-depth gauges surfaced through the analytics pipeline (write-transaction-queue-depth /
 // read-transaction-queue-depth). Per-thread state; the analytics aggregator sums across threads.
-// `writeTxnQueueDepth` counts write commits handed to the storage engine but not yet resolved —
-// this is the backlog that, when it drains too slowly, produces the "Outstanding write transactions
-// have too long of queue" overload error. Read depth is derived from the live `trackedTxns` set
-// (every tracked transaction holds an open read snapshot). We also retain a high-water mark per
-// sampling window because the queue can fill and drain within a single (~1s) analytics period, so an
+// The write depth is `outstandingCommitCount` itself (maintained above by trackOutstandingCommit) —
+// write commits handed to the storage engine but not yet resolved are exactly the same set of native
+// commits the overload check tracks, and keeping one counter instead of two removes the duplicate
+// per-commit bookkeeping (and the drift risk: a code path that updates one but not the other, as the
+// replay path did before this fix). Read depth is derived from the live `trackedTxns` set (every
+// tracked transaction holds an open read snapshot). We also retain a high-water mark per sampling
+// window because the queue can fill and drain within a single (~1s) analytics period, so an
 // instantaneous sample taken at emit time would routinely miss the spike operators need to see.
 // RocksDB-write-path only: LMDB routes through the separate LMDBTransaction.commit()/getReadTxn()
 // overrides (resources/LMDBTransaction.ts), which maintain their own unrelated `trackedTxns` set and
 // do not call into this accounting.
-let writeTxnQueueDepth = 0;
 let writeTxnQueueDepthHighWater = 0;
 let readTxnQueueDepthHighWater = 0;
-function enterWriteQueue() {
-    if (++writeTxnQueueDepth > writeTxnQueueDepthHighWater)
-        writeTxnQueueDepthHighWater = writeTxnQueueDepth;
-}
-function leaveWriteQueue() {
-    // Floor at zero: accounting is balanced by construction (every enterWriteQueue has exactly one
-    // matching settlement), but the guard is cheap insurance against a future call-site imbalance
-    // producing a negative depth that would corrupt every subsequent sample.
-    if (writeTxnQueueDepth > 0)
-        writeTxnQueueDepth--;
-}
 /**
  * Returns the current write/read transaction queue depths for this thread along with the high-water
  * mark observed since the previous call, then resets the high-water marks to the current depth so the
@@ -150,12 +212,12 @@ function getTransactionQueueDepths() {
     // dominates the current size here — no need to reconcile against `readDepth` before reporting.
     const readDepth = trackedTxns.size;
     const depths = {
-        writeDepth: writeTxnQueueDepth,
+        writeDepth: outstandingCommitCount,
         writeMaxDepth: writeTxnQueueDepthHighWater,
         readDepth,
         readMaxDepth: readTxnQueueDepthHighWater,
     };
-    writeTxnQueueDepthHighWater = writeTxnQueueDepth;
+    writeTxnQueueDepthHighWater = outstandingCommitCount;
     readTxnQueueDepthHighWater = readDepth;
     return depths;
 }
@@ -227,7 +289,18 @@ class DatabaseTransaction {
     replicatedConfirmation;
     getReadTxn(disableSnapshot) {
         this.readTxnRefCount = (this.readTxnRefCount || 0) + 1;
-        this.timeout = txnExpiration; // reset the timeout
+        // The limit is an IDLE limit. Writes always re-arm it (see addWrite), but reads only do so
+        // while no uncommitted writes are held: staged writes hold write intents that other writers'
+        // coordinated-retry commits park on, so a handler that wrote once and then only reads — an
+        // orphaned long-poll whose client had already gone, in harper#2001 — must not keep those
+        // intents alive by reading. A transaction that keeps writing stays alive; so does a purely
+        // read-only one. A committed transaction re-arms too: its intents went with the commit, and
+        // the monitor bounds its retained read snapshot separately.
+        // `writes`/`next` are checked inline first: this is a hot path and the dominant case is a
+        // single-store transaction that has never written.
+        if ((this.writes.length === 0 && !this.next) || this.open !== exports.TRANSACTION_STATE.OPEN || !this.hasPendingWrites()) {
+            this.timeout = txnExpiration;
+        }
         if (this.transaction) {
             if (this.transaction.openTimer)
                 this.transaction.openTimer = 0;
@@ -275,6 +348,7 @@ class DatabaseTransaction {
             trackedTxns.delete(this);
             this.transaction?.abort();
             this.transaction = null;
+            this.completeDeferredContextRelease();
         }
     }
     /**
@@ -293,6 +367,20 @@ class DatabaseTransaction {
             harperLogger.debug?.('releasing timed-out read transaction', error);
         }
         this.transaction = null;
+        this.completeDeferredContextRelease();
+    }
+    /**
+     * Complete a context release that releaseContext() deferred because outstanding read iterators
+     * were still using this transaction (see releaseContext()) — called once the last one drains,
+     * whether that happens naturally (doneReadTxn()) or is forced by the long-transaction monitor
+     * (releaseReadTxn()).
+     */
+    completeDeferredContextRelease() {
+        if (!this.pendingContextRelease)
+            return;
+        this.pendingContextRelease = false;
+        if (this.#context?.transaction === this)
+            this.#context.transaction = null;
     }
     disregardReadTxn() {
         if (--this.readTxnRefCount === 0 && this.readTxnsUsed === 1) {
@@ -324,22 +412,69 @@ class DatabaseTransaction {
         this.writes = [];
         this.writesByKey = undefined;
     }
+    /**
+     * Drop this transaction's back-reference from its context once completed (commit or abort),
+     * so a long-lived context (e.g. an MQTT subscription context held open for the life of a
+     * suspended delivery loop) doesn't keep pinning a finished transaction in memory. Guarded by
+     * identity: a context already re-pointed at a different (e.g. reused) transaction is untouched.
+     *
+     * `final` must be false for an in-callback explicit `context.transaction.commit()` — the
+     * "commit in the middle" pattern intentionally keeps recommitting and adding writes to the
+     * SAME instance (see the comment above about a transaction being "reused and committed
+     * again"), so releasing here would strand those later writes with no transaction to join.
+     * Only resources/transaction.ts's own wrapper commit (`{ doneWriting: true }`, once the
+     * caller's callback has fully returned) and abort() are truly final.
+     *
+     * A final commit can still have outstanding read iterators streaming through this.transaction
+     * (see the outstanding-iterators branch in commit()) — those keep this instance meaningfully
+     * alive (a fresh write on the same context must not join a DIFFERENT, already-replayed
+     * transaction) until doneReadTxn() drains the last one, so the release is deferred to there.
+     *
+     * Sets `.transaction` to `null` rather than deleting the property: `Context.transaction` is
+     * typed `DatabaseTransaction | null | undefined` precisely to document this released state, and
+     * `delete` would repeatedly force a long-lived, hot context (e.g. an MQTT subscription context
+     * releasing/reattaching a transaction per message) into V8's slower dictionary-mode property
+     * storage.
+     */
+    releaseContext(final) {
+        if (!final)
+            return;
+        if (this.readTxnsUsed > 0) {
+            this.pendingContextRelease = true;
+            return;
+        }
+        if (this.#context?.transaction === this)
+            this.#context.transaction = null;
+    }
     checkOverloaded() {
-        if (outstandingCommit &&
+        if (oldestOutstandingCommit &&
             !this.overloadChecked &&
-            performance.now() - outstandingCommitStart > MAX_OUTSTANDING_TXN_DURATION) {
-            if (!outstandingCommitLogged) {
+            performance.now() - oldestOutstandingCommit.start > MAX_OUTSTANDING_TXN_DURATION) {
+            const now = performance.now();
+            // Also rate-limited across the whole overload episode (not just deduped per commit): under
+            // sustained heavy load, many distinct commits can each individually age past the limit in
+            // quick succession as earlier ones finally settle, which without this cap would turn one
+            // overload episode into a growing stream of ERROR lines — the same "flood" harper#2001's
+            // original per-request log was fixed to avoid, just shifted from per-request to per-commit.
+            // A commit skipped by the cooldown is NOT marked `logged`, so it still gets a log later if
+            // it's still the oldest once the cooldown clears, rather than going silent forever.
+            if (!oldestOutstandingCommit.logged && now - lastOverloadLogAt > OVERLOAD_LOG_MIN_INTERVAL_MS) {
                 // Log once per stuck commit (not once per rejected request, harper#2001): a wedged
                 // thread otherwise logs nothing at all server-side while rejecting every write with a
-                // 503, which was the single biggest obstacle to root-causing a recurrence.
-                outstandingCommitLogged = true;
-                const nativeTransactionId = outstandingCommitNativeTransaction?.id;
+                // 503, which was the single biggest obstacle to root-causing a recurrence. The flag lives
+                // on the node itself, so if THIS commit settles while still over the limit and a
+                // different one is now oldest, that one logs too instead of staying silent forever.
+                oldestOutstandingCommit.logged = true;
+                lastOverloadLogAt = now;
+                const nativeTransactionId = oldestOutstandingCommit.nativeTransaction?.id;
+                const store = oldestOutstandingCommit.store;
+                const startedFrom = oldestOutstandingCommit.startedFrom;
                 harperLogger.error(`Rejecting writes on this thread: a commit has been outstanding for ` +
-                    `${Math.round(performance.now() - outstandingCommitStart)}ms (exceeds the ` +
-                    `${MAX_OUTSTANDING_TXN_DURATION}ms limit), from table: ${outstandingCommitStore?.rootStore?.databaseName ?? '?'}.${outstandingCommitStore?.name ?? '?'}` +
+                    `${Math.round(now - oldestOutstandingCommit.start)}ms (exceeds the ` +
+                    `${MAX_OUTSTANDING_TXN_DURATION}ms limit), from table: ${store?.rootStore?.databaseName ?? '?'}.${store?.name ?? '?'}` +
                     (nativeTransactionId !== undefined ? ` (transaction ${nativeTransactionId})` : '') +
-                    (outstandingCommitStartedFrom?.resourceName
-                        ? `, started from ${outstandingCommitStartedFrom.resourceName}${outstandingCommitStartedFrom.method ? '.' + outstandingCommitStartedFrom.method : ''}`
+                    (startedFrom?.resourceName
+                        ? `, started from ${startedFrom.resourceName}${startedFrom.method ? '.' + startedFrom.method : ''}`
                         : '') +
                     `. Further record updates and publishes from new application requests on this thread ` +
                     `will be rejected with 503 until the commit settles or the process is restarted (deletes, ` +
@@ -352,6 +487,13 @@ class DatabaseTransaction {
     addWrite(operation) {
         if (this.timedOut)
             throw transactionOpenTooLongError();
+        // A write is activity: it re-arms the idle limit on this link even though the reads it
+        // performs no longer do (see getReadTxn), so a transaction that keeps writing stays alive
+        // and only an idle one holding write intents is reaped.
+        this.timeout = txnExpiration;
+        // Independent write-recency signal for chainStillActive (see the field comment) — reads never
+        // touch this, only writes do.
+        this.writeTimeout = txnExpiration;
         this.linkWrite(operation);
         this.writes.push(operation);
         if (!operation.deferSave) {
@@ -481,6 +623,12 @@ class DatabaseTransaction {
                 this.writes = this.writes.filter((write) => write); // filter out removed entries
                 if (this.writes.length > 0) {
                     if (!options.transaction) {
+                        if (!replayedWritesWarned) {
+                            replayedWritesWarned = true;
+                            harperLogger.warn?.(`Committing while read iterators are still open: ${this.writes.length} staged write(s) must be re-staged and committed on a second transaction, doubling their write work` +
+                                (this.startedFrom ? `, from ${this.startedFrom.resourceName}.${this.startedFrom.method}` : '') +
+                                `. Fully consume (or close) iterators before committing to avoid this. Logged once per process.`);
+                        }
                         // Deliberately NOT marked isRetry and NOT carrying over the original's onCommit:
                         // audit/txn-log entries batch natively on the transaction they were staged into and
                         // are only durably written by that transaction's commit attempt (an abort discards
@@ -501,6 +649,29 @@ class DatabaseTransaction {
                     // re-staged the writes into it
                     commitResolution = transaction.commit();
                     recordCommitLatency(commitResolution, performance.now());
+                    // Write-queue-depth accounting for this replay commit happens uniformly below, via
+                    // trackOutstandingCommit(commitResolution) — see that function's comment. Omitting
+                    // dedicated accounting here (as a prior version of this replay path did) used to leave
+                    // write-transaction-queue-depth, the one metric that can observe a commit that never
+                    // settles (harper#2001), reading zero for exactly this path.
+                }
+                // No commit will ever run on the retained handle — the replay above owns these
+                // writes — so this is the only place its write intents can be released. Left in
+                // place, other writers' coordinated-retry commits park on them until the last
+                // iterator finishes (harper#2001). Reads through the handle, including
+                // read-your-own-writes, keep working. Once only: a coordinated-retry or backoff
+                // round re-enters this branch on the same retained handle. Fenced like the other
+                // post-submit steps here: the replay commit is already in flight, so a throw must
+                // not skip onCommit/the chain-store commit below. Optional: rocksdb-js < 2.7
+                // lacks the method.
+                if (!this.writesAbandoned) {
+                    this.writesAbandoned = true;
+                    try {
+                        this.transaction?.abandonWrites?.();
+                    }
+                    catch (error) {
+                        harperLogger.warn?.('Failed to release write intents on a retained read transaction', error);
+                    }
                 }
             }
             else {
@@ -516,31 +687,19 @@ class DatabaseTransaction {
                         // Promise<number | void>; it is handled in the resolve callback below.
                         commitResolution = transaction.commit();
                         // Record how long this commit stays outstanding (submit → settle) as a distribution
-                        // metric. This is the same clock the overload check uses (outstandingCommitStart is
-                        // stamped at submit), so a rising p99/p999 is the leading indicator for the
+                        // metric. This is the same clock the overload check uses (trackOutstandingCommit
+                        // stamps each attempt at submit), so a rising p99/p999 is the leading indicator for the
                         // "Outstanding write transactions have too long of queue" (503) rejection. A transient-
-                        // conflict retry rejects this promise and issues a fresh commit(), but outstandingCommit
-                        // only re-arms for the backoff path (retries > 2, below) — the coordinated-retry and
-                        // retries<=2 paths re-commit synchronously while outstandingCommit is still set, so
-                        // recording per attempt here counts more attempts than the overload check ever arms for.
+                        // conflict retry rejects this promise and issues a fresh commit(), which is tracked as
+                        // its own attempt, so recording per attempt matches the overload semantics.
                         // commitResolution's declared type (Promise<number | void> | void) doesn't narrow to
                         // Promise<void> here because the widening union defeats flow analysis on the prior
                         // cast assignment; re-assert it — this branch's commit() result is always a Promise.
                         recordCommitLatency(commitResolution, performance.now());
-                        // Count this commit against the write queue depth until the storage engine
-                        // resolves it. A transient-conflict retry rejects this promise and issues a
-                        // fresh commit() (re-entering here), so the enter/leave stays balanced. leaveWriteQueue
-                        // never throws, so the settled promise resolves and needs no rejection handling of its own.
-                        // The thenable guard protects against a future caller passing a non-Promise
-                        // `commitResolution` (today it is always rocksdb-js's async Transaction.commit()
-                        // result, guaranteed to be a Promise).
-                        enterWriteQueue();
-                        if (commitResolution && typeof commitResolution.then === 'function') {
-                            commitResolution.then(leaveWriteQueue, leaveWriteQueue);
-                        }
-                        else {
-                            leaveWriteQueue();
-                        }
+                        // Write-queue-depth accounting for this commit happens uniformly below, via
+                        // trackOutstandingCommit(commitResolution) — see that function's comment. A
+                        // transient-conflict retry rejects this promise and issues a fresh commit()
+                        // (re-entering here), which trackOutstandingCommit tracks as its own attempt.
                     }
                     else {
                         try {
@@ -556,43 +715,10 @@ class DatabaseTransaction {
                 }
             }
             if (commitResolution) {
-                // Known gap (pre-existing, not introduced here): this branch only arms when
-                // outstandingCommit is currently unset. A coordinated-retry re-commit (below) or a
-                // chained this.next.commit() runs synchronously inside this same commit's .then
-                // handler, one microtask before the .catch().finally() below clears outstandingCommit
-                // — so a retry or a second store's commit that itself wedges is never armed, and
-                // neither checkOverloaded() nor this log will ever see it. Only the first store's
-                // first commit attempt is covered.
-                if (!outstandingCommit) {
-                    outstandingCommit = commitResolution;
-                    outstandingCommitStart = performance.now();
-                    // Snapshot the store/origin now rather than reading them off `this` lazily in
-                    // checkOverloaded(): `this` (a DatabaseTransaction) can be reused for a later immediate
-                    // commit while this native commit is still wedged, and that later commit's resolve
-                    // handler runs clearWrites() on this SAME object — a lazy read would then blank or
-                    // mis-attribute the identity out from under the deferred log. Read the table off the
-                    // write itself, not this.db, which is whichever table first claimed this per-database
-                    // transaction in txnForContext and so can name the wrong table when a transaction spans
-                    // more than one table in the same database. Both are stable references (a Store, and an
-                    // object set once and never mutated), so this holds no allocation and no lingering
-                    // reference to the transaction/writes/entries graph.
-                    outstandingCommitStore = this.writes[0]?.store;
-                    outstandingCommitStartedFrom = this.startedFrom;
-                    outstandingCommitNativeTransaction = transaction;
-                    outstandingCommitLogged = false;
-                    outstandingCommit
-                        // if `commitResolution` rejects with and `ERR_BUSY` error, the retry logic
-                        // will correct course, but the reject will still be propagated on the
-                        // `outstandingCommit` promise and needs to be caught and silenced
-                        .catch(() => { })
-                        .finally(() => {
-                        outstandingCommit = null;
-                        outstandingCommitStore = undefined;
-                        outstandingCommitStartedFrom = undefined;
-                        outstandingCommitNativeTransaction = undefined;
-                        outstandingCommitLogged = false;
-                    });
-                }
+                // Read the table off the write itself, not this.db, which is whichever table first
+                // claimed this per-database transaction in txnForContext and so can name the wrong
+                // table when a transaction spans more than one table in the same database.
+                trackOutstandingCommit(commitResolution, this.writes[0]?.store, this.startedFrom, transaction);
                 const completions = [];
                 return commitResolution.then((commitResult) => {
                     if (commitResult === RETRY_NOW_VALUE) {
@@ -656,8 +782,7 @@ class DatabaseTransaction {
                     // now reset transactions tracking; this transaction be reused and committed again
                     this.retries = 0; // reset per-native-transaction retry counter so a reused DatabaseTransaction's next batch starts fresh
                     this.clearWrites();
-                    if (this.#context?.resourceCache)
-                        this.#context.resourceCache = null;
+                    this.releaseContext(!!options.doneWriting);
                     this.next = null;
                     let txnTime = this.timestamp;
                     this.timestamp = 0; // reset the timestamp as well
@@ -734,6 +859,11 @@ class DatabaseTransaction {
                         catch (abortError) {
                             harperLogger.debug?.('aborting transaction after failed commit', abortError);
                         }
+                        // A terminal failure is just as final as a success — release the context's
+                        // back-reference here too, or transaction.ts's onComplete() (which has no
+                        // rejection handler of its own) would leave a long-lived context pinning this
+                        // CLOSED wrapper forever.
+                        this.releaseContext(!!options.doneWriting);
                         throw error;
                     }
                 });
@@ -743,8 +873,7 @@ class DatabaseTransaction {
                     (0, blob_ts_1.cleanupUnusedBlobs)(write.savedBlobs, (0, blob_ts_1.collectRetainedFileIds)(write.store.getEntry(write.key)?.value));
             }
             this.clearWrites();
-            if (this.#context?.resourceCache)
-                this.#context.resourceCache = null;
+            this.releaseContext(!!options.doneWriting);
             const txnResolution = {
                 txnTime: this.timestamp,
             };
@@ -776,8 +905,13 @@ class DatabaseTransaction {
         }
         // reset the transaction
         this.clearWrites();
-        if (this.#context?.resourceCache)
-            this.#context.resourceCache = null;
+        // A timeout-poisoned abort (abortDueToTimeout()) is the one abort that is NOT "reuse-free":
+        // Resource.ts's dispatcher deliberately keeps joining a `timedOut` transaction (instead of
+        // starting a fresh one) so the rest of the logical operation fails atomically via the
+        // poison check in addWrite()/commit(), rather than silently landing a later write on a
+        // brand-new transaction after an earlier one was rolled back (#1411). Releasing here would
+        // make that check see `undefined?.timedOut` and take the "start fresh" branch instead.
+        this.releaseContext(!this.timedOut);
     }
     /**
      * Give up on a chain of linked transactions after exhausting conflict retries: poison every link
@@ -899,9 +1033,33 @@ class ImmediateTransaction extends DatabaseTransaction {
 }
 exports.ImmediateTransaction = ImmediateTransaction;
 let timer;
+/**
+ * True when a link other than `txn` in the same multi-store chain was written recently enough to
+ * still be active — i.e. its `writeTimeout` (set only by addWrite, see the field comment) hasn't
+ * decayed to zero. Writes re-arm only the link that receives them, so a chain writing database B
+ * while its head only reads A would otherwise be aborted by the head's own decay.
+ */
+function chainStillActive(txn) {
+    for (let link = txn.next; link; link = link.next) {
+        // A write-only link (e.g. a blind write to a second database, never itself read) never calls
+        // getReadTxn, so it's never added to trackedTxns and the main loop below never decays it.
+        // Decay it here instead, so an idle write-only link eventually expires rather than keeping the
+        // whole chain immortal (harper#2001's blind-write shape).
+        if (!trackedTxns.has(link) && link.writeTimeout > 0)
+            link.writeTimeout -= txnExpiration;
+        if (link.writeTimeout > 0)
+            return true;
+    }
+    return false;
+}
 function startMonitoringTxns() {
     timer = setInterval(function () {
         for (const txn of trackedTxns) {
+            // Decay write recency once per tick for every tracked link, independent of the `timeout`
+            // branches below — a tracked link that keeps its own idle limit alive by reading must not
+            // thereby keep chainStillActive believing it was written recently too.
+            if (txn.writeTimeout > 0)
+                txn.writeTimeout -= txnExpiration;
             if (txn.timeout <= 0) {
                 const url = txn.getContext()?.url;
                 if (txn.open === exports.TRANSACTION_STATE.CLOSED) {
@@ -914,6 +1072,13 @@ function startMonitoringTxns() {
                     harperLogger.warn?.(`Read iterators held a committed transaction's snapshot past the open-transaction limit; releasing it, from table: ${txn.db?.name + (url ? ' path: ' + url : '')}`);
                     txn.releaseReadTxn();
                 }
+                else if (txn.hasPendingWrites() && chainStillActive(txn)) {
+                    // A later link in the chain was written recently (writes re-arm only the link that
+                    // receives them, and a multi-store transaction can be writing database B while this
+                    // head only reads A). The logical transaction is still active, so re-arm this link
+                    // rather than aborting the whole chain out from under it.
+                    txn.timeout = txnExpiration;
+                }
                 else if (txn.hasPendingWrites() && !txn.sourceApply && !txn.isReplay) {
                     // Abort and surface an error rather than force-committing a partial write set: silently
                     // committing on the application's behalf breaks atomicity and can leave orphaned
@@ -956,6 +1121,14 @@ function startMonitoringTxns() {
     }, txnExpiration).unref();
 }
 startMonitoringTxns();
+/**
+ * Test seam: re-arms the once-per-process replay warning. The whole unit suite shares one process,
+ * so whichever test first drives a commit under open iterators consumes the warning for every test
+ * after it.
+ */
+function resetReplayedWritesWarning() {
+    replayedWritesWarned = false;
+}
 function setTxnExpiration(ms) {
     clearInterval(timer);
     txnExpiration = ms;