@harperfast/harper 5.1.27 → 5.1.29

package/resources/replayLogs.ts

@@ -75,8 +75,9 @@ export function replayLogs(rootStore: RocksDatabase, tables: any): Promise<void>
 			tableById.set(table.tableId, table);
 		}
 		// replay all the logs
-		let transaction: DatabaseTransaction;
+		let transaction: DatabaseTransaction | undefined;
 		let lastTimestamp = 0;
+		let openCommitEnded = false;
 		let writes = 0;
 		let skipped = 0;
 		// Track forward progress so a backlog of unwritable entries can't grind the boot thread
@@ -110,8 +111,27 @@ export function replayLogs(rootStore: RocksDatabase, tables: any): Promise<void>
 				originatingOperation,
 				username,
 				extendedType,
+				endTxn,
 			} = auditRecord;
 			try {
+				// A replay transaction is one native commit ("Boot replay transactions" in DESIGN.md).
+				if (transaction && (openCommitEnded || lastTimestamp !== version)) {
+					const ending = transaction;
+					transaction = undefined;
+					try {
+						ending.directCommitSync();
+					} catch (error) {
+						logger.error('Error committing replay transaction', error);
+					}
+					// The wall-clock budget (harper#1316) is checked only here, between native commits with
+					// nothing staged, so aborting never tears a commit in half.
+					if (shouldAbortSlowReplay(performance.now() - replayStartTime, replayTimeoutMs)) {
+						logger.fatal(
+							`Aborting transaction-log replay in ${(rootStore as any).databaseName} database: replay has exceeded the wall-clock time limit (${writes} written, ${skipped} skipped). The transaction log contains a pathologically deep out-of-order write history that is too expensive to reconcile during boot (harper#1316). Re-clone this node from a healthy leader to recover the unreplayed data.`
+						);
+						break;
+					}
+				}
 				if (classifyAuditEntryForReplay(extendedType, tableId, true) === 'corrupt-header') {
 					skipped++;
 					noProgressRun++;
@@ -165,28 +185,9 @@ export function replayLogs(rootStore: RocksDatabase, tables: any): Promise<void>
 					warnedReplayHappening = true;
 					console.warn('Harper was not properly shutdown, replaying transaction logs to synchronize database');
 				}
-				if (lastTimestamp !== version) {
+				if (!transaction) {
 					lastTimestamp = version;
-					try {
-						// commit the last transaction since we are starting a new one
-						transaction?.directCommitSync();
-					} catch (error) {
-						logger.error('Error committing replay transaction', error);
-					}
-					// Abort if replay has exceeded the total wall-clock budget even while making progress
-					// (harper#1316, facet a). shouldAbortStalledReplay resets its counters on every write,
-					// so a slow-but-progressing replay (deep out-of-order audit chain walk per entry) can
-					// peg the boot thread indefinitely without tripping it. Checked only here, at a version
-					// boundary: the prior version's transaction was just committed in full and the new one
-					// is not yet staged, so aborting never tears a same-version (same source-transaction)
-					// write batch in half. Re-clone to recover the unreplayed remainder.
-					if (shouldAbortSlowReplay(performance.now() - replayStartTime, replayTimeoutMs)) {
-						logger.fatal(
-							`Aborting transaction-log replay in ${(rootStore as any).databaseName} database: replay has exceeded the wall-clock time limit (${writes} written, ${skipped} skipped). The transaction log contains a pathologically deep out-of-order write history that is too expensive to reconcile during boot (harper#1316). Re-clone this node from a healthy leader to recover the unreplayed data.`
-						);
-						transaction = undefined as any; // already committed above; nothing staged for the new version
-						break;
-					}
+					openCommitEnded = false;
 					transaction = new DatabaseTransaction();
 					transaction.db = primaryStore;
 					transaction.timestamp = version;
@@ -280,6 +281,8 @@ export function replayLogs(rootStore: RocksDatabase, tables: any): Promise<void>
 				logger.error(`Error writing from replay of log`, err, {
 					version,
 				});
+			} finally {
+				if (endTxn) openCommitEnded = true;
 			}
 		}
 		try {

package/resources/transactionBroadcast.ts

@@ -187,7 +187,7 @@ function notifyFromTransactionData(subscriptions, auditLogIterable?, allowYield
 					let ancestorLevel = 0;
 					do {
 						// we iterate through the key hierarchy, notifying all subscribers for each key,
-						// so for an id like resource/foo/bar, we notify subscribers for resource/foo/bar, resource/foo/, resource/foo, resource/, and resource
+						// so for an id like resource/foo/bar, we notify subscribers for resource/foo/bar, resource/foo/, resource/, and the root (null)
 						// this allows for efficient subscriptions to children ids/topics
 						const keySubscriptions = tableSubscriptions.get(matchingKey);
 						if (keySubscriptions) {
@@ -228,9 +228,9 @@ function notifyFromTransactionData(subscriptions, auditLogIterable?, allowYield
 						if (lastSlash !== matchingKey.length - 1) {
 							ancestorLevel++; // don't increase the ancestor level for this going from resource/ to resource
 						}
-						if (lastSlash > -1) {
-							matchingKey = matchingKey.slice(0, lastSlash + 1);
-						} else matchingKey = null;
+						// lastIndexOf clamps a negative fromIndex to 0, so '/' would otherwise yield itself forever
+						const parentKey = lastSlash > -1 ? matchingKey.slice(0, lastSlash + 1) : null;
+						matchingKey = parentKey === matchingKey ? null : parentKey;
 					} while (true);
 				}
 			} else if (auditRecord.type === 'reload') {

package/security/user.ts

@@ -105,6 +105,7 @@ import * as password from '../utility/password.ts';
 import { server } from '../server/Server.ts';
 import * as terms from '../utility/hdbTerms.ts';
 import { expandOperationsPerms } from '../utility/operationPermissions.ts';
+import { coalesceRefresh } from '../utility/coalesceRefresh.ts';
 
 server.getUser = (username: string, password?: string | null): Promise<User> => {
 	return findAndValidateUser(username, password, password != null);
@@ -371,9 +372,13 @@ function cacheExpandedOperationsPerms(userRole: UserRole) {
 	userRole.permission._expandedOperations = expandOperationsPerms(userRole.permission.operations);
 }
 
+const refreshUsersWithRolesCache = coalesceRefresh(async () => {
+	usersWithRolesMap = await listUsers();
+});
+
 async function setUsersWithRolesCache(cache = undefined) {
 	if (cache) usersWithRolesMap = cache;
-	else usersWithRolesMap = await listUsers();
+	else await refreshUsersWithRolesCache();
 }
 
 async function getUsersWithRolesCache() {

package/studio/web/404.html

@@ -0,0 +1,79 @@
+<!DOCTYPE html>
+<html lang="en">
+  <head>
+    <meta charset="UTF-8" />
+    <title>Page Not Found — Harper Fabric</title>
+    <link rel="icon" type="image/svg+xml" href="/HDBDogOnly.svg" />
+    <link rel="icon" type="dynamic-favicon" href="/favicon_purple.png" />
+    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
+    <meta name="robots" content="noindex" />
+    <!-- Self-contained on purpose: this page is served when a URL matched nothing, so it must not
+         depend on a hashed bundle, a stylesheet, or a font that might itself be the thing missing. -->
+    <style>
+    * {
+      margin: 0;
+      padding: 0;
+    }
+
+    body {
+      align-items: center;
+      background: linear-gradient(45deg, #312556, #403b8a, #7a3a87);
+      box-sizing: border-box;
+      color: #efefef;
+      display: flex;
+      font-family: helvetica, sans-serif;
+      justify-content: center;
+      line-height: 1.5;
+      min-height: 100vh;
+      padding: 2rem 1.5rem;
+    }
+
+    main {
+      max-width: 30rem;
+      text-align: center;
+    }
+
+    img {
+      height: 84px;
+      width: 84px;
+    }
+
+    h1 {
+      font-size: 1.75rem;
+      font-weight: 400;
+      margin: 1.5rem 0 0.75rem;
+    }
+
+    p {
+      color: hsl(0, 0%, 85%);
+    }
+
+    a {
+      background-color: hsla(0, 0%, 0%, 0.35);
+      border-radius: 0.375rem;
+      color: #fff;
+      display: inline-block;
+      margin-top: 1.75rem;
+      padding: 0.625rem 1.25rem;
+      text-decoration: none;
+    }
+
+    a:hover,
+    a:focus-visible {
+      background-color: hsla(0, 0%, 0%, 0.6);
+    }
+    </style>
+  </head>
+
+  <body>
+    <main>
+      <img src="/HDBDogOnly.svg" alt="" width="84" height="84" />
+      <h1>Page not found</h1>
+      <p>
+        That address isn't part of Harper Fabric. If you followed a link from
+        outside Studio, it may have pointed somewhere that has since moved.
+      </p>
+      <a href="/">Go to Harper Fabric</a>
+    </main>
+  </body>
+</html>