@harperfast/harper-pro 5.0.23 → 5.0.24

package/core/package-lock.json

@@ -1,12 +1,12 @@
 {
 	"name": "harper",
-	"version": "5.0.23",
+	"version": "5.0.24",
 	"lockfileVersion": 3,
 	"requires": true,
 	"packages": {
 		"": {
 			"name": "harper",
-			"version": "5.0.23",
+			"version": "5.0.24",
 			"license": "Apache-2.0",
 			"dependencies": {
 				"@aws-sdk/client-s3": "^3.1012.0",
@@ -53,7 +53,7 @@
 				"json-bigint-fixes": "1.1.0",
 				"jsonata": "1.8.7",
 				"jsonwebtoken": "9.0.3",
-				"lmdb": "3.5.4",
+				"lmdb": "3.5.5",
 				"lodash": "^4.17.23",
 				"mathjs": "11.12.0",
 				"micromatch": "^4.0.8",
@@ -2619,9 +2619,9 @@
 			}
 		},
 		"node_modules/@lmdb/lmdb-darwin-arm64": {
-			"version": "3.5.4",
-			"resolved": "https://registry.npmjs.org/@lmdb/lmdb-darwin-arm64/-/lmdb-darwin-arm64-3.5.4.tgz",
-			"integrity": "sha512-Kk4Kz3iyu1QiLsLZBS9Af1eSKUC8VR2T+/jyE2iAyuGw2VwK08pp5iTbZnXn6sWu0LogO/RFktMxOjiDA2sS3w==",
+			"version": "3.5.5",
+			"resolved": "https://registry.npmjs.org/@lmdb/lmdb-darwin-arm64/-/lmdb-darwin-arm64-3.5.5.tgz",
+			"integrity": "sha512-hcSIUgSblRtwEuPzV/88cTbEPxaWfxVSrTaMIVUreyAA02ysE3S9tsiQdmT7KNmUaXlwgRGs+x+GaVDCuk7Prg==",
 			"cpu": [
 				"arm64"
 			],
@@ -2632,9 +2632,9 @@
 			]
 		},
 		"node_modules/@lmdb/lmdb-darwin-x64": {
-			"version": "3.5.4",
-			"resolved": "https://registry.npmjs.org/@lmdb/lmdb-darwin-x64/-/lmdb-darwin-x64-3.5.4.tgz",
-			"integrity": "sha512-BEe5Rp3trn26oxoXOVL5HVDoiYmjUDwr8NRPkBOdUdCSBEorKI+7JrZLRKAdxO+G6cGQLgseXk0gR7qIQa7aGw==",
+			"version": "3.5.5",
+			"resolved": "https://registry.npmjs.org/@lmdb/lmdb-darwin-x64/-/lmdb-darwin-x64-3.5.5.tgz",
+			"integrity": "sha512-cLlp9ypk3W9Hr4fuTYwg1kL2vPfz887v9NXiHQE1raSKtJ8/hnghekqUu62wUQdQPgThLV8Om+Ran08wWuM/3w==",
 			"cpu": [
 				"x64"
 			],
@@ -2645,9 +2645,9 @@
 			]
 		},
 		"node_modules/@lmdb/lmdb-linux-arm": {
-			"version": "3.5.4",
-			"resolved": "https://registry.npmjs.org/@lmdb/lmdb-linux-arm/-/lmdb-linux-arm-3.5.4.tgz",
-			"integrity": "sha512-SGbFR7816uBcTHc2ZY4S6WyOkl9bICnzqTQd2Mv4V/j24cfds88xx2nC6cm/y8zGQL7Ds31YF/5NGxjgcdM5Hw==",
+			"version": "3.5.5",
+			"resolved": "https://registry.npmjs.org/@lmdb/lmdb-linux-arm/-/lmdb-linux-arm-3.5.5.tgz",
+			"integrity": "sha512-eDeK9vZww0dIXlRCZa7pvbEXSUpUNIJKUs13FxDzazL8CRLDLggbeirm5m0hZvJcRgZzTYGESE8UUEBqHcdZ9Q==",
 			"cpu": [
 				"arm"
 			],
@@ -2658,9 +2658,9 @@
 			]
 		},
 		"node_modules/@lmdb/lmdb-linux-arm64": {
-			"version": "3.5.4",
-			"resolved": "https://registry.npmjs.org/@lmdb/lmdb-linux-arm64/-/lmdb-linux-arm64-3.5.4.tgz",
-			"integrity": "sha512-cUXEengO8o60v1SWerJTH4/RH4U3+9jC0/4njp2Z9NdmvaGzhKsbRM2wpXuRYrN8tytsoJCg0SvWEWwHAwLbCA==",
+			"version": "3.5.5",
+			"resolved": "https://registry.npmjs.org/@lmdb/lmdb-linux-arm64/-/lmdb-linux-arm64-3.5.5.tgz",
+			"integrity": "sha512-tn8KSYdvX5sietpuGyJJSXocvQQtWlenzquap/Mzr+wWx5jrjK5I3nEAIMFxvTtuMMrpPTGHGNuE/Hanh3o0EQ==",
 			"cpu": [
 				"arm64"
 			],
@@ -2671,9 +2671,9 @@
 			]
 		},
 		"node_modules/@lmdb/lmdb-linux-x64": {
-			"version": "3.5.4",
-			"resolved": "https://registry.npmjs.org/@lmdb/lmdb-linux-x64/-/lmdb-linux-x64-3.5.4.tgz",
-			"integrity": "sha512-Gxq8jpgOWXwd0PUR+c9R2Ik1/uBnGd5GMIIzRRDqABCkvmjtC3KWcyhesV9jSPCz759isl0NlbsstZ2oyvk8lA==",
+			"version": "3.5.5",
+			"resolved": "https://registry.npmjs.org/@lmdb/lmdb-linux-x64/-/lmdb-linux-x64-3.5.5.tgz",
+			"integrity": "sha512-o6VRcJjZ6Zc67MnymLEa3AtbYSreFzm6Um6LMHh4lkynlE5Qk/XUHXU2beTZBdB3QuZBiMoXO2gjPSgP0tYUKg==",
 			"cpu": [
 				"x64"
 			],
@@ -2684,9 +2684,9 @@
 			]
 		},
 		"node_modules/@lmdb/lmdb-win32-arm64": {
-			"version": "3.5.4",
-			"resolved": "https://registry.npmjs.org/@lmdb/lmdb-win32-arm64/-/lmdb-win32-arm64-3.5.4.tgz",
-			"integrity": "sha512-pKv1DJ1bPZAaHkdFsSz5IDfUG8x9vntgquXF9/Dm2xuupcIe/EkLzylpoBxppFVK5vzbV561Dq26jNY2fIMA7g==",
+			"version": "3.5.5",
+			"resolved": "https://registry.npmjs.org/@lmdb/lmdb-win32-arm64/-/lmdb-win32-arm64-3.5.5.tgz",
+			"integrity": "sha512-k0k/CwywhymTAJT7Uj5PdehH31Vem2ov/Jp0rn5McuJEHgzj7vbE0cmnByhjrQv+VeHLALI8wUZNicqwocPB4Q==",
 			"cpu": [
 				"arm64"
 			],
@@ -2697,9 +2697,9 @@
 			]
 		},
 		"node_modules/@lmdb/lmdb-win32-x64": {
-			"version": "3.5.4",
-			"resolved": "https://registry.npmjs.org/@lmdb/lmdb-win32-x64/-/lmdb-win32-x64-3.5.4.tgz",
-			"integrity": "sha512-JF1BmLCm9kGEVZgYmJq43zeQVdHVgAJnTi/NURWEsy6L1ZrrlSmdltS+D17QN4LODwf+1LMXAA9auIZVXtWwzw==",
+			"version": "3.5.5",
+			"resolved": "https://registry.npmjs.org/@lmdb/lmdb-win32-x64/-/lmdb-win32-x64-3.5.5.tgz",
+			"integrity": "sha512-dkV3r04ro8MfhBaPj4ZsARy0LIP3sK+rm2LAuVe2QLCepBIpSzRx8p8RLWfRfkKV5YNyJ3c0NUJxGNMqtTB6Fg==",
 			"cpu": [
 				"x64"
 			],
@@ -7547,9 +7547,9 @@
 			"license": "MIT"
 		},
 		"node_modules/lmdb": {
-			"version": "3.5.4",
-			"resolved": "https://registry.npmjs.org/lmdb/-/lmdb-3.5.4.tgz",
-			"integrity": "sha512-9FKQA6G1MMtqNxfxvSBNXD/axeG2QRjYbNh0/ykRL5xYcRbCm2vXq7B9bhc7nSuKdHzr8/BHIwfPuYYH1UsXXw==",
+			"version": "3.5.5",
+			"resolved": "https://registry.npmjs.org/lmdb/-/lmdb-3.5.5.tgz",
+			"integrity": "sha512-e2q1RtHdJoDaQQNMJ55wJnD5BqpvzoJIEL3NBxfZXNBjYxY0QjCh3RSL/sqmi+y9l97cERdO4WwGFfYYVft1fA==",
 			"hasInstallScript": true,
 			"license": "MIT",
 			"dependencies": {
@@ -7564,13 +7564,13 @@
 				"download-lmdb-prebuilds": "bin/download-prebuilds.js"
 			},
 			"optionalDependencies": {
-				"@lmdb/lmdb-darwin-arm64": "3.5.4",
-				"@lmdb/lmdb-darwin-x64": "3.5.4",
-				"@lmdb/lmdb-linux-arm": "3.5.4",
-				"@lmdb/lmdb-linux-arm64": "3.5.4",
-				"@lmdb/lmdb-linux-x64": "3.5.4",
-				"@lmdb/lmdb-win32-arm64": "3.5.4",
-				"@lmdb/lmdb-win32-x64": "3.5.4"
+				"@lmdb/lmdb-darwin-arm64": "3.5.5",
+				"@lmdb/lmdb-darwin-x64": "3.5.5",
+				"@lmdb/lmdb-linux-arm": "3.5.5",
+				"@lmdb/lmdb-linux-arm64": "3.5.5",
+				"@lmdb/lmdb-linux-x64": "3.5.5",
+				"@lmdb/lmdb-win32-arm64": "3.5.5",
+				"@lmdb/lmdb-win32-x64": "3.5.5"
 			}
 		},
 		"node_modules/lmdb/node_modules/node-addon-api": {

package/core/resources/Table.ts

@@ -1441,6 +1441,7 @@ export function makeTable(options) {
 			const lmdbTransaction = txnForContext({ transaction: new DatabaseTransaction() });
 			let transaction = lmdbTransaction.getReadTxn();
 			let options = { transaction };
+			let committed = false;
 			try {
 				if (hasSourceGet || audit) {
 					if (!existingRecord) return;
@@ -1460,19 +1461,30 @@ export function makeTable(options) {
 					primaryStore.ifVersion?.(id, existingVersion, () => {
 						updateIndices(id, existingRecord, null);
 					});
-					return removeEntry(primaryStore, entry ?? primaryStore.getEntry(id), existingVersion);
+					removeEntry(primaryStore, entry ?? primaryStore.getEntry(id), existingVersion);
 				} else {
 					updateIndices(id, existingRecord, null, options);
-					return removeEntry(primaryStore, entry ?? primaryStore.getEntry(id), options);
+					removeEntry(primaryStore, entry ?? primaryStore.getEntry(id), options);
 				}
-			} finally {
+				committed = true;
 				if (primaryStore.ifVersion) {
 					// LMDB: committing the wrapper calls doneReadTxn(), removing it from trackedTxns
 					return lmdbTransaction.commit();
 				}
 				// RocksDB: eviction writes went directly into the raw transaction via options;
-				// commit it directly, as DatabaseTransaction.commit() would abort it (no tracked writes)
-				return transaction?.commit();
+				// commit it directly, as DatabaseTransaction.commit() would abort it (no tracked writes).
+				// Wrap in Promise.resolve so callers can rely on a thenable return regardless of engine.
+				return Promise.resolve((transaction as any).commit());
+			} finally {
+				if (!committed) {
+					// Skip path or thrown error: abort instead of committing so we don't apply
+					// partial work and the txn handle is released.
+					if (primaryStore.ifVersion) {
+						(lmdbTransaction as any).abort?.();
+					} else {
+						(transaction as any)?.abort?.();
+					}
+				}
 			}
 		}
 		/**
@@ -4459,7 +4471,7 @@ export function makeTable(options) {
 										const { key, value: record, version, expiresAt, metadataFlags } = entry;
 										// if there is no auditing cleanup and we are tracking deletion, need to do cleanup of
 										// these deletion entries (LMDB audit cleanup has its own scheduled job for this)
-										let resolution: Promise<void>;
+										let resolution: Promise<void> | undefined;
 										if (record === null && removeDeletedRecords && version + auditRetention < Date.now()) {
 											// make sure it is still deleted when we do the removal
 											resolution = removeEntry(primaryStore, entry, version);

package/core/utility/logging/logRotator.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const { promises: fsProm, createReadStream, createWriteStream } = require('fs');
+const { promises: fsProm, createReadStream, createWriteStream, mkdirSync } = require('fs');
 const { createGzip } = require('zlib');
 const { promisify } = require('util');
 const { pipeline } = require('stream');
@@ -17,8 +17,6 @@ const { onStorageReclamation } = require('../../server/storageReclamation.ts');
 const LOG_AUDIT_INTERVAL = 60000;
 const INT_SIZE_UNDEFINED_MSG =
 	"'interval' and 'maxSize' are both undefined, to enable logging rotation at least one of these values must be defined in harperdb-config.yaml";
-const PATH_UNDEFINED_MSG =
-	"'logging.rotation.path' is undefined, to enable logging rotation set this value in harperdb-config.yaml";
 
 let lastRotationTime;
 let setIntervalId;
@@ -47,8 +45,9 @@ function logRotator({ logger, maxSize, interval, retention, enabled, path: rotat
 	}
 
 	if (!rotatedLogDir) {
-		throw new Error(PATH_UNDEFINED_MSG);
+		rotatedLogDir = path.join(path.dirname(logger.path), 'rotated');
 	}
+	mkdirSync(rotatedLogDir, { recursive: true });
 
 	// Convert maxSize param to bytes.
 	let maxBytes;

package/dist/core/resources/Table.js

@@ -1332,6 +1332,7 @@ function makeTable(options) {
             const lmdbTransaction = txnForContext({ transaction: new DatabaseTransaction_ts_1.DatabaseTransaction() });
             let transaction = lmdbTransaction.getReadTxn();
             let options = { transaction };
+            let committed = false;
             try {
                 if (hasSourceGet || audit) {
                     if (!existingRecord)
@@ -1355,21 +1356,33 @@ function makeTable(options) {
                     primaryStore.ifVersion?.(id, existingVersion, () => {
                         updateIndices(id, existingRecord, null);
                     });
-                    return (0, RecordEncoder_ts_1.removeEntry)(primaryStore, entry ?? primaryStore.getEntry(id), existingVersion);
+                    (0, RecordEncoder_ts_1.removeEntry)(primaryStore, entry ?? primaryStore.getEntry(id), existingVersion);
                 }
                 else {
                     updateIndices(id, existingRecord, null, options);
-                    return (0, RecordEncoder_ts_1.removeEntry)(primaryStore, entry ?? primaryStore.getEntry(id), options);
+                    (0, RecordEncoder_ts_1.removeEntry)(primaryStore, entry ?? primaryStore.getEntry(id), options);
                 }
-            }
-            finally {
+                committed = true;
                 if (primaryStore.ifVersion) {
                     // LMDB: committing the wrapper calls doneReadTxn(), removing it from trackedTxns
                     return lmdbTransaction.commit();
                 }
                 // RocksDB: eviction writes went directly into the raw transaction via options;
-                // commit it directly, as DatabaseTransaction.commit() would abort it (no tracked writes)
-                return transaction?.commit();
+                // commit it directly, as DatabaseTransaction.commit() would abort it (no tracked writes).
+                // Wrap in Promise.resolve so callers can rely on a thenable return regardless of engine.
+                return Promise.resolve(transaction.commit());
+            }
+            finally {
+                if (!committed) {
+                    // Skip path or thrown error: abort instead of committing so we don't apply
+                    // partial work and the txn handle is released.
+                    if (primaryStore.ifVersion) {
+                        lmdbTransaction.abort?.();
+                    }
+                    else {
+                        transaction?.abort?.();
+                    }
+                }
             }
         }
         /**