@harness-fe/mcp-server 4.0.0-next.1 → 4.0.0-next.3

package/src/openBrowser.test.ts

@@ -1,103 +0,0 @@
-import { describe, expect, it, vi } from 'vitest';
-import { openBrowser } from './openBrowser.js';
-
-/**
- * Unit tests for the cross-platform browser launcher. We mock both
- * `spawn` and the platform/env probes so the test runs deterministically
- * on any host — no actual browser windows pop open in CI.
- */
-describe('openBrowser', () => {
-    function spy() {
-        return vi.fn(() => ({
-            unref: vi.fn(),
-        }) as any);
-    }
-
-    it('uses `open` on darwin', () => {
-        const spawnFn = spy();
-        const out = openBrowser('https://example.test', {
-            platformOverride: 'darwin',
-            envOverride: {},
-            spawnOverride: spawnFn,
-        });
-        expect(out.opened).toBe(true);
-        expect(spawnFn).toHaveBeenCalledWith('open', ['https://example.test'], expect.any(Object));
-    });
-
-    it('uses `xdg-open` on linux', () => {
-        const spawnFn = spy();
-        const out = openBrowser('https://example.test', {
-            platformOverride: 'linux',
-            envOverride: {},
-            spawnOverride: spawnFn,
-        });
-        expect(out.opened).toBe(true);
-        expect(spawnFn).toHaveBeenCalledWith('xdg-open', ['https://example.test'], expect.any(Object));
-    });
-
-    it('uses `cmd /c start "" <url>` on win32 (empty title is required)', () => {
-        const spawnFn = spy();
-        const out = openBrowser('https://example.test', {
-            platformOverride: 'win32',
-            envOverride: {},
-            spawnOverride: spawnFn,
-        });
-        expect(out.opened).toBe(true);
-        expect(spawnFn).toHaveBeenCalledWith(
-            'cmd',
-            ['/c', 'start', '', 'https://example.test'],
-            expect.any(Object),
-        );
-    });
-
-    it('short-circuits when HARNESS_FE_HEADLESS=1 is set', () => {
-        const spawnFn = spy();
-        const out = openBrowser('https://example.test', {
-            platformOverride: 'darwin',
-            envOverride: { HARNESS_FE_HEADLESS: '1' },
-            spawnOverride: spawnFn,
-        });
-        expect(out.opened).toBe(false);
-        expect(out.reason).toMatch(/HEADLESS/);
-        expect(spawnFn).not.toHaveBeenCalled();
-    });
-
-    it('returns opened=false on unsupported platforms with a reason', () => {
-        const spawnFn = spy();
-        const out = openBrowser('https://example.test', {
-            platformOverride: 'freebsd' as NodeJS.Platform,
-            envOverride: {},
-            spawnOverride: spawnFn,
-        });
-        expect(out.opened).toBe(false);
-        expect(out.reason).toMatch(/unsupported platform/);
-        expect(spawnFn).not.toHaveBeenCalled();
-    });
-
-    it('catches spawn errors and returns opened=false', () => {
-        const spawnFn = vi.fn(() => {
-            throw new Error('ENOENT: no such file');
-        }) as unknown as typeof openBrowser['arguments'][1]['spawnOverride'];
-        const out = openBrowser('https://example.test', {
-            platformOverride: 'darwin',
-            envOverride: {},
-            spawnOverride: spawnFn as any,
-        });
-        expect(out.opened).toBe(false);
-        expect(out.reason).toMatch(/ENOENT/);
-    });
-
-    it('detaches and unrefs the child so it survives the parent exit', () => {
-        const unref = vi.fn();
-        const spawnFn = vi.fn(() => ({ unref })) as any;
-        openBrowser('https://example.test', {
-            platformOverride: 'darwin',
-            envOverride: {},
-            spawnOverride: spawnFn,
-        });
-        const opts = (spawnFn.mock.calls[0]?.[2] ?? {}) as { detached?: boolean; stdio?: string };
-        expect(opts.detached).toBe(true);
-        expect(opts.stdio).toBe('ignore');
-        expect(unref).toHaveBeenCalledOnce();
-    });
-});

package/src/openBrowser.ts

@@ -1,81 +0,0 @@
-/**
- * Cross-platform "open this URL in the user's default browser" — a tiny
- * wrapper around the OS-native command.
- *
- * Detection rules:
- *   - darwin → `open <url>`
- *   - linux  → `xdg-open <url>`
- *   - win32  → `cmd /c start "" <url>` (the empty title is required, otherwise `start` treats the URL as a title)
- *
- * Escape hatches:
- *   - `HARNESS_FE_HEADLESS=1` short-circuits and returns `false` without
- *     spawning anything — useful when the daemon runs in Docker / CI /
- *     remote host where there's no GUI to open
- *   - any other platform returns `false`
- *
- * The spawned process is detached and stdio'd to ignore so we don't
- * accidentally tie its lifetime to ours.
- */
-
-import { spawn } from 'node:child_process';
-
-export interface OpenBrowserOptions {
-    /** Inject an alternate `process.platform` value, for tests. */
-    platformOverride?: NodeJS.Platform;
-    /** Inject the env lookup, for tests. */
-    envOverride?: Record<string, string | undefined>;
-    /** Inject the spawn function, for tests. */
-    spawnOverride?: typeof spawn;
-}
-
-export interface OpenBrowserResult {
-    opened: boolean;
-    /** Set when `opened` is false to explain why. */
-    reason?: string;
-}
-
-export function openBrowser(url: string, opts: OpenBrowserOptions = {}): OpenBrowserResult {
-    const env = opts.envOverride ?? process.env;
-    if (env.HARNESS_FE_HEADLESS === '1') {
-        return { opened: false, reason: 'HARNESS_FE_HEADLESS=1' };
-    }
-    const platform = opts.platformOverride ?? process.platform;
-    const spawnFn = opts.spawnOverride ?? spawn;
-
-    let cmd: string;
-    let args: string[];
-    switch (platform) {
-        case 'darwin':
-            cmd = 'open';
-            args = [url];
-            break;
-        case 'linux':
-            cmd = 'xdg-open';
-            args = [url];
-            break;
-        case 'win32':
-            // `start` is a cmd builtin, not a standalone exe. The first
-            // empty-string arg is the window title — required, because
-            // otherwise `start "https://…"` treats the URL as the title
-            // and never opens anything.
-            cmd = 'cmd';
-            args = ['/c', 'start', '', url];
-            break;
-        default:
-            return { opened: false, reason: `unsupported platform: ${platform}` };
-    }
-
-    try {
-        const child = spawnFn(cmd, args, {
-            detached: true,
-            stdio: 'ignore',
-        });
-        child.unref();
-        return { opened: true };
-    } catch (err) {
-        return {
-            opened: false,
-            reason: err instanceof Error ? err.message : String(err),
-        };
-    }
-}

package/src/remoteBridge.test.ts

@@ -1,119 +0,0 @@
-import { describe, expect, it } from 'vitest';
-import { WebSocket } from 'ws';
-import { Bridge } from './bridge.js';
-import { RemoteBridge } from './remoteBridge.js';
-import type { Frame, HelloAckFrame, ResponseFrame } from '@harness-fe/protocol';
-
-async function spawnLeader(): Promise<Bridge> {
-    const bridge = new Bridge({ port: 0, host: '127.0.0.1', tasksFile: '', store: null });
-    await bridge.start();
-    return bridge;
-}
-
-function getPort(bridge: Bridge): number {
-    const port = bridge.getBoundPort();
-    if (!port) throw new Error('no address');
-    return port;
-}
-
-async function fakeRuntimeClient(
-    port: number,
-    tabId: string,
-): Promise<WebSocket> {
-    const ws = new WebSocket(`ws://127.0.0.1:${port}`);
-    await new Promise<void>((resolve, reject) => {
-        ws.once('open', () => resolve());
-        ws.once('error', reject);
-    });
-    ws.send(
-        JSON.stringify({
-            type: 'hello',
-            id: 'h-rc',
-            role: 'runtime-client',
-            projectId: 'demo',
-            tabId,
-            sessionId: 'sess-1',
-            page: { url: 'http://localhost:5173/', title: 'Demo' },
-        }),
-    );
-    await new Promise<HelloAckFrame>((resolve, reject) => {
-        const timer = setTimeout(() => reject(new Error('hello.ack timeout')), 1000);
-        ws.once('message', (raw) => {
-            clearTimeout(timer);
-            resolve(JSON.parse(raw.toString()) as HelloAckFrame);
-        });
-    });
-    return ws;
-}
-
-describe('RemoteBridge (follower → leader)', () => {
-    it('listTabs reflects tabs registered on the leader', async () => {
-        const leader = await spawnLeader();
-        try {
-            const port = getPort(leader);
-            const rc = await fakeRuntimeClient(port, 't-remote-1');
-
-            const follower = new RemoteBridge({ port, host: '127.0.0.1' });
-            await follower.connect();
-            try {
-                const tabs = await follower.listTabs();
-                expect(tabs).toHaveLength(1);
-                expect(tabs[0].tabId).toBe('t-remote-1');
-            } finally {
-                await follower.stop();
-                rc.close();
-            }
-        } finally {
-            await leader.stop();
-        }
-    });
-
-    it('sendCommand forwards through leader to runtime-client and returns the result', async () => {
-        const leader = await spawnLeader();
-        try {
-            const port = getPort(leader);
-            const rc = await fakeRuntimeClient(port, 't-remote-2');
-            // Echo: respond ok with { echoed: args }
-            rc.on('message', (raw) => {
-                const frame = JSON.parse(raw.toString()) as Frame;
-                if (frame.type !== 'command') return;
-                const reply: ResponseFrame = {
-                    type: 'response',
-                    id: frame.id,
-                    ok: true,
-                    result: { echoed: frame.args },
-                };
-                rc.send(JSON.stringify(reply));
-            });
-
-            const follower = new RemoteBridge({ port, host: '127.0.0.1' });
-            await follower.connect();
-            try {
-                const out = (await follower.sendCommand(
-                    'page.evaluate',
-                    { expr: '1+1' },
-                    { tabId: 't-remote-2' },
-                )) as { echoed: { expr: string } };
-                expect(out.echoed.expr).toBe('1+1');
-            } finally {
-                await follower.stop();
-                rc.close();
-            }
-        } finally {
-            await leader.stop();
-        }
-    });
-
-    it('rejects pending calls when leader disappears', async () => {
-        const leader = await spawnLeader();
-        const port = getPort(leader);
-        const follower = new RemoteBridge({ port, host: '127.0.0.1' });
-        await follower.connect();
-        // Issue a call with no runtime-client connected → leader will throw; we just
-        // need to confirm follower receives the propagated error frame cleanly.
-        const callPromise = follower.sendCommand('page.click', { selector: { css: '#x' } });
-        await expect(callPromise).rejects.toThrow(/no runtime-client|connection|closed/i);
-        await follower.stop();
-        await leader.stop();
-    });
-});